)]}'
{"libvirt/templates/bin/_libvirt.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"82e9fe29598d03b5115660cd6491be585d30df04","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    chown root:kvm /dev/kvm"},{"line_number":31,"context_line":"fi"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"if [ -n \"${LIBVIRT_CEPH_SECRET_UUID}\" ] ; then"},{"line_number":34,"context_line":"  libvirtd --listen \u0026"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  tmpsecret\u003d$(mktemp --suffix .xml)"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"7f515b1d_01f5b983","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":46},"updated":"2017-10-03 22:01:26.000000000","message":"I think we should be able to explicitly enable/disable ceph support - and error accordingly. This approach though neat makes me concerned we will confuse users when we silently don\u0027t try to setup ceph creds if incorrectly configured.","commit_id":"04d8ced3c4f96110400261e5e025a3c711306e9d"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"50e0e133980dcde3b06e0c6bffc4321837f58cef","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    chown root:kvm /dev/kvm"},{"line_number":31,"context_line":"fi"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"if [ -n \"${LIBVIRT_CEPH_SECRET_UUID}\" ] ; then"},{"line_number":34,"context_line":"  libvirtd --listen \u0026"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  tmpsecret\u003d$(mktemp --suffix .xml)"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"7f515b1d_b7a747a8","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":46},"in_reply_to":"7f515b1d_01f5b983","updated":"2017-10-03 23:35:16.000000000","message":"it\u0027s functionally equivalent surely... if ceph isn\u0027t enabled that var won\u0027t get pushed down","commit_id":"04d8ced3c4f96110400261e5e025a3c711306e9d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"3cdff42866adf713c512cf246fd4cfff8a37b679","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  tmpsecret\u003d$(mktemp --suffix .xml)"},{"line_number":37,"context_line":"  function cleanup {"},{"line_number":38,"context_line":"      rm -f \"${tmpsecret}\""},{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":"  trap cleanup EXIT"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"7f515b1d_a1db851f","line":38,"range":{"start_line":38,"start_character":12,"end_line":38,"end_character":26},"updated":"2017-10-03 21:58:39.000000000","message":"probably do not need the quotes since mktemp shouldn\u0027t generate strange chars.","commit_id":"04d8ced3c4f96110400261e5e025a3c711306e9d"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"50e0e133980dcde3b06e0c6bffc4321837f58cef","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  tmpsecret\u003d$(mktemp --suffix .xml)"},{"line_number":37,"context_line":"  function cleanup {"},{"line_number":38,"context_line":"      rm -f \"${tmpsecret}\""},{"line_number":39,"context_line":"  }"},{"line_number":40,"context_line":"  trap cleanup EXIT"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"7f515b1d_978d6b2c","line":38,"range":{"start_line":38,"start_character":12,"end_line":38,"end_character":26},"in_reply_to":"7f515b1d_a1db851f","updated":"2017-10-03 23:35:16.000000000","message":"what if TEMP and/or TMPDIR have a space?","commit_id":"04d8ced3c4f96110400261e5e025a3c711306e9d"}]}
