)]}'
{"id":"openstack%2Fopenstack-helm~509281","triplet_id":"openstack%2Fopenstack-helm~master~I5dbcbd393b18befd762518e3865da9e006cf5bd9","project":"openstack/openstack-helm","branch":"master","topic":"libvirt-fix-secret","hashtags":[],"change_id":"I5dbcbd393b18befd762518e3865da9e006cf5bd9","subject":"libvirt: fix secret so that volume attach works","status":"MERGED","created":"2017-10-03 20:36:53.000000000","updated":"2017-10-04 04:52:18.000000000","submitted":"2017-10-04 04:52:18.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"509281-1507092738218-c54c92a8","meta_rev_id":"eee13187f3f7fc4f3b7a66c4f1cb9f4c63116667","_number":509281,"virtual_id_number":509281,"owner":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2017-10-03 23:35:16.000000000","_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":2,"date":"2017-10-04 04:52:18.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"value":0,"date":"2017-10-03 21:14:16.000000000","_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"value":0,"_account_id":21307,"name":"Brandon B. Jozsa","email":"bjozsa@jinkit.com","username":"v1k0d3n"},{"value":0,"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"all":[{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":2,"date":"2017-10-04 04:48:33.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-10-04 01:40:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"value":0,"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"value":0,"_account_id":21307,"name":"Brandon B. Jozsa","email":"bjozsa@jinkit.com","username":"v1k0d3n"},{"value":0,"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"all":[{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":1,"date":"2017-10-04 04:48:33.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"date":"2017-10-03 20:47:34.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"value":0,"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"value":0,"date":"2017-10-03 20:47:50.000000000","_account_id":21307,"name":"Brandon B. Jozsa","email":"bjozsa@jinkit.com","username":"v1k0d3n"},{"value":0,"date":"2017-10-03 20:53:33.000000000","_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":21307,"name":"Brandon B. Jozsa","email":"bjozsa@jinkit.com","username":"v1k0d3n"},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-10-03 20:47:34.000000000","updated_by":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"reviewer":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"state":"REVIEWER"},{"updated":"2017-10-03 20:47:50.000000000","updated_by":{"_account_id":21307,"name":"Brandon B. Jozsa","email":"bjozsa@jinkit.com","username":"v1k0d3n"},"reviewer":{"_account_id":21307,"name":"Brandon B. Jozsa","email":"bjozsa@jinkit.com","username":"v1k0d3n"},"state":"REVIEWER"},{"updated":"2017-10-03 20:53:33.000000000","updated_by":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"reviewer":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"state":"REVIEWER"},{"updated":"2017-10-03 21:14:16.000000000","updated_by":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"reviewer":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"state":"REVIEWER"},{"updated":"2017-10-04 01:40:38.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2017-10-04 04:48:33.000000000","updated_by":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"reviewer":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"state":"REVIEWER"},{"updated":"2017-10-04 04:52:18.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b9f68737a98bbc55eefd5e309827d5108b6d37b3","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2017-10-03 20:36:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f34dd05f0737762a89de7eaae777ff2b0e75a4ac","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2017-10-03 20:37:02.000000000","message":"Patch Set 1:\n\nBuild Started http://10.24.20.18:30081/job/OSH/job/openstack/job/openstack-helm/job/basic/1415/","accounts_in_message":[],"_revision_number":1},{"id":"c28b011d8aae6ed97fb84f6b6584684e70cb4074","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2017-10-03 21:14:16.000000000","message":"Patch Set 1:\n\nBuild Successful \n\nhttp://12.37.173.196:32775/repository/att-comdev-jenkins-logs/openstack-helm/org.openstack.helm/1415/org.openstack.helm-1415.x-gtar : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"fcbe47ab63027fc89eadaea7fe0011c04f70044a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-03 21:26:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-helm-docs-ubuntu-xenial http://docs-draft.openstack.org/81/509281/1/check/gate-openstack-helm-docs-ubuntu-xenial/25c05ab//doc/build/html/ : SUCCESS in 3m 44s\n- gate-openstack-helm-nocluster-linter-ovs-rbd-ubuntu-xenial http://logs.openstack.org/81/509281/1/check/gate-openstack-helm-nocluster-linter-ovs-rbd-ubuntu-xenial/51a00b2/ : SUCCESS in 9m 08s\n- gate-openstack-helm-aio-basic-ovs-rbd-ubuntu-xenial-nv http://logs.openstack.org/81/509281/1/check/gate-openstack-helm-aio-basic-ovs-rbd-ubuntu-xenial-nv/02c05d7/ : FAILURE in 18m 58s (non-voting)\n- gate-openstack-helm-aio-basic-ovs-swift-ubuntu-xenial-nv http://logs.openstack.org/81/509281/1/check/gate-openstack-helm-aio-basic-ovs-swift-ubuntu-xenial-nv/2ec8ce1/ : FAILURE in 17m 14s (non-voting)\n- gate-openstack-helm-aio-basic-ovs-radosgw-ubuntu-xenial-nv http://logs.openstack.org/81/509281/1/check/gate-openstack-helm-aio-basic-ovs-radosgw-ubuntu-xenial-nv/ef88059/ : FAILURE in 18m 48s (non-voting)\n- gate-openstack-helm-aio-basic-ovs-pvc-ubuntu-xenial-nv http://logs.openstack.org/81/509281/1/check/gate-openstack-helm-aio-basic-ovs-pvc-ubuntu-xenial-nv/81e5e1f/ : FAILURE in 18m 32s (non-voting)\n- gate-openstack-helm-aio-basic-linuxbridge-rbd-ubuntu-xenial-nv http://logs.openstack.org/81/509281/1/check/gate-openstack-helm-aio-basic-linuxbridge-rbd-ubuntu-xenial-nv/d9be637/ : SUCCESS in 26m 24s (non-voting)\n- gate-openstack-helm-aio-basic-ovs-rbd-centos-7-nv http://logs.openstack.org/81/509281/1/check/gate-openstack-helm-aio-basic-ovs-rbd-centos-7-nv/2ccdbc5/ : FAILURE in 26m 51s (non-voting)\n- gate-openstack-helm-aio-basic-ovs-rbd-fedora-26-nv http://logs.openstack.org/81/509281/1/check/gate-openstack-helm-aio-basic-ovs-rbd-fedora-26-nv/31c38d2/ : FAILURE in 2m 19s (non-voting)\n- gate-openstack-helm-multi-basic-ovs-rbd-ubuntu-xenial-3-node-nv http://logs.openstack.org/81/509281/1/check/gate-openstack-helm-multi-basic-ovs-rbd-ubuntu-xenial-3-node-nv/11eff4e/ : SUCCESS in 46m 21s (non-voting)\n- gate-openstack-helm-multi-basic-linuxbridge-rbd-ubuntu-xenial-3-node-nv http://logs.openstack.org/81/509281/1/check/gate-openstack-helm-multi-basic-linuxbridge-rbd-ubuntu-xenial-3-node-nv/57d0de1/ : SUCCESS in 44m 15s (non-voting)\n- gate-openstack-helm-multi-armada-ovs-rbd-ubuntu-xenial-3-node-nv http://logs.openstack.org/81/509281/1/check/gate-openstack-helm-multi-armada-ovs-rbd-ubuntu-xenial-3-node-nv/eb65f9a/ : FAILURE in 16m 34s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"3cdff42866adf713c512cf246fd4cfff8a37b679","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2017-10-03 21:58:39.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"82e9fe29598d03b5115660cd6491be585d30df04","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2017-10-03 22:01:26.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"50e0e133980dcde3b06e0c6bffc4321837f58cef","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2017-10-03 23:35:16.000000000","message":"Patch Set 1:\n\n(2 comments)\n\ni don\u0027t think further changes are required\n\nunlike the existing code - this does actually work","accounts_in_message":[],"_revision_number":1},{"id":"2b12c366b1643dc9e78ce81fdfa9067f1a742ec0","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2017-10-04 01:40:38.000000000","message":"Patch Set 1: Code-Review+2\n\nFollowing offline discussion - LGTM - thanks chris :)","accounts_in_message":[],"_revision_number":1},{"id":"3a7abfabea67b04a247c24d508d8dfa6932e2154","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2017-10-04 04:48:33.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"64239d3c8dc62bb53c889990d2dfef030817f7e5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-04 04:48:46.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"3f8b03a832ab6fd8ebba28f5f98196505c807a25","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-04 04:52:18.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstack-helm-docs-ubuntu-xenial http://docs-draft.openstack.org/81/509281/1/gate/gate-openstack-helm-docs-ubuntu-xenial/ccde09b//doc/build/html/ : SUCCESS in 2m 20s\n- gate-openstack-helm-nocluster-linter-ovs-rbd-ubuntu-xenial http://logs.openstack.org/81/509281/1/gate/gate-openstack-helm-nocluster-linter-ovs-rbd-ubuntu-xenial/3e584a0/ : SUCCESS in 3m 03s","accounts_in_message":[],"_revision_number":1},{"id":"180c4a07df4239d1a4787ecfa1e519d256b52033","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-10-04 04:52:18.000000000","message":"Change has been successfully merged by Jenkins","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"04d8ced3c4f96110400261e5e025a3c711306e9d","revisions":{"04d8ced3c4f96110400261e5e025a3c711306e9d":{"kind":"REWORK","_number":1,"created":"2017-10-03 20:36:53.000000000","uploader":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"ref":"refs/changes/81/509281/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/81/509281/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/81/509281/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/81/509281/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/81/509281/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/81/509281/1"}}},"commit":{"parents":[{"commit":"2ca580a9b4319ac7fa8c28d4e2928e81294b874b","subject":"Merge \"gate: move \u0027root check\u0027 to setup\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/2ca580a9b4319ac7fa8c28d4e2928e81294b874b"}]}],"author":{"name":"Chris Wedgwood","email":"cw@f00f.org","date":"2017-10-03 20:35:37.000000000","tz":0},"committer":{"name":"Chris Wedgwood","email":"cw@f00f.org","date":"2017-10-03 20:35:37.000000000","tz":0},"subject":"libvirt: fix secret so that volume attach works","message":"libvirt: fix secret so that volume attach works\n\nIn addition to restoring the secret setting again this removes some\nredundant logic and does minimal cleanups.\n\nChange-Id: I5dbcbd393b18befd762518e3865da9e006cf5bd9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/04d8ced3c4f96110400261e5e025a3c711306e9d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/04d8ced3c4f96110400261e5e025a3c711306e9d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
