)]}'
{"neutron/templates/daemonset-lb-agent.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"a2e4058e43e3c3a64ee87043f30747e9bab2a27e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"              mountPath: /tmp/neutron-linuxbridge-agent-init-modules.sh"},{"line_number":56,"context_line":"              subPath: neutron-linuxbridge-agent-init-modules.sh"},{"line_number":57,"context_line":"              readOnly: true"},{"line_number":58,"context_line":"            - name: rootfs"},{"line_number":59,"context_line":"              mountPath: /mnt/rootfs"},{"line_number":60,"context_line":"              readOnly: true"},{"line_number":61,"context_line":"        - name: neutron-lb-agent-init"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f4e5783_42243caf","line":58,"updated":"2017-10-15 22:38:18.000000000","message":"name, rootfs -\u003e hostrootfs?\n\nalso what if /lib is on a diff mp to / ?\nwe\u0027ll get / but not /lib","commit_id":"8e8f033e6749fcd7800526844117618a7a276fc0"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"63cb8bda01cde0531fd5bfc96207d4a58adbc9cf","unresolved":false,"context_lines":[{"line_number":55,"context_line":"              mountPath: /tmp/neutron-linuxbridge-agent-init-modules.sh"},{"line_number":56,"context_line":"              subPath: neutron-linuxbridge-agent-init-modules.sh"},{"line_number":57,"context_line":"              readOnly: true"},{"line_number":58,"context_line":"            - name: rootfs"},{"line_number":59,"context_line":"              mountPath: /mnt/rootfs"},{"line_number":60,"context_line":"              readOnly: true"},{"line_number":61,"context_line":"        - name: neutron-lb-agent-init"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f4b6375_1ff9947f","line":58,"in_reply_to":"5f4e5783_42243caf","updated":"2017-10-18 13:43:14.000000000","message":"Will rename the mount. As with docker you are not doing a true mount, /lib (and others) should be retained - I have checked this on my systems to confirm.","commit_id":"8e8f033e6749fcd7800526844117618a7a276fc0"}],"openvswitch/templates/bin/_openvswitch-vswitchd-init-modules.sh.tpl":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"a2e4058e43e3c3a64ee87043f30747e9bab2a27e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"set -ex"},{"line_number":20,"context_line":"chroot /mnt/rootfs modprobe openvswitch"},{"line_number":21,"context_line":"chroot /mnt/rootfs modprobe gre"},{"line_number":22,"context_line":"chroot /mnt/rootfs modprobe vxlan"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"5f4e5783_c22f0c86","line":20,"updated":"2017-10-15 22:38:18.000000000","message":"we\u0027re quite sure PATH is robust enough that we don\u0027t need /sbin/modprobe (or perhaps that varies?)","commit_id":"8e8f033e6749fcd7800526844117618a7a276fc0"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"63cb8bda01cde0531fd5bfc96207d4a58adbc9cf","unresolved":false,"context_lines":[{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"set -ex"},{"line_number":20,"context_line":"chroot /mnt/rootfs modprobe openvswitch"},{"line_number":21,"context_line":"chroot /mnt/rootfs modprobe gre"},{"line_number":22,"context_line":"chroot /mnt/rootfs modprobe vxlan"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"3f4b6375_df753cfc","line":20,"in_reply_to":"5f4e5783_c22f0c86","updated":"2017-10-18 13:43:14.000000000","message":"I think that $PATH is preferable here, as it does sometimes vary as its\u0027 just a link to kmod.","commit_id":"8e8f033e6749fcd7800526844117618a7a276fc0"}],"tools/gate/funcs/common.sh":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"a2e4058e43e3c3a64ee87043f30747e9bab2a27e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  # NOTE(portdirect): Temp workaround until module loading is supported by"},{"line_number":74,"context_line":"  # OpenStack-Helm in Fedora"},{"line_number":75,"context_line":"  if [ \"x$HOST_OS\" \u003d\u003d \"xfedora\" ]; then"},{"line_number":76,"context_line":"    sudo modprobe ip6_tables"},{"line_number":77,"context_line":"  fi"},{"line_number":78,"context_line":"}"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"5f4e5783_82535417","line":76,"updated":"2017-10-15 22:38:18.000000000","message":"why did we leave this here when we moved the others?","commit_id":"8e8f033e6749fcd7800526844117618a7a276fc0"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"63cb8bda01cde0531fd5bfc96207d4a58adbc9cf","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  # NOTE(portdirect): Temp workaround until module loading is supported by"},{"line_number":74,"context_line":"  # OpenStack-Helm in Fedora"},{"line_number":75,"context_line":"  if [ \"x$HOST_OS\" \u003d\u003d \"xfedora\" ]; then"},{"line_number":76,"context_line":"    sudo modprobe ip6_tables"},{"line_number":77,"context_line":"  fi"},{"line_number":78,"context_line":"}"},{"line_number":79,"context_line":""}],"source_content_type":"text/x-sh","patch_set":8,"id":"3f4b6375_9f622416","line":76,"in_reply_to":"5f4e5783_82535417","updated":"2017-10-18 13:43:14.000000000","message":"This module is used by the openvswitch and lb agents as well as the l3 agent - as the l3 agent will only be running on nodes that already run the mechanism driver agents I\u0027ll move it to those two.","commit_id":"8e8f033e6749fcd7800526844117618a7a276fc0"}]}
