)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"1bc3aa07233c730b62cb58a4258e563852aa13cd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Grzegorz Grasza (xek) \u003cgrzegorz.grasza@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-10-11 08:59:17 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Support services in different namespaces"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This passes the service namespace to kubernetes-entrypoint in"},{"line_number":10,"context_line":"order to support dependencies between namespaces."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f4e5783_4c061d89","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"updated":"2017-10-11 10:47:06.000000000","message":"Seems like it is working now, we can remove the \u0027WIP\u0027.","commit_id":"5779e56eca226e527e2459c6b44fec01b8bbedf8"}],"helm-toolkit/templates/endpoints/_hostname_short_endpoint_with_namespace_lookup.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"3b70da7c48f6f74c53ccc583ee570924c5f3a108","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5f4e5783_e29df666","updated":"2017-10-10 14:23:00.000000000","message":"how does this differ from: https://github.com/openstack/openstack-helm/blob/master/helm-toolkit/templates/endpoints/_hostname_namespaced_endpoint_lookup.tpl ?","commit_id":"3d2914bbc18cf925db6de2e1242d8136c0dbfa3b"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"aff2183ddf930b30db308d2fe57410744ddea47f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5f4e5783_8bf3df9e","in_reply_to":"5f4e5783_e29df666","updated":"2017-10-11 09:00:35.000000000","message":"It returns the endpoint name with endpoint namespace for kubernetes entrypoint (this revision is buggy, see the latest version).","commit_id":"3d2914bbc18cf925db6de2e1242d8136c0dbfa3b"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"1bc3aa07233c730b62cb58a4258e563852aa13cd","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# This function returns hostnames from endpoint definitions for use cases"},{"line_number":18,"context_line":"# where the uri style return is not appropriate, and only the short hostname or"},{"line_number":19,"context_line":"# kubernetes servicename is used or relevant in the template:"},{"line_number":20,"context_line":"# { tuple \"memcache\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }"},{"line_number":21,"context_line":"# returns: the short internal hostname, which will also match the service name"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{- define \"helm-toolkit.endpoints.hostname_short_endpoint_with_namespace_lookup\" -}}"},{"line_number":24,"context_line":"{{- $type :\u003d index . 0 -}}"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"5f4e5783_6ca9d979","line":21,"range":{"start_line":17,"start_character":0,"end_line":21,"end_character":78},"updated":"2017-10-11 10:47:06.000000000","message":"Rewrite this comment to reflect what is really done by this function.","commit_id":"5779e56eca226e527e2459c6b44fec01b8bbedf8"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"324f736d9faf6c256a483075b5dbeeef99351310","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# This function returns hostnames from endpoint definitions for use cases"},{"line_number":18,"context_line":"# where the uri style return is not appropriate, and only the short hostname or"},{"line_number":19,"context_line":"# kubernetes servicename is used or relevant in the template:"},{"line_number":20,"context_line":"# { tuple \"memcache\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }"},{"line_number":21,"context_line":"# returns: the short internal hostname, which will also match the service name"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{- define \"helm-toolkit.endpoints.hostname_short_endpoint_with_namespace_lookup\" -}}"},{"line_number":24,"context_line":"{{- $type :\u003d index . 0 -}}"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"5f4e5783_d70ef039","line":21,"range":{"start_line":17,"start_character":0,"end_line":21,"end_character":78},"in_reply_to":"5f4e5783_6ca9d979","updated":"2017-10-12 15:55:04.000000000","message":"Done","commit_id":"5779e56eca226e527e2459c6b44fec01b8bbedf8"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"1bc3aa07233c730b62cb58a4258e563852aa13cd","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# { tuple \"memcache\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }"},{"line_number":21,"context_line":"# returns: the short internal hostname, which will also match the service name"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{- define \"helm-toolkit.endpoints.hostname_short_endpoint_with_namespace_lookup\" -}}"},{"line_number":24,"context_line":"{{- $type :\u003d index . 0 -}}"},{"line_number":25,"context_line":"{{- $endpoint :\u003d index . 1 -}}"},{"line_number":26,"context_line":"{{- $context :\u003d index . 2 -}}"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"5f4e5783_ac3b5136","line":23,"range":{"start_line":23,"start_character":35,"end_line":23,"end_character":80},"updated":"2017-10-11 10:47:06.000000000","message":"this function should be named differently, for example:\nservice_short_endpoint_with_namespace_lookup\n\nI do not understand why it is called \u0027hostname\u0027 in the first place?","commit_id":"5779e56eca226e527e2459c6b44fec01b8bbedf8"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"324f736d9faf6c256a483075b5dbeeef99351310","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# { tuple \"memcache\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }"},{"line_number":21,"context_line":"# returns: the short internal hostname, which will also match the service name"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{- define \"helm-toolkit.endpoints.hostname_short_endpoint_with_namespace_lookup\" -}}"},{"line_number":24,"context_line":"{{- $type :\u003d index . 0 -}}"},{"line_number":25,"context_line":"{{- $endpoint :\u003d index . 1 -}}"},{"line_number":26,"context_line":"{{- $context :\u003d index . 2 -}}"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"5f4e5783_f717ac50","line":23,"range":{"start_line":23,"start_character":35,"end_line":23,"end_character":80},"in_reply_to":"5f4e5783_5945bcb2","updated":"2017-10-12 15:55:04.000000000","message":"Done","commit_id":"5779e56eca226e527e2459c6b44fec01b8bbedf8"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"8859863a3d369293013b5cbd491ca8fea0a09cbb","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# { tuple \"memcache\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }"},{"line_number":21,"context_line":"# returns: the short internal hostname, which will also match the service name"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{- define \"helm-toolkit.endpoints.hostname_short_endpoint_with_namespace_lookup\" -}}"},{"line_number":24,"context_line":"{{- $type :\u003d index . 0 -}}"},{"line_number":25,"context_line":"{{- $endpoint :\u003d index . 1 -}}"},{"line_number":26,"context_line":"{{- $context :\u003d index . 2 -}}"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"5f4e5783_5945bcb2","line":23,"range":{"start_line":23,"start_character":35,"end_line":23,"end_character":80},"in_reply_to":"5f4e5783_ac3b5136","updated":"2017-10-11 13:11:12.000000000","message":"Agree with Artur, this is what caused my confusion in the 1st ps.","commit_id":"5779e56eca226e527e2459c6b44fec01b8bbedf8"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"1bc3aa07233c730b62cb58a4258e563852aa13cd","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# returns: the short internal hostname, which will also match the service name"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{- define \"helm-toolkit.endpoints.hostname_short_endpoint_with_namespace_lookup\" -}}"},{"line_number":24,"context_line":"{{- $type :\u003d index . 0 -}}"},{"line_number":25,"context_line":"{{- $endpoint :\u003d index . 1 -}}"},{"line_number":26,"context_line":"{{- $context :\u003d index . 2 -}}"},{"line_number":27,"context_line":"{{- $typeYamlSafe :\u003d $type | replace \"-\" \"_\" }}"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"5f4e5783_ec882920","line":24,"range":{"start_line":24,"start_character":5,"end_line":24,"end_character":9},"updated":"2017-10-11 10:47:06.000000000","message":"This variable can be named \u0027service\u0027, since it is its content.","commit_id":"5779e56eca226e527e2459c6b44fec01b8bbedf8"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"1bc3aa07233c730b62cb58a4258e563852aa13cd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{{- with $endpointMap -}}"},{"line_number":30,"context_line":"{{- $endpointScheme :\u003d .scheme }}"},{"line_number":31,"context_line":"{{- $endpointHost :\u003d index .hosts $endpoint | default .hosts.default}}"},{"line_number":32,"context_line":"{{- $endpointHostname :\u003d printf \"%s\" $endpointHost }}"},{"line_number":33,"context_line":"{{- $endpointNamespace :\u003d $endpointMap.namespace | default $context.Release.Namespace }}"},{"line_number":34,"context_line":"{{- printf \"%s:%s\" $endpointNamespace $endpointHostname -}}"},{"line_number":35,"context_line":"{{- end -}}"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"5f4e5783_eceb89ad","line":32,"range":{"start_line":32,"start_character":5,"end_line":32,"end_character":21},"updated":"2017-10-11 10:47:06.000000000","message":"Why this is called Hostname? Can it be called \u0027endpointName\u0027?","commit_id":"5779e56eca226e527e2459c6b44fec01b8bbedf8"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"324f736d9faf6c256a483075b5dbeeef99351310","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{{- with $endpointMap -}}"},{"line_number":30,"context_line":"{{- $endpointScheme :\u003d .scheme }}"},{"line_number":31,"context_line":"{{- $endpointHost :\u003d index .hosts $endpoint | default .hosts.default}}"},{"line_number":32,"context_line":"{{- $endpointHostname :\u003d printf \"%s\" $endpointHost }}"},{"line_number":33,"context_line":"{{- $endpointNamespace :\u003d $endpointMap.namespace | default $context.Release.Namespace }}"},{"line_number":34,"context_line":"{{- printf \"%s:%s\" $endpointNamespace $endpointHostname -}}"},{"line_number":35,"context_line":"{{- end -}}"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"5f4e5783_b7093432","line":32,"range":{"start_line":32,"start_character":5,"end_line":32,"end_character":21},"in_reply_to":"5f4e5783_eceb89ad","updated":"2017-10-12 15:55:04.000000000","message":"Done","commit_id":"5779e56eca226e527e2459c6b44fec01b8bbedf8"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"1bc3aa07233c730b62cb58a4258e563852aa13cd","unresolved":false,"context_lines":[{"line_number":30,"context_line":"{{- $endpointScheme :\u003d .scheme }}"},{"line_number":31,"context_line":"{{- $endpointHost :\u003d index .hosts $endpoint | default .hosts.default}}"},{"line_number":32,"context_line":"{{- $endpointHostname :\u003d printf \"%s\" $endpointHost }}"},{"line_number":33,"context_line":"{{- $endpointNamespace :\u003d $endpointMap.namespace | default $context.Release.Namespace }}"},{"line_number":34,"context_line":"{{- printf \"%s:%s\" $endpointNamespace $endpointHostname -}}"},{"line_number":35,"context_line":"{{- end -}}"},{"line_number":36,"context_line":"{{- end -}}"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"5f4e5783_ac911155","line":33,"range":{"start_line":33,"start_character":26,"end_line":33,"end_character":47},"updated":"2017-10-11 10:47:06.000000000","message":"Within scope modification we can access the namespace by simply using .namespace here.","commit_id":"5779e56eca226e527e2459c6b44fec01b8bbedf8"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"324f736d9faf6c256a483075b5dbeeef99351310","unresolved":false,"context_lines":[{"line_number":30,"context_line":"{{- $endpointScheme :\u003d .scheme }}"},{"line_number":31,"context_line":"{{- $endpointHost :\u003d index .hosts $endpoint | default .hosts.default}}"},{"line_number":32,"context_line":"{{- $endpointHostname :\u003d printf \"%s\" $endpointHost }}"},{"line_number":33,"context_line":"{{- $endpointNamespace :\u003d $endpointMap.namespace | default $context.Release.Namespace }}"},{"line_number":34,"context_line":"{{- printf \"%s:%s\" $endpointNamespace $endpointHostname -}}"},{"line_number":35,"context_line":"{{- end -}}"},{"line_number":36,"context_line":"{{- end -}}"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"5f4e5783_9708782c","line":33,"range":{"start_line":33,"start_character":26,"end_line":33,"end_character":47},"in_reply_to":"5f4e5783_ac911155","updated":"2017-10-12 15:55:04.000000000","message":"Done","commit_id":"5779e56eca226e527e2459c6b44fec01b8bbedf8"}],"helm-toolkit/templates/endpoints/_service_short_endpoint_with_namespace_lookup.tpl":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"eb1a234413f79f3721bc5e634b3c7aee6fd74a05","unresolved":false,"context_lines":[{"line_number":28,"context_line":"{{- with $endpointMap -}}"},{"line_number":29,"context_line":"{{- $endpointScheme :\u003d .scheme }}"},{"line_number":30,"context_line":"{{- $endpointHost :\u003d index .hosts $endpoint | default .hosts.default}}"},{"line_number":31,"context_line":"{{- $endpointName :\u003d printf \"%s\" $endpointHost }}"},{"line_number":32,"context_line":"{{- $endpointNamespace :\u003d .namespace | default $context.Release.Namespace }}"},{"line_number":33,"context_line":"{{- printf \"%s:%s\" $endpointNamespace $endpointName -}}"},{"line_number":34,"context_line":"{{- end -}}"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"5f4e5783_3a2c0401","line":31,"updated":"2017-10-12 19:49:36.000000000","message":"This line can be dropped and endpointHost can be used directly in line 33, meaning:\n{{- $endpointName :\u003d index .hosts $endpoint | default .hosts.default}}\n{{- $endpointNamespace :\u003d .namespace | default $context.Release.Namespace }}\n{{- printf \"%s:%s\" $endpointNamespace $endpointName -}}","commit_id":"4b1b80117f3f654ec9daaa1b33b1a2781c80cec2"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"411e935365ff2ee06ff5618eadbf8548802f43ad","unresolved":false,"context_lines":[{"line_number":28,"context_line":"{{- with $endpointMap -}}"},{"line_number":29,"context_line":"{{- $endpointScheme :\u003d .scheme }}"},{"line_number":30,"context_line":"{{- $endpointHost :\u003d index .hosts $endpoint | default .hosts.default}}"},{"line_number":31,"context_line":"{{- $endpointName :\u003d printf \"%s\" $endpointHost }}"},{"line_number":32,"context_line":"{{- $endpointNamespace :\u003d .namespace | default $context.Release.Namespace }}"},{"line_number":33,"context_line":"{{- printf \"%s:%s\" $endpointNamespace $endpointName -}}"},{"line_number":34,"context_line":"{{- end -}}"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"5f4e5783_d64c69c9","line":31,"in_reply_to":"5f4e5783_3a2c0401","updated":"2017-10-16 09:51:04.000000000","message":"Done","commit_id":"4b1b80117f3f654ec9daaa1b33b1a2781c80cec2"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"be1ba3c4323e8d656d766b20a72a36e5e3b17bfc","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# between different services in different namespaces."},{"line_number":20,"context_line":"# returns: the endpoint namespace and the service name, delimited by a colon"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{{- define \"helm-toolkit.endpoints.service_short_endpoint_with_namespace_lookup\" -}}"},{"line_number":23,"context_line":"{{- $type :\u003d index . 0 -}}"},{"line_number":24,"context_line":"{{- $endpoint :\u003d index . 1 -}}"},{"line_number":25,"context_line":"{{- $context :\u003d index . 2 -}}"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"5f4e5783_bfe8797b","line":22,"range":{"start_line":22,"start_character":43,"end_line":22,"end_character":48},"updated":"2017-10-17 15:00:18.000000000","message":"would `name` not be better here.\n\nie: `service_name_endpoint_and_namespace_lookup`","commit_id":"1002695b16cbabcdd01ed18f8d7a1b1d34c882d5"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"561ee69beba5dae942277b674550864cc3b86e89","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# between different services in different namespaces."},{"line_number":20,"context_line":"# returns: the endpoint namespace and the service name, delimited by a colon"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{{- define \"helm-toolkit.endpoints.service_short_endpoint_with_namespace_lookup\" -}}"},{"line_number":23,"context_line":"{{- $type :\u003d index . 0 -}}"},{"line_number":24,"context_line":"{{- $endpoint :\u003d index . 1 -}}"},{"line_number":25,"context_line":"{{- $context :\u003d index . 2 -}}"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"3f4b6375_9fa0e4a7","line":22,"range":{"start_line":22,"start_character":43,"end_line":22,"end_character":48},"in_reply_to":"5f4e5783_bfe8797b","updated":"2017-10-18 13:33:13.000000000","message":"Done","commit_id":"1002695b16cbabcdd01ed18f8d7a1b1d34c882d5"}],"helm-toolkit/templates/utils/_comma_joined_hostname_list.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"be1ba3c4323e8d656d766b20a72a36e5e3b17bfc","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- define \"helm-toolkit.utils.comma_joined_hostname_list\" -}}"},{"line_number":18,"context_line":"{{- $deps :\u003d index . 0 -}}"},{"line_number":19,"context_line":"{{- $envAll :\u003d index . 1 -}}"},{"line_number":20,"context_line":"{{- range $k, $v :\u003d $deps -}}{{- if $k -}},{{- end -}}{{ tuple $v.service $v.endpoint $envAll | include \"helm-toolkit.endpoints.service_short_endpoint_with_namespace_lookup\" }}{{- end -}}"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"5f4e5783_bf9d190b","line":17,"range":{"start_line":17,"start_character":31,"end_line":17,"end_character":57},"updated":"2017-10-17 15:00:18.000000000","message":"this should now be renamed to:\n`comma_joined_service_list`\n\nThough it would potentially also make sense to add this as a new function.","commit_id":"1002695b16cbabcdd01ed18f8d7a1b1d34c882d5"},{"author":{"_account_id":14250,"name":"Grzegorz Grasza","email":"xek@redhat.com","username":"xek"},"change_message_id":"561ee69beba5dae942277b674550864cc3b86e89","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- define \"helm-toolkit.utils.comma_joined_hostname_list\" -}}"},{"line_number":18,"context_line":"{{- $deps :\u003d index . 0 -}}"},{"line_number":19,"context_line":"{{- $envAll :\u003d index . 1 -}}"},{"line_number":20,"context_line":"{{- range $k, $v :\u003d $deps -}}{{- if $k -}},{{- end -}}{{ tuple $v.service $v.endpoint $envAll | include \"helm-toolkit.endpoints.service_short_endpoint_with_namespace_lookup\" }}{{- end -}}"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"3f4b6375_df53fce1","line":17,"range":{"start_line":17,"start_character":31,"end_line":17,"end_character":57},"in_reply_to":"5f4e5783_bf9d190b","updated":"2017-10-18 13:33:13.000000000","message":"It\u0027s used only in one place, so I\u0027m changing the name.","commit_id":"1002695b16cbabcdd01ed18f8d7a1b1d34c882d5"}]}
