)]}'
{"fluent-logging/Chart.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7eb445cc9624fae2079ebb779349adcb8ba5110c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"sources:"},{"line_number":21,"context_line":"  - https://github.com/fluent/fluentbit"},{"line_number":22,"context_line":"  - https://github.com/fluent/fluentd"},{"line_number":23,"context_line":"  - https://git.openstack.org/cgit/openstack/openstack-helm-addons"},{"line_number":24,"context_line":"maintainers:"},{"line_number":25,"context_line":"  - name: OpenStack-Helm Authors"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_a4c35057","line":23,"range":{"start_line":23,"start_character":45,"end_line":23,"end_character":66},"updated":"2017-10-31 17:32:25.000000000","message":"this should change to openstack-helm-infra, in anticipation of this chart being included as part of the infra services eventually","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"60d05d984f7ab0725a52f460c4daa503f5bb3354","unresolved":false,"context_lines":[{"line_number":20,"context_line":"sources:"},{"line_number":21,"context_line":"  - https://github.com/fluent/fluentbit"},{"line_number":22,"context_line":"  - https://github.com/fluent/fluentd"},{"line_number":23,"context_line":"  - https://git.openstack.org/cgit/openstack/openstack-helm-addons"},{"line_number":24,"context_line":"maintainers:"},{"line_number":25,"context_line":"  - name: OpenStack-Helm Authors"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_ada2fe98","line":23,"range":{"start_line":23,"start_character":45,"end_line":23,"end_character":66},"in_reply_to":"3f4b6375_a4c35057","updated":"2017-11-01 14:06:31.000000000","message":"Done","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"}],"fluent-logging/README.rst":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"25b86c73eb1aaa6236a646aa4a4b5d9a74f03cac","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Fluentd-logging"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"OpenStack-Helm defines a centralized logging mechanism to provide insight into"},{"line_number":5,"context_line":"the the state of the OpenStack services and infrastructure components as"},{"line_number":6,"context_line":"well as underlying kubernetes platform. Among the requirements for a logging"},{"line_number":7,"context_line":"platform, where log data can come from and where log data need to be delivered"},{"line_number":8,"context_line":"are very variable. To support various logging scenarios, OpenStack-Helm should"},{"line_number":9,"context_line":"provide a flexible mechanism to meet with certain operation needs. This chart"},{"line_number":10,"context_line":"proposes fast and lightweight log forwarder and full featured log aggregator"},{"line_number":11,"context_line":"complementing each other providing a flexible and reliable solution. Especially,"},{"line_number":12,"context_line":"Fluent-bit is proposed as a log forwarder and Fluentd is proposed as a main log"},{"line_number":13,"context_line":"aggregator and processor."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Mechanism"},{"line_number":17,"context_line":"---------"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Fluent-bit, Fluentd meet OpenStack-Helm\u0027s logging requirements for gathering,"},{"line_number":20,"context_line":"aggregating, and delivering of logged events. Flunt-bit runs as a daemonset on"},{"line_number":21,"context_line":"each node and mounts the /var/lib/docker/containers directory. The Docker"},{"line_number":22,"context_line":"container runtime engine directs events posted to stdout and stderr to this"},{"line_number":23,"context_line":"directory on the host. Fluent-bit then forward the contents of that directory to"},{"line_number":24,"context_line":"Fluentd. Fluentd runs as deployment at the designated nodes and expose service"},{"line_number":25,"context_line":"for Fluent-bit to foward logs. Fluentd should then apply the Logstash format to"},{"line_number":26,"context_line":"the logs. Fluentd can also write kubernetes and OpenStack metadata to the logs."},{"line_number":27,"context_line":"Fluentd will then forward the results to Elasticsearch and to optionally kafka."},{"line_number":28,"context_line":"Elasticsearch indexes the logs in a logstash-* index by default. kafka stores"},{"line_number":29,"context_line":"the logs in a \u0027logs\u0027 topic by default. Any external tool can then consume the"},{"line_number":30,"context_line":"\u0027logs\u0027 topic."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f485f77_e0682088","line":30,"range":{"start_line":1,"start_character":0,"end_line":30,"end_character":13},"updated":"2017-11-13 20:58:18.000000000","message":"This is a good write-up -- would it be possible to put this somewhere in the docs tree instead?  I think it\u0027s important we accurately document the systems we use out of the box for OSH in the published docs instead of in the charts","commit_id":"71576152fdfe2f07a7846df8d0a99fbaab539f46"},{"author":{"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},"change_message_id":"b7f446f7f4d23e2012017c45b875f46fe5cc6dc6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Fluentd-logging"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"OpenStack-Helm defines a centralized logging mechanism to provide insight into"},{"line_number":5,"context_line":"the the state of the OpenStack services and infrastructure components as"},{"line_number":6,"context_line":"well as underlying kubernetes platform. Among the requirements for a logging"},{"line_number":7,"context_line":"platform, where log data can come from and where log data need to be delivered"},{"line_number":8,"context_line":"are very variable. To support various logging scenarios, OpenStack-Helm should"},{"line_number":9,"context_line":"provide a flexible mechanism to meet with certain operation needs. This chart"},{"line_number":10,"context_line":"proposes fast and lightweight log forwarder and full featured log aggregator"},{"line_number":11,"context_line":"complementing each other providing a flexible and reliable solution. Especially,"},{"line_number":12,"context_line":"Fluent-bit is proposed as a log forwarder and Fluentd is proposed as a main log"},{"line_number":13,"context_line":"aggregator and processor."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Mechanism"},{"line_number":17,"context_line":"---------"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Fluent-bit, Fluentd meet OpenStack-Helm\u0027s logging requirements for gathering,"},{"line_number":20,"context_line":"aggregating, and delivering of logged events. Flunt-bit runs as a daemonset on"},{"line_number":21,"context_line":"each node and mounts the /var/lib/docker/containers directory. The Docker"},{"line_number":22,"context_line":"container runtime engine directs events posted to stdout and stderr to this"},{"line_number":23,"context_line":"directory on the host. Fluent-bit then forward the contents of that directory to"},{"line_number":24,"context_line":"Fluentd. Fluentd runs as deployment at the designated nodes and expose service"},{"line_number":25,"context_line":"for Fluent-bit to foward logs. Fluentd should then apply the Logstash format to"},{"line_number":26,"context_line":"the logs. Fluentd can also write kubernetes and OpenStack metadata to the logs."},{"line_number":27,"context_line":"Fluentd will then forward the results to Elasticsearch and to optionally kafka."},{"line_number":28,"context_line":"Elasticsearch indexes the logs in a logstash-* index by default. kafka stores"},{"line_number":29,"context_line":"the logs in a \u0027logs\u0027 topic by default. Any external tool can then consume the"},{"line_number":30,"context_line":"\u0027logs\u0027 topic."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1f485f77_31579e05","line":30,"range":{"start_line":1,"start_character":0,"end_line":30,"end_character":13},"in_reply_to":"1f485f77_e0682088","updated":"2017-11-14 05:24:35.000000000","message":"https://review.openstack.org/519541 \nI did PS on documentation.","commit_id":"71576152fdfe2f07a7846df8d0a99fbaab539f46"}],"fluent-logging/templates/configmap-etc.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7eb445cc9624fae2079ebb779349adcb8ba5110c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"apiVersion: v1"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_64a318b3","line":16,"updated":"2017-10-31 17:32:25.000000000","message":"This needs the ability to be toggled enabled/disabled, like the other components","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"60d05d984f7ab0725a52f460c4daa503f5bb3354","unresolved":false,"context_lines":[{"line_number":13,"context_line":"See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":"apiVersion: v1"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_0d091294","line":16,"in_reply_to":"3f4b6375_64a318b3","updated":"2017-11-01 14:06:31.000000000","message":"Done","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"}],"fluent-logging/templates/daemonset-fluent-bit.yaml":[{"author":{"_account_id":11636,"name":"Mateusz Blaszkowski","email":"mateusz.blaszkowski@intel.com","username":"mateuszb"},"change_message_id":"d41a11b28069b71678bb8424d35834b5d6be4a01","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      labels:"},{"line_number":32,"context_line":"{{ tuple $envAll \"fluentbit\" \"daemon\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":33,"context_line":"      annotations:"},{"line_number":34,"context_line":"        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":35,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":36,"context_line":"    spec:"},{"line_number":37,"context_line":"      nodeSelector:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_97c804a6","line":34,"updated":"2017-10-26 06:53:19.000000000","message":"configmap-bin-hash is not used so this annotation should not be present","commit_id":"42802054ffe4769ee7be70eb2414820d7bf28863"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"8d0341458b4b0c24d70a0728d0d6c6d0855fafaa","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      labels:"},{"line_number":32,"context_line":"{{ tuple $envAll \"fluentbit\" \"daemon\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":33,"context_line":"      annotations:"},{"line_number":34,"context_line":"        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":35,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":36,"context_line":"    spec:"},{"line_number":37,"context_line":"      nodeSelector:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_7d9a09b9","line":34,"in_reply_to":"3f4b6375_97c804a6","updated":"2017-10-26 13:20:34.000000000","message":"Done","commit_id":"42802054ffe4769ee7be70eb2414820d7bf28863"},{"author":{"_account_id":11636,"name":"Mateusz Blaszkowski","email":"mateusz.blaszkowski@intel.com","username":"mateuszb"},"change_message_id":"d41a11b28069b71678bb8424d35834b5d6be4a01","unresolved":false,"context_lines":[{"line_number":65,"context_line":"          readOnly: true"},{"line_number":66,"context_line":"{{ if $mounts_fluentbit.volumeMounts }}{{ toYaml $mounts_fluentbit.volumeMounts | indent 8 }}{{ end }}"},{"line_number":67,"context_line":"      volumes:"},{"line_number":68,"context_line":"      - name: config"},{"line_number":69,"context_line":"        hostPath:"},{"line_number":70,"context_line":"          path: /tmp/ca"},{"line_number":71,"context_line":"      - name: varlog"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_57e5ec36","line":68,"updated":"2017-10-26 06:53:19.000000000","message":"Is this volume needed?","commit_id":"42802054ffe4769ee7be70eb2414820d7bf28863"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"8d0341458b4b0c24d70a0728d0d6c6d0855fafaa","unresolved":false,"context_lines":[{"line_number":65,"context_line":"          readOnly: true"},{"line_number":66,"context_line":"{{ if $mounts_fluentbit.volumeMounts }}{{ toYaml $mounts_fluentbit.volumeMounts | indent 8 }}{{ end }}"},{"line_number":67,"context_line":"      volumes:"},{"line_number":68,"context_line":"      - name: config"},{"line_number":69,"context_line":"        hostPath:"},{"line_number":70,"context_line":"          path: /tmp/ca"},{"line_number":71,"context_line":"      - name: varlog"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_7fac36ec","line":68,"in_reply_to":"3f4b6375_57e5ec36","updated":"2017-10-26 13:20:34.000000000","message":"Done","commit_id":"42802054ffe4769ee7be70eb2414820d7bf28863"}],"fluent-logging/templates/deployment-fluentd.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"6846ec3504c78cb5fc3063866a9d6917eadd833c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        image: {{ .Values.images.tags.fluentd }}"},{"line_number":51,"context_line":"        imagePullPolicy: {{ .Values.images.pull_policy }}"},{"line_number":52,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.fluentd | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":53,"context_line":"        command:"},{"line_number":54,"context_line":"        - /tmp/fluentd.sh"},{"line_number":55,"context_line":"        - start"},{"line_number":56,"context_line":"        volumeMounts:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_a71592e7","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":15},"updated":"2017-10-31 18:12:44.000000000","message":"There should be a port section to connect to the port defined in the service","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"60d05d984f7ab0725a52f460c4daa503f5bb3354","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        image: {{ .Values.images.tags.fluentd }}"},{"line_number":51,"context_line":"        imagePullPolicy: {{ .Values.images.pull_policy }}"},{"line_number":52,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.fluentd | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":53,"context_line":"        command:"},{"line_number":54,"context_line":"        - /tmp/fluentd.sh"},{"line_number":55,"context_line":"        - start"},{"line_number":56,"context_line":"        volumeMounts:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_668c237f","line":53,"range":{"start_line":53,"start_character":8,"end_line":53,"end_character":15},"in_reply_to":"3f4b6375_a71592e7","updated":"2017-11-01 14:06:31.000000000","message":"Done","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"e88f07ecbcb74b9f5c4c11f2ee2d3e11c2036761","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        volumeMounts:"},{"line_number":57,"context_line":"        - name: pod-etc-fluentd"},{"line_number":58,"context_line":"          mountPath: /etc/td-agent"},{"line_number":59,"context_line":"        - name: fluentd-etc"},{"line_number":60,"context_line":"          mountPath: /etc/td-agent/td-agent.conf"},{"line_number":61,"context_line":"          subPath: td-agent.conf"},{"line_number":62,"context_line":"          readOnly: true"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_f27c6621","line":59,"range":{"start_line":59,"start_character":16,"end_line":59,"end_character":27},"updated":"2017-10-31 18:55:05.000000000","message":"this should match the configmap name","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"60d05d984f7ab0725a52f460c4daa503f5bb3354","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        volumeMounts:"},{"line_number":57,"context_line":"        - name: pod-etc-fluentd"},{"line_number":58,"context_line":"          mountPath: /etc/td-agent"},{"line_number":59,"context_line":"        - name: fluentd-etc"},{"line_number":60,"context_line":"          mountPath: /etc/td-agent/td-agent.conf"},{"line_number":61,"context_line":"          subPath: td-agent.conf"},{"line_number":62,"context_line":"          readOnly: true"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_7063b9dd","line":59,"range":{"start_line":59,"start_character":16,"end_line":59,"end_character":27},"in_reply_to":"3f4b6375_f27c6621","updated":"2017-11-01 14:06:31.000000000","message":"Done","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7eb445cc9624fae2079ebb779349adcb8ba5110c","unresolved":false,"context_lines":[{"line_number":68,"context_line":"          mountPath: /tmp/producer.rb"},{"line_number":69,"context_line":"          subPath: producer.rb"},{"line_number":70,"context_line":"          readOnly: true"},{"line_number":71,"context_line":"        - name: fluent-logging-bin"},{"line_number":72,"context_line":"          mountPath: /tmp/client.rb"},{"line_number":73,"context_line":"          subPath: client.rb"},{"line_number":74,"context_line":"          readOnly: true"},{"line_number":75,"context_line":"{{- if .Values.conf.fluentd.kafka.enabled }}"},{"line_number":76,"context_line":"        - name: fluent-logging-bin"},{"line_number":77,"context_line":"          mountPath: /tmp/kafka_producer_ext.rb"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_047d841b","line":74,"range":{"start_line":71,"start_character":0,"end_line":74,"end_character":24},"updated":"2017-10-31 17:32:25.000000000","message":"This should be wrapped in the kafka_enabled conditional.  This is currently referenced from the fluent-logging-bin configmap, but isn\u0027t actually included in the configmap defined as part of this patchset.","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"60d05d984f7ab0725a52f460c4daa503f5bb3354","unresolved":false,"context_lines":[{"line_number":68,"context_line":"          mountPath: /tmp/producer.rb"},{"line_number":69,"context_line":"          subPath: producer.rb"},{"line_number":70,"context_line":"          readOnly: true"},{"line_number":71,"context_line":"        - name: fluent-logging-bin"},{"line_number":72,"context_line":"          mountPath: /tmp/client.rb"},{"line_number":73,"context_line":"          subPath: client.rb"},{"line_number":74,"context_line":"          readOnly: true"},{"line_number":75,"context_line":"{{- if .Values.conf.fluentd.kafka.enabled }}"},{"line_number":76,"context_line":"        - name: fluent-logging-bin"},{"line_number":77,"context_line":"          mountPath: /tmp/kafka_producer_ext.rb"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_d0ba6d6c","line":74,"range":{"start_line":71,"start_character":0,"end_line":74,"end_character":24},"in_reply_to":"3f4b6375_047d841b","updated":"2017-11-01 14:06:31.000000000","message":"Done","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7eb445cc9624fae2079ebb779349adcb8ba5110c","unresolved":false,"context_lines":[{"line_number":73,"context_line":"          subPath: client.rb"},{"line_number":74,"context_line":"          readOnly: true"},{"line_number":75,"context_line":"{{- if .Values.conf.fluentd.kafka.enabled }}"},{"line_number":76,"context_line":"        - name: fluent-logging-bin"},{"line_number":77,"context_line":"          mountPath: /tmp/kafka_producer_ext.rb"},{"line_number":78,"context_line":"          subPath: kafka_producer_ext.rb"},{"line_number":79,"context_line":"          readOnly: true"},{"line_number":80,"context_line":"{{- end }}"},{"line_number":81,"context_line":"{{- if $mounts_fluentd.volumeMounts }}{{ toYaml $mounts_fluentd.volumeMounts | indent 8 }}{{- end }}"},{"line_number":82,"context_line":"      volumes:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_c4764c3f","line":79,"range":{"start_line":76,"start_character":0,"end_line":79,"end_character":24},"updated":"2017-10-31 17:32:25.000000000","message":"This is also referenced from the fluent-logging-bin configmap, but does not appear in the confimap in this patchset.","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"60d05d984f7ab0725a52f460c4daa503f5bb3354","unresolved":false,"context_lines":[{"line_number":73,"context_line":"          subPath: client.rb"},{"line_number":74,"context_line":"          readOnly: true"},{"line_number":75,"context_line":"{{- if .Values.conf.fluentd.kafka.enabled }}"},{"line_number":76,"context_line":"        - name: fluent-logging-bin"},{"line_number":77,"context_line":"          mountPath: /tmp/kafka_producer_ext.rb"},{"line_number":78,"context_line":"          subPath: kafka_producer_ext.rb"},{"line_number":79,"context_line":"          readOnly: true"},{"line_number":80,"context_line":"{{- end }}"},{"line_number":81,"context_line":"{{- if $mounts_fluentd.volumeMounts }}{{ toYaml $mounts_fluentd.volumeMounts | indent 8 }}{{- end }}"},{"line_number":82,"context_line":"      volumes:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_b0b13192","line":79,"range":{"start_line":76,"start_character":0,"end_line":79,"end_character":24},"in_reply_to":"3f4b6375_c4764c3f","updated":"2017-11-01 14:06:31.000000000","message":"Done","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"e88f07ecbcb74b9f5c4c11f2ee2d3e11c2036761","unresolved":false,"context_lines":[{"line_number":82,"context_line":"      volumes:"},{"line_number":83,"context_line":"      - name: pod-etc-fluentd"},{"line_number":84,"context_line":"        emptyDir: {}"},{"line_number":85,"context_line":"      - name: fluentd-etc"},{"line_number":86,"context_line":"        configMap:"},{"line_number":87,"context_line":"          name: fluent-logging-etc"},{"line_number":88,"context_line":"          defaultMode: 0444"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_d2772a3b","line":85,"range":{"start_line":85,"start_character":14,"end_line":85,"end_character":25},"updated":"2017-10-31 18:55:05.000000000","message":"this should match the configmap name","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"60d05d984f7ab0725a52f460c4daa503f5bb3354","unresolved":false,"context_lines":[{"line_number":82,"context_line":"      volumes:"},{"line_number":83,"context_line":"      - name: pod-etc-fluentd"},{"line_number":84,"context_line":"        emptyDir: {}"},{"line_number":85,"context_line":"      - name: fluentd-etc"},{"line_number":86,"context_line":"        configMap:"},{"line_number":87,"context_line":"          name: fluent-logging-etc"},{"line_number":88,"context_line":"          defaultMode: 0444"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_3062e13f","line":85,"range":{"start_line":85,"start_character":14,"end_line":85,"end_character":25},"in_reply_to":"3f4b6375_d2772a3b","updated":"2017-11-01 14:06:31.000000000","message":"Done","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"}],"fluent-logging/templates/etc/_fluent-bit.conf.tpl":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7eb445cc9624fae2079ebb779349adcb8ba5110c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[SERVICE]"},{"line_number":2,"context_line":"    Flush          1"},{"line_number":3,"context_line":"    Daemon         Off"},{"line_number":4,"context_line":"    Log_Level      info"},{"line_number":5,"context_line":"    Parsers_File   parsers.conf"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[INPUT]"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"3f4b6375_848e1425","line":4,"range":{"start_line":4,"start_character":19,"end_line":4,"end_character":23},"updated":"2017-10-31 17:32:25.000000000","message":"This should be configurable","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"60d05d984f7ab0725a52f460c4daa503f5bb3354","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[SERVICE]"},{"line_number":2,"context_line":"    Flush          1"},{"line_number":3,"context_line":"    Daemon         Off"},{"line_number":4,"context_line":"    Log_Level      info"},{"line_number":5,"context_line":"    Parsers_File   parsers.conf"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[INPUT]"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"3f4b6375_cbae42e6","line":4,"range":{"start_line":4,"start_character":19,"end_line":4,"end_character":23},"in_reply_to":"3f4b6375_848e1425","updated":"2017-11-01 14:06:31.000000000","message":"Done","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"7eb445cc9624fae2079ebb779349adcb8ba5110c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    Path           /var/log/containers/*.log"},{"line_number":11,"context_line":"    Parser         docker"},{"line_number":12,"context_line":"    DB             /var/log/flb_kube.db"},{"line_number":13,"context_line":"    Mem_Buf_Limit  5MB"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[OUTPUT]"},{"line_number":16,"context_line":"    Name          forward"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"3f4b6375_04cb4453","line":13,"range":{"start_line":13,"start_character":19,"end_line":13,"end_character":22},"updated":"2017-10-31 17:32:25.000000000","message":"This should be configurable as well.","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"60d05d984f7ab0725a52f460c4daa503f5bb3354","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    Path           /var/log/containers/*.log"},{"line_number":11,"context_line":"    Parser         docker"},{"line_number":12,"context_line":"    DB             /var/log/flb_kube.db"},{"line_number":13,"context_line":"    Mem_Buf_Limit  5MB"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[OUTPUT]"},{"line_number":16,"context_line":"    Name          forward"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"3f4b6375_aba9c6dd","line":13,"range":{"start_line":13,"start_character":19,"end_line":13,"end_character":22},"in_reply_to":"3f4b6375_04cb4453","updated":"2017-11-01 14:06:31.000000000","message":"Done","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"}],"fluent-logging/templates/etc/_parsers.conf.tpl":[{"author":{"_account_id":11636,"name":"Mateusz Blaszkowski","email":"mateusz.blaszkowski@intel.com","username":"mateuszb"},"change_message_id":"d41a11b28069b71678bb8424d35834b5d6be4a01","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#lskjfoiwjfoijweoifjowiefjoweifoweifjowiejf"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[PARSER]"},{"line_number":4,"context_line":"    Name   apache"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3f4b6375_542deaa5","line":1,"updated":"2017-10-26 06:53:19.000000000","message":"Is it some kind of \"TBD\"? ;)","commit_id":"42802054ffe4769ee7be70eb2414820d7bf28863"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"8d0341458b4b0c24d70a0728d0d6c6d0855fafaa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#lskjfoiwjfoijweoifjowiefjoweifoweifjowiejf"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[PARSER]"},{"line_number":4,"context_line":"    Name   apache"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3f4b6375_dd045d17","line":1,"in_reply_to":"3f4b6375_542deaa5","updated":"2017-10-26 13:20:34.000000000","message":"Done","commit_id":"42802054ffe4769ee7be70eb2414820d7bf28863"},{"author":{"_account_id":11636,"name":"Mateusz Blaszkowski","email":"mateusz.blaszkowski@intel.com","username":"mateuszb"},"change_message_id":"d41a11b28069b71678bb8424d35834b5d6be4a01","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    Time_Format %d/%b/%Y:%H:%M:%S %z"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[PARSER]"},{"line_number":30,"context_line":"    Name   json-test"},{"line_number":31,"context_line":"    Format json"},{"line_number":32,"context_line":"    Time_Key time"},{"line_number":33,"context_line":"    Time_Format %d/%b/%Y:%H:%M:%S %z"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3f4b6375_1779b492","line":30,"updated":"2017-10-26 06:53:19.000000000","message":"Do we need all of these parsers? I assume only \u0027docker\u0027 is needed, is that right?","commit_id":"42802054ffe4769ee7be70eb2414820d7bf28863"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"8d0341458b4b0c24d70a0728d0d6c6d0855fafaa","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    Time_Format %d/%b/%Y:%H:%M:%S %z"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[PARSER]"},{"line_number":30,"context_line":"    Name   json-test"},{"line_number":31,"context_line":"    Format json"},{"line_number":32,"context_line":"    Time_Key time"},{"line_number":33,"context_line":"    Time_Format %d/%b/%Y:%H:%M:%S %z"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"3f4b6375_3d6251d9","line":30,"in_reply_to":"3f4b6375_1779b492","updated":"2017-10-26 13:20:34.000000000","message":"yes.\nI\u0027ll remove the others.","commit_id":"42802054ffe4769ee7be70eb2414820d7bf28863"}],"fluent-logging/templates/service-fluentd.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"84e6a3068534ad38741246d392c66621bdf19ea3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"apiVersion: v1"},{"line_number":21,"context_line":"kind: Service"},{"line_number":22,"context_line":"metadata:"},{"line_number":23,"context_line":"  name: {{ tuple \"aggregator\" \"fluentd\" . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":24,"context_line":"spec:"},{"line_number":25,"context_line":"  ports:"},{"line_number":26,"context_line":"  - name: {{ tuple \"aggregator\" \"fluentd\"  . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_c54db83e","line":23,"range":{"start_line":23,"start_character":17,"end_line":23,"end_character":39},"updated":"2017-10-25 17:54:57.000000000","message":"This should match the pattern for service names in the other services. Instead of \"fluentd\", this should be \"internal\"","commit_id":"42802054ffe4769ee7be70eb2414820d7bf28863"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"61e158f62a51f33fdaf73ac3ccd5cc41d266289d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"apiVersion: v1"},{"line_number":21,"context_line":"kind: Service"},{"line_number":22,"context_line":"metadata:"},{"line_number":23,"context_line":"  name: {{ tuple \"aggregator\" \"fluentd\" . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":24,"context_line":"spec:"},{"line_number":25,"context_line":"  ports:"},{"line_number":26,"context_line":"  - name: {{ tuple \"aggregator\" \"fluentd\"  . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_52950132","line":23,"range":{"start_line":23,"start_character":17,"end_line":23,"end_character":39},"in_reply_to":"3f4b6375_c54db83e","updated":"2017-10-26 06:53:46.000000000","message":"Done","commit_id":"42802054ffe4769ee7be70eb2414820d7bf28863"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"84e6a3068534ad38741246d392c66621bdf19ea3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  name: {{ tuple \"aggregator\" \"fluentd\" . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":24,"context_line":"spec:"},{"line_number":25,"context_line":"  ports:"},{"line_number":26,"context_line":"  - name: {{ tuple \"aggregator\" \"fluentd\"  . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":27,"context_line":"    port:  {{ tuple \"aggregator\" \"fluentd\" \"service\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":28,"context_line":"    {{ if .Values.network.fluentd.node_port.enabled }}"},{"line_number":29,"context_line":"    nodePort: {{ .Values.network.fluentd.node_port.port }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_05275066","line":26,"range":{"start_line":26,"start_character":10,"end_line":26,"end_character":113},"updated":"2017-10-25 17:54:57.000000000","message":"This should be the name of the port defined in the deployment.","commit_id":"42802054ffe4769ee7be70eb2414820d7bf28863"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"84e6a3068534ad38741246d392c66621bdf19ea3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  name: {{ tuple \"aggregator\" \"fluentd\" . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":24,"context_line":"spec:"},{"line_number":25,"context_line":"  ports:"},{"line_number":26,"context_line":"  - name: {{ tuple \"aggregator\" \"fluentd\"  . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":27,"context_line":"    port:  {{ tuple \"aggregator\" \"fluentd\" \"service\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":28,"context_line":"    {{ if .Values.network.fluentd.node_port.enabled }}"},{"line_number":29,"context_line":"    nodePort: {{ .Values.network.fluentd.node_port.port }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_850100b2","line":26,"range":{"start_line":26,"start_character":10,"end_line":26,"end_character":113},"updated":"2017-10-25 17:54:57.000000000","message":"This should match the name defined for the port in deployment-fluentd, which there seems to be none exposed via the definition","commit_id":"42802054ffe4769ee7be70eb2414820d7bf28863"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"61e158f62a51f33fdaf73ac3ccd5cc41d266289d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  name: {{ tuple \"aggregator\" \"fluentd\" . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":24,"context_line":"spec:"},{"line_number":25,"context_line":"  ports:"},{"line_number":26,"context_line":"  - name: {{ tuple \"aggregator\" \"fluentd\"  . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":27,"context_line":"    port:  {{ tuple \"aggregator\" \"fluentd\" \"service\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":28,"context_line":"    {{ if .Values.network.fluentd.node_port.enabled }}"},{"line_number":29,"context_line":"    nodePort: {{ .Values.network.fluentd.node_port.port }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_b2f2f598","line":26,"range":{"start_line":26,"start_character":10,"end_line":26,"end_character":113},"in_reply_to":"3f4b6375_05275066","updated":"2017-10-26 06:53:46.000000000","message":"Done","commit_id":"42802054ffe4769ee7be70eb2414820d7bf28863"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"61e158f62a51f33fdaf73ac3ccd5cc41d266289d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  name: {{ tuple \"aggregator\" \"fluentd\" . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":24,"context_line":"spec:"},{"line_number":25,"context_line":"  ports:"},{"line_number":26,"context_line":"  - name: {{ tuple \"aggregator\" \"fluentd\"  . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":27,"context_line":"    port:  {{ tuple \"aggregator\" \"fluentd\" \"service\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":28,"context_line":"    {{ if .Values.network.fluentd.node_port.enabled }}"},{"line_number":29,"context_line":"    nodePort: {{ .Values.network.fluentd.node_port.port }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_92edb9b8","line":26,"range":{"start_line":26,"start_character":10,"end_line":26,"end_character":113},"in_reply_to":"3f4b6375_850100b2","updated":"2017-10-26 06:53:46.000000000","message":"Done","commit_id":"42802054ffe4769ee7be70eb2414820d7bf28863"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"84e6a3068534ad38741246d392c66621bdf19ea3","unresolved":false,"context_lines":[{"line_number":24,"context_line":"spec:"},{"line_number":25,"context_line":"  ports:"},{"line_number":26,"context_line":"  - name: {{ tuple \"aggregator\" \"fluentd\"  . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":27,"context_line":"    port:  {{ tuple \"aggregator\" \"fluentd\" \"service\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":28,"context_line":"    {{ if .Values.network.fluentd.node_port.enabled }}"},{"line_number":29,"context_line":"    nodePort: {{ .Values.network.fluentd.node_port.port }}"},{"line_number":30,"context_line":"    {{ end }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_85b7c03a","line":27,"range":{"start_line":27,"start_character":11,"end_line":27,"end_character":113},"updated":"2017-10-25 17:54:57.000000000","message":"This should be referenced by network.fluentd.port instead","commit_id":"42802054ffe4769ee7be70eb2414820d7bf28863"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"61e158f62a51f33fdaf73ac3ccd5cc41d266289d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"spec:"},{"line_number":25,"context_line":"  ports:"},{"line_number":26,"context_line":"  - name: {{ tuple \"aggregator\" \"fluentd\"  . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":27,"context_line":"    port:  {{ tuple \"aggregator\" \"fluentd\" \"service\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":28,"context_line":"    {{ if .Values.network.fluentd.node_port.enabled }}"},{"line_number":29,"context_line":"    nodePort: {{ .Values.network.fluentd.node_port.port }}"},{"line_number":30,"context_line":"    {{ end }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_d7cafc9e","line":27,"range":{"start_line":27,"start_character":11,"end_line":27,"end_character":113},"in_reply_to":"3f4b6375_85b7c03a","updated":"2017-10-26 06:53:46.000000000","message":"I think that the way which brings port number using helm-toolkit mechanism is better. If I use a network.fluentd.port value, there will be duplicated values on values.yaml (network.fluentd.port and endpoints.aggregator.ports.service.internal)","commit_id":"42802054ffe4769ee7be70eb2414820d7bf28863"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"6846ec3504c78cb5fc3063866a9d6917eadd833c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  name: {{ tuple \"aggregator\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":24,"context_line":"spec:"},{"line_number":25,"context_line":"  ports:"},{"line_number":26,"context_line":"  - name: {{ tuple \"aggregator\" \"internal\"  . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":27,"context_line":"    port:  {{ tuple \"aggregator\" \"internal\" \"service\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":28,"context_line":"    {{ if .Values.network.fluentd.node_port.enabled }}"},{"line_number":29,"context_line":"    nodePort: {{ .Values.network.fluentd.node_port.port }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_4727fe65","line":26,"range":{"start_line":26,"start_character":10,"end_line":26,"end_character":114},"updated":"2017-10-31 18:12:44.000000000","message":"This should be a name other than the service name.","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"8899e8e300565daf81d2fd141e4cf075bfd2b6fa","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  name: {{ tuple \"aggregator\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":24,"context_line":"spec:"},{"line_number":25,"context_line":"  ports:"},{"line_number":26,"context_line":"  - name: {{ tuple \"aggregator\" \"internal\"  . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":27,"context_line":"    port:  {{ tuple \"aggregator\" \"internal\" \"service\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":28,"context_line":"    {{ if .Values.network.fluentd.node_port.enabled }}"},{"line_number":29,"context_line":"    nodePort: {{ .Values.network.fluentd.node_port.port }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_a0777fd4","line":26,"range":{"start_line":26,"start_character":10,"end_line":26,"end_character":114},"in_reply_to":"3f4b6375_4727fe65","updated":"2017-11-02 13:35:07.000000000","message":"Done","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"9fab8be1a32d23242b2e9cd8b92ddbf7796b13a9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"spec:"},{"line_number":25,"context_line":"  ports:"},{"line_number":26,"context_line":"  - name: {{ tuple \"aggregator\" \"internal\"  . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":27,"context_line":"    port:  {{ tuple \"aggregator\" \"internal\" \"service\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":28,"context_line":"    {{ if .Values.network.fluentd.node_port.enabled }}"},{"line_number":29,"context_line":"    nodePort: {{ .Values.network.fluentd.node_port.port }}"},{"line_number":30,"context_line":"    {{ end }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_1662363f","line":27,"range":{"start_line":27,"start_character":11,"end_line":27,"end_character":114},"updated":"2017-11-01 18:09:45.000000000","message":"Also, can this be handled like the other services?  Ex:  https://github.com/openstack/openstack-helm/blob/master/keystone/templates/service-api.yaml#L32","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"8899e8e300565daf81d2fd141e4cf075bfd2b6fa","unresolved":false,"context_lines":[{"line_number":24,"context_line":"spec:"},{"line_number":25,"context_line":"  ports:"},{"line_number":26,"context_line":"  - name: {{ tuple \"aggregator\" \"internal\"  . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":27,"context_line":"    port:  {{ tuple \"aggregator\" \"internal\" \"service\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":28,"context_line":"    {{ if .Values.network.fluentd.node_port.enabled }}"},{"line_number":29,"context_line":"    nodePort: {{ .Values.network.fluentd.node_port.port }}"},{"line_number":30,"context_line":"    {{ end }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_607d07b1","line":27,"range":{"start_line":27,"start_character":11,"end_line":27,"end_character":114},"in_reply_to":"3f4b6375_1662363f","updated":"2017-11-02 13:35:07.000000000","message":"Done","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"0e9500941846a814b9da7a6f1feb61511297e443","unresolved":false,"context_lines":[{"line_number":24,"context_line":"spec:"},{"line_number":25,"context_line":"  ports:"},{"line_number":26,"context_line":"  - name: aggregator"},{"line_number":27,"context_line":"    port:  {{ .Values.network.fluentd.port }}"},{"line_number":28,"context_line":"    {{ if .Values.network.fluentd.node_port.enabled }}"},{"line_number":29,"context_line":"    nodePort: {{ .Values.network.fluentd.node_port.port }}"},{"line_number":30,"context_line":"    {{ end }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f4b6375_1eecfd8d","line":27,"updated":"2017-11-08 14:35:49.000000000","message":"This needs to be entered in values.yaml","commit_id":"16f806eebba9d7e9febef6630da7643f9528f294"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"b19c72e0d9537f214d4173c147aff7d27a5744b1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"spec:"},{"line_number":25,"context_line":"  ports:"},{"line_number":26,"context_line":"  - name: aggregator"},{"line_number":27,"context_line":"    port:  {{ .Values.network.fluentd.port }}"},{"line_number":28,"context_line":"    {{ if .Values.network.fluentd.node_port.enabled }}"},{"line_number":29,"context_line":"    nodePort: {{ .Values.network.fluentd.node_port.port }}"},{"line_number":30,"context_line":"    {{ end }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f4b6375_16cbba4a","line":27,"in_reply_to":"3f4b6375_1eecfd8d","updated":"2017-11-09 02:12:01.000000000","message":"Done","commit_id":"16f806eebba9d7e9febef6630da7643f9528f294"}],"fluent-logging/values.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"84e6a3068534ad38741246d392c66621bdf19ea3","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"images:"},{"line_number":30,"context_line":"  fluentbit: docker.io/fluent/fluent-bit-kubernetes-daemonset:0.11"},{"line_number":31,"context_line":"  fluentd: docker.io/kolla/ubuntu-binary-fluentd:master"},{"line_number":32,"context_line":"  helm_tests: docker.io/kolla/ubuntu-source-elasticsearch:3.0.3"},{"line_number":33,"context_line":"  dep_check: docker.io/kolla/ubuntu-source-kubernetes-entrypoint:4.0.0"},{"line_number":34,"context_line":"  pull_policy: IfNotPresent"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_85e5803a","line":31,"range":{"start_line":31,"start_character":49,"end_line":31,"end_character":55},"updated":"2017-10-25 17:54:57.000000000","message":"Should be a stable tag and not master","commit_id":"42802054ffe4769ee7be70eb2414820d7bf28863"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"61e158f62a51f33fdaf73ac3ccd5cc41d266289d","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"images:"},{"line_number":30,"context_line":"  fluentbit: docker.io/fluent/fluent-bit-kubernetes-daemonset:0.11"},{"line_number":31,"context_line":"  fluentd: docker.io/kolla/ubuntu-binary-fluentd:master"},{"line_number":32,"context_line":"  helm_tests: docker.io/kolla/ubuntu-source-elasticsearch:3.0.3"},{"line_number":33,"context_line":"  dep_check: docker.io/kolla/ubuntu-source-kubernetes-entrypoint:4.0.0"},{"line_number":34,"context_line":"  pull_policy: IfNotPresent"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_d2c33188","line":31,"range":{"start_line":31,"start_character":49,"end_line":31,"end_character":55},"in_reply_to":"3f4b6375_85e5803a","updated":"2017-10-26 06:53:46.000000000","message":"Done","commit_id":"42802054ffe4769ee7be70eb2414820d7bf28863"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"84e6a3068534ad38741246d392c66621bdf19ea3","unresolved":false,"context_lines":[{"line_number":36,"context_line":"dependencies:"},{"line_number":37,"context_line":"  fluentd:"},{"line_number":38,"context_line":"    services:"},{"line_number":39,"context_line":"    - service: elasticsearch"},{"line_number":40,"context_line":"      endpoint: public"},{"line_number":41,"context_line":"  fluentd_with_kafka:"},{"line_number":42,"context_line":"    services:"},{"line_number":43,"context_line":"    - service: elasticsearch"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_a5e4fc0d","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":22},"updated":"2017-10-25 17:54:57.000000000","message":"This should check for an internal service endpoint, not public","commit_id":"42802054ffe4769ee7be70eb2414820d7bf28863"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"61e158f62a51f33fdaf73ac3ccd5cc41d266289d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"dependencies:"},{"line_number":37,"context_line":"  fluentd:"},{"line_number":38,"context_line":"    services:"},{"line_number":39,"context_line":"    - service: elasticsearch"},{"line_number":40,"context_line":"      endpoint: public"},{"line_number":41,"context_line":"  fluentd_with_kafka:"},{"line_number":42,"context_line":"    services:"},{"line_number":43,"context_line":"    - service: elasticsearch"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_b2be75fc","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":22},"in_reply_to":"3f4b6375_a5e4fc0d","updated":"2017-10-26 06:53:46.000000000","message":"Done","commit_id":"42802054ffe4769ee7be70eb2414820d7bf28863"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"84e6a3068534ad38741246d392c66621bdf19ea3","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  fluentbit:"},{"line_number":48,"context_line":"    services:"},{"line_number":49,"context_line":"    - service: aggregator"},{"line_number":50,"context_line":"      endpoint: fluentd"},{"line_number":51,"context_line":"  tests:"},{"line_number":52,"context_line":"    services:"},{"line_number":53,"context_line":"    - service: elasticsearch"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_25d92c56","line":50,"range":{"start_line":50,"start_character":6,"end_line":50,"end_character":23},"updated":"2017-10-25 17:54:57.000000000","message":"Once the service name is fixed, this should instead target \u0027endpoint: internal\u0027 to match the other services","commit_id":"42802054ffe4769ee7be70eb2414820d7bf28863"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"61e158f62a51f33fdaf73ac3ccd5cc41d266289d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  fluentbit:"},{"line_number":48,"context_line":"    services:"},{"line_number":49,"context_line":"    - service: aggregator"},{"line_number":50,"context_line":"      endpoint: fluentd"},{"line_number":51,"context_line":"  tests:"},{"line_number":52,"context_line":"    services:"},{"line_number":53,"context_line":"    - service: elasticsearch"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4b6375_92b93916","line":50,"range":{"start_line":50,"start_character":6,"end_line":50,"end_character":23},"in_reply_to":"3f4b6375_25d92c56","updated":"2017-10-26 06:53:46.000000000","message":"Done","commit_id":"42802054ffe4769ee7be70eb2414820d7bf28863"},{"author":{"_account_id":11636,"name":"Mateusz Blaszkowski","email":"mateusz.blaszkowski@intel.com","username":"mateuszb"},"change_message_id":"5eed18a2dcd828b0b7f7469e03c53023276af601","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  tags:"},{"line_number":31,"context_line":"    fluentbit: docker.io/fluent/fluent-bit-kubernetes-daemonset:0.11"},{"line_number":32,"context_line":"    fluentd: docker.io/kolla/ubuntu-binary-fluentd:4.0.0"},{"line_number":33,"context_line":"    dep_check: docker.io/kolla/ubuntu-source-kubernetes-entrypoint:4.0.0"},{"line_number":34,"context_line":"  pull_policy: IfNotPresent"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"dependencies:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f4b6375_150dbe34","line":33,"updated":"2017-10-31 07:34:58.000000000","message":"Should be changed to \u0027quay.io/stackanetes/kubernetes-entrypoint:v0.2.1\u0027","commit_id":"86026764a9a52b78bc6913ca9aaa05e1280c3935"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"a3b36e4c434c42b540de21709bc0dc304d5b5356","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  tags:"},{"line_number":31,"context_line":"    fluentbit: docker.io/fluent/fluent-bit-kubernetes-daemonset:0.11"},{"line_number":32,"context_line":"    fluentd: docker.io/kolla/ubuntu-binary-fluentd:4.0.0"},{"line_number":33,"context_line":"    dep_check: docker.io/kolla/ubuntu-source-kubernetes-entrypoint:4.0.0"},{"line_number":34,"context_line":"  pull_policy: IfNotPresent"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"dependencies:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f4b6375_ac910049","line":33,"in_reply_to":"3f4b6375_150dbe34","updated":"2017-10-31 13:09:41.000000000","message":"Done","commit_id":"86026764a9a52b78bc6913ca9aaa05e1280c3935"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"bde75e7086e1533c9d5c864c09d9b72401a789d8","unresolved":false,"context_lines":[{"line_number":83,"context_line":"      default: elasticsearch-logging"},{"line_number":84,"context_line":"      discovery: elasticsearch-discovery"},{"line_number":85,"context_line":"      public: elasticsearch"},{"line_number":86,"context_line":"      internal: elasticsearch-logging"},{"line_number":87,"context_line":"    host_fqdn_override:"},{"line_number":88,"context_line":"      default: null"},{"line_number":89,"context_line":"    path:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_12b4a2d0","line":86,"range":{"start_line":86,"start_character":0,"end_line":86,"end_character":37},"updated":"2017-10-31 18:57:40.000000000","message":"This isn\u0027t necessary.  the default entry should handle this via endpoint lookups","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"60d05d984f7ab0725a52f460c4daa503f5bb3354","unresolved":false,"context_lines":[{"line_number":83,"context_line":"      default: elasticsearch-logging"},{"line_number":84,"context_line":"      discovery: elasticsearch-discovery"},{"line_number":85,"context_line":"      public: elasticsearch"},{"line_number":86,"context_line":"      internal: elasticsearch-logging"},{"line_number":87,"context_line":"    host_fqdn_override:"},{"line_number":88,"context_line":"      default: null"},{"line_number":89,"context_line":"    path:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_ab454617","line":86,"range":{"start_line":86,"start_character":0,"end_line":86,"end_character":37},"in_reply_to":"3f4b6375_12b4a2d0","updated":"2017-11-01 14:06:31.000000000","message":"Done","commit_id":"296107b9831d811a668b96cea15b4ab0332d06ad"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"555848ff7eaf406284527a3ffaf7457579c1801e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"endpoints:"},{"line_number":82,"context_line":"  cluster_domain_suffix: cluster.local"},{"line_number":83,"context_line":"  elasticsearch:"},{"line_number":84,"context_line":"    name: elasticsearch"},{"line_number":85,"context_line":"    hosts:"},{"line_number":86,"context_line":"      data: elasticsearch-data"},{"line_number":87,"context_line":"      default: elasticsearch-logging"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f4b6375_f5241062","line":84,"range":{"start_line":84,"start_character":4,"end_line":84,"end_character":23},"updated":"2017-11-02 17:44:47.000000000","message":"needs a `namespace: null` key as well","commit_id":"684babfbed41156ec63257c51bd3acb086ca2926"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"9ad826feeebf58a1f6f3044fbcada3fae846674e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"endpoints:"},{"line_number":82,"context_line":"  cluster_domain_suffix: cluster.local"},{"line_number":83,"context_line":"  elasticsearch:"},{"line_number":84,"context_line":"    name: elasticsearch"},{"line_number":85,"context_line":"    hosts:"},{"line_number":86,"context_line":"      data: elasticsearch-data"},{"line_number":87,"context_line":"      default: elasticsearch-logging"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f4b6375_fed745be","line":84,"range":{"start_line":84,"start_character":4,"end_line":84,"end_character":23},"in_reply_to":"3f4b6375_f5241062","updated":"2017-11-03 01:05:03.000000000","message":"I fixed as your recommendation.\nbut I wonder what is done by the value","commit_id":"684babfbed41156ec63257c51bd3acb086ca2926"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"555848ff7eaf406284527a3ffaf7457579c1801e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    port:"},{"line_number":110,"context_line":"      service:"},{"line_number":111,"context_line":"        default: 9092"},{"line_number":112,"context_line":"  aggregator:"},{"line_number":113,"context_line":"    hosts:"},{"line_number":114,"context_line":"      default: fluentd-logging"},{"line_number":115,"context_line":"      internal: fluentd-logging"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f4b6375_551524e4","line":112,"range":{"start_line":112,"start_character":2,"end_line":112,"end_character":13},"updated":"2017-11-02 17:44:47.000000000","message":"needs keys for `name: fluentd` and `namespace: null` for endpoint lookups\n\nalso needs an entry for fqdn overrides: https://github.com/openstack/openstack-helm/blob/master/mariadb/values.yaml#L84","commit_id":"684babfbed41156ec63257c51bd3acb086ca2926"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"9ad826feeebf58a1f6f3044fbcada3fae846674e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    port:"},{"line_number":110,"context_line":"      service:"},{"line_number":111,"context_line":"        default: 9092"},{"line_number":112,"context_line":"  aggregator:"},{"line_number":113,"context_line":"    hosts:"},{"line_number":114,"context_line":"      default: fluentd-logging"},{"line_number":115,"context_line":"      internal: fluentd-logging"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f4b6375_9ef05169","line":112,"range":{"start_line":112,"start_character":2,"end_line":112,"end_character":13},"in_reply_to":"3f4b6375_551524e4","updated":"2017-11-03 01:05:03.000000000","message":"Done","commit_id":"684babfbed41156ec63257c51bd3acb086ca2926"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"25b86c73eb1aaa6236a646aa4a4b5d9a74f03cac","unresolved":false,"context_lines":[{"line_number":29,"context_line":"images:"},{"line_number":30,"context_line":"  tags:"},{"line_number":31,"context_line":"    fluentbit: docker.io/fluent/fluent-bit-kubernetes-daemonset:0.11"},{"line_number":32,"context_line":"    fluentd: docker.io/kolla/ubuntu-binary-fluentd:4.0.0"},{"line_number":33,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.2.1"},{"line_number":34,"context_line":"  pull_policy: IfNotPresent"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f485f77_77f633fc","line":32,"range":{"start_line":32,"start_character":29,"end_line":32,"end_character":56},"updated":"2017-11-13 20:58:18.000000000","message":"This should be the source image rather than the binary image","commit_id":"71576152fdfe2f07a7846df8d0a99fbaab539f46"},{"author":{"_account_id":26931,"name":"Sungil Im","email":"usnexp@gmail.com","username":"sungil"},"change_message_id":"e3a0cc96d8dd753e4b5e4d6e53976ee47ac62f55","unresolved":false,"context_lines":[{"line_number":29,"context_line":"images:"},{"line_number":30,"context_line":"  tags:"},{"line_number":31,"context_line":"    fluentbit: docker.io/fluent/fluent-bit-kubernetes-daemonset:0.11"},{"line_number":32,"context_line":"    fluentd: docker.io/kolla/ubuntu-binary-fluentd:4.0.0"},{"line_number":33,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.2.1"},{"line_number":34,"context_line":"  pull_policy: IfNotPresent"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f485f77_ddc0617f","line":32,"range":{"start_line":32,"start_character":29,"end_line":32,"end_character":56},"in_reply_to":"1f485f77_77f633fc","updated":"2017-11-14 06:34:53.000000000","message":"Done","commit_id":"71576152fdfe2f07a7846df8d0a99fbaab539f46"}]}