)]}'
{"id":"openstack%2Fopenstack-helm~518475","triplet_id":"openstack%2Fopenstack-helm~master~I002607baadb90c8b0da4332a9eb7ca8e6f598f9f","project":"openstack/openstack-helm","branch":"master","topic":"package_install","hashtags":[],"change_id":"I002607baadb90c8b0da4332a9eb7ca8e6f598f9f","subject":"Do not use “-y” for package install","status":"MERGED","created":"2017-11-08 07:34:43.000000000","updated":"2017-11-12 03:38:23.000000000","submitted":"2017-11-12 03:03:09.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"518475-1510455789631-daa754ec","meta_rev_id":"c3d12929c95960281005ac889cd79568495dbde6","_number":518475,"virtual_id_number":518475,"owner":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"date":"2017-11-08 08:09:37.000000000","_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"value":2,"date":"2017-11-12 03:03:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"all":[{"value":2,"date":"2017-11-12 02:58:07.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":2,"date":"2017-11-12 01:58:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"all":[{"value":1,"date":"2017-11-12 02:58:07.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-11-08 08:09:37.000000000","updated_by":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"reviewer":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"state":"REVIEWER"},{"updated":"2017-11-12 01:58:34.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2017-11-12 02:58:07.000000000","updated_by":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"reviewer":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"state":"REVIEWER"},{"updated":"2017-11-12 03:03:09.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"2a4714018a15cfaac040c33d7c58edd037c9f08e","author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"date":"2017-11-08 07:34:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2e9ffb1f67ab1fe757757414359aa7fae625de9f","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2017-11-08 07:34:50.000000000","message":"Patch Set 1:\n\nBuild Started http://10.24.20.18:30081/job/charts/job/openstack/job/openstack-helm/job/basic/2030/","accounts_in_message":[],"_revision_number":1},{"id":"aaa35c58275ec250c0bdbee0983d9af010fec6ba","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-08 07:38:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/75/518475/1/check/build-openstack-sphinx-docs/1433985/html/ : SUCCESS in 3m 18s\n- legacy-openstack-helm-nocluster-linter-ovs-rbd http://logs.openstack.org/75/518475/1/check/legacy-openstack-helm-nocluster-linter-ovs-rbd/c13c603/ : SUCCESS in 3m 26s","accounts_in_message":[],"_revision_number":1},{"id":"7e4f8c965530b5160fc52fa0b49e4af082dab205","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2017-11-08 08:09:37.000000000","message":"Patch Set 1:\n\nBuild Successful \n\nhttp://12.37.173.196:32775/repository/att-comdev-jenkins-logs/openstack-helm/org.openstack.helm/2030/org.openstack.helm-2030.x-gtar : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"bd735c285ba0484dd8009e8af9f34a4aaf081ac3","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2017-11-12 01:58:34.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"1c9ba70e56aee89be46f1d9b27577ec13211a7a1","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2017-11-12 02:58:07.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"6eea6e9b25d5a847659dfe888cc1e4cb2608136b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-12 02:58:18.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"86edcaa5b1972f06298be6b6bff7b278b56ac392","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-12 03:03:09.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"521737d59e9105d077ddce5d3a698dd74c33b089","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-12 03:03:09.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/75/518475/1/gate/build-openstack-sphinx-docs/5785913/html/ : SUCCESS in 3m 58s\n- legacy-openstack-helm-nocluster-linter-ovs-rbd http://logs.openstack.org/75/518475/1/gate/legacy-openstack-helm-nocluster-linter-ovs-rbd/104005d/ : SUCCESS in 3m 47s","accounts_in_message":[],"_revision_number":1},{"id":"431561c2e6a44db5dbfcbb1148065486f123746e","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2017-11-12 03:38:23.000000000","message":"Patch Set 1:\n\nBuild Successful \n\nhttp://12.37.173.196:32775/repository/att-comdev-jenkins-logs/openstack-helm/org.openstack.helm/2053/org.openstack.helm-2053.x-gtar : SUCCESS","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"fcd4b405ff8053e6153207929dce1da7c9c505da","revisions":{"fcd4b405ff8053e6153207929dce1da7c9c505da":{"kind":"REWORK","_number":1,"created":"2017-11-08 07:34:43.000000000","uploader":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"ref":"refs/changes/75/518475/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/75/518475/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/75/518475/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/75/518475/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/75/518475/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/75/518475/1"}}},"commit":{"parents":[{"commit":"ec86066a195cd6a7eef79e68a5b4fa5faf42cdc8","subject":"Docs: true-up to recent changes","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/ec86066a195cd6a7eef79e68a5b4fa5faf42cdc8"}]}],"author":{"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","date":"2017-11-08 07:34:33.000000000","tz":420},"committer":{"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","date":"2017-11-08 07:34:33.000000000","tz":420},"subject":"Do not use “-y” for package install","message":"Do not use “-y” for package install\n\nAccording to \"code conventions\" [1], do not use \"-y\" option.\nInstead, use apt-get install package, yum install package,\nor zypper install package.\n\n[1] https://docs.openstack.org/doc-contrib-guide/writing-style/\ncode-conventions.html\n\nChange-Id: I002607baadb90c8b0da4332a9eb7ca8e6f598f9f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/fcd4b405ff8053e6153207929dce1da7c9c505da"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/fcd4b405ff8053e6153207929dce1da7c9c505da"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}