)]}'
{"rabbitmq/requirements.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"e8650177f9b58eb05862d0afcf36ca4436a43876","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  - name: helm-toolkit"},{"line_number":17,"context_line":"    repository: http://localhost:8879/charts"},{"line_number":18,"context_line":"    version: 0.1.0"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f485f77_992530ae","line":19,"updated":"2017-11-15 10:47:01.000000000","message":"unintended change?  we do not need 2 blank EOF lines.","commit_id":"dcf0f0599ff71b702e126230441f6823c3abb745"}],"rabbitmq/templates/bin/_rabbitmq-check-helpers.sh.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"e8650177f9b58eb05862d0afcf36ca4436a43876","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":6,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":1,"id":"1f485f77_b970eca6","line":3,"updated":"2017-11-15 10:47:01.000000000","message":"We should leave the comment style as {{/* */}} so the template doesn\u0027t render the copy right license","commit_id":"dcf0f0599ff71b702e126230441f6823c3abb745"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"71de88c87331c5fc60400fd8a02fedaf394b281b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":"{{/*"},{"line_number":3,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":6,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":7,"context_line":"# You may obtain a copy of the License at"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"#     http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# Unless required by applicable law or agreed to in writing, software"},{"line_number":12,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":13,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":14,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":"*/}}"},{"line_number":17,"context_line":"# This is taken from https://github.com/openstack/fuel-ccp-rabbitmq/blob/master/service/files/rabbitmq-check-helpers.sh.j2"},{"line_number":18,"context_line":"MARKER_PATH\u003d/tmp/rabbit-startup-marker"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# How many seconds we give a node before successfull liveness checks"},{"line_number":21,"context_line":"# become mandatory."},{"line_number":22,"context_line":"FRESH_NODE_TIMEOUT\u003d{{ .Values.probes_delay }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LP\u003d\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"set-log-prefix() {"},{"line_number":27,"context_line":"    LP\u003d\"[${1:?}]\""},{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"log-it() {"},{"line_number":31,"context_line":"    echo \"$LP\" \"$@\""},{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"prepend-log-prefix() {"},{"line_number":35,"context_line":"    awk -v lp\u003d\"$LP\" \u0027{print lp \" \" $0}\u0027"},{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"marker-state() {"},{"line_number":39,"context_line":"    if [[ ! -f $MARKER_PATH ]]; then"},{"line_number":40,"context_line":"        echo \"missing\""},{"line_number":41,"context_line":"        return 0"},{"line_number":42,"context_line":"    fi"},{"line_number":43,"context_line":"    local marker_time"},{"line_number":44,"context_line":"    marker_time\u003d\"$(cat $MARKER_PATH)\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    local end_of_fresh_time\u003d$((FRESH_NODE_TIMEOUT + $marker_time))"},{"line_number":47,"context_line":"    local now"},{"line_number":48,"context_line":"    now\u003d$(date +%s)"},{"line_number":49,"context_line":"    if [[ $now -le $end_of_fresh_time ]]; then"},{"line_number":50,"context_line":"        echo \"fresh\""},{"line_number":51,"context_line":"        return 0"},{"line_number":52,"context_line":"    fi"},{"line_number":53,"context_line":"    echo \"stale\""},{"line_number":54,"context_line":"    return 0"},{"line_number":55,"context_line":"}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"ping-node() {"},{"line_number":58,"context_line":"    local result"},{"line_number":59,"context_line":"    result\u003d\"$(rabbitmqctl eval \u0027ok.\u0027 2\u003e\u00261)\""},{"line_number":60,"context_line":"    if [[ \"$result\" \u003d\u003d \"ok\" ]]; then"},{"line_number":61,"context_line":"        return 0"},{"line_number":62,"context_line":"    fi"},{"line_number":63,"context_line":"    log-it \"ping-node error:\""},{"line_number":64,"context_line":"    echo \"$result\" | prepend-log-prefix"},{"line_number":65,"context_line":"    return 1"},{"line_number":66,"context_line":"}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"is-node-booting() {"},{"line_number":69,"context_line":"    local result"},{"line_number":70,"context_line":"    result\u003d\"$(rabbitmqctl eval \u0027is_pid(erlang:whereis(rabbit_boot)).\u0027 2\u003e\u00261)\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    case \"$result\" in"},{"line_number":73,"context_line":"        true)"},{"line_number":74,"context_line":"            return 0"},{"line_number":75,"context_line":"            ;;"},{"line_number":76,"context_line":"        false)"},{"line_number":77,"context_line":"            return 1"},{"line_number":78,"context_line":"            ;;"},{"line_number":79,"context_line":"        *)"},{"line_number":80,"context_line":"            log-it \"is-node-booting error:\""},{"line_number":81,"context_line":"            echo \"$result\" | prepend-log-prefix"},{"line_number":82,"context_line":"            return 1"},{"line_number":83,"context_line":"            ;;"},{"line_number":84,"context_line":"    esac"},{"line_number":85,"context_line":"}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"is-node-healthy() {"},{"line_number":88,"context_line":"    local result"},{"line_number":89,"context_line":"    result\u003d$(rabbitmqctl node_health_check -t 30 2\u003e\u00261)"},{"line_number":90,"context_line":"    if [[ \"$result\" \u003d~ \"Health check passed\" ]]; then"},{"line_number":91,"context_line":"        return 0"},{"line_number":92,"context_line":"    fi"},{"line_number":93,"context_line":"    echo \"$result\" | prepend-log-prefix"},{"line_number":94,"context_line":"    return 1"},{"line_number":95,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":27,"id":"bf8cb3f7_43d07851","line":94,"range":{"start_line":1,"start_character":0,"end_line":94,"end_character":12},"updated":"2017-12-20 14:05:28.000000000","message":"This can be removed","commit_id":"015fc5b2507296b0c89d963ae0969869d7a65815"}],"rabbitmq/templates/bin/_rabbitmq-liveness.sh.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"e8650177f9b58eb05862d0afcf36ca4436a43876","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":6,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":7,"context_line":"# You may obtain a copy of the License at"},{"line_number":8,"context_line":"#"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"1f485f77_f99b04c6","line":5,"updated":"2017-11-15 10:47:01.000000000","message":"ditto","commit_id":"dcf0f0599ff71b702e126230441f6823c3abb745"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"71de88c87331c5fc60400fd8a02fedaf394b281b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":"{{/*"},{"line_number":3,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":6,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":7,"context_line":"# You may obtain a copy of the License at"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"#     http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# Unless required by applicable law or agreed to in writing, software"},{"line_number":12,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":13,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":14,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":"*/}}"},{"line_number":17,"context_line":"# This is taken from https://github.com/openstack/fuel-ccp-rabbitmq/blob/master/service/files/rabbitmq-liveness.sh.j2"},{"line_number":18,"context_line":"set -eu"},{"line_number":19,"context_line":"set -o pipefail"},{"line_number":20,"context_line":"exec 1\u003e/proc/1/fd/2 2\u003e/proc/1/fd/2"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"source $(readlink -f $(dirname $0))/rabbitmq-check-helpers.sh"},{"line_number":23,"context_line":"set-log-prefix \"liveness:$$\""},{"line_number":24,"context_line":"log-it \"Starting liveness probe at $(date +\u0027%Y-%m-%d %H:%M:%S\u0027)\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"main() {"},{"line_number":27,"context_line":"    local marker_state"},{"line_number":28,"context_line":"    marker_state\u003d\"$(marker-state)\""},{"line_number":29,"context_line":"    case $marker_state in"},{"line_number":30,"context_line":"        missing)"},{"line_number":31,"context_line":"            log-it \"Startup marker missing, probably probe was executed too early\""},{"line_number":32,"context_line":"            return 0"},{"line_number":33,"context_line":"            ;;"},{"line_number":34,"context_line":"        fresh) # node has recently started - it can still be booting"},{"line_number":35,"context_line":"            if ! ping-node; then"},{"line_number":36,"context_line":"                log-it \"Fresh node, erlang VM hasn\u0027t started yet - giving it another chance\""},{"line_number":37,"context_line":"                # Erlang VM hasn\u0027t started yet"},{"line_number":38,"context_line":"                return 0"},{"line_number":39,"context_line":"            fi"},{"line_number":40,"context_line":"            if is-node-booting; then"},{"line_number":41,"context_line":"                log-it \"Node is still booting, giving it some time to finish\""},{"line_number":42,"context_line":"                return 0"},{"line_number":43,"context_line":"            fi"},{"line_number":44,"context_line":"            if ! is-node-healthy; then"},{"line_number":45,"context_line":"                log-it \"Node is unhealthy\""},{"line_number":46,"context_line":"                return 1"},{"line_number":47,"context_line":"            fi"},{"line_number":48,"context_line":"            return 0"},{"line_number":49,"context_line":"            ;;"},{"line_number":50,"context_line":"        stale) # node has started long ago - it shoud be either ready or dead"},{"line_number":51,"context_line":"            if ! is-node-healthy; then"},{"line_number":52,"context_line":"                log-it \"Long-running node become unhealthy\""},{"line_number":53,"context_line":"                return 1"},{"line_number":54,"context_line":"            fi"},{"line_number":55,"context_line":"            return 0"},{"line_number":56,"context_line":"            ;;"},{"line_number":57,"context_line":"        *)"},{"line_number":58,"context_line":"            log-it \"Unexpected marker-state \u0027$marker-state\u0027\""},{"line_number":59,"context_line":"            return 1"},{"line_number":60,"context_line":"            ;;"},{"line_number":61,"context_line":"    esac"},{"line_number":62,"context_line":"}"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"if main; then"},{"line_number":65,"context_line":"    rc\u003d0"}],"source_content_type":"text/x-smarty","patch_set":27,"id":"bf8cb3f7_6336dcb7","line":62,"range":{"start_line":1,"start_character":0,"end_line":62,"end_character":1},"updated":"2017-12-20 14:05:28.000000000","message":"This can be removed","commit_id":"015fc5b2507296b0c89d963ae0969869d7a65815"}],"rabbitmq/templates/bin/_rabbitmq-readiness.sh.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"e8650177f9b58eb05862d0afcf36ca4436a43876","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":6,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":1,"id":"1f485f77_d99e08b7","line":3,"updated":"2017-11-15 10:47:01.000000000","message":"ditto","commit_id":"dcf0f0599ff71b702e126230441f6823c3abb745"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"e8650177f9b58eb05862d0afcf36ca4436a43876","unresolved":false,"context_lines":[{"line_number":42,"context_line":"fi"},{"line_number":43,"context_line":"log-it \"Ready to return $rc\""},{"line_number":44,"context_line":"exit $rc"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"1f485f77_99a890db","line":45,"updated":"2017-11-15 10:47:01.000000000","message":"can remove","commit_id":"dcf0f0599ff71b702e126230441f6823c3abb745"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"71de88c87331c5fc60400fd8a02fedaf394b281b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":"{{/*"},{"line_number":3,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":6,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":7,"context_line":"# You may obtain a copy of the License at"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"#     http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# Unless required by applicable law or agreed to in writing, software"},{"line_number":12,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":13,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":14,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":15,"context_line":"# limitations under the License."},{"line_number":16,"context_line":"*/}}"},{"line_number":17,"context_line":"# This is taken from https://github.com/openstack/fuel-ccp-rabbitmq/blob/master/service/files/rabbitmq-readiness.sh.j2"},{"line_number":18,"context_line":"set -eu"},{"line_number":19,"context_line":"set -o pipefail"},{"line_number":20,"context_line":"exec 1\u003e/proc/1/fd/2 2\u003e/proc/1/fd/2"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"source $(readlink -f $(dirname $0))/rabbitmq-check-helpers.sh"},{"line_number":23,"context_line":"set-log-prefix \"readiness:$$\""},{"line_number":24,"context_line":"log-it \"Starting readiness probe at $(date +\u0027%Y-%m-%d %H:%M:%S\u0027)\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"main() {"},{"line_number":27,"context_line":"    if [[ \"$(marker-state)\" \u003d\u003d missing ]]; then"},{"line_number":28,"context_line":"        log-it \"Startup marker missing, probably probe was executed too early\""},{"line_number":29,"context_line":"        return 1"},{"line_number":30,"context_line":"    fi"},{"line_number":31,"context_line":"    if ! is-node-healthy; then"},{"line_number":32,"context_line":"        log-it \"Node is unhealthy\""},{"line_number":33,"context_line":"        return 1"},{"line_number":34,"context_line":"    fi"},{"line_number":35,"context_line":"    return 0"},{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"if main; then"},{"line_number":39,"context_line":"    rc\u003d0"},{"line_number":40,"context_line":"else"},{"line_number":41,"context_line":"    rc\u003d$?"},{"line_number":42,"context_line":"fi"},{"line_number":43,"context_line":"log-it \"Ready to return $rc\""},{"line_number":44,"context_line":"exit $rc"}],"source_content_type":"text/x-smarty","patch_set":27,"id":"bf8cb3f7_833be09a","line":44,"range":{"start_line":1,"start_character":0,"end_line":44,"end_character":8},"updated":"2017-12-20 14:05:28.000000000","message":"This can be removed","commit_id":"015fc5b2507296b0c89d963ae0969869d7a65815"}],"rabbitmq/templates/etc/_rabbitmq-disc-node.conf.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"e8650177f9b58eb05862d0afcf36ca4436a43876","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":1,"id":"1f485f77_d9872861","line":1,"updated":"2017-11-15 10:47:01.000000000","message":"can use {{/* */}} comment","commit_id":"dcf0f0599ff71b702e126230441f6823c3abb745"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"e8650177f9b58eb05862d0afcf36ca4436a43876","unresolved":false,"context_lines":[{"line_number":27,"context_line":"cluster_partition_handling \u003d ignore"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"queue_master_locator \u003d random"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"1f485f77_19f9404c","line":30,"updated":"2017-11-15 10:47:01.000000000","message":"one blank line for EoF","commit_id":"dcf0f0599ff71b702e126230441f6823c3abb745"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c5f734e6786e2321a73dbc2b593694453f9813f5","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"loopback_users.guest \u003d false"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"autocluster.peer_discovery_backend \u003d rabbit_peer_discovery_dns"},{"line_number":24,"context_line":"autocluster.dns.hostname           \u003d rabbitmq-discovery.{{ .Release.Namespace }}.svc.cluster.local"},{"line_number":25,"context_line":"autocluster.node_type \u003d disc"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":7,"id":"df87a7cf_6e30d157","line":23,"updated":"2017-12-04 15:31:57.000000000","message":"Looks like these settings have changed to be prefixed with `cluster_formation` instead of `autocluster`: http://logs.openstack.org/38/519938/7/check/openstack-helm-legacy-ubuntu-vm-ovs-radosgw/e46f32a/primary/k8s/pods/openstack-rabbitmq-disc-node-0-rabbitmq.txt","commit_id":"b1b21056a0beb1f739a4ed05016366e356ca83e6"}],"rabbitmq/templates/etc/_rabbitmq-env.conf.tpl":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"71de88c87331c5fc60400fd8a02fedaf394b281b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."},{"line_number":6,"context_line":"You may obtain a copy of the License at"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"   http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Unless required by applicable law or agreed to in writing, software"},{"line_number":11,"context_line":"distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":12,"context_line":"WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":"See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"CONFIG_FILE\u003d/etc/rabbitmq/rabbitmq.conf"},{"line_number":18,"context_line":"RABBITMQ_LOGS\u003d-"},{"line_number":19,"context_line":"RABBITMQ_SASL_LOGS\u003d-"},{"line_number":20,"context_line":"RABBITMQ_USE_LONGNAME\u003dtrue"},{"line_number":21,"context_line":"NODENAME\u003d\"rabbit@$(hostname -f)\""}],"source_content_type":"text/x-smarty","patch_set":27,"id":"bf8cb3f7_635fbce5","line":21,"range":{"start_line":7,"start_character":0,"end_line":21,"end_character":32},"updated":"2017-12-20 14:05:28.000000000","message":"This can all be removed","commit_id":"015fc5b2507296b0c89d963ae0969869d7a65815"}],"rabbitmq/templates/etc/_rabbitmq-ram-node.conf.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"e8650177f9b58eb05862d0afcf36ca4436a43876","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":1,"id":"1f485f77_798954c8","line":1,"updated":"2017-11-15 10:47:01.000000000","message":"ditto","commit_id":"dcf0f0599ff71b702e126230441f6823c3abb745"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"e8650177f9b58eb05862d0afcf36ca4436a43876","unresolved":false,"context_lines":[{"line_number":27,"context_line":"cluster_partition_handling \u003d ignore"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"queue_master_locator \u003d random"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"1f485f77_198ee0cf","line":30,"updated":"2017-11-15 10:47:01.000000000","message":"one blank line for EoF","commit_id":"dcf0f0599ff71b702e126230441f6823c3abb745"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c5f734e6786e2321a73dbc2b593694453f9813f5","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"loopback_users.guest \u003d false"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"autocluster.peer_discovery_backend \u003d rabbit_peer_discovery_dns"},{"line_number":24,"context_line":"autocluster.dns.hostname           \u003d rabbitmq-discovery.{{ .Release.Namespace }}.svc.cluster.local"},{"line_number":25,"context_line":"autocluster.node_type \u003d ram"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":7,"id":"df87a7cf_0e358546","line":23,"updated":"2017-12-04 15:31:57.000000000","message":"same here","commit_id":"b1b21056a0beb1f739a4ed05016366e356ca83e6"}],"rabbitmq/templates/etc/_rabbitmq.config.tpl":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"71de88c87331c5fc60400fd8a02fedaf394b281b","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"loopback_users.guest \u003d false"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"autocluster.peer_discovery_backend \u003d rabbit_peer_discovery_dns"},{"line_number":24,"context_line":"autocluster.dns.hostname           \u003d rabbitmq-discovery.{{ .Release.Namespace }}.svc.cluster.local"},{"line_number":25,"context_line":"autocluster.node_type \u003d disc"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"cluster_keepalive_interval \u003d 30000"},{"line_number":28,"context_line":"cluster_partition_handling \u003d ignore"}],"source_content_type":"text/x-smarty","patch_set":27,"id":"bf8cb3f7_435e38e7","line":25,"range":{"start_line":23,"start_character":0,"end_line":25,"end_character":28},"updated":"2017-12-20 14:05:28.000000000","message":"This section can be removed as it\u0027s no longer necessary","commit_id":"015fc5b2507296b0c89d963ae0969869d7a65815"}],"rabbitmq/templates/service-disc-node.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"bb24d786ec7706454ee658dede34c9c970bf8cb5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"spec:"},{"line_number":20,"context_line":"  clusterIP: None"},{"line_number":21,"context_line":"  selector:"},{"line_number":22,"context_line":"    app: rabbitmq"},{"line_number":23,"context_line":"    node_type: disc"},{"line_number":24,"context_line":"  ports:"},{"line_number":25,"context_line":"  - port: {{.Values.network.port.public}}"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df87a7cf_887f9b64","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":19},"updated":"2017-12-11 18:50:56.000000000","message":"This needs to use labels for selectors, similar to the other services: https://github.com/openstack/openstack-helm/blob/master/keystone/templates/service-api.yaml#L37","commit_id":"e6fcb3facbb89ecfa75cffec133a9cf7def9a15f"}],"rabbitmq/templates/service-ram-node.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"bb24d786ec7706454ee658dede34c9c970bf8cb5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"spec:"},{"line_number":20,"context_line":"  clusterIP: None"},{"line_number":21,"context_line":"  selector:"},{"line_number":22,"context_line":"    app: rabbitmq"},{"line_number":23,"context_line":"    node_type: ram"},{"line_number":24,"context_line":"  ports:"},{"line_number":25,"context_line":"  - port: {{.Values.network.port.public}}"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df87a7cf_e8e4273e","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":18},"updated":"2017-12-11 18:50:56.000000000","message":"Same thing as disc nodes here","commit_id":"e6fcb3facbb89ecfa75cffec133a9cf7def9a15f"}],"rabbitmq/templates/service.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"bb24d786ec7706454ee658dede34c9c970bf8cb5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df87a7cf_e5a9b223","side":"PARENT","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":4},"updated":"2017-12-11 18:50:56.000000000","message":"The chart will still need a service to expose endpoints for rabbitmq.  This service should be used for service discovery for autoclusterer, and previous work on this can be found here: https://review.openstack.org/#/c/464669/8/rabbitmq/templates/service-discovery.yaml\n\nNote the selector would need to be \"application\" instead of \"app\" due to how the helm toolkit label function labels items","commit_id":"2c89386765d0c390e156035c24172cc20bccf43b"}],"rabbitmq/templates/statefulset-disc-node.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"e8650177f9b58eb05862d0afcf36ca4436a43876","unresolved":false,"context_lines":[{"line_number":93,"context_line":"              subPath: erlang.cookie"},{"line_number":94,"context_line":"            - name: rabbitmq-etc"},{"line_number":95,"context_line":"              mountPath: /etc/rabbitmq/rabbitmq-env.conf"},{"line_number":96,"context_line":"              subPath: rabbitmq-env.conf"},{"line_number":97,"context_line":"            - name: rabbitmq-etc"},{"line_number":98,"context_line":"              mountPath: /etc/rabbitmq/rabbitmq.conf"},{"line_number":99,"context_line":"              subPath: rabbitmq-disc-node.conf"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f485f77_b95c6c7e","line":96,"range":{"start_line":96,"start_character":14,"end_line":96,"end_character":40},"updated":"2017-11-15 10:47:01.000000000","message":"can you make this readonly?","commit_id":"dcf0f0599ff71b702e126230441f6823c3abb745"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"e8650177f9b58eb05862d0afcf36ca4436a43876","unresolved":false,"context_lines":[{"line_number":96,"context_line":"              subPath: rabbitmq-env.conf"},{"line_number":97,"context_line":"            - name: rabbitmq-etc"},{"line_number":98,"context_line":"              mountPath: /etc/rabbitmq/rabbitmq.conf"},{"line_number":99,"context_line":"              subPath: rabbitmq-disc-node.conf"},{"line_number":100,"context_line":"  volumeClaimTemplates:"},{"line_number":101,"context_line":"  - metadata:"},{"line_number":102,"context_line":"      name: rabbitmq-data"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f485f77_5951f861","line":99,"range":{"start_line":99,"start_character":14,"end_line":99,"end_character":46},"updated":"2017-11-15 10:47:01.000000000","message":"ditto","commit_id":"dcf0f0599ff71b702e126230441f6823c3abb745"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c36af20d80f471d0b40c02ad034f430154ac6854","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  template:"},{"line_number":23,"context_line":"    metadata:"},{"line_number":24,"context_line":"      labels:"},{"line_number":25,"context_line":"        app: rabbitmq"},{"line_number":26,"context_line":"        node_type: disc"},{"line_number":27,"context_line":"      annotations:"},{"line_number":28,"context_line":"        # TODO: this needs to be moved to common."},{"line_number":29,"context_line":"        scheduler.alpha.kubernetes.io/affinity: \u003e"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f485f77_9223bd56","line":26,"range":{"start_line":25,"start_character":0,"end_line":26,"end_character":23},"updated":"2017-11-15 18:26:39.000000000","message":"Labels can be handled via helm-toolkit: https://github.com/openstack/openstack-helm/blob/master/keystone/templates/deployment-api.yaml#L33","commit_id":"0f5d25d066aff03fb92b1754697e2a1afff70c26"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c36af20d80f471d0b40c02ad034f430154ac6854","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        node_type: disc"},{"line_number":27,"context_line":"      annotations:"},{"line_number":28,"context_line":"        # TODO: this needs to be moved to common."},{"line_number":29,"context_line":"        scheduler.alpha.kubernetes.io/affinity: \u003e"},{"line_number":30,"context_line":"           {"},{"line_number":31,"context_line":"             \"podAntiAffinity\": {"},{"line_number":32,"context_line":"               \"preferredDuringSchedulingIgnoredDuringExecution\": [{"},{"line_number":33,"context_line":"                 \"labelSelector\": {"},{"line_number":34,"context_line":"                   \"matchExpressions\": [{"},{"line_number":35,"context_line":"                     \"key\": \"app\","},{"line_number":36,"context_line":"                     \"operator\": \"In\","},{"line_number":37,"context_line":"                     \"values\":[\"rabbitmq\"]"},{"line_number":38,"context_line":"                   }]"},{"line_number":39,"context_line":"                 },"},{"line_number":40,"context_line":"               \"topologyKey\": \"kubernetes.io/hostname\","},{"line_number":41,"context_line":"               \"weight\": 10"},{"line_number":42,"context_line":"               }]"},{"line_number":43,"context_line":"             }"},{"line_number":44,"context_line":"           }"},{"line_number":45,"context_line":"    spec:"},{"line_number":46,"context_line":"      nodeSelector:"},{"line_number":47,"context_line":"        {{ .Values.labels.node_selector_key }}: {{ .Values.labels.node_selector_value }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f485f77_f20b11d3","line":44,"range":{"start_line":29,"start_character":0,"end_line":44,"end_character":12},"updated":"2017-11-15 18:26:39.000000000","message":"We can remove the json annotations and handle them via helm-toolkit: https://github.com/openstack/openstack-helm/blob/master/keystone/templates/deployment-api.yaml#L39","commit_id":"0f5d25d066aff03fb92b1754697e2a1afff70c26"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c36af20d80f471d0b40c02ad034f430154ac6854","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      containers:"},{"line_number":56,"context_line":"        - name: rabbitmq"},{"line_number":57,"context_line":"          image: {{ .Values.images.tags.rabbitmq }}"},{"line_number":58,"context_line":"           {{- if .Values.resources.enabled }}"},{"line_number":59,"context_line":"          resources:"},{"line_number":60,"context_line":"            limits:"},{"line_number":61,"context_line":"              cpu: {{ .Values.resources.api.limits.cpu | quote }}"},{"line_number":62,"context_line":"              memory: {{ .Values.resources.api.limits.memory | quote }}"},{"line_number":63,"context_line":"            requests:"},{"line_number":64,"context_line":"              cpu: {{ .Values.resources.api.requests.cpu | quote }}"},{"line_number":65,"context_line":"              memory: {{ .Values.resources.api.requests.memory | quote }}"},{"line_number":66,"context_line":"           {{- end }}"},{"line_number":67,"context_line":"          command:"},{"line_number":68,"context_line":"          - bash"},{"line_number":69,"context_line":"          - /scripts/start.sh"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f485f77_d257f5c9","line":66,"range":{"start_line":58,"start_character":0,"end_line":66,"end_character":21},"updated":"2017-11-15 18:26:39.000000000","message":"This can be handled via helm-toolkit: https://github.com/openstack/openstack-helm/blob/master/keystone/templates/deployment-api.yaml#L49","commit_id":"0f5d25d066aff03fb92b1754697e2a1afff70c26"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c36af20d80f471d0b40c02ad034f430154ac6854","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            - name: rabbitmq-etc"},{"line_number":95,"context_line":"              mountPath: /etc/rabbitmq/rabbitmq-env.conf"},{"line_number":96,"context_line":"              subPath: rabbitmq-env.conf"},{"line_number":97,"context_line":"              readonly: true"},{"line_number":98,"context_line":"            - name: rabbitmq-etc"},{"line_number":99,"context_line":"              mountPath: /etc/rabbitmq/rabbitmq.conf"},{"line_number":100,"context_line":"              subPath: rabbitmq-disc-node.conf"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f485f77_32e1a92b","line":97,"updated":"2017-11-15 18:26:39.000000000","message":"Should be readOnly","commit_id":"0f5d25d066aff03fb92b1754697e2a1afff70c26"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c36af20d80f471d0b40c02ad034f430154ac6854","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            - name: rabbitmq-etc"},{"line_number":99,"context_line":"              mountPath: /etc/rabbitmq/rabbitmq.conf"},{"line_number":100,"context_line":"              subPath: rabbitmq-disc-node.conf"},{"line_number":101,"context_line":"              readonly: true"},{"line_number":102,"context_line":"  volumeClaimTemplates:"},{"line_number":103,"context_line":"  - metadata:"},{"line_number":104,"context_line":"      name: rabbitmq-data"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f485f77_d2c935ac","line":101,"range":{"start_line":101,"start_character":14,"end_line":101,"end_character":22},"updated":"2017-11-15 18:26:39.000000000","message":"Same","commit_id":"0f5d25d066aff03fb92b1754697e2a1afff70c26"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a6b78168c07af5f6112ad277c1dd4825947bca68","unresolved":false,"context_lines":[{"line_number":18,"context_line":"---"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"apiVersion: apps/v1beta1"},{"line_number":21,"context_line":"kind: Statefulset"},{"line_number":22,"context_line":"metadata:"},{"line_number":23,"context_line":"  name: rabbitmq-disc-node"},{"line_number":24,"context_line":"spec:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff82abbf_563de228","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":17},"updated":"2017-11-29 17:46:43.000000000","message":"Needs to be \u0027StatefulSet\u0027","commit_id":"a6a222139b1e7cbb70ebede17be7c3f882505818"}],"rabbitmq/templates/statefulset-ram-node.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"e8650177f9b58eb05862d0afcf36ca4436a43876","unresolved":false,"context_lines":[{"line_number":57,"context_line":"          configMap:"},{"line_number":58,"context_line":"            name: rabbitmq-etc"},{"line_number":59,"context_line":"      initContainers:"},{"line_number":60,"context_line":"{{ tuple $envAll $dependencies \"[]\" | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 9 }}"},{"line_number":61,"context_line":"      containers:"},{"line_number":62,"context_line":"        - name: rabbitmq"},{"line_number":63,"context_line":"          image: {{ .Values.images.tags.rabbitmq }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f485f77_99d410bf","line":60,"range":{"start_line":60,"start_character":116,"end_line":60,"end_character":117},"updated":"2017-11-15 10:47:01.000000000","message":"yaml indent usually goes by multiple of 2, is this 9 correct","commit_id":"dcf0f0599ff71b702e126230441f6823c3abb745"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"e8650177f9b58eb05862d0afcf36ca4436a43876","unresolved":false,"context_lines":[{"line_number":107,"context_line":"              mountPath: /etc/rabbitmq/rabbitmq.conf"},{"line_number":108,"context_line":"              subPath: rabbitmq-ram-node.conf"},{"line_number":109,"context_line":"              readOnly: True"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f485f77_59d698c5","line":110,"updated":"2017-11-15 10:47:01.000000000","message":"single EoF line","commit_id":"dcf0f0599ff71b702e126230441f6823c3abb745"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c36af20d80f471d0b40c02ad034f430154ac6854","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  template:"},{"line_number":25,"context_line":"    metadata:"},{"line_number":26,"context_line":"      labels:"},{"line_number":27,"context_line":"        app: rabbitmq"},{"line_number":28,"context_line":"        node_type: ram"},{"line_number":29,"context_line":"      annotations:"},{"line_number":30,"context_line":"        # TODO: this needs to be moved to common."},{"line_number":31,"context_line":"        scheduler.alpha.kubernetes.io/affinity: \u003e"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f485f77_f2d9d156","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":22},"updated":"2017-11-15 18:26:39.000000000","message":"Same","commit_id":"0f5d25d066aff03fb92b1754697e2a1afff70c26"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c36af20d80f471d0b40c02ad034f430154ac6854","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        app: rabbitmq"},{"line_number":28,"context_line":"        node_type: ram"},{"line_number":29,"context_line":"      annotations:"},{"line_number":30,"context_line":"        # TODO: this needs to be moved to common."},{"line_number":31,"context_line":"        scheduler.alpha.kubernetes.io/affinity: \u003e"},{"line_number":32,"context_line":"           {"},{"line_number":33,"context_line":"             \"podAntiAffinity\": {"},{"line_number":34,"context_line":"               \"preferredDuringSchedulingIgnoredDuringExecution\": [{"},{"line_number":35,"context_line":"                 \"labelSelector\": {"},{"line_number":36,"context_line":"                   \"matchExpressions\": [{"},{"line_number":37,"context_line":"                     \"key\": \"app\","},{"line_number":38,"context_line":"                     \"operator\": \"In\","},{"line_number":39,"context_line":"                     \"values\":[\"rabbitmq\"]"},{"line_number":40,"context_line":"                   }]"},{"line_number":41,"context_line":"                 },"},{"line_number":42,"context_line":"               \"topologyKey\": \"kubernetes.io/hostname\","},{"line_number":43,"context_line":"               \"weight\": 10"},{"line_number":44,"context_line":"               }]"},{"line_number":45,"context_line":"             }"},{"line_number":46,"context_line":"           }"},{"line_number":47,"context_line":"    spec:"},{"line_number":48,"context_line":"      nodeSelector:"},{"line_number":49,"context_line":"        {{ .Values.labels.node_selector_key }}: {{ .Values.labels.node_selector_value }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f485f77_d2da5549","line":46,"range":{"start_line":30,"start_character":0,"end_line":46,"end_character":12},"updated":"2017-11-15 18:26:39.000000000","message":"Same","commit_id":"0f5d25d066aff03fb92b1754697e2a1afff70c26"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c36af20d80f471d0b40c02ad034f430154ac6854","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        - name: rabbitmq"},{"line_number":63,"context_line":"          image: {{ .Values.images.tags.rabbitmq }}"},{"line_number":64,"context_line":"          {{- if .Values.resources.enabled }}"},{"line_number":65,"context_line":"          resources:"},{"line_number":66,"context_line":"            limits:"},{"line_number":67,"context_line":"              cpu: {{ .Values.resources.api.limits.cpu | quote }}"},{"line_number":68,"context_line":"              memory: {{ .Values.resources.api.limits.memory | quote }}"},{"line_number":69,"context_line":"            requests:"},{"line_number":70,"context_line":"              cpu: {{ .Values.resources.api.requests.cpu | quote }}"},{"line_number":71,"context_line":"              memory: {{ .Values.resources.api.requests.memory | quote }}"},{"line_number":72,"context_line":"          {{- end }}"},{"line_number":73,"context_line":"          command:"},{"line_number":74,"context_line":"          - bash"},{"line_number":75,"context_line":"          - /scripts/start.sh"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f485f77_72e5e108","line":72,"range":{"start_line":65,"start_character":0,"end_line":72,"end_character":20},"updated":"2017-11-15 18:26:39.000000000","message":"Same","commit_id":"0f5d25d066aff03fb92b1754697e2a1afff70c26"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c36af20d80f471d0b40c02ad034f430154ac6854","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            - name: rabbitmq-etc"},{"line_number":107,"context_line":"              mountPath: /etc/rabbitmq/rabbitmq.conf"},{"line_number":108,"context_line":"              subPath: rabbitmq-ram-node.conf"},{"line_number":109,"context_line":"              readOnly: True"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f485f77_32ebe9dc","line":109,"range":{"start_line":109,"start_character":24,"end_line":109,"end_character":28},"updated":"2017-11-15 18:26:39.000000000","message":"true","commit_id":"0f5d25d066aff03fb92b1754697e2a1afff70c26"}],"rabbitmq/templates/statefulset.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"71de88c87331c5fc60400fd8a02fedaf394b281b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        image: pivotalrabbitmq/rabbitmq-autocluster:3.7-k8s"},{"line_number":33,"context_line":"        ports:"},{"line_number":34,"context_line":"          - name: management"},{"line_number":35,"context_line":"            protocol: TCP"},{"line_number":36,"context_line":"            containerPort: 15672"},{"line_number":37,"context_line":"          - name: public"},{"line_number":38,"context_line":"            protocol: TCP"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"bf8cb3f7_a36ce49c","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":25},"updated":"2017-12-20 14:05:28.000000000","message":"This can be removed as TCP is the default","commit_id":"015fc5b2507296b0c89d963ae0969869d7a65815"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"71de88c87331c5fc60400fd8a02fedaf394b281b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        ports:"},{"line_number":34,"context_line":"          - name: management"},{"line_number":35,"context_line":"            protocol: TCP"},{"line_number":36,"context_line":"            containerPort: 15672"},{"line_number":37,"context_line":"          - name: public"},{"line_number":38,"context_line":"            protocol: TCP"},{"line_number":39,"context_line":"            containerPort: 5672"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"bf8cb3f7_03f590cb","line":36,"range":{"start_line":36,"start_character":27,"end_line":36,"end_character":32},"updated":"2017-12-20 14:05:28.000000000","message":"This can be referenced with the management port entry in the .Values.network section","commit_id":"015fc5b2507296b0c89d963ae0969869d7a65815"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"71de88c87331c5fc60400fd8a02fedaf394b281b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            protocol: TCP"},{"line_number":36,"context_line":"            containerPort: 15672"},{"line_number":37,"context_line":"          - name: public"},{"line_number":38,"context_line":"            protocol: TCP"},{"line_number":39,"context_line":"            containerPort: 5672"},{"line_number":40,"context_line":"        livenessProbe:"},{"line_number":41,"context_line":"          exec:"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"bf8cb3f7_c369e88b","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":25},"updated":"2017-12-20 14:05:28.000000000","message":"Same","commit_id":"015fc5b2507296b0c89d963ae0969869d7a65815"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"71de88c87331c5fc60400fd8a02fedaf394b281b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            containerPort: 15672"},{"line_number":37,"context_line":"          - name: public"},{"line_number":38,"context_line":"            protocol: TCP"},{"line_number":39,"context_line":"            containerPort: 5672"},{"line_number":40,"context_line":"        livenessProbe:"},{"line_number":41,"context_line":"          exec:"},{"line_number":42,"context_line":"            command: [\"rabbitmqctl\", \"status\"]"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"bf8cb3f7_031ef00b","line":39,"range":{"start_line":39,"start_character":27,"end_line":39,"end_character":31},"updated":"2017-12-20 14:05:28.000000000","message":"This can be referenced with the public port entry in the .Values.network section","commit_id":"015fc5b2507296b0c89d963ae0969869d7a65815"}],"rabbitmq/values.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c36af20d80f471d0b40c02ad034f430154ac6854","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# Declare name/value pairs to be passed into your templates."},{"line_number":18,"context_line":"# name: value"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"replicas:"},{"line_number":21,"context_line":"  disc_node: 3"},{"line_number":22,"context_line":"  #"},{"line_number":23,"context_line":"  # RAM nodes are not generally recommended by the RabbitMQ team.  They may be"},{"line_number":24,"context_line":"  # useful, however, for OpenStack deployments which have significant queue"},{"line_number":25,"context_line":"  # churn."},{"line_number":26,"context_line":"  #"},{"line_number":27,"context_line":"  # However, the current implementation of this chart has some shortcomings"},{"line_number":28,"context_line":"  # which can lead to split-brain between disc and ram nodes.  A video"},{"line_number":29,"context_line":"  # demonstrating this issue can be found here: https://asciinema.org/a/121760"},{"line_number":30,"context_line":"  ram_node: 0"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"resources:"},{"line_number":33,"context_line":"   enabled: false"},{"line_number":34,"context_line":"   api:"},{"line_number":35,"context_line":"     limits:"},{"line_number":36,"context_line":"       memory: \"128Mi\""},{"line_number":37,"context_line":"       cpu: \"500m\""},{"line_number":38,"context_line":"     requests:"},{"line_number":39,"context_line":"       memory: \"128Mi\""},{"line_number":40,"context_line":"       cpu: \"500m\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"labels:"},{"line_number":43,"context_line":"  node_selector_key: openstack-control-plane"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f485f77_12a34db4","line":40,"range":{"start_line":20,"start_character":0,"end_line":40,"end_character":18},"updated":"2017-11-15 18:26:39.000000000","message":"Can you put these under the pod: tree, similar to the other charts? Example: https://github.com/openstack/openstack-helm/blob/master/keystone/templates/deployment-api.yaml#L33","commit_id":"0f5d25d066aff03fb92b1754697e2a1afff70c26"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"560beaa451069ad559c9287ff520132eec3ebdf7","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"images:"},{"line_number":68,"context_line":"  tags:"},{"line_number":69,"context_line":"    rabbitmq: hub.docker.com/r/harsha9/rabbitmq"},{"line_number":70,"context_line":"    dep_check: docker.io/kolla/ubuntu-source-kubernetes-entrypoint:4.0.0"},{"line_number":71,"context_line":"  pull_policy: \"IfNotPresent\""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff82abbf_89777a09","line":69,"range":{"start_line":69,"start_character":4,"end_line":69,"end_character":47},"updated":"2017-11-30 15:19:22.000000000","message":"It looks like there\u0027s an issue pulling this image. When I try to pull up the repo in dockerhub, it\u0027s showing 404. This will need to be updated with a publicly available dockerhub repository","commit_id":"2afe6a7320c52417c548bd35a248e6d6957abb9e"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"9cd13ad3ffda100a2af253259990b029c537846c","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"images:"},{"line_number":68,"context_line":"  tags:"},{"line_number":69,"context_line":"    rabbitmq: hub.docker.com/r/harsha9/rabbitmq3.7.1"},{"line_number":70,"context_line":"    dep_check: docker.io/kolla/ubuntu-source-kubernetes-entrypoint:4.0.0"},{"line_number":71,"context_line":"  pull_policy: \"IfNotPresent\""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff82abbf_6a5a1984","line":69,"range":{"start_line":69,"start_character":14,"end_line":69,"end_character":52},"updated":"2017-11-30 23:10:36.000000000","message":"This should be docker.io/harsha9/rabbitmq:3.7.1\n\nThe hub.docker.com prefix is causing issues with the image pull process. In order to prevent this image from being tagged with :latest, it should be named something like osh-rabbitmq:3.7.1 or something similar, just to ensure there\u0027s a valid :\u003cx\u003e tag appended to the image","commit_id":"aaf72af9783b285e5d03b7ffcaccf47bfa69d379"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"71de88c87331c5fc60400fd8a02fedaf394b281b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      requests:"},{"line_number":46,"context_line":"        memory: \"128Mi\""},{"line_number":47,"context_line":"        cpu: \"500m\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  volume:"},{"line_number":50,"context_line":"    class_path: volume.beta.kubernetes.io/storage-class"},{"line_number":51,"context_line":"    class_name: general"},{"line_number":52,"context_line":"    size: 2Gi"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"auth:"},{"line_number":55,"context_line":"  default_user: rabbitmq"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"bf8cb3f7_43e158fe","line":52,"range":{"start_line":48,"start_character":0,"end_line":52,"end_character":13},"updated":"2017-12-20 14:05:28.000000000","message":"I dont think this is necessary at this point and may be removed","commit_id":"015fc5b2507296b0c89d963ae0969869d7a65815"}]}