)]}'
{"Makefile":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"2afc14401cac4481047655b446c23671c068d270","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\trm -f *tgz */charts/*tgz"},{"line_number":49,"context_line":"\trm -f */requirements.lock"},{"line_number":50,"context_line":"\t-rmdir -p */charts"},{"line_number":51,"context_line":"\t"},{"line_number":52,"context_line":"pull-all-images:"},{"line_number":53,"context_line":"\t@./tools/pull-images.sh"},{"line_number":54,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":27,"id":"df87a7cf_0900df00","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":1},"updated":"2017-12-06 15:19:05.000000000","message":"Remove this","commit_id":"bc6f05d6c3b2b548256e4f2c47749840dfb4319d"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"79897957f23ae434ff7f000d4cb19867c4d601d5","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\trm -f *tgz */charts/*tgz"},{"line_number":49,"context_line":"\trm -f */requirements.lock"},{"line_number":50,"context_line":"\t-rmdir -p */charts"},{"line_number":51,"context_line":"\t"},{"line_number":52,"context_line":"pull-all-images:"},{"line_number":53,"context_line":"\t@./tools/pull-images.sh"},{"line_number":54,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":27,"id":"df87a7cf_29504332","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":1},"in_reply_to":"df87a7cf_0900df00","updated":"2017-12-06 15:28:08.000000000","message":"Done","commit_id":"bc6f05d6c3b2b548256e4f2c47749840dfb4319d"}],"doc/source/install/developer/all-in-one.rst":[{"author":{"_account_id":21473,"name":"Elise Eiden","email":"ee550x@att.com","username":"elise.eiden"},"change_message_id":"d1ca739a2c96abd886a2a0a364c48ca963697f7d","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    :language: shell"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"This command will deploy a single node KubeADM administered cluster. This will"},{"line_number":61,"context_line":"use the paramiters in ``tools/gate/playbooks/vars.yaml`` to control the"},{"line_number":62,"context_line":"deployment, which can be over-ridden by adding entries to"},{"line_number":63,"context_line":"``tools/gate/devel/local-vars.yaml``."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"ff82abbf_4b49bb2e","line":61,"range":{"start_line":61,"start_character":8,"end_line":61,"end_character":18},"updated":"2017-11-27 22:57:57.000000000","message":"parameters","commit_id":"44bc780ecd4a788c95f4ceb62619cb5b63650370"},{"author":{"_account_id":21473,"name":"Elise Eiden","email":"ee550x@att.com","username":"elise.eiden"},"change_message_id":"d1ca739a2c96abd886a2a0a364c48ca963697f7d","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    :language: shell"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"This command will deploy a single node KubeADM administered cluster. This will"},{"line_number":61,"context_line":"use the paramiters in ``tools/gate/playbooks/vars.yaml`` to control the"},{"line_number":62,"context_line":"deployment, which can be over-ridden by adding entries to"},{"line_number":63,"context_line":"``tools/gate/devel/local-vars.yaml``."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"ff82abbf_6bfd9f6c","line":61,"range":{"start_line":61,"start_character":8,"end_line":61,"end_character":18},"updated":"2017-11-27 22:57:57.000000000","message":"parameters","commit_id":"374d31243de18f5967ffc4b06cf23f263aefab49"},{"author":{"_account_id":27396,"name":"Samuel Gil Jonesi","email":"sj019q@att.com","username":"sj019q"},"change_message_id":"d8affbcfc10e48a513d1a9fcc15add6203e3f54f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    set -xe"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    git clone https://git.openstack.org/openstack/openstack-helm-infra.git"},{"line_number":49,"context_line":"    git clone https://git.openstack.org/openstack/openstack-helm.git"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    #WARN(portdirect): do not merge with the following!"},{"line_number":52,"context_line":"    #NOTE(portdirect): while a wip, please then move into the ``openstack-helm``"}],"source_content_type":"text/x-rst","patch_set":25,"id":"df87a7cf_ac09c131","line":49,"range":{"start_line":49,"start_character":4,"end_line":49,"end_character":68},"updated":"2017-12-06 19:09:42.000000000","message":"I would put lines 45-49 before line 36.\n\nI would include a reminder to cd out of the openstack-repo, rm -rf the repo, then reclone if necessary to restart because of errors.\n\nI would include a line explaining how to check out the most recent PS.\n\nFinally, I would like a reminder that the hostname needs to be entirely lowercase to possibly avoid the errors that this causes. \n\nBoth of these commands:\n\nkubectl logs -n openstack NAMEOFPOD\nkubectl describe pods -n openstack\n\nI found useful for finding greater information about pods.\n\nAnd sudo rm -rf /var/lib/openstack-helm could be useful for resetting the namespaces as well.","commit_id":"2b6a85c82a554849f7c04c86e7b1f81c83fb8066"},{"author":{"_account_id":27396,"name":"Samuel Gil Jonesi","email":"sj019q@att.com","username":"sj019q"},"change_message_id":"d8affbcfc10e48a513d1a9fcc15add6203e3f54f","unresolved":false,"context_lines":[{"line_number":335,"context_line":""},{"line_number":336,"context_line":".. code-block:: shell"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"  helm delete ${RELEASE_NAME} --purge"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"This will delete all Kubernetes resources generated when the chart was"},{"line_number":341,"context_line":"instantiated. However for OpenStack charts, by default, this will not delete"}],"source_content_type":"text/x-rst","patch_set":25,"id":"df87a7cf_17ed5a24","line":338,"range":{"start_line":338,"start_character":0,"end_line":338,"end_character":37},"updated":"2017-12-06 19:09:42.000000000","message":"I would add\n\nkubectl delete ns ${RELEASE_NAME}\n\nif deletion of the namespace is required","commit_id":"2b6a85c82a554849f7c04c86e7b1f81c83fb8066"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"bd201a2223e05f22a3418bb9497a62fd333b3f83","unresolved":false,"context_lines":[{"line_number":47,"context_line":"--------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Install the latest versions of Git, CA Certs \u0026 Make if necessary"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. literalinclude:: ../../../../tools/deployment/developer/00-install-packages.sh"},{"line_number":52,"context_line":"    :language: shell"},{"line_number":53,"context_line":"    :lines: 1,17-"}],"source_content_type":"text/x-rst","patch_set":29,"id":"df87a7cf_6cef39b0","line":50,"updated":"2017-12-06 19:10:05.000000000","message":"Had to install Curl as well","commit_id":"183aabe090362ee44f5df99005a6de1d425b92c1"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"bd201a2223e05f22a3418bb9497a62fd333b3f83","unresolved":false,"context_lines":[{"line_number":78,"context_line":".. literalinclude:: ../../../../tools/deployment/developer/01-deploy-k8s.sh"},{"line_number":79,"context_line":"    :language: shell"},{"line_number":80,"context_line":"    :lines: 1,17-"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"This command will deploy a single node KubeADM administered cluster. This will"},{"line_number":83,"context_line":"use the parameters in ``${OSH_INFRA_PATH}/tools/gate/playbooks/vars.yaml`` to control the"},{"line_number":84,"context_line":"deployment, which can be over-ridden by adding entries to"}],"source_content_type":"text/x-rst","patch_set":29,"id":"df87a7cf_acad4132","line":81,"updated":"2017-12-06 19:10:05.000000000","message":"Running \"watch kubectl get --all-namespaces pods\" in a separate terminal was helpful as you can see the pods as they are being installed.","commit_id":"183aabe090362ee44f5df99005a6de1d425b92c1"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"bd201a2223e05f22a3418bb9497a62fd333b3f83","unresolved":false,"context_lines":[{"line_number":135,"context_line":".. literalinclude:: ../../../../tools/deployment/developer/04-ceph.sh"},{"line_number":136,"context_line":"    :language: shell"},{"line_number":137,"context_line":"    :lines: 1,17-"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Alternatively, this step can be performed by running the script directly:"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. code-block:: shell"}],"source_content_type":"text/x-rst","patch_set":29,"id":"df87a7cf_d70cd23c","line":138,"updated":"2017-12-06 19:10:05.000000000","message":"Ran into an issue installing 04 without errors.  Fixed by uninstalling 04 then running \"sudo {text editor} /etc/nsswitch.conf\" and commenting out \"hosts: files mdns4_minimal [NOTFOUND\u003dreturn] dns\" and adding \"hosts: files dns\" and finally reinstalling 04","commit_id":"183aabe090362ee44f5df99005a6de1d425b92c1"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"40f07c75027697d2bb9d1470eada7b0b534325fc","unresolved":false,"context_lines":[{"line_number":47,"context_line":"--------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Install the latest versions of Git, CA Certs \u0026 Make if necessary"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. literalinclude:: ../../../../tools/deployment/developer/00-install-packages.sh"},{"line_number":52,"context_line":"    :language: shell"},{"line_number":53,"context_line":"    :lines: 1,17-"}],"source_content_type":"text/x-rst","patch_set":31,"id":"df87a7cf_45c1e32d","line":50,"updated":"2017-12-06 20:43:40.000000000","message":"Had to install Curl as well","commit_id":"73786c1616e88ffadd0f04454eca620955bdb96c"},{"author":{"_account_id":27396,"name":"Samuel Gil Jonesi","email":"sj019q@att.com","username":"sj019q"},"change_message_id":"bf0cfff82aa40dff22410c7fd69b85beabb6e817","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    #!/bin/bash"},{"line_number":61,"context_line":"    set -xe"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    git clone https://git.openstack.org/openstack/openstack-helm-infra.git"},{"line_number":64,"context_line":"    git clone https://git.openstack.org/openstack/openstack-helm.git"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    #WARN(portdirect): do not merge with the following!"}],"source_content_type":"text/x-rst","patch_set":31,"id":"df87a7cf_a5578f02","line":63,"range":{"start_line":63,"start_character":4,"end_line":63,"end_character":74},"updated":"2017-12-06 20:23:49.000000000","message":"I would move line 51 after lines 63 and 64.\n\nI had some trouble installing these scripts, particularly with 06. Running \"watch helm ls\" in its own terminal and \"watch kubectl get pods -n openstack\" in its own terminal helped understand the process of installation immensely.\n\nWhat finally allowed me to install everything was deleting all the helm releases using \"helm delete --purge \u003crelease\u003e\" along with using \"kubectl delete pods -n openstack \u003cpod\u003e\" to delete all the pods and \"kubectl get -n openstack pvc\" to check the pvcs and \"kubectl delete -n openstack pvc mysql-data-mariadb-0\" to delete the maria pvc. I then deleted both openstack-helm and openstack-helm-infra and restarted my computer. Finally, I allowed some time between script 05 and 06.","commit_id":"73786c1616e88ffadd0f04454eca620955bdb96c"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"494e4a78e57301ed380872e44ad463d2dfa16419","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    #!/bin/bash"},{"line_number":61,"context_line":"    set -xe"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    git clone https://git.openstack.org/openstack/openstack-helm-infra.git"},{"line_number":64,"context_line":"    git clone https://git.openstack.org/openstack/openstack-helm.git"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    #WARN(portdirect): do not merge with the following!"}],"source_content_type":"text/x-rst","patch_set":31,"id":"df87a7cf_e5dd9714","line":63,"range":{"start_line":63,"start_character":4,"end_line":63,"end_character":74},"in_reply_to":"df87a7cf_a5578f02","updated":"2017-12-06 20:41:18.000000000","message":"re moving the lines: note that it wont be possible to run git, if you have not installed git...","commit_id":"73786c1616e88ffadd0f04454eca620955bdb96c"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"40f07c75027697d2bb9d1470eada7b0b534325fc","unresolved":false,"context_lines":[{"line_number":135,"context_line":".. literalinclude:: ../../../../tools/deployment/developer/04-ceph.sh"},{"line_number":136,"context_line":"    :language: shell"},{"line_number":137,"context_line":"    :lines: 1,17-"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Alternatively, this step can be performed by running the script directly:"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. code-block:: shell"}],"source_content_type":"text/x-rst","patch_set":31,"id":"df87a7cf_a500ef68","line":138,"updated":"2017-12-06 20:43:40.000000000","message":"Ran into an issue installing 04 without errors. Fixed by uninstalling 04 then running \"sudo {text editor} /etc/nsswitch.conf\" and commenting out \"hosts: files mdns4_minimal [NOTFOUND\u003dreturn] dns\" and adding \"hosts: files dns\" and finally reinstalling 04","commit_id":"73786c1616e88ffadd0f04454eca620955bdb96c"}],"tools/deployment/developer/00-install-packages.sh":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"01f2d50b1064866abe55c820f20999beeb2dc90e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        make \\"},{"line_number":24,"context_line":"        jq \\"},{"line_number":25,"context_line":"        nmap \\"},{"line_number":26,"context_line":"\tcurl"}],"source_content_type":"text/x-sh","patch_set":27,"id":"df87a7cf_7fbe1466","line":26,"range":{"start_line":26,"start_character":1,"end_line":26,"end_character":5},"updated":"2017-12-05 22:45:36.000000000","message":"is this required? also tabs.","commit_id":"bc6f05d6c3b2b548256e4f2c47749840dfb4319d"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"79897957f23ae434ff7f000d4cb19867c4d601d5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        make \\"},{"line_number":24,"context_line":"        jq \\"},{"line_number":25,"context_line":"        nmap \\"},{"line_number":26,"context_line":"\tcurl"}],"source_content_type":"text/x-sh","patch_set":27,"id":"df87a7cf_09645f21","line":26,"range":{"start_line":26,"start_character":1,"end_line":26,"end_character":5},"in_reply_to":"df87a7cf_09077f84","updated":"2017-12-06 15:28:08.000000000","message":"it is required for Ubuntu desktop potentially - as I cannot see it here:\n\n```\nubuntu@ip-172-31-62-126:~$ curl -sSL http://releases.ubuntu.com/xenial/ubuntu-16.04.3-desktop-amd64.manifest | grep curl\nlibcurl3:amd64\t7.47.0-1ubuntu2.2\nlibcurl3-gnutls:amd64\t7.47.0-1ubuntu2.2\npython3-pycurl\t7.43.0-1ubuntu1\n```","commit_id":"bc6f05d6c3b2b548256e4f2c47749840dfb4319d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"f814441c32bc2085ee87c61e5fc105582923da89","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        make \\"},{"line_number":24,"context_line":"        jq \\"},{"line_number":25,"context_line":"        nmap \\"},{"line_number":26,"context_line":"\tcurl"}],"source_content_type":"text/x-sh","patch_set":27,"id":"df87a7cf_4cc0357c","line":26,"range":{"start_line":26,"start_character":1,"end_line":26,"end_character":5},"in_reply_to":"df87a7cf_09645f21","updated":"2017-12-06 15:44:14.000000000","message":"Okay. It’s referenced in the current single node install docs, so oversight on my part.","commit_id":"bc6f05d6c3b2b548256e4f2c47749840dfb4319d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"2afc14401cac4481047655b446c23671c068d270","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        make \\"},{"line_number":24,"context_line":"        jq \\"},{"line_number":25,"context_line":"        nmap \\"},{"line_number":26,"context_line":"\tcurl"}],"source_content_type":"text/x-sh","patch_set":27,"id":"df87a7cf_09077f84","line":26,"range":{"start_line":26,"start_character":1,"end_line":26,"end_character":5},"in_reply_to":"df87a7cf_7fbe1466","updated":"2017-12-06 15:19:05.000000000","message":"I cant find where this is required","commit_id":"bc6f05d6c3b2b548256e4f2c47749840dfb4319d"},{"author":{"_account_id":27396,"name":"Samuel Gil Jonesi","email":"sj019q@att.com","username":"sj019q"},"change_message_id":"d8affbcfc10e48a513d1a9fcc15add6203e3f54f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        make \\"},{"line_number":24,"context_line":"        jq \\"},{"line_number":25,"context_line":"        nmap \\"},{"line_number":26,"context_line":"\tcurl"}],"source_content_type":"text/x-sh","patch_set":27,"id":"df87a7cf_863cdec8","line":26,"range":{"start_line":26,"start_character":1,"end_line":26,"end_character":5},"in_reply_to":"df87a7cf_7fbe1466","updated":"2017-12-06 19:09:42.000000000","message":"It was suggested by a teammate. Good to have, but not required. If you don\u0027t want this, I can get rid of it. Otherwise, I will replace the spaces with tabs.","commit_id":"bc6f05d6c3b2b548256e4f2c47749840dfb4319d"}],"tools/deployment/developer/10-ceph-radosgateway.sh":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"2afc14401cac4481047655b446c23671c068d270","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -xe"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"#NOTE: Pull images and lint chart"},{"line_number":20,"context_line":"make pull-images ceph"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"#NOTE: Deploy command"},{"line_number":23,"context_line":"WORK_DIR\u003d$(pwd)"}],"source_content_type":"text/x-sh","patch_set":27,"id":"df87a7cf_a96f7390","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":21},"updated":"2017-12-06 15:19:05.000000000","message":"Is this necessary?  This should be handled via the previous step for installing the ceph service","commit_id":"bc6f05d6c3b2b548256e4f2c47749840dfb4319d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"f814441c32bc2085ee87c61e5fc105582923da89","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -xe"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"#NOTE: Pull images and lint chart"},{"line_number":20,"context_line":"make pull-images ceph"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"#NOTE: Deploy command"},{"line_number":23,"context_line":"WORK_DIR\u003d$(pwd)"}],"source_content_type":"text/x-sh","patch_set":27,"id":"df87a7cf_ac46a120","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":21},"in_reply_to":"df87a7cf_697c0bb5","updated":"2017-12-06 15:44:14.000000000","message":"Okay. I’m alright with it sticking around then.","commit_id":"bc6f05d6c3b2b548256e4f2c47749840dfb4319d"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"79897957f23ae434ff7f000d4cb19867c4d601d5","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"set -xe"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"#NOTE: Pull images and lint chart"},{"line_number":20,"context_line":"make pull-images ceph"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"#NOTE: Deploy command"},{"line_number":23,"context_line":"WORK_DIR\u003d$(pwd)"}],"source_content_type":"text/x-sh","patch_set":27,"id":"df87a7cf_697c0bb5","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":21},"in_reply_to":"df87a7cf_a96f7390","updated":"2017-12-06 15:28:08.000000000","message":"it should not be - but for consistency, I\u0027d like to leave it in, unless there is opposition to this.","commit_id":"bc6f05d6c3b2b548256e4f2c47749840dfb4319d"}],"tools/deployment/developer/wait-for-pods.sh":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"9b98a2c993426af7009c5e3f4902fae19ae6e732","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"set -e"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# From Kolla-Kubernetes, orginal authors Kevin Fox \u0026 Serguei Bezverkhi"},{"line_number":19,"context_line":"# Default wait timeout is 300 seconds"}],"source_content_type":"text/x-sh","patch_set":32,"id":"df87a7cf_3b8e40d0","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":6},"updated":"2017-12-06 22:12:29.000000000","message":"-xe?","commit_id":"704cbcbcea6684d2c9e9c03ec7e6696119e56425"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"212f0dd27eb3ff41b0ef8669f843f2ea5828db7b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"set -e"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# From Kolla-Kubernetes, orginal authors Kevin Fox \u0026 Serguei Bezverkhi"},{"line_number":19,"context_line":"# Default wait timeout is 300 seconds"}],"source_content_type":"text/x-sh","patch_set":32,"id":"df87a7cf_1bac9c32","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":6},"in_reply_to":"df87a7cf_3b8e40d0","updated":"2017-12-06 22:39:16.000000000","message":"here we use only -e, as -x would be too verbose.","commit_id":"704cbcbcea6684d2c9e9c03ec7e6696119e56425"}],"tools/gate/playbooks/dev-deploy.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"9b98a2c993426af7009c5e3f4902fae19ae6e732","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  tasks:"},{"line_number":17,"context_line":"    - name: Deploy Required packages"},{"line_number":18,"context_line":"      shell: |"},{"line_number":19,"context_line":"        set -xe;"},{"line_number":20,"context_line":"        ./tools/deployment/developer/00-install-packages.sh"},{"line_number":21,"context_line":"      args:"},{"line_number":22,"context_line":"        chdir: \"{{ zuul.project.src_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"df87a7cf_9b5c2c7f","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":16},"updated":"2017-12-06 22:12:29.000000000","message":"technically redundant since you already set -xe; in the scripts.","commit_id":"73786c1616e88ffadd0f04454eca620955bdb96c"}]}