)]}'
{"id":"openstack%2Fopenstack-helm~523479","triplet_id":"openstack%2Fopenstack-helm~master~Ib008e36426de65fd90c79166349b6d4a4f5abf3d","project":"openstack/openstack-helm","branch":"master","topic":"be-gauche","hashtags":[],"change_id":"Ib008e36426de65fd90c79166349b6d4a4f5abf3d","subject":"[RFC] [DNM] (optionally) be gauche","status":"ABANDONED","created":"2017-11-28 17:20:06.000000000","updated":"2017-11-28 18:26:21.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"84c8dc9c0f581b85e4aa133e76858fd5d8bffa0f","_number":523479,"virtual_id_number":523479,"owner":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"actions":{},"labels":{"Verified":{"all":[{"date":"2017-11-28 18:20:05.000000000","_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"date":"2017-11-28 18:13:47.000000000","_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"value":-1,"date":"2017-11-28 18:06:35.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"date":"2017-11-28 18:21:07.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-11-28 18:06:35.000000000","updated_by":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"reviewer":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"state":"REVIEWER"},{"updated":"2017-11-28 18:13:47.000000000","updated_by":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"reviewer":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"state":"REVIEWER"},{"updated":"2017-11-28 18:21:07.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"}],"messages":[{"id":"a69f6b7577472e5f5e9beae280304e92ad4f1ae2","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2017-11-28 17:20:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dd64559ebfc85735cb696b5d44ce89f10d2b9868","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2017-11-28 17:20:17.000000000","message":"Patch Set 1:\n\nBuild Started http://10.24.20.18:30081/job/charts/job/openstack/job/openstack-helm/job/basic/2302/","accounts_in_message":[],"_revision_number":1},{"id":"d8157d6ead479ed51371ba40b33d0caacddd9eaa","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2017-11-28 17:23:34.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"89278c228d7364da29f8070924135bfc509439f9","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2017-11-28 17:26:17.000000000","message":"Patch Set 2:\n\nBuild Started http://10.24.20.18:30081/job/charts/job/openstack/job/openstack-helm/job/basic/2303/","accounts_in_message":[],"_revision_number":2},{"id":"d9f52320a05f332cc3e714654cc885d7a12ac440","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2017-11-28 18:06:24.000000000","message":"Patch Set 1:\n\nBuild Successful \n\nhttp://12.37.173.196:32775/repository/att-comdev-jenkins-logs/openstack-helm/org.openstack.helm/2302/org.openstack.helm-2302.x-gtar : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"d1d91a6a0bf1f8600059d6741c3734d549fa1aee","author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"date":"2017-11-28 18:06:35.000000000","message":"Patch Set 2: Code-Review-1\n\nWe tried an overarching \"no frills\" approach once before, namely \"developer mode\" that quickly fell apart.  Would it not make more sense to simply allow enabling or disabling the life cycle declarations (defaulting to enabled as it functions today) and developers could tap into it? We had discussed that instead of a \"global\" flag, a \"dev-values.yaml\" could exist that turns on and off the appropriate things.","accounts_in_message":[],"_revision_number":2},{"id":"20525c0d64434bb6d6b0069c1c6761c54cac3945","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2017-11-28 18:13:47.000000000","message":"Patch Set 2:\n\nBuild Successful \n\nhttp://12.37.173.196:32775/repository/att-comdev-jenkins-logs/openstack-helm/org.openstack.helm/2303/org.openstack.helm-2303.x-gtar : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"81158bee13cafe3d32883166ab85b5571e0e66e5","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2017-11-28 18:20:05.000000000","message":"Patch Set 2:\n\n\u003e We tried an overarching \"no frills\" approach once before, namely\n \u003e \"developer mode\" that quickly fell apart.  Would it not make more\n \u003e sense to simply allow enabling or disabling the life cycle\n \u003e declarations (defaulting to enabled as it functions today) and\n \u003e developers could tap into it? We had discussed that instead of a\n \u003e \"global\" flag, a \"dev-values.yaml\" could exist that turns on and\n \u003e off the appropriate things.\n\nie.\n\nfoo:\n  bar:\n    lifecycle:\n      preStop: null\n\n?","accounts_in_message":[],"_revision_number":2},{"id":"f8ffb3b8b35f1e58b8cc1221fa2db6b3890d9e6d","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2017-11-28 18:21:07.000000000","message":"Patch Set 2:\n\nLexicon beside - I concur with alan, also I must confess not being sure of when you would want to enable this option.","accounts_in_message":[],"_revision_number":2},{"id":"0707122844ee91ae39243bd19b5cd2ddc12c7f14","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2017-11-28 18:26:21.000000000","message":"Abandoned\n\nthe people hath spoken","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"fb38401f88c324f0151ccf69d8fcd440b17b6d58","revisions":{"6cabca05bbd142c8ac2f9fe87c82d7886172860a":{"kind":"REWORK","_number":1,"created":"2017-11-28 17:20:06.000000000","uploader":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"ref":"refs/changes/79/523479/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/79/523479/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/79/523479/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/79/523479/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/79/523479/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/79/523479/1"}}},"commit":{"parents":[{"commit":"7d7cf484ee33623973577fe73b356ba45def2865","subject":"Fixed helm_dry_run path issue","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/7d7cf484ee33623973577fe73b356ba45def2865"}]}],"author":{"name":"Chris Wedgwood","email":"cw@f00f.org","date":"2017-11-28 17:18:16.000000000","tz":0},"committer":{"name":"Chris Wedgwood","email":"cw@f00f.org","date":"2017-11-28 17:18:16.000000000","tz":0},"subject":"[RFC] [DNM] (optionally) be gauche","message":"[RFC] [DNM] (optionally) be gauche\n\nWhen testing for development and/or gate jobs we might want to skip\nsome lifecycle actions (currently only preStop) where it\u0027s not needed\nor useful.\n\nChange-Id: Ib008e36426de65fd90c79166349b6d4a4f5abf3d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/6cabca05bbd142c8ac2f9fe87c82d7886172860a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/6cabca05bbd142c8ac2f9fe87c82d7886172860a"}]},"branch":"refs/heads/master"},"fb38401f88c324f0151ccf69d8fcd440b17b6d58":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2017-11-28 17:23:34.000000000","uploader":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"ref":"refs/changes/79/523479/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/79/523479/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/79/523479/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/79/523479/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/79/523479/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/79/523479/2"}}},"commit":{"parents":[{"commit":"7d7cf484ee33623973577fe73b356ba45def2865","subject":"Fixed helm_dry_run path issue","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/7d7cf484ee33623973577fe73b356ba45def2865"}]}],"author":{"name":"Chris Wedgwood","email":"cw@f00f.org","date":"2017-11-28 17:18:16.000000000","tz":0},"committer":{"name":"Chris Wedgwood","email":"cw@f00f.org","date":"2017-11-28 17:22:28.000000000","tz":0},"subject":"[RFC] [DNM] (optionally) be gauche","message":"[RFC] [DNM] (optionally) be gauche\n\nFor testing and development we might want to skip some lifecycle\naction when not useful.\n\nChange-Id: Ib008e36426de65fd90c79166349b6d4a4f5abf3d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/fb38401f88c324f0151ccf69d8fcd440b17b6d58"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/fb38401f88c324f0151ccf69d8fcd440b17b6d58"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
