)]}'
{"id":"openstack%2Fopenstack-helm~526660","triplet_id":"openstack%2Fopenstack-helm~master~I93e66abb844f0e035b962bdae04f4180962a8eca","project":"openstack/openstack-helm","branch":"master","topic":"bp/add-osd-device-targetting","hashtags":[],"change_id":"I93e66abb844f0e035b962bdae04f4180962a8eca","subject":"Add osd device targetting","status":"ABANDONED","created":"2017-12-08 11:47:12.000000000","updated":"2020-07-15 19:26:40.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8d92e2e409f1860dc01d204c70e35fa003e46215","_number":526660,"virtual_id_number":526660,"owner":{"_account_id":24484,"name":"rongzhang","email":"rong.zhang@easystack.cn","username":"rongzhang"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":-1,"date":"2017-12-08 13:34:59.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2017-12-11 02:27:28.000000000","_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"date":"2017-12-08 12:26:36.000000000","_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},{"date":"2017-12-12 11:34:19.000000000","_account_id":24484,"name":"rongzhang","email":"rong.zhang@easystack.cn","username":"rongzhang"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"value":-1,"date":"2017-12-09 22:40:17.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":24484,"name":"rongzhang","email":"rong.zhang@easystack.cn","username":"rongzhang"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":24484,"name":"rongzhang","email":"rong.zhang@easystack.cn","username":"rongzhang"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":24484,"name":"rongzhang","email":"rong.zhang@easystack.cn","username":"rongzhang"},{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-12-08 12:26:36.000000000","updated_by":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"reviewer":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"state":"REVIEWER"},{"updated":"2017-12-08 13:34:59.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2017-12-09 22:40:17.000000000","updated_by":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"reviewer":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"state":"REVIEWER"},{"updated":"2017-12-11 02:27:28.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"}],"messages":[{"id":"5ed3643329362adcbdcc7adc1fa01fcd197689fe","author":{"_account_id":24484,"name":"rongzhang","email":"rong.zhang@easystack.cn","username":"rongzhang"},"date":"2017-12-08 11:47:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4398542af3f7d62b53c344724864bbfd3806b4c6","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2017-12-08 11:47:20.000000000","message":"Patch Set 1:\n\nBuild Started http://10.24.20.18:30081/job/charts/job/openstack/job/openstack-helm/job/basic/2447/","accounts_in_message":[],"_revision_number":1},{"id":"8d6a5e3f70bc20cea24d751323c35ed523981b5d","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2017-12-08 12:26:36.000000000","message":"Patch Set 1:\n\nBuild Failed \n\nhttp://12.37.173.196:32775/repository/att-comdev-jenkins-logs/openstack-helm/org.openstack.helm/2447/org.openstack.helm-2447.x-gtar : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"edc4f3f5a5f368dfe337210f5c66dcd3593178f9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-08 13:34:59.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs http://logs.openstack.org/60/526660/1/check/build-openstack-sphinx-docs/fed0fc9/html/ : SUCCESS in 3m 04s\n- openstack-helm-linter http://logs.openstack.org/60/526660/1/check/openstack-helm-linter/be4aa90/ : SUCCESS in 1m 45s\n- openstack-helm-dev-deploy http://logs.openstack.org/60/526660/1/check/openstack-helm-dev-deploy/3fc085a/ : FAILURE in 19m 02s\n- openstack-helm-legacy-ubuntu-vm-ovs-radosgw http://logs.openstack.org/60/526660/1/check/openstack-helm-legacy-ubuntu-vm-ovs-radosgw/96ad7aa/ : FAILURE in 45m 51s (non-voting)\n- openstack-helm-legacy-ubuntu-vm-lb-radosgw http://logs.openstack.org/60/526660/1/check/openstack-helm-legacy-ubuntu-vm-lb-radosgw/4bf9f2e/ : FAILURE in 40m 42s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d8489abbe45d515906f9a8e3071e3cb1d8c4d49c","author":{"_account_id":20443,"name":"Larry Rensing","email":"larry.rensing@gmail.com","username":"lr699s"},"date":"2017-12-09 22:40:17.000000000","message":"Patch Set 1: Code-Review-1\n\nThis looks a lot like the initial implementation of https://review.openstack.org/#/c/457754/\n\nIt\u0027d be great to have you weigh in there, in order to avoid duplication of work.","accounts_in_message":[],"_revision_number":1},{"id":"f0a739f948c3604decb3500a6a21cdc10f37bf43","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2017-12-11 02:27:28.000000000","message":"Patch Set 1:\n\n\u003e This looks a lot like the initial implementation of\n \u003e https://review.openstack.org/#/c/457754/\n \u003e \n \u003e It\u0027d be great to have you weigh in there, in order to avoid\n \u003e duplication of work.\n\nLarry - as we discussed in kubecon we think the original disc targetting PS has grown to the point where it is unreviewable, as its scope has grown along with its age. Therefore starting a new set of PS\u0027s to address the features that the original PS covered makes the most sense for the path forward, as part of this I\u0027d ideally like to see dave kormann\u0027s PS in (https://review.openstack.org/#/c/497417/) to bring more robustness to the monitoring and deployment of ceph, before we migrate to luminous based on the work that rootfs performed. Once these are in place then we are in a good place to start afresh with the device targeting work.","accounts_in_message":[],"_revision_number":1},{"id":"f78ee3498e9b51fb915d9a3b59fad5d210f1f2cd","author":{"_account_id":24484,"name":"rongzhang","email":"rong.zhang@easystack.cn","username":"rongzhang"},"date":"2017-12-12 11:34:19.000000000","message":"Patch Set 1:\n\nI feel this is a bit complicated(https://review.openstack.org/#/c/457754/), we can take advantage of this project\u0027s code(https://github.com/ceph/ceph-container/blob/master/ceph-releases/jewel/ubuntu/14.04/daemon/entrypoint.sh.in), we only need a small amount of changes, such as just need to write a yaml file, to simplify our code. It defines a variety of osd_type to handle different situations.","accounts_in_message":[],"_revision_number":1},{"id":"21db59b221b37121dc4c99cd46bfdb4b9489d5c9","author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"date":"2020-07-15 19:26:40.000000000","message":"Abandoned\n\nAbandoning since there hasn\u0027t been any recent activity, if anyone wants to continue this work, please feel free to restore this.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"bfa7abcc904dce93570c215ab7c3d55e4c89471f","revisions":{"bfa7abcc904dce93570c215ab7c3d55e4c89471f":{"kind":"REWORK","_number":1,"created":"2017-12-08 11:47:12.000000000","uploader":{"_account_id":24484,"name":"rongzhang","email":"rong.zhang@easystack.cn","username":"rongzhang"},"ref":"refs/changes/60/526660/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/60/526660/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/60/526660/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/60/526660/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/60/526660/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/60/526660/1"}}},"commit":{"parents":[{"commit":"eaadfa6e934ae3aa772e9368f819d1fb0cedde1c","subject":"Merge \"Docs: Updated developer documentation to use -infra repo\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/eaadfa6e934ae3aa772e9368f819d1fb0cedde1c"}]}],"author":{"name":"rong.zhang","email":"rong.zhang@easystack.cn","date":"2017-12-08 11:45:07.000000000","tz":480},"committer":{"name":"rong.zhang","email":"rong.zhang@easystack.cn","date":"2017-12-08 11:45:07.000000000","tz":480},"subject":"Add osd device targetting","message":"Add osd device targetting\n\nAdd osd device targetting\n\nChange-Id: I93e66abb844f0e035b962bdae04f4180962a8eca\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/bfa7abcc904dce93570c215ab7c3d55e4c89471f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/bfa7abcc904dce93570c215ab7c3d55e4c89471f"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"eaadfa6e934ae3aa772e9368f819d1fb0cedde1c","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}