)]}'
{"id":"openstack%2Fopenstack-helm~530431","triplet_id":"openstack%2Fopenstack-helm~master~I37e8d8c1a0d587410811c544e049bbafed73cba8","project":"openstack/openstack-helm","branch":"master","topic":"rbac-refactor","hashtags":[],"change_id":"I37e8d8c1a0d587410811c544e049bbafed73cba8","subject":"RBAC: Fix issue with inclusion of empty jobs or daemonsets","status":"MERGED","created":"2017-12-29 04:05:57.000000000","updated":"2017-12-29 15:38:44.000000000","submitted":"2017-12-29 15:34:02.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"530431-1514561642864-7f84d19e","meta_rev_id":"f2757d8620936a49a419c7aea350765f75c14fc8","_number":530431,"virtual_id_number":530431,"owner":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2017-12-29 05:58:04.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"date":"2017-12-29 04:11:28.000000000","_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"value":2,"date":"2017-12-29 15:34:02.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"all":[{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":2,"date":"2017-12-29 14:00:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2017-12-29 14:50:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"all":[{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2017-12-29 14:50:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-12-29 04:11:28.000000000","updated_by":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"reviewer":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"state":"REVIEWER"},{"updated":"2017-12-29 14:00:43.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2017-12-29 14:50:33.000000000","updated_by":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"reviewer":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"state":"REVIEWER"},{"updated":"2017-12-29 15:34:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e67c218b00142250692e646617e1bfd3c6d661f0","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2017-12-29 04:05:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ba20ec0386af00ad3ceb72ee3d390389aaf3deb2","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2017-12-29 04:06:09.000000000","message":"Patch Set 1:\n\nBuild Started http://10.24.20.18:30081/job/charts/job/openstack/job/openstack-helm/job/basic/2766/","accounts_in_message":[],"_revision_number":1},{"id":"3a2971503b7cb4a934206555cd933f388b58b541","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2017-12-29 04:11:28.000000000","message":"Patch Set 1:\n\nBuild Failed \n\nhttp://12.37.173.196:32775/repository/att-comdev-jenkins-logs/openstack/openstack-helm/2766/openstack-helm-2766 : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"135a0b250f7807502c82a2c405b6539c892c3414","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-29 05:52:08.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs http://logs.openstack.org/31/530431/1/check/build-openstack-sphinx-docs/3d6a449/html/ : SUCCESS in 3m 09s\n- openstack-helm-linter http://logs.openstack.org/31/530431/1/check/openstack-helm-linter/4482015/ : SUCCESS in 1m 11s\n- openstack-helm-dev-deploy http://logs.openstack.org/31/530431/1/check/openstack-helm-dev-deploy/582532b/ : FAILURE in 34m 26s\n- openstack-helm-legacy-ubuntu-vm-ovs-radosgw http://logs.openstack.org/31/530431/1/check/openstack-helm-legacy-ubuntu-vm-ovs-radosgw/12dcc1a/ : FAILURE in 1h 45m 17s (non-voting)\n- openstack-helm-legacy-ubuntu-vm-lb-radosgw http://logs.openstack.org/31/530431/1/check/openstack-helm-legacy-ubuntu-vm-lb-radosgw/b2cf492/ : FAILURE in 47m 53s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a1f87a8b159285abb9cc9038f99f511fd204fa01","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2017-12-29 05:58:04.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"e12fa03154a9e7aaad6937c6624d2da445512e5e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-29 07:20:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/31/530431/1/check/build-openstack-sphinx-docs/481122a/html/ : SUCCESS in 4m 56s\n- openstack-helm-linter http://logs.openstack.org/31/530431/1/check/openstack-helm-linter/fd59daf/ : SUCCESS in 1m 17s\n- openstack-helm-dev-deploy http://logs.openstack.org/31/530431/1/check/openstack-helm-dev-deploy/6b210c9/ : SUCCESS in 54m 37s\n- openstack-helm-legacy-ubuntu-vm-ovs-radosgw http://logs.openstack.org/31/530431/1/check/openstack-helm-legacy-ubuntu-vm-ovs-radosgw/77e36f0/ : FAILURE in 55m 07s (non-voting)\n- openstack-helm-legacy-ubuntu-vm-lb-radosgw http://logs.openstack.org/31/530431/1/check/openstack-helm-legacy-ubuntu-vm-lb-radosgw/e76679f/ : FAILURE in 1h 20m 01s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a9b1c61dbd19f7a13fef871a818af51604986822","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2017-12-29 14:00:43.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c39adad3c01ca23cf10acbaf5d9cc0bfe7268cbc","author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"date":"2017-12-29 14:50:33.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"633fa89a519d110f5709d2efce66df76cd7f0fa6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-29 14:50:44.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"fdf418e56cff957a23c51701504b59e432143b36","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-29 15:34:02.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"c36b47cb9303ce6d49d8740f1393edc7816bc8ff","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-29 15:34:02.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/31/530431/1/gate/build-openstack-sphinx-docs/b9c5557/html/ : SUCCESS in 3m 10s\n- openstack-helm-linter http://logs.openstack.org/31/530431/1/gate/openstack-helm-linter/864ec00/ : SUCCESS in 1m 09s\n- openstack-helm-dev-deploy http://logs.openstack.org/31/530431/1/gate/openstack-helm-dev-deploy/dd105a0/ : SUCCESS in 43m 09s","accounts_in_message":[],"_revision_number":1},{"id":"196bf978d55c0b2a5176f1fea40776134bc9499b","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2017-12-29 15:38:44.000000000","message":"Patch Set 1:\n\nBuild Failed \n\nhttp://12.37.173.196:32775/repository/att-comdev-jenkins-logs/openstack/openstack-helm/2772/openstack-helm-2772 : FAILURE","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"943a400b9a5e351a62bab6715922a83430ba2bd7","revisions":{"943a400b9a5e351a62bab6715922a83430ba2bd7":{"kind":"REWORK","_number":1,"created":"2017-12-29 04:05:57.000000000","uploader":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"ref":"refs/changes/31/530431/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/31/530431/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/31/530431/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/31/530431/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/31/530431/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/31/530431/1"}}},"commit":{"parents":[{"commit":"9fb2bdf839747f484001ce32432bcf32094bf1be","subject":"Docs: remove potentially confusing references to versions and RBAC","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/9fb2bdf839747f484001ce32432bcf32094bf1be"}]}],"author":{"name":"Tin Lam","email":"tin@irrational.io","date":"2017-12-29 04:04:55.000000000","tz":-360},"committer":{"name":"Tin Lam","email":"tin@irrational.io","date":"2017-12-29 04:05:34.000000000","tz":-360},"subject":"RBAC: Fix issue with inclusion of empty jobs or daemonsets","message":"RBAC: Fix issue with inclusion of empty jobs or daemonsets\n\nCurrently, the rbac logic would allow for ``jobs`` or ``daemonsets``\nif it is specified in the dependencies, even if they may just be empty\nor null.  This patch set addresses this by checking the jobs or\ndaemonsets map in the value.yaml is non-empty before including it\nin the Role.\n\nThis mirrors the fix in OSH-infra in [0].\n\n[0] https://review.openstack.org/#/c/530337/1\n\nChange-Id: I37e8d8c1a0d587410811c544e049bbafed73cba8\nSigned-off-by: Tin Lam \u003ctin@irrational.io\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/943a400b9a5e351a62bab6715922a83430ba2bd7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/943a400b9a5e351a62bab6715922a83430ba2bd7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
