)]}'
{"mariadb/templates/monitoring/prometheus/bin/_create-mysql-user.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"78201b78776c95ee8e1db41cfb11348310630463","unresolved":false,"context_lines":[{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"set -ex"},{"line_number":20,"context_line":"COMMAND\u003d\"${@:-start}\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function create_user () {"},{"line_number":23,"context_line":"  mysql --defaults-file\u003d/etc/mysql/admin_user.cnf -e \\"},{"line_number":24,"context_line":"    \"CREATE OR REPLACE USER \u0027${EXPORTER_USER}\u0027@\u0027%\u0027 IDENTIFIED BY \u0027${EXPORTER_PASSWORD}\u0027; \\"},{"line_number":25,"context_line":"     GRANT PROCESS, REPLICATION CLIENT, SELECT ON *.* TO \u0027${EXPORTER_USER}\u0027@\u0027%\u0027; \\"},{"line_number":26,"context_line":"     FLUSH PRIVILEGES;\""},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"function start () {"},{"line_number":30,"context_line":"  create_user"},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"function stop () {"},{"line_number":34,"context_line":"  kill -TERM 1"},{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"$COMMAND"}],"source_content_type":"text/x-smarty","patch_set":15,"id":"3fa0c359_9a4a4125","line":37,"range":{"start_line":20,"start_character":0,"end_line":37,"end_character":8},"updated":"2018-02-06 02:18:25.000000000","message":"we don\u0027t need the functions here - it\u0027s just a job.","commit_id":"f3c0fa939a68df3151e12c04ef79b1f3a748d6db"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"41a870d24d5840ad4c07525862bd96a01ceea3cb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"set -ex"},{"line_number":20,"context_line":"COMMAND\u003d\"${@:-start}\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function create_user () {"},{"line_number":23,"context_line":"  mysql --defaults-file\u003d/etc/mysql/admin_user.cnf -e \\"},{"line_number":24,"context_line":"    \"CREATE OR REPLACE USER \u0027${EXPORTER_USER}\u0027@\u0027%\u0027 IDENTIFIED BY \u0027${EXPORTER_PASSWORD}\u0027; \\"},{"line_number":25,"context_line":"     GRANT PROCESS, REPLICATION CLIENT, SELECT ON *.* TO \u0027${EXPORTER_USER}\u0027@\u0027%\u0027; \\"},{"line_number":26,"context_line":"     FLUSH PRIVILEGES;\""},{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"function start () {"},{"line_number":30,"context_line":"  create_user"},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"function stop () {"},{"line_number":34,"context_line":"  kill -TERM 1"},{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"$COMMAND"}],"source_content_type":"text/x-smarty","patch_set":15,"id":"3fa0c359_3a7e8de4","line":37,"range":{"start_line":20,"start_character":0,"end_line":37,"end_character":8},"in_reply_to":"3fa0c359_9a4a4125","updated":"2018-02-06 02:48:29.000000000","message":"Done","commit_id":"f3c0fa939a68df3151e12c04ef79b1f3a748d6db"}],"mariadb/templates/monitoring/prometheus/bin/_helm-tests.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"78201b78776c95ee8e1db41cfb11348310630463","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"3fa0c359_7a5175d8","updated":"2018-02-06 02:18:25.000000000","message":"these tests dont look to run?","commit_id":"f3c0fa939a68df3151e12c04ef79b1f3a748d6db"}],"mariadb/templates/monitoring/prometheus/exporter-deployment.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"75412db94e85a656ade4ec51d871f0ee18bbe5f3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"{{- $dependencies :\u003d .Values.dependencies.prometheus_mysql_exporter }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{- $mariadb_user :\u003d .Values.endpoints.oslo_db.auth.admin.username }}"},{"line_number":22,"context_line":"{{- $mariadb_pass :\u003d .Values.endpoints.oslo_db.auth.admin.password }}"},{"line_number":23,"context_line":"{{- $mariadb_fqdn :\u003d tuple \"oslo_db\" \"internal\" . | include \"helm-toolkit.endpoints.hostname_fqdn_endpoint_lookup\" }}"},{"line_number":24,"context_line":"{{- $mariadb_port :\u003d tuple \"oslo_db\" \"internal\" \"mysql\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":25,"context_line":"{{- $mysql_data_source :\u003d printf \"%s:%s@(%s:%s)/\" $mariadb_user $mariadb_pass $mariadb_fqdn $mariadb_port }}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"{{- $serviceAccountName :\u003d \"prometheus-mysql-exporter\"}}"},{"line_number":28,"context_line":"{{ tuple $envAll $dependencies $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f91af0f_ac20ca49","line":25,"range":{"start_line":21,"start_character":0,"end_line":25,"end_character":108},"updated":"2018-01-08 04:05:11.000000000","message":"should we not use a read-only user for this activity?","commit_id":"7b4e392128cfe19e8e42be72f46ffd789475b461"}],"mariadb/values.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"cb265af399d58f6b7d608293f4e589dd03a18d76","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    server: 3"},{"line_number":41,"context_line":"    prometheus_mysql_exporter: 1"},{"line_number":42,"context_line":"  lifecycle:"},{"line_number":43,"context_line":"    upgrades:"},{"line_number":44,"context_line":"      revision_history: 3"},{"line_number":45,"context_line":"      pod_replacement_strategy: RollingUpdate"},{"line_number":46,"context_line":"      rolling_update:"},{"line_number":47,"context_line":"        max_unavailable: 1"},{"line_number":48,"context_line":"        max_surge: 3"},{"line_number":49,"context_line":"    termination_grace_period:"},{"line_number":50,"context_line":"      prometheus_mysql_exporter:"},{"line_number":51,"context_line":"        timeout: 30"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa0c359_daa4490b","line":48,"range":{"start_line":43,"start_character":0,"end_line":48,"end_character":20},"updated":"2018-02-06 02:17:08.000000000","message":"This should match other charts, eg:\n * https://github.com/openstack/openstack-helm/blob/master/nova/values.yaml#L1361-L1372\n * https://github.com/openstack/openstack-helm/blob/master/glance/values.yaml#L539-L544","commit_id":"f3c0fa939a68df3151e12c04ef79b1f3a748d6db"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"94ce14a522cf89e7bb11cd0bbc1d5a44de5f05d9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    server: 3"},{"line_number":41,"context_line":"    prometheus_mysql_exporter: 1"},{"line_number":42,"context_line":"  lifecycle:"},{"line_number":43,"context_line":"    upgrades:"},{"line_number":44,"context_line":"      revision_history: 3"},{"line_number":45,"context_line":"      pod_replacement_strategy: RollingUpdate"},{"line_number":46,"context_line":"      rolling_update:"},{"line_number":47,"context_line":"        max_unavailable: 1"},{"line_number":48,"context_line":"        max_surge: 3"},{"line_number":49,"context_line":"    termination_grace_period:"},{"line_number":50,"context_line":"      prometheus_mysql_exporter:"},{"line_number":51,"context_line":"        timeout: 30"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa0c359_5ac5993b","line":48,"range":{"start_line":43,"start_character":0,"end_line":48,"end_character":20},"in_reply_to":"3fa0c359_daa4490b","updated":"2018-02-06 02:33:32.000000000","message":"Done","commit_id":"f3c0fa939a68df3151e12c04ef79b1f3a748d6db"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"cb265af399d58f6b7d608293f4e589dd03a18d76","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"monitoring:"},{"line_number":124,"context_line":"  prometheus:"},{"line_number":125,"context_line":"    enabled: true"},{"line_number":126,"context_line":"    mysqld_exporter:"},{"line_number":127,"context_line":"      scrape: true"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa0c359_baab7dd4","line":125,"range":{"start_line":125,"start_character":4,"end_line":125,"end_character":17},"updated":"2018-02-06 02:17:08.000000000","message":"this should be the other way round, the manifests enabled, but the feature disabled.","commit_id":"f3c0fa939a68df3151e12c04ef79b1f3a748d6db"}],"rabbitmq/templates/monitoring/prometheus/bin/_helm-tests.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"75412db94e85a656ade4ec51d871f0ee18bbe5f3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  done"},{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"#TODO(srwilkers): This wont be activated until mariadb is moved to OSH-infra"},{"line_number":39,"context_line":"function check_mysql_status () {"},{"line_number":40,"context_line":"  echo \"Querying Prometheus for MySQL status\""},{"line_number":41,"context_line":"  mysql_status\u003d$(curl \"${PROMETHEUS_ENDPOINT}/api/v1/query?query\u003dmysql_up\" \\"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"9f91af0f_4c19fe1f","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":76},"updated":"2018-01-08 04:05:11.000000000","message":"should both of these not be activated now?","commit_id":"7b4e392128cfe19e8e42be72f46ffd789475b461"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"76ddc386dced7d27bf31d9dcf02d1302f8240fc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"3fa0c359_da59a9fe","updated":"2018-02-06 02:18:42.000000000","message":"do these tests run?","commit_id":"f3c0fa939a68df3151e12c04ef79b1f3a748d6db"}],"rabbitmq/templates/monitoring/prometheus/exporter-configmap-bin.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"cb265af399d58f6b7d608293f4e589dd03a18d76","unresolved":false,"context_lines":[{"line_number":21,"context_line":"apiVersion: v1"},{"line_number":22,"context_line":"kind: ConfigMap"},{"line_number":23,"context_line":"metadata:"},{"line_number":24,"context_line":"  name: rabbitmq-exporter-bin"},{"line_number":25,"context_line":"data:"},{"line_number":26,"context_line":"  helm-tests.sh: |"},{"line_number":27,"context_line":"{{ tuple \"bin/_helm-tests.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa0c359_1a84f15d","line":24,"updated":"2018-02-06 02:17:08.000000000","message":"this needs to be prefixed with the release name, otherwise, collisions will occur.","commit_id":"f3c0fa939a68df3151e12c04ef79b1f3a748d6db"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"94ce14a522cf89e7bb11cd0bbc1d5a44de5f05d9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"apiVersion: v1"},{"line_number":22,"context_line":"kind: ConfigMap"},{"line_number":23,"context_line":"metadata:"},{"line_number":24,"context_line":"  name: rabbitmq-exporter-bin"},{"line_number":25,"context_line":"data:"},{"line_number":26,"context_line":"  helm-tests.sh: |"},{"line_number":27,"context_line":"{{ tuple \"bin/_helm-tests.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa0c359_fab6e5d9","line":24,"in_reply_to":"3fa0c359_1a84f15d","updated":"2018-02-06 02:33:32.000000000","message":"Done","commit_id":"f3c0fa939a68df3151e12c04ef79b1f3a748d6db"}],"rabbitmq/templates/monitoring/prometheus/exporter-deployment.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"cb265af399d58f6b7d608293f4e589dd03a18d76","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.monitoring.prometheus.deployment_exporter }}"},{"line_number":18,"context_line":"{{- if .Values.monitoring.prometheus.enabled }}"},{"line_number":19,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":20,"context_line":"{{- $dependencies :\u003d .Values.dependencies.prometheus_rabbitmq_exporter }}"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa0c359_faf7c5f4","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":47},"updated":"2018-02-06 02:17:08.000000000","message":"this would be neater as a single line","commit_id":"f3c0fa939a68df3151e12c04ef79b1f3a748d6db"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"41a870d24d5840ad4c07525862bd96a01ceea3cb","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.monitoring.prometheus.deployment_exporter }}"},{"line_number":18,"context_line":"{{- if .Values.monitoring.prometheus.enabled }}"},{"line_number":19,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":20,"context_line":"{{- $dependencies :\u003d .Values.dependencies.prometheus_rabbitmq_exporter }}"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa0c359_3a51ad37","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":47},"in_reply_to":"3fa0c359_faf7c5f4","updated":"2018-02-06 02:48:29.000000000","message":"This is consistent with the other charts in openstack-helm at the moment","commit_id":"f3c0fa939a68df3151e12c04ef79b1f3a748d6db"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"cb265af399d58f6b7d608293f4e589dd03a18d76","unresolved":false,"context_lines":[{"line_number":19,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":20,"context_line":"{{- $dependencies :\u003d .Values.dependencies.prometheus_rabbitmq_exporter }}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{{- $serviceAccountName :\u003d \"prometheus-rabbitmq-exporter\"}}"},{"line_number":23,"context_line":"{{ tuple $envAll $dependencies $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":24,"context_line":"---"},{"line_number":25,"context_line":"apiVersion: extensions/v1beta1"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa0c359_fa82654f","line":22,"range":{"start_line":22,"start_character":28,"end_line":22,"end_character":56},"updated":"2018-02-06 02:17:08.000000000","message":"needs to be prefixed with the release name, to prevent a collision.","commit_id":"f3c0fa939a68df3151e12c04ef79b1f3a748d6db"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"94ce14a522cf89e7bb11cd0bbc1d5a44de5f05d9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":20,"context_line":"{{- $dependencies :\u003d .Values.dependencies.prometheus_rabbitmq_exporter }}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{{- $serviceAccountName :\u003d \"prometheus-rabbitmq-exporter\"}}"},{"line_number":23,"context_line":"{{ tuple $envAll $dependencies $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":24,"context_line":"---"},{"line_number":25,"context_line":"apiVersion: extensions/v1beta1"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa0c359_5aacb98b","line":22,"range":{"start_line":22,"start_character":28,"end_line":22,"end_character":56},"in_reply_to":"3fa0c359_fa82654f","updated":"2018-02-06 02:33:32.000000000","message":"Done","commit_id":"f3c0fa939a68df3151e12c04ef79b1f3a748d6db"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"cb265af399d58f6b7d608293f4e589dd03a18d76","unresolved":false,"context_lines":[{"line_number":25,"context_line":"apiVersion: extensions/v1beta1"},{"line_number":26,"context_line":"kind: Deployment"},{"line_number":27,"context_line":"metadata:"},{"line_number":28,"context_line":"  name: prometheus-rabbitmq-exporter"},{"line_number":29,"context_line":"spec:"},{"line_number":30,"context_line":"  replicas: {{ .Values.pod.replicas.prometheus_rabbitmq_exporter }}"},{"line_number":31,"context_line":"{{ tuple $envAll | include \"helm-toolkit.snippets.kubernetes_upgrades_deployment\" | indent 2 }}"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa0c359_5a911999","line":28,"range":{"start_line":28,"start_character":7,"end_line":28,"end_character":36},"updated":"2018-02-06 02:17:08.000000000","message":"needs to be prefixed with the release name, to prevent a collision.","commit_id":"f3c0fa939a68df3151e12c04ef79b1f3a748d6db"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"94ce14a522cf89e7bb11cd0bbc1d5a44de5f05d9","unresolved":false,"context_lines":[{"line_number":25,"context_line":"apiVersion: extensions/v1beta1"},{"line_number":26,"context_line":"kind: Deployment"},{"line_number":27,"context_line":"metadata:"},{"line_number":28,"context_line":"  name: prometheus-rabbitmq-exporter"},{"line_number":29,"context_line":"spec:"},{"line_number":30,"context_line":"  replicas: {{ .Values.pod.replicas.prometheus_rabbitmq_exporter }}"},{"line_number":31,"context_line":"{{ tuple $envAll | include \"helm-toolkit.snippets.kubernetes_upgrades_deployment\" | indent 2 }}"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa0c359_7aa97579","line":28,"range":{"start_line":28,"start_character":7,"end_line":28,"end_character":36},"in_reply_to":"3fa0c359_5a911999","updated":"2018-02-06 02:33:32.000000000","message":"Done","commit_id":"f3c0fa939a68df3151e12c04ef79b1f3a748d6db"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"ce50ef797e6dfcdf446f55f83ee7965290369fb2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":20,"context_line":"{{- $dependencies :\u003d .Values.dependencies.prometheus_rabbitmq_exporter }}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{{- $rcControllerName :\u003d printf \"%s-%s\" $envAll.Release.Name \"rabbitmq-exporter\"  }}"},{"line_number":23,"context_line":"{{ tuple $envAll $dependencies $rcControllerName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":24,"context_line":"---"},{"line_number":25,"context_line":"apiVersion: extensions/v1beta1"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3fa0c359_e04cf377","line":22,"range":{"start_line":22,"start_character":81,"end_line":22,"end_character":82},"updated":"2018-02-07 20:08:58.000000000","message":"nit: double space","commit_id":"9a4a7c4f7acfed0637713180afa59f1c2abff0b7"}],"rabbitmq/values.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"cb265af399d58f6b7d608293f4e589dd03a18d76","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    server: 3"},{"line_number":45,"context_line":"    prometheus_rabbitmq_exporter: 1"},{"line_number":46,"context_line":"  lifecycle:"},{"line_number":47,"context_line":"    upgrades:"},{"line_number":48,"context_line":"      revision_history: 3"},{"line_number":49,"context_line":"      pod_replacement_strategy: RollingUpdate"},{"line_number":50,"context_line":"      rolling_update:"},{"line_number":51,"context_line":"        max_unavailable: 1"},{"line_number":52,"context_line":"        max_surge: 3"},{"line_number":53,"context_line":"    termination_grace_period:"},{"line_number":54,"context_line":"      prometheus_rabbitmq_exporter:"},{"line_number":55,"context_line":"        timeout: 30"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa0c359_1ad2b15d","line":52,"range":{"start_line":47,"start_character":0,"end_line":52,"end_character":20},"updated":"2018-02-06 02:17:08.000000000","message":"as with mariadb this should specify the rc type","commit_id":"f3c0fa939a68df3151e12c04ef79b1f3a748d6db"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"cb265af399d58f6b7d608293f4e589dd03a18d76","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"monitoring:"},{"line_number":124,"context_line":"  prometheus:"},{"line_number":125,"context_line":"    enabled: true"},{"line_number":126,"context_line":"    rabbitmq_exporter:"},{"line_number":127,"context_line":"      scrape: true"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa0c359_dacbe9a2","line":125,"range":{"start_line":125,"start_character":4,"end_line":125,"end_character":17},"updated":"2018-02-06 02:17:08.000000000","message":"this should be false by default, and the manifests set to true","commit_id":"f3c0fa939a68df3151e12c04ef79b1f3a748d6db"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"94ce14a522cf89e7bb11cd0bbc1d5a44de5f05d9","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"monitoring:"},{"line_number":124,"context_line":"  prometheus:"},{"line_number":125,"context_line":"    enabled: true"},{"line_number":126,"context_line":"    rabbitmq_exporter:"},{"line_number":127,"context_line":"      scrape: true"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa0c359_9aa2419a","line":125,"range":{"start_line":125,"start_character":4,"end_line":125,"end_character":17},"in_reply_to":"3fa0c359_dacbe9a2","updated":"2018-02-06 02:33:32.000000000","message":"Done","commit_id":"f3c0fa939a68df3151e12c04ef79b1f3a748d6db"}],"tools/deployment/multinode/050-mariadb.sh":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"cb265af399d58f6b7d608293f4e589dd03a18d76","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    --namespace\u003dopenstack \\"},{"line_number":22,"context_line":"    --name\u003dmariadb \\"},{"line_number":23,"context_line":"    --set volume.enabled\u003dfalse \\"},{"line_number":24,"context_line":"    --set manifests.prometheus.configmap_bin\u003dtrue \\"},{"line_number":25,"context_line":"    --set manifests.prometheus.deployment_exporter\u003dtrue \\"},{"line_number":26,"context_line":"    --set manifests.prometheus.service_exporter\u003dtrue \\"},{"line_number":27,"context_line":"    --set manifests.prometheus.job_user_create\u003dtrue \\"},{"line_number":28,"context_line":"    --set manifests.prometheus.secret_etc\u003dtrue"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"#NOTE: Wait for deploy"},{"line_number":31,"context_line":"./tools/deployment/common/wait-for-pods.sh openstack"}],"source_content_type":"text/x-sh","patch_set":15,"id":"3fa0c359_9ac56191","line":28,"range":{"start_line":24,"start_character":0,"end_line":28,"end_character":46},"updated":"2018-02-06 02:17:08.000000000","message":"why are these turned on if there is nothing to collect the data?","commit_id":"f3c0fa939a68df3151e12c04ef79b1f3a748d6db"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"94ce14a522cf89e7bb11cd0bbc1d5a44de5f05d9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    --namespace\u003dopenstack \\"},{"line_number":22,"context_line":"    --name\u003dmariadb \\"},{"line_number":23,"context_line":"    --set volume.enabled\u003dfalse \\"},{"line_number":24,"context_line":"    --set manifests.prometheus.configmap_bin\u003dtrue \\"},{"line_number":25,"context_line":"    --set manifests.prometheus.deployment_exporter\u003dtrue \\"},{"line_number":26,"context_line":"    --set manifests.prometheus.service_exporter\u003dtrue \\"},{"line_number":27,"context_line":"    --set manifests.prometheus.job_user_create\u003dtrue \\"},{"line_number":28,"context_line":"    --set manifests.prometheus.secret_etc\u003dtrue"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"#NOTE: Wait for deploy"},{"line_number":31,"context_line":"./tools/deployment/common/wait-for-pods.sh openstack"}],"source_content_type":"text/x-sh","patch_set":15,"id":"3fa0c359_5a77d93b","line":28,"range":{"start_line":24,"start_character":0,"end_line":28,"end_character":46},"in_reply_to":"3fa0c359_9ac56191","updated":"2018-02-06 02:33:32.000000000","message":"Because the endpoint can still be scraped for the service\u0027s metrics regardless of whether Prometheus is deployed or not","commit_id":"f3c0fa939a68df3151e12c04ef79b1f3a748d6db"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"ce50ef797e6dfcdf446f55f83ee7965290369fb2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    --namespace\u003dopenstack \\"},{"line_number":22,"context_line":"    --name\u003dmariadb \\"},{"line_number":23,"context_line":"    --set volume.enabled\u003dfalse \\"},{"line_number":24,"context_line":"    --set monitoring.prometheus.enabled\u003dtrue"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"#NOTE: Wait for deploy"},{"line_number":27,"context_line":"./tools/deployment/common/wait-for-pods.sh openstack"}],"source_content_type":"text/x-sh","patch_set":21,"id":"3fa0c359_f73ec527","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":44},"updated":"2018-02-07 20:08:58.000000000","message":"I don\u0027t think we should enable monitoring functionality in a service, until the monitoring solution is part of the deployment.","commit_id":"853773e829670b2b81f3d3ed00f0f4ffb95f0897"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"86793611c2bad856dc021f61939615738edf7985","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    --namespace\u003dopenstack \\"},{"line_number":22,"context_line":"    --name\u003dmariadb \\"},{"line_number":23,"context_line":"    --set volume.enabled\u003dfalse \\"},{"line_number":24,"context_line":"    --set monitoring.prometheus.enabled\u003dtrue"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"#NOTE: Wait for deploy"},{"line_number":27,"context_line":"./tools/deployment/common/wait-for-pods.sh openstack"}],"source_content_type":"text/x-sh","patch_set":21,"id":"3fa0c359_9b444bb9","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":44},"in_reply_to":"3fa0c359_f73ec527","updated":"2018-02-07 21:49:24.000000000","message":"We can still check the endpoint to verify the exporter is functional. This is what we do in the gate currently: http://logs.openstack.org/75/531575/21/check/openstack-helm-multinode-ubuntu/01e4918/primary/prometheus/rabbitmq-exporter.txt","commit_id":"853773e829670b2b81f3d3ed00f0f4ffb95f0897"}],"tools/deployment/multinode/060-rabbitmq.sh":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"cb265af399d58f6b7d608293f4e589dd03a18d76","unresolved":false,"context_lines":[{"line_number":20,"context_line":"helm install ./rabbitmq \\"},{"line_number":21,"context_line":"    --namespace\u003dopenstack \\"},{"line_number":22,"context_line":"    --name\u003drabbitmq \\"},{"line_number":23,"context_line":"    --set manifests.prometheus.configmap_bin\u003dtrue \\"},{"line_number":24,"context_line":"    --set manifests.prometheus.deployment_exporter\u003dtrue \\"},{"line_number":25,"context_line":"    --set manifests.prometheus.service_exporter\u003dtrue"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"#NOTE: Wait for deploy"}],"source_content_type":"text/x-sh","patch_set":15,"id":"3fa0c359_5abfd9fa","line":25,"range":{"start_line":23,"start_character":0,"end_line":25,"end_character":52},"updated":"2018-02-06 02:17:08.000000000","message":"as with mariadb we should not turn this on unless the feature is exercised.","commit_id":"f3c0fa939a68df3151e12c04ef79b1f3a748d6db"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"94ce14a522cf89e7bb11cd0bbc1d5a44de5f05d9","unresolved":false,"context_lines":[{"line_number":20,"context_line":"helm install ./rabbitmq \\"},{"line_number":21,"context_line":"    --namespace\u003dopenstack \\"},{"line_number":22,"context_line":"    --name\u003drabbitmq \\"},{"line_number":23,"context_line":"    --set manifests.prometheus.configmap_bin\u003dtrue \\"},{"line_number":24,"context_line":"    --set manifests.prometheus.deployment_exporter\u003dtrue \\"},{"line_number":25,"context_line":"    --set manifests.prometheus.service_exporter\u003dtrue"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"#NOTE: Wait for deploy"}],"source_content_type":"text/x-sh","patch_set":15,"id":"3fa0c359_3a944d37","line":25,"range":{"start_line":23,"start_character":0,"end_line":25,"end_character":52},"in_reply_to":"3fa0c359_5abfd9fa","updated":"2018-02-06 02:33:32.000000000","message":"Same thing here","commit_id":"f3c0fa939a68df3151e12c04ef79b1f3a748d6db"}]}