)]}'
{"id":"openstack%2Fopenstack-helm~532724","triplet_id":"openstack%2Fopenstack-helm~master~Ie6b7e94e80d625c212331cf74c0f796bb3e99858","project":"openstack/openstack-helm","branch":"master","topic":"add_exporters","hashtags":[],"change_id":"Ie6b7e94e80d625c212331cf74c0f796bb3e99858","subject":"mgr: refactor mgr module enablement","status":"MERGED","created":"2018-01-11 04:28:31.000000000","updated":"2018-01-11 20:58:26.000000000","submitted":"2018-01-11 20:58:26.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"532724-1515704306365-9cedb2f7","meta_rev_id":"9092b3fad5c34bcdd20bcb3617b55c787e6cb9f8","_number":532724,"virtual_id_number":532724,"owner":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":27160,"name":"Alexandre Marangone","email":"amarango@redhat.com","username":"alram"},{"value":0,"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},{"value":2,"date":"2018-01-11 20:58:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},{"value":0,"_account_id":26509,"name":"Huamin Chen","email":"huamin.chen@gmail.com","username":"rootfs"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"all":[{"value":2,"date":"2018-01-11 19:38:59.000000000","_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":2,"date":"2018-01-11 19:40:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":27160,"name":"Alexandre Marangone","email":"amarango@redhat.com","username":"alram"},{"value":0,"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},{"value":1,"date":"2018-01-11 20:28:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":26509,"name":"Huamin Chen","email":"huamin.chen@gmail.com","username":"rootfs"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"all":[{"value":0,"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":1,"date":"2018-01-11 19:40:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":27160,"name":"Alexandre Marangone","email":"amarango@redhat.com","username":"alram"},{"value":0,"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},{"value":0,"_account_id":26509,"name":"Huamin Chen","email":"huamin.chen@gmail.com","username":"rootfs"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},{"_account_id":26509,"name":"Huamin Chen","email":"huamin.chen@gmail.com","username":"rootfs"},{"_account_id":27160,"name":"Alexandre Marangone","email":"amarango@redhat.com","username":"alram"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-01-11 04:28:31.000000000","updated_by":{"_account_id":27160,"name":"Alexandre Marangone","email":"amarango@redhat.com","username":"alram"},"reviewer":{"_account_id":27160,"name":"Alexandre Marangone","email":"amarango@redhat.com","username":"alram"},"state":"REVIEWER"},{"updated":"2018-01-11 04:29:36.000000000","updated_by":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"reviewer":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"state":"REVIEWER"},{"updated":"2018-01-11 19:38:59.000000000","updated_by":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"reviewer":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"state":"REVIEWER"},{"updated":"2018-01-11 19:40:19.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2018-01-11 20:28:24.000000000","updated_by":{"_account_id":26509,"name":"Huamin Chen","email":"huamin.chen@gmail.com","username":"rootfs"},"reviewer":{"_account_id":26509,"name":"Huamin Chen","email":"huamin.chen@gmail.com","username":"rootfs"},"state":"REVIEWER"},{"updated":"2018-01-11 20:58:26.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7f456cf7d762f68ac7739c53485e98396126cbaa","author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"date":"2018-01-11 04:28:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6dea64b17174cec18ba8297a6a44da17b324abbb","author":{"_account_id":26509,"name":"Huamin Chen","email":"huamin.chen@gmail.com","username":"rootfs"},"date":"2018-01-11 15:03:41.000000000","message":"Patch Set 1:\n\nalso need to update deployment-mgr.yaml\nhttps://github.com/ceph/ceph-helm/commit/a6d6b2eef3a700efbcdc17dda099d1e38abc1ce0#diff-657d748112835da54304e757e0760d0a","accounts_in_message":[],"_revision_number":1},{"id":"133ce2ebd0beb30fde9b1a69f7660aa3fd496a4b","author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"date":"2018-01-11 17:17:15.000000000","message":"Patch Set 1:\n\n@huamin i believe the change in deployment-mgr.yaml has already been merged via https://review.openstack.org/#/c/531494/. Is there something else that i am missing?","accounts_in_message":[],"_revision_number":1},{"id":"fc16f95bede70a0d54ebd210d9dc3c6c8a89a655","author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"date":"2018-01-11 17:49:28.000000000","message":"Patch Set 1: Code-Review+1\n\nVote pending gate runs, but was able to use this to enable the prometheus plugin for ceph-mgr. :)","accounts_in_message":[],"_revision_number":1},{"id":"8be2286aa74983108c99ee00a1aeef2d8fd12234","author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"date":"2018-01-11 17:59:26.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"d8ae6e5f3f726e5deec3c2670d6baf2f87dbd61a","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2018-01-11 19:22:06.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"bf54a21bc87deaf0595bc8f3b382bdd7f62f7f6c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-11 19:28:11.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/24/532724/2/check/build-openstack-sphinx-docs/8e4fbf3/html/ : SUCCESS in 3m 52s\n- openstack-helm-linter http://logs.openstack.org/24/532724/2/check/openstack-helm-linter/197982a/ : SUCCESS in 1m 25s\n- openstack-helm-dev-deploy http://logs.openstack.org/24/532724/2/check/openstack-helm-dev-deploy/10b310b/ : SUCCESS in 1h 14m 53s\n- openstack-helm-legacy-ubuntu-vm-ovs-radosgw http://logs.openstack.org/24/532724/2/check/openstack-helm-legacy-ubuntu-vm-ovs-radosgw/d9af7ec/ : FAILURE in 50m 59s (non-voting)\n- openstack-helm-legacy-ubuntu-vm-lb-radosgw http://logs.openstack.org/24/532724/2/check/openstack-helm-legacy-ubuntu-vm-lb-radosgw/a2d8b2c/ : FAILURE in 53m 41s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"1dbaeee1362c26ba6e7afcd1291587443dee40af","author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"date":"2018-01-11 19:38:59.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"44271287b63466d6a4fa6259b05713e0f80d0315","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2018-01-11 19:40:19.000000000","message":"Patch Set 2: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"ad65e4adbec054019f821b725ebd018df40b721f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-11 19:40:32.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"50eb7de02d034234366090224e0d169e5896ba6c","author":{"_account_id":26509,"name":"Huamin Chen","email":"huamin.chen@gmail.com","username":"rootfs"},"date":"2018-01-11 20:28:24.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"566696039f9fadc8efa87ffbaa61e0e1c8571231","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-11 20:58:26.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"891974b396910120383fe0df923a84dbe82949a0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-11 20:58:26.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/24/532724/2/gate/build-openstack-sphinx-docs/1fae197/html/ : SUCCESS in 4m 13s\n- openstack-helm-linter http://logs.openstack.org/24/532724/2/gate/openstack-helm-linter/989cb3f/ : SUCCESS in 2m 07s\n- openstack-helm-dev-deploy http://logs.openstack.org/24/532724/2/gate/openstack-helm-dev-deploy/5d66ac6/ : SUCCESS in 1h 08m 56s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"434a28e80f12cfd9d7bef8073ad751ee30172269","revisions":{"5f3b6ef2c6a8922ee0c654ed81b460cdc2746064":{"kind":"REWORK","_number":1,"created":"2018-01-11 04:28:31.000000000","uploader":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"ref":"refs/changes/24/532724/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/24/532724/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/24/532724/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/24/532724/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/24/532724/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/24/532724/1"}}},"commit":{"parents":[{"commit":"b17c051bfc1d01580b4fe57038679e0eaa59898d","subject":"Merge \"ceph-mgr: change liveness/readiness probes\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/b17c051bfc1d01580b4fe57038679e0eaa59898d"}]}],"author":{"name":"Alexandre Marangone","email":"amarango@redhat.com","date":"2017-10-30 16:57:29.000000000","tz":-420},"committer":{"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","date":"2018-01-11 03:42:03.000000000","tz":-480},"subject":"mgr: refactor mgr module enablement","message":"mgr: refactor mgr module enablement\n\nCherry-picked from https://github.com/ceph/ceph-helm/commit/a6d6b2eef3a700efbcdc17dda099d1e38abc1ce0\n\nChange-Id: Ie6b7e94e80d625c212331cf74c0f796bb3e99858\nSigned-off-by: Alexandre Marangone \u003camarango@redhat.com\u003e\nSigned-off-by: Ganesh Maharaj Mahalingam \u003cganesh.mahalingam@intel.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/5f3b6ef2c6a8922ee0c654ed81b460cdc2746064"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/5f3b6ef2c6a8922ee0c654ed81b460cdc2746064"}]},"branch":"refs/heads/master"},"434a28e80f12cfd9d7bef8073ad751ee30172269":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2018-01-11 17:59:26.000000000","uploader":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"ref":"refs/changes/24/532724/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/24/532724/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/24/532724/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/24/532724/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/24/532724/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/24/532724/2"}}},"commit":{"parents":[{"commit":"e4fa63aea9a2b327ff39c0021e2fe303b9f62139","subject":"Merge \"MariaDB: Move to version 10.2.12\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/e4fa63aea9a2b327ff39c0021e2fe303b9f62139"}]}],"author":{"name":"Alexandre Marangone","email":"amarango@redhat.com","date":"2017-10-30 16:57:29.000000000","tz":-420},"committer":{"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","date":"2018-01-11 17:58:50.000000000","tz":-360},"subject":"mgr: refactor mgr module enablement","message":"mgr: refactor mgr module enablement\n\nCherry-picked from https://github.com/ceph/ceph-helm/commit/a6d6b2eef3a700efbcdc17dda099d1e38abc1ce0\n\nChange-Id: Ie6b7e94e80d625c212331cf74c0f796bb3e99858\nSigned-off-by: Alexandre Marangone \u003camarango@redhat.com\u003e\nSigned-off-by: Ganesh Maharaj Mahalingam \u003cganesh.mahalingam@intel.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/434a28e80f12cfd9d7bef8073ad751ee30172269"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/434a28e80f12cfd9d7bef8073ad751ee30172269"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
