)]}'
{"helm-toolkit/templates/scripts/_db-work.py.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"1f36273d69c0899fb27194f2f06ecadcfe1386fb","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# OPENSTACK_CONFIG_DB_SECTION."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"import os"},{"line_number":29,"context_line":"import sys"},{"line_number":30,"context_line":"import ConfigParser"},{"line_number":31,"context_line":"import logging"},{"line_number":32,"context_line":"from sqlalchemy import create_engine"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f96bb07_1fdaa016","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":10},"updated":"2018-01-11 23:51:00.000000000","message":"sort the import alphabetically","commit_id":"185ad49c0c22ada7c8f57954f3a82ac90c12735d"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"b02be380e4037c053d2f795b5fdb64c4458f12fc","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# OPENSTACK_CONFIG_DB_SECTION."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"import os"},{"line_number":29,"context_line":"import sys"},{"line_number":30,"context_line":"import ConfigParser"},{"line_number":31,"context_line":"import logging"},{"line_number":32,"context_line":"from sqlalchemy import create_engine"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f96bb07_9d5d3ceb","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":10},"in_reply_to":"7f96bb07_1fdaa016","updated":"2018-01-22 15:27:25.000000000","message":"Done","commit_id":"185ad49c0c22ada7c8f57954f3a82ac90c12735d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"1f36273d69c0899fb27194f2f06ecadcfe1386fb","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"import os"},{"line_number":29,"context_line":"import sys"},{"line_number":30,"context_line":"import ConfigParser"},{"line_number":31,"context_line":"import logging"},{"line_number":32,"context_line":"from sqlalchemy import create_engine"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f96bb07_5fd028f8","line":30,"range":{"start_line":30,"start_character":7,"end_line":30,"end_character":19},"updated":"2018-01-11 23:51:00.000000000","message":"can we also make this py3 compatible?","commit_id":"185ad49c0c22ada7c8f57954f3a82ac90c12735d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"1f36273d69c0899fb27194f2f06ecadcfe1386fb","unresolved":false,"context_lines":[{"line_number":29,"context_line":"import sys"},{"line_number":30,"context_line":"import ConfigParser"},{"line_number":31,"context_line":"import logging"},{"line_number":32,"context_line":"from sqlalchemy import create_engine"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"sys_arg \u003d sys.argv[1]"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f96bb07_7ff64492","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":36},"updated":"2018-01-11 23:51:00.000000000","message":"separate section.  can we do this:\n\n  import sqlalchemy as sql\n\nand in the code do sql.create_engine","commit_id":"185ad49c0c22ada7c8f57954f3a82ac90c12735d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"1f36273d69c0899fb27194f2f06ecadcfe1386fb","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    ch.setFormatter(formatter)"},{"line_number":48,"context_line":"    logger.addHandler(ch)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    os.environ[\u0027DB_CONNECTION\u0027] \u003d \\"},{"line_number":51,"context_line":"        \u0027mysql://keystone:KEYSTONE_DBPASS@localhost/keystone\u0027"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    # Get the connection string for the service db root user"},{"line_number":54,"context_line":"    if \"ROOT_DB_CONNECTION\" in os.environ:"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f96bb07_1f4860ca","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":61},"updated":"2018-01-11 23:51:00.000000000","message":"we shouldn\u0027t need to assign environment variable here here.","commit_id":"185ad49c0c22ada7c8f57954f3a82ac90c12735d"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"b02be380e4037c053d2f795b5fdb64c4458f12fc","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    ch.setFormatter(formatter)"},{"line_number":48,"context_line":"    logger.addHandler(ch)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    os.environ[\u0027DB_CONNECTION\u0027] \u003d \\"},{"line_number":51,"context_line":"        \u0027mysql://keystone:KEYSTONE_DBPASS@localhost/keystone\u0027"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    # Get the connection string for the service db root user"},{"line_number":54,"context_line":"    if \"ROOT_DB_CONNECTION\" in os.environ:"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f96bb07_5d6fb491","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":61},"in_reply_to":"7f96bb07_1f4860ca","updated":"2018-01-22 15:27:25.000000000","message":"Done","commit_id":"185ad49c0c22ada7c8f57954f3a82ac90c12735d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b2b7d8a8db7af56bdb352bc065a9dba187c1d49c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \u0027mysql://keystone:KEYSTONE_DBPASS@localhost/keystone\u0027"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    # Get the connection string for the service db root user"},{"line_number":54,"context_line":"    if \"ROOT_DB_CONNECTION\" in os.environ:"},{"line_number":55,"context_line":"        db_connection \u003d os.environ[\u0027ROOT_DB_CONNECTION\u0027]"},{"line_number":56,"context_line":"        logger.info(\u0027Got DB root connection\u0027)"},{"line_number":57,"context_line":"    else:"},{"line_number":58,"context_line":"        logger.critical(\u0027environment variable ROOT_DB_CONNECTION not set\u0027)"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f96bb07_d6e65a17","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":56},"updated":"2018-01-12 05:47:18.000000000","message":"instead of testing and fetch, there is os.getenv: https://docs.python.org/2/library/os.html#os.getenv","commit_id":"185ad49c0c22ada7c8f57954f3a82ac90c12735d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b2b7d8a8db7af56bdb352bc065a9dba187c1d49c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        sys.exit(1)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    # Get the connection string for the service db"},{"line_number":62,"context_line":"    if \"OPENSTACK_CONFIG_FILE\" in os.environ:"},{"line_number":63,"context_line":"        os_conf \u003d os.environ[\u0027OPENSTACK_CONFIG_FILE\u0027]"},{"line_number":64,"context_line":"        if \"OPENSTACK_CONFIG_DB_SECTION\" in os.environ:"},{"line_number":65,"context_line":"            os_conf_section \u003d os.environ[\u0027OPENSTACK_CONFIG_DB_SECTION\u0027]"},{"line_number":66,"context_line":"        else:"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f96bb07_b6ff0ea9","line":63,"range":{"start_line":62,"start_character":7,"end_line":63,"end_character":53},"updated":"2018-01-12 05:47:18.000000000","message":"ditto","commit_id":"185ad49c0c22ada7c8f57954f3a82ac90c12735d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b2b7d8a8db7af56bdb352bc065a9dba187c1d49c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    # Get the connection string for the service db"},{"line_number":62,"context_line":"    if \"OPENSTACK_CONFIG_FILE\" in os.environ:"},{"line_number":63,"context_line":"        os_conf \u003d os.environ[\u0027OPENSTACK_CONFIG_FILE\u0027]"},{"line_number":64,"context_line":"        if \"OPENSTACK_CONFIG_DB_SECTION\" in os.environ:"},{"line_number":65,"context_line":"            os_conf_section \u003d os.environ[\u0027OPENSTACK_CONFIG_DB_SECTION\u0027]"},{"line_number":66,"context_line":"        else:"},{"line_number":67,"context_line":"            logger.critical("},{"line_number":68,"context_line":"                \u0027environment variable OPENSTACK_CONFIG_DB_SECTION not set\u0027)"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f96bb07_362d3e43","line":65,"range":{"start_line":64,"start_character":0,"end_line":65,"end_character":71},"updated":"2018-01-12 05:47:18.000000000","message":"ditto","commit_id":"185ad49c0c22ada7c8f57954f3a82ac90c12735d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b2b7d8a8db7af56bdb352bc065a9dba187c1d49c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            logger.critical("},{"line_number":68,"context_line":"                \u0027environment variable OPENSTACK_CONFIG_DB_SECTION not set\u0027)"},{"line_number":69,"context_line":"            sys.exit(1)"},{"line_number":70,"context_line":"        if \"OPENSTACK_CONFIG_DB_KEY\" in os.environ:"},{"line_number":71,"context_line":"            os_conf_key \u003d os.environ[\u0027OPENSTACK_CONFIG_DB_KEY\u0027]"},{"line_number":72,"context_line":"        else:"},{"line_number":73,"context_line":"            logger.critical("},{"line_number":74,"context_line":"                \u0027environment variable OPENSTACK_CONFIG_DB_KEY not set\u0027)"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f96bb07_961bf219","line":71,"range":{"start_line":70,"start_character":11,"end_line":71,"end_character":63},"updated":"2018-01-12 05:47:18.000000000","message":"ditto","commit_id":"185ad49c0c22ada7c8f57954f3a82ac90c12735d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b2b7d8a8db7af56bdb352bc065a9dba187c1d49c","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            logger.critical("},{"line_number":86,"context_line":"                \"Tried to load config from {0} but failed.\".format(os_conf))"},{"line_number":87,"context_line":"            raise"},{"line_number":88,"context_line":"    elif \"DB_CONNECTION\" in os.environ:"},{"line_number":89,"context_line":"        user_db_conn \u003d os.environ[\u0027DB_CONNECTION\u0027]"},{"line_number":90,"context_line":"        logger.info(\u0027Got config from DB_CONNECTION env var\u0027)"},{"line_number":91,"context_line":"    else:"},{"line_number":92,"context_line":"        logger.critical("}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f96bb07_16dda241","line":89,"range":{"start_line":88,"start_character":9,"end_line":89,"end_character":50},"updated":"2018-01-12 05:47:18.000000000","message":"ditto","commit_id":"185ad49c0c22ada7c8f57954f3a82ac90c12735d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"1f36273d69c0899fb27194f2f06ecadcfe1386fb","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        root_engine_url \u003d \u0027\u0027.join("},{"line_number":109,"context_line":"            [drivername, \u0027://\u0027, root_user, \u0027:\u0027, root_password, \u0027@\u0027,"},{"line_number":110,"context_line":"                db_info[\u0027host\u0027], \u0027:\u0027, str(db_info[\u0027port\u0027])])"},{"line_number":111,"context_line":"        db_info[\u0027root_engine\u0027] \u003d create_engine(root_engine_url)"},{"line_number":112,"context_line":"        connection \u003d db_info[\u0027root_engine\u0027].connect()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        connection.close()"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f96bb07_9f8230c8","line":111,"range":{"start_line":111,"start_character":0,"end_line":111,"end_character":63},"updated":"2018-01-11 23:51:00.000000000","message":"if the db_connection on L102 is already well form, are we just breaking things up and recombine it into root_engine_url to do another create_engine()?","commit_id":"185ad49c0c22ada7c8f57954f3a82ac90c12735d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"1f36273d69c0899fb27194f2f06ecadcfe1386fb","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    elif dbArg \u003d\u003d \u0027drop\u0027:"},{"line_number":137,"context_line":"        deleteDB(db_info)"},{"line_number":138,"context_line":"    else:"},{"line_number":139,"context_line":"        logger.info(\u0027Invalid arguments\u0027)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"def deleteDB(db_info):"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f96bb07_5f6ca835","line":139,"range":{"start_line":139,"start_character":15,"end_line":139,"end_character":19},"updated":"2018-01-11 23:51:00.000000000","message":"error","commit_id":"185ad49c0c22ada7c8f57954f3a82ac90c12735d"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"b02be380e4037c053d2f795b5fdb64c4458f12fc","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    elif dbArg \u003d\u003d \u0027drop\u0027:"},{"line_number":137,"context_line":"        deleteDB(db_info)"},{"line_number":138,"context_line":"    else:"},{"line_number":139,"context_line":"        logger.info(\u0027Invalid arguments\u0027)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"def deleteDB(db_info):"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f96bb07_5df494cf","line":139,"range":{"start_line":139,"start_character":15,"end_line":139,"end_character":19},"in_reply_to":"7f96bb07_5f6ca835","updated":"2018-01-22 15:27:25.000000000","message":"Done","commit_id":"185ad49c0c22ada7c8f57954f3a82ac90c12735d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b2b7d8a8db7af56bdb352bc065a9dba187c1d49c","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"def deleteDB(db_info):"},{"line_number":143,"context_line":"    logger \u003d logging.getLogger(\u0027OpenStack-Helm DB Drop or Create\u0027)"},{"line_number":144,"context_line":"    # Delete DB"},{"line_number":145,"context_line":"    try:"},{"line_number":146,"context_line":"        db_info[\u0027root_engine\u0027].execute(\"DROP DATABASE IF EXISTS {0}\".format("}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f96bb07_763c2693","line":143,"range":{"start_line":143,"start_character":4,"end_line":143,"end_character":66},"updated":"2018-01-12 05:47:18.000000000","message":"make this a module variable - no need to create 3 different loggers for 1 script.","commit_id":"185ad49c0c22ada7c8f57954f3a82ac90c12735d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b2b7d8a8db7af56bdb352bc065a9dba187c1d49c","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            db_info[\u0027user\u0027]))"},{"line_number":158,"context_line":"        logger.info(\"Deleted user {0}\".format(db_info[\u0027user\u0027]))"},{"line_number":159,"context_line":"    except:"},{"line_number":160,"context_line":"        logger.critical(\"Could not delete user {0}\".format(db_info[\u0027user\u0027]))"},{"line_number":161,"context_line":"        raise"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    logger.info(\u0027Finished DB Management\u0027)"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f96bb07_36469e25","line":160,"range":{"start_line":160,"start_character":15,"end_line":160,"end_character":23},"updated":"2018-01-12 05:47:18.000000000","message":"exception","commit_id":"185ad49c0c22ada7c8f57954f3a82ac90c12735d"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"b02be380e4037c053d2f795b5fdb64c4458f12fc","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            db_info[\u0027user\u0027]))"},{"line_number":158,"context_line":"        logger.info(\"Deleted user {0}\".format(db_info[\u0027user\u0027]))"},{"line_number":159,"context_line":"    except:"},{"line_number":160,"context_line":"        logger.critical(\"Could not delete user {0}\".format(db_info[\u0027user\u0027]))"},{"line_number":161,"context_line":"        raise"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    logger.info(\u0027Finished DB Management\u0027)"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f96bb07_fd0240b4","line":160,"range":{"start_line":160,"start_character":15,"end_line":160,"end_character":23},"in_reply_to":"7f96bb07_36469e25","updated":"2018-01-22 15:27:25.000000000","message":"Done","commit_id":"185ad49c0c22ada7c8f57954f3a82ac90c12735d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b2b7d8a8db7af56bdb352bc065a9dba187c1d49c","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            \"CREATE DATABASE IF NOT EXISTS {0}\".format(db_info[\u0027database\u0027]))"},{"line_number":172,"context_line":"        logger.info(\"Created database {0}\".format(db_info[\u0027database\u0027]))"},{"line_number":173,"context_line":"    except:"},{"line_number":174,"context_line":"        logger.critical(\"Could not create database {0}\".format("},{"line_number":175,"context_line":"            db_info[\u0027database\u0027]))"},{"line_number":176,"context_line":"        raise"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f96bb07_f647d61c","line":174,"range":{"start_line":174,"start_character":15,"end_line":174,"end_character":23},"updated":"2018-01-12 05:47:18.000000000","message":"exception","commit_id":"185ad49c0c22ada7c8f57954f3a82ac90c12735d"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"b02be380e4037c053d2f795b5fdb64c4458f12fc","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            \"CREATE DATABASE IF NOT EXISTS {0}\".format(db_info[\u0027database\u0027]))"},{"line_number":172,"context_line":"        logger.info(\"Created database {0}\".format(db_info[\u0027database\u0027]))"},{"line_number":173,"context_line":"    except:"},{"line_number":174,"context_line":"        logger.critical(\"Could not create database {0}\".format("},{"line_number":175,"context_line":"            db_info[\u0027database\u0027]))"},{"line_number":176,"context_line":"        raise"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f96bb07_1dfe0cae","line":174,"range":{"start_line":174,"start_character":15,"end_line":174,"end_character":23},"in_reply_to":"7f96bb07_f647d61c","updated":"2018-01-22 15:27:25.000000000","message":"Done","commit_id":"185ad49c0c22ada7c8f57954f3a82ac90c12735d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"b2b7d8a8db7af56bdb352bc065a9dba187c1d49c","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            \"Created user {0} for {1}\".format("},{"line_number":185,"context_line":"                    db_info[\u0027user\u0027], db_info[\u0027database\u0027]))"},{"line_number":186,"context_line":"    except:"},{"line_number":187,"context_line":"        logger.critical(\"Could not create user {0} for {1}\".format("},{"line_number":188,"context_line":"            db_info[\u0027user\u0027], db_info[\u0027database\u0027]))"},{"line_number":189,"context_line":"        raise"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f96bb07_965452cc","line":187,"range":{"start_line":187,"start_character":15,"end_line":187,"end_character":23},"updated":"2018-01-12 05:47:18.000000000","message":"exception","commit_id":"185ad49c0c22ada7c8f57954f3a82ac90c12735d"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"b02be380e4037c053d2f795b5fdb64c4458f12fc","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            \"Created user {0} for {1}\".format("},{"line_number":185,"context_line":"                    db_info[\u0027user\u0027], db_info[\u0027database\u0027]))"},{"line_number":186,"context_line":"    except:"},{"line_number":187,"context_line":"        logger.critical(\"Could not create user {0} for {1}\".format("},{"line_number":188,"context_line":"            db_info[\u0027user\u0027], db_info[\u0027database\u0027]))"},{"line_number":189,"context_line":"        raise"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f96bb07_bd2ef840","line":187,"range":{"start_line":187,"start_character":15,"end_line":187,"end_character":23},"in_reply_to":"7f96bb07_965452cc","updated":"2018-01-22 15:27:25.000000000","message":"Done","commit_id":"185ad49c0c22ada7c8f57954f3a82ac90c12735d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"1f36273d69c0899fb27194f2f06ecadcfe1386fb","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        raise"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    logger.info(\u0027Finished DB Management\u0027)"},{"line_number":203,"context_line":"main()"},{"line_number":204,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f96bb07_1fc5c03c","line":203,"range":{"start_line":203,"start_character":0,"end_line":203,"end_character":6},"updated":"2018-01-11 23:51:00.000000000","message":"if __name__ \u003d\u003d \"__main_\":\n   main()","commit_id":"185ad49c0c22ada7c8f57954f3a82ac90c12735d"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"b02be380e4037c053d2f795b5fdb64c4458f12fc","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        raise"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    logger.info(\u0027Finished DB Management\u0027)"},{"line_number":203,"context_line":"main()"},{"line_number":204,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"7f96bb07_7d287033","line":203,"range":{"start_line":203,"start_character":0,"end_line":203,"end_character":6},"in_reply_to":"7f96bb07_1fc5c03c","updated":"2018-01-22 15:27:25.000000000","message":"Done","commit_id":"185ad49c0c22ada7c8f57954f3a82ac90c12735d"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"4c33b8ace63c40ed82500a4e5d884e7e6a967a0b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        sys.exit(1)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    # Get the connection string for the service db"},{"line_number":57,"context_line":"    if \"OPENSTACK_CONFIG_FILE\" in os.environ:"},{"line_number":58,"context_line":"          os_conf \u003d os.environ[\u0027OPENSTACK_CONFIG_FILE\u0027]"},{"line_number":59,"context_line":"          if \"OPENSTACK_CONFIG_DB_SECTION\" in os.environ:"},{"line_number":60,"context_line":"              os_conf_section \u003d os.environ[\u0027OPENSTACK_CONFIG_DB_SECTION\u0027]"},{"line_number":61,"context_line":"          else:"},{"line_number":62,"context_line":"              logger.critical("},{"line_number":63,"context_line":"                  \u0027environment variable OPENSTACK_CONFIG_DB_SECTION not set\u0027)"},{"line_number":64,"context_line":"              sys.exit(1)"},{"line_number":65,"context_line":"          if \"OPENSTACK_CONFIG_DB_KEY\" in os.environ:"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"7f96bb07_076eb194","line":62,"range":{"start_line":57,"start_character":1,"end_line":62,"end_character":14},"updated":"2018-01-13 02:36:04.000000000","message":"I would suggest pulling this python script as is without the gotpl marking and test it. The identation of this is incorrect from quick eyeballing of this.","commit_id":"653c0c02ea6bdc22b89330094e3a2865221e7f52"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"b02be380e4037c053d2f795b5fdb64c4458f12fc","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        sys.exit(1)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    # Get the connection string for the service db"},{"line_number":57,"context_line":"    if \"OPENSTACK_CONFIG_FILE\" in os.environ:"},{"line_number":58,"context_line":"          os_conf \u003d os.environ[\u0027OPENSTACK_CONFIG_FILE\u0027]"},{"line_number":59,"context_line":"          if \"OPENSTACK_CONFIG_DB_SECTION\" in os.environ:"},{"line_number":60,"context_line":"              os_conf_section \u003d os.environ[\u0027OPENSTACK_CONFIG_DB_SECTION\u0027]"},{"line_number":61,"context_line":"          else:"},{"line_number":62,"context_line":"              logger.critical("},{"line_number":63,"context_line":"                  \u0027environment variable OPENSTACK_CONFIG_DB_SECTION not set\u0027)"},{"line_number":64,"context_line":"              sys.exit(1)"},{"line_number":65,"context_line":"          if \"OPENSTACK_CONFIG_DB_KEY\" in os.environ:"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"7f96bb07_ebea5273","line":62,"range":{"start_line":57,"start_character":1,"end_line":62,"end_character":14},"in_reply_to":"7f96bb07_076eb194","updated":"2018-01-22 15:27:25.000000000","message":"Done","commit_id":"653c0c02ea6bdc22b89330094e3a2865221e7f52"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"4c33b8ace63c40ed82500a4e5d884e7e6a967a0b","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"def deleteDB(db_info):"},{"line_number":139,"context_line":"    logger \u003d logging.getLogger(\u0027OpenStack-Helm DB Drop or Create\u0027)"},{"line_number":140,"context_line":"    # Delete DB"},{"line_number":141,"context_line":"    try:"},{"line_number":142,"context_line":"        db_info[\u0027root_engine\u0027].execute(\"DROP DATABASE IF EXISTS {0}\".format("}],"source_content_type":"text/x-smarty","patch_set":6,"id":"7f96bb07_870f21e0","line":139,"range":{"start_line":139,"start_character":2,"end_line":139,"end_character":66},"updated":"2018-01-13 02:36:04.000000000","message":"per previous comment, we do not need a new logger per function.  In fact, this logger is not set up unlike the one in main().","commit_id":"653c0c02ea6bdc22b89330094e3a2865221e7f52"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"b02be380e4037c053d2f795b5fdb64c4458f12fc","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"def deleteDB(db_info):"},{"line_number":139,"context_line":"    logger \u003d logging.getLogger(\u0027OpenStack-Helm DB Drop or Create\u0027)"},{"line_number":140,"context_line":"    # Delete DB"},{"line_number":141,"context_line":"    try:"},{"line_number":142,"context_line":"        db_info[\u0027root_engine\u0027].execute(\"DROP DATABASE IF EXISTS {0}\".format("}],"source_content_type":"text/x-smarty","patch_set":6,"id":"7f96bb07_ab044a4b","line":139,"range":{"start_line":139,"start_character":2,"end_line":139,"end_character":66},"in_reply_to":"7f96bb07_870f21e0","updated":"2018-01-22 15:27:25.000000000","message":"Done","commit_id":"653c0c02ea6bdc22b89330094e3a2865221e7f52"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"4c33b8ace63c40ed82500a4e5d884e7e6a967a0b","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            db_info[\u0027host\u0027], db_info[\u0027port\u0027],"},{"line_number":193,"context_line":"            db_info[\u0027database\u0027], db_info[\u0027user\u0027]))"},{"line_number":194,"context_line":"    except:"},{"line_number":195,"context_line":"        logger.critical(\u0027Could not connect to database as user\u0027)"},{"line_number":196,"context_line":"        raise"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    logger.info(\u0027Finished DB Management\u0027)"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"7f96bb07_e73145a4","line":195,"range":{"start_line":195,"start_character":15,"end_line":195,"end_character":23},"updated":"2018-01-13 02:36:04.000000000","message":"exception","commit_id":"653c0c02ea6bdc22b89330094e3a2865221e7f52"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"b02be380e4037c053d2f795b5fdb64c4458f12fc","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            db_info[\u0027host\u0027], db_info[\u0027port\u0027],"},{"line_number":193,"context_line":"            db_info[\u0027database\u0027], db_info[\u0027user\u0027]))"},{"line_number":194,"context_line":"    except:"},{"line_number":195,"context_line":"        logger.critical(\u0027Could not connect to database as user\u0027)"},{"line_number":196,"context_line":"        raise"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    logger.info(\u0027Finished DB Management\u0027)"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"7f96bb07_8bf94e4e","line":195,"range":{"start_line":195,"start_character":15,"end_line":195,"end_character":23},"in_reply_to":"7f96bb07_e73145a4","updated":"2018-01-22 15:27:25.000000000","message":"Done","commit_id":"653c0c02ea6bdc22b89330094e3a2865221e7f52"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"102830debeccb56ab3678544479f89004b3bdbaf","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        sys.exit(1)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    # Get the connection string for the service db"},{"line_number":57,"context_line":"    if \"OPENSTACK_CONFIG_FILE\" in os.environ:"},{"line_number":58,"context_line":"        os_conf \u003d os.environ[\u0027OPENSTACK_CONFIG_FILE\u0027]"},{"line_number":59,"context_line":"        if \"OPENSTACK_CONFIG_DB_SECTION\" in os.environ:"},{"line_number":60,"context_line":"            os_conf_section \u003d os.environ[\u0027OPENSTACK_CONFIG_DB_SECTION\u0027]"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_24bfebb0","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":45},"updated":"2018-01-16 10:09:59.000000000","message":"why change some to os.getenv() but not here?","commit_id":"65f4adb2eef53d84e12650787cc249948e1e9346"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"b02be380e4037c053d2f795b5fdb64c4458f12fc","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        sys.exit(1)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    # Get the connection string for the service db"},{"line_number":57,"context_line":"    if \"OPENSTACK_CONFIG_FILE\" in os.environ:"},{"line_number":58,"context_line":"        os_conf \u003d os.environ[\u0027OPENSTACK_CONFIG_FILE\u0027]"},{"line_number":59,"context_line":"        if \"OPENSTACK_CONFIG_DB_SECTION\" in os.environ:"},{"line_number":60,"context_line":"            os_conf_section \u003d os.environ[\u0027OPENSTACK_CONFIG_DB_SECTION\u0027]"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_17ea15ab","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":45},"in_reply_to":"7f96bb07_24bfebb0","updated":"2018-01-22 15:27:25.000000000","message":"I\u0027m working on changing them all, this one was giving me issues when testing the python file","commit_id":"65f4adb2eef53d84e12650787cc249948e1e9346"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"70d478e1ad1ab938e068fcec2074836e074e76a0","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        else:"},{"line_number":62,"context_line":"            logger.critical("},{"line_number":63,"context_line":"                \u0027environment variable OPENSTACK_CONFIG_DB_SECTION not set\u0027)"},{"line_number":64,"context_line":"                sys.exit(1)"},{"line_number":65,"context_line":"        if \"OPENSTACK_CONFIG_DB_KEY\" in os.environ:"},{"line_number":66,"context_line":"            os_conf_key \u003d os.environ[\u0027OPENSTACK_CONFIG_DB_KEY\u0027]"},{"line_number":67,"context_line":"        else:"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_e4cee3b2","line":64,"range":{"start_line":64,"start_character":11,"end_line":64,"end_character":27},"updated":"2018-01-16 10:03:00.000000000","message":"indent","commit_id":"65f4adb2eef53d84e12650787cc249948e1e9346"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"b02be380e4037c053d2f795b5fdb64c4458f12fc","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        else:"},{"line_number":62,"context_line":"            logger.critical("},{"line_number":63,"context_line":"                \u0027environment variable OPENSTACK_CONFIG_DB_SECTION not set\u0027)"},{"line_number":64,"context_line":"                sys.exit(1)"},{"line_number":65,"context_line":"        if \"OPENSTACK_CONFIG_DB_KEY\" in os.environ:"},{"line_number":66,"context_line":"            os_conf_key \u003d os.environ[\u0027OPENSTACK_CONFIG_DB_KEY\u0027]"},{"line_number":67,"context_line":"        else:"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_d7cfcd53","line":64,"range":{"start_line":64,"start_character":11,"end_line":64,"end_character":27},"in_reply_to":"7f96bb07_e4cee3b2","updated":"2018-01-22 15:27:25.000000000","message":"Done","commit_id":"65f4adb2eef53d84e12650787cc249948e1e9346"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"102830debeccb56ab3678544479f89004b3bdbaf","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            logger.critical("},{"line_number":81,"context_line":"                \"Tried to load config from {0} but failed.\".format(os_conf))"},{"line_number":82,"context_line":"            raise"},{"line_number":83,"context_line":"    elif \"DB_CONNECTION\" in os.environ:"},{"line_number":84,"context_line":"        user_db_conn \u003d os.environ[\u0027DB_CONNECTION\u0027]"},{"line_number":85,"context_line":"        logger.info(\u0027Got config from DB_CONNECTION env var\u0027)"},{"line_number":86,"context_line":"    else:"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_84cd9f67","line":83,"range":{"start_line":83,"start_character":9,"end_line":83,"end_character":38},"updated":"2018-01-16 10:09:59.000000000","message":"ditto","commit_id":"65f4adb2eef53d84e12650787cc249948e1e9346"},{"author":{"_account_id":23674,"name":"Rohan Arora","email":"ra271w@att.com","username":"rarora"},"change_message_id":"42f00b48f6b56fb28204296a15eec68473c6c93f","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    # Call db function based on arguments"},{"line_number":130,"context_line":"    if dbArg \u003d\u003d \u0027create\u0027:"},{"line_number":131,"context_line":"        createDB(db_info, logger)"},{"line_number":132,"context_line":"    elif dbArg \u003d\u003d \u0027drop\u0027:"},{"line_number":133,"context_line":"        deleteDB(db_info, logger)"},{"line_number":134,"context_line":"    else:"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_460a5b8a","line":131,"range":{"start_line":131,"start_character":26,"end_line":131,"end_character":32},"updated":"2018-01-15 15:55:43.000000000","message":"I believe Tin wanted to make the logger global rather than passing it to the functions.","commit_id":"65f4adb2eef53d84e12650787cc249948e1e9346"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"70d478e1ad1ab938e068fcec2074836e074e76a0","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    # Call db function based on arguments"},{"line_number":130,"context_line":"    if dbArg \u003d\u003d \u0027create\u0027:"},{"line_number":131,"context_line":"        createDB(db_info, logger)"},{"line_number":132,"context_line":"    elif dbArg \u003d\u003d \u0027drop\u0027:"},{"line_number":133,"context_line":"        deleteDB(db_info, logger)"},{"line_number":134,"context_line":"    else:"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_a449bb31","line":131,"range":{"start_line":131,"start_character":26,"end_line":131,"end_character":32},"in_reply_to":"7f96bb07_460a5b8a","updated":"2018-01-16 10:03:00.000000000","message":"++","commit_id":"65f4adb2eef53d84e12650787cc249948e1e9346"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"b02be380e4037c053d2f795b5fdb64c4458f12fc","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    # Call db function based on arguments"},{"line_number":130,"context_line":"    if dbArg \u003d\u003d \u0027create\u0027:"},{"line_number":131,"context_line":"        createDB(db_info, logger)"},{"line_number":132,"context_line":"    elif dbArg \u003d\u003d \u0027drop\u0027:"},{"line_number":133,"context_line":"        deleteDB(db_info, logger)"},{"line_number":134,"context_line":"    else:"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_571bbdce","line":131,"range":{"start_line":131,"start_character":26,"end_line":131,"end_character":32},"in_reply_to":"7f96bb07_460a5b8a","updated":"2018-01-22 15:27:25.000000000","message":"Done","commit_id":"65f4adb2eef53d84e12650787cc249948e1e9346"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"b02be380e4037c053d2f795b5fdb64c4458f12fc","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    # Call db function based on arguments"},{"line_number":130,"context_line":"    if dbArg \u003d\u003d \u0027create\u0027:"},{"line_number":131,"context_line":"        createDB(db_info, logger)"},{"line_number":132,"context_line":"    elif dbArg \u003d\u003d \u0027drop\u0027:"},{"line_number":133,"context_line":"        deleteDB(db_info, logger)"},{"line_number":134,"context_line":"    else:"}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_f70be979","line":131,"range":{"start_line":131,"start_character":26,"end_line":131,"end_character":32},"in_reply_to":"7f96bb07_a449bb31","updated":"2018-01-22 15:27:25.000000000","message":"Done","commit_id":"65f4adb2eef53d84e12650787cc249948e1e9346"},{"author":{"_account_id":23674,"name":"Rohan Arora","email":"ra271w@att.com","username":"rarora"},"change_message_id":"42f00b48f6b56fb28204296a15eec68473c6c93f","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    if dbArg \u003d\u003d \u0027create\u0027:"},{"line_number":131,"context_line":"        createDB(db_info, logger)"},{"line_number":132,"context_line":"    elif dbArg \u003d\u003d \u0027drop\u0027:"},{"line_number":133,"context_line":"        deleteDB(db_info, logger)"},{"line_number":134,"context_line":"    else:"},{"line_number":135,"context_line":"        logger.error(\u0027Invalid arguments\u0027)"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_c6f50b85","line":133,"range":{"start_line":133,"start_character":26,"end_line":133,"end_character":32},"updated":"2018-01-15 15:55:43.000000000","message":"see above","commit_id":"65f4adb2eef53d84e12650787cc249948e1e9346"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"b02be380e4037c053d2f795b5fdb64c4458f12fc","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    if dbArg \u003d\u003d \u0027create\u0027:"},{"line_number":131,"context_line":"        createDB(db_info, logger)"},{"line_number":132,"context_line":"    elif dbArg \u003d\u003d \u0027drop\u0027:"},{"line_number":133,"context_line":"        deleteDB(db_info, logger)"},{"line_number":134,"context_line":"    else:"},{"line_number":135,"context_line":"        logger.error(\u0027Invalid arguments\u0027)"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_1711b5ac","line":133,"range":{"start_line":133,"start_character":26,"end_line":133,"end_character":32},"in_reply_to":"7f96bb07_644f3334","updated":"2018-01-22 15:27:25.000000000","message":"Done","commit_id":"65f4adb2eef53d84e12650787cc249948e1e9346"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"70d478e1ad1ab938e068fcec2074836e074e76a0","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    if dbArg \u003d\u003d \u0027create\u0027:"},{"line_number":131,"context_line":"        createDB(db_info, logger)"},{"line_number":132,"context_line":"    elif dbArg \u003d\u003d \u0027drop\u0027:"},{"line_number":133,"context_line":"        deleteDB(db_info, logger)"},{"line_number":134,"context_line":"    else:"},{"line_number":135,"context_line":"        logger.error(\u0027Invalid arguments\u0027)"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_644f3334","line":133,"range":{"start_line":133,"start_character":26,"end_line":133,"end_character":32},"in_reply_to":"7f96bb07_c6f50b85","updated":"2018-01-16 10:03:00.000000000","message":"++","commit_id":"65f4adb2eef53d84e12650787cc249948e1e9346"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"b02be380e4037c053d2f795b5fdb64c4458f12fc","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    if dbArg \u003d\u003d \u0027create\u0027:"},{"line_number":131,"context_line":"        createDB(db_info, logger)"},{"line_number":132,"context_line":"    elif dbArg \u003d\u003d \u0027drop\u0027:"},{"line_number":133,"context_line":"        deleteDB(db_info, logger)"},{"line_number":134,"context_line":"    else:"},{"line_number":135,"context_line":"        logger.error(\u0027Invalid arguments\u0027)"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_b729e1e6","line":133,"range":{"start_line":133,"start_character":26,"end_line":133,"end_character":32},"in_reply_to":"7f96bb07_c6f50b85","updated":"2018-01-22 15:27:25.000000000","message":"Done","commit_id":"65f4adb2eef53d84e12650787cc249948e1e9346"},{"author":{"_account_id":23674,"name":"Rohan Arora","email":"ra271w@att.com","username":"rarora"},"change_message_id":"15af207ed34e199f4f2175f917d565bea8b64dbc","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        logger.error(\u0027Invalid arguments\u0027)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"def deleteDB(db_info):"},{"line_number":139,"context_line":"    # Delete DB"},{"line_number":140,"context_line":"    try:"},{"line_number":141,"context_line":"        db_info[\u0027root_engine\u0027].execute(\"DROP DATABASE IF EXISTS {0}\".format("}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_065e93e5","line":138,"range":{"start_line":138,"start_character":13,"end_line":138,"end_character":20},"updated":"2018-01-15 15:50:15.000000000","message":"missing the logger","commit_id":"65f4adb2eef53d84e12650787cc249948e1e9346"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"70d478e1ad1ab938e068fcec2074836e074e76a0","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        logger.error(\u0027Invalid arguments\u0027)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"def deleteDB(db_info):"},{"line_number":139,"context_line":"    # Delete DB"},{"line_number":140,"context_line":"    try:"},{"line_number":141,"context_line":"        db_info[\u0027root_engine\u0027].execute(\"DROP DATABASE IF EXISTS {0}\".format("}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_84fa7fba","line":138,"range":{"start_line":138,"start_character":13,"end_line":138,"end_character":20},"in_reply_to":"7f96bb07_065e93e5","updated":"2018-01-16 10:03:00.000000000","message":"without the 2nd parameter, this script should just fail when you invoke deleteDB on L133.","commit_id":"65f4adb2eef53d84e12650787cc249948e1e9346"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"b02be380e4037c053d2f795b5fdb64c4458f12fc","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        logger.error(\u0027Invalid arguments\u0027)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"def deleteDB(db_info):"},{"line_number":139,"context_line":"    # Delete DB"},{"line_number":140,"context_line":"    try:"},{"line_number":141,"context_line":"        db_info[\u0027root_engine\u0027].execute(\"DROP DATABASE IF EXISTS {0}\".format("}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_a671b50e","line":138,"range":{"start_line":138,"start_character":13,"end_line":138,"end_character":20},"in_reply_to":"7f96bb07_84fa7fba","updated":"2018-01-22 15:27:25.000000000","message":"You\u0027re right, yesterdays issues caused that commit not to get pushed up.","commit_id":"65f4adb2eef53d84e12650787cc249948e1e9346"},{"author":{"_account_id":23674,"name":"Rohan Arora","email":"ra271w@att.com","username":"rarora"},"change_message_id":"15af207ed34e199f4f2175f917d565bea8b64dbc","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    logger.info(\u0027Finished DB Management\u0027)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"def createDB(db_info):"},{"line_number":162,"context_line":"    # Create DB"},{"line_number":163,"context_line":"    try:"},{"line_number":164,"context_line":"        db_info[\u0027root_engine\u0027].execute("}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_c66f4b90","line":161,"range":{"start_line":161,"start_character":13,"end_line":161,"end_character":20},"updated":"2018-01-15 15:50:15.000000000","message":"see above","commit_id":"65f4adb2eef53d84e12650787cc249948e1e9346"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"70d478e1ad1ab938e068fcec2074836e074e76a0","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    logger.info(\u0027Finished DB Management\u0027)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"def createDB(db_info):"},{"line_number":162,"context_line":"    # Create DB"},{"line_number":163,"context_line":"    try:"},{"line_number":164,"context_line":"        db_info[\u0027root_engine\u0027].execute("}],"source_content_type":"text/x-smarty","patch_set":7,"id":"7f96bb07_64fdf3af","line":161,"range":{"start_line":161,"start_character":13,"end_line":161,"end_character":20},"in_reply_to":"7f96bb07_c66f4b90","updated":"2018-01-16 10:03:00.000000000","message":"same here","commit_id":"65f4adb2eef53d84e12650787cc249948e1e9346"},{"author":{"_account_id":23674,"name":"Rohan Arora","email":"ra271w@att.com","username":"rarora"},"change_message_id":"ac52d5153dc2573b1ae6a32131cbcea7172e75ee","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    # Get the connection string for the service db"},{"line_number":57,"context_line":"    if \"OPENSTACK_CONFIG_FILE\" in os.environ:"},{"line_number":58,"context_line":"        os_conf \u003d os.environ[\u0027OPENSTACK_CONFIG_FILE\u0027]"},{"line_number":59,"context_line":"        if \"OPENSTACK_CONFIG_DB_SECTION\" in os.environ:"},{"line_number":60,"context_line":"            os_conf_section \u003d os.environ[\u0027OPENSTACK_CONFIG_DB_SECTION\u0027]"},{"line_number":61,"context_line":"        else:"},{"line_number":62,"context_line":"            logger.critical("}],"source_content_type":"text/x-smarty","patch_set":8,"id":"7f96bb07_f53f5e22","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":55},"updated":"2018-01-16 20:48:44.000000000","message":"As Tin mentioned in previous patch, there is inconsistency with using both os.getenv() and os.environ","commit_id":"5cd4337376a8d39677f0f0448aceaa1f41ac7d59"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"b02be380e4037c053d2f795b5fdb64c4458f12fc","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    # Get the connection string for the service db"},{"line_number":57,"context_line":"    if \"OPENSTACK_CONFIG_FILE\" in os.environ:"},{"line_number":58,"context_line":"        os_conf \u003d os.environ[\u0027OPENSTACK_CONFIG_FILE\u0027]"},{"line_number":59,"context_line":"        if \"OPENSTACK_CONFIG_DB_SECTION\" in os.environ:"},{"line_number":60,"context_line":"            os_conf_section \u003d os.environ[\u0027OPENSTACK_CONFIG_DB_SECTION\u0027]"},{"line_number":61,"context_line":"        else:"},{"line_number":62,"context_line":"            logger.critical("}],"source_content_type":"text/x-smarty","patch_set":8,"id":"7f96bb07_58ad2999","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":55},"in_reply_to":"7f96bb07_f53f5e22","updated":"2018-01-22 15:27:25.000000000","message":"Done","commit_id":"5cd4337376a8d39677f0f0448aceaa1f41ac7d59"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"2c6668f5a834b90f03a3035e0c4f0a49163bf6f4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- define \"helm-toolkit.scripts.db_work\" }}"},{"line_number":18,"context_line":"from six.moves import configparser"},{"line_number":19,"context_line":"import logging"},{"line_number":20,"context_line":"from sqlalchemy import create_engine"}],"source_content_type":"text/x-smarty","patch_set":17,"id":"7f96bb07_81e1352d","line":17,"range":{"start_line":17,"start_character":33,"end_line":17,"end_character":40},"updated":"2018-01-23 17:07:43.000000000","message":"This needs a more descriptive name. `work` doesn\u0027t really say much. db_ops or db_funcs makes more sense in this context","commit_id":"a928c3ac1be982a4c276eae852f16d2934e81a7d"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"c0b9b1ee242b60fdafccff95ff4e24311e10defe","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- define \"helm-toolkit.scripts.db_work\" }}"},{"line_number":18,"context_line":"from six.moves import configparser"},{"line_number":19,"context_line":"import logging"},{"line_number":20,"context_line":"from sqlalchemy import create_engine"}],"source_content_type":"text/x-smarty","patch_set":17,"id":"7f96bb07_fab462d3","line":17,"range":{"start_line":17,"start_character":33,"end_line":17,"end_character":40},"in_reply_to":"7f96bb07_81e1352d","updated":"2018-01-23 19:04:25.000000000","message":"Done","commit_id":"a928c3ac1be982a4c276eae852f16d2934e81a7d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"2c6668f5a834b90f03a3035e0c4f0a49163bf6f4","unresolved":false,"context_lines":[{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- define \"helm-toolkit.scripts.db_work\" }}"},{"line_number":18,"context_line":"from six.moves import configparser"},{"line_number":19,"context_line":"import logging"},{"line_number":20,"context_line":"from sqlalchemy import create_engine"},{"line_number":21,"context_line":"import os"},{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"sys_arg \u003d sys.argv[1]"},{"line_number":25,"context_line":"logger \u003d logging.getLogger(\u0027OpenStack-Helm DB Drop or Create\u0027)"}],"source_content_type":"text/x-smarty","patch_set":17,"id":"7f96bb07_814ff532","line":22,"range":{"start_line":18,"start_character":0,"end_line":22,"end_character":10},"updated":"2018-01-23 17:07:43.000000000","message":"These need to be organized according to the import style guide: https://docs.openstack.org/hacking/latest/user/hacking.html#import-order-template","commit_id":"a928c3ac1be982a4c276eae852f16d2934e81a7d"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"c0b9b1ee242b60fdafccff95ff4e24311e10defe","unresolved":false,"context_lines":[{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- define \"helm-toolkit.scripts.db_work\" }}"},{"line_number":18,"context_line":"from six.moves import configparser"},{"line_number":19,"context_line":"import logging"},{"line_number":20,"context_line":"from sqlalchemy import create_engine"},{"line_number":21,"context_line":"import os"},{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"sys_arg \u003d sys.argv[1]"},{"line_number":25,"context_line":"logger \u003d logging.getLogger(\u0027OpenStack-Helm DB Drop or Create\u0027)"}],"source_content_type":"text/x-smarty","patch_set":17,"id":"7f96bb07_a16c7136","line":22,"range":{"start_line":18,"start_character":0,"end_line":22,"end_character":10},"in_reply_to":"7f96bb07_814ff532","updated":"2018-01-23 19:04:25.000000000","message":"Done","commit_id":"a928c3ac1be982a4c276eae852f16d2934e81a7d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"2c6668f5a834b90f03a3035e0c4f0a49163bf6f4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"def main(dbArg\u003dsys_arg):"},{"line_number":29,"context_line":"    # Create logger, console handler and formatter"},{"line_number":30,"context_line":"    logger.setLevel(logging.DEBUG)"},{"line_number":31,"context_line":"    ch \u003d logging.StreamHandler()"},{"line_number":32,"context_line":"    ch.setLevel(logging.DEBUG)"},{"line_number":33,"context_line":"    formatter \u003d logging.Formatter(\u0027%(asctime)s - %(name)s - \\"},{"line_number":34,"context_line":"        %(levelname)s - %(message)s\u0027)"}],"source_content_type":"text/x-smarty","patch_set":17,"id":"7f96bb07_811615f1","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":6},"updated":"2018-01-23 17:07:43.000000000","message":"This should be a more descriptive variable name to line up with the other variables here","commit_id":"a928c3ac1be982a4c276eae852f16d2934e81a7d"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"c0b9b1ee242b60fdafccff95ff4e24311e10defe","unresolved":false,"context_lines":[{"line_number":28,"context_line":"def main(dbArg\u003dsys_arg):"},{"line_number":29,"context_line":"    # Create logger, console handler and formatter"},{"line_number":30,"context_line":"    logger.setLevel(logging.DEBUG)"},{"line_number":31,"context_line":"    ch \u003d logging.StreamHandler()"},{"line_number":32,"context_line":"    ch.setLevel(logging.DEBUG)"},{"line_number":33,"context_line":"    formatter \u003d logging.Formatter(\u0027%(asctime)s - %(name)s - \\"},{"line_number":34,"context_line":"        %(levelname)s - %(message)s\u0027)"}],"source_content_type":"text/x-smarty","patch_set":17,"id":"7f96bb07_c1673d51","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":6},"in_reply_to":"7f96bb07_811615f1","updated":"2018-01-23 19:04:25.000000000","message":"Done","commit_id":"a928c3ac1be982a4c276eae852f16d2934e81a7d"}],"keystone/values.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"450b5f8400d9060096ed7ec6fa866803520873e9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    db_init: docker.io/kolla/ubuntu-source-heat-engine:3.0.3"},{"line_number":31,"context_line":"    keystone_db_sync: docker.io/kolla/ubuntu-source-keystone:3.0.3"},{"line_number":32,"context_line":"    db_drop: docker.io/kolla/ubuntu-source-heat-engine:3.0.3"},{"line_number":33,"context_line":"    db_work: docker.io/kolla/ubuntu-source-heat-engine:3.0.3"},{"line_number":34,"context_line":"    keystone_fernet_setup: docker.io/kolla/ubuntu-source-keystone:3.0.3"},{"line_number":35,"context_line":"    keystone_fernet_rotate: docker.io/kolla/ubuntu-source-keystone:3.0.3"},{"line_number":36,"context_line":"    keystone_credential_setup: docker.io/kolla/ubuntu-source-keystone:3.0.3"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f96bb07_6023e306","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":60},"updated":"2018-01-12 21:09:59.000000000","message":"we do not need a new job here, we are just changing db_drop and db_init to use the new script.","commit_id":"894f6bf7bb9d9ec678e67730ac7e2cf5b8edf899"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"b02be380e4037c053d2f795b5fdb64c4458f12fc","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    db_init: docker.io/kolla/ubuntu-source-heat-engine:3.0.3"},{"line_number":31,"context_line":"    keystone_db_sync: docker.io/kolla/ubuntu-source-keystone:3.0.3"},{"line_number":32,"context_line":"    db_drop: docker.io/kolla/ubuntu-source-heat-engine:3.0.3"},{"line_number":33,"context_line":"    db_work: docker.io/kolla/ubuntu-source-heat-engine:3.0.3"},{"line_number":34,"context_line":"    keystone_fernet_setup: docker.io/kolla/ubuntu-source-keystone:3.0.3"},{"line_number":35,"context_line":"    keystone_fernet_rotate: docker.io/kolla/ubuntu-source-keystone:3.0.3"},{"line_number":36,"context_line":"    keystone_credential_setup: docker.io/kolla/ubuntu-source-keystone:3.0.3"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f96bb07_00ac5f32","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":60},"in_reply_to":"7f96bb07_6023e306","updated":"2018-01-22 15:27:25.000000000","message":"Done","commit_id":"894f6bf7bb9d9ec678e67730ac7e2cf5b8edf899"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d40c85ca6613e852da077a8ca5cbf8b08995cc3c","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    services:"},{"line_number":96,"context_line":"    - service: oslo_db"},{"line_number":97,"context_line":"      endpoint: internal"},{"line_number":98,"context_line":"  db_work:"},{"line_number":99,"context_line":"    services:"},{"line_number":100,"context_line":"    - service: oslo_db"},{"line_number":101,"context_line":"      endpoint: internal"},{"line_number":102,"context_line":"  fernet_setup:"},{"line_number":103,"context_line":"  fernet_rotate:"},{"line_number":104,"context_line":"    jobs:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f96bb07_930c4b3c","line":101,"range":{"start_line":98,"start_character":0,"end_line":101,"end_character":24},"updated":"2018-01-12 21:26:11.000000000","message":"can be removed.  there is no db_work dependency.","commit_id":"bf323ca79bb80237bc6bc9ccdfbd0192b84a7eba"},{"author":{"_account_id":27397,"name":"Gabe Maurer","email":"gm789v@att.com","username":"gmaurer"},"change_message_id":"b02be380e4037c053d2f795b5fdb64c4458f12fc","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    services:"},{"line_number":96,"context_line":"    - service: oslo_db"},{"line_number":97,"context_line":"      endpoint: internal"},{"line_number":98,"context_line":"  db_work:"},{"line_number":99,"context_line":"    services:"},{"line_number":100,"context_line":"    - service: oslo_db"},{"line_number":101,"context_line":"      endpoint: internal"},{"line_number":102,"context_line":"  fernet_setup:"},{"line_number":103,"context_line":"  fernet_rotate:"},{"line_number":104,"context_line":"    jobs:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f96bb07_737e5f6c","line":101,"range":{"start_line":98,"start_character":0,"end_line":101,"end_character":24},"in_reply_to":"7f96bb07_930c4b3c","updated":"2018-01-22 15:27:25.000000000","message":"Done","commit_id":"bf323ca79bb80237bc6bc9ccdfbd0192b84a7eba"}],"magnum/templates/job-db-init.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"fa2ab40ec63068004303faf65260135199722c2f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"              value: connection"},{"line_number":57,"context_line":"          command:"},{"line_number":58,"context_line":"            - /tmp/db-work.py"},{"line_number":59,"context_line":"            -create"},{"line_number":60,"context_line":"          volumeMounts:"},{"line_number":61,"context_line":"            - name: magnum-bin"},{"line_number":62,"context_line":"              mountPath: /tmp/db-work.py"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7f96bb07_22dbf14e","line":59,"range":{"start_line":59,"start_character":13,"end_line":59,"end_character":14},"updated":"2018-01-19 00:58:08.000000000","message":"space","commit_id":"f662bd78bcd04fd56ad338c19f413891c359406b"}]}