)]}'
{"ingress/templates/bin/_ingress-vip.sh.tpl":[{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"c62a29490cd4098a1f84002bf70ea06076d82b1a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"function stop () {"},{"line_number":44,"context_line":"  ip link set ${interface} down"},{"line_number":45,"context_line":"  ip link del ${interface}"},{"line_number":46,"context_line":"}"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":14,"id":"7f96bb07_9ff3de73","line":44,"updated":"2018-01-15 02:50:53.000000000","message":"I suggest remove /32 here, and if the interface is now empty, down and remove.  This allows future ingress incantations to potentially manage more then one address.","commit_id":"dba3a84e35ff581ec8534cf7e7dc868a9cdaaa11"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"c62a29490cd4098a1f84002bf70ea06076d82b1a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  read -u $sleep || :"},{"line_number":41,"context_line":"}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"function stop () {"},{"line_number":44,"context_line":"  ip link set ${interface} down"},{"line_number":45,"context_line":"  ip link del ${interface}"},{"line_number":46,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":15,"id":"7f96bb07_1fffce34","line":43,"updated":"2018-01-15 02:50:53.000000000","message":"As opposed to assuming there will only ever be one address, I suggest removing the addr here, and if the interface is now empty after the removal, down and remove. This allows future ingress incantations to potentially manage more then one address independently.","commit_id":"8e23192e75601ddbf48507f74cfeb42ce08a00c2"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"618689828fc08bccc2d6a11a3f26cadf6cbec50a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  read -u $sleep || :"},{"line_number":41,"context_line":"}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"function stop () {"},{"line_number":44,"context_line":"  ip link set ${interface} down"},{"line_number":45,"context_line":"  ip link del ${interface}"},{"line_number":46,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":15,"id":"7f96bb07_f0f9ef7f","line":43,"in_reply_to":"7f96bb07_1fffce34","updated":"2018-01-15 06:07:35.000000000","message":"Done","commit_id":"8e23192e75601ddbf48507f74cfeb42ce08a00c2"}]}