)]}'
{"ceph/values.yaml":[{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"7c686bdf87f20cde4e268800702d1975f56cfcf3","unresolved":false,"context_lines":[{"line_number":211,"context_line":"      client:"},{"line_number":212,"context_line":"      mds:"},{"line_number":213,"context_line":"  rbd:"},{"line_number":214,"context_line":"    pool_size: 128"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"dependencies:"},{"line_number":217,"context_line":"  cephfs_client_key_generator:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f96bb07_77db80ec","line":214,"updated":"2018-01-15 19:28:45.000000000","message":"i\u0027d suggest naming this something more like \"placement_groups\" or \"pool_pgs\", just to be completely explicit.","commit_id":"02b391d3ba5d5f8d91b66446e1df78a94177cd75"},{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"304e6a910e58d209da64495de4adac6d41d5c17e","unresolved":false,"context_lines":[{"line_number":211,"context_line":"      client:"},{"line_number":212,"context_line":"      mds:"},{"line_number":213,"context_line":"  rbd:"},{"line_number":214,"context_line":"    pool_size: 128"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"dependencies:"},{"line_number":217,"context_line":"  cephfs_client_key_generator:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f96bb07_c5bbb76f","line":214,"in_reply_to":"7f96bb07_77db80ec","updated":"2018-01-15 23:03:57.000000000","message":"i can call it pool_pg_size. think that would be good?","commit_id":"02b391d3ba5d5f8d91b66446e1df78a94177cd75"}],"tools/deployment/multinode/090-ceph-radosgateway.sh":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"91ba72302fdfb0fdfde854154867bc7f3d828dc1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    --set deployment.cephfs_provisioner\u003dfalse \\"},{"line_number":32,"context_line":"    --set deployment.client_secrets\u003dfalse \\"},{"line_number":33,"context_line":"    --set deployment.rgw_keystone_user_and_endpoints\u003dtrue \\"},{"line_number":34,"context_line":"    --values\u003d./tools/overrides/multinode/ceph.yaml"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"#NOTE: Wait for deploy"},{"line_number":37,"context_line":"./tools/deployment/common/wait-for-pods.sh openstack"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7f96bb07_62173cef","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":50},"updated":"2018-01-15 20:09:35.000000000","message":"can we use --set here. --values seems overkill for a single value.","commit_id":"02b391d3ba5d5f8d91b66446e1df78a94177cd75"},{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"304e6a910e58d209da64495de4adac6d41d5c17e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    --set deployment.cephfs_provisioner\u003dfalse \\"},{"line_number":32,"context_line":"    --set deployment.client_secrets\u003dfalse \\"},{"line_number":33,"context_line":"    --set deployment.rgw_keystone_user_and_endpoints\u003dtrue \\"},{"line_number":34,"context_line":"    --values\u003d./tools/overrides/multinode/ceph.yaml"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"#NOTE: Wait for deploy"},{"line_number":37,"context_line":"./tools/deployment/common/wait-for-pods.sh openstack"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7f96bb07_255a9b4e","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":50},"in_reply_to":"7f96bb07_62173cef","updated":"2018-01-15 23:03:57.000000000","message":"i just thought this file bein here would be good in case we need to add more things for the future. if you prefer --set, i can totally fine with it.","commit_id":"02b391d3ba5d5f8d91b66446e1df78a94177cd75"}]}