)]}'
{"ceph/templates/bin/osd/_block.sh.tpl":[{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"922e28f0a44d07aa9c7c6406d67c210ae0f8c256","unresolved":false,"context_lines":[{"line_number":26,"context_line":": \"${OSD_JOURNAL_PARTITION:\u003d}\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"if [ \"x${STORAGE_TYPE%-*}\" \u003d\u003d \"xdirectory\" ]; then"},{"line_number":29,"context_line":"  export OSD_DEVICE\u003d\"/var/lib/ceph/journal\""},{"line_number":30,"context_line":"else"},{"line_number":31,"context_line":"  export OSD_DEVICE\u003d$(readlink -f ${STORAGE_LOCATION})"},{"line_number":32,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":28,"id":"3fa0c359_59fc273d","line":29,"updated":"2018-02-12 18:31:20.000000000","message":"NIT: Believe this should not be the same path as the journal.","commit_id":"4591a9b3925f63a5fc30193050ef3f6e27bbe9c5"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"dd21d698b4a45272dae02a2e9e33fa78122be529","unresolved":false,"context_lines":[{"line_number":26,"context_line":": \"${OSD_JOURNAL_PARTITION:\u003d}\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"if [ \"x${STORAGE_TYPE%-*}\" \u003d\u003d \"xdirectory\" ]; then"},{"line_number":29,"context_line":"  export OSD_DEVICE\u003d\"/var/lib/ceph/journal\""},{"line_number":30,"context_line":"else"},{"line_number":31,"context_line":"  export OSD_DEVICE\u003d$(readlink -f ${STORAGE_LOCATION})"},{"line_number":32,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":28,"id":"3fa0c359_01baa56c","line":29,"in_reply_to":"3fa0c359_59fc273d","updated":"2018-02-12 20:06:31.000000000","message":"Done","commit_id":"4591a9b3925f63a5fc30193050ef3f6e27bbe9c5"}],"ceph/templates/bin/osd/_init.sh.tpl":[{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"30ef636c7c258d79250077665f08210bd741ac05","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    DATA_UUID\u003d$(blkid -o value -s PARTUUID ${OSD_DEVICE}1)"},{"line_number":179,"context_line":"    umount /var/lib/ceph/osd-lockbox/${DATA_UUID} || true"},{"line_number":180,"context_line":"  else"},{"line_number":181,"context_line":"    ceph-disk -v prepare ${CLI_OPTS} --journal-uuid ${OSD_JOURNAL_UUID} ${OSD_DEVICE} ${OSD_JOURNAL}"},{"line_number":182,"context_line":"  fi"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  # watch the udev event queue, and exit if all current events are handled"}],"source_content_type":"text/x-smarty","patch_set":17,"id":"5f93b717_9e79b9fd","line":181,"updated":"2018-01-26 14:06:46.000000000","message":"since things are undergoing a rewrite anyway, it might be a good idea to use ceph-volume, as ceph-disk is deprecated.  maybe even better would be to eliminate this call altogether, as it\u0027s not really doing anything we couldn\u0027t do in the script.","commit_id":"2f8274256a917487deb5aa45239e7fd738ecb628"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"7f560d3d5677c85f8f3e4681d905947e29c4751a","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    DATA_UUID\u003d$(blkid -o value -s PARTUUID ${OSD_DEVICE}1)"},{"line_number":179,"context_line":"    umount /var/lib/ceph/osd-lockbox/${DATA_UUID} || true"},{"line_number":180,"context_line":"  else"},{"line_number":181,"context_line":"    ceph-disk -v prepare ${CLI_OPTS} --journal-uuid ${OSD_JOURNAL_UUID} ${OSD_DEVICE} ${OSD_JOURNAL}"},{"line_number":182,"context_line":"  fi"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"  # watch the udev event queue, and exit if all current events are handled"}],"source_content_type":"text/x-smarty","patch_set":17,"id":"5f93b717_29f94dc7","line":181,"in_reply_to":"5f93b717_9e79b9fd","updated":"2018-01-26 14:25:59.000000000","message":"ceph-volume is where i would have like to have gone, though it requires lvm2 and sudo - which is not currently in the rh provided image.","commit_id":"2f8274256a917487deb5aa45239e7fd738ecb628"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"bd340e9284ed225ba658daf9a9426ef8d423e69e","unresolved":false,"context_lines":[{"line_number":128,"context_line":"          # maybe they specified the journal as a /dev path like \u0027/dev/sdc12\u0027:"},{"line_number":129,"context_line":"          local JDEV\u003d`echo ${OSD_JOURNAL} | sed \u0027s/\\(.*[^0-9]\\)[0-9]*$/\\1/\u0027`"},{"line_number":130,"context_line":"          if [ -d /sys/block/`basename $JDEV`/`basename $OSD_JOURNAL` ]; then"},{"line_number":131,"context_line":"            OSD_JOURNAL\u003d$(dev_part ${JDEV} `echo ${OSD_JOURNAL} |\\"},{"line_number":132,"context_line":"              sed \u0027s/.*[^0-9]\\([0-9]*\\)$/\\1/\u0027`)"},{"line_number":133,"context_line":"            OSD_JOURNAL_PARTITION\u003d${JDEV}"},{"line_number":134,"context_line":"          fi"}],"source_content_type":"text/x-smarty","patch_set":25,"id":"5f93b717_d99d9b0a","line":131,"updated":"2018-02-01 03:21:42.000000000","message":"dev_part doesn\u0027t seem to be defined in this script or anything it includes...  probably should copy in the definition from block.sh or put it in a library someplace.","commit_id":"ec768bf9894e54eae51dc425588555ae233b1cc1"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"dd21d698b4a45272dae02a2e9e33fa78122be529","unresolved":false,"context_lines":[{"line_number":128,"context_line":"          # maybe they specified the journal as a /dev path like \u0027/dev/sdc12\u0027:"},{"line_number":129,"context_line":"          local JDEV\u003d`echo ${OSD_JOURNAL} | sed \u0027s/\\(.*[^0-9]\\)[0-9]*$/\\1/\u0027`"},{"line_number":130,"context_line":"          if [ -d /sys/block/`basename $JDEV`/`basename $OSD_JOURNAL` ]; then"},{"line_number":131,"context_line":"            OSD_JOURNAL\u003d$(dev_part ${JDEV} `echo ${OSD_JOURNAL} |\\"},{"line_number":132,"context_line":"              sed \u0027s/.*[^0-9]\\([0-9]*\\)$/\\1/\u0027`)"},{"line_number":133,"context_line":"            OSD_JOURNAL_PARTITION\u003d${JDEV}"},{"line_number":134,"context_line":"          fi"}],"source_content_type":"text/x-smarty","patch_set":25,"id":"3fa0c359_c1afdd27","line":131,"in_reply_to":"5f93b717_d99d9b0a","updated":"2018-02-12 20:06:31.000000000","message":"Done","commit_id":"ec768bf9894e54eae51dc425588555ae233b1cc1"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"45c6c58c0a7f7456a948cee5ea6a81c36fd0df63","unresolved":false,"context_lines":[{"line_number":128,"context_line":"          # maybe they specified the journal as a /dev path like \u0027/dev/sdc12\u0027:"},{"line_number":129,"context_line":"          local JDEV\u003d`echo ${OSD_JOURNAL} | sed \u0027s/\\(.*[^0-9]\\)[0-9]*$/\\1/\u0027`"},{"line_number":130,"context_line":"          if [ -d /sys/block/`basename $JDEV`/`basename $OSD_JOURNAL` ]; then"},{"line_number":131,"context_line":"            OSD_JOURNAL\u003d$(dev_part ${JDEV} `echo ${OSD_JOURNAL} |\\"},{"line_number":132,"context_line":"              sed \u0027s/.*[^0-9]\\([0-9]*\\)$/\\1/\u0027`)"},{"line_number":133,"context_line":"            OSD_JOURNAL_PARTITION\u003d${JDEV}"},{"line_number":134,"context_line":"          fi"}],"source_content_type":"text/x-smarty","patch_set":25,"id":"3fa0c359_26b0acf4","line":131,"in_reply_to":"5f93b717_d99d9b0a","updated":"2018-02-06 15:15:18.000000000","message":"good catch, I\u0027ll fix in the next PS","commit_id":"ec768bf9894e54eae51dc425588555ae233b1cc1"},{"author":{"_account_id":18476,"name":"Ganesh Maharaj Mahalingam","email":"ganesh.mahalingam@intel.com","username":"gmmaha"},"change_message_id":"922e28f0a44d07aa9c7c6406d67c210ae0f8c256","unresolved":false,"context_lines":[{"line_number":23,"context_line":": \"${OSD_FORCE_ZAP:\u003d1}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"if [ \"x${STORAGE_TYPE%-*}\" \u003d\u003d \"xdirectory\" ]; then"},{"line_number":26,"context_line":"  export OSD_DEVICE\u003d\"/var/lib/ceph/journal\""},{"line_number":27,"context_line":"else"},{"line_number":28,"context_line":"  export OSD_DEVICE\u003d$(readlink -f ${STORAGE_LOCATION})"},{"line_number":29,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":28,"id":"3fa0c359_ab4dd23e","line":26,"updated":"2018-02-12 18:31:20.000000000","message":"Same NIT as the other file.","commit_id":"4591a9b3925f63a5fc30193050ef3f6e27bbe9c5"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"dd21d698b4a45272dae02a2e9e33fa78122be529","unresolved":false,"context_lines":[{"line_number":23,"context_line":": \"${OSD_FORCE_ZAP:\u003d1}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"if [ \"x${STORAGE_TYPE%-*}\" \u003d\u003d \"xdirectory\" ]; then"},{"line_number":26,"context_line":"  export OSD_DEVICE\u003d\"/var/lib/ceph/journal\""},{"line_number":27,"context_line":"else"},{"line_number":28,"context_line":"  export OSD_DEVICE\u003d$(readlink -f ${STORAGE_LOCATION})"},{"line_number":29,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":28,"id":"3fa0c359_e1b6998a","line":26,"in_reply_to":"3fa0c359_ab4dd23e","updated":"2018-02-12 20:06:31.000000000","message":"Done","commit_id":"4591a9b3925f63a5fc30193050ef3f6e27bbe9c5"}]}