)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"ad9a93a2358a4d692e174b061abf1aaa714c0b56","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implementes: ranger-agent helm charts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is an effor to deploy ranger-agent component"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Signed-off-by: Hari Om Singh\u003chosingh000@gmail.com\u003e"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f93b717_b5e019fc","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":16},"updated":"2018-01-29 23:52:47.000000000","message":"effort\n(+t)","commit_id":"d8a69515d45b4d4cdffcf9b51f0af6ae8f20fef3"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"05049083969e92999b85fbb600fd731aa64fff53","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pete Birley \u003cpete@port.direct\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-03-29 16:49:06 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implementes: ranger-agent helm charts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is an effort to implement helm charts for  ranger-agent component"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":53,"id":"bf659307_136b021e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":11},"updated":"2018-03-30 02:09:36.000000000","message":"Implements","commit_id":"c2e76faf950481b7e1f64cc71f942e872a0f817f"}],"helm-toolkit/templates/endpoints/_external_endpoint_uri_lookup.tpl":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a616bc0d023d57f49df6d4049861a40bb9f12a92","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# This function helps resolve database style endpoints:"},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# Presuming that .Values contains an endpoint: definition for \u0027git_repo\u0027 with the"},{"line_number":20,"context_line":"# appropriate attributes, a call such as:"},{"line_number":21,"context_line":"# { tuple \"git_repo\" \"internal\" \"ord\" \"git_port\" . | include \"helm-toolkit.endpoints.external_endpoint_uri_lookup\" }"},{"line_number":22,"context_line":"# where portName is optional if a default port has been defined in .Values"},{"line_number":23,"context_line":"# returns: ssh://abc@internal_host:3306/dbname"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{{- define \"helm-toolkit.endpoints.external_endpoint_uri_lookup\" -}}"},{"line_number":26,"context_line":"{{- $type :\u003d index . 0 -}}"}],"source_content_type":"text/x-smarty","patch_set":38,"id":"df7087c5_0f4c59c6","line":23,"range":{"start_line":17,"start_character":0,"end_line":23,"end_character":46},"updated":"2018-03-22 14:01:21.000000000","message":"If this is used for git repositories, can we remove the database references here and include a more accurate example of the rendered endpoint? The example output here doesn\u0027t match the pattern provided in the printf statement","commit_id":"f0c4f8517f0c7ab55acef8fd1b065a3274c4ef8a"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6eb3b2f34c46b0907fe0de349b647a289fbf8c4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":49,"id":"bf659307_06ee9f87","updated":"2018-03-28 06:01:33.000000000","message":"how does this differ from: https://github.com/openstack/openstack-helm/blob/master/helm-toolkit/templates/endpoints/_keystone_endpoint_uri_lookup.tpl, which this appears to be a subset of?","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"9eee53537ba66e4623c2edaa7b779ca097e191cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":49,"id":"bf659307_68ef1db0","in_reply_to":"bf659307_06ee9f87","updated":"2018-03-28 15:54:42.000000000","message":"We created to lookup external url and other patterns like ssh://user@url/path but we have changed it to not use for git repo and all so I will change it to keystone_endpoint_uri_lookup","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"}],"ranger-agent/Chart.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6eb3b2f34c46b0907fe0de349b647a289fbf8c4b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"description: OpenStack-Helm Ranger Agent"},{"line_number":15,"context_line":"name: ranger-agent"},{"line_number":16,"context_line":"version: 0.1.0"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"sources:"},{"line_number":19,"context_line":"  - https://git.openstack.org/cgit/openstack/ranger-agent"},{"line_number":20,"context_line":"  - https://git.openstack.org/cgit/openstack/openstack-helm"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"bf659307_66fe7b38","line":17,"updated":"2018-03-28 06:01:33.000000000","message":"remove","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"}],"ranger-agent/templates/bin/_db-sync.sh.tpl":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a616bc0d023d57f49df6d4049861a40bb9f12a92","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"set -ex"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"COMMAND\u003d\"${@:-start}\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"function start () {"},{"line_number":24,"context_line":"  exec ranger-agent-dbsync \\"},{"line_number":25,"context_line":"        --config-file /etc/ranger-agent/ranger-agent.conf"},{"line_number":26,"context_line":"}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"function stop () {"},{"line_number":29,"context_line":"  kill -TERM 1"},{"line_number":30,"context_line":"}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"$COMMAND"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":38,"id":"df7087c5_eff56558","line":32,"range":{"start_line":21,"start_character":0,"end_line":32,"end_character":8},"updated":"2018-03-22 14:01:21.000000000","message":"As this is executed by a job, it only needs the exec command here, not the functions or COMMAND bits","commit_id":"f0c4f8517f0c7ab55acef8fd1b065a3274c4ef8a"}],"ranger-agent/templates/bin/_health-check.sh.tpl":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"70643e40ce95d39d20fb908b3771cc4aea7d6a24","unresolved":false,"context_lines":[{"line_number":40,"context_line":"function engineliveness () {"},{"line_number":41,"context_line":"  enginereadiness"},{"line_number":42,"context_line":"}"},{"line_number":43,"context_line":"$COMMAND"}],"source_content_type":"text/x-smarty","patch_set":31,"id":"df7087c5_d7464a22","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":8},"updated":"2018-03-20 04:43:53.000000000","message":"This isn\u0027t defined in this file","commit_id":"ff894aba67a6977a5c99f7cf208695c5fa2b4dff"}],"ranger-agent/templates/bin/_ranger-agent-api.sh.tpl":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"70643e40ce95d39d20fb908b3771cc4aea7d6a24","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":7,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":31,"id":"df7087c5_7753bee3","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":14},"updated":"2018-03-20 04:43:53.000000000","message":"nit: All these copyrights should be 2018.","commit_id":"ff894aba67a6977a5c99f7cf208695c5fa2b4dff"}],"ranger-agent/templates/bin/_ranger-agent-engine.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"2e30b82f6044676753764717dc88bdc1fed9af78","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  kill -TERM 1"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"IFS\u003d\u0027,\u0027"},{"line_number":33,"context_line":"for KEY_TYPE in $KEY_TYPES; do"},{"line_number":34,"context_line":"    KEY_PATH\u003d/etc/ssh/ssh_host_${KEY_TYPE}_key"},{"line_number":35,"context_line":"    if [[ ! -f \"${KEY_PATH}\" ]]; then"},{"line_number":36,"context_line":"        ssh-keygen -q -t ${KEY_TYPE} -f ${KEY_PATH} -N \"\""},{"line_number":37,"context_line":"    fi"},{"line_number":38,"context_line":"done"},{"line_number":39,"context_line":"IFS\u003d\u0027\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"mkdir -p ~aic-ord/.ssh"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"if [[ $(stat -c %U:%G ~aic-ord/.ssh) !\u003d \"aic-ord:aic-ord\" ]]; then"},{"line_number":44,"context_line":"    chown aic-ord: ~aic-ord/.ssh"},{"line_number":45,"context_line":"fi"},{"line_number":46,"context_line":"}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"$COMMAND"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"3fa0c359_fb5a2ff1","line":45,"range":{"start_line":32,"start_character":0,"end_line":45,"end_character":2},"updated":"2018-02-07 21:35:28.000000000","message":"why is this generating shh keys on shutdown - and AIC is not appropriate here.","commit_id":"6dd3b1f9e040523fe6cba08d4e315137217efb95"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"34600fdb4911e243cd69044db21ec2689d87dee3","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  kill -TERM 1"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"IFS\u003d\u0027,\u0027"},{"line_number":33,"context_line":"for KEY_TYPE in $KEY_TYPES; do"},{"line_number":34,"context_line":"    KEY_PATH\u003d/etc/ssh/ssh_host_${KEY_TYPE}_key"},{"line_number":35,"context_line":"    if [[ ! -f \"${KEY_PATH}\" ]]; then"},{"line_number":36,"context_line":"        ssh-keygen -q -t ${KEY_TYPE} -f ${KEY_PATH} -N \"\""},{"line_number":37,"context_line":"    fi"},{"line_number":38,"context_line":"done"},{"line_number":39,"context_line":"IFS\u003d\u0027\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"mkdir -p ~aic-ord/.ssh"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"if [[ $(stat -c %U:%G ~aic-ord/.ssh) !\u003d \"aic-ord:aic-ord\" ]]; then"},{"line_number":44,"context_line":"    chown aic-ord: ~aic-ord/.ssh"},{"line_number":45,"context_line":"fi"},{"line_number":46,"context_line":"}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"$COMMAND"}],"source_content_type":"text/x-smarty","patch_set":10,"id":"3fa0c359_5ec0f150","line":45,"range":{"start_line":32,"start_character":0,"end_line":45,"end_character":2},"in_reply_to":"3fa0c359_fb5a2ff1","updated":"2018-02-07 22:11:13.000000000","message":"Remove for now, Will go with ssh key separately,Thanks","commit_id":"6dd3b1f9e040523fe6cba08d4e315137217efb95"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"315229b8f5d5b7fe158c1524bdf8c44c8f387180","unresolved":false,"context_lines":[{"line_number":23,"context_line":"function start () {"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"if [[ $(stat -c %F ${USER_HOME}/.ssh) !\u003d \"directory\" ]]; then"},{"line_number":26,"context_line":"    mkdir -p ${USER_HOME}/.ssh"},{"line_number":27,"context_line":"    echo -e \"${SSH_KEY}\" \u003e\u003e${USER_HOME}/.ssh/${SSH_KEY_FILE}"},{"line_number":28,"context_line":"    echo -e \"${SSH_KEY_CONFIGURATION}\" \u003e\u003e${USER_HOME}/.ssh/config"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    chown ranger_agent: ${USER_HOME}/.ssh"},{"line_number":31,"context_line":"    chmod 0700 -R ${USER_HOME}/.ssh"},{"line_number":32,"context_line":"    chmod 0644 ${USER_HOME}/.ssh/config"},{"line_number":33,"context_line":"    chmod 0600 ${USER_HOME}/.ssh/${SSH_KEY_FILE}"},{"line_number":34,"context_line":"fi"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  exec ranger-agent-engine \\"}],"source_content_type":"text/x-smarty","patch_set":23,"id":"df7087c5_15361005","line":33,"range":{"start_line":26,"start_character":0,"end_line":33,"end_character":48},"updated":"2018-03-08 02:52:22.000000000","message":"why dont we do this via mounts?","commit_id":"a308619e7102b1bcd51fa4b1e7ad82a6ff3cfee9"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"40b9d6bfd4acbee3724c489f2dd3135422310442","unresolved":false,"context_lines":[{"line_number":23,"context_line":"function start () {"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"if [[ $(stat -c %F ${USER_HOME}/.ssh) !\u003d \"directory\" ]]; then"},{"line_number":26,"context_line":"    mkdir -p ${USER_HOME}/.ssh"},{"line_number":27,"context_line":"    echo -e \"${SSH_KEY}\" \u003e\u003e${USER_HOME}/.ssh/${SSH_KEY_FILE}"},{"line_number":28,"context_line":"    echo -e \"${SSH_KEY_CONFIGURATION}\" \u003e\u003e${USER_HOME}/.ssh/config"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    chown ranger_agent: ${USER_HOME}/.ssh"},{"line_number":31,"context_line":"    chmod 0700 -R ${USER_HOME}/.ssh"},{"line_number":32,"context_line":"    chmod 0644 ${USER_HOME}/.ssh/config"},{"line_number":33,"context_line":"    chmod 0600 ${USER_HOME}/.ssh/${SSH_KEY_FILE}"},{"line_number":34,"context_line":"fi"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  exec ranger-agent-engine \\"}],"source_content_type":"text/x-smarty","patch_set":23,"id":"df7087c5_a6512adb","line":33,"range":{"start_line":26,"start_character":0,"end_line":33,"end_character":48},"in_reply_to":"df7087c5_15361005","updated":"2018-03-08 16:22:38.000000000","message":"This was secret file for encryption and that is why we are copying here as ceph is doing","commit_id":"a308619e7102b1bcd51fa4b1e7ad82a6ff3cfee9"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"c068458dbd83920dd1260df4d8b6e90de9315e3f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"set -x"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"COMMAND\u003d\"${@:-start}\""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":31,"id":"df7087c5_3761c63a","line":19,"range":{"start_line":19,"start_character":3,"end_line":19,"end_character":6},"updated":"2018-03-20 05:27:43.000000000","message":"-xe?","commit_id":"ff894aba67a6977a5c99f7cf208695c5fa2b4dff"}],"ranger-agent/templates/bin/_ranger-agent-test.sh.tpl":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"70643e40ce95d39d20fb908b3771cc4aea7d6a24","unresolved":false,"context_lines":[{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"set -ex"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Come up with a ranger agent payload"},{"line_number":23,"context_line":"url\u003d\"${RANGER_SERVICE_URL}\""}],"source_content_type":"text/x-smarty","patch_set":31,"id":"df7087c5_375f86e6","line":20,"updated":"2018-03-20 04:43:53.000000000","message":"Extra newline","commit_id":"ff894aba67a6977a5c99f7cf208695c5fa2b4dff"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"70643e40ce95d39d20fb908b3771cc4aea7d6a24","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Come up with a ranger agent payload"},{"line_number":23,"context_line":"url\u003d\"${RANGER_SERVICE_URL}\""},{"line_number":24,"context_line":"UUID\u003d$(python  -c \u0027import uuid; print uuid.uuid1()\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"PAYLOAD\u003d\"{\\\"ord-notifier\\\":{"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":31,"id":"df7087c5_57647ab9","line":24,"range":{"start_line":24,"start_character":13,"end_line":24,"end_character":14},"updated":"2018-03-20 04:43:53.000000000","message":"Extra WS","commit_id":"ff894aba67a6977a5c99f7cf208695c5fa2b4dff"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"33bff0c343c28ead76cf4e7d048e46a8a57d66b6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    }"},{"line_number":45,"context_line":"}\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"echo \"*******Ranger Agent notification request :: ${PAYLOAD} \" \u003e\u003e ranger_output.txt"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"url\u003d\"${RANGER_SERVICE_URL}\""}],"source_content_type":"text/x-smarty","patch_set":31,"id":"df7087c5_d723aa04","line":47,"range":{"start_line":47,"start_character":63,"end_line":47,"end_character":83},"updated":"2018-03-20 05:18:47.000000000","message":"we can just print things to stdout","commit_id":"ff894aba67a6977a5c99f7cf208695c5fa2b4dff"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"70643e40ce95d39d20fb908b3771cc4aea7d6a24","unresolved":false,"context_lines":[{"line_number":47,"context_line":"echo \"*******Ranger Agent notification request :: ${PAYLOAD} \" \u003e\u003e ranger_output.txt"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"url\u003d\"${RANGER_SERVICE_URL}\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"function assertContains()"},{"line_number":53,"context_line":"{"}],"source_content_type":"text/x-smarty","patch_set":31,"id":"df7087c5_f7582efb","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":27},"updated":"2018-03-20 04:43:53.000000000","message":"Already defined on L23","commit_id":"ff894aba67a6977a5c99f7cf208695c5fa2b4dff"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"33bff0c343c28ead76cf4e7d048e46a8a57d66b6","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"url\u003d\"${RANGER_SERVICE_URL}\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"function assertContains()"},{"line_number":53,"context_line":"{"},{"line_number":54,"context_line":"    expected\u003d$1"},{"line_number":55,"context_line":"    msg\u003d$2"}],"source_content_type":"text/x-smarty","patch_set":31,"id":"df7087c5_971d32bf","line":52,"range":{"start_line":52,"start_character":9,"end_line":52,"end_character":25},"updated":"2018-03-20 05:18:47.000000000","message":"this assert function and thus the entire test can never fail (or return an error code !\u003d 0) aside from printing a FAILED message.  Can we do an exit 1 if there is a failure?","commit_id":"ff894aba67a6977a5c99f7cf208695c5fa2b4dff"},{"author":{"_account_id":21242,"name":"Michael Glaser","email":"michael.glaser@att.com","username":"MikeG451"},"change_message_id":"f28acf359477e6312a21b11ab075dcd7df904a67","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"url\u003d\"${RANGER_SERVICE_URL}\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"function assertContains()"},{"line_number":53,"context_line":"{"},{"line_number":54,"context_line":"    expected\u003d$1"},{"line_number":55,"context_line":"    msg\u003d$2"}],"source_content_type":"text/x-smarty","patch_set":31,"id":"df7087c5_11e7c0e6","line":52,"range":{"start_line":52,"start_character":9,"end_line":52,"end_character":25},"in_reply_to":"df7087c5_971d32bf","updated":"2018-03-21 19:28:05.000000000","message":"Done","commit_id":"ff894aba67a6977a5c99f7cf208695c5fa2b4dff"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"33bff0c343c28ead76cf4e7d048e46a8a57d66b6","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    if echo \"$msg\" | grep -q \"$expected\"; then"},{"line_number":59,"context_line":"      echo \"***TEST IS PASSED: EXPECTED\u003d$expected is in Responce\" \u003e\u003e ranger_output.txt"},{"line_number":60,"context_line":"    else"},{"line_number":61,"context_line":"      echo \"***FAILED: EXPECTED\u003d$expected in Responce\" \u003e\u003e ranger_output.txt"},{"line_number":62,"context_line":"    fi"},{"line_number":63,"context_line":"}"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":31,"id":"df7087c5_171282b2","line":61,"range":{"start_line":61,"start_character":55,"end_line":61,"end_character":75},"updated":"2018-03-20 05:18:47.000000000","message":"can we not print these to stdout so it will be capture in the log?","commit_id":"ff894aba67a6977a5c99f7cf208695c5fa2b4dff"},{"author":{"_account_id":23276,"name":"Nicholas Jones","email":"nj762h@att.com","username":"nj762h"},"change_message_id":"0b7f4105fb184168d23f00c884dc704ed5c86b56","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    fi"},{"line_number":60,"context_line":"}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Request_submit_Responce\u003d\"*******Ranger Agent notification Responce of POST CALL***** :: $(curl -i -X POST -d \"${PAYLOAD}\"  $url --header \"Content-type:application/json\")\""},{"line_number":63,"context_line":"expected\u003d\"Submitted\""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"assertContains \"${expected}\" \"${Request_submit_Responce}\""}],"source_content_type":"text/x-smarty","patch_set":33,"id":"df7087c5_e678502c","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":23},"updated":"2018-03-21 14:59:08.000000000","message":"response; consistent variable naming scheme.","commit_id":"1829cf6d051b6642fb3cd47ab5ff6aa73aa45a66"},{"author":{"_account_id":23276,"name":"Nicholas Jones","email":"nj762h@att.com","username":"nj762h"},"change_message_id":"0b7f4105fb184168d23f00c884dc704ed5c86b56","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"sleep 15"},{"line_number":68,"context_line":"expected\u003d\"Error\""},{"line_number":69,"context_line":"Resorce_Status_From_Engine\u003d\"*******GET Resorce Status From Engine of POST CALL*****:: $(curl -s \"$url?Id\u003d$UUID\")\""},{"line_number":70,"context_line":"assertContains \"${expected}\" \"$Resorce_Status_From_Engine\""}],"source_content_type":"text/x-smarty","patch_set":33,"id":"df7087c5_869e3461","line":69,"range":{"start_line":69,"start_character":39,"end_line":69,"end_character":46},"updated":"2018-03-21 14:59:08.000000000","message":"s/resorce/resource/","commit_id":"1829cf6d051b6642fb3cd47ab5ff6aa73aa45a66"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a616bc0d023d57f49df6d4049861a40bb9f12a92","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    fi"},{"line_number":57,"context_line":"}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Request_submit_Response\u003d\"$(curl -i -X POST -d \"${PAYLOAD}\"  $url --header \"Content-type:application/json\")\""},{"line_number":60,"context_line":"expected\u003d\"Submitted\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"assertContains \"${expected}\" \"${Request_submit_Response}\""}],"source_content_type":"text/x-smarty","patch_set":38,"id":"df7087c5_0f8f79cd","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":23},"updated":"2018-03-22 14:01:21.000000000","message":"Let\u0027s keep the case consistent here","commit_id":"f0c4f8517f0c7ab55acef8fd1b065a3274c4ef8a"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a616bc0d023d57f49df6d4049861a40bb9f12a92","unresolved":false,"context_lines":[{"line_number":57,"context_line":"}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Request_submit_Response\u003d\"$(curl -i -X POST -d \"${PAYLOAD}\"  $url --header \"Content-type:application/json\")\""},{"line_number":60,"context_line":"expected\u003d\"Submitted\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"assertContains \"${expected}\" \"${Request_submit_Response}\""},{"line_number":63,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":38,"id":"df7087c5_cfbe6164","line":60,"range":{"start_line":60,"start_character":0,"end_line":60,"end_character":8},"updated":"2018-03-22 14:01:21.000000000","message":"As `expected` is used twice, can we make these names more meaningful? ie: expected_response, or something similar","commit_id":"f0c4f8517f0c7ab55acef8fd1b065a3274c4ef8a"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"a2508db46da33ead395b9254196fcabe9f4b5889","unresolved":false,"context_lines":[{"line_number":23,"context_line":"UUID\u003d$(python -c \u0027import uuid; print uuid.uuid1()\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"PAYLOAD\u003d\"{\\\"ord-notifier\\\":{"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    \\\"request-id\\\":\\\"$UUID\\\","},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    \\\"resource-id\\\":\\\"$UUID\\\","}],"source_content_type":"text/x-smarty","patch_set":43,"id":"bf659307_333b38d2","line":26,"updated":"2018-03-24 23:29:21.000000000","message":"Why the extra newlines?  Is that intentional or a CRLF format issue?","commit_id":"34bb46485c34ca315c6e2dae066af429884ad3db"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"bb15d7d370c473dec2c3f40f22c51a51d42945af","unresolved":false,"context_lines":[{"line_number":23,"context_line":"UUID\u003d$(python -c \u0027import uuid; print uuid.uuid1()\u0027)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"PAYLOAD\u003d\"{\\\"ord-notifier\\\":{"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    \\\"request-id\\\":\\\"$UUID\\\","},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    \\\"resource-id\\\":\\\"$UUID\\\","}],"source_content_type":"text/x-smarty","patch_set":43,"id":"bf659307_c5d539bb","line":26,"in_reply_to":"bf659307_333b38d2","updated":"2018-03-26 13:41:17.000000000","message":"It is not intentional, used Json formator to build request parameter then pasted valid request received from formator","commit_id":"34bb46485c34ca315c6e2dae066af429884ad3db"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"a2508db46da33ead395b9254196fcabe9f4b5889","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"expected_on_execution\u003d\"Error\""},{"line_number":67,"context_line":"resource_status_from_engine\u003d\"$(curl -s \"$url?Id\u003d$UUID\")\""},{"line_number":68,"context_line":"assertContains \"${expected_on_execution}\" \"$resource_status_from_engine\""}],"source_content_type":"text/x-smarty","patch_set":43,"id":"bf659307_5366ecef","line":68,"updated":"2018-03-24 23:29:21.000000000","message":"Hari, I know you\u0027d been considering both an expected error test and an expected success test, with the latter being preferable but requiring some additional changes to Ranger-Agent to avoid calling back to Ranger.  Are we still moving toward that plan - I think it would be best to successfully run a heat template if it\u0027s feasible to do so.","commit_id":"34bb46485c34ca315c6e2dae066af429884ad3db"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"bb15d7d370c473dec2c3f40f22c51a51d42945af","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"expected_on_execution\u003d\"Error\""},{"line_number":67,"context_line":"resource_status_from_engine\u003d\"$(curl -s \"$url?Id\u003d$UUID\")\""},{"line_number":68,"context_line":"assertContains \"${expected_on_execution}\" \"$resource_status_from_engine\""}],"source_content_type":"text/x-smarty","patch_set":43,"id":"bf659307_c0f767f5","line":68,"in_reply_to":"bf659307_5366ecef","updated":"2018-03-26 13:41:17.000000000","message":"We are moving in that direction. Goal for this test to receive API message to assert -API is responsive (with request Submitted) and second to identify Engine have done it work so we receive Error message from the get call we implemented after template pull fulfilling all the prerequisite.\n\nhttp://logs.openstack.org/41/538341/43/check/openstack-helm-multinode-ubuntu/ee2682d/primary/pod-logs/openstack/ranger-agent-test/ranger-agent-test.txt.gz \n\nFailure we are getting is 400, which need to be investigated is flavor plugin not enabled(which by default not enabled in openstack). This is a validation of openstack heat template and identify why do we get \"Property error: : resources.nova_flavor.properties: error with a service admin user for flavor.\n\nOn a different node- I have refactored ranger agent 4 times because helm tool kit code is standardized multiple times and we do not have supporting stories related to that.If ranger agent code look ok then we should move forward because I am pretty sure that we do not need to change a single line of code in case heat template is working for service tenant for an admin user. \n\nOnce this code is merged we can deploy in lab and validate and tweak identify issue and add success scenario also","commit_id":"34bb46485c34ca315c6e2dae066af429884ad3db"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6eb3b2f34c46b0907fe0de349b647a289fbf8c4b","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"assertContains \"${expected_on_request}\" \"${request_submit_response}\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"sleep 15"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"expected_on_execution\u003d\"Success\""},{"line_number":58,"context_line":"resource_status_from_engine\u003d\"$(curl -s \"$url?Id\u003d$UUID\")\""}],"source_content_type":"text/x-smarty","patch_set":49,"id":"bf659307_a6601303","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":8},"updated":"2018-03-28 06:01:33.000000000","message":"why? it would be beneficial to include a note here.","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"9eee53537ba66e4623c2edaa7b779ca097e191cd","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"assertContains \"${expected_on_request}\" \"${request_submit_response}\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"sleep 15"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"expected_on_execution\u003d\"Success\""},{"line_number":58,"context_line":"resource_status_from_engine\u003d\"$(curl -s \"$url?Id\u003d$UUID\")\""}],"source_content_type":"text/x-smarty","patch_set":49,"id":"bf659307_e344ae1d","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":8},"in_reply_to":"bf659307_a6601303","updated":"2018-03-28 15:54:42.000000000","message":"ok , I will include","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"}],"ranger-agent/templates/bin/_ssh-start.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"73cb769355d2a50846678c435924f2a96b03b0d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5f93b717_84eb5ada","updated":"2018-01-30 15:56:07.000000000","message":"required?","commit_id":"d8a69515d45b4d4cdffcf9b51f0af6ae8f20fef3"}],"ranger-agent/templates/configmap-bin.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"73cb769355d2a50846678c435924f2a96b03b0d5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"{{ tuple \"bin/_ranger-agent-api.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":42,"context_line":"  ranger-agent-engine.sh: |"},{"line_number":43,"context_line":"{{ tuple \"bin/_ranger-agent-engine.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":44,"context_line":"  ssh-start.sh: |"},{"line_number":45,"context_line":"{{ tuple \"bin/_ssh-start.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":46,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f93b717_e4b33e09","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":88},"updated":"2018-01-30 15:56:07.000000000","message":"required?","commit_id":"d8a69515d45b4d4cdffcf9b51f0af6ae8f20fef3"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"2e30b82f6044676753764717dc88bdc1fed9af78","unresolved":false,"context_lines":[{"line_number":21,"context_line":"apiVersion: v1"},{"line_number":22,"context_line":"kind: ConfigMap"},{"line_number":23,"context_line":"metadata:"},{"line_number":24,"context_line":"  name: ord-bin"},{"line_number":25,"context_line":"data:"},{"line_number":26,"context_line":"  rally-test.sh: |"},{"line_number":27,"context_line":"{{ tuple $rallyTests | include \"helm-toolkit.scripts.rally_test\" | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa0c359_bb6a67b0","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":11},"updated":"2018-02-07 21:35:28.000000000","message":"ranger-agent","commit_id":"6dd3b1f9e040523fe6cba08d4e315137217efb95"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"34600fdb4911e243cd69044db21ec2689d87dee3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"apiVersion: v1"},{"line_number":22,"context_line":"kind: ConfigMap"},{"line_number":23,"context_line":"metadata:"},{"line_number":24,"context_line":"  name: ord-bin"},{"line_number":25,"context_line":"data:"},{"line_number":26,"context_line":"  rally-test.sh: |"},{"line_number":27,"context_line":"{{ tuple $rallyTests | include \"helm-toolkit.scripts.rally_test\" | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa0c359_3ed40520","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":11},"in_reply_to":"3fa0c359_bb6a67b0","updated":"2018-02-07 22:11:13.000000000","message":"will change etc and bin to ranger-agent","commit_id":"6dd3b1f9e040523fe6cba08d4e315137217efb95"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"99dad24eea21adfa5feec75942b3fd5289ad0251","unresolved":false,"context_lines":[{"line_number":23,"context_line":"metadata:"},{"line_number":24,"context_line":"  name: ranger-agent-bin"},{"line_number":25,"context_line":"data:"},{"line_number":26,"context_line":"  rally-test.sh: |"},{"line_number":27,"context_line":"{{ tuple $rallyTests | include \"helm-toolkit.scripts.rally_test\" | indent 4 }}"},{"line_number":28,"context_line":"  db-init.py: |+"},{"line_number":29,"context_line":"{{- include \"helm-toolkit.scripts.db_init\" . | indent 4 }}"},{"line_number":30,"context_line":"  db-sync.sh: |+"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"df7087c5_276c5835","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":78},"updated":"2018-03-07 14:18:12.000000000","message":"We need to include relevant tests if at all possible for ranger agent.  I don\u0027t see any helm test pods defined as part of this effort","commit_id":"d3ab54a79d41a30a0fc8e3f7387024bd1cc07dd0"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"0562de2bc5e786125d0e52b60d06e2d6bb77dcbc","unresolved":false,"context_lines":[{"line_number":23,"context_line":"metadata:"},{"line_number":24,"context_line":"  name: ranger-agent-bin"},{"line_number":25,"context_line":"data:"},{"line_number":26,"context_line":"  rally-test.sh: |"},{"line_number":27,"context_line":"{{ tuple $rallyTests | include \"helm-toolkit.scripts.rally_test\" | indent 4 }}"},{"line_number":28,"context_line":"  db-init.py: |+"},{"line_number":29,"context_line":"{{- include \"helm-toolkit.scripts.db_init\" . | indent 4 }}"},{"line_number":30,"context_line":"  db-sync.sh: |+"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"df7087c5_503d84b9","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":78},"in_reply_to":"df7087c5_276c5835","updated":"2018-03-07 16:24:32.000000000","message":"We have not planned to write helm test yet because ranher agent have it repo and some other dependency, so I will remove it for now","commit_id":"d3ab54a79d41a30a0fc8e3f7387024bd1cc07dd0"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a616bc0d023d57f49df6d4049861a40bb9f12a92","unresolved":false,"context_lines":[{"line_number":23,"context_line":"metadata:"},{"line_number":24,"context_line":"  name: ranger-agent-bin"},{"line_number":25,"context_line":"data:"},{"line_number":26,"context_line":"  rally-test.sh: |"},{"line_number":27,"context_line":"{{ tuple $rallyTests | include \"helm-toolkit.scripts.rally_test\" | indent 4 }}"},{"line_number":28,"context_line":"  db-init.py: |+"},{"line_number":29,"context_line":"{{- include \"helm-toolkit.scripts.db_init\" . | indent 4 }}"},{"line_number":30,"context_line":"  db-sync.sh: |+"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"df7087c5_6faf152a","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":78},"updated":"2018-03-22 14:01:21.000000000","message":"This should be removed","commit_id":"f0c4f8517f0c7ab55acef8fd1b065a3274c4ef8a"}],"ranger-agent/templates/configmap-etc.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"2e30b82f6044676753764717dc88bdc1fed9af78","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{{- if .Values.manifests.configmap_etc }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{- if empty .Values.conf.ranger_agent.database.connection -}}"},{"line_number":22,"context_line":"{{- tuple \"oslo_db\" \"internal\" \"ord\" \"mysql\" . | include \"helm-toolkit.endpoints.authenticated_endpoint_uri_lookup\"| set .Values.conf.ranger_agent.database \"connection\" | quote | trunc 0 -}}"},{"line_number":23,"context_line":"{{- end -}}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa0c359_7b64dfe4","line":20,"updated":"2018-02-07 21:35:28.000000000","message":"extra ws","commit_id":"6dd3b1f9e040523fe6cba08d4e315137217efb95"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"34600fdb4911e243cd69044db21ec2689d87dee3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{{- if .Values.manifests.configmap_etc }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{- if empty .Values.conf.ranger_agent.database.connection -}}"},{"line_number":22,"context_line":"{{- tuple \"oslo_db\" \"internal\" \"ord\" \"mysql\" . | include \"helm-toolkit.endpoints.authenticated_endpoint_uri_lookup\"| set .Values.conf.ranger_agent.database \"connection\" | quote | trunc 0 -}}"},{"line_number":23,"context_line":"{{- end -}}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa0c359_7e55adc5","line":20,"in_reply_to":"3fa0c359_7b64dfe4","updated":"2018-02-07 22:11:13.000000000","message":"Will fix it","commit_id":"6dd3b1f9e040523fe6cba08d4e315137217efb95"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"2e30b82f6044676753764717dc88bdc1fed9af78","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{{- if empty .Values.conf.ranger_agent.DEFAULT.ord_server_url -}}"},{"line_number":30,"context_line":"{{- tuple \"ord\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_uri_lookup\" | trimSuffix .Values.endpoints.ranger_agent.path.default | set .Values.conf.ranger_agent.DEFAULT \"ord_server_url\" | quote | trunc 0 -}}"},{"line_number":31,"context_line":"{{- end -}}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{{- if empty .Values.conf.ranger_agent.keystone_authtoken.username -}}"},{"line_number":34,"context_line":"{{- set .Values.conf.ranger_agent.keystone_authtoken \"username\" .Values.endpoints.identity.auth.ord_stack_user.username | quote | trunc 0 -}}"},{"line_number":35,"context_line":"{{- end -}}"},{"line_number":36,"context_line":"{{- if empty .Values.conf.ranger_agent.keystone_authtoken.password -}}"},{"line_number":37,"context_line":"{{- set .Values.conf.ranger_agent.keystone_authtoken \"password\" .Values.endpoints.identity.auth.ord_stack_user.password | quote | trunc 0 -}}"},{"line_number":38,"context_line":"{{- end -}}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"---"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa0c359_bbafc7e1","line":38,"range":{"start_line":32,"start_character":0,"end_line":38,"end_character":11},"updated":"2018-02-07 21:35:28.000000000","message":"what about domains, regions, Memcached etc","commit_id":"6dd3b1f9e040523fe6cba08d4e315137217efb95"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"34600fdb4911e243cd69044db21ec2689d87dee3","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{{- if empty .Values.conf.ranger_agent.DEFAULT.ord_server_url -}}"},{"line_number":30,"context_line":"{{- tuple \"ord\" \"public\" \"api\" . | include \"helm-toolkit.endpoints.keystone_endpoint_uri_lookup\" | trimSuffix .Values.endpoints.ranger_agent.path.default | set .Values.conf.ranger_agent.DEFAULT \"ord_server_url\" | quote | trunc 0 -}}"},{"line_number":31,"context_line":"{{- end -}}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{{- if empty .Values.conf.ranger_agent.keystone_authtoken.username -}}"},{"line_number":34,"context_line":"{{- set .Values.conf.ranger_agent.keystone_authtoken \"username\" .Values.endpoints.identity.auth.ord_stack_user.username | quote | trunc 0 -}}"},{"line_number":35,"context_line":"{{- end -}}"},{"line_number":36,"context_line":"{{- if empty .Values.conf.ranger_agent.keystone_authtoken.password -}}"},{"line_number":37,"context_line":"{{- set .Values.conf.ranger_agent.keystone_authtoken \"password\" .Values.endpoints.identity.auth.ord_stack_user.password | quote | trunc 0 -}}"},{"line_number":38,"context_line":"{{- end -}}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"---"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa0c359_de1de10f","line":38,"range":{"start_line":32,"start_character":0,"end_line":38,"end_character":11},"in_reply_to":"3fa0c359_bbafc7e1","updated":"2018-02-07 22:11:13.000000000","message":"will fix ord configuration, token is not cached so no Memcached needed, domain for ord and orm will always be default","commit_id":"6dd3b1f9e040523fe6cba08d4e315137217efb95"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"2e30b82f6044676753764717dc88bdc1fed9af78","unresolved":false,"context_lines":[{"line_number":37,"context_line":"{{- set .Values.conf.ranger_agent.keystone_authtoken \"password\" .Values.endpoints.identity.auth.ord_stack_user.password | quote | trunc 0 -}}"},{"line_number":38,"context_line":"{{- end -}}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"---"},{"line_number":42,"context_line":"apiVersion: v1"},{"line_number":43,"context_line":"kind: ConfigMap"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa0c359_9b5f6b0d","line":40,"updated":"2018-02-07 21:35:28.000000000","message":"extra ws","commit_id":"6dd3b1f9e040523fe6cba08d4e315137217efb95"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"2e30b82f6044676753764717dc88bdc1fed9af78","unresolved":false,"context_lines":[{"line_number":42,"context_line":"apiVersion: v1"},{"line_number":43,"context_line":"kind: ConfigMap"},{"line_number":44,"context_line":"metadata:"},{"line_number":45,"context_line":"  name: ord-etc"},{"line_number":46,"context_line":"data:"},{"line_number":47,"context_line":"  api-paste.ini: |+"},{"line_number":48,"context_line":"{{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.paste | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa0c359_db65f3e2","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":11},"updated":"2018-02-07 21:35:28.000000000","message":"ranger-agent","commit_id":"6dd3b1f9e040523fe6cba08d4e315137217efb95"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"608e436d2862a00ac5f54c4a8eecd5f3e0ee960d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  name: ranger-agent-etc"},{"line_number":56,"context_line":"data:"},{"line_number":57,"context_line":"  api-paste.ini: |+"},{"line_number":58,"context_line":"{{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.paste | indent 4 }}"},{"line_number":59,"context_line":"  ranger-agent.conf: |+"},{"line_number":60,"context_line":"{{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.ranger_agent | indent 4 }}"},{"line_number":61,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ff6b8bd7_c4531fe2","line":58,"range":{"start_line":58,"start_character":31,"end_line":58,"end_character":43},"updated":"2018-03-05 14:53:21.000000000","message":"Needs to use the to_ini function.\n\nhttps://github.com/openstack/openstack-helm/blob/master/keystone/templates/configmap-etc.yaml#L43","commit_id":"98c30429aafa1c0db61f9f14d15e16ba04949198"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a616bc0d023d57f49df6d4049861a40bb9f12a92","unresolved":false,"context_lines":[{"line_number":57,"context_line":"metadata:"},{"line_number":58,"context_line":"  name: ranger-agent-etc"},{"line_number":59,"context_line":"data:"},{"line_number":60,"context_line":"  rally_tests.yaml: |+"},{"line_number":61,"context_line":"{{ toYaml .Values.conf.rally_tests.tests | indent 4 }}"},{"line_number":62,"context_line":"  api-paste.ini: |+"},{"line_number":63,"context_line":"{{ include \"helm-toolkit.utils.to_ini\" .Values.conf.paste | indent 4 }}"},{"line_number":64,"context_line":"  ranger-agent.conf: |+"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"df7087c5_2fa59d47","line":61,"range":{"start_line":60,"start_character":0,"end_line":61,"end_character":54},"updated":"2018-03-22 14:01:21.000000000","message":"Can be removed","commit_id":"f0c4f8517f0c7ab55acef8fd1b065a3274c4ef8a"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6eb3b2f34c46b0907fe0de349b647a289fbf8c4b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"metadata:"},{"line_number":61,"context_line":"  name: ranger-agent-etc"},{"line_number":62,"context_line":"data:"},{"line_number":63,"context_line":"  api-paste.ini: |+"},{"line_number":64,"context_line":"{{ include \"helm-toolkit.utils.to_ini\" .Values.conf.paste | indent 4 }}"},{"line_number":65,"context_line":"  ranger-agent.conf: |+"},{"line_number":66,"context_line":"{{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.ranger_agent | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"bf659307_2632c311","line":63,"range":{"start_line":63,"start_character":18,"end_line":63,"end_character":19},"updated":"2018-03-28 06:01:33.000000000","message":"not required","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6eb3b2f34c46b0907fe0de349b647a289fbf8c4b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"data:"},{"line_number":63,"context_line":"  api-paste.ini: |+"},{"line_number":64,"context_line":"{{ include \"helm-toolkit.utils.to_ini\" .Values.conf.paste | indent 4 }}"},{"line_number":65,"context_line":"  ranger-agent.conf: |+"},{"line_number":66,"context_line":"{{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.ranger_agent | indent 4 }}"},{"line_number":67,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"bf659307_463577f6","line":65,"range":{"start_line":65,"start_character":22,"end_line":65,"end_character":23},"updated":"2018-03-28 06:01:33.000000000","message":"not required","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"}],"ranger-agent/templates/deployment-ranger-agent-api.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"68c01da1e1975894a7be08440258b242aa2a31a6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"{{- $mounts_ranger_agent_api_init :\u003d .Values.pod.mounts.ranger_agent_api.init_container }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{{- $serviceAccountName :\u003d \"ranger-agent-api\" }}"},{"line_number":25,"context_line":"{{ tuple $envAll $dependencies $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":26,"context_line":"---"},{"line_number":27,"context_line":"apiVersion: apps/v1beta1"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f93b717_e1bd7ed8","line":24,"range":{"start_line":24,"start_character":28,"end_line":24,"end_character":44},"updated":"2018-01-30 05:31:00.000000000","message":"this should match the metadata name","commit_id":"d8a69515d45b4d4cdffcf9b51f0af6ae8f20fef3"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"608e436d2862a00ac5f54c4a8eecd5f3e0ee960d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                  - /tmp/ranger-agent-api.sh"},{"line_number":67,"context_line":"                  - stop"},{"line_number":68,"context_line":"          ports:"},{"line_number":69,"context_line":"            - containerPort: {{ .Values.network.api.port }}"},{"line_number":70,"context_line":"          readinessProbe:"},{"line_number":71,"context_line":"            tcpSocket:"},{"line_number":72,"context_line":"              port: {{ .Values.network.api.port }}"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ff6b8bd7_241e9b0c","line":69,"range":{"start_line":69,"start_character":29,"end_line":69,"end_character":59},"updated":"2018-03-05 14:53:21.000000000","message":"Needs to be handled with the port lookup functions","commit_id":"98c30429aafa1c0db61f9f14d15e16ba04949198"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"608e436d2862a00ac5f54c4a8eecd5f3e0ee960d","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            - containerPort: {{ .Values.network.api.port }}"},{"line_number":70,"context_line":"          readinessProbe:"},{"line_number":71,"context_line":"            tcpSocket:"},{"line_number":72,"context_line":"              port: {{ .Values.network.api.port }}"},{"line_number":73,"context_line":"          volumeMounts:"},{"line_number":74,"context_line":"            - name: ranger-agent-bin"},{"line_number":75,"context_line":"              mountPath: /tmp/ranger-agent-api.sh"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ff6b8bd7_c41a3f16","line":72,"range":{"start_line":72,"start_character":20,"end_line":72,"end_character":50},"updated":"2018-03-05 14:53:21.000000000","message":"Needs to be handled with the port lookup functions","commit_id":"98c30429aafa1c0db61f9f14d15e16ba04949198"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"99dad24eea21adfa5feec75942b3fd5289ad0251","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":41,"context_line":"    spec:"},{"line_number":42,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":43,"context_line":"      dnsPolicy: ClusterFirstWithHostNet"},{"line_number":44,"context_line":"      hostNetwork: true"},{"line_number":45,"context_line":"      affinity:"},{"line_number":46,"context_line":"{{ tuple $envAll \"ranger-agent\" \"api\" | include \"helm-toolkit.snippets.kubernetes_pod_anti_affinity\" | indent 8 }}"},{"line_number":47,"context_line":"      nodeSelector:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"df7087c5_c7c23cea","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":23},"updated":"2018-03-07 14:18:12.000000000","message":"Is this required for the ranger-agent api?","commit_id":"d3ab54a79d41a30a0fc8e3f7387024bd1cc07dd0"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"0562de2bc5e786125d0e52b60d06e2d6bb77dcbc","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":41,"context_line":"    spec:"},{"line_number":42,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":43,"context_line":"      dnsPolicy: ClusterFirstWithHostNet"},{"line_number":44,"context_line":"      hostNetwork: true"},{"line_number":45,"context_line":"      affinity:"},{"line_number":46,"context_line":"{{ tuple $envAll \"ranger-agent\" \"api\" | include \"helm-toolkit.snippets.kubernetes_pod_anti_affinity\" | indent 8 }}"},{"line_number":47,"context_line":"      nodeSelector:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"df7087c5_5b0da58e","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":23},"in_reply_to":"df7087c5_c7c23cea","updated":"2018-03-07 16:24:32.000000000","message":"Yes it is making Ranger call back for status update so it needed to communicate with external API","commit_id":"d3ab54a79d41a30a0fc8e3f7387024bd1cc07dd0"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a616bc0d023d57f49df6d4049861a40bb9f12a92","unresolved":false,"context_lines":[{"line_number":29,"context_line":"metadata:"},{"line_number":30,"context_line":"  name: ranger-agent-api"},{"line_number":31,"context_line":"spec:"},{"line_number":32,"context_line":"  replicas: {{ .Values.pod.replicas.ranger_agent_api }}"},{"line_number":33,"context_line":"{{ tuple $envAll | include \"helm-toolkit.snippets.kubernetes_upgrades_deployment\" | indent 2 }}"},{"line_number":34,"context_line":"  template:"},{"line_number":35,"context_line":"    metadata:"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"df7087c5_0f56992b","line":32,"range":{"start_line":32,"start_character":15,"end_line":32,"end_character":52},"updated":"2018-03-22 14:01:21.000000000","message":"Let\u0027s keep this consistent with other charts: .Values.pod.replicas.api will suffice","commit_id":"f0c4f8517f0c7ab55acef8fd1b065a3274c4ef8a"}],"ranger-agent/templates/deployment-ranger-agent-engine.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"68c01da1e1975894a7be08440258b242aa2a31a6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"apiVersion: apps/v1beta1"},{"line_number":27,"context_line":"kind: Deployment"},{"line_number":28,"context_line":"metadata:"},{"line_number":29,"context_line":"  name: engine"},{"line_number":30,"context_line":"spec:"},{"line_number":31,"context_line":"  replicas: {{ .Values.pod.replicas.ranger_agent_engine }}"},{"line_number":32,"context_line":"{{ tuple $envAll | include \"helm-toolkit.snippets.kubernetes_upgrades_deployment\" | indent 2 }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f93b717_21c7e666","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":14},"updated":"2018-01-30 05:31:00.000000000","message":"this should be \"ranger-agent-engine\"","commit_id":"d8a69515d45b4d4cdffcf9b51f0af6ae8f20fef3"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a616bc0d023d57f49df6d4049861a40bb9f12a92","unresolved":false,"context_lines":[{"line_number":28,"context_line":"metadata:"},{"line_number":29,"context_line":"  name: ranger-agent-engine"},{"line_number":30,"context_line":"spec:"},{"line_number":31,"context_line":"  replicas: {{ .Values.pod.replicas.ranger_agent_engine }}"},{"line_number":32,"context_line":"{{ tuple $envAll | include \"helm-toolkit.snippets.kubernetes_upgrades_deployment\" | indent 2 }}"},{"line_number":33,"context_line":"  template:"},{"line_number":34,"context_line":"    metadata:"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"df7087c5_f2046e17","line":31,"range":{"start_line":31,"start_character":36,"end_line":31,"end_character":55},"updated":"2018-03-22 14:01:21.000000000","message":"engine will suffice here","commit_id":"f0c4f8517f0c7ab55acef8fd1b065a3274c4ef8a"}],"ranger-agent/templates/etc/_ranger_agent_sudoers.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"73cb769355d2a50846678c435924f2a96b03b0d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5f93b717_64c72e66","updated":"2018-01-30 15:56:07.000000000","message":"required?","commit_id":"d8a69515d45b4d4cdffcf9b51f0af6ae8f20fef3"}],"ranger-agent/templates/etc/_ssh-config.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"73cb769355d2a50846678c435924f2a96b03b0d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5f93b717_84c4ba60","updated":"2018-01-30 15:56:07.000000000","message":"required?","commit_id":"d8a69515d45b4d4cdffcf9b51f0af6ae8f20fef3"}],"ranger-agent/templates/ingress-ranger-agent-api.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"608e436d2862a00ac5f54c4a8eecd5f3e0ee960d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."},{"line_number":6,"context_line":"You may obtain a copy of the License at"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"   http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Unless required by applicable law or agreed to in writing, software"},{"line_number":11,"context_line":"distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":12,"context_line":"WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":"See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.ingress_ranger_agent_api }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"{{- if .Values.network.api.ingress.public }}"},{"line_number":20,"context_line":"{{- $backendServiceType :\u003d \"ranger-agent\" }}"},{"line_number":21,"context_line":"{{- $backendPort :\u003d \"ranger-api\" }}"},{"line_number":22,"context_line":"{{- $ingressName :\u003d tuple $backendServiceType \"public\" $envAll | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":23,"context_line":"{{- $backendName :\u003d tuple $backendServiceType \"internal\" $envAll | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":24,"context_line":"{{- $hostName :\u003d tuple $backendServiceType \"public\" $envAll | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":25,"context_line":"{{- $hostNameNamespaced :\u003d tuple $backendServiceType \"public\" $envAll | include \"helm-toolkit.endpoints.hostname_namespaced_endpoint_lookup\" }}"},{"line_number":26,"context_line":"{{- $hostNameFull :\u003d tuple $backendServiceType \"public\" $envAll | include \"helm-toolkit.endpoints.hostname_fqdn_endpoint_lookup\" }}"},{"line_number":27,"context_line":"---"},{"line_number":28,"context_line":"apiVersion: extensions/v1beta1"},{"line_number":29,"context_line":"kind: Ingress"},{"line_number":30,"context_line":"metadata:"},{"line_number":31,"context_line":"  name: {{ $ingressName }}"},{"line_number":32,"context_line":"  annotations:"},{"line_number":33,"context_line":"{{ toJson .Values.network.api.ingress.annotations | indent 4 }}"},{"line_number":34,"context_line":"spec:"},{"line_number":35,"context_line":"  rules:"},{"line_number":36,"context_line":"{{ if ne $hostNameNamespaced $hostNameFull }}"},{"line_number":37,"context_line":"{{- range $key1, $vHost :\u003d tuple $hostName $hostNameNamespaced $hostNameFull }}"},{"line_number":38,"context_line":"  - host: {{ $vHost }}"},{"line_number":39,"context_line":"    http:"},{"line_number":40,"context_line":"      paths:"},{"line_number":41,"context_line":"      - path: /"},{"line_number":42,"context_line":"        backend:"},{"line_number":43,"context_line":"          serviceName: {{ $backendName }}"},{"line_number":44,"context_line":"          servicePort: {{ $backendPort }}"},{"line_number":45,"context_line":"{{- end }}"},{"line_number":46,"context_line":"{{- else }}"},{"line_number":47,"context_line":"{{- range $key1, $vHost :\u003d tuple $hostName $hostNameNamespaced }}"},{"line_number":48,"context_line":"  - host: {{ $vHost }}"},{"line_number":49,"context_line":"    http:"},{"line_number":50,"context_line":"      paths:"},{"line_number":51,"context_line":"      - path: /"},{"line_number":52,"context_line":"        backend:"},{"line_number":53,"context_line":"          serviceName: {{ $backendName }}"},{"line_number":54,"context_line":"          servicePort: {{ $backendPort }}"},{"line_number":55,"context_line":"{{- end }}"},{"line_number":56,"context_line":"{{- end }}"},{"line_number":57,"context_line":"{{- end }}"},{"line_number":58,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ff6b8bd7_645ed3e7","line":58,"range":{"start_line":1,"start_character":0,"end_line":58,"end_character":10},"updated":"2018-03-05 14:53:21.000000000","message":"This is handled via templates in helm-toolkit: https://github.com/openstack/openstack-helm/blob/master/keystone/templates/ingress-api.yaml","commit_id":"98c30429aafa1c0db61f9f14d15e16ba04949198"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"372469f9ad89d3579ff7d9d7102f18f253118a27","unresolved":false,"context_lines":[{"line_number":12,"context_line":"WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":"See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":"{{- if and .Values.manifests.ingress_ranger_agent_api .Values.network.api.ingress.public }}"},{"line_number":17,"context_line":"{{- $ingressOpts :\u003d dict \"envAll\" . \"backendServiceType\" \"ranger-agent\" \"backendPort\" \"ranger-api\" -}}"},{"line_number":18,"context_line":"{{ $ingressOpts | include \"helm-toolkit.manifests.ingress\" }}"},{"line_number":19,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"bf659307_614a1356","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":91},"updated":"2018-03-26 21:39:01.000000000","message":"Can we place a newline between these two?","commit_id":"fea8db7f4c96b1c602ef73d7249f1c3ced7239fd"}],"ranger-agent/templates/job-db-drop.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"99dad24eea21adfa5feec75942b3fd5289ad0251","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      nodeSelector:"},{"line_number":41,"context_line":"        {{ .Values.labels.job.node_selector_key }}: {{ .Values.labels.job.node_selector_value }}"},{"line_number":42,"context_line":"      initContainers:"},{"line_number":43,"context_line":"{{ tuple $envAll $dependencies \"[]\" | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":44,"context_line":"      containers:"},{"line_number":45,"context_line":"        - name: ranger-agent-db-drop"},{"line_number":46,"context_line":"          image: {{ .Values.images.tags.db_drop }}"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"df7087c5_475cec4a","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":120},"updated":"2018-03-07 14:18:12.000000000","message":"This line should match the other services: https://github.com/openstack/openstack-helm/blob/master/keystone/templates/job-db-drop.yaml#L47","commit_id":"d3ab54a79d41a30a0fc8e3f7387024bd1cc07dd0"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"0562de2bc5e786125d0e52b60d06e2d6bb77dcbc","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      nodeSelector:"},{"line_number":41,"context_line":"        {{ .Values.labels.job.node_selector_key }}: {{ .Values.labels.job.node_selector_value }}"},{"line_number":42,"context_line":"      initContainers:"},{"line_number":43,"context_line":"{{ tuple $envAll $dependencies \"[]\" | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":44,"context_line":"      containers:"},{"line_number":45,"context_line":"        - name: ranger-agent-db-drop"},{"line_number":46,"context_line":"          image: {{ .Values.images.tags.db_drop }}"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"df7087c5_9b61fd3c","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":120},"in_reply_to":"df7087c5_475cec4a","updated":"2018-03-07 16:24:32.000000000","message":"I will fix it","commit_id":"d3ab54a79d41a30a0fc8e3f7387024bd1cc07dd0"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a616bc0d023d57f49df6d4049861a40bb9f12a92","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."},{"line_number":6,"context_line":"You may obtain a copy of the License at"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"   http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Unless required by applicable law or agreed to in writing, software"},{"line_number":11,"context_line":"distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":12,"context_line":"WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":"See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.job_db_drop }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"{{- $dependencies :\u003d .Values.dependencies.db_drop }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{- $serviceAccountName :\u003d \"ranger-agent-db-drop\" }}"},{"line_number":22,"context_line":"{{ tuple $envAll $dependencies $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"---"},{"line_number":25,"context_line":"apiVersion: batch/v1"},{"line_number":26,"context_line":"kind: Job"},{"line_number":27,"context_line":"metadata:"},{"line_number":28,"context_line":"  name: ranger-agent-db-drop-{{ randAlphaNum 5 | lower }}"},{"line_number":29,"context_line":"  annotations:"},{"line_number":30,"context_line":"    \"helm.sh/hook\": pre-delete"},{"line_number":31,"context_line":"    \"helm.sh/hook-delete-policy\": hook-succeeded"},{"line_number":32,"context_line":"spec:"},{"line_number":33,"context_line":"  template:"},{"line_number":34,"context_line":"    metadata:"},{"line_number":35,"context_line":"      labels:"},{"line_number":36,"context_line":"{{ tuple $envAll \"ranger-agent\" \"db-drop\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":37,"context_line":"    spec:"},{"line_number":38,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":39,"context_line":"      restartPolicy: OnFailure"},{"line_number":40,"context_line":"      nodeSelector:"},{"line_number":41,"context_line":"        {{ .Values.labels.job.node_selector_key }}: {{ .Values.labels.job.node_selector_value }}"},{"line_number":42,"context_line":"      initContainers:"},{"line_number":43,"context_line":"{{ tuple $envAll $dependencies list | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":44,"context_line":"      containers:"},{"line_number":45,"context_line":"        - name: ranger-agent-db-drop"},{"line_number":46,"context_line":"          image: {{ .Values.images.tags.db_drop }}"},{"line_number":47,"context_line":"          imagePullPolicy: {{ .Values.images.pull_policy }}"},{"line_number":48,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.jobs.db_drop | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":49,"context_line":"          env:"},{"line_number":50,"context_line":"            - name: ROOT_DB_CONNECTION"},{"line_number":51,"context_line":"              valueFrom:"},{"line_number":52,"context_line":"                secretKeyRef:"},{"line_number":53,"context_line":"                  name: {{ .Values.secrets.oslo_db.admin }}"},{"line_number":54,"context_line":"                  key: DB_CONNECTION"},{"line_number":55,"context_line":"            - name: OPENSTACK_CONFIG_FILE"},{"line_number":56,"context_line":"              value: /etc/ranger-agent/ranger-agent.conf"},{"line_number":57,"context_line":"            - name: OPENSTACK_CONFIG_DB_SECTION"},{"line_number":58,"context_line":"              value: database"},{"line_number":59,"context_line":"            - name: OPENSTACK_CONFIG_DB_KEY"},{"line_number":60,"context_line":"              value: connection"},{"line_number":61,"context_line":"          command:"},{"line_number":62,"context_line":"            - /tmp/db-drop.py"},{"line_number":63,"context_line":"          volumeMounts:"},{"line_number":64,"context_line":"            - name: ranger-agent-bin"},{"line_number":65,"context_line":"              mountPath: /tmp/db-drop.py"},{"line_number":66,"context_line":"              subPath: db-drop.py"},{"line_number":67,"context_line":"              readOnly: true"},{"line_number":68,"context_line":"            - name: etcrangeragent"},{"line_number":69,"context_line":"              mountPath: /etc/ranger-agent"},{"line_number":70,"context_line":"            - name: ranger-agent-etc"},{"line_number":71,"context_line":"              mountPath: /etc/ranger-agent/ranger-agent.conf"},{"line_number":72,"context_line":"              subPath: ranger-agent.conf"},{"line_number":73,"context_line":"              readOnly: true"},{"line_number":74,"context_line":"        - name: ranger-agent-db-drop-api"},{"line_number":75,"context_line":"          image: {{ .Values.images.tags.db_drop }}"},{"line_number":76,"context_line":"          imagePullPolicy: {{ .Values.images.pull_policy }}"},{"line_number":77,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.jobs.db_drop | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":78,"context_line":"          env:"},{"line_number":79,"context_line":"            - name: ROOT_DB_CONNECTION"},{"line_number":80,"context_line":"              valueFrom:"},{"line_number":81,"context_line":"                secretKeyRef:"},{"line_number":82,"context_line":"                  name: {{ .Values.secrets.oslo_db.admin }}"},{"line_number":83,"context_line":"                  key: DB_CONNECTION"},{"line_number":84,"context_line":"            - name: OPENSTACK_CONFIG_FILE"},{"line_number":85,"context_line":"              value: /etc/ranger-agent/ranger-agent.conf"},{"line_number":86,"context_line":"            - name: OPENSTACK_CONFIG_DB_SECTION"},{"line_number":87,"context_line":"              value: api_database"},{"line_number":88,"context_line":"            - name: OPENSTACK_CONFIG_DB_KEY"},{"line_number":89,"context_line":"              value: connection"},{"line_number":90,"context_line":"          command:"},{"line_number":91,"context_line":"            - /tmp/db-drop.py"},{"line_number":92,"context_line":"          volumeMounts:"},{"line_number":93,"context_line":"            - name: ranger-agent-bin"},{"line_number":94,"context_line":"              mountPath: /tmp/db-drop.py"},{"line_number":95,"context_line":"              subPath: db-drop.py"},{"line_number":96,"context_line":"              readOnly: true"},{"line_number":97,"context_line":"            - name: etcrangeragent"},{"line_number":98,"context_line":"              mountPath: /etc/ranger-agent"},{"line_number":99,"context_line":"            - name: ranger-agent-etc"},{"line_number":100,"context_line":"              mountPath: /etc/ranger-agent/ranger-agent.conf"},{"line_number":101,"context_line":"              subPath: ranger-agent.conf"},{"line_number":102,"context_line":"              readOnly: true"},{"line_number":103,"context_line":"      volumes:"},{"line_number":104,"context_line":"        - name: etcrangeragent"},{"line_number":105,"context_line":"          emptyDir: {}"},{"line_number":106,"context_line":"        - name: ranger-agent-etc"},{"line_number":107,"context_line":"          configMap:"},{"line_number":108,"context_line":"            name: ranger-agent-etc"},{"line_number":109,"context_line":"            defaultMode: 0444"},{"line_number":110,"context_line":"        - name: ranger-agent-bin"},{"line_number":111,"context_line":"          configMap:"},{"line_number":112,"context_line":"            name: ranger-agent-bin"},{"line_number":113,"context_line":"            defaultMode: 0555"},{"line_number":114,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"df7087c5_52743a68","line":114,"range":{"start_line":1,"start_character":0,"end_line":114,"end_character":10},"updated":"2018-03-22 14:01:21.000000000","message":"This should be handled similar to the other db-drop jobs in openstack-helm: https://github.com/openstack/openstack-helm/blob/master/keystone/templates/job-db-drop.yaml","commit_id":"f0c4f8517f0c7ab55acef8fd1b065a3274c4ef8a"}],"ranger-agent/templates/job-db-init.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"7ee5a81785f93a58d008fe98bf2574d9f9bb74bf","unresolved":false,"context_lines":[{"line_number":69,"context_line":"              subPath: ord.conf"},{"line_number":70,"context_line":"              readOnly: true"},{"line_number":71,"context_line":"      volumes:"},{"line_number":72,"context_line":"        - name: etcord "},{"line_number":73,"context_line":"          emptyDir: {}"},{"line_number":74,"context_line":"        - name: ord-etc"},{"line_number":75,"context_line":"          configMap:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f93b717_1fb9ec2c","line":72,"updated":"2018-01-29 22:00:28.000000000","message":"trailing ws (causes linter job to fail)","commit_id":"a69f60109f974802e544b7ee9fe1748a508b2092"},{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"8ce19d2e672dc456adae8ab0ce99783ccb982de2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.job_db_init }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"{{- $dependencies :\u003d .Values.dependencies.db_init }}"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1f9dbf25_4eff3667","line":16,"updated":"2018-02-27 23:42:09.000000000","message":"Recently, we changed db-init manifest to use templates stored in helm-toolkit. Please review recently changes to db-init manifest in master and make needed changes.","commit_id":"78706e00a433ee20866e4c81156f1f2462ee9917"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d50895e864e24987b7914d6549ae8fcd1d8b38e2","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.job_db_init }}"},{"line_number":18,"context_line":"{{- $dbInitJob :\u003d dict \"envAll\" . \"serviceName\" \"ranger-agent\" -}}"},{"line_number":19,"context_line":"{{ $dbInitJob | include \"helm-toolkit.manifests.job_db_init_mysql\" }}"},{"line_number":20,"context_line":"{{- end }}"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1f9dbf25_f9457744","line":19,"range":{"start_line":19,"start_character":3,"end_line":19,"end_character":14},"updated":"2018-03-02 14:42:08.000000000","message":"you can probably place in: dict \"envAll\" . \"serviceName\" \"ranger-agent\" without a separate variable, but that may just be a preference.","commit_id":"ee6bbb9f81cb3538a75eca1e2a33626f7844ffa5"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d50895e864e24987b7914d6549ae8fcd1d8b38e2","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{- $dbInitJob :\u003d dict \"envAll\" . \"serviceName\" \"ranger-agent\" -}}"},{"line_number":19,"context_line":"{{ $dbInitJob | include \"helm-toolkit.manifests.job_db_init_mysql\" }}"},{"line_number":20,"context_line":"{{- end }}"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1f9dbf25_193ce3c6","line":21,"updated":"2018-03-02 14:42:08.000000000","message":"extra EoF line","commit_id":"ee6bbb9f81cb3538a75eca1e2a33626f7844ffa5"}],"ranger-agent/templates/job-db-sync.yaml":[{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"8ce19d2e672dc456adae8ab0ce99783ccb982de2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.job_db_sync }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"{{- $dependencies :\u003d .Values.dependencies.db_sync }}"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1f9dbf25_6e04727c","line":16,"updated":"2018-02-27 23:42:09.000000000","message":"Recently, we changed db-sync script to use templates stored in helm-toolkit. Please review recently changes to db-sync script in master and make needed changes.","commit_id":"78706e00a433ee20866e4c81156f1f2462ee9917"}],"ranger-agent/templates/job-ks-endpoints.yaml":[{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"8ce19d2e672dc456adae8ab0ce99783ccb982de2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.job_ks_endpoints }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"{{- $dependencies :\u003d .Values.dependencies.ks_endpoints }}"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1f9dbf25_2e3bca38","line":16,"updated":"2018-02-27 23:42:09.000000000","message":"Similar to what i mentioned about db-init manifest","commit_id":"78706e00a433ee20866e4c81156f1f2462ee9917"}],"ranger-agent/templates/job-ks-service.yaml":[{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"8ce19d2e672dc456adae8ab0ce99783ccb982de2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.job_ks_service }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"{{- $dependencies :\u003d .Values.dependencies.ks_service }}"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1f9dbf25_eeef22ae","line":16,"updated":"2018-02-27 23:42:09.000000000","message":"Similar to what i mentioned about db-init manifest","commit_id":"78706e00a433ee20866e4c81156f1f2462ee9917"}],"ranger-agent/templates/job-ks-user-trustee.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"4f487113620f07ea6e0e9577a40c9cb516a1716b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"df7087c5_15893074","line":1,"updated":"2018-03-08 01:47:55.000000000","message":"if the trustee user is not used, we should not create it","commit_id":"a308619e7102b1bcd51fa4b1e7ad82a6ff3cfee9"}],"ranger-agent/templates/job-ks-user.yaml":[{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"8ce19d2e672dc456adae8ab0ce99783ccb982de2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.job_ks_user }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"{{- $dependencies :\u003d .Values.dependencies.ks_user }}"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1f9dbf25_ce47c6bc","line":16,"updated":"2018-02-27 23:42:09.000000000","message":"Similar to what i mentioned about db-init manifest","commit_id":"78706e00a433ee20866e4c81156f1f2462ee9917"}],"ranger-agent/templates/pod-rally-test.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"f45418d326527af6454ccd3ee3296d80737b686c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      image: {{ .Values.images.tags.test }}"},{"line_number":65,"context_line":"      imagePullPolicy: {{ .Values.images.pull_policy }}"},{"line_number":66,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.jobs.tests | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 6 }}"},{"line_number":67,"context_line":"      env:"},{"line_number":68,"context_line":"{{- with $env :\u003d dict \"ksUserSecret\" .Values.secrets.identity.admin }}"},{"line_number":69,"context_line":"{{- include \"helm-toolkit.snippets.keystone_openrc_env_vars\" $env | indent 8 }}"},{"line_number":70,"context_line":"{{- end }}"},{"line_number":71,"context_line":"{{- with $env :\u003d dict \"ksUserSecret\" .Values.secrets.identity.test }}"},{"line_number":72,"context_line":"{{- include \"helm-toolkit.snippets.keystone_user_create_env_vars\" $env | indent 8 }}"},{"line_number":73,"context_line":"{{- end }}"},{"line_number":74,"context_line":"        - name: RALLY_ENV_NAME"},{"line_number":75,"context_line":"          value: {{.Release.Name}}"},{"line_number":76,"context_line":"      command:"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"df7087c5_bc969bef","line":73,"range":{"start_line":67,"start_character":0,"end_line":73,"end_character":10},"updated":"2018-03-14 13:16:28.000000000","message":"The env variables being used here are causing the gates to fail: please see http://logs.openstack.org/41/538341/26/check/openstack-helm-multinode-ubuntu/af88fb0/job-output.txt.gz#_2018-03-13_19_27_17_594608\n\nYou\u0027re referencing an entry in values that doesn\u0027t exist.  You\u0027ll need to add entries for creating the test user in the endpoints.identity.auth section, similar to the other charts.","commit_id":"609018755c5c062f85d2c599a920521c7623a5a7"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a616bc0d023d57f49df6d4049861a40bb9f12a92","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."},{"line_number":6,"context_line":"You may obtain a copy of the License at"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"   http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Unless required by applicable law or agreed to in writing, software"},{"line_number":11,"context_line":"distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":12,"context_line":"WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":"See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.pod_rally_test }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"{{- $dependencies :\u003d .Values.dependencies.static.tests }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{- $mounts_tests :\u003d .Values.pod.mounts.ranger_agent_tests.ranger_agent_tests }}"},{"line_number":22,"context_line":"{{- $mounts_tests_init :\u003d .Values.pod.mounts.ranger_agent_tests.init_container }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{{- $serviceAccountName :\u003d print $envAll.Release.Name \"-test\" }}"},{"line_number":25,"context_line":"{{ tuple $envAll $dependencies $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":26,"context_line":"---"},{"line_number":27,"context_line":"apiVersion: v1"},{"line_number":28,"context_line":"kind: Pod"},{"line_number":29,"context_line":"metadata:"},{"line_number":30,"context_line":"  name: {{ print $envAll.Release.Name \"-test\" }}"},{"line_number":31,"context_line":"  annotations:"},{"line_number":32,"context_line":"    \"helm.sh/hook\": test-success"},{"line_number":33,"context_line":"spec:"},{"line_number":34,"context_line":"  nodeSelector:"},{"line_number":35,"context_line":"    {{ .Values.labels.test.node_selector_key }}: {{ .Values.labels.test.node_selector_value }}"},{"line_number":36,"context_line":"  restartPolicy: Never"},{"line_number":37,"context_line":"  serviceAccountName: {{ $serviceAccountName }}"},{"line_number":38,"context_line":"  initContainers:"},{"line_number":39,"context_line":"{{ tuple $envAll $dependencies $mounts_tests_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 4 }}"},{"line_number":40,"context_line":"    - name: {{ .Release.Name }}-test-ks-user"},{"line_number":41,"context_line":"      image: {{ .Values.images.tags.ks_user }}"},{"line_number":42,"context_line":"      imagePullPolicy: {{ .Values.images.pull_policy }}"},{"line_number":43,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.jobs.ks_user | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 6 }}"},{"line_number":44,"context_line":"      command:"},{"line_number":45,"context_line":"        - /tmp/ks-user.sh"},{"line_number":46,"context_line":"      volumeMounts:"},{"line_number":47,"context_line":"        - name: ranger-agent-bin"},{"line_number":48,"context_line":"          mountPath: /tmp/ks-user.sh"},{"line_number":49,"context_line":"          subPath: ks-user.sh"},{"line_number":50,"context_line":"          readOnly: true"},{"line_number":51,"context_line":"      env:"},{"line_number":52,"context_line":"{{- with $env :\u003d dict \"ksUserSecret\" .Values.secrets.identity.admin }}"},{"line_number":53,"context_line":"{{- include \"helm-toolkit.snippets.keystone_openrc_env_vars\" $env | indent 8 }}"},{"line_number":54,"context_line":"{{- end }}"},{"line_number":55,"context_line":"        - name: SERVICE_OS_SERVICE_NAME"},{"line_number":56,"context_line":"          value: \"test\""},{"line_number":57,"context_line":"{{- with $env :\u003d dict \"ksUserSecret\" .Values.secrets.identity.test }}"},{"line_number":58,"context_line":"{{- include \"helm-toolkit.snippets.keystone_user_create_env_vars\" $env | indent 8 }}"},{"line_number":59,"context_line":"{{- end }}"},{"line_number":60,"context_line":"        - name: SERVICE_OS_ROLE"},{"line_number":61,"context_line":"          value: {{ .Values.endpoints.identity.auth.test.role | quote }}"},{"line_number":62,"context_line":"  containers:"},{"line_number":63,"context_line":"    - name: {{ .Release.Name }}-test"},{"line_number":64,"context_line":"      image: {{ .Values.images.tags.test }}"},{"line_number":65,"context_line":"      imagePullPolicy: {{ .Values.images.pull_policy }}"},{"line_number":66,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.jobs.tests | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 6 }}"},{"line_number":67,"context_line":"      env:"},{"line_number":68,"context_line":"{{- with $env :\u003d dict \"ksUserSecret\" .Values.secrets.identity.admin }}"},{"line_number":69,"context_line":"{{- include \"helm-toolkit.snippets.keystone_openrc_env_vars\" $env | indent 8 }}"},{"line_number":70,"context_line":"{{- end }}"},{"line_number":71,"context_line":"{{- with $env :\u003d dict \"ksUserSecret\" .Values.secrets.identity.test }}"},{"line_number":72,"context_line":"{{- include \"helm-toolkit.snippets.keystone_user_create_env_vars\" $env | indent 8 }}"},{"line_number":73,"context_line":"{{- end }}"},{"line_number":74,"context_line":"        - name: RALLY_ENV_NAME"},{"line_number":75,"context_line":"          value: {{.Release.Name}}"},{"line_number":76,"context_line":"      command:"},{"line_number":77,"context_line":"        - /tmp/rally-test.sh"},{"line_number":78,"context_line":"      volumeMounts:"},{"line_number":79,"context_line":"        - name: ranger-agent-etc"},{"line_number":80,"context_line":"          mountPath: /etc/rally/rally_tests.yaml"},{"line_number":81,"context_line":"          subPath: rally_tests.yaml"},{"line_number":82,"context_line":"          readOnly: true"},{"line_number":83,"context_line":"        - name: ranger-agent-bin"},{"line_number":84,"context_line":"          mountPath: /tmp/rally-test.sh"},{"line_number":85,"context_line":"          subPath: rally-test.sh"},{"line_number":86,"context_line":"          readOnly: true"},{"line_number":87,"context_line":"        - name: rally-db"},{"line_number":88,"context_line":"          mountPath: /var/lib/rally"},{"line_number":89,"context_line":"{{ if $mounts_tests.volumeMounts }}{{ toYaml $mounts_tests.volumeMounts | indent 8 }}{{ end }}"},{"line_number":90,"context_line":"  volumes:"},{"line_number":91,"context_line":"    - name: ranger-agent-etc"},{"line_number":92,"context_line":"      configMap:"},{"line_number":93,"context_line":"        name: ranger-agent-etc"},{"line_number":94,"context_line":"        defaultMode: 0444"},{"line_number":95,"context_line":"    - name: ranger-agent-bin"},{"line_number":96,"context_line":"      configMap:"},{"line_number":97,"context_line":"        name: ranger-agent-bin"},{"line_number":98,"context_line":"        defaultMode: 0555"},{"line_number":99,"context_line":"    - name: rally-db"},{"line_number":100,"context_line":"      emptyDir: {}"},{"line_number":101,"context_line":"{{ if $mounts_tests.volumes }}{{ toYaml $mounts_tests.volumes | indent 4 }}{{ end }}"},{"line_number":102,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"df7087c5_32fc26b4","line":102,"range":{"start_line":1,"start_character":0,"end_line":102,"end_character":10},"updated":"2018-03-22 14:01:21.000000000","message":"Assuming this can be removed, as rally isnt being used for testing","commit_id":"f0c4f8517f0c7ab55acef8fd1b065a3274c4ef8a"}],"ranger-agent/templates/secret-keystone.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"2e30b82f6044676753764717dc88bdc1fed9af78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3fa0c359_7b929fa0","updated":"2018-02-07 21:35:28.000000000","message":"this looks lifted straight from heat - are all these users used?","commit_id":"6dd3b1f9e040523fe6cba08d4e315137217efb95"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"2e30b82f6044676753764717dc88bdc1fed9af78","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.secret_keystone }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"{{- range $key1, $userClass :\u003d tuple \"admin\" \"ord\" \"ord_trustee\" }}"},{"line_number":20,"context_line":"{{- $secretName :\u003d index $envAll.Values.secrets.identity $userClass }}"},{"line_number":21,"context_line":"---"},{"line_number":22,"context_line":"apiVersion: v1"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa0c359_bb9827c0","line":19,"range":{"start_line":19,"start_character":46,"end_line":19,"end_character":49},"updated":"2018-02-07 21:35:28.000000000","message":"ranger_agent","commit_id":"6dd3b1f9e040523fe6cba08d4e315137217efb95"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"34600fdb4911e243cd69044db21ec2689d87dee3","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.secret_keystone }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"{{- range $key1, $userClass :\u003d tuple \"admin\" \"ord\" \"ord_trustee\" }}"},{"line_number":20,"context_line":"{{- $secretName :\u003d index $envAll.Values.secrets.identity $userClass }}"},{"line_number":21,"context_line":"---"},{"line_number":22,"context_line":"apiVersion: v1"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa0c359_7eb92d2c","line":19,"range":{"start_line":19,"start_character":46,"end_line":19,"end_character":49},"in_reply_to":"3fa0c359_bb9827c0","updated":"2018-02-07 22:11:13.000000000","message":"We have to create users for orm and still need to support for legacy system. ord_trustee is not used till now but for v3 support, I decided to create this user. \nWe will revisit user section as go along","commit_id":"6dd3b1f9e040523fe6cba08d4e315137217efb95"}],"ranger-agent/templates/secret-rabbitmq.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6eb3b2f34c46b0907fe0de349b647a289fbf8c4b","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.secret_rabbitmq }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"{{- range $key1, $userClass :\u003d tuple \"admin\" \"ranger-agent\" }}"},{"line_number":20,"context_line":"{{- $secretName :\u003d index $envAll.Values.secrets.oslo_messaging $userClass }}"},{"line_number":21,"context_line":"---"},{"line_number":22,"context_line":"apiVersion: v1"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"bf659307_a60ed338","line":19,"range":{"start_line":19,"start_character":52,"end_line":19,"end_character":53},"updated":"2018-03-28 06:01:33.000000000","message":"why `-` when `_`  is used for all other user classes?","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"9eee53537ba66e4623c2edaa7b779ca097e191cd","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.secret_rabbitmq }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"{{- range $key1, $userClass :\u003d tuple \"admin\" \"ranger-agent\" }}"},{"line_number":20,"context_line":"{{- $secretName :\u003d index $envAll.Values.secrets.oslo_messaging $userClass }}"},{"line_number":21,"context_line":"---"},{"line_number":22,"context_line":"apiVersion: v1"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"bf659307_43223a02","line":19,"range":{"start_line":19,"start_character":52,"end_line":19,"end_character":53},"in_reply_to":"bf659307_a60ed338","updated":"2018-03-28 15:54:42.000000000","message":"We wanted to use same but get error ..\n[ERROR] templates/: render error in \"ranger-agent/templates/deployment-ranger-agent-engine.yaml\": template: ranger-agent/templates/deployment-ranger-agent-engine.yaml:39:62: executing \"ranger-agent/templates/deployment-ranger-agent-engine.yaml\" at \u003cinclude \"helm-toolki...\u003e: error calling include: template: ranger-agent/charts/helm-toolkit/templates/utils/_hash.tpl:22:4: executing \"helm-toolkit.utils.hash\" at \u003cinclude $wtf $contex...\u003e: error calling include: template: ranger-agent/templates/configmap-etc.yaml:24:64: executing \"ranger-agent/templates/configmap-etc.yaml\" at \u003cinclude \"helm-toolki...\u003e: error calling include: template: ranger-agent/charts/helm-toolkit/templates/endpoints/_authenticated_endpoint_uri_lookup.tpl:38:21: executing \"helm-toolkit.endpoints.authenticated_endpoint_uri_lookup\" at \u003cindex $userMap \"user...\u003e: error calling index: index of untyped nil","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"}],"ranger-agent/templates/secret-ssh-key.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d50895e864e24987b7914d6549ae8fcd1d8b38e2","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  name: {{ $secretName }}"},{"line_number":25,"context_line":"type: Opaque"},{"line_number":26,"context_line":"data:"},{"line_number":27,"context_line":"  USER: {{ .Values.conf.ssh.user | b64enc | indent 4 }}"},{"line_number":28,"context_line":"  USER_HOME: {{ .Values.conf.ssh.user_home | b64enc | indent 4 }}"},{"line_number":29,"context_line":"  SSH_KEY_FILE: {{ .Values.conf.ssh.ssh_key_file | b64enc | indent 4 }}"},{"line_number":30,"context_line":"  RANGER_AGENT_PRIVATE_KEY: {{ .Files.Get \"cert/ranger_agent\" | b64enc }}"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1f9dbf25_d9919b9b","line":27,"range":{"start_line":27,"start_character":44,"end_line":27,"end_character":52},"updated":"2018-03-02 14:42:08.000000000","message":"do we need to indent these things?","commit_id":"ee6bbb9f81cb3538a75eca1e2a33626f7844ffa5"}],"ranger-agent/templates/service-ingress-ranger-agent-api.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a616bc0d023d57f49df6d4049861a40bb9f12a92","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."},{"line_number":6,"context_line":"You may obtain a copy of the License at"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"   http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Unless required by applicable law or agreed to in writing, software"},{"line_number":11,"context_line":"distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":12,"context_line":"WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":"See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.manifests.service_ingress_ranger_agent_api }}"},{"line_number":18,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":19,"context_line":"{{- if .Values.network.api.ingress.public }}"},{"line_number":20,"context_line":"---"},{"line_number":21,"context_line":"apiVersion: v1"},{"line_number":22,"context_line":"kind: Service"},{"line_number":23,"context_line":"metadata:"},{"line_number":24,"context_line":"  name: {{ tuple \"ranger-agent\" \"public\" . | include \"helm-toolkit.endpoints.hostname_short_endpoint_lookup\" }}"},{"line_number":25,"context_line":"spec:"},{"line_number":26,"context_line":"  ports:"},{"line_number":27,"context_line":"  - name: http"},{"line_number":28,"context_line":"    port: 80"},{"line_number":29,"context_line":"  selector:"},{"line_number":30,"context_line":"    app: ingress-api"},{"line_number":31,"context_line":"{{- end }}"},{"line_number":32,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"df7087c5_52d0ba1f","line":32,"range":{"start_line":1,"start_character":0,"end_line":32,"end_character":10},"updated":"2018-03-22 14:01:21.000000000","message":"Can be handled via helm-toolkit, like so: https://github.com/openstack/openstack-helm/blob/master/keystone/templates/service-ingress-api.yaml","commit_id":"f0c4f8517f0c7ab55acef8fd1b065a3274c4ef8a"}],"ranger-agent/templates/service-ranger-agent-api.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d50895e864e24987b7914d6549ae8fcd1d8b38e2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  ports:"},{"line_number":26,"context_line":"  - name: ranger-api"},{"line_number":27,"context_line":"    port: {{ .Values.conf.ranger_agent.api.port }}"},{"line_number":28,"context_line":"    {{ if .Values.network.api.node_port.enabled }}"},{"line_number":29,"context_line":"    nodePort: {{ .Values.network.api.node_port.port }}"},{"line_number":30,"context_line":"    {{ end }}"},{"line_number":31,"context_line":"  selector:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1f9dbf25_79f647fc","line":28,"range":{"start_line":28,"start_character":6,"end_line":28,"end_character":7},"updated":"2018-03-02 14:42:08.000000000","message":"without {{- would the rendering of these just leave a bunch of empty spaces?","commit_id":"ee6bbb9f81cb3538a75eca1e2a33626f7844ffa5"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"608e436d2862a00ac5f54c4a8eecd5f3e0ee960d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"spec:"},{"line_number":25,"context_line":"  ports:"},{"line_number":26,"context_line":"  - name: ranger-api"},{"line_number":27,"context_line":"    port: {{ .Values.conf.ranger_agent.api.port }}"},{"line_number":28,"context_line":"    {{- if .Values.network.api.node_port.enabled }}"},{"line_number":29,"context_line":"    nodePort: {{ .Values.network.api.node_port.port }}"},{"line_number":30,"context_line":"    {{ end }}"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ff6b8bd7_c401dfb1","line":27,"range":{"start_line":27,"start_character":10,"end_line":27,"end_character":50},"updated":"2018-03-05 14:53:21.000000000","message":"Needs to be handled with the port lookup functions","commit_id":"98c30429aafa1c0db61f9f14d15e16ba04949198"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"99dad24eea21adfa5feec75942b3fd5289ad0251","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  - name: ranger-api"},{"line_number":27,"context_line":"    port: {{ tuple \"ranger-agent\" \"internal\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":28,"context_line":"    {{- if .Values.network.api.node_port.enabled }}"},{"line_number":29,"context_line":"       nodePort: {{ .Values.network.api.node_port.port }}"},{"line_number":30,"context_line":"    {{ end }}"},{"line_number":31,"context_line":"  selector:"},{"line_number":32,"context_line":"{{ tuple $envAll \"ranger-agent\" \"api\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"df7087c5_c71ebc6f","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":57},"updated":"2018-03-07 14:18:12.000000000","message":"Needs to match the indent of the previous line","commit_id":"d3ab54a79d41a30a0fc8e3f7387024bd1cc07dd0"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"0562de2bc5e786125d0e52b60d06e2d6bb77dcbc","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  - name: ranger-api"},{"line_number":27,"context_line":"    port: {{ tuple \"ranger-agent\" \"internal\" \"api\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":28,"context_line":"    {{- if .Values.network.api.node_port.enabled }}"},{"line_number":29,"context_line":"       nodePort: {{ .Values.network.api.node_port.port }}"},{"line_number":30,"context_line":"    {{ end }}"},{"line_number":31,"context_line":"  selector:"},{"line_number":32,"context_line":"{{ tuple $envAll \"ranger-agent\" \"api\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"df7087c5_3bd791c2","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":57},"in_reply_to":"df7087c5_c71ebc6f","updated":"2018-03-07 16:24:32.000000000","message":"will fix it","commit_id":"d3ab54a79d41a30a0fc8e3f7387024bd1cc07dd0"}],"ranger-agent/values.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"7ee5a81785f93a58d008fe98bf2574d9f9bb74bf","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  tags:"},{"line_number":35,"context_line":"    ranger_agent: hosingh000/ranger-agent:0.1.0"},{"line_number":36,"context_line":"    test: docker.io/kolla/ubuntu-source-rally:4.0.0"},{"line_number":37,"context_line":"    db_init: docker.io/kolla/ubuntu-source-heat-engine:3.0.3 "},{"line_number":38,"context_line":"    db_sync: hosingh000/ranger-agent:0.1.0"},{"line_number":39,"context_line":"    db_drop: hosingh000/ranger-agent:0.1.0"},{"line_number":40,"context_line":"    ks_user: docker.io/kolla/ubuntu-source-heat-engine:3.0.3"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f93b717_3fb4e834","line":37,"range":{"start_line":37,"start_character":60,"end_line":37,"end_character":61},"updated":"2018-01-29 22:00:28.000000000","message":"trailing ws","commit_id":"a69f60109f974802e544b7ee9fe1748a508b2092"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"39be4a71d3290f665c908287b06de3fecbf2e909","unresolved":false,"context_lines":[{"line_number":170,"context_line":"      openstack_client_http_timeout: 360"},{"line_number":171,"context_line":"      https_insecure: False"},{"line_number":172,"context_line":"    database:"},{"line_number":173,"context_line":"      db_connection: mysql://root:password@mariadb.openstack.svc.cluster.local/ord "},{"line_number":174,"context_line":"    oslo_messaging_rabbit:"},{"line_number":175,"context_line":"      rabbit_userid: rabbitmq"},{"line_number":176,"context_line":"      rabbit_password: password"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f93b717_95287d34","line":173,"range":{"start_line":173,"start_character":82,"end_line":173,"end_character":83},"updated":"2018-01-29 23:52:14.000000000","message":"trailing ws (causing linter job to fail)\n\nsuggestion: get an editor to highlight this or better still trim it for you","commit_id":"d8a69515d45b4d4cdffcf9b51f0af6ae8f20fef3"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"39be4a71d3290f665c908287b06de3fecbf2e909","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        username: root"},{"line_number":208,"context_line":"        password: password"},{"line_number":209,"context_line":"      ord:"},{"line_number":210,"context_line":"        username: root "},{"line_number":211,"context_line":"        password: password"},{"line_number":212,"context_line":"    hosts:"},{"line_number":213,"context_line":"      default: mariadb"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f93b717_b52b392e","line":210,"range":{"start_line":210,"start_character":22,"end_line":210,"end_character":23},"updated":"2018-01-29 23:52:14.000000000","message":"ws","commit_id":"d8a69515d45b4d4cdffcf9b51f0af6ae8f20fef3"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"2e30b82f6044676753764717dc88bdc1fed9af78","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    - service: identity"},{"line_number":163,"context_line":"      endpoint: internal"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"ssh:"},{"line_number":166,"context_line":"  key_types:"},{"line_number":167,"context_line":"    - rsa"},{"line_number":168,"context_line":"    - dsa"},{"line_number":169,"context_line":"    - ecdsa"},{"line_number":170,"context_line":"    - ed25519"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"# Names of secrets used by bootstrap and environmental checks"},{"line_number":173,"context_line":"secrets:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa0c359_3bead70e","line":170,"range":{"start_line":165,"start_character":0,"end_line":170,"end_character":13},"updated":"2018-02-07 21:35:28.000000000","message":"used anywhere?","commit_id":"6dd3b1f9e040523fe6cba08d4e315137217efb95"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"34600fdb4911e243cd69044db21ec2689d87dee3","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    - service: identity"},{"line_number":163,"context_line":"      endpoint: internal"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"ssh:"},{"line_number":166,"context_line":"  key_types:"},{"line_number":167,"context_line":"    - rsa"},{"line_number":168,"context_line":"    - dsa"},{"line_number":169,"context_line":"    - ecdsa"},{"line_number":170,"context_line":"    - ed25519"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"# Names of secrets used by bootstrap and environmental checks"},{"line_number":173,"context_line":"secrets:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa0c359_fb3b0fe8","line":170,"range":{"start_line":165,"start_character":0,"end_line":170,"end_character":13},"in_reply_to":"3fa0c359_3bead70e","updated":"2018-02-07 22:11:13.000000000","message":"We have to generate ssh key for connect git repo in comming iterations , going to remove for now","commit_id":"6dd3b1f9e040523fe6cba08d4e315137217efb95"},{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"60f212bcac0fcd885dc54d5a9348ed309896d828","unresolved":false,"context_lines":[{"line_number":104,"context_line":"  script: null"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"dependencies:"},{"line_number":107,"context_line":"  api:"},{"line_number":108,"context_line":"    jobs:"},{"line_number":109,"context_line":"    - ranger-agent-db-sync"},{"line_number":110,"context_line":"    - ranger-agent-ks-user"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa0c359_8499b51f","line":107,"updated":"2018-02-26 18:02:20.000000000","message":"Missing \u0027static:\u0027. Review recent changes merged to master","commit_id":"013ed4646ca4305eaa3f07c05882cffd846f4c18"},{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"8ce19d2e672dc456adae8ab0ce99783ccb982de2","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    port:"},{"line_number":200,"context_line":"      memcache:"},{"line_number":201,"context_line":"        default: 11211"},{"line_number":202,"context_line":"  oslo_messaging:"},{"line_number":203,"context_line":"    auth:"},{"line_number":204,"context_line":"      ord:"},{"line_number":205,"context_line":"        username: rabbitmq"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1f9dbf25_ee1de2bd","line":202,"updated":"2018-02-27 23:42:09.000000000","message":"We merged a PS that adds rabbit-init job to create new rabbitmq user. Review that PS and make appropriate changes. You would have to add manifest for rabbit-init job, update values.yaml and add secrets. \nhttps://review.openstack.org/#/c/540630/","commit_id":"78706e00a433ee20866e4c81156f1f2462ee9917"},{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"8eb18228acbf99a9f3405861410b32c4123aabd0","unresolved":false,"context_lines":[{"line_number":111,"context_line":"      jobs:"},{"line_number":112,"context_line":"      - ranger-agent-db-sync"},{"line_number":113,"context_line":"      - ranger-agent-ks-user"},{"line_number":114,"context_line":"      - ranger-agent-ks-endpoints"},{"line_number":115,"context_line":"      services:"},{"line_number":116,"context_line":"      - service: oslo_messaging"},{"line_number":117,"context_line":"        endpoint: internal"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1f9dbf25_3f48c3ca","line":114,"updated":"2018-02-28 20:51:37.000000000","message":"Since API depends on oslo_messaging service, you also need to add rabbit-init job as well to jobs: list","commit_id":"03c167b9576a153e9233a6bf3e360086642defd7"},{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"8eb18228acbf99a9f3405861410b32c4123aabd0","unresolved":false,"context_lines":[{"line_number":121,"context_line":"      jobs:"},{"line_number":122,"context_line":"      - ranger-agent-db-sync"},{"line_number":123,"context_line":"      - ranger-agent-ks-user"},{"line_number":124,"context_line":"      services:"},{"line_number":125,"context_line":"      - service: oslo_messaging"},{"line_number":126,"context_line":"        endpoint: internal"},{"line_number":127,"context_line":"      - service: oslo_db"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"1f9dbf25_df12ffb1","line":124,"updated":"2018-02-28 20:51:37.000000000","message":"ditto as above","commit_id":"03c167b9576a153e9233a6bf3e360086642defd7"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"99dad24eea21adfa5feec75942b3fd5289ad0251","unresolved":false,"context_lines":[{"line_number":69,"context_line":"      resource_status_check_wait: 15"},{"line_number":70,"context_line":"    api:"},{"line_number":71,"context_line":"      host: 0.0.0.0"},{"line_number":72,"context_line":"      port: 9010"},{"line_number":73,"context_line":"    database:"},{"line_number":74,"context_line":"      max_retries: -1"},{"line_number":75,"context_line":"    oslo_messaging_notifications:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"df7087c5_071ef4b9","line":72,"updated":"2018-03-07 14:18:12.000000000","message":"Can this be handled via the etc configmap similar to other services? https://github.com/openstack/openstack-helm/blob/master/glance/templates/configmap-etc.yaml#L105-L109\n\nThis reduces the number of times a port needs to be referenced since we can drive it via endpoint lookups","commit_id":"d3ab54a79d41a30a0fc8e3f7387024bd1cc07dd0"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"99dad24eea21adfa5feec75942b3fd5289ad0251","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    ssh_key_file: ranger_agent"},{"line_number":90,"context_line":"    ssh_key_file_location: cert/ranger_agent"},{"line_number":91,"context_line":"    ssh_config_file_location: cert/config"},{"line_number":92,"context_line":"network:"},{"line_number":93,"context_line":"  api:"},{"line_number":94,"context_line":"    ingress:"},{"line_number":95,"context_line":"      public: true"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"df7087c5_07c27434","line":92,"range":{"start_line":92,"start_character":0,"end_line":92,"end_character":8},"updated":"2018-03-07 14:18:12.000000000","message":"Need a return between the above tree and the network tree","commit_id":"d3ab54a79d41a30a0fc8e3f7387024bd1cc07dd0"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"99dad24eea21adfa5feec75942b3fd5289ad0251","unresolved":false,"context_lines":[{"line_number":168,"context_line":"# Names of secrets used by bootstrap and environmental checks"},{"line_number":169,"context_line":"secrets:"},{"line_number":170,"context_line":"  identity:"},{"line_number":171,"context_line":"    admin: admin"},{"line_number":172,"context_line":"    ord: ord-admin"},{"line_number":173,"context_line":"    ord_trustee: ord-trust"},{"line_number":174,"context_line":"  oslo_db:"},{"line_number":175,"context_line":"    admin: ord-db-admin"},{"line_number":176,"context_line":"    ord: ord-db-user"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"df7087c5_67ffb067","line":173,"range":{"start_line":171,"start_character":0,"end_line":173,"end_character":26},"updated":"2018-03-07 14:18:12.000000000","message":"Can the names of these be updated to following a similar naming scheme to the other services? https://github.com/openstack/openstack-helm/blob/master/glance/values.yaml#L395-L404","commit_id":"d3ab54a79d41a30a0fc8e3f7387024bd1cc07dd0"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"0562de2bc5e786125d0e52b60d06e2d6bb77dcbc","unresolved":false,"context_lines":[{"line_number":168,"context_line":"# Names of secrets used by bootstrap and environmental checks"},{"line_number":169,"context_line":"secrets:"},{"line_number":170,"context_line":"  identity:"},{"line_number":171,"context_line":"    admin: admin"},{"line_number":172,"context_line":"    ord: ord-admin"},{"line_number":173,"context_line":"    ord_trustee: ord-trust"},{"line_number":174,"context_line":"  oslo_db:"},{"line_number":175,"context_line":"    admin: ord-db-admin"},{"line_number":176,"context_line":"    ord: ord-db-user"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"df7087c5_7b18a980","line":173,"range":{"start_line":171,"start_character":0,"end_line":173,"end_character":26},"in_reply_to":"df7087c5_67ffb067","updated":"2018-03-07 16:24:32.000000000","message":"Ok Will make changes","commit_id":"d3ab54a79d41a30a0fc8e3f7387024bd1cc07dd0"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"4f487113620f07ea6e0e9577a40c9cb516a1716b","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"images:"},{"line_number":34,"context_line":"  tags:"},{"line_number":35,"context_line":"    ranger_agent: quay.io/attcomdev/ranger-agent"},{"line_number":36,"context_line":"    ranger-agent_db_sync: quay.io/attcomdev/ranger-agent"},{"line_number":37,"context_line":"    db_drop: quay.io/attcomdev/ranger-agent"},{"line_number":38,"context_line":"    db_init: docker.io/kolla/ubuntu-source-heat-engine:3.0.3"},{"line_number":39,"context_line":"    ks_user: docker.io/kolla/ubuntu-source-heat-engine:3.0.3"},{"line_number":40,"context_line":"    ks_service: docker.io/kolla/ubuntu-source-heat-engine:3.0.3"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"df7087c5_f5835c55","line":37,"range":{"start_line":35,"start_character":0,"end_line":37,"end_character":43},"updated":"2018-03-08 01:47:55.000000000","message":"should be pinned to tagged releases","commit_id":"a308619e7102b1bcd51fa4b1e7ad82a6ff3cfee9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"4f487113620f07ea6e0e9577a40c9cb516a1716b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  ranger_agent:"},{"line_number":58,"context_line":"    DEFAULT:"},{"line_number":59,"context_line":"      api_workers: 1"},{"line_number":60,"context_line":"      debug: True"},{"line_number":61,"context_line":"      verbose: True"},{"line_number":62,"context_line":"      pecan_debug: True"},{"line_number":63,"context_line":"      repo_connection_timeout: 120"},{"line_number":64,"context_line":"      resource_creation_timeout_min: 1200"},{"line_number":65,"context_line":"      resource_creation_timeout_max: 14400"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"df7087c5_15a050f4","line":62,"range":{"start_line":60,"start_character":0,"end_line":62,"end_character":23},"updated":"2018-03-08 01:47:55.000000000","message":"should be false by default","commit_id":"a308619e7102b1bcd51fa4b1e7ad82a6ff3cfee9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"4f487113620f07ea6e0e9577a40c9cb516a1716b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"      resource_status_check_wait: 15"},{"line_number":70,"context_line":"    api:"},{"line_number":71,"context_line":"      host: 0.0.0.0"},{"line_number":72,"context_line":"      port: 9010"},{"line_number":73,"context_line":"    database:"},{"line_number":74,"context_line":"      max_retries: -1"},{"line_number":75,"context_line":"    oslo_messaging_notifications:"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"df7087c5_35b8f428","line":72,"range":{"start_line":72,"start_character":0,"end_line":72,"end_character":16},"updated":"2018-03-08 01:47:55.000000000","message":"should be driven by endpoints section","commit_id":"a308619e7102b1bcd51fa4b1e7ad82a6ff3cfee9"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a616bc0d023d57f49df6d4049861a40bb9f12a92","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"images:"},{"line_number":37,"context_line":"  tags:"},{"line_number":38,"context_line":"    ranger_agent: artifacts-aic.atlantafoundry.com/openstack/ranger-agent:89eec6d35689b7a2259581956dc53eef25585498"},{"line_number":39,"context_line":"    ranger-agent_db_sync: artifacts-aic.atlantafoundry.com/openstack/ranger-agent:89eec6d35689b7a2259581956dc53eef25585498"},{"line_number":40,"context_line":"    db_drop: docker.io/openstackhelm/heat:newton"},{"line_number":41,"context_line":"    db_init: docker.io/openstackhelm/heat:newton"},{"line_number":42,"context_line":"    ks_user: docker.io/openstackhelm/heat:newton"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"df7087c5_52cc3a69","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":122},"updated":"2018-03-22 14:01:21.000000000","message":"These should be references to a generally available image","commit_id":"f0c4f8517f0c7ab55acef8fd1b065a3274c4ef8a"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a616bc0d023d57f49df6d4049861a40bb9f12a92","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    rabbit_init: docker.io/rabbitmq:3.7-management"},{"line_number":45,"context_line":"    ks_endpoints: docker.io/openstackhelm/heat:newton"},{"line_number":46,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.2.1"},{"line_number":47,"context_line":"    test: docker.io/kolla/ubuntu-source-rally:4.0.0"},{"line_number":48,"context_line":"    scripted_test: docker.io/openstackhelm/heat:newton"},{"line_number":49,"context_line":"  pull_policy: \"IfNotPresent\""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":38,"id":"df7087c5_12c24235","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":51},"updated":"2018-03-22 14:01:21.000000000","message":"Can be removed","commit_id":"f0c4f8517f0c7ab55acef8fd1b065a3274c4ef8a"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a616bc0d023d57f49df6d4049861a40bb9f12a92","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  pull_policy: \"IfNotPresent\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"conf:"},{"line_number":52,"context_line":"  rally_tests:"},{"line_number":53,"context_line":"    run_tempest: false"},{"line_number":54,"context_line":"    tests:"},{"line_number":55,"context_line":"  paste:"},{"line_number":56,"context_line":"    pipeline:main:"},{"line_number":57,"context_line":"      pipeline: request_id api-server"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"df7087c5_f2e22ed5","line":54,"range":{"start_line":52,"start_character":0,"end_line":54,"end_character":10},"updated":"2018-03-22 14:01:21.000000000","message":"Can be removed","commit_id":"f0c4f8517f0c7ab55acef8fd1b065a3274c4ef8a"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a616bc0d023d57f49df6d4049861a40bb9f12a92","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    keystone_authtoken:"},{"line_number":88,"context_line":"      auth_type: password"},{"line_number":89,"context_line":"      auth_version: v3"},{"line_number":90,"context_line":"      project_domain_name: Default"},{"line_number":91,"context_line":"      user_domain_name: Default"},{"line_number":92,"context_line":"  ssh:"},{"line_number":93,"context_line":"    user: ranger_agent"},{"line_number":94,"context_line":"    user_home: /home/ranger_agent"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"df7087c5_d2060a87","line":91,"range":{"start_line":90,"start_character":0,"end_line":91,"end_character":31},"updated":"2018-03-22 14:01:21.000000000","message":"This should be handled in the etc-configmap with endpoint lookups","commit_id":"f0c4f8517f0c7ab55acef8fd1b065a3274c4ef8a"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a616bc0d023d57f49df6d4049861a40bb9f12a92","unresolved":false,"context_lines":[{"line_number":235,"context_line":"  git_repo:"},{"line_number":236,"context_line":"    auth:"},{"line_number":237,"context_line":"      ranger_agent:"},{"line_number":238,"context_line":"        username: git@"},{"line_number":239,"context_line":"    hosts:"},{"line_number":240,"context_line":"      default: null"},{"line_number":241,"context_line":"    host_fqdn_override:"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"df7087c5_12f00291","line":238,"range":{"start_line":238,"start_character":1,"end_line":238,"end_character":22},"updated":"2018-03-22 14:01:21.000000000","message":"The endpoint lookup function should be updated to include the @ component in the printf statement. It should not be necessary to append it to a username","commit_id":"f0c4f8517f0c7ab55acef8fd1b065a3274c4ef8a"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a616bc0d023d57f49df6d4049861a40bb9f12a92","unresolved":false,"context_lines":[{"line_number":365,"context_line":"      init_container: null"},{"line_number":366,"context_line":"      ranger_agent_tests:"},{"line_number":367,"context_line":"  replicas:"},{"line_number":368,"context_line":"    ranger_agent_api: 1"},{"line_number":369,"context_line":"    ranger_agent_engine: 1"},{"line_number":370,"context_line":"  lifecycle:"},{"line_number":371,"context_line":"    upgrades:"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"df7087c5_d214caa2","line":368,"range":{"start_line":368,"start_character":4,"end_line":368,"end_character":20},"updated":"2018-03-22 14:01:21.000000000","message":"api","commit_id":"f0c4f8517f0c7ab55acef8fd1b065a3274c4ef8a"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a616bc0d023d57f49df6d4049861a40bb9f12a92","unresolved":false,"context_lines":[{"line_number":366,"context_line":"      ranger_agent_tests:"},{"line_number":367,"context_line":"  replicas:"},{"line_number":368,"context_line":"    ranger_agent_api: 1"},{"line_number":369,"context_line":"    ranger_agent_engine: 1"},{"line_number":370,"context_line":"  lifecycle:"},{"line_number":371,"context_line":"    upgrades:"},{"line_number":372,"context_line":"      deployments:"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"df7087c5_5228bae0","line":369,"range":{"start_line":369,"start_character":4,"end_line":369,"end_character":23},"updated":"2018-03-22 14:01:21.000000000","message":"engine","commit_id":"f0c4f8517f0c7ab55acef8fd1b065a3274c4ef8a"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a616bc0d023d57f49df6d4049861a40bb9f12a92","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        rolling_update:"},{"line_number":376,"context_line":"          max_unavailable: 1"},{"line_number":377,"context_line":"          max_surge: 3"},{"line_number":378,"context_line":"      daemonsets:"},{"line_number":379,"context_line":"        pod_replacement_strategy: RollingUpdate"},{"line_number":380,"context_line":"        ranger_agent_api:"},{"line_number":381,"context_line":"          enabled: true"},{"line_number":382,"context_line":"          min_ready_seconds: 0"},{"line_number":383,"context_line":"          max_unavailable: 1"},{"line_number":384,"context_line":"        ranger_agent_engine:"},{"line_number":385,"context_line":"          enabled: true"},{"line_number":386,"context_line":"          min_ready_seconds: 0"},{"line_number":387,"context_line":"          max_unavailable: 1"},{"line_number":388,"context_line":"    disruption_budget:"},{"line_number":389,"context_line":"      ranger_agent_api:"},{"line_number":390,"context_line":"        min_available: 0"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"df7087c5_726a9e1a","line":387,"range":{"start_line":378,"start_character":0,"end_line":387,"end_character":28},"updated":"2018-03-22 14:01:21.000000000","message":"This can be removed, as ranger-agent api and engine are both deployments, not daemonsets","commit_id":"f0c4f8517f0c7ab55acef8fd1b065a3274c4ef8a"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a616bc0d023d57f49df6d4049861a40bb9f12a92","unresolved":false,"context_lines":[{"line_number":487,"context_line":"  job_ks_user: true"},{"line_number":488,"context_line":"  job_rabbit_init: true"},{"line_number":489,"context_line":"  pdb_api: true"},{"line_number":490,"context_line":"  pod_rally_test: false"},{"line_number":491,"context_line":"  pod_test: true"},{"line_number":492,"context_line":"  service_ingress_ranger_agent_api: true"},{"line_number":493,"context_line":"  service_ranger_agent_api: true"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"df7087c5_d2628a3e","line":490,"range":{"start_line":490,"start_character":0,"end_line":490,"end_character":23},"updated":"2018-03-22 14:01:21.000000000","message":"remove","commit_id":"f0c4f8517f0c7ab55acef8fd1b065a3274c4ef8a"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"c2b0cd1956c4330a47eced04cbf07325b931efb9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Default values for nova."},{"line_number":16,"context_line":"# This is a YAML-formatted file."},{"line_number":17,"context_line":"# Declare name/value pairs to be passed into your templates."},{"line_number":18,"context_line":"# name: value"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"bf659307_8119677a","line":15,"range":{"start_line":15,"start_character":21,"end_line":15,"end_character":25},"updated":"2018-03-26 21:32:09.000000000","message":"ranger agent","commit_id":"fea8db7f4c96b1c602ef73d7249f1c3ced7239fd"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"372469f9ad89d3579ff7d9d7102f18f253118a27","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    keystone_authtoken:"},{"line_number":84,"context_line":"      auth_type: password"},{"line_number":85,"context_line":"      auth_version: v3"},{"line_number":86,"context_line":"      project_domain_name: Default"},{"line_number":87,"context_line":"      user_domain_name: Default"},{"line_number":88,"context_line":"  ssh:"},{"line_number":89,"context_line":"    user: ranger_agent"},{"line_number":90,"context_line":"    user_home: /home/ranger_agent"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"bf659307_01aa37d3","line":87,"range":{"start_line":86,"start_character":0,"end_line":87,"end_character":31},"updated":"2018-03-26 21:39:01.000000000","message":"I\u0027d still like to see this handled via endpoint lookups","commit_id":"fea8db7f4c96b1c602ef73d7249f1c3ced7239fd"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6eb3b2f34c46b0907fe0de349b647a289fbf8c4b","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"images:"},{"line_number":37,"context_line":"  tags:"},{"line_number":38,"context_line":"    ranger_agent: quay.io/attcomdev/ranger-agent"},{"line_number":39,"context_line":"    ranger-agent_db_sync: quay.io/attcomdev/ranger-agent"},{"line_number":40,"context_line":"    db_drop: docker.io/openstackhelm/heat:newton"},{"line_number":41,"context_line":"    db_init: docker.io/openstackhelm/heat:newton"},{"line_number":42,"context_line":"    ks_user: docker.io/openstackhelm/heat:newton"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"bf659307_c6098731","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":56},"updated":"2018-03-28 06:01:33.000000000","message":"should be pinned to a version","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"9eee53537ba66e4623c2edaa7b779ca097e191cd","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"images:"},{"line_number":37,"context_line":"  tags:"},{"line_number":38,"context_line":"    ranger_agent: quay.io/attcomdev/ranger-agent"},{"line_number":39,"context_line":"    ranger-agent_db_sync: quay.io/attcomdev/ranger-agent"},{"line_number":40,"context_line":"    db_drop: docker.io/openstackhelm/heat:newton"},{"line_number":41,"context_line":"    db_init: docker.io/openstackhelm/heat:newton"},{"line_number":42,"context_line":"    ks_user: docker.io/openstackhelm/heat:newton"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"bf659307_838932cb","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":56},"in_reply_to":"bf659307_c6098731","updated":"2018-03-28 15:54:42.000000000","message":"we did not get a version release. will keep following up with Stacey","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6eb3b2f34c46b0907fe0de349b647a289fbf8c4b","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    ranger_agent: ranger-agent-db-user"},{"line_number":173,"context_line":"  oslo_messaging:"},{"line_number":174,"context_line":"    admin: ranger-agent-rabbitmq-admin"},{"line_number":175,"context_line":"    ranger-agent: ranger-agent-rabbitmq-user"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"# typically overriden by environmental"},{"line_number":178,"context_line":"# values, but should include all endpoints"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"bf659307_3903c40f","line":175,"range":{"start_line":175,"start_character":10,"end_line":175,"end_character":11},"updated":"2018-03-28 06:01:33.000000000","message":"why `-` when `_` is used for all other user classes?","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6eb3b2f34c46b0907fe0de349b647a289fbf8c4b","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        username: root"},{"line_number":186,"context_line":"        password: password"},{"line_number":187,"context_line":"      ranger_agent:"},{"line_number":188,"context_line":"        username: root"},{"line_number":189,"context_line":"        password: password"},{"line_number":190,"context_line":"    hosts:"},{"line_number":191,"context_line":"      default: mariadb"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"bf659307_d909682c","line":188,"range":{"start_line":188,"start_character":18,"end_line":188,"end_character":22},"updated":"2018-03-28 06:01:33.000000000","message":"please don\u0027t use `root` for application databases","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6eb3b2f34c46b0907fe0de349b647a289fbf8c4b","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        username: rabbitmq"},{"line_number":211,"context_line":"        password: password"},{"line_number":212,"context_line":"      ranger-agent:"},{"line_number":213,"context_line":"        username: ord"},{"line_number":214,"context_line":"        password: password"},{"line_number":215,"context_line":"    hosts:"},{"line_number":216,"context_line":"      default: rabbitmq"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"bf659307_f90c6c3c","line":213,"range":{"start_line":213,"start_character":18,"end_line":213,"end_character":21},"updated":"2018-03-28 06:01:33.000000000","message":"`ranger_agent` ?","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6eb3b2f34c46b0907fe0de349b647a289fbf8c4b","unresolved":false,"context_lines":[{"line_number":226,"context_line":"  ranger_rds:"},{"line_number":227,"context_line":"    auth:"},{"line_number":228,"context_line":"      ranger:"},{"line_number":229,"context_line":"       username: null"},{"line_number":230,"context_line":"    hosts:"},{"line_number":231,"context_line":"      default: null"},{"line_number":232,"context_line":"    host_fqdn_override:"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"bf659307_b90ef42f","line":229,"range":{"start_line":229,"start_character":17,"end_line":229,"end_character":21},"updated":"2018-03-28 06:01:33.000000000","message":"why null?","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"359603f40545a9822215c8eb05258b0eaed9db9e","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    hosts:"},{"line_number":231,"context_line":"      default: null"},{"line_number":232,"context_line":"    host_fqdn_override:"},{"line_number":233,"context_line":"      default: internal.ranger.com"},{"line_number":234,"context_line":"    path: /v1/rds/status"},{"line_number":235,"context_line":"    scheme: http"},{"line_number":236,"context_line":"    port:"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"bf659307_f95d4ce9","line":233,"range":{"start_line":233,"start_character":15,"end_line":233,"end_character":34},"updated":"2018-03-28 06:12:23.000000000","message":"how does this work? If we need an external service for ranger-agent to function, should it live in the main repo? or would addons be a more appropriate home?","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"9eee53537ba66e4623c2edaa7b779ca097e191cd","unresolved":false,"context_lines":[{"line_number":230,"context_line":"    hosts:"},{"line_number":231,"context_line":"      default: null"},{"line_number":232,"context_line":"    host_fqdn_override:"},{"line_number":233,"context_line":"      default: internal.ranger.com"},{"line_number":234,"context_line":"    path: /v1/rds/status"},{"line_number":235,"context_line":"    scheme: http"},{"line_number":236,"context_line":"    port:"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"bf659307_588d4479","line":233,"range":{"start_line":233,"start_character":15,"end_line":233,"end_character":34},"in_reply_to":"bf659307_f95d4ce9","updated":"2018-03-28 15:54:42.000000000","message":"This is url which is expecting final response for ranger agent request. This is asynchronous response after resource is physically created. If requester implement listener then they will receive response other wise they can pull status.","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6eb3b2f34c46b0907fe0de349b647a289fbf8c4b","unresolved":false,"context_lines":[{"line_number":249,"context_line":"      ranger_agent:"},{"line_number":250,"context_line":"        role: admin"},{"line_number":251,"context_line":"        region_name: RegionOne"},{"line_number":252,"context_line":"        username: ord-admin"},{"line_number":253,"context_line":"        password: password"},{"line_number":254,"context_line":"        project_name: service"},{"line_number":255,"context_line":"        user_domain_name: default"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"bf659307_591d5864","line":252,"range":{"start_line":252,"start_character":18,"end_line":252,"end_character":27},"updated":"2018-03-28 06:01:33.000000000","message":"`ranger-agent` ?","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6eb3b2f34c46b0907fe0de349b647a289fbf8c4b","unresolved":false,"context_lines":[{"line_number":283,"context_line":"      api:"},{"line_number":284,"context_line":"        default: 9292"},{"line_number":285,"context_line":"        public: 80"},{"line_number":286,"context_line":"  orchestration:"},{"line_number":287,"context_line":"    name: heat"},{"line_number":288,"context_line":"    hosts:"},{"line_number":289,"context_line":"      default: heat-api"},{"line_number":290,"context_line":"      public: heat"},{"line_number":291,"context_line":"    host_fqdn_override:"},{"line_number":292,"context_line":"      default: null"},{"line_number":293,"context_line":"    path:"},{"line_number":294,"context_line":"      default: \u0027/v1/%(project_id)s\u0027"},{"line_number":295,"context_line":"    scheme:"},{"line_number":296,"context_line":"      default: \u0027http\u0027"},{"line_number":297,"context_line":"    port:"},{"line_number":298,"context_line":"      api:"},{"line_number":299,"context_line":"        default: 8004"},{"line_number":300,"context_line":"        public: 80"},{"line_number":301,"context_line":"  ranger_agent:"},{"line_number":302,"context_line":"    name: ranger-agent"},{"line_number":303,"context_line":"    hosts:"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"bf659307_b937d4e3","line":300,"range":{"start_line":286,"start_character":0,"end_line":300,"end_character":18},"updated":"2018-03-28 06:01:33.000000000","message":"is this used anywhere?","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"9eee53537ba66e4623c2edaa7b779ca097e191cd","unresolved":false,"context_lines":[{"line_number":283,"context_line":"      api:"},{"line_number":284,"context_line":"        default: 9292"},{"line_number":285,"context_line":"        public: 80"},{"line_number":286,"context_line":"  orchestration:"},{"line_number":287,"context_line":"    name: heat"},{"line_number":288,"context_line":"    hosts:"},{"line_number":289,"context_line":"      default: heat-api"},{"line_number":290,"context_line":"      public: heat"},{"line_number":291,"context_line":"    host_fqdn_override:"},{"line_number":292,"context_line":"      default: null"},{"line_number":293,"context_line":"    path:"},{"line_number":294,"context_line":"      default: \u0027/v1/%(project_id)s\u0027"},{"line_number":295,"context_line":"    scheme:"},{"line_number":296,"context_line":"      default: \u0027http\u0027"},{"line_number":297,"context_line":"    port:"},{"line_number":298,"context_line":"      api:"},{"line_number":299,"context_line":"        default: 8004"},{"line_number":300,"context_line":"        public: 80"},{"line_number":301,"context_line":"  ranger_agent:"},{"line_number":302,"context_line":"    name: ranger-agent"},{"line_number":303,"context_line":"    hosts:"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"bf659307_98467c21","line":300,"range":{"start_line":286,"start_character":0,"end_line":300,"end_character":18},"in_reply_to":"bf659307_b937d4e3","updated":"2018-03-28 15:54:42.000000000","message":"ranger-agent-engine is having dependency on it\nengine:\n      jobs:\n      - ranger-agent-db-sync\n      - ranger-agent-ks-user\n      - ranger-agent-rabbit-init\n      services:\n      - service: oslo_db\n        endpoint: internal\n      - service: identity\n        endpoint: internal\n      - service: orchestration\n        endpoint: internal\n      - service: image\n        endpoint: internal","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"280a57a8f08ed5adc5b948730b53cb83cf6e07ab","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    ranger_agent: ranger-agent-db-user"},{"line_number":173,"context_line":"  oslo_messaging:"},{"line_number":174,"context_line":"    admin: ranger-agent-rabbitmq-admin"},{"line_number":175,"context_line":"    ranger-agent: ranger-agent-rabbitmq-user"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"# typically overriden by environmental"},{"line_number":178,"context_line":"# values, but should include all endpoints"}],"source_content_type":"text/x-yaml","patch_set":52,"id":"bf659307_9a72d048","line":175,"range":{"start_line":175,"start_character":10,"end_line":175,"end_character":11},"updated":"2018-03-29 16:39:35.000000000","message":"should be \u0027_\u0027","commit_id":"51742b86f0615d6067920273520c2bdf807cfaac"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"f91419e898e37fa37d9cd89fe7b7bf8ad3252462","unresolved":false,"context_lines":[{"line_number":36,"context_line":"images:"},{"line_number":37,"context_line":"  tags:"},{"line_number":38,"context_line":"    ranger_agent: quay.io/attcomdev/ranger-agent:5d29fd462bb85cf6c1b0acb25bfb898944e62b1a"},{"line_number":39,"context_line":"    ranger-agent_db_sync: quay.io/attcomdev/ranger-agent:5d29fd462bb85cf6c1b0acb25bfb898944e62b1a"},{"line_number":40,"context_line":"    db_drop: docker.io/openstackhelm/heat:newton"},{"line_number":41,"context_line":"    db_init: docker.io/openstackhelm/heat:newton"},{"line_number":42,"context_line":"    ks_user: docker.io/openstackhelm/heat:newton"}],"source_content_type":"text/x-yaml","patch_set":53,"id":"bf659307_9adf30d5","line":39,"range":{"start_line":39,"start_character":10,"end_line":39,"end_character":11},"updated":"2018-03-29 16:52:29.000000000","message":"_","commit_id":"c2e76faf950481b7e1f64cc71f942e872a0f817f"}],"tools/deployment/multinode/250-ranger-agent.sh":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"1cf8e3a878b47946d89f0cf6497c38a89526726b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  --set pod.replicas.ranger_agent_api\u003d1 \\"},{"line_number":23,"context_line":"  --set pod.replicas.ranger_agent_engine\u003d1"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"#NOTE: Wait for deploy"},{"line_number":26,"context_line":"./tools/deployment/common/wait-for-pods.sh openstack"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":" helm status ranger-agent"}],"source_content_type":"text/x-sh","patch_set":25,"id":"df7087c5_4b5233e0","line":28,"range":{"start_line":25,"start_character":0,"end_line":28,"end_character":25},"updated":"2018-03-13 12:58:10.000000000","message":"The helm tests for ranger-agent need to be executed as part of this bash script, after checking the helm status","commit_id":"6626c9d3f97e3bfba2d35a7ea418e4fec38c1a84"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"5026a0538ef67a96822be2cd28915cf3499678ef","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#NOTE: Wait for deploy"},{"line_number":26,"context_line":"./tools/deployment/common/wait-for-pods.sh openstack"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":" helm status ranger-agent"}],"source_content_type":"text/x-sh","patch_set":29,"id":"df7087c5_9a7ef2ac","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":25},"updated":"2018-03-16 15:36:52.000000000","message":"Still need tests to be executed via the ranger-agent deployment to verify it\u0027s functional and can pass a basic smoke test","commit_id":"52dc3fa4935052d2a5d6f80fa12011971996ea7d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a616bc0d023d57f49df6d4049861a40bb9f12a92","unresolved":false,"context_lines":[{"line_number":16,"context_line":"set -xe"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"#NOTE: Deploy command"},{"line_number":19,"context_line":"helm install ./ranger-agent \\"},{"line_number":20,"context_line":"  --namespace\u003dopenstack \\"},{"line_number":21,"context_line":"  --name\u003dranger-agent \\"},{"line_number":22,"context_line":"  --set pod.replicas.ranger_agent_api\u003d1 \\"},{"line_number":23,"context_line":"  --set pod.replicas.ranger_agent_engine\u003d1 \\"},{"line_number":24,"context_line":"  --set conf.ranger_agent.orm.enable_rds_callback_check\u003dFalse"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"#NOTE: Wait for deploy"},{"line_number":27,"context_line":"./tools/deployment/common/wait-for-pods.sh openstack"}],"source_content_type":"text/x-sh","patch_set":38,"id":"df7087c5_f2cc6e36","line":24,"range":{"start_line":19,"start_character":0,"end_line":24,"end_character":61},"updated":"2018-03-22 14:01:21.000000000","message":"For setting \u003e\u003d3 values, we use the following format: https://github.com/openstack/openstack-helm/blob/master/tools/deployment/multinode/140-compute-kit.sh#L55-L95","commit_id":"f0c4f8517f0c7ab55acef8fd1b065a3274c4ef8a"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"372469f9ad89d3579ff7d9d7102f18f253118a27","unresolved":false,"context_lines":[{"line_number":19,"context_line":"helm install ./ranger-agent \\"},{"line_number":20,"context_line":"  --namespace\u003dopenstack \\"},{"line_number":21,"context_line":"  --name\u003dranger-agent \\"},{"line_number":22,"context_line":"  --set pod.replicas.api\u003d1 \\"},{"line_number":23,"context_line":"  --set pod.replicas.engine\u003d1 \\"},{"line_number":24,"context_line":"  --set conf.ranger_agent.DEFAULT.enable_rds_callback_check\u003dFalse"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"#NOTE: Wait for deploy"},{"line_number":27,"context_line":"./tools/deployment/common/wait-for-pods.sh openstack"}],"source_content_type":"text/x-sh","patch_set":44,"id":"bf659307_01831755","line":24,"range":{"start_line":22,"start_character":0,"end_line":24,"end_character":65},"updated":"2018-03-26 21:39:01.000000000","message":"Please see how this is handled with other services with \u003e\u003d 3 set flags: https://github.com/openstack/openstack-helm/blob/master/tools/deployment/developer/ceph/160-compute-kit.sh#L40-L66","commit_id":"fea8db7f4c96b1c602ef73d7249f1c3ced7239fd"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"b5ae2fcc87071875bbc32db2341501c3569df217","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"set -xe"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"#NOTE: Deploy command"},{"line_number":19,"context_line":"helm install ./ranger-agent \\"},{"line_number":20,"context_line":"  --namespace\u003dopenstack \\"}],"source_content_type":"text/x-sh","patch_set":46,"id":"bf659307_5b5d65e7","line":17,"updated":"2018-03-27 14:45:42.000000000","message":"Since we\u0027re invoking ranger-agent in a multinode context, should we set pod.replicas.* greater than 1?  Or is that not yet supported by Ranger-Agent?  If it works today, might be good to set them to 2.  Otherwise I\u0027m good with holding to 1 for now, but with a comment in values.yaml that says something like \"Support for more than one replica is pending.\"","commit_id":"4820bbbaa0c24144b64b1dc1b451b87b4ce41c12"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"6911944cfc15b845dd478969b3702b1bb7064506","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"set -xe"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"#NOTE: Deploy command"},{"line_number":19,"context_line":"helm install ./ranger-agent \\"},{"line_number":20,"context_line":"  --namespace\u003dopenstack \\"}],"source_content_type":"text/x-sh","patch_set":46,"id":"bf659307_bb9281f5","line":17,"in_reply_to":"bf659307_5b5d65e7","updated":"2018-03-27 15:22:59.000000000","message":"It is supported more than 1 , I will go agead and enable more than 2 in value","commit_id":"4820bbbaa0c24144b64b1dc1b451b87b4ce41c12"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"b5ae2fcc87071875bbc32db2341501c3569df217","unresolved":false,"context_lines":[{"line_number":19,"context_line":"helm install ./ranger-agent \\"},{"line_number":20,"context_line":"  --namespace\u003dopenstack \\"},{"line_number":21,"context_line":"  --name\u003dranger-agent \\"},{"line_number":22,"context_line":"  --set conf.ranger_agent.DEFAULT.enable_rds_callback_check\u003dFalse"},{"line_number":23,"context_line":"      ${OSH_EXTRA_HELM_ARGS} \\"},{"line_number":24,"context_line":"      ${OSH_EXTRA_HELM_ARGS_RANGER_AGENT}"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-sh","patch_set":46,"id":"bf659307_fbaeb9e5","line":22,"updated":"2018-03-27 14:45:42.000000000","message":"I think we\u0027re missing a line continuing \\ on this line?","commit_id":"4820bbbaa0c24144b64b1dc1b451b87b4ce41c12"},{"author":{"_account_id":24999,"name":"Hari","email":"hosingh000@gmail.com","username":"hosingh000"},"change_message_id":"6911944cfc15b845dd478969b3702b1bb7064506","unresolved":false,"context_lines":[{"line_number":19,"context_line":"helm install ./ranger-agent \\"},{"line_number":20,"context_line":"  --namespace\u003dopenstack \\"},{"line_number":21,"context_line":"  --name\u003dranger-agent \\"},{"line_number":22,"context_line":"  --set conf.ranger_agent.DEFAULT.enable_rds_callback_check\u003dFalse"},{"line_number":23,"context_line":"      ${OSH_EXTRA_HELM_ARGS} \\"},{"line_number":24,"context_line":"      ${OSH_EXTRA_HELM_ARGS_RANGER_AGENT}"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-sh","patch_set":46,"id":"bf659307_fb76b9d8","line":22,"in_reply_to":"bf659307_fbaeb9e5","updated":"2018-03-27 15:22:59.000000000","message":"Thanks","commit_id":"4820bbbaa0c24144b64b1dc1b451b87b4ce41c12"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"e0c499eba55abdd1ac6fc5249812091d43814893","unresolved":false,"context_lines":[{"line_number":19,"context_line":"helm install ./ranger-agent \\"},{"line_number":20,"context_line":"  --namespace\u003dopenstack \\"},{"line_number":21,"context_line":"  --name\u003dranger-agent \\"},{"line_number":22,"context_line":"  --set pod.replicas.api\u003d2 \\"},{"line_number":23,"context_line":"  --set conf.ranger_agent.DEFAULT.enable_rds_callback_check\u003dFalse \\"},{"line_number":24,"context_line":"      ${OSH_EXTRA_HELM_ARGS} \\"},{"line_number":25,"context_line":"      ${OSH_EXTRA_HELM_ARGS_RANGER_AGENT}"}],"source_content_type":"text/x-sh","patch_set":48,"id":"bf659307_f229f39a","line":22,"updated":"2018-03-27 18:36:36.000000000","message":"Awesome, thanks for adding this.  What about the engine, can it support \u003e1 replica as well?","commit_id":"9d08e5c89eb239a2c678cbca1ee1484d3b1183e4"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"e0c499eba55abdd1ac6fc5249812091d43814893","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  --name\u003dranger-agent \\"},{"line_number":22,"context_line":"  --set pod.replicas.api\u003d2 \\"},{"line_number":23,"context_line":"  --set conf.ranger_agent.DEFAULT.enable_rds_callback_check\u003dFalse \\"},{"line_number":24,"context_line":"      ${OSH_EXTRA_HELM_ARGS} \\"},{"line_number":25,"context_line":"      ${OSH_EXTRA_HELM_ARGS_RANGER_AGENT}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"#NOTE: Wait for deploy"}],"source_content_type":"text/x-sh","patch_set":48,"id":"bf659307_72a2c34d","line":24,"updated":"2018-03-27 18:36:36.000000000","message":"Sorry Hari, we\u0027re back above two --sets now :)  Steve\u0027s point was to create a values override file similar to the link below, rather than using --sets.  I discussed with Steve and this is something we need to drive toward consistency, can we please add the override file here?  There are other examples with \u003e2 --set\u0027s that we need to clean up in the future (they are bad examples).\n\nhttps://github.com/openstack/openstack-helm/blob/master/tools/deployment/developer/ceph/160-compute-kit.sh#L40-L66","commit_id":"9d08e5c89eb239a2c678cbca1ee1484d3b1183e4"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6eb3b2f34c46b0907fe0de349b647a289fbf8c4b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    engine: 2"},{"line_number":30,"context_line":"EOF"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"helm install ./ranger-agent \\"},{"line_number":33,"context_line":"  --namespace\u003dopenstack \\"},{"line_number":34,"context_line":"  --name\u003dranger-agent \\"},{"line_number":35,"context_line":"  --values\u003d/tmp/ranger-agent.yaml \\"}],"source_content_type":"text/x-sh","patch_set":49,"id":"bf659307_0660df31","line":32,"range":{"start_line":32,"start_character":5,"end_line":32,"end_character":12},"updated":"2018-03-28 06:01:33.000000000","message":"`upgrade --install`","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6eb3b2f34c46b0907fe0de349b647a289fbf8c4b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  --namespace\u003dopenstack \\"},{"line_number":34,"context_line":"  --name\u003dranger-agent \\"},{"line_number":35,"context_line":"  --values\u003d/tmp/ranger-agent.yaml \\"},{"line_number":36,"context_line":"      ${OSH_EXTRA_HELM_ARGS} \\"},{"line_number":37,"context_line":"      ${OSH_EXTRA_HELM_ARGS_RANGER_AGENT}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"#NOTE: Wait for deploy"}],"source_content_type":"text/x-sh","patch_set":49,"id":"bf659307_4666d753","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":6},"updated":"2018-03-28 06:01:33.000000000","message":"indent","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6eb3b2f34c46b0907fe0de349b647a289fbf8c4b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  --name\u003dranger-agent \\"},{"line_number":35,"context_line":"  --values\u003d/tmp/ranger-agent.yaml \\"},{"line_number":36,"context_line":"      ${OSH_EXTRA_HELM_ARGS} \\"},{"line_number":37,"context_line":"      ${OSH_EXTRA_HELM_ARGS_RANGER_AGENT}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"#NOTE: Wait for deploy"},{"line_number":40,"context_line":"./tools/deployment/common/wait-for-pods.sh openstack"}],"source_content_type":"text/x-sh","patch_set":49,"id":"bf659307_2663a344","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":6},"updated":"2018-03-28 06:01:33.000000000","message":"indent","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6eb3b2f34c46b0907fe0de349b647a289fbf8c4b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"#NOTE: Wait for deploy"},{"line_number":40,"context_line":"./tools/deployment/common/wait-for-pods.sh openstack"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":" helm status ranger-agent"},{"line_number":43,"context_line":" helm test ranger-agent --timeout 900"}],"source_content_type":"text/x-sh","patch_set":49,"id":"bf659307_66775b04","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":1},"updated":"2018-03-28 06:01:33.000000000","message":"ws","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6eb3b2f34c46b0907fe0de349b647a289fbf8c4b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"./tools/deployment/common/wait-for-pods.sh openstack"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":" helm status ranger-agent"},{"line_number":43,"context_line":" helm test ranger-agent --timeout 900"}],"source_content_type":"text/x-sh","patch_set":49,"id":"bf659307_8672af10","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":1},"updated":"2018-03-28 06:01:33.000000000","message":"ws","commit_id":"7f5decc0aad78d90c3e1c42097abe36016210cb2"}]}