)]}'
{"ceph/templates/bin/osd/_bus.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"b71d62e1af537b70618994638ecc46af738a2f1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3fa0c359_4dedd023","updated":"2018-02-16 16:23:46.000000000","message":"rather than creating a new file with a large amount of repetition, would it be possible to simply add the bus_to_logical function to the block scripts?","commit_id":"415500aee7d1e955203b95ec611a50cf8df61d31"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"f5438610e8cf2b538d56f1a9eafb93b7d8fc17b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3fa0c359_4d0950db","in_reply_to":"3fa0c359_4dedd023","updated":"2018-02-16 16:29:18.000000000","message":"good question — I originally had this code in block.sh, but between the fact that init wants to execute based on the device type and because i didn\u0027t know what the preferred design was, I just copied it off to a new script.  If it\u0027d be better to just use block.sh, I\u0027m fine with that.","commit_id":"415500aee7d1e955203b95ec611a50cf8df61d31"}],"ceph/templates/bin/osd/_init.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"0ef7715bcbe71b0218884135f67d11dc051d07d4","unresolved":false,"context_lines":[{"line_number":22,"context_line":": \"${OSD_JOURNAL_UUID:\u003d$(uuidgen)}\""},{"line_number":23,"context_line":": \"${OSD_FORCE_ZAP:\u003d1}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# convert device paths like \u0027scsi@bus:x.y.z\u0027 or"},{"line_number":26,"context_line":"# \u0027iscsi@ip:port:iqn:unit:lun\u0027 to block device"},{"line_number":27,"context_line":"# names in the form \u0027/dev/sdX\u0027, if possible."},{"line_number":28,"context_line":"# In the ISCSI case, the connection is presumed"},{"line_number":29,"context_line":"# to already exist.  We will not attempt to connect"},{"line_number":30,"context_line":"# to a target."},{"line_number":31,"context_line":"function bus_to_logical {"},{"line_number":32,"context_line":"  local DEV\u003d$1"},{"line_number":33,"context_line":"  if [ ! -b ${DEV} ]; then"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"1f9dbf25_abf3079e","line":30,"range":{"start_line":25,"start_character":0,"end_line":30,"end_character":14},"updated":"2018-03-04 12:31:28.000000000","message":"what about pci etc?","commit_id":"10e6e33732b89effa36a4c5ee036eff2c47b4952"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"7e76f5746a0fd961e46849e5df9aa00078b4ba85","unresolved":false,"context_lines":[{"line_number":22,"context_line":": \"${OSD_JOURNAL_UUID:\u003d$(uuidgen)}\""},{"line_number":23,"context_line":": \"${OSD_FORCE_ZAP:\u003d1}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# convert device paths like \u0027scsi@bus:x.y.z\u0027 or"},{"line_number":26,"context_line":"# \u0027iscsi@ip:port:iqn:unit:lun\u0027 to block device"},{"line_number":27,"context_line":"# names in the form \u0027/dev/sdX\u0027, if possible."},{"line_number":28,"context_line":"# In the ISCSI case, the connection is presumed"},{"line_number":29,"context_line":"# to already exist.  We will not attempt to connect"},{"line_number":30,"context_line":"# to a target."},{"line_number":31,"context_line":"function bus_to_logical {"},{"line_number":32,"context_line":"  local DEV\u003d$1"},{"line_number":33,"context_line":"  if [ ! -b ${DEV} ]; then"}],"source_content_type":"text/x-smarty","patch_set":4,"id":"1f9dbf25_4e17f152","line":30,"range":{"start_line":25,"start_character":0,"end_line":30,"end_character":14},"in_reply_to":"1f9dbf25_abf3079e","updated":"2018-03-04 16:05:49.000000000","message":"right now, i don\u0027t have a system to work out PCI paths on; if I can figure out what they look like, I\u0027d add them.\n\nas for \"etc\": what other buses do we want to support besides PCI, scsi, and iSCSI?  adding additional ones would be pretty easy.\n\ngiven we\u0027ve got use cases for scsi and iSCSI now (and also, those seem to cover many typical installations), would it be OK to merge this as-is and add additional bus types in future changes?","commit_id":"10e6e33732b89effa36a4c5ee036eff2c47b4952"}],"ceph/templates/utils/_osd_daemonset_overrides.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"b71d62e1af537b70618994638ecc46af738a2f1e","unresolved":false,"context_lines":[{"line_number":311,"context_line":"  {{- range $podContainer :\u003d $context.Values.__daemonset_yaml.spec.template.spec.containers }}"},{"line_number":312,"context_line":"    {{- $_ :\u003d set $context.Values \"_tmpYAMLcontainer\" $podContainer }}"},{"line_number":313,"context_line":"    {{ $containerEnv :\u003d prepend (prepend (prepend ( prepend (index $context.Values._tmpYAMLcontainer \"env\") (dict \"name\" \"STORAGE_TYPE\" \"value\" $v.data.type)) (dict \"name\" \"JOURNAL_TYPE\" \"value\" $v.journal.type)) (dict \"name\" \"STORAGE_LOCATION\" \"value\" $v.data.location)) (dict \"name\" \"JOURNAL_LOCATION\" \"value\" $v.journal.location) }}"},{"line_number":314,"context_line":"    {{ $containerEnv :\u003d prepend $containerEnv (dict \"name\" \"JOURNAL_PARTITION\" \"value\" (toString $v.journal.partition)) }}"},{"line_number":315,"context_line":"    {{- $localInitContainerEnv :\u003d omit $context.Values._tmpYAMLcontainer \"env\" }}"},{"line_number":316,"context_line":"    {{- $_ :\u003d set $localInitContainerEnv \"env\" $containerEnv }}"},{"line_number":317,"context_line":"    {{ $containerList :\u003d append $context.Values.__tmpYAMLcontainers $localInitContainerEnv }}"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3fa0c359_adad74eb","line":314,"range":{"start_line":314,"start_character":4,"end_line":314,"end_character":122},"updated":"2018-02-16 16:23:46.000000000","message":"why can we not use JOURNAL_LOCATION as with other modes of operation?","commit_id":"415500aee7d1e955203b95ec611a50cf8df61d31"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"f889c905d848edd8516ea089671b51f402a262da","unresolved":false,"context_lines":[{"line_number":311,"context_line":"  {{- range $podContainer :\u003d $context.Values.__daemonset_yaml.spec.template.spec.containers }}"},{"line_number":312,"context_line":"    {{- $_ :\u003d set $context.Values \"_tmpYAMLcontainer\" $podContainer }}"},{"line_number":313,"context_line":"    {{ $containerEnv :\u003d prepend (prepend (prepend ( prepend (index $context.Values._tmpYAMLcontainer \"env\") (dict \"name\" \"STORAGE_TYPE\" \"value\" $v.data.type)) (dict \"name\" \"JOURNAL_TYPE\" \"value\" $v.journal.type)) (dict \"name\" \"STORAGE_LOCATION\" \"value\" $v.data.location)) (dict \"name\" \"JOURNAL_LOCATION\" \"value\" $v.journal.location) }}"},{"line_number":314,"context_line":"    {{ $containerEnv :\u003d prepend $containerEnv (dict \"name\" \"JOURNAL_PARTITION\" \"value\" (toString $v.journal.partition)) }}"},{"line_number":315,"context_line":"    {{- $localInitContainerEnv :\u003d omit $context.Values._tmpYAMLcontainer \"env\" }}"},{"line_number":316,"context_line":"    {{- $_ :\u003d set $localInitContainerEnv \"env\" $containerEnv }}"},{"line_number":317,"context_line":"    {{ $containerList :\u003d append $context.Values.__tmpYAMLcontainers $localInitContainerEnv }}"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3fa0c359_bd391ba4","line":314,"range":{"start_line":314,"start_character":4,"end_line":314,"end_character":122},"in_reply_to":"3fa0c359_6def6ce9","updated":"2018-02-16 20:57:24.000000000","message":"I used this pattern: https://github.com/openstack/openstack-helm/blob/master/ceph/templates/bin/osd/_start.sh.tpl#L21 with the intention of having block-logical, block-bus etc - would that suffice here?","commit_id":"415500aee7d1e955203b95ec611a50cf8df61d31"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"f5438610e8cf2b538d56f1a9eafb93b7d8fc17b4","unresolved":false,"context_lines":[{"line_number":311,"context_line":"  {{- range $podContainer :\u003d $context.Values.__daemonset_yaml.spec.template.spec.containers }}"},{"line_number":312,"context_line":"    {{- $_ :\u003d set $context.Values \"_tmpYAMLcontainer\" $podContainer }}"},{"line_number":313,"context_line":"    {{ $containerEnv :\u003d prepend (prepend (prepend ( prepend (index $context.Values._tmpYAMLcontainer \"env\") (dict \"name\" \"STORAGE_TYPE\" \"value\" $v.data.type)) (dict \"name\" \"JOURNAL_TYPE\" \"value\" $v.journal.type)) (dict \"name\" \"STORAGE_LOCATION\" \"value\" $v.data.location)) (dict \"name\" \"JOURNAL_LOCATION\" \"value\" $v.journal.location) }}"},{"line_number":314,"context_line":"    {{ $containerEnv :\u003d prepend $containerEnv (dict \"name\" \"JOURNAL_PARTITION\" \"value\" (toString $v.journal.partition)) }}"},{"line_number":315,"context_line":"    {{- $localInitContainerEnv :\u003d omit $context.Values._tmpYAMLcontainer \"env\" }}"},{"line_number":316,"context_line":"    {{- $_ :\u003d set $localInitContainerEnv \"env\" $containerEnv }}"},{"line_number":317,"context_line":"    {{ $containerList :\u003d append $context.Values.__tmpYAMLcontainers $localInitContainerEnv }}"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3fa0c359_6def6ce9","line":314,"range":{"start_line":314,"start_character":4,"end_line":314,"end_character":122},"in_reply_to":"3fa0c359_adad74eb","updated":"2018-02-16 16:29:18.000000000","message":"The problem is that there\u0027s no good, standard way I can see to specify partition as part of a location of the form \"[i]scsi@....\".  We could invent a syntax, but it seems better to make the partition explicit.\n\n(also, this just covers journals right now, but obviously the same syntax would be used for the OSD.)","commit_id":"415500aee7d1e955203b95ec611a50cf8df61d31"},{"author":{"_account_id":26441,"name":"dave kormann","email":"davek@research.att.com","username":"multics"},"change_message_id":"6c8df5e264c044d6867a3722ec41ce09abe2fdb0","unresolved":false,"context_lines":[{"line_number":311,"context_line":"  {{- range $podContainer :\u003d $context.Values.__daemonset_yaml.spec.template.spec.containers }}"},{"line_number":312,"context_line":"    {{- $_ :\u003d set $context.Values \"_tmpYAMLcontainer\" $podContainer }}"},{"line_number":313,"context_line":"    {{ $containerEnv :\u003d prepend (prepend (prepend ( prepend (index $context.Values._tmpYAMLcontainer \"env\") (dict \"name\" \"STORAGE_TYPE\" \"value\" $v.data.type)) (dict \"name\" \"JOURNAL_TYPE\" \"value\" $v.journal.type)) (dict \"name\" \"STORAGE_LOCATION\" \"value\" $v.data.location)) (dict \"name\" \"JOURNAL_LOCATION\" \"value\" $v.journal.location) }}"},{"line_number":314,"context_line":"    {{ $containerEnv :\u003d prepend $containerEnv (dict \"name\" \"JOURNAL_PARTITION\" \"value\" (toString $v.journal.partition)) }}"},{"line_number":315,"context_line":"    {{- $localInitContainerEnv :\u003d omit $context.Values._tmpYAMLcontainer \"env\" }}"},{"line_number":316,"context_line":"    {{- $_ :\u003d set $localInitContainerEnv \"env\" $containerEnv }}"},{"line_number":317,"context_line":"    {{ $containerList :\u003d append $context.Values.__tmpYAMLcontainers $localInitContainerEnv }}"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3fa0c359_bd2d9bfe","line":314,"range":{"start_line":314,"start_character":4,"end_line":314,"end_character":122},"in_reply_to":"3fa0c359_bd391ba4","updated":"2018-02-16 21:16:54.000000000","message":"oy, managed to _completely_ miss that.  sorry, i should\u0027ve been reading more closely (i even noticed the \"bus-bus\" and it didn\u0027t sink in.)\n\nyeah, that should work fine.  i\u0027ll use block-bus as you suggest.","commit_id":"415500aee7d1e955203b95ec611a50cf8df61d31"}]}