)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"607bb2865388888cb588156f5a51f93957191e8a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shixiong Shang \u003csparkofwisdom@hotmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-02-27 02:41:03 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Partially-Implements: proxysql-mariadb"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added new values.yaml"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa0c359_669fc9b3","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":20},"updated":"2018-02-27 04:39:33.000000000","message":"Is this a partial implementation?  Are there other patch set related to this bp?","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"607bb2865388888cb588156f5a51f93957191e8a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Partially-Implements: proxysql-mariadb"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added new values.yaml"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Fixed more conflicts after rebase with latest master branch"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Fixed merge conflicts"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Fixed volume mount issues"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"First step to position a single proxysql in front of mariadb cluster"},{"line_number":18,"context_line":"Only changes occur on mariadb side"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa0c359_066da5ca","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":25},"updated":"2018-02-27 04:39:33.000000000","message":"Do not need to add incremental changes to the commit message.  values.yaml isn\u0027t added new in this patch set, and git conflicts introduced in the PS are expected to be resolved.","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Partially-Implements: proxysql-mariadb"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added new values.yaml"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Fixed more conflicts after rebase with latest master branch"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Fixed merge conflicts"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Fixed volume mount issues"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"First step to position a single proxysql in front of mariadb cluster"},{"line_number":18,"context_line":"Only changes occur on mariadb side"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df7087c5_77c5fe3b","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":25},"in_reply_to":"3fa0c359_066da5ca","updated":"2018-03-08 17:44:55.000000000","message":"Done","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"607bb2865388888cb588156f5a51f93957191e8a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Fixed volume mount issues"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"First step to position a single proxysql in front of mariadb cluster"},{"line_number":18,"context_line":"Only changes occur on mariadb side"},{"line_number":19,"context_line":"All mariadb traffic will go through proxysql data plane"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Idafe81d1857609f8f00091b769374f49b78b0cff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa0c359_2670e1a3","line":18,"range":{"start_line":18,"start_character":33,"end_line":18,"end_character":34},"updated":"2018-02-27 04:39:33.000000000","message":"nit: side. (missing period)","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"607bb2865388888cb588156f5a51f93957191e8a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"First step to position a single proxysql in front of mariadb cluster"},{"line_number":18,"context_line":"Only changes occur on mariadb side"},{"line_number":19,"context_line":"All mariadb traffic will go through proxysql data plane"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Idafe81d1857609f8f00091b769374f49b78b0cff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa0c359_e66519e2","line":20,"updated":"2018-02-27 04:39:33.000000000","message":"Add a line here:\n\n   implements: bp/proxysql-mariadb\n\nor\n\n  partially-implements: bp/proxysql-mariadb","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"df8088d2a232b3b93a2d118c9aa428d5ce78b90a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Partially-Implements: proxysql-mariadb"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixed ceph volume issues"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Added support of proxysql cluster, positioned in front of mariadb cluster"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Added new values.yaml"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Fixed more conflicts after rebase with latest master branch"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Fixed merge conflicts"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Fixed volume mount issues"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"First step to position a single proxysql in front of mariadb cluster"},{"line_number":22,"context_line":"Only changes occur on mariadb side"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"df7087c5_1e306d56","line":19,"range":{"start_line":9,"start_character":0,"end_line":19,"end_character":25},"updated":"2018-03-08 06:47:20.000000000","message":"see comment from previous patch set.","commit_id":"5dc75bcc416a393ee4fadcfdbdbf6872783e492c"}],"mariadb/templates/bin/_proxysql_nanny.sh.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"607bb2865388888cb588156f5a51f93957191e8a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"#set -ex"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Wait until the final proxysql pod is ready before bootstrapping the"},{"line_number":22,"context_line":"# proxysql database with backends and users"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3fa0c359_8619b57a","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":1},"updated":"2018-02-27 04:39:33.000000000","message":"should this be uncommented?","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"#set -ex"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Wait until the final proxysql pod is ready before bootstrapping the"},{"line_number":22,"context_line":"# proxysql database with backends and users"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"df7087c5_d7cdea5d","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":1},"in_reply_to":"3fa0c359_8619b57a","updated":"2018-03-08 17:44:55.000000000","message":"Done","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"}],"mariadb/templates/configmap-bin-proxysql.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"72d2aa995029b7a9d777855bbaa66c4a623e5f21","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.proxy.proxysql }}"},{"line_number":18,"context_line":"{{- if .Values.manifests.configmap_bin }}"},{"line_number":19,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":20,"context_line":"---"},{"line_number":21,"context_line":"apiVersion: v1"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa0c359_e6ad1931","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":41},"updated":"2018-02-27 06:37:19.000000000","message":"can be combined into a single statement","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.proxy.proxysql }}"},{"line_number":18,"context_line":"{{- if .Values.manifests.configmap_bin }}"},{"line_number":19,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":20,"context_line":"---"},{"line_number":21,"context_line":"apiVersion: v1"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df7087c5_ec706175","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":41},"in_reply_to":"3fa0c359_e6ad1931","updated":"2018-03-08 17:44:55.000000000","message":"Done","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"607bb2865388888cb588156f5a51f93957191e8a","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.proxy.proxysql }}"},{"line_number":18,"context_line":"{{- if .Values.manifests.configmap_bin }}"},{"line_number":19,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":20,"context_line":"---"},{"line_number":21,"context_line":"apiVersion: v1"},{"line_number":22,"context_line":"kind: ConfigMap"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa0c359_662ca998","line":19,"range":{"start_line":19,"start_character":5,"end_line":19,"end_character":11},"updated":"2018-02-27 04:39:33.000000000","message":"unused","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.proxy.proxysql }}"},{"line_number":18,"context_line":"{{- if .Values.manifests.configmap_bin }}"},{"line_number":19,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":20,"context_line":"---"},{"line_number":21,"context_line":"apiVersion: v1"},{"line_number":22,"context_line":"kind: ConfigMap"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df7087c5_4c05cdc1","line":19,"range":{"start_line":19,"start_character":5,"end_line":19,"end_character":11},"in_reply_to":"3fa0c359_662ca998","updated":"2018-03-08 17:44:55.000000000","message":"Done","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"}],"mariadb/templates/configmap-etc-proxysql.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"72d2aa995029b7a9d777855bbaa66c4a623e5f21","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.proxy.proxysql }}"},{"line_number":18,"context_line":"{{- if .Values.manifests.configmap_etc }}"},{"line_number":19,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":20,"context_line":"---"},{"line_number":21,"context_line":"apiVersion: v1"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa0c359_86a8d51f","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":41},"updated":"2018-02-27 06:37:19.000000000","message":"can be combined into a single statement","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.proxy.proxysql }}"},{"line_number":18,"context_line":"{{- if .Values.manifests.configmap_etc }}"},{"line_number":19,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":20,"context_line":"---"},{"line_number":21,"context_line":"apiVersion: v1"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df7087c5_0c0fd5e1","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":41},"in_reply_to":"3fa0c359_86a8d51f","updated":"2018-03-08 17:44:55.000000000","message":"Done","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"607bb2865388888cb588156f5a51f93957191e8a","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.proxy.proxysql }}"},{"line_number":18,"context_line":"{{- if .Values.manifests.configmap_etc }}"},{"line_number":19,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":20,"context_line":"---"},{"line_number":21,"context_line":"apiVersion: v1"},{"line_number":22,"context_line":"kind: ConfigMap"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa0c359_262221a4","line":19,"range":{"start_line":19,"start_character":5,"end_line":19,"end_character":11},"updated":"2018-02-27 04:39:33.000000000","message":"unused","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.proxy.proxysql }}"},{"line_number":18,"context_line":"{{- if .Values.manifests.configmap_etc }}"},{"line_number":19,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":20,"context_line":"---"},{"line_number":21,"context_line":"apiVersion: v1"},{"line_number":22,"context_line":"kind: ConfigMap"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df7087c5_cc21dd4f","line":19,"range":{"start_line":19,"start_character":5,"end_line":19,"end_character":11},"in_reply_to":"3fa0c359_262221a4","updated":"2018-03-08 17:44:55.000000000","message":"Done","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"}],"mariadb/templates/deployment-nanny-proxysql.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"72d2aa995029b7a9d777855bbaa66c4a623e5f21","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.proxy.proxysql }}"},{"line_number":18,"context_line":"{{- if .Values.manifests.deployment }}"},{"line_number":19,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":20,"context_line":"{{- $dependencies :\u003d .Values.dependencies.proxysql_nanny }}"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa0c359_867d35b3","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":38},"updated":"2018-02-27 06:37:19.000000000","message":"can be combined into a single statement.","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.proxy.proxysql }}"},{"line_number":18,"context_line":"{{- if .Values.manifests.deployment }}"},{"line_number":19,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":20,"context_line":"{{- $dependencies :\u003d .Values.dependencies.proxysql_nanny }}"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df7087c5_cccb1d51","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":38},"in_reply_to":"3fa0c359_867d35b3","updated":"2018-03-08 17:44:55.000000000","message":"this function is moved to statefulset due to pv requirement. I combined the both statement.","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"72d2aa995029b7a9d777855bbaa66c4a623e5f21","unresolved":false,"context_lines":[{"line_number":26,"context_line":"kind: Deployment"},{"line_number":27,"context_line":"metadata:"},{"line_number":28,"context_line":"  name: proxysql-nanny"},{"line_number":29,"context_line":"  labels:"},{"line_number":30,"context_line":"{{ tuple $envAll \"proxysql\" \"proxysql-nanny\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":31,"context_line":"spec:"},{"line_number":32,"context_line":"  replicas: 1"},{"line_number":33,"context_line":"  selector:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa0c359_c6601d04","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":119},"updated":"2018-02-27 06:37:19.000000000","message":"required?","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":26,"context_line":"kind: Deployment"},{"line_number":27,"context_line":"metadata:"},{"line_number":28,"context_line":"  name: proxysql-nanny"},{"line_number":29,"context_line":"  labels:"},{"line_number":30,"context_line":"{{ tuple $envAll \"proxysql\" \"proxysql-nanny\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":31,"context_line":"spec:"},{"line_number":32,"context_line":"  replicas: 1"},{"line_number":33,"context_line":"  selector:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df7087c5_8cf3e59e","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":119},"in_reply_to":"3fa0c359_c6601d04","updated":"2018-03-08 17:44:55.000000000","message":"This label is deleted.","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"72d2aa995029b7a9d777855bbaa66c4a623e5f21","unresolved":false,"context_lines":[{"line_number":30,"context_line":"{{ tuple $envAll \"proxysql\" \"proxysql-nanny\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":31,"context_line":"spec:"},{"line_number":32,"context_line":"  replicas: 1"},{"line_number":33,"context_line":"  selector:"},{"line_number":34,"context_line":"    matchLabels:"},{"line_number":35,"context_line":"{{ tuple $envAll \"proxysql\" \"proxysql-nanny\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 6 }}"},{"line_number":36,"context_line":"  template:"},{"line_number":37,"context_line":"    metadata:"},{"line_number":38,"context_line":"      labels:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa0c359_e65bd950","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":119},"updated":"2018-02-27 06:37:19.000000000","message":"required?","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":30,"context_line":"{{ tuple $envAll \"proxysql\" \"proxysql-nanny\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 4 }}"},{"line_number":31,"context_line":"spec:"},{"line_number":32,"context_line":"  replicas: 1"},{"line_number":33,"context_line":"  selector:"},{"line_number":34,"context_line":"    matchLabels:"},{"line_number":35,"context_line":"{{ tuple $envAll \"proxysql\" \"proxysql-nanny\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 6 }}"},{"line_number":36,"context_line":"  template:"},{"line_number":37,"context_line":"    metadata:"},{"line_number":38,"context_line":"      labels:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df7087c5_cc6c7d38","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":119},"in_reply_to":"3fa0c359_e65bd950","updated":"2018-03-08 17:44:55.000000000","message":"This label is deleted","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"}],"mariadb/templates/etc/_proxysql.cnf.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"72d2aa995029b7a9d777855bbaa66c4a623e5f21","unresolved":false,"context_lines":[{"line_number":19,"context_line":"admin_variables \u003d"},{"line_number":20,"context_line":"{"},{"line_number":21,"context_line":"        admin_credentials\u003d\"{{ .Values.endpoints.proxysql.auth.admin.username }}:{{ .Values.endpoints.proxysql.auth.admin.password }}\""},{"line_number":22,"context_line":"        mysql_ifaces\u003d\"0.0.0.0:6032,/var/run/mysql/mysql.sock\""},{"line_number":23,"context_line":"\trefresh_interval\u003d2000"},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3fa0c359_e620b9b2","line":22,"range":{"start_line":22,"start_character":30,"end_line":22,"end_character":34},"updated":"2018-02-27 06:37:19.000000000","message":"should this be controllable?","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":19,"context_line":"admin_variables \u003d"},{"line_number":20,"context_line":"{"},{"line_number":21,"context_line":"        admin_credentials\u003d\"{{ .Values.endpoints.proxysql.auth.admin.username }}:{{ .Values.endpoints.proxysql.auth.admin.password }}\""},{"line_number":22,"context_line":"        mysql_ifaces\u003d\"0.0.0.0:6032,/var/run/mysql/mysql.sock\""},{"line_number":23,"context_line":"\trefresh_interval\u003d2000"},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":5,"id":"df7087c5_9719b27a","line":22,"range":{"start_line":22,"start_character":30,"end_line":22,"end_character":34},"in_reply_to":"3fa0c359_e620b9b2","updated":"2018-03-08 17:44:55.000000000","message":"I am not sure about the implication after we change it from default to a separate port. Let me investigate it further.","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"72d2aa995029b7a9d777855bbaa66c4a623e5f21","unresolved":false,"context_lines":[{"line_number":20,"context_line":"{"},{"line_number":21,"context_line":"        admin_credentials\u003d\"{{ .Values.endpoints.proxysql.auth.admin.username }}:{{ .Values.endpoints.proxysql.auth.admin.password }}\""},{"line_number":22,"context_line":"        mysql_ifaces\u003d\"0.0.0.0:6032,/var/run/mysql/mysql.sock\""},{"line_number":23,"context_line":"\trefresh_interval\u003d2000"},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"mysql_variables\u003d"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3fa0c359_063845eb","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":1},"updated":"2018-02-27 06:37:19.000000000","message":"tabs","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":20,"context_line":"{"},{"line_number":21,"context_line":"        admin_credentials\u003d\"{{ .Values.endpoints.proxysql.auth.admin.username }}:{{ .Values.endpoints.proxysql.auth.admin.password }}\""},{"line_number":22,"context_line":"        mysql_ifaces\u003d\"0.0.0.0:6032,/var/run/mysql/mysql.sock\""},{"line_number":23,"context_line":"\trefresh_interval\u003d2000"},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"mysql_variables\u003d"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"df7087c5_6cc3f1ee","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":1},"in_reply_to":"3fa0c359_063845eb","updated":"2018-03-08 17:44:55.000000000","message":"Done","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"72d2aa995029b7a9d777855bbaa66c4a623e5f21","unresolved":false,"context_lines":[{"line_number":30,"context_line":"\tdefault_query_delay\u003d0"},{"line_number":31,"context_line":"\tdefault_query_timeout\u003d20000"},{"line_number":32,"context_line":"\tpoll_timeout\u003d5000"},{"line_number":33,"context_line":"\tinterfaces\u003d\"0.0.0.0:3306\""},{"line_number":34,"context_line":"\tdefault_schema\u003d\"information_schema\""},{"line_number":35,"context_line":"\tstacksize\u003d1048576"},{"line_number":36,"context_line":"\tconnect_timeout_server\u003d10000"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3fa0c359_661ee970","line":33,"range":{"start_line":33,"start_character":21,"end_line":33,"end_character":25},"updated":"2018-02-27 06:37:19.000000000","message":"should this be controllable?","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":30,"context_line":"\tdefault_query_delay\u003d0"},{"line_number":31,"context_line":"\tdefault_query_timeout\u003d20000"},{"line_number":32,"context_line":"\tpoll_timeout\u003d5000"},{"line_number":33,"context_line":"\tinterfaces\u003d\"0.0.0.0:3306\""},{"line_number":34,"context_line":"\tdefault_schema\u003d\"information_schema\""},{"line_number":35,"context_line":"\tstacksize\u003d1048576"},{"line_number":36,"context_line":"\tconnect_timeout_server\u003d10000"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"df7087c5_572d5a93","line":33,"range":{"start_line":33,"start_character":21,"end_line":33,"end_character":25},"in_reply_to":"3fa0c359_661ee970","updated":"2018-03-08 17:44:55.000000000","message":"I am not sure about the implication after we change it from default to a separate port. Let me investigate it further.","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"e960f33f1fbf8593cb6eaf33f2f92f80bfe1023b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    monitor_ping_timeout\u003d1000"},{"line_number":82,"context_line":"    monitor_ping_max_failures\u003d3"},{"line_number":83,"context_line":"    monitor_replication_lag_interval\u003d10000"},{"line_number":84,"context_line":"    monitor_replication_lag_timeout\u003d1000 "},{"line_number":85,"context_line":"    monitor_history\u003d60000"},{"line_number":86,"context_line":"    multiplexing\u003d\"false\""},{"line_number":87,"context_line":"    commands_stats\u003dtrue"}],"source_content_type":"text/x-smarty","patch_set":14,"id":"bf659307_9410bcaa","line":84,"range":{"start_line":84,"start_character":40,"end_line":84,"end_character":41},"updated":"2018-04-08 15:44:12.000000000","message":"whitespace is causing the linter to fail","commit_id":"f3c7a2e7a74c3e4ce6263c7ae6914f81fd0620f7"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"b0ab66a3cfee1e92c41007e90e1269f5f8055ffc","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    monitor_ping_timeout\u003d1000"},{"line_number":82,"context_line":"    monitor_ping_max_failures\u003d3"},{"line_number":83,"context_line":"    monitor_replication_lag_interval\u003d10000"},{"line_number":84,"context_line":"    monitor_replication_lag_timeout\u003d1000 "},{"line_number":85,"context_line":"    monitor_history\u003d60000"},{"line_number":86,"context_line":"    multiplexing\u003d\"false\""},{"line_number":87,"context_line":"    commands_stats\u003dtrue"}],"source_content_type":"text/x-smarty","patch_set":14,"id":"bf659307_3be671ea","line":84,"range":{"start_line":84,"start_character":40,"end_line":84,"end_character":41},"in_reply_to":"bf659307_9410bcaa","updated":"2018-04-09 13:53:21.000000000","message":"Good catch! Will fix all of them. Thanks, Tin!","commit_id":"f3c7a2e7a74c3e4ce6263c7ae6914f81fd0620f7"}],"mariadb/templates/secrets-etc-proxysql.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"607bb2865388888cb588156f5a51f93957191e8a","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.proxy.proxysql }}"},{"line_number":18,"context_line":"{{- if .Values.manifests.secret_etc }}"},{"line_number":19,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":20,"context_line":"---"},{"line_number":21,"context_line":"apiVersion: v1"},{"line_number":22,"context_line":"kind: Secret"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa0c359_0606051d","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":19},"updated":"2018-02-27 04:39:33.000000000","message":"this is unused","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.proxy.proxysql }}"},{"line_number":18,"context_line":"{{- if .Values.manifests.secret_etc }}"},{"line_number":19,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":20,"context_line":"---"},{"line_number":21,"context_line":"apiVersion: v1"},{"line_number":22,"context_line":"kind: Secret"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df7087c5_570b1a8d","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":19},"in_reply_to":"3fa0c359_0606051d","updated":"2018-03-08 17:44:55.000000000","message":"Done","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"33b830761cf764e2cabcd294e1a37f2a41ea0124","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# credential to access proxysql admin port"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{{- if .Values.proxy.proxysql }}"},{"line_number":20,"context_line":"{{- if .Values.manifests.secret_etc }}"},{"line_number":21,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":22,"context_line":"---"},{"line_number":23,"context_line":"apiVersion: v1"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df7087c5_328eb427","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":38},"updated":"2018-03-20 06:22:41.000000000","message":"ditto","commit_id":"d2f5078da1eccdd595d9eb0f17a37e8b83d02af6"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"05ffc74b60f376e9d6df25809b86c21b207e9a18","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# credential to access proxysql admin port"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{{- if .Values.proxy.proxysql }}"},{"line_number":20,"context_line":"{{- if .Values.manifests.secret_etc }}"},{"line_number":21,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":22,"context_line":"---"},{"line_number":23,"context_line":"apiVersion: v1"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bf659307_0bd69850","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":38},"in_reply_to":"df7087c5_328eb427","updated":"2018-03-28 15:25:30.000000000","message":"Fixed it. Will be in the next ps.","commit_id":"d2f5078da1eccdd595d9eb0f17a37e8b83d02af6"}],"mariadb/templates/service-discovery-proxysql.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"33b830761cf764e2cabcd294e1a37f2a41ea0124","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# this service is used by other kubernetes services to identify proxysql pods"},{"line_number":18,"context_line":"# for example, to form proxysql cluster"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{- if .Values.proxy.proxysql }}"},{"line_number":21,"context_line":"{{- if .Values.manifests.service }}"},{"line_number":22,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":23,"context_line":"---"},{"line_number":24,"context_line":"apiVersion: v1"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df7087c5_9273004e","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":35},"updated":"2018-03-20 06:22:41.000000000","message":"can we combine them into 1 statement using and?","commit_id":"d2f5078da1eccdd595d9eb0f17a37e8b83d02af6"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"05ffc74b60f376e9d6df25809b86c21b207e9a18","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# this service is used by other kubernetes services to identify proxysql pods"},{"line_number":18,"context_line":"# for example, to form proxysql cluster"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"{{- if .Values.proxy.proxysql }}"},{"line_number":21,"context_line":"{{- if .Values.manifests.service }}"},{"line_number":22,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":23,"context_line":"---"},{"line_number":24,"context_line":"apiVersion: v1"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bf659307_8b462821","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":35},"in_reply_to":"df7087c5_9273004e","updated":"2018-03-28 15:25:30.000000000","message":"Yup! Will verify the other files too.","commit_id":"d2f5078da1eccdd595d9eb0f17a37e8b83d02af6"}],"mariadb/templates/service-proxysql.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"33b830761cf764e2cabcd294e1a37f2a41ea0124","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# This service is used for proxysql administration only"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{{- if .Values.proxy.proxysql }}"},{"line_number":20,"context_line":"{{- if .Values.manifests.service }}"},{"line_number":21,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":22,"context_line":"---"},{"line_number":23,"context_line":"apiVersion: v1"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df7087c5_52932850","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":35},"updated":"2018-03-20 06:22:41.000000000","message":"ditto","commit_id":"d2f5078da1eccdd595d9eb0f17a37e8b83d02af6"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"05ffc74b60f376e9d6df25809b86c21b207e9a18","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# This service is used for proxysql administration only"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{{- if .Values.proxy.proxysql }}"},{"line_number":20,"context_line":"{{- if .Values.manifests.service }}"},{"line_number":21,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":22,"context_line":"---"},{"line_number":23,"context_line":"apiVersion: v1"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bf659307_8bcb8870","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":35},"in_reply_to":"df7087c5_52932850","updated":"2018-03-28 15:25:30.000000000","message":"Fixed it! See change in the next ps","commit_id":"d2f5078da1eccdd595d9eb0f17a37e8b83d02af6"}],"mariadb/templates/statefulset-proxysql.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"72d2aa995029b7a9d777855bbaa66c4a623e5f21","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.proxy.proxysql }}"},{"line_number":18,"context_line":"{{- if .Values.manifests.statefulset }}"},{"line_number":19,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":20,"context_line":"{{- $dependencies :\u003d .Values.dependencies.proxysql }}"},{"line_number":21,"context_line":"{{- $MARIADB_CLUSTER :\u003d \"reader_hostgroup\" }}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa0c359_dc0f8d2d","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":39},"updated":"2018-02-27 06:37:19.000000000","message":"can be a single statement","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if .Values.proxy.proxysql }}"},{"line_number":18,"context_line":"{{- if .Values.manifests.statefulset }}"},{"line_number":19,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":20,"context_line":"{{- $dependencies :\u003d .Values.dependencies.proxysql }}"},{"line_number":21,"context_line":"{{- $MARIADB_CLUSTER :\u003d \"reader_hostgroup\" }}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df7087c5_5789da72","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":39},"in_reply_to":"3fa0c359_dc0f8d2d","updated":"2018-03-08 17:44:55.000000000","message":"Done","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"72d2aa995029b7a9d777855bbaa66c4a623e5f21","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{- if .Values.manifests.statefulset }}"},{"line_number":19,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":20,"context_line":"{{- $dependencies :\u003d .Values.dependencies.proxysql }}"},{"line_number":21,"context_line":"{{- $MARIADB_CLUSTER :\u003d \"reader_hostgroup\" }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{- $serviceAccountName :\u003d \"proxysql-sts\" }}"},{"line_number":24,"context_line":"{{ tuple $envAll $dependencies $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa0c359_3c0b1125","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":45},"updated":"2018-02-27 06:37:19.000000000","message":"required?","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{{- if .Values.manifests.statefulset }}"},{"line_number":19,"context_line":"{{- $envAll :\u003d . }}"},{"line_number":20,"context_line":"{{- $dependencies :\u003d .Values.dependencies.proxysql }}"},{"line_number":21,"context_line":"{{- $MARIADB_CLUSTER :\u003d \"reader_hostgroup\" }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{- $serviceAccountName :\u003d \"proxysql-sts\" }}"},{"line_number":24,"context_line":"{{ tuple $envAll $dependencies $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df7087c5_77bf3efb","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":45},"in_reply_to":"3fa0c359_3c0b1125","updated":"2018-03-08 17:44:55.000000000","message":"This one is used by proxysql_galera_checker.sh script.","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"607bb2865388888cb588156f5a51f93957191e8a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"{{- $dependencies :\u003d .Values.dependencies.proxysql }}"},{"line_number":21,"context_line":"{{- $MARIADB_CLUSTER :\u003d \"reader_hostgroup\" }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{- $serviceAccountName :\u003d \"proxysql-sts\" }}"},{"line_number":24,"context_line":"{{ tuple $envAll $dependencies $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":25,"context_line":"---"},{"line_number":26,"context_line":"apiVersion: apps/v1beta1"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa0c359_abffdcff","line":23,"range":{"start_line":23,"start_character":28,"end_line":23,"end_character":40},"updated":"2018-02-27 04:39:33.000000000","message":"should this be matching the metadata:name - proxysql?","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":20,"context_line":"{{- $dependencies :\u003d .Values.dependencies.proxysql }}"},{"line_number":21,"context_line":"{{- $MARIADB_CLUSTER :\u003d \"reader_hostgroup\" }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{- $serviceAccountName :\u003d \"proxysql-sts\" }}"},{"line_number":24,"context_line":"{{ tuple $envAll $dependencies $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":25,"context_line":"---"},{"line_number":26,"context_line":"apiVersion: apps/v1beta1"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df7087c5_373786b3","line":23,"range":{"start_line":23,"start_character":28,"end_line":23,"end_character":40},"in_reply_to":"3fa0c359_abffdcff","updated":"2018-03-08 17:44:55.000000000","message":"Done","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"df8088d2a232b3b93a2d118c9aa428d5ce78b90a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"{{- $dependencies :\u003d .Values.dependencies.proxysql }}"},{"line_number":23,"context_line":"{{- $MARIADB_CLUSTER :\u003d \"reader_hostgroup\" }}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{{- $serviceAccountName :\u003d \"proxysql-sts\" }}"},{"line_number":26,"context_line":"{{ tuple $envAll $dependencies $serviceAccountName | include \"helm-toolkit.snippets.kubernetes_pod_rbac_serviceaccount\" }}"},{"line_number":27,"context_line":"---"},{"line_number":28,"context_line":"apiVersion: apps/v1beta1"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df7087c5_1e0b8d8e","line":25,"range":{"start_line":25,"start_character":27,"end_line":25,"end_character":41},"updated":"2018-03-08 06:47:20.000000000","message":"see comment from previous patch set.","commit_id":"5dc75bcc416a393ee4fadcfdbdbf6872783e492c"}],"mariadb/values.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"7be09deecca4ddc1beeca86f49c4fc6267e76956","unresolved":false,"context_lines":[{"line_number":15,"context_line":"images:"},{"line_number":16,"context_line":"  tags:"},{"line_number":17,"context_line":"    mariadb: docker.io/mariadb:10.1.23"},{"line_number":18,"context_line":"    prometheus_create_mysql_user: docker.io/mariadb:10.1.23"},{"line_number":19,"context_line":"    prometheus_mysql_exporter: docker.io/prom/mysqld-exporter:v0.10.0"},{"line_number":20,"context_line":"    prometheus_mysql_exporter_helm_tests: docker.io/openstackhelm/heat:newton"},{"line_number":21,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.2.1"},{"line_number":22,"context_line":"  pull_policy: IfNotPresent"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa0c359_d6ea2f72","side":"PARENT","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":77},"updated":"2018-02-23 23:55:04.000000000","message":"Per Pete\u0027s comment on the other patch: \n\nwhy is monitoring being removed as part of this ps?","commit_id":"c20da4a62261d50663b1c25bf3cbd8cccbead798"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"3f9c66cdfa382c5cd2d872bb0b6262a9a38871d9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"images:"},{"line_number":16,"context_line":"  tags:"},{"line_number":17,"context_line":"    mariadb: docker.io/mariadb:10.1.23"},{"line_number":18,"context_line":"    prometheus_create_mysql_user: docker.io/mariadb:10.1.23"},{"line_number":19,"context_line":"    prometheus_mysql_exporter: docker.io/prom/mysqld-exporter:v0.10.0"},{"line_number":20,"context_line":"    prometheus_mysql_exporter_helm_tests: docker.io/openstackhelm/heat:newton"},{"line_number":21,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.2.1"},{"line_number":22,"context_line":"  pull_policy: IfNotPresent"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_109cfb0b","side":"PARENT","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":77},"updated":"2018-02-27 02:30:48.000000000","message":"we can\u0027t take these out.","commit_id":"62698f7ea7a106399ff8c7b8417c25d5193c2ef8"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"1a5de33c43f47ed3133553bcb9d8799ad45f2ec9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"images:"},{"line_number":16,"context_line":"  tags:"},{"line_number":17,"context_line":"    mariadb: docker.io/mariadb:10.1.23"},{"line_number":18,"context_line":"    prometheus_create_mysql_user: docker.io/mariadb:10.1.23"},{"line_number":19,"context_line":"    prometheus_mysql_exporter: docker.io/prom/mysqld-exporter:v0.10.0"},{"line_number":20,"context_line":"    prometheus_mysql_exporter_helm_tests: docker.io/openstackhelm/heat:newton"},{"line_number":21,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.2.1"},{"line_number":22,"context_line":"  pull_policy: IfNotPresent"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_b0518732","side":"PARENT","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":77},"in_reply_to":"3fa0c359_109cfb0b","updated":"2018-02-27 02:46:20.000000000","message":"Patch 4 should keep all of the structure including promethus and monitoring. However, I don\u0027t know why, but my local up-to-date values.yaml was NOT included in this patch.\n\nSee new patch 5.","commit_id":"62698f7ea7a106399ff8c7b8417c25d5193c2ef8"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":15,"context_line":"images:"},{"line_number":16,"context_line":"  tags:"},{"line_number":17,"context_line":"    mariadb: docker.io/mariadb:10.1.23"},{"line_number":18,"context_line":"    prometheus_create_mysql_user: docker.io/mariadb:10.1.23"},{"line_number":19,"context_line":"    prometheus_mysql_exporter: docker.io/prom/mysqld-exporter:v0.10.0"},{"line_number":20,"context_line":"    prometheus_mysql_exporter_helm_tests: docker.io/openstackhelm/heat:newton"},{"line_number":21,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.2.1"},{"line_number":22,"context_line":"  pull_policy: IfNotPresent"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_eb3c04c0","side":"PARENT","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":77},"in_reply_to":"3fa0c359_b0518732","updated":"2018-03-08 17:44:55.000000000","message":"Done","commit_id":"62698f7ea7a106399ff8c7b8417c25d5193c2ef8"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"3f9c66cdfa382c5cd2d872bb0b6262a9a38871d9","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  server:"},{"line_number":26,"context_line":"    node_selector_key: openstack-control-plane"},{"line_number":27,"context_line":"    node_selector_value: enabled"},{"line_number":28,"context_line":"  prometheus_mysql_exporter:"},{"line_number":29,"context_line":"    node_selector_key: openstack-control-plane"},{"line_number":30,"context_line":"    node_selector_value: enabled"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"pod:"},{"line_number":33,"context_line":"  affinity:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_309fb702","side":"PARENT","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":32},"updated":"2018-02-27 02:30:48.000000000","message":"ditto","commit_id":"62698f7ea7a106399ff8c7b8417c25d5193c2ef8"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"1a5de33c43f47ed3133553bcb9d8799ad45f2ec9","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  server:"},{"line_number":26,"context_line":"    node_selector_key: openstack-control-plane"},{"line_number":27,"context_line":"    node_selector_value: enabled"},{"line_number":28,"context_line":"  prometheus_mysql_exporter:"},{"line_number":29,"context_line":"    node_selector_key: openstack-control-plane"},{"line_number":30,"context_line":"    node_selector_value: enabled"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"pod:"},{"line_number":33,"context_line":"  affinity:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_70353ff6","side":"PARENT","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":32},"in_reply_to":"3fa0c359_309fb702","updated":"2018-02-27 02:46:20.000000000","message":"Yes, in my local commit, these sublevel was still here.\n\nSee new patch 5.","commit_id":"62698f7ea7a106399ff8c7b8417c25d5193c2ef8"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"3f9c66cdfa382c5cd2d872bb0b6262a9a38871d9","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        default: kubernetes.io/hostname"},{"line_number":39,"context_line":"  replicas:"},{"line_number":40,"context_line":"    server: 1"},{"line_number":41,"context_line":"    prometheus_mysql_exporter: 1"},{"line_number":42,"context_line":"  lifecycle:"},{"line_number":43,"context_line":"    upgrades:"},{"line_number":44,"context_line":"      deployments:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_50bfe35f","side":"PARENT","line":41,"range":{"start_line":41,"start_character":4,"end_line":41,"end_character":29},"updated":"2018-02-27 02:30:48.000000000","message":"can\u0027t remove these prometheus-related values.","commit_id":"62698f7ea7a106399ff8c7b8417c25d5193c2ef8"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"1a5de33c43f47ed3133553bcb9d8799ad45f2ec9","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        default: kubernetes.io/hostname"},{"line_number":39,"context_line":"  replicas:"},{"line_number":40,"context_line":"    server: 1"},{"line_number":41,"context_line":"    prometheus_mysql_exporter: 1"},{"line_number":42,"context_line":"  lifecycle:"},{"line_number":43,"context_line":"    upgrades:"},{"line_number":44,"context_line":"      deployments:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_10387beb","side":"PARENT","line":41,"range":{"start_line":41,"start_character":4,"end_line":41,"end_character":29},"in_reply_to":"3fa0c359_50bfe35f","updated":"2018-02-27 02:46:20.000000000","message":"Same as above. I must lose the change during git squash.\n\nSee new patch 5.","commit_id":"62698f7ea7a106399ff8c7b8417c25d5193c2ef8"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"3f9c66cdfa382c5cd2d872bb0b6262a9a38871d9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    server: 1"},{"line_number":41,"context_line":"    prometheus_mysql_exporter: 1"},{"line_number":42,"context_line":"  lifecycle:"},{"line_number":43,"context_line":"    upgrades:"},{"line_number":44,"context_line":"      deployments:"},{"line_number":45,"context_line":"        revision_history: 3"},{"line_number":46,"context_line":"        pod_replacement_strategy: RollingUpdate"},{"line_number":47,"context_line":"        rolling_update:"},{"line_number":48,"context_line":"          max_unavailable: 1"},{"line_number":49,"context_line":"          max_surge: 3"},{"line_number":50,"context_line":"    termination_grace_period:"},{"line_number":51,"context_line":"      prometheus_mysql_exporter:"},{"line_number":52,"context_line":"        timeout: 30"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_90a80b20","side":"PARENT","line":49,"range":{"start_line":43,"start_character":0,"end_line":49,"end_character":22},"updated":"2018-02-27 02:30:48.000000000","message":"we shouldn\u0027t remove this","commit_id":"62698f7ea7a106399ff8c7b8417c25d5193c2ef8"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"1a5de33c43f47ed3133553bcb9d8799ad45f2ec9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    server: 1"},{"line_number":41,"context_line":"    prometheus_mysql_exporter: 1"},{"line_number":42,"context_line":"  lifecycle:"},{"line_number":43,"context_line":"    upgrades:"},{"line_number":44,"context_line":"      deployments:"},{"line_number":45,"context_line":"        revision_history: 3"},{"line_number":46,"context_line":"        pod_replacement_strategy: RollingUpdate"},{"line_number":47,"context_line":"        rolling_update:"},{"line_number":48,"context_line":"          max_unavailable: 1"},{"line_number":49,"context_line":"          max_surge: 3"},{"line_number":50,"context_line":"    termination_grace_period:"},{"line_number":51,"context_line":"      prometheus_mysql_exporter:"},{"line_number":52,"context_line":"        timeout: 30"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_d02533c3","side":"PARENT","line":49,"range":{"start_line":43,"start_character":0,"end_line":49,"end_character":22},"in_reply_to":"3fa0c359_90a80b20","updated":"2018-02-27 02:46:20.000000000","message":"Same as above. I must lose the change during git squash.\n\nSee new patch 5.","commit_id":"62698f7ea7a106399ff8c7b8417c25d5193c2ef8"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"3f9c66cdfa382c5cd2d872bb0b6262a9a38871d9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        rolling_update:"},{"line_number":48,"context_line":"          max_unavailable: 1"},{"line_number":49,"context_line":"          max_surge: 3"},{"line_number":50,"context_line":"    termination_grace_period:"},{"line_number":51,"context_line":"      prometheus_mysql_exporter:"},{"line_number":52,"context_line":"        timeout: 30"},{"line_number":53,"context_line":"    disruption_budget:"},{"line_number":54,"context_line":"      mariadb:"},{"line_number":55,"context_line":"        min_available: 0"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_30b81773","side":"PARENT","line":52,"range":{"start_line":50,"start_character":0,"end_line":52,"end_character":19},"updated":"2018-02-27 02:30:48.000000000","message":"see above re: prometheus-related values","commit_id":"62698f7ea7a106399ff8c7b8417c25d5193c2ef8"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"1a5de33c43f47ed3133553bcb9d8799ad45f2ec9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        rolling_update:"},{"line_number":48,"context_line":"          max_unavailable: 1"},{"line_number":49,"context_line":"          max_surge: 3"},{"line_number":50,"context_line":"    termination_grace_period:"},{"line_number":51,"context_line":"      prometheus_mysql_exporter:"},{"line_number":52,"context_line":"        timeout: 30"},{"line_number":53,"context_line":"    disruption_budget:"},{"line_number":54,"context_line":"      mariadb:"},{"line_number":55,"context_line":"        min_available: 0"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_f0206fb2","side":"PARENT","line":52,"range":{"start_line":50,"start_character":0,"end_line":52,"end_character":19},"in_reply_to":"3fa0c359_30b81773","updated":"2018-02-27 02:46:20.000000000","message":"Same as above. I must lose the change during git squash.\n\nSee new patch 5.","commit_id":"62698f7ea7a106399ff8c7b8417c25d5193c2ef8"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"3f9c66cdfa382c5cd2d872bb0b6262a9a38871d9","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        min_available: 0"},{"line_number":56,"context_line":"  resources:"},{"line_number":57,"context_line":"    enabled: false"},{"line_number":58,"context_line":"    prometheus_mysql_exporter:"},{"line_number":59,"context_line":"      limits:"},{"line_number":60,"context_line":"        memory: \"1024Mi\""},{"line_number":61,"context_line":"        cpu: \"2000m\""},{"line_number":62,"context_line":"      requests:"},{"line_number":63,"context_line":"        memory: \"128Mi\""},{"line_number":64,"context_line":"        cpu: \"500m\""},{"line_number":65,"context_line":"    server:"},{"line_number":66,"context_line":"      requests:"},{"line_number":67,"context_line":"        memory: \"128Mi\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_10b5db7d","side":"PARENT","line":64,"range":{"start_line":58,"start_character":0,"end_line":64,"end_character":19},"updated":"2018-02-27 02:30:48.000000000","message":"see above re: prometheus-related values","commit_id":"62698f7ea7a106399ff8c7b8417c25d5193c2ef8"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"1a5de33c43f47ed3133553bcb9d8799ad45f2ec9","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        min_available: 0"},{"line_number":56,"context_line":"  resources:"},{"line_number":57,"context_line":"    enabled: false"},{"line_number":58,"context_line":"    prometheus_mysql_exporter:"},{"line_number":59,"context_line":"      limits:"},{"line_number":60,"context_line":"        memory: \"1024Mi\""},{"line_number":61,"context_line":"        cpu: \"2000m\""},{"line_number":62,"context_line":"      requests:"},{"line_number":63,"context_line":"        memory: \"128Mi\""},{"line_number":64,"context_line":"        cpu: \"500m\""},{"line_number":65,"context_line":"    server:"},{"line_number":66,"context_line":"      requests:"},{"line_number":67,"context_line":"        memory: \"128Mi\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_b02667ca","side":"PARENT","line":64,"range":{"start_line":58,"start_character":0,"end_line":64,"end_character":19},"in_reply_to":"3fa0c359_10b5db7d","updated":"2018-02-27 02:46:20.000000000","message":"Same as above. I must lose the change during git squash.\n\nSee new patch 5.","commit_id":"62698f7ea7a106399ff8c7b8417c25d5193c2ef8"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"3f9c66cdfa382c5cd2d872bb0b6262a9a38871d9","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  #   [mysqld]"},{"line_number":123,"context_line":"  #   wsrep_slave_threads\u003d1"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"monitoring:"},{"line_number":126,"context_line":"  prometheus:"},{"line_number":127,"context_line":"    enabled: false"},{"line_number":128,"context_line":"    mysqld_exporter:"},{"line_number":129,"context_line":"      scrape: true"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"network:"},{"line_number":132,"context_line":"  prometheus_mysql_exporter:"},{"line_number":133,"context_line":"    port: 9104"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"# typically overriden by environmental"},{"line_number":136,"context_line":"# values, but should include all endpoints"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_5064c321","side":"PARENT","line":133,"range":{"start_line":125,"start_character":0,"end_line":133,"end_character":14},"updated":"2018-02-27 02:30:48.000000000","message":"see above re: prometheus-related values","commit_id":"62698f7ea7a106399ff8c7b8417c25d5193c2ef8"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"1a5de33c43f47ed3133553bcb9d8799ad45f2ec9","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  #   [mysqld]"},{"line_number":123,"context_line":"  #   wsrep_slave_threads\u003d1"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"monitoring:"},{"line_number":126,"context_line":"  prometheus:"},{"line_number":127,"context_line":"    enabled: false"},{"line_number":128,"context_line":"    mysqld_exporter:"},{"line_number":129,"context_line":"      scrape: true"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"network:"},{"line_number":132,"context_line":"  prometheus_mysql_exporter:"},{"line_number":133,"context_line":"    port: 9104"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"# typically overriden by environmental"},{"line_number":136,"context_line":"# values, but should include all endpoints"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_501b637f","side":"PARENT","line":133,"range":{"start_line":125,"start_character":0,"end_line":133,"end_character":14},"in_reply_to":"3fa0c359_5064c321","updated":"2018-02-27 02:46:20.000000000","message":"Same as above. I must lose the change during git squash.\n\nSee new patch 5.","commit_id":"62698f7ea7a106399ff8c7b8417c25d5193c2ef8"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"3f9c66cdfa382c5cd2d872bb0b6262a9a38871d9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  pull_policy: IfNotPresent"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"labels:"},{"line_number":24,"context_line":"  node_selector_key: openstack-control-plane"},{"line_number":25,"context_line":"  node_selector_value: enabled"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"pod:"},{"line_number":28,"context_line":"  affinity:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_f084efb2","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":30},"updated":"2018-02-27 02:30:48.000000000","message":"The sub level structure is changed here.","commit_id":"5765b3fa52a5754fde55228d8c19aeb4edd6c459"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"1a5de33c43f47ed3133553bcb9d8799ad45f2ec9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  pull_policy: IfNotPresent"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"labels:"},{"line_number":24,"context_line":"  node_selector_key: openstack-control-plane"},{"line_number":25,"context_line":"  node_selector_value: enabled"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"pod:"},{"line_number":28,"context_line":"  affinity:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa0c359_f05b8f50","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":30},"in_reply_to":"3fa0c359_f084efb2","updated":"2018-02-27 02:46:20.000000000","message":"Patch 4 should keep all of the structure including promethus and monitoring. However, I don\u0027t know why, but my local up-to-date values.yaml was NOT included in this patch.\n\nSee new patch 5.","commit_id":"5765b3fa52a5754fde55228d8c19aeb4edd6c459"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"607bb2865388888cb588156f5a51f93957191e8a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"# You may obtain a copy of the License at"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#     http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"# Unless required by applicable law or agreed to in writing, software"},{"line_number":10,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":11,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":12,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"images:"},{"line_number":16,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa0c359_0654c5fc","side":"PARENT","line":13,"range":{"start_line":1,"start_character":0,"end_line":13,"end_character":32},"updated":"2018-02-27 04:39:33.000000000","message":"should retain this","commit_id":"62698f7ea7a106399ff8c7b8417c25d5193c2ef8"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"# You may obtain a copy of the License at"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#     http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"# Unless required by applicable law or agreed to in writing, software"},{"line_number":10,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":11,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":12,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"images:"},{"line_number":16,"context_line":"  tags:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df7087c5_77541ecb","side":"PARENT","line":13,"range":{"start_line":1,"start_character":0,"end_line":13,"end_character":32},"in_reply_to":"3fa0c359_0654c5fc","updated":"2018-03-08 17:44:55.000000000","message":"Done","commit_id":"62698f7ea7a106399ff8c7b8417c25d5193c2ef8"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"72d2aa995029b7a9d777855bbaa66c4a623e5f21","unresolved":false,"context_lines":[{"line_number":106,"context_line":"          service: prometheus_mysql_exporter"},{"line_number":107,"context_line":"        - endpoint: internal"},{"line_number":108,"context_line":"          service: monitoring"},{"line_number":109,"context_line":"  proxysql:"},{"line_number":110,"context_line":"    jobs: null"},{"line_number":111,"context_line":"    services:"},{"line_number":112,"context_line":"    - service: oslo_db"},{"line_number":113,"context_line":"      endpoint: discovery"},{"line_number":114,"context_line":"  proxysql_bootstrap:"},{"line_number":115,"context_line":"    jobs: null"},{"line_number":116,"context_line":"    services:"},{"line_number":117,"context_line":"    - service: proxysql"},{"line_number":118,"context_line":"      endpoint: internal"},{"line_number":119,"context_line":"  proxysql_nanny:"},{"line_number":120,"context_line":"    jobs:"},{"line_number":121,"context_line":"    - proxysql-bootstrap"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"force_bootstrap: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa0c359_bc164149","line":121,"range":{"start_line":109,"start_character":0,"end_line":121,"end_character":24},"updated":"2018-02-27 06:37:19.000000000","message":"should be indented to be under the `static` key","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":106,"context_line":"          service: prometheus_mysql_exporter"},{"line_number":107,"context_line":"        - endpoint: internal"},{"line_number":108,"context_line":"          service: monitoring"},{"line_number":109,"context_line":"  proxysql:"},{"line_number":110,"context_line":"    jobs: null"},{"line_number":111,"context_line":"    services:"},{"line_number":112,"context_line":"    - service: oslo_db"},{"line_number":113,"context_line":"      endpoint: discovery"},{"line_number":114,"context_line":"  proxysql_bootstrap:"},{"line_number":115,"context_line":"    jobs: null"},{"line_number":116,"context_line":"    services:"},{"line_number":117,"context_line":"    - service: proxysql"},{"line_number":118,"context_line":"      endpoint: internal"},{"line_number":119,"context_line":"  proxysql_nanny:"},{"line_number":120,"context_line":"    jobs:"},{"line_number":121,"context_line":"    - proxysql-bootstrap"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"force_bootstrap: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df7087c5_172da242","line":121,"range":{"start_line":109,"start_character":0,"end_line":121,"end_character":24},"in_reply_to":"3fa0c359_bc164149","updated":"2018-03-08 17:44:55.000000000","message":"Done","commit_id":"68452865bd464dad36939b4452ca331e0a361c77"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"df8088d2a232b3b93a2d118c9aa428d5ce78b90a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  tags:"},{"line_number":22,"context_line":"# proxysql v1.4.6 supports cluster mode"},{"line_number":23,"context_line":"    proxysql: docker.io/shshang/proxysql:v1.4.6"},{"line_number":24,"context_line":"    mariadb: docker.io/mariadb:10.1.23"},{"line_number":25,"context_line":"    prometheus_create_mysql_user: docker.io/mariadb:10.1.23"},{"line_number":26,"context_line":"    prometheus_mysql_exporter: docker.io/prom/mysqld-exporter:v0.10.0"},{"line_number":27,"context_line":"    prometheus_mysql_exporter_helm_tests: docker.io/openstackhelm/heat:newton"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df7087c5_5ea90579","line":24,"range":{"start_line":24,"start_character":31,"end_line":24,"end_character":38},"updated":"2018-03-08 06:47:20.000000000","message":"is there a reason why we change the mariaDB version here?","commit_id":"5dc75bcc416a393ee4fadcfdbdbf6872783e492c"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  tags:"},{"line_number":22,"context_line":"# proxysql v1.4.6 supports cluster mode"},{"line_number":23,"context_line":"    proxysql: docker.io/shshang/proxysql:v1.4.6"},{"line_number":24,"context_line":"    mariadb: docker.io/mariadb:10.1.23"},{"line_number":25,"context_line":"    prometheus_create_mysql_user: docker.io/mariadb:10.1.23"},{"line_number":26,"context_line":"    prometheus_mysql_exporter: docker.io/prom/mysqld-exporter:v0.10.0"},{"line_number":27,"context_line":"    prometheus_mysql_exporter_helm_tests: docker.io/openstackhelm/heat:newton"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df7087c5_a9a81b1f","line":24,"range":{"start_line":24,"start_character":31,"end_line":24,"end_character":38},"in_reply_to":"df7087c5_5ea90579","updated":"2018-03-08 17:44:55.000000000","message":"Done","commit_id":"5dc75bcc416a393ee4fadcfdbdbf6872783e492c"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"df8088d2a232b3b93a2d118c9aa428d5ce78b90a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# proxysql v1.4.6 supports cluster mode"},{"line_number":23,"context_line":"    proxysql: docker.io/shshang/proxysql:v1.4.6"},{"line_number":24,"context_line":"    mariadb: docker.io/mariadb:10.1.23"},{"line_number":25,"context_line":"    prometheus_create_mysql_user: docker.io/mariadb:10.1.23"},{"line_number":26,"context_line":"    prometheus_mysql_exporter: docker.io/prom/mysqld-exporter:v0.10.0"},{"line_number":27,"context_line":"    prometheus_mysql_exporter_helm_tests: docker.io/openstackhelm/heat:newton"},{"line_number":28,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.2.1"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df7087c5_1ebdcdb6","line":25,"range":{"start_line":25,"start_character":52,"end_line":25,"end_character":59},"updated":"2018-03-08 06:47:20.000000000","message":"ditto","commit_id":"5dc75bcc416a393ee4fadcfdbdbf6872783e492c"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":22,"context_line":"# proxysql v1.4.6 supports cluster mode"},{"line_number":23,"context_line":"    proxysql: docker.io/shshang/proxysql:v1.4.6"},{"line_number":24,"context_line":"    mariadb: docker.io/mariadb:10.1.23"},{"line_number":25,"context_line":"    prometheus_create_mysql_user: docker.io/mariadb:10.1.23"},{"line_number":26,"context_line":"    prometheus_mysql_exporter: docker.io/prom/mysqld-exporter:v0.10.0"},{"line_number":27,"context_line":"    prometheus_mysql_exporter_helm_tests: docker.io/openstackhelm/heat:newton"},{"line_number":28,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.2.1"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df7087c5_6968c3f4","line":25,"range":{"start_line":25,"start_character":52,"end_line":25,"end_character":59},"in_reply_to":"df7087c5_1ebdcdb6","updated":"2018-03-08 17:44:55.000000000","message":"Done","commit_id":"5dc75bcc416a393ee4fadcfdbdbf6872783e492c"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"df8088d2a232b3b93a2d118c9aa428d5ce78b90a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      topologyKey:"},{"line_number":48,"context_line":"        default: kubernetes.io/hostname"},{"line_number":49,"context_line":"  replicas:"},{"line_number":50,"context_line":"    server: 3"},{"line_number":51,"context_line":"    prometheus_mysql_exporter: 1"},{"line_number":52,"context_line":"    proxysql: 3"},{"line_number":53,"context_line":"  lifecycle:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df7087c5_fedc9919","line":50,"range":{"start_line":50,"start_character":12,"end_line":50,"end_character":13},"updated":"2018-03-08 06:47:20.000000000","message":"we may lower this back to 1, and up it to 3 for the multinode deployment.  I believe it was lowered to 1 because of resource constraint.","commit_id":"5dc75bcc416a393ee4fadcfdbdbf6872783e492c"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      topologyKey:"},{"line_number":48,"context_line":"        default: kubernetes.io/hostname"},{"line_number":49,"context_line":"  replicas:"},{"line_number":50,"context_line":"    server: 3"},{"line_number":51,"context_line":"    prometheus_mysql_exporter: 1"},{"line_number":52,"context_line":"    proxysql: 3"},{"line_number":53,"context_line":"  lifecycle:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df7087c5_0946e77d","line":50,"range":{"start_line":50,"start_character":12,"end_line":50,"end_character":13},"in_reply_to":"df7087c5_fedc9919","updated":"2018-03-08 17:44:55.000000000","message":"Done","commit_id":"5dc75bcc416a393ee4fadcfdbdbf6872783e492c"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"df8088d2a232b3b93a2d118c9aa428d5ce78b90a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    disruption_budget:"},{"line_number":65,"context_line":"      mariadb:"},{"line_number":66,"context_line":"        min_available: 0"},{"line_number":67,"context_line":"  resources:"},{"line_number":68,"context_line":"    enabled: false"},{"line_number":69,"context_line":"    prometheus_mysql_exporter:"},{"line_number":70,"context_line":"      limits:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df7087c5_bee621e8","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":12},"updated":"2018-03-08 06:47:20.000000000","message":"does the sqlproxy not have resource here?","commit_id":"5dc75bcc416a393ee4fadcfdbdbf6872783e492c"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    disruption_budget:"},{"line_number":65,"context_line":"      mariadb:"},{"line_number":66,"context_line":"        min_available: 0"},{"line_number":67,"context_line":"  resources:"},{"line_number":68,"context_line":"    enabled: false"},{"line_number":69,"context_line":"    prometheus_mysql_exporter:"},{"line_number":70,"context_line":"      limits:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df7087c5_a92b3b92","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":12},"in_reply_to":"df7087c5_bee621e8","updated":"2018-03-08 17:44:55.000000000","message":"I am not certain what resource we should give to proxysql at this moment. I think it may need further investigation.","commit_id":"5dc75bcc416a393ee4fadcfdbdbf6872783e492c"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"df8088d2a232b3b93a2d118c9aa428d5ce78b90a","unresolved":false,"context_lines":[{"line_number":262,"context_line":"  service_discovery: true"},{"line_number":263,"context_line":"  service: true"},{"line_number":264,"context_line":"  statefulset: true"},{"line_number":265,"context_line":"  job: true"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"proxy:"},{"line_number":268,"context_line":"  proxysql: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df7087c5_fe05797b","line":265,"range":{"start_line":265,"start_character":2,"end_line":265,"end_character":5},"updated":"2018-03-08 06:47:20.000000000","message":"nit: this control variable can probably be a bit more specific","commit_id":"5dc75bcc416a393ee4fadcfdbdbf6872783e492c"},{"author":{"_account_id":27787,"name":"Shixiong Shang","email":"sparkofwisdom@hotmail.com","username":"shshang"},"change_message_id":"31c54e9c09b70674a7e6220268efa32a38473803","unresolved":false,"context_lines":[{"line_number":262,"context_line":"  service_discovery: true"},{"line_number":263,"context_line":"  service: true"},{"line_number":264,"context_line":"  statefulset: true"},{"line_number":265,"context_line":"  job: true"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"proxy:"},{"line_number":268,"context_line":"  proxysql: true"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"df7087c5_4cff0d01","line":265,"range":{"start_line":265,"start_character":2,"end_line":265,"end_character":5},"in_reply_to":"df7087c5_fe05797b","updated":"2018-03-08 17:44:55.000000000","message":"OK, I will remove this and the corresponding check","commit_id":"5dc75bcc416a393ee4fadcfdbdbf6872783e492c"}]}