)]}'
{"neutron/templates/bin/_neutron-sriov-agent-init.sh.tpl":[{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"90fa7f4e27bcf666387ef5d286b664c8fa50c2c7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"set -ex"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"exit 0"}],"source_content_type":"text/x-smarty","patch_set":20,"id":"1f9dbf25_8fe68ee8","line":19,"updated":"2018-02-28 16:01:45.000000000","message":"We should support doing thing such as promiscuous mode options and enabling the VFS\u0027 subinterfaces here.  To me, this is equivalent to the interface plumbing we enable (or should) during OVS init and Linux bridge.\n\nI believe it would be reasonable for the patchset to make this potentially arbitrary for now, filling refining this more with future patchsets.\n\nExamples can be as varied as:\n\n  $ echo 32 \u003e /sys/class/net/device name/device/sriov_numvfs\n\n  # persist at boot\n  $ cat /etc/modprobe.d/i40e.conf\n  $ options i40e max_vfs\u003d4,4\n\n  $ insmod ....\n\n  # set trust mode\n  # To set a VF as trusted or untrusted, enter the following command in the Hypervisor:\n  $ ip link set dev eth0 vf 1 trust [on|off]\n\n  # enable promiscuous mode\n  $ ip link set eth2 promisc on\n  $ ethtool -set-priv-flags p261p1 vf-true-promisc-support on\n\nI believe all of this points toward arbitrary init declarations until we know more.","commit_id":"61779674b11ca8836c55e4706d77f50f77e369ba"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"2c8b18515e728c6128b75c3642f7636379d6743a","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{- range $k, $sriov :\u003d .Values.network.interface.sriov }}"},{"line_number":22,"context_line":"if [ \"x{{ $sriov.num_vfs }}\" !\u003d \"x\" ]; then"},{"line_number":23,"context_line":"  echo \"{{ $sriov.num_vfs }}\" \u003e /sys/class/net/{{ $sriov.device }}/device/sriov_numvfs"},{"line_number":24,"context_line":"else"},{"line_number":25,"context_line":"  NUM_VFS\u003d$(cat /sys/class/net/{{ $sriov.device }}/device/sriov_totalvfs)"},{"line_number":26,"context_line":"  echo \"${NUM_VFS}\" \u003e /sys/class/net/{{ $sriov.device }}/device/sriov_numvfs"},{"line_number":27,"context_line":"fi"},{"line_number":28,"context_line":"ip link set {{ $sriov.device }} up"},{"line_number":29,"context_line":"ip link show {{ $sriov.device }}"}],"source_content_type":"text/x-smarty","patch_set":34,"id":"df7087c5_b15b6652","line":26,"range":{"start_line":23,"start_character":21,"end_line":26,"end_character":30},"updated":"2018-03-12 15:16:01.000000000","message":"I think it is better to always write \u00270\u0027 to sriov_numvfs first, in case the chart/override value changes, otherwise the update would fail.\n\necho \"0\" \u003e /sys/class/net/{{ $sriov.device }}/device/sriov_numvfs","commit_id":"4db865ece1ef124683fc7153637bdc2b6f6f5a49"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"2c8b18515e728c6128b75c3642f7636379d6743a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"fi"},{"line_number":28,"context_line":"ip link set {{ $sriov.device }} up"},{"line_number":29,"context_line":"ip link show {{ $sriov.device }}"},{"line_number":30,"context_line":"{{- if $sriov.promisc }}"},{"line_number":31,"context_line":"ethtool --set-priv-flags {{ $sriov.device }} vf-true-promisc-support on"},{"line_number":32,"context_line":"{{- end }}"},{"line_number":33,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":34,"id":"df7087c5_b46594e3","line":31,"range":{"start_line":30,"start_character":24,"end_line":31,"end_character":44},"updated":"2018-03-12 15:16:01.000000000","message":"Actually same question for all the operations here, is there a need to verify all the settings are what we set it to be?  or this is more of a best-effort?","commit_id":"4db865ece1ef124683fc7153637bdc2b6f6f5a49"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"064d1f43785540f928ae5fbdf3e422b255c99e9a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"ip link set {{ $sriov.device }} up"},{"line_number":29,"context_line":"ip link show {{ $sriov.device }}"},{"line_number":30,"context_line":"{{- if $sriov.promisc }}"},{"line_number":31,"context_line":"ethtool --set-priv-flags {{ $sriov.device }} vf-true-promisc-support on"},{"line_number":32,"context_line":"{{- end }}"},{"line_number":33,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":37,"id":"df7087c5_e5dd6a70","line":31,"range":{"start_line":31,"start_character":13,"end_line":31,"end_character":20},"updated":"2018-03-13 21:01:52.000000000","message":"btw... this only works with ethtool version 4.18 or above, the current ethtool version in your neutron image is 4.15, which will cause a failure if we try to enable promiscous mode.","commit_id":"1d17f00c9fc5f3572a74defd2af7afe138dec7b5"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"5f590439f5969b9f6a964cb1ebdc3747bce0627d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"ip link set {{ $sriov.device }} up"},{"line_number":29,"context_line":"ip link show {{ $sriov.device }}"},{"line_number":30,"context_line":"{{- if $sriov.promisc }}"},{"line_number":31,"context_line":"ethtool --set-priv-flags {{ $sriov.device }} vf-true-promisc-support on"},{"line_number":32,"context_line":"{{- end }}"},{"line_number":33,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":37,"id":"df7087c5_a790c444","line":31,"range":{"start_line":31,"start_character":13,"end_line":31,"end_character":20},"in_reply_to":"df7087c5_2e11fa04","updated":"2018-03-14 13:49:33.000000000","message":"4.15 \u003e 4.8 though - why can we not just use this one?","commit_id":"1d17f00c9fc5f3572a74defd2af7afe138dec7b5"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"767766d63849a490b7995ae86341bacf7c653633","unresolved":false,"context_lines":[{"line_number":28,"context_line":"ip link set {{ $sriov.device }} up"},{"line_number":29,"context_line":"ip link show {{ $sriov.device }}"},{"line_number":30,"context_line":"{{- if $sriov.promisc }}"},{"line_number":31,"context_line":"ethtool --set-priv-flags {{ $sriov.device }} vf-true-promisc-support on"},{"line_number":32,"context_line":"{{- end }}"},{"line_number":33,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":37,"id":"df7087c5_6d9ccb0d","line":31,"range":{"start_line":31,"start_character":13,"end_line":31,"end_character":20},"in_reply_to":"df7087c5_a790c444","updated":"2018-03-14 15:01:58.000000000","message":"sorry, I think I got confused with all the 5s and 8s.   I think Munish tested with version 4.8 only, I am not sure if it is supported in 4.15.  Let\u0027s use version 4.8.  Sorry about the mis-communication.","commit_id":"1d17f00c9fc5f3572a74defd2af7afe138dec7b5"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"e558a912e68b719d2090c3a1cca56c1c76927a3b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"ip link set {{ $sriov.device }} up"},{"line_number":29,"context_line":"ip link show {{ $sriov.device }}"},{"line_number":30,"context_line":"{{- if $sriov.promisc }}"},{"line_number":31,"context_line":"ethtool --set-priv-flags {{ $sriov.device }} vf-true-promisc-support on"},{"line_number":32,"context_line":"{{- end }}"},{"line_number":33,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":37,"id":"df7087c5_2e11fa04","line":31,"range":{"start_line":31,"start_character":13,"end_line":31,"end_character":20},"in_reply_to":"df7087c5_dfe02f29","updated":"2018-03-14 04:54:07.000000000","message":"You can download it from here: https://packages.ubuntu.com/search?keywords\u003dethtool\n\nor from ubuntu archive:\n$ sudo apt-cache policy ethtool\nethtool:\n  Installed: 1:4.8-1\n  Candidate: 1:4.8-1\n  Version table:\n *** 1:4.8-1 500\n        500 http://nova.clouds.archive.ubuntu.com/ubuntu artful/main amd64 Packages\n        100 /var/lib/dpkg/status\n     1:4.5-1 500\n        500 http://nova.clouds.archive.ubuntu.com/ubuntu xenial/main amd64 Packages","commit_id":"1d17f00c9fc5f3572a74defd2af7afe138dec7b5"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"1843ee208e64c5fbd4df488d7dd66d4224504719","unresolved":false,"context_lines":[{"line_number":28,"context_line":"ip link set {{ $sriov.device }} up"},{"line_number":29,"context_line":"ip link show {{ $sriov.device }}"},{"line_number":30,"context_line":"{{- if $sriov.promisc }}"},{"line_number":31,"context_line":"ethtool --set-priv-flags {{ $sriov.device }} vf-true-promisc-support on"},{"line_number":32,"context_line":"{{- end }}"},{"line_number":33,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":37,"id":"df7087c5_dfe02f29","line":31,"range":{"start_line":31,"start_character":13,"end_line":31,"end_character":20},"in_reply_to":"df7087c5_e5dd6a70","updated":"2018-03-14 00:54:54.000000000","message":"where can we get 4.18?\nhttps://mirrors.edge.kernel.org/pub/software/network/ethtool/ - it looks like 4.18 has not been released?","commit_id":"1d17f00c9fc5f3572a74defd2af7afe138dec7b5"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"e558a912e68b719d2090c3a1cca56c1c76927a3b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"{{- range $k, $sriov :\u003d .Values.network.interface.sriov }}"},{"line_number":22,"context_line":"if [ \"x{{ $sriov.num_vfs }}\" !\u003d \"x\" ]; then"},{"line_number":23,"context_line":"  echo \"{{ $sriov.num_vfs }}\" \u003e /sys/class/net/{{ $sriov.device }}/device/sriov_numvfs"},{"line_number":24,"context_line":"else"},{"line_number":25,"context_line":"  NUM_VFS\u003d$(cat /sys/class/net/{{ $sriov.device }}/device/sriov_totalvfs)"},{"line_number":26,"context_line":"  echo \"${NUM_VFS}\" \u003e /sys/class/net/{{ $sriov.device }}/device/sriov_numvfs"},{"line_number":27,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":41,"id":"df7087c5_31595f34","line":24,"updated":"2018-03-14 04:54:07.000000000","message":"I am going to stick a comment here again to say we should always echo \u00270\u0027 to reset it first, then echo sriov.num_vfs to .../device/sriov_numvfs.... otherwise you won\u0027t be able to update this if the existing value is non-zero.","commit_id":"1f57e95ac13a9345c50c4c73e87543ad27d8bb58"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"5f590439f5969b9f6a964cb1ebdc3747bce0627d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"{{- range $k, $sriov :\u003d .Values.network.interface.sriov }}"},{"line_number":22,"context_line":"if [ \"x{{ $sriov.num_vfs }}\" !\u003d \"x\" ]; then"},{"line_number":23,"context_line":"  echo \"{{ $sriov.num_vfs }}\" \u003e /sys/class/net/{{ $sriov.device }}/device/sriov_numvfs"},{"line_number":24,"context_line":"else"},{"line_number":25,"context_line":"  NUM_VFS\u003d$(cat /sys/class/net/{{ $sriov.device }}/device/sriov_totalvfs)"},{"line_number":26,"context_line":"  echo \"${NUM_VFS}\" \u003e /sys/class/net/{{ $sriov.device }}/device/sriov_numvfs"},{"line_number":27,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":41,"id":"df7087c5_47a1a893","line":24,"in_reply_to":"df7087c5_31595f34","updated":"2018-03-14 13:49:33.000000000","message":"we should def not be doing that - if we remove all vf\u0027s on pod startup then we will make things really unhappy if any are in use.","commit_id":"1f57e95ac13a9345c50c4c73e87543ad27d8bb58"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"767766d63849a490b7995ae86341bacf7c653633","unresolved":false,"context_lines":[{"line_number":21,"context_line":"{{- range $k, $sriov :\u003d .Values.network.interface.sriov }}"},{"line_number":22,"context_line":"if [ \"x{{ $sriov.num_vfs }}\" !\u003d \"x\" ]; then"},{"line_number":23,"context_line":"  echo \"{{ $sriov.num_vfs }}\" \u003e /sys/class/net/{{ $sriov.device }}/device/sriov_numvfs"},{"line_number":24,"context_line":"else"},{"line_number":25,"context_line":"  NUM_VFS\u003d$(cat /sys/class/net/{{ $sriov.device }}/device/sriov_totalvfs)"},{"line_number":26,"context_line":"  echo \"${NUM_VFS}\" \u003e /sys/class/net/{{ $sriov.device }}/device/sriov_numvfs"},{"line_number":27,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":41,"id":"df7087c5_2dd25301","line":24,"in_reply_to":"df7087c5_47a1a893","updated":"2018-03-14 15:01:58.000000000","message":"I do agree with that statement, but the downside is, the value can never be changed again the way it stands.  Which may be what we want, perhaps we should add some comment to explain that I guess.","commit_id":"1f57e95ac13a9345c50c4c73e87543ad27d8bb58"}],"neutron/values.yaml":[{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"90fa7f4e27bcf666387ef5d286b664c8fa50c2c7","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"network:"},{"line_number":78,"context_line":"  # provide what type of network wiring will be used"},{"line_number":79,"context_line":"  # possible options: openvswitch, linuxbridge, sriov"},{"line_number":80,"context_line":"  backend:"},{"line_number":81,"context_line":"    - openvswitch"},{"line_number":82,"context_line":"  external_bridge: br-ex"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"1f9dbf25_8f344e4c","line":79,"updated":"2018-02-28 16:01:45.000000000","message":"Should we note some of these can be mixed (e.g. [openvswitch, sriov] but not [openvswitch, linuxbridge]?","commit_id":"61779674b11ca8836c55e4706d77f50f77e369ba"}],"nova/values.yaml":[{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"90fa7f4e27bcf666387ef5d286b664c8fa50c2c7","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            vcpus: 8"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"network:"},{"line_number":128,"context_line":"  # provide what type of network wiring will be used"},{"line_number":129,"context_line":"  # possible options: openvswitch, linuxbridge, sriov"},{"line_number":130,"context_line":"  backend:"},{"line_number":131,"context_line":"    - openvswitch"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"1f9dbf25_2f73ba17","line":128,"updated":"2018-02-28 16:01:45.000000000","message":"Same","commit_id":"61779674b11ca8836c55e4706d77f50f77e369ba"}],"tools/deployment/developer/ceph/160-compute-kit-sr-iov.sh":[{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"fbc018168a7314f6fd3a8a2a7b1e8d59559d187d","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"DEV\u003denp3s0f1"},{"line_number":23,"context_line":"sudo sh -c \"echo \u00270\u0027 \u003e /sys/class/net/${DEV}/device/sriov_numvfs\""},{"line_number":24,"context_line":"VFS\u003d$(sudo cat /sys/class/net/${DEV}/device/sriov_totalvfs)"},{"line_number":25,"context_line":"sudo sh -c \"echo \\\"${VFS}\\\" \u003e /sys/class/net/${DEV}/device/sriov_numvfs\""},{"line_number":26,"context_line":"sudo ip link set ${DEV} up"},{"line_number":27,"context_line":"sudo ip link show ${DEV}"}],"source_content_type":"text/x-sh","patch_set":20,"id":"1f9dbf25_fecb341b","line":24,"updated":"2018-03-01 10:57:34.000000000","message":"Why are we doing this here and not allowing arbitrary commands (for now) in the init script?\n\nThis would not work in a production environment where there is another orchestration layer prior to helm.","commit_id":"61779674b11ca8836c55e4706d77f50f77e369ba"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"e22d43e79f014cd5d35e82b3378adb1021837fd8","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"DEV\u003denp3s0f1"},{"line_number":23,"context_line":"sudo sh -c \"echo \u00270\u0027 \u003e /sys/class/net/${DEV}/device/sriov_numvfs\""},{"line_number":24,"context_line":"VFS\u003d$(sudo cat /sys/class/net/${DEV}/device/sriov_totalvfs)"},{"line_number":25,"context_line":"sudo sh -c \"echo \\\"${VFS}\\\" \u003e /sys/class/net/${DEV}/device/sriov_numvfs\""},{"line_number":26,"context_line":"sudo ip link set ${DEV} up"},{"line_number":27,"context_line":"sudo ip link show ${DEV}"}],"source_content_type":"text/x-sh","patch_set":20,"id":"df7087c5_b685cfaf","line":24,"in_reply_to":"1f9dbf25_fecb341b","updated":"2018-03-09 04:46:42.000000000","message":"WIP dude ;)","commit_id":"61779674b11ca8836c55e4706d77f50f77e369ba"},{"author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"change_message_id":"90fa7f4e27bcf666387ef5d286b664c8fa50c2c7","unresolved":false,"context_lines":[{"line_number":30,"context_line":": ${OSH_EXTRA_HELM_ARGS:\u003d\"\"}"},{"line_number":31,"context_line":"tee /tmp/nova.yaml \u003c\u003c EOF"},{"line_number":32,"context_line":"network:"},{"line_number":33,"context_line":"  backend: sriov"},{"line_number":34,"context_line":"conf:"},{"line_number":35,"context_line":"  nova:"},{"line_number":36,"context_line":"    DEFAULT:"}],"source_content_type":"text/x-sh","patch_set":20,"id":"1f9dbf25_2f4c1ac6","line":33,"updated":"2018-02-28 16:01:45.000000000","message":"[sriov] ?","commit_id":"61779674b11ca8836c55e4706d77f50f77e369ba"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"e22d43e79f014cd5d35e82b3378adb1021837fd8","unresolved":false,"context_lines":[{"line_number":30,"context_line":": ${OSH_EXTRA_HELM_ARGS:\u003d\"\"}"},{"line_number":31,"context_line":"tee /tmp/nova.yaml \u003c\u003c EOF"},{"line_number":32,"context_line":"network:"},{"line_number":33,"context_line":"  backend: sriov"},{"line_number":34,"context_line":"conf:"},{"line_number":35,"context_line":"  nova:"},{"line_number":36,"context_line":"    DEFAULT:"}],"source_content_type":"text/x-sh","patch_set":20,"id":"1f9dbf25_20742935","line":33,"in_reply_to":"1f9dbf25_2f4c1ac6","updated":"2018-03-09 04:46:42.000000000","message":"it actually takes a sting or a list, but should be:\n```\nnetwork:\n  backend:\n   - openvswitch\n   - sriov\n```","commit_id":"61779674b11ca8836c55e4706d77f50f77e369ba"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"ad5489879ddd37113ca84adbc7026b4865090d88","unresolved":false,"context_lines":[{"line_number":29,"context_line":"conf:"},{"line_number":30,"context_line":"  nova:"},{"line_number":31,"context_line":"    DEFAULT:"},{"line_number":32,"context_line":"      pci_passthrough_whitelist: |"},{"line_number":33,"context_line":"        { \"devname\": \"${DEV}\", \"physical_network\": \"physnet1\" }"},{"line_number":34,"context_line":"      scheduler_default_filters: \"RetryFilter, AvailabilityZoneFilter, RamFilter, ComputeFilter, ComputeCapabilitiesFilter, ImagePropertiesFilter, ServerGroupAntiAffinityFilter, ServerGroupAffinityFilter, PciPassthroughFilter\""},{"line_number":35,"context_line":"EOF"},{"line_number":36,"context_line":"if [ \"x$(systemd-detect-virt)\" \u003d\u003d \"xnone\" ]; then"},{"line_number":37,"context_line":"  echo \u0027OSH is not being deployed in virtualized environment\u0027"}],"source_content_type":"text/x-sh","patch_set":32,"id":"df7087c5_f5cfaa7c","line":34,"range":{"start_line":32,"start_character":13,"end_line":34,"end_character":12},"updated":"2018-03-09 22:53:05.000000000","message":"Please refer to new pci setting for ocata in etherpad","commit_id":"a2135af0ace34efddab35083e0263587ddb96610"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"ad5489879ddd37113ca84adbc7026b4865090d88","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    tunnel: docker0"},{"line_number":59,"context_line":"    sriov: null"},{"line_number":60,"context_line":"  auto_bridge_add:"},{"line_number":61,"context_line":"    br-physnet1: ${DEV}"},{"line_number":62,"context_line":"  sriov:"},{"line_number":63,"context_line":"    - device: ${DEV}"},{"line_number":64,"context_line":"      num_vfs: 8"},{"line_number":65,"context_line":"conf:"},{"line_number":66,"context_line":"  neutron:"}],"source_content_type":"text/x-sh","patch_set":32,"id":"df7087c5_35b682fc","line":63,"range":{"start_line":61,"start_character":8,"end_line":63,"end_character":20},"updated":"2018-03-09 22:53:05.000000000","message":"I think it is better for sriov and ovs to setup shop on different physnet/interfaces","commit_id":"a2135af0ace34efddab35083e0263587ddb96610"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"b1ce98949b5c6295e90acb797769f2ee926d4266","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    tunnel: docker0"},{"line_number":59,"context_line":"    sriov: null"},{"line_number":60,"context_line":"  auto_bridge_add:"},{"line_number":61,"context_line":"    br-physnet1: ${DEV}"},{"line_number":62,"context_line":"  sriov:"},{"line_number":63,"context_line":"    - device: ${DEV}"},{"line_number":64,"context_line":"      num_vfs: 8"},{"line_number":65,"context_line":"conf:"},{"line_number":66,"context_line":"  neutron:"}],"source_content_type":"text/x-sh","patch_set":32,"id":"df7087c5_b17cddeb","line":63,"range":{"start_line":61,"start_character":8,"end_line":63,"end_character":20},"in_reply_to":"df7087c5_35b682fc","updated":"2018-03-10 20:00:16.000000000","message":"this is just for testing","commit_id":"a2135af0ace34efddab35083e0263587ddb96610"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"e558a912e68b719d2090c3a1cca56c1c76927a3b","unresolved":false,"context_lines":[{"line_number":27,"context_line":": ${OSH_EXTRA_HELM_ARGS:\u003d\"\"}"},{"line_number":28,"context_line":"tee /tmp/nova.yaml \u003c\u003c EOF"},{"line_number":29,"context_line":"network:"},{"line_number":30,"context_line":"  backend: sriov"},{"line_number":31,"context_line":"conf:"},{"line_number":32,"context_line":"  nova:"},{"line_number":33,"context_line":"    DEFAULT:"}],"source_content_type":"text/x-sh","patch_set":37,"id":"df7087c5_6e34d293","line":30,"range":{"start_line":30,"start_character":8,"end_line":30,"end_character":13},"updated":"2018-03-14 04:54:07.000000000","message":"oh we no longer need openswitch?  that\u0027s cool","commit_id":"1d17f00c9fc5f3572a74defd2af7afe138dec7b5"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"767766d63849a490b7995ae86341bacf7c653633","unresolved":false,"context_lines":[{"line_number":27,"context_line":": ${OSH_EXTRA_HELM_ARGS:\u003d\"\"}"},{"line_number":28,"context_line":"tee /tmp/nova.yaml \u003c\u003c EOF"},{"line_number":29,"context_line":"network:"},{"line_number":30,"context_line":"  backend: sriov"},{"line_number":31,"context_line":"conf:"},{"line_number":32,"context_line":"  nova:"},{"line_number":33,"context_line":"    DEFAULT:"}],"source_content_type":"text/x-sh","patch_set":37,"id":"df7087c5_6d0b6b7c","line":30,"range":{"start_line":30,"start_character":8,"end_line":30,"end_character":13},"in_reply_to":"df7087c5_67814cfb","updated":"2018-03-14 15:01:58.000000000","message":"Oops... my bad.  We must have removed it before because it was causing problem with both ovs and sriov using the same device.","commit_id":"1d17f00c9fc5f3572a74defd2af7afe138dec7b5"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"5f590439f5969b9f6a964cb1ebdc3747bce0627d","unresolved":false,"context_lines":[{"line_number":27,"context_line":": ${OSH_EXTRA_HELM_ARGS:\u003d\"\"}"},{"line_number":28,"context_line":"tee /tmp/nova.yaml \u003c\u003c EOF"},{"line_number":29,"context_line":"network:"},{"line_number":30,"context_line":"  backend: sriov"},{"line_number":31,"context_line":"conf:"},{"line_number":32,"context_line":"  nova:"},{"line_number":33,"context_line":"    DEFAULT:"}],"source_content_type":"text/x-sh","patch_set":37,"id":"df7087c5_67814cfb","line":30,"range":{"start_line":30,"start_character":8,"end_line":30,"end_character":13},"in_reply_to":"df7087c5_6e34d293","updated":"2018-03-14 13:49:33.000000000","message":"this was copied from your notes :) I think we do need it.","commit_id":"1d17f00c9fc5f3572a74defd2af7afe138dec7b5"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"064d1f43785540f928ae5fbdf3e422b255c99e9a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        [{\"address\": \"0000:03:10.0\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:10.2\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:10.4\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:10.6\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:11.0\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:11.2\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:11.4\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:11.6\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:12.0\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:12.2\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:12.4\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:12.6\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:13.0\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:13.2\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:13.4\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:13.6\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:14.0\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:14.2\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:14.4\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:14.6\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:15.0\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:15.2\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:15.4\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:15.6\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:16.0\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:16.2\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:16.4\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:16.6\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:17.0\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:17.2\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:17.4\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:17.6\", \"physical_network\": \"physnet1\"}, {\"address\": \"0000:03:10.1\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:10.3\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:10.5\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:10.7\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:11.1\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:11.3\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:11.5\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:11.7\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:12.1\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:12.3\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:12.5\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:12.7\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:13.1\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:13.3\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:13.5\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:13.7\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:14.1\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:14.3\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:14.5\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:14.7\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:15.1\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:15.3\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:15.5\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:15.7\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:16.1\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:16.3\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:16.5\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:16.7\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:17.1\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:17.3\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:17.5\", \"physical_network\": \"physnet2\"}, {\"address\": \"0000:03:17.7\", \"physical_network\": \"physnet2\"}]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    filter_scheduler:"},{"line_number":42,"context_line":"      enabled_filters: \"RetryFilter, AvailabilityZoneFilter, RamFilter, ComputeFilter, ComputeCapabilitiesFilter, ImagePropertiesFilter, ServerGroupAntiAffinityFilter, ServerGroupAffinityFilter, PciPassthroughFilter, NUMATopologyFilter\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"EOF"},{"line_number":45,"context_line":"if [ \"x$(systemd-detect-virt)\" \u003d\u003d \"xnone\" ]; then"}],"source_content_type":"text/x-sh","patch_set":37,"id":"df7087c5_c8987b76","line":42,"range":{"start_line":42,"start_character":49,"end_line":42,"end_character":52},"updated":"2018-03-13 21:01:52.000000000","message":"please note new changes in etherpad  :)","commit_id":"1d17f00c9fc5f3572a74defd2af7afe138dec7b5"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"064d1f43785540f928ae5fbdf3e422b255c99e9a","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        tenant_network_types: vxlan"},{"line_number":95,"context_line":"      ml2_type_vlan:"},{"line_number":96,"context_line":"        network_vlan_ranges: physnet1:20:30"},{"line_number":97,"context_line":"        network_vlan_ranges: physnet2:20:30"},{"line_number":98,"context_line":"    #NOTE(portdirect): for clarity we include options for all the neutron"},{"line_number":99,"context_line":"    # backends here."},{"line_number":100,"context_line":"    openvswitch_agent:"}],"source_content_type":"text/x-sh","patch_set":37,"id":"df7087c5_e87e9f17","line":97,"range":{"start_line":97,"start_character":29,"end_line":97,"end_character":37},"updated":"2018-03-13 21:01:52.000000000","message":"I mess up here, should be \n\nnetwork_vlan_ranges: physnet1:20:30,physnet2:20:30","commit_id":"1d17f00c9fc5f3572a74defd2af7afe138dec7b5"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"e558a912e68b719d2090c3a1cca56c1c76927a3b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2017 The Openstack-Helm Authors."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-sh","patch_set":41,"id":"df7087c5_3124ffae","line":1,"updated":"2018-03-14 04:54:07.000000000","message":"please update permission on this shell script, currently it is set 664 only, need it to be 775.  Thanks.","commit_id":"1f57e95ac13a9345c50c4c73e87543ad27d8bb58"}],"tools/deployment/developer/common/900-use-it-sr-iov.sh":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"e22d43e79f014cd5d35e82b3378adb1021837fd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"df7087c5_d69e4306","updated":"2018-03-09 04:46:42.000000000","message":"these are really just rough notes - I\u0027d ignore them","commit_id":"eb26b8b643d040aa661b69f5b2993b91abb1556e"}]}