)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"a2e86fd7a8f49670d2df9d2863de8315e1e4fa73","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-03-20 06:55:15 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implements deploying Nova with pre-configured flavors"},{"line_number":8,"context_line":"US390534, US390532, US390524"},{"line_number":9,"context_line":"Change-Id: I99795955e235cbb8d42c3c518abfe6a94549a69d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df7087c5_24dc2473","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":28},"updated":"2018-03-20 13:59:05.000000000","message":"nit: line break after the first subject line","commit_id":"70e6c3772a717a608f430d14a0d0ecc14b784d19"}],"nova/templates/bin/_bootstrap.sh.tpl":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"bb2b79f3c900eebb5e984262c309a6c43992369c","unresolved":false,"context_lines":[{"line_number":27,"context_line":" --id {{ .id }} \\"},{"line_number":28,"context_line":" --ram {{ .ram }} \\"},{"line_number":29,"context_line":" --disk {{ .disk }} \\"},{"line_number":30,"context_line":"{{ if .vcpus }} --vcpus {{ .vcpus }} {{ end }} \\"},{"line_number":31,"context_line":"{{ if .ephemeral }} --ephemeral {{ .ephemeral }} \\{{ end }}"},{"line_number":32,"context_line":"{{ if .swap }} --swap {{ .swap }} \\{{ end }}"},{"line_number":33,"context_line":"{{ if .properties }} {{ range $key, $value :\u003d .properties }}--property {{$key}}\u003d{{$value}} {{ end }}{{ end -}} \\"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"df7087c5_0eef29e9","line":30,"range":{"start_line":30,"start_character":46,"end_line":30,"end_character":48},"updated":"2018-03-15 12:46:07.000000000","message":"can we move this \\ inside the if block.","commit_id":"7e45fd3529a9fd80c2aeb713b069eab5ac650394"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"04a24a1fe6fb179c556edcce6a363bb3f8c80e25","unresolved":false,"context_lines":[{"line_number":27,"context_line":" --id {{ .id }} \\"},{"line_number":28,"context_line":" --ram {{ .ram }} \\"},{"line_number":29,"context_line":" --disk {{ .disk }} \\"},{"line_number":30,"context_line":"{{ if .vcpus }} --vcpus {{ .vcpus }} {{ end }} \\"},{"line_number":31,"context_line":"{{ if .ephemeral }} --ephemeral {{ .ephemeral }} \\{{ end }}"},{"line_number":32,"context_line":"{{ if .swap }} --swap {{ .swap }} \\{{ end }}"},{"line_number":33,"context_line":"{{ if .properties }} {{ range $key, $value :\u003d .properties }}--property {{$key}}\u003d{{$value}} {{ end }}{{ end -}} \\"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"{{ end }}"},{"line_number":36,"context_line":"{{ end }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"df7087c5_b9cd29b8","line":33,"range":{"start_line":30,"start_character":0,"end_line":33,"end_character":20},"updated":"2018-03-15 13:12:22.000000000","message":"can we put this all inside a range function - so that we can support arbitrary keys/flags without having to extend the function each time?","commit_id":"7e45fd3529a9fd80c2aeb713b069eab5ac650394"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"a2e86fd7a8f49670d2df9d2863de8315e1e4fa73","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"openstack flavor show {{ .name }} || \\"},{"line_number":26,"context_line":" openstack flavor create {{ .name }} \\"},{"line_number":27,"context_line":"{{ range $key, $value :\u003d . }}{{ if and ($value)  (ne $key \"name\") (ne $key \"properties\") }}--{{$key}} {{$value}} \\{{ end }}{{ end }}"},{"line_number":28,"context_line":"{{ range $k, $v :\u003d .properties }}--property {{$k}}\u003d{{$v}} \\{{ end }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":" openstack flavor show {{ .name }}"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"df7087c5_04ba4009","line":27,"range":{"start_line":27,"start_character":113,"end_line":27,"end_character":115},"updated":"2018-03-20 13:59:05.000000000","message":"with all these parameters in 1 line, we probably don\u0027t need \\ after all the parameter.  See the rendering http://paste.openstack.org/show/706106/","commit_id":"70e6c3772a717a608f430d14a0d0ecc14b784d19"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"a2e86fd7a8f49670d2df9d2863de8315e1e4fa73","unresolved":false,"context_lines":[{"line_number":25,"context_line":"openstack flavor show {{ .name }} || \\"},{"line_number":26,"context_line":" openstack flavor create {{ .name }} \\"},{"line_number":27,"context_line":"{{ range $key, $value :\u003d . }}{{ if and ($value)  (ne $key \"name\") (ne $key \"properties\") }}--{{$key}} {{$value}} \\{{ end }}{{ end }}"},{"line_number":28,"context_line":"{{ range $k, $v :\u003d .properties }}--property {{$k}}\u003d{{$v}} \\{{ end }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":" openstack flavor show {{ .name }}"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":5,"id":"df7087c5_e4538ce1","line":28,"range":{"start_line":28,"start_character":51,"end_line":28,"end_character":58},"updated":"2018-03-20 13:59:05.000000000","message":"should we check if {{$v}} is none empty, else, we are getting these in the commands:\n\n  --property hw:numa_nodes\u003d\n\nwith a blank. Would that not cause problem?","commit_id":"70e6c3772a717a608f430d14a0d0ecc14b784d19"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"a93c625036708fd84a8dbfbabc803277442c86f7","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"openstack flavor show {{ .name }} || \\"},{"line_number":26,"context_line":" openstack flavor create {{ .name }} \\"},{"line_number":27,"context_line":"{{ range $key, $value :\u003d . }}{{ if and ($value)  (ne $key \"name\") (ne $key \"properties\") }}--{{$key}} {{$value}} {{ end }}{{ end }}\\"},{"line_number":28,"context_line":"{{ range $k, $v :\u003d .properties }}{{if ($v)}}--property {{$k}}\u003d{{$v}}{{end}} {{ end }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":" openstack flavor show {{ .name }}"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"df7087c5_38a645ad","line":27,"range":{"start_line":27,"start_character":39,"end_line":27,"end_character":41},"updated":"2018-03-23 14:23:50.000000000","message":"could there be any valid configurations where `$value` evaluates to false, like `0`, `false`, or `\"\"`?  if so maybe something like `(ne $value nil)` could resolve.","commit_id":"fad1d1037ac5b598c14bfcbdcbea7318335e20f0"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"a93c625036708fd84a8dbfbabc803277442c86f7","unresolved":false,"context_lines":[{"line_number":25,"context_line":"openstack flavor show {{ .name }} || \\"},{"line_number":26,"context_line":" openstack flavor create {{ .name }} \\"},{"line_number":27,"context_line":"{{ range $key, $value :\u003d . }}{{ if and ($value)  (ne $key \"name\") (ne $key \"properties\") }}--{{$key}} {{$value}} {{ end }}{{ end }}\\"},{"line_number":28,"context_line":"{{ range $k, $v :\u003d .properties }}{{if ($v)}}--property {{$k}}\u003d{{$v}}{{end}} {{ end }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":" openstack flavor show {{ .name }}"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":6,"id":"df7087c5_78c91d57","line":28,"range":{"start_line":28,"start_character":38,"end_line":28,"end_character":40},"updated":"2018-03-23 14:23:50.000000000","message":"could there be any valid configurations where `$v` evaluates to false, like `0`, `false`, or `\"\"`?  if so maybe something like `(ne $v nil)` could resolve.","commit_id":"fad1d1037ac5b598c14bfcbdcbea7318335e20f0"}]}