)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"4d7240e197308cf8fa092ce2063d90fc6af46d48","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[0] https://review.openstack.org/#/c/523959/13"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-implements: blueprint nginx-sidecar"},{"line_number":14,"context_line":"Co-Authored-By: Pete Birley \u003cpete@port.direct\u003e"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I8cb6f05bd97f31c0a4e4394da43c5752a2f651a1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"bf659307_6dc9ef23","line":13,"range":{"start_line":13,"start_character":22,"end_line":13,"end_character":45},"updated":"2018-04-04 07:29:11.000000000","message":"is that missing?  the generated URL doesn\u0027t work for me and searching i wasn\u0027t able to find it either","commit_id":"647798b4d2213dfdb009932a227104eef3409311"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"af1211b6df58d9a727a6c28419a5cc71a20ca69d","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[0] https://review.openstack.org/#/c/523959/13"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-implements: blueprint nginx-sidecar"},{"line_number":14,"context_line":"Co-Authored-By: Pete Birley \u003cpete@port.direct\u003e"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I8cb6f05bd97f31c0a4e4394da43c5752a2f651a1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"bf659307_cf610807","line":13,"range":{"start_line":13,"start_character":22,"end_line":13,"end_character":45},"in_reply_to":"bf659307_6dc9ef23","updated":"2018-04-04 14:18:58.000000000","message":"This is an issue with the generated launchpad link not search through OSH bps. I will update this to an actual link [0] if new patchset is needed.\n\n[0] https://blueprints.launchpad.net/openstack-helm/?searchtext\u003dnginx-sidecar","commit_id":"647798b4d2213dfdb009932a227104eef3409311"}],"cinder/templates/bin/_cinder-api.sh.tpl":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"4d7240e197308cf8fa092ce2063d90fc6af46d48","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  kill -TERM 1"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"function readiness () {"},{"line_number":32,"context_line":"  python -c \"import ConfigParser;"},{"line_number":33,"context_line":"import requests;"},{"line_number":34,"context_line":"config \u003d ConfigParser.RawConfigParser();"},{"line_number":35,"context_line":"config.read(\u0027/etc/cinder/cinder.conf\u0027);"}],"source_content_type":"text/x-smarty","patch_set":23,"id":"bf659307_8df56359","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":33},"updated":"2018-04-04 07:29:11.000000000","message":"python embedded in shell ... is there an alternative to this?  i don\u0027t mean some evil grep/sed/awk/curl machination but perhaps having the readiness script be pure python?","commit_id":"647798b4d2213dfdb009932a227104eef3409311"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"af1211b6df58d9a727a6c28419a5cc71a20ca69d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  kill -TERM 1"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"function readiness () {"},{"line_number":32,"context_line":"  python -c \"import ConfigParser;"},{"line_number":33,"context_line":"import requests;"},{"line_number":34,"context_line":"config \u003d ConfigParser.RawConfigParser();"},{"line_number":35,"context_line":"config.read(\u0027/etc/cinder/cinder.conf\u0027);"}],"source_content_type":"text/x-smarty","patch_set":23,"id":"bf659307_af529433","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":33},"in_reply_to":"bf659307_8df56359","updated":"2018-04-04 14:18:58.000000000","message":"I agree that this can be better.  Having all the line starting at col 0 may need a cleanup.  I will issue a new patch set to clean it up.","commit_id":"647798b4d2213dfdb009932a227104eef3409311"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"ee5f3e6fd5acf93aa3a95de9ba48672b0426cda3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  kill -TERM 1"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"function readiness () {"},{"line_number":32,"context_line":"  python -c \"import ConfigParser;"},{"line_number":33,"context_line":"import requests;"},{"line_number":34,"context_line":"config \u003d ConfigParser.RawConfigParser();"},{"line_number":35,"context_line":"config.read(\u0027/etc/cinder/cinder.conf\u0027);"}],"source_content_type":"text/x-smarty","patch_set":23,"id":"bf659307_c3862eba","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":33},"in_reply_to":"bf659307_af529433","updated":"2018-04-11 13:40:13.000000000","message":"Why not just use a python script instead of bash?","commit_id":"647798b4d2213dfdb009932a227104eef3409311"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"ee5f3e6fd5acf93aa3a95de9ba48672b0426cda3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  kill -TERM 1"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"function readiness () {"},{"line_number":32,"context_line":"  python -c \"import ConfigParser;"},{"line_number":33,"context_line":"import requests;"},{"line_number":34,"context_line":"config \u003d ConfigParser.RawConfigParser();"}],"source_content_type":"text/x-smarty","patch_set":25,"id":"bf659307_e337b2fd","line":31,"updated":"2018-04-11 13:40:13.000000000","message":"I saw a lot of discussion around shell vs python, and Tin I think you were going to issue a cleanup script to add indentation.  But to Chris\u0027 point, I didn\u0027t see an answer to \"why not just a python script instead of bash\"?","commit_id":"d702b3f9b08a42036ecb639f0e690013942952a1"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"24ade4c7800a26784daa7cbb03f8be35db6bf141","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  kill -TERM 1"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"function readiness () {"},{"line_number":32,"context_line":"  python -c \"import ConfigParser;"},{"line_number":33,"context_line":"import requests;"},{"line_number":34,"context_line":"config \u003d ConfigParser.RawConfigParser();"}],"source_content_type":"text/x-smarty","patch_set":25,"id":"bf659307_cb612e07","line":31,"in_reply_to":"bf659307_cbd28e00","updated":"2018-04-13 04:46:24.000000000","message":"Done","commit_id":"d702b3f9b08a42036ecb639f0e690013942952a1"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"00505aa72454dbfda3a3e146a3509f0543e851f3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  kill -TERM 1"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"function readiness () {"},{"line_number":32,"context_line":"  python -c \"import ConfigParser;"},{"line_number":33,"context_line":"import requests;"},{"line_number":34,"context_line":"config \u003d ConfigParser.RawConfigParser();"}],"source_content_type":"text/x-smarty","patch_set":25,"id":"bf659307_cbd28e00","line":31,"in_reply_to":"bf659307_e337b2fd","updated":"2018-04-13 04:20:10.000000000","message":"+1 to putting these in a the *-bin configmap with a sane name eg: `cinder-api-check.py`. In my original PS I just put these here for expedience as I fleshed out the approach.","commit_id":"d702b3f9b08a42036ecb639f0e690013942952a1"}],"cinder/templates/configmap-bin.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"e74100c34584b727f0c81397514d135b5235d25e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"{{ tuple \"bin/_db-sync.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":32,"context_line":"  db-drop.py: |"},{"line_number":33,"context_line":"{{- include \"helm-toolkit.scripts.db_drop\" . | indent 4 }}"},{"line_number":34,"context_line":"  readiness-check.py: |"},{"line_number":35,"context_line":"{{- include \"helm-toolkit.scripts.readiness-check\" . | indent 4 }}"},{"line_number":36,"context_line":"  ks-service.sh: |"},{"line_number":37,"context_line":"{{- include \"helm-toolkit.scripts.keystone_service\" . | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"9f6a8fd7_5b13f85c","line":34,"updated":"2018-04-20 00:08:11.000000000","message":"{{- if .Values.sidecar.enabled }}\n\n...\n\n{{- end }}\n\n\n?","commit_id":"97ac9cb0073a52aeb85a6508102e0b02831bfa25"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"adf3569ffd9e013167f7816eb8c43c55a5034d76","unresolved":false,"context_lines":[{"line_number":31,"context_line":"{{ tuple \"bin/_db-sync.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":32,"context_line":"  db-drop.py: |"},{"line_number":33,"context_line":"{{- include \"helm-toolkit.scripts.db_drop\" . | indent 4 }}"},{"line_number":34,"context_line":"  readiness-check.py: |"},{"line_number":35,"context_line":"{{- include \"helm-toolkit.scripts.readiness-check\" . | indent 4 }}"},{"line_number":36,"context_line":"  ks-service.sh: |"},{"line_number":37,"context_line":"{{- include \"helm-toolkit.scripts.keystone_service\" . | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"9f6a8fd7_a75c7aed","line":34,"in_reply_to":"9f6a8fd7_5b13f85c","updated":"2018-04-20 01:24:56.000000000","message":"no - the whole readiness check will be migrated to use this with or without sidecar.","commit_id":"97ac9cb0073a52aeb85a6508102e0b02831bfa25"}],"cinder/templates/deployment-api.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"4d7240e197308cf8fa092ce2063d90fc6af46d48","unresolved":false,"context_lines":[{"line_number":82,"context_line":"          readinessProbe:"},{"line_number":83,"context_line":"            exec:"},{"line_number":84,"context_line":"              command:"},{"line_number":85,"context_line":"                - /tmp/cinder-api.sh"},{"line_number":86,"context_line":"                - readiness"},{"line_number":87,"context_line":"            initialDelaySeconds: 10"},{"line_number":88,"context_line":"            periodSeconds: 5"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"bf659307_ed05ff46","line":85,"range":{"start_line":85,"start_character":22,"end_line":85,"end_character":23},"updated":"2018-04-04 07:29:11.000000000","message":"as previously mentioned, i wonder if we shouldn\u0027t have /tmp/cinder-isready.py","commit_id":"647798b4d2213dfdb009932a227104eef3409311"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"af1211b6df58d9a727a6c28419a5cc71a20ca69d","unresolved":false,"context_lines":[{"line_number":82,"context_line":"          readinessProbe:"},{"line_number":83,"context_line":"            exec:"},{"line_number":84,"context_line":"              command:"},{"line_number":85,"context_line":"                - /tmp/cinder-api.sh"},{"line_number":86,"context_line":"                - readiness"},{"line_number":87,"context_line":"            initialDelaySeconds: 10"},{"line_number":88,"context_line":"            periodSeconds: 5"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"bf659307_8f2c70ac","line":85,"range":{"start_line":85,"start_character":22,"end_line":85,"end_character":23},"in_reply_to":"bf659307_ed05ff46","updated":"2018-04-04 14:18:58.000000000","message":"see prev comments re: embedded python in bash.","commit_id":"647798b4d2213dfdb009932a227104eef3409311"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"4d7240e197308cf8fa092ce2063d90fc6af46d48","unresolved":false,"context_lines":[{"line_number":84,"context_line":"              command:"},{"line_number":85,"context_line":"                - /tmp/cinder-api.sh"},{"line_number":86,"context_line":"                - readiness"},{"line_number":87,"context_line":"            initialDelaySeconds: 10"},{"line_number":88,"context_line":"            periodSeconds: 5"},{"line_number":89,"context_line":"          volumeMounts:"},{"line_number":90,"context_line":"            - name: cinder-bin"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"bf659307_0d015338","line":87,"range":{"start_line":87,"start_character":33,"end_line":87,"end_character":35},"updated":"2018-04-04 07:29:11.000000000","message":"i\u0027ve not thought hard about this, are we sure this isn\u0027t too aggressive though?","commit_id":"647798b4d2213dfdb009932a227104eef3409311"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"af1211b6df58d9a727a6c28419a5cc71a20ca69d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"              command:"},{"line_number":85,"context_line":"                - /tmp/cinder-api.sh"},{"line_number":86,"context_line":"                - readiness"},{"line_number":87,"context_line":"            initialDelaySeconds: 10"},{"line_number":88,"context_line":"            periodSeconds: 5"},{"line_number":89,"context_line":"          volumeMounts:"},{"line_number":90,"context_line":"            - name: cinder-bin"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"bf659307_6a046a15","line":87,"range":{"start_line":87,"start_character":33,"end_line":87,"end_character":35},"in_reply_to":"bf659307_0d015338","updated":"2018-04-04 14:18:58.000000000","message":"This was moved directly over from the other patch set and looks to be working fine.  Is there a value you would recommend that is less aggression?  I am open to discussion.","commit_id":"647798b4d2213dfdb009932a227104eef3409311"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"dae54dcfee8b5dd42c8f7ff24ccfdf50fff2ae60","unresolved":false,"context_lines":[{"line_number":84,"context_line":"              command:"},{"line_number":85,"context_line":"                - /tmp/cinder-api.sh"},{"line_number":86,"context_line":"                - readiness"},{"line_number":87,"context_line":"            initialDelaySeconds: 10"},{"line_number":88,"context_line":"            periodSeconds: 5"},{"line_number":89,"context_line":"          volumeMounts:"},{"line_number":90,"context_line":"            - name: cinder-bin"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"bf659307_74118c53","line":87,"range":{"start_line":87,"start_character":33,"end_line":87,"end_character":35},"in_reply_to":"bf659307_3b49e38a","updated":"2018-04-05 20:31:21.000000000","message":"the default for this is 0 seconds, so it actually buys us a bit more breathing room.","commit_id":"647798b4d2213dfdb009932a227104eef3409311"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"4e4906fb83866eec62d491df31ddc4c19638714f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"              command:"},{"line_number":85,"context_line":"                - /tmp/cinder-api.sh"},{"line_number":86,"context_line":"                - readiness"},{"line_number":87,"context_line":"            initialDelaySeconds: 10"},{"line_number":88,"context_line":"            periodSeconds: 5"},{"line_number":89,"context_line":"          volumeMounts:"},{"line_number":90,"context_line":"            - name: cinder-bin"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"bf659307_3b49e38a","line":87,"range":{"start_line":87,"start_character":33,"end_line":87,"end_character":35},"in_reply_to":"bf659307_6a046a15","updated":"2018-04-04 16:08:16.000000000","message":"oh, i was asking because we\u0027ve seen issues on cluster rebooted with overly aggressive timing and also on some builders\n\nif what you have is working well in the gates it\u0027s probably fine","commit_id":"647798b4d2213dfdb009932a227104eef3409311"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"4d7240e197308cf8fa092ce2063d90fc6af46d48","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                - /tmp/cinder-api.sh"},{"line_number":86,"context_line":"                - readiness"},{"line_number":87,"context_line":"            initialDelaySeconds: 10"},{"line_number":88,"context_line":"            periodSeconds: 5"},{"line_number":89,"context_line":"          volumeMounts:"},{"line_number":90,"context_line":"            - name: cinder-bin"},{"line_number":91,"context_line":"              mountPath: /tmp/cinder-api.sh"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"bf659307_adfb8744","line":88,"range":{"start_line":88,"start_character":27,"end_line":88,"end_character":28},"updated":"2018-04-04 07:29:11.000000000","message":"same comment as above","commit_id":"647798b4d2213dfdb009932a227104eef3409311"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"af1211b6df58d9a727a6c28419a5cc71a20ca69d","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                - /tmp/cinder-api.sh"},{"line_number":86,"context_line":"                - readiness"},{"line_number":87,"context_line":"            initialDelaySeconds: 10"},{"line_number":88,"context_line":"            periodSeconds: 5"},{"line_number":89,"context_line":"          volumeMounts:"},{"line_number":90,"context_line":"            - name: cinder-bin"},{"line_number":91,"context_line":"              mountPath: /tmp/cinder-api.sh"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"bf659307_2a0af21e","line":88,"range":{"start_line":88,"start_character":27,"end_line":88,"end_character":28},"in_reply_to":"bf659307_adfb8744","updated":"2018-04-04 14:18:58.000000000","message":"ditto.","commit_id":"647798b4d2213dfdb009932a227104eef3409311"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"e74100c34584b727f0c81397514d135b5235d25e","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                command:"},{"line_number":81,"context_line":"                  - /tmp/cinder-api.sh"},{"line_number":82,"context_line":"                  - stop"},{"line_number":83,"context_line":"          readinessProbe:"},{"line_number":84,"context_line":"            exec:"},{"line_number":85,"context_line":"              command:"},{"line_number":86,"context_line":"                - python"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"9f6a8fd7_1b1d8065","line":83,"range":{"start_line":83,"start_character":0,"end_line":83,"end_character":25},"updated":"2018-04-20 00:08:11.000000000","message":"is this only for sidecar or always? (see last comment as well)","commit_id":"97ac9cb0073a52aeb85a6508102e0b02831bfa25"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"adf3569ffd9e013167f7816eb8c43c55a5034d76","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                command:"},{"line_number":81,"context_line":"                  - /tmp/cinder-api.sh"},{"line_number":82,"context_line":"                  - stop"},{"line_number":83,"context_line":"          readinessProbe:"},{"line_number":84,"context_line":"            exec:"},{"line_number":85,"context_line":"              command:"},{"line_number":86,"context_line":"                - python"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"9f6a8fd7_870cd6ec","line":83,"range":{"start_line":83,"start_character":0,"end_line":83,"end_character":25},"in_reply_to":"9f6a8fd7_1b1d8065","updated":"2018-04-20 01:24:56.000000000","message":"always - it in effect does a tcpSocket check against the port specified in the .conf via the python script.  The only difference is handling of the host.","commit_id":"97ac9cb0073a52aeb85a6508102e0b02831bfa25"}],"cinder/values.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"ea2a70d2bc5eab80b39fb168ff1121508dd3eb1c","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"        default: 11211"},{"line_number":1080,"context_line":""},{"line_number":1081,"context_line":"sidecar:"},{"line_number":1082,"context_line":"  enabled: true"},{"line_number":1083,"context_line":""},{"line_number":1084,"context_line":"manifests:"},{"line_number":1085,"context_line":"  configmap_bin: true"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"9f6a8fd7_19a647c3","line":1082,"range":{"start_line":1082,"start_character":0,"end_line":1082,"end_character":15},"updated":"2018-04-16 23:21:27.000000000","message":"should that be the default?","commit_id":"f87a1b36ef59bf165397d5b3879fbe491f956f72"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"d6f6db3b8d40ebe8e2cd45fc51db0d5c2d1383bd","unresolved":false,"context_lines":[{"line_number":247,"context_line":"network:"},{"line_number":248,"context_line":"  api:"},{"line_number":249,"context_line":"    termination:"},{"line_number":250,"context_line":"      enabled: true"},{"line_number":251,"context_line":"    ingress:"},{"line_number":252,"context_line":"      public: true"},{"line_number":253,"context_line":"      classes:"}],"source_content_type":"text/x-yaml","patch_set":67,"id":"5f7c97a3_1e7d7fe6","line":250,"range":{"start_line":250,"start_character":0,"end_line":250,"end_character":19},"updated":"2018-05-09 18:12:22.000000000","message":"is that a good default?\n\ndoes that mean things are enabled?","commit_id":"c0fdf154a336e275a67dcb8715f852db7c264e8c"}],"glance/templates/bin/_glance-api.sh.tpl":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"4d7240e197308cf8fa092ce2063d90fc6af46d48","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  kill -TERM 1"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"function readiness () {"},{"line_number":32,"context_line":"  python -c \"import ConfigParser;"},{"line_number":33,"context_line":"import requests;"},{"line_number":34,"context_line":"config \u003d ConfigParser.RawConfigParser();"},{"line_number":35,"context_line":"config.read(\u0027/etc/glance/glance-api.conf\u0027);"}],"source_content_type":"text/x-smarty","patch_set":23,"id":"bf659307_ed8adfbc","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":33},"updated":"2018-04-04 07:29:11.000000000","message":"$earlier_comment","commit_id":"647798b4d2213dfdb009932a227104eef3409311"}],"glance/templates/bin/_glance-registry.sh.tpl":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"4d7240e197308cf8fa092ce2063d90fc6af46d48","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  kill -TERM 1"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"function readiness () {"},{"line_number":32,"context_line":"  python -c \"import ConfigParser;"},{"line_number":33,"context_line":"import requests;"},{"line_number":34,"context_line":"config \u003d ConfigParser.RawConfigParser();"},{"line_number":35,"context_line":"config.read(\u0027/etc/glance/glance-registry.conf\u0027);"}],"source_content_type":"text/x-smarty","patch_set":23,"id":"bf659307_cd8b5bbd","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":33},"updated":"2018-04-04 07:29:11.000000000","message":"^","commit_id":"647798b4d2213dfdb009932a227104eef3409311"}],"glance/templates/deployment-api.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"e74100c34584b727f0c81397514d135b5235d25e","unresolved":false,"context_lines":[{"line_number":85,"context_line":"              readOnly: true"},{"line_number":86,"context_line":"        {{ end }}"},{"line_number":87,"context_line":"      containers:"},{"line_number":88,"context_line":"{{ tuple $envAll \"glance-bin\" \"glance-etc\" \"g-api\" \"image\" \"internal\" \"api\" . | include \"helm-toolkit.snippets.nginx_sidecar_container\" | indent 8 }}"},{"line_number":89,"context_line":"        - name: glance-api"},{"line_number":90,"context_line":"          image: {{ .Values.images.tags.glance_api }}"},{"line_number":91,"context_line":"          imagePullPolicy: {{ .Values.images.pull_policy }}"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"9f6a8fd7_db286887","line":88,"range":{"start_line":88,"start_character":9,"end_line":88,"end_character":10},"updated":"2018-04-20 00:08:11.000000000","message":"what will this do when the sidecar isn\u0027t enabled?  nothing?","commit_id":"97ac9cb0073a52aeb85a6508102e0b02831bfa25"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"adf3569ffd9e013167f7816eb8c43c55a5034d76","unresolved":false,"context_lines":[{"line_number":85,"context_line":"              readOnly: true"},{"line_number":86,"context_line":"        {{ end }}"},{"line_number":87,"context_line":"      containers:"},{"line_number":88,"context_line":"{{ tuple $envAll \"glance-bin\" \"glance-etc\" \"g-api\" \"image\" \"internal\" \"api\" . | include \"helm-toolkit.snippets.nginx_sidecar_container\" | indent 8 }}"},{"line_number":89,"context_line":"        - name: glance-api"},{"line_number":90,"context_line":"          image: {{ .Values.images.tags.glance_api }}"},{"line_number":91,"context_line":"          imagePullPolicy: {{ .Values.images.pull_policy }}"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"9f6a8fd7_e734b295","line":88,"range":{"start_line":88,"start_character":9,"end_line":88,"end_character":10},"in_reply_to":"9f6a8fd7_db286887","updated":"2018-04-20 01:24:56.000000000","message":"Nothing - this creates the sidecar container only when it is enabled.  See L38 in https://review.openstack.org/#/c/555386/38/helm-toolkit/templates/snippets/_nginx_sidecar_container.tpl","commit_id":"97ac9cb0073a52aeb85a6508102e0b02831bfa25"}],"heat/templates/bin/_heat-cfn.sh.tpl":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"4d7240e197308cf8fa092ce2063d90fc6af46d48","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  kill -TERM 1"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"function readiness () {"},{"line_number":32,"context_line":"  python -c \"import ConfigParser;"},{"line_number":33,"context_line":"import requests;"},{"line_number":34,"context_line":"config \u003d ConfigParser.RawConfigParser();"},{"line_number":35,"context_line":"config.read(\u0027/etc/heat/heat.conf\u0027);"}],"source_content_type":"text/x-smarty","patch_set":23,"id":"bf659307_ada94724","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":33},"updated":"2018-04-04 07:29:11.000000000","message":"quite a lot of commonality here across charts, toolkit?  (mixed feelings on that, it makes things smaller and in theory less error-prone but also really really hard to read)","commit_id":"647798b4d2213dfdb009932a227104eef3409311"}],"helm-toolkit/templates/scripts/_readiness-check.py.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"c4e3d887012269f96bce81282461c81e99518b3a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"limitations under the License."},{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":"{{- define \"helm-toolkit.scripts.readiness-check\" }}"},{"line_number":17,"context_line":"#!/usr/bin/env python"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import ConfigParser"},{"line_number":20,"context_line":"import requests"},{"line_number":21,"context_line":"import sys"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"config \u003d ConfigParser.RawConfigParser()"},{"line_number":25,"context_line":"config.read(sys.argv[1])"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"try:"},{"line_number":28,"context_line":"    bind_host \u003d config.get(sys.argv[2], sys.argv[3])"},{"line_number":29,"context_line":"except ConfigParser.NoOptionError:"},{"line_number":30,"context_line":"    bind_host \u003d \"0.0.0.0\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"bind_port \u003d config.get(sys.argv[4], sys.argv[5])"},{"line_number":33,"context_line":"addr \u003d \u0027%s://%s:%s\u0027 % (sys.argv[6], bind_host, bind_port)"},{"line_number":34,"context_line":"requests.get(addr)"},{"line_number":35,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":42,"id":"9f6a8fd7_befe6668","line":34,"range":{"start_line":17,"start_character":0,"end_line":34,"end_character":18},"updated":"2018-04-25 01:00:22.000000000","message":"we should put this in each chart, as a script to allow for future expansion - as it stands this would be better served using an HTTP probe. https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.10/#httpgetaction-v1-core","commit_id":"957ec616d6ec13f9395d7657dfe00299549158d4"}],"helm-toolkit/templates/snippets/_nginx_sidecar.tpl":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"4d7240e197308cf8fa092ce2063d90fc6af46d48","unresolved":false,"context_lines":[{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"function stop () {"},{"line_number":36,"context_line":"  # Stops the nginx server"},{"line_number":37,"context_line":"  nginx -s stop"},{"line_number":38,"context_line":"}"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":23,"id":"bf659307_2d6bf7f0","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":26},"updated":"2018-04-04 07:29:11.000000000","message":"self explanatory?","commit_id":"647798b4d2213dfdb009932a227104eef3409311"}],"helm-toolkit/templates/snippets/_nginx_sidecar_config.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"dae54dcfee8b5dd42c8f7ff24ccfdf50fff2ae60","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    sendfile                on;"},{"line_number":34,"context_line":"    keepalive_timeout       65;"},{"line_number":35,"context_line":"    client_max_body_size    20M;"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    upstream target_service {"},{"line_number":38,"context_line":"        server 127.0.0.1:${PORT};"}],"source_content_type":"text/x-smarty","patch_set":23,"id":"bf659307_6a8f8a29","line":35,"range":{"start_line":35,"start_character":28,"end_line":35,"end_character":31},"updated":"2018-04-05 20:31:21.000000000","message":"this will break glance et all with image uploads - we should prob expose it. or set it to unlimited for now.","commit_id":"647798b4d2213dfdb009932a227104eef3409311"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"0a9d5ad8fdc95e846a88c1408a0239efc813994c","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    sendfile                on;"},{"line_number":34,"context_line":"    keepalive_timeout       65;"},{"line_number":35,"context_line":"    client_max_body_size    20M;"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    upstream target_service {"},{"line_number":38,"context_line":"        server 127.0.0.1:${PORT};"}],"source_content_type":"text/x-smarty","patch_set":23,"id":"bf659307_9746a221","line":35,"range":{"start_line":35,"start_character":28,"end_line":35,"end_character":31},"in_reply_to":"bf659307_6a8f8a29","updated":"2018-04-06 06:32:20.000000000","message":"Done","commit_id":"647798b4d2213dfdb009932a227104eef3409311"}],"helm-toolkit/templates/snippets/_nginx_sidecar_container.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"675f6c075cf284b29b4bd5eb4db1ddf35ceed9bc","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    - name: {{ $etcConfigmap }}"},{"line_number":55,"context_line":"      mountPath: /tmp/nginx.conf"},{"line_number":56,"context_line":"      subPath: nginx.conf"},{"line_number":57,"context_line":"      readOnly: true"},{"line_number":58,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":19,"id":"bf659307_283469dd","line":57,"updated":"2018-04-03 00:46:45.000000000","message":"can we try with /etc/nginx as a emptydir? It would be nice to be sure we are image agnostic. This also opens the path to read only rootfs containers.","commit_id":"d837434cf234e56176d18f8aca2df11cef400da0"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"c5aeddba4020543c7167da1f247e1e806e462f03","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    - name: {{ $etcConfigmap }}"},{"line_number":55,"context_line":"      mountPath: /tmp/nginx.conf"},{"line_number":56,"context_line":"      subPath: nginx.conf"},{"line_number":57,"context_line":"      readOnly: true"},{"line_number":58,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":19,"id":"bf659307_8cd25bd0","line":57,"in_reply_to":"bf659307_283469dd","updated":"2018-04-03 14:13:15.000000000","message":"Done","commit_id":"d837434cf234e56176d18f8aca2df11cef400da0"},{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"ee5f3e6fd5acf93aa3a95de9ba48672b0426cda3","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{{- define \"helm-toolkit.snippets.nginx_sidecar_container\" }}"},{"line_number":16,"context_line":"{{- $envAll :\u003d index . 0 -}}"},{"line_number":17,"context_line":"{{- $binConfigmap :\u003d index . 1 -}}"},{"line_number":18,"context_line":"{{- $etcConfigmap :\u003d index . 2 -}}"},{"line_number":19,"context_line":"{{- $portName :\u003d index . 3 -}}"},{"line_number":20,"context_line":"{{- $service :\u003d index . 4 -}}"}],"source_content_type":"text/x-smarty","patch_set":25,"id":"bf659307_6e986974","line":17,"updated":"2018-04-11 13:40:13.000000000","message":"Instead of adding the nginx config and script to their respective configmaps in each chart, and then passing them into the htk snippet, would it make more sense to create one htk template configmap that captures the nginx config and bin?  This would \n1) un-mix nginx configmap bits from chart-specific configs, \n2) reduce the number of chart manifests that need to know about the sidecar\n\nMay be 6 of one 1/2 dozen of the other, but a thought as we move to templatizing all the bits that make sense.","commit_id":"d702b3f9b08a42036ecb639f0e690013942952a1"}]}