)]}'
{"id":"openstack%2Fopenstack-helm~557352","triplet_id":"openstack%2Fopenstack-helm~master~I7de85e349fb609b8380070030579b9b4767e72d1","project":"openstack/openstack-helm","branch":"master","topic":"ingress/hostname-fix","hashtags":[],"change_id":"I7de85e349fb609b8380070030579b9b4767e72d1","subject":"Ingress: Give arbitary fqdns a different name from namespaced rules","status":"MERGED","created":"2018-03-28 14:28:45.000000000","updated":"2018-03-30 05:20:19.000000000","submitted":"2018-03-30 05:20:19.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"557352-1522387219036-3da00d2b","meta_rev_id":"57670c7909e0f5271d9a6f43cfe745707c6f247f","_number":557352,"virtual_id_number":557352,"owner":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":2,"date":"2018-03-30 05:20:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"all":[{"value":2,"date":"2018-03-28 18:33:17.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":2,"date":"2018-03-28 14:29:16.000000000","_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"all":[{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":1,"date":"2018-03-30 04:16:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-03-28 14:29:16.000000000","updated_by":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"reviewer":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"state":"REVIEWER"},{"updated":"2018-03-28 18:33:17.000000000","updated_by":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"reviewer":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"state":"REVIEWER"},{"updated":"2018-03-30 05:20:18.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a3435841dbc9fab8acea9eb3faf882fbbd6ca81e","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2018-03-28 14:28:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bd5203445777d69a5e2591eec33556ea560265a8","author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"date":"2018-03-28 14:29:16.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"07c70d7f6744adba993d66de32cf081f7413606d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-28 17:31:27.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs http://logs.openstack.org/52/557352/1/check/build-openstack-sphinx-docs/4e9597d/html/ : SUCCESS in 3m 15s\n- openstack-helm-linter http://logs.openstack.org/52/557352/1/check/openstack-helm-linter/ded4125/ : SUCCESS in 1m 11s\n- openstack-helm-dev-deploy-ceph-ovs http://logs.openstack.org/52/557352/1/check/openstack-helm-dev-deploy-ceph-ovs/d317cdc/ : POST_FAILURE in 7m 09s\n- openstack-helm-dev-deploy-nfs-ovs http://logs.openstack.org/52/557352/1/check/openstack-helm-dev-deploy-nfs-ovs/eae763c/ : SUCCESS in 49m 20s\n- openstack-helm-dev-deploy-ceph-lb http://logs.openstack.org/52/557352/1/check/openstack-helm-dev-deploy-ceph-lb/ee81fe6/ : SUCCESS in 1h 18m 47s (non-voting)\n- openstack-helm-dev-deploy-nfs-lb http://logs.openstack.org/52/557352/1/check/openstack-helm-dev-deploy-nfs-lb/dac9adc/ : SUCCESS in 48m 44s (non-voting)\n- openstack-helm-dev-deploy-nfs-ldap http://logs.openstack.org/52/557352/1/check/openstack-helm-dev-deploy-nfs-ldap/6223932/ : SUCCESS in 53m 15s (non-voting)\n- openstack-helm-multinode-ubuntu http://logs.openstack.org/52/557352/1/check/openstack-helm-multinode-ubuntu/68408a3/ : FAILURE in 1h 27m 13s\n- openstack-helm-multinode-centos http://logs.openstack.org/52/557352/1/check/openstack-helm-multinode-centos/90caad1/ : SUCCESS in 2h 06m 01s (non-voting)\n- openstack-helm-multinode-fedora http://logs.openstack.org/52/557352/1/check/openstack-helm-multinode-fedora/aadb599/ : FAILURE in 1h 30m 39s (non-voting)\n- openstack-helm-ironic-ubuntu http://logs.openstack.org/52/557352/1/check/openstack-helm-ironic-ubuntu/a8a22dd/ : SUCCESS in 1h 13m 01s (non-voting)\n- openstack-helm-armada-fullstack-deploy http://logs.openstack.org/52/557352/1/check/openstack-helm-armada-fullstack-deploy/2347f37/ : SUCCESS in 2h 33m 04s (non-voting)\n- openstack-helm-kolla-deploy-ceph-ovs http://logs.openstack.org/52/557352/1/check/openstack-helm-kolla-deploy-ceph-ovs/a61146c/ : SUCCESS in 58m 20s\n- openstack-helm-ocata-loci-deploy-ceph http://logs.openstack.org/52/557352/1/check/openstack-helm-ocata-loci-deploy-ceph/e51e853/ : SUCCESS in 1h 01m 01s (non-voting)\n- openstack-helm-ocata-kolla-deploy-ceph http://logs.openstack.org/52/557352/1/check/openstack-helm-ocata-kolla-deploy-ceph/c4e2ddc/ : SUCCESS in 59m 18s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7da1609b71d2e149f258047fd275cc679ec41354","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2018-03-28 18:15:48.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"6ae6a26290d98e5367602c76c8f8e7de0d7917cc","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2018-03-28 18:33:17.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"cf735845b8298d96010dfdc673e0a3db23bec1b3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-28 20:44:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/52/557352/1/check/build-openstack-sphinx-docs/bb3f5f9/html/ : SUCCESS in 3m 58s\n- openstack-helm-linter http://logs.openstack.org/52/557352/1/check/openstack-helm-linter/043184d/ : SUCCESS in 1m 35s\n- openstack-helm-dev-deploy-ceph-ovs http://logs.openstack.org/52/557352/1/check/openstack-helm-dev-deploy-ceph-ovs/ed34e53/ : SUCCESS in 59m 02s\n- openstack-helm-dev-deploy-nfs-ovs http://logs.openstack.org/52/557352/1/check/openstack-helm-dev-deploy-nfs-ovs/2b3ff3b/ : SUCCESS in 47m 57s\n- openstack-helm-dev-deploy-ceph-lb http://logs.openstack.org/52/557352/1/check/openstack-helm-dev-deploy-ceph-lb/990d196/ : SUCCESS in 1h 06m 00s (non-voting)\n- openstack-helm-dev-deploy-nfs-lb http://logs.openstack.org/52/557352/1/check/openstack-helm-dev-deploy-nfs-lb/30f4cba/ : SUCCESS in 47m 55s (non-voting)\n- openstack-helm-dev-deploy-nfs-ldap http://logs.openstack.org/52/557352/1/check/openstack-helm-dev-deploy-nfs-ldap/268f599/ : SUCCESS in 57m 29s (non-voting)\n- openstack-helm-multinode-ubuntu http://logs.openstack.org/52/557352/1/check/openstack-helm-multinode-ubuntu/f440cf6/ : SUCCESS in 1h 52m 09s\n- openstack-helm-multinode-centos http://logs.openstack.org/52/557352/1/check/openstack-helm-multinode-centos/7838382/ : SUCCESS in 2h 01m 06s (non-voting)\n- openstack-helm-multinode-fedora http://logs.openstack.org/52/557352/1/check/openstack-helm-multinode-fedora/9aed0b1/ : SUCCESS in 1h 55m 40s (non-voting)\n- openstack-helm-ironic-ubuntu http://logs.openstack.org/52/557352/1/check/openstack-helm-ironic-ubuntu/c989a22/ : FAILURE in 53m 39s (non-voting)\n- openstack-helm-armada-fullstack-deploy http://logs.openstack.org/52/557352/1/check/openstack-helm-armada-fullstack-deploy/e9d2657/ : SUCCESS in 2h 23m 24s (non-voting)\n- openstack-helm-kolla-deploy-ceph-ovs http://logs.openstack.org/52/557352/1/check/openstack-helm-kolla-deploy-ceph-ovs/b86bed9/ : SUCCESS in 1h 10m 53s\n- openstack-helm-ocata-loci-deploy-ceph http://logs.openstack.org/52/557352/1/check/openstack-helm-ocata-loci-deploy-ceph/d3c4fac/ : SUCCESS in 58m 48s (non-voting)\n- openstack-helm-ocata-kolla-deploy-ceph http://logs.openstack.org/52/557352/1/check/openstack-helm-ocata-kolla-deploy-ceph/03ab315/ : SUCCESS in 1h 12m 00s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9f2d750fe8c368d3404c46687a4a732cf2b9a92e","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2018-03-30 04:16:47.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"41e8c706cc12e1fce37d358df7a3eb28cc142a56","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-30 04:16:59.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"6d601c91fef1be286fefd3639982bcc982630e46","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-30 05:20:18.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/52/557352/1/gate/build-openstack-sphinx-docs/2dce538/html/ : SUCCESS in 3m 07s\n- openstack-helm-linter http://logs.openstack.org/52/557352/1/gate/openstack-helm-linter/f20c897/ : SUCCESS in 1m 46s\n- openstack-helm-dev-deploy-ceph-ovs http://logs.openstack.org/52/557352/1/gate/openstack-helm-dev-deploy-ceph-ovs/45be572/ : SUCCESS in 57m 42s\n- openstack-helm-dev-deploy-nfs-ovs http://logs.openstack.org/52/557352/1/gate/openstack-helm-dev-deploy-nfs-ovs/4a1dab5/ : SUCCESS in 51m 19s\n- openstack-helm-kolla-deploy-ceph-ovs http://logs.openstack.org/52/557352/1/gate/openstack-helm-kolla-deploy-ceph-ovs/8f887fd/ : SUCCESS in 1h 02m 31s","accounts_in_message":[],"_revision_number":1},{"id":"5948ec45542150b2d6c66ea99be200fd52073db7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-30 05:20:19.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"34175d43af3404054ac6d41d27b6fdf81fe82580","revisions":{"34175d43af3404054ac6d41d27b6fdf81fe82580":{"kind":"REWORK","_number":1,"created":"2018-03-28 14:28:45.000000000","uploader":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"ref":"refs/changes/52/557352/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/52/557352/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/52/557352/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/52/557352/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/52/557352/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/52/557352/1"}}},"commit":{"parents":[{"commit":"ceca6ad96cb0c6f7a7a5135443cf424005023bf9","subject":"Neutron: Move all config to be directly values driven.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/ceca6ad96cb0c6f7a7a5135443cf424005023bf9"}]}],"author":{"name":"portdirect","email":"pete@port.direct","date":"2018-03-28 14:27:21.000000000","tz":-240},"committer":{"name":"portdirect","email":"pete@port.direct","date":"2018-03-28 14:27:21.000000000","tz":-240},"subject":"Ingress: Give arbitary fqdns a different name from namespaced rules","message":"Ingress: Give arbitary fqdns a different name from namespaced rules\n\nThis PS gives ingress rules attached to the cluster wide ingress\ncontroller the suffix `-fqdn` to allow them to be used.\n\nChange-Id: I7de85e349fb609b8380070030579b9b4767e72d1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/34175d43af3404054ac6d41d27b6fdf81fe82580"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/34175d43af3404054ac6d41d27b6fdf81fe82580"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}