)]}'
{"tools/images/kubernetes-entrypoint/Dockerfile":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"94d20054048c40afb72a7ef19367955b67e79621","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM docker.io/ubuntu:xenial"},{"line_number":2,"context_line":"MAINTAINER sean.eagan@att.com"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"ARG BINARY_DOWNLOAD_URL\u003dhttps://github.com/stackanetes/kubernetes-entrypoint/blob/master/kubernetes-entrypoint?raw\u003dtrue"},{"line_number":5,"context_line":"ARG BINARY_INSTALL_PATH\u003d/usr/local/bin/kubernetes-entrypoint"},{"line_number":6,"context_line":"ENV BINARY_INSTALL_PATH\u003d${BINARY_INSTALL_PATH}"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"bf659307_387c9370","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":119},"updated":"2018-04-04 07:35:16.000000000","message":"grabbing binaries is discouraged if we can avoid it\n\ni did a test of a dockerfile where we actually build the binary, i will find a pointer to it for you","commit_id":"defb9790249cc87ecab0d301dde5146f4e96c236"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"a795e64bce11dcd487e70e1e380ddab91f5da8b8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM docker.io/ubuntu:xenial"},{"line_number":2,"context_line":"MAINTAINER sean.eagan@att.com"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"ARG BINARY_DOWNLOAD_URL\u003dhttps://github.com/stackanetes/kubernetes-entrypoint/blob/master/kubernetes-entrypoint?raw\u003dtrue"},{"line_number":5,"context_line":"ARG BINARY_INSTALL_PATH\u003d/usr/local/bin/kubernetes-entrypoint"},{"line_number":6,"context_line":"ENV BINARY_INSTALL_PATH\u003d${BINARY_INSTALL_PATH}"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"bf659307_58037dbf","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":119},"in_reply_to":"bf659307_387c9370","updated":"2018-04-04 15:13:36.000000000","message":"Currently the kubernetes-entrypoint binary is tracked via source control[1], not sure whether this was on purpose, but I continued this with my changes for consistency.\n\nWe would probably want to remove that from source control if we no longer plan to use it, I am not sure what the upstream stackanetes image[2] does, as the build info for it is not available publicly that I am aware of.\n\nIf we do want to build the binary I think we\u0027d want to do it in the Makefile instead of the Dockerfile, so we can avoid adding (and removing after install) any golang dependencies, and rather can just `COPY` the binary in from a local path in the Dockerfile, and replace the BINARY_DOWNLOAD_URL arg with BINARY_PATH.\n\n[1]: https://github.com/stackanetes/kubernetes-entrypoint/commits/master/kubernetes-entrypoint\n[2]: https://quay.io/repository/stackanetes/kubernetes-entrypoint?tab\u003dtags","commit_id":"defb9790249cc87ecab0d301dde5146f4e96c236"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"2daa3b4035d92904f1a8512b8f32f83027b93551","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM docker.io/ubuntu:xenial"},{"line_number":2,"context_line":"MAINTAINER sean.eagan@att.com"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"ARG BINARY_DOWNLOAD_URL\u003dhttps://github.com/stackanetes/kubernetes-entrypoint/blob/master/kubernetes-entrypoint?raw\u003dtrue"},{"line_number":5,"context_line":"ARG BINARY_INSTALL_PATH\u003d/usr/local/bin/kubernetes-entrypoint"},{"line_number":6,"context_line":"ENV BINARY_INSTALL_PATH\u003d${BINARY_INSTALL_PATH}"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":2,"id":"bf659307_1b7c1f71","line":4,"range":{"start_line":4,"start_character":24,"end_line":4,"end_character":119},"updated":"2018-04-04 15:43:17.000000000","message":"do we want master?\nit could change on us\nhttps://github.com/stackanetes/kubernetes-entrypoint/blob/v0.3.0/kubernetes-entrypoint?raw\u003dtrue\n\nor\n\nhttps://github.com/stackanetes/kubernetes-entrypoint/blob/20a0b3c86b191253adfaaff1c99832fea87d0a58/kubernetes-entrypoint?raw\u003dtrue\n\nperhaps?","commit_id":"25389fc40eed5988e4443361c697a38056c4e1b3"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"25d95966d111febb7563e90026c3710a5a7459af","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM docker.io/ubuntu:xenial"},{"line_number":2,"context_line":"MAINTAINER sean.eagan@att.com"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"ARG BINARY_DOWNLOAD_URL\u003dhttps://github.com/stackanetes/kubernetes-entrypoint/blob/master/kubernetes-entrypoint?raw\u003dtrue"},{"line_number":5,"context_line":"ARG BINARY_INSTALL_PATH\u003d/usr/local/bin/kubernetes-entrypoint"},{"line_number":6,"context_line":"ENV BINARY_INSTALL_PATH\u003d${BINARY_INSTALL_PATH}"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":2,"id":"bf659307_210c5493","line":4,"range":{"start_line":4,"start_character":24,"end_line":4,"end_character":119},"in_reply_to":"bf659307_1b7c1f71","updated":"2018-04-04 17:29:11.000000000","message":"Since this is just the default value I think pointing at something that stays current and doesn\u0027t become stale makes sense, similar to defaulting to :latest tag on a docker image reference.  But if we don\u0027t think a default value is useful I could see just removing it, and making it a required variable in the Dockerfile and Makefile.","commit_id":"25389fc40eed5988e4443361c697a38056c4e1b3"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"fc1f4b46105d5eb5a46ed550071b11cfe6516feb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM docker.io/ubuntu:xenial"},{"line_number":2,"context_line":"MAINTAINER sean.eagan@att.com"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"ARG BINARY_DOWNLOAD_URL\u003dhttps://github.com/stackanetes/kubernetes-entrypoint/blob/master/kubernetes-entrypoint?raw\u003dtrue"},{"line_number":5,"context_line":"ARG BINARY_INSTALL_PATH\u003d/usr/local/bin/kubernetes-entrypoint"},{"line_number":6,"context_line":"ENV BINARY_INSTALL_PATH\u003d${BINARY_INSTALL_PATH}"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":2,"id":"bf659307_8c1be971","line":4,"range":{"start_line":4,"start_character":24,"end_line":4,"end_character":119},"in_reply_to":"bf659307_210c5493","updated":"2018-04-06 15:56:43.000000000","message":"using :latest is discouraged as well","commit_id":"25389fc40eed5988e4443361c697a38056c4e1b3"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"cb1c0aa2bfa0d00d6dacb7a1a82f166f71ca8dbb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM docker.io/ubuntu:xenial"},{"line_number":2,"context_line":"MAINTAINER sean.eagan@att.com"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"ARG BINARY_DOWNLOAD_URL\u003dhttps://github.com/stackanetes/kubernetes-entrypoint/blob/master/kubernetes-entrypoint?raw\u003dtrue"},{"line_number":5,"context_line":"ARG BINARY_INSTALL_PATH\u003d/usr/local/bin/kubernetes-entrypoint"},{"line_number":6,"context_line":"ENV BINARY_INSTALL_PATH\u003d${BINARY_INSTALL_PATH}"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":2,"id":"bf659307_ba59f035","line":4,"range":{"start_line":4,"start_character":24,"end_line":4,"end_character":119},"in_reply_to":"bf659307_8c1be971","updated":"2018-04-10 21:14:37.000000000","message":"This variable is now replaced by the GIT_REPO and GIT_REF args in the Makefile, GIT_REF still defaults to master, though I included an example in the README of how to override this.","commit_id":"25389fc40eed5988e4443361c697a38056c4e1b3"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"9f8dc4bc7b99c82183c139fbd373a7e12c7db28a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM docker.io/ubuntu:xenial"},{"line_number":2,"context_line":"MAINTAINER sean.eagan@att.com"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"ARG BINARY_DOWNLOAD_URL\u003dhttps://github.com/stackanetes/kubernetes-entrypoint/blob/master/kubernetes-entrypoint?raw\u003dtrue"}],"source_content_type":"text/x-dockerfile","patch_set":3,"id":"bf659307_89e3dba4","line":1,"range":{"start_line":1,"start_character":5,"end_line":1,"end_character":28},"updated":"2018-04-06 16:20:15.000000000","message":"or do we want to use something smaller?  helm-toolkit\u0027s usage of kubernetes-entrypoint currently requires `echo` to be in the container, though we could either remove that usage, or use a minimal image with just `echo` added in.","commit_id":"f8fb1a1ce6456e880a012741162452d6462b9515"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"74a12a9e613002bdb07205a090766d5cab7aa1ec","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM docker.io/ubuntu:xenial"},{"line_number":2,"context_line":"MAINTAINER sean.eagan@att.com"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"ARG BINARY_DOWNLOAD_URL\u003dhttps://github.com/stackanetes/kubernetes-entrypoint/blob/master/kubernetes-entrypoint?raw\u003dtrue"}],"source_content_type":"text/x-dockerfile","patch_set":3,"id":"bf659307_0f826bc9","line":1,"range":{"start_line":1,"start_character":5,"end_line":1,"end_character":28},"in_reply_to":"bf659307_89e3dba4","updated":"2018-04-06 17:02:52.000000000","message":"it won\u0027t work to put that binary in something greatly smaller\n\nwhen i wanted a smaller container i rebuilt the entrypoint\n\nhttps://quay.io/repository/cw/kubernetes-entrypoint is where i put it for testing, it has two files, the entrypoint (rebuilt to be standalone) and echo\n\nmy intent was to do a few cleanups and move echo (or something similar) inside and just have the one binary (savings are minimal though, because the entrypoint ends up large it might be useful to have busybox about?)","commit_id":"f8fb1a1ce6456e880a012741162452d6462b9515"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"65417acab658b0230d605f46ee0309c8e080f516","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM docker.io/ubuntu:xenial"},{"line_number":2,"context_line":"MAINTAINER sean.eagan@att.com"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"ARG BINARY_DOWNLOAD_URL\u003dhttps://github.com/stackanetes/kubernetes-entrypoint/blob/master/kubernetes-entrypoint?raw\u003dtrue"},{"line_number":5,"context_line":"ARG BINARY_INSTALL_PATH\u003d/usr/local/bin/kubernetes-entrypoint"},{"line_number":6,"context_line":"ENV BINARY_INSTALL_PATH\u003d${BINARY_INSTALL_PATH}"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":3,"id":"bf659307_2660bc32","line":4,"range":{"start_line":4,"start_character":82,"end_line":4,"end_character":88},"updated":"2018-04-06 15:13:40.000000000","message":"could we make this variable, and use it to also drive the image tag.","commit_id":"f8fb1a1ce6456e880a012741162452d6462b9515"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"9f8dc4bc7b99c82183c139fbd373a7e12c7db28a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM docker.io/ubuntu:xenial"},{"line_number":2,"context_line":"MAINTAINER sean.eagan@att.com"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"ARG BINARY_DOWNLOAD_URL\u003dhttps://github.com/stackanetes/kubernetes-entrypoint/blob/master/kubernetes-entrypoint?raw\u003dtrue"},{"line_number":5,"context_line":"ARG BINARY_INSTALL_PATH\u003d/usr/local/bin/kubernetes-entrypoint"},{"line_number":6,"context_line":"ENV BINARY_INSTALL_PATH\u003d${BINARY_INSTALL_PATH}"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":3,"id":"bf659307_ac44adb8","line":4,"range":{"start_line":4,"start_character":82,"end_line":4,"end_character":88},"in_reply_to":"bf659307_2660bc32","updated":"2018-04-06 16:20:15.000000000","message":"Currently The entire url (via this Dockerfile `ARG` and similar one in Makefile) is variable rather than a portion of it which allows for pointing to a git fork which could either be on github or somewhere else like gerrit which would have a different url structure.\n\nAlso see Chris Wedgewood and my discussion in this review about whether to use the binary that is tracked in the source code or build it independently.  If we build it independently then this BINARY_DOWNLOAD_URL arg could be replaced by a GIT_REPO and GIT_REF args in the Makefile which we could clone and do the build on and then just `COPY` the locally built binary in the Dockerfile.  And then we could use GIT_REF to drive the image tag.  Would we then want to default the GIT_REF to anything such as `master` or just make it a required arg?","commit_id":"f8fb1a1ce6456e880a012741162452d6462b9515"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"cb1c0aa2bfa0d00d6dacb7a1a82f166f71ca8dbb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM docker.io/ubuntu:xenial"},{"line_number":2,"context_line":"MAINTAINER sean.eagan@att.com"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"ARG BINARY_DOWNLOAD_URL\u003dhttps://github.com/stackanetes/kubernetes-entrypoint/blob/master/kubernetes-entrypoint?raw\u003dtrue"},{"line_number":5,"context_line":"ARG BINARY_INSTALL_PATH\u003d/usr/local/bin/kubernetes-entrypoint"},{"line_number":6,"context_line":"ENV BINARY_INSTALL_PATH\u003d${BINARY_INSTALL_PATH}"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":3,"id":"bf659307_3fdf12d7","line":4,"range":{"start_line":4,"start_character":82,"end_line":4,"end_character":88},"in_reply_to":"bf659307_ac44adb8","updated":"2018-04-10 21:14:37.000000000","message":"The change outlined here is done.","commit_id":"f8fb1a1ce6456e880a012741162452d6462b9515"}],"tools/images/kubernetes-entrypoint/README.rst":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"6cd9343d054ccefe350157f4e07a90866fcce090","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Kubernetes-Entrypoint Container"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This container builds a small image with Kubernetes-Entrypoint for use with OpenStack-Helm."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf659307_c1c32a37","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":17},"updated":"2018-04-04 03:31:40.000000000","message":"nit: can we make the \u003d\u003d match the length?","commit_id":"defb9790249cc87ecab0d301dde5146f4e96c236"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"a795e64bce11dcd487e70e1e380ddab91f5da8b8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Kubernetes-Entrypoint Container"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This container builds a small image with Kubernetes-Entrypoint for use with OpenStack-Helm."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bf659307_8fbd5003","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":17},"in_reply_to":"bf659307_c1c32a37","updated":"2018-04-04 15:13:36.000000000","message":"Done","commit_id":"defb9790249cc87ecab0d301dde5146f4e96c236"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"2daa3b4035d92904f1a8512b8f32f83027b93551","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":".. code:: bash"},{"line_number":16,"context_line":"    # Optional configuration, see Makefile for all available options:"},{"line_number":17,"context_line":"    # export BINARY_DOWNLOAD_URL\u003dhttps://github.com/someuser/kubernetes-entrypoint/blob/somebranch/kubernetes-entrypoint?raw\u003dtrue"},{"line_number":18,"context_line":"    # export IMAGE_REPO\u003dquay.io"},{"line_number":19,"context_line":"    make"},{"line_number":20,"context_line":"    make push"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_9bbd8f04","line":17,"range":{"start_line":17,"start_character":88,"end_line":17,"end_character":98},"updated":"2018-04-04 15:43:17.000000000","message":"someref ?","commit_id":"25389fc40eed5988e4443361c697a38056c4e1b3"},{"author":{"_account_id":27715,"name":"Sean Eagan","email":"seaneagan@microsoft.com","username":"seaneagan"},"change_message_id":"4241f21980e9e5a22bfe93350c9ac3712556f019","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":".. code:: bash"},{"line_number":16,"context_line":"    # Optional configuration, see Makefile for all available options:"},{"line_number":17,"context_line":"    # export BINARY_DOWNLOAD_URL\u003dhttps://github.com/someuser/kubernetes-entrypoint/blob/somebranch/kubernetes-entrypoint?raw\u003dtrue"},{"line_number":18,"context_line":"    # export IMAGE_REPO\u003dquay.io"},{"line_number":19,"context_line":"    make"},{"line_number":20,"context_line":"    make push"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bf659307_ccc4af62","line":17,"range":{"start_line":17,"start_character":88,"end_line":17,"end_character":98},"in_reply_to":"bf659307_9bbd8f04","updated":"2018-04-04 18:04:57.000000000","message":"Done","commit_id":"25389fc40eed5988e4443361c697a38056c4e1b3"}]}