)]}'
{"id":"openstack%2Fopenstack-helm~559191","triplet_id":"openstack%2Fopenstack-helm~master~I17a19046fa96e0f3e8fb029c156ba79c924a0097","project":"openstack/openstack-helm","branch":"master","topic":"fix-error","hashtags":[],"change_id":"I17a19046fa96e0f3e8fb029c156ba79c924a0097","subject":"Add robust ldap domain-specific config","status":"MERGED","created":"2018-04-05 23:41:52.000000000","updated":"2018-04-08 18:25:41.000000000","submitted":"2018-04-08 18:25:41.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"559191-1523211941851-bde222b8","meta_rev_id":"9db5406f03a4afecff85b908d98b467cd18162e7","_number":559191,"virtual_id_number":559191,"owner":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":2,"date":"2018-04-08 18:25:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"all":[{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":2,"date":"2018-04-08 17:07:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2018-04-06 23:06:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"all":[{"value":0,"date":"2018-04-06 23:09:00.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":1,"date":"2018-04-08 17:07:12.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-04-06 23:06:45.000000000","updated_by":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"reviewer":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"state":"REVIEWER"},{"updated":"2018-04-08 17:07:12.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2018-04-08 18:25:41.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"82ca39d377f9c8dd45c85ce18b11b8437974fa12","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2018-04-05 23:41:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"500fa395da70f50689df7ff2576af83371be193f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-06 02:16:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/91/559191/1/check/build-openstack-sphinx-docs/87bedc2/html/ : SUCCESS in 3m 43s\n- openstack-helm-linter http://logs.openstack.org/91/559191/1/check/openstack-helm-linter/0d614eb/ : SUCCESS in 1m 16s\n- openstack-helm-dev-deploy-ceph-radosgw-ovs http://logs.openstack.org/91/559191/1/check/openstack-helm-dev-deploy-ceph-radosgw-ovs/1efb4c7/ : SUCCESS in 1h 05m 11s\n- openstack-helm-dev-deploy-ceph-rbd-ovs http://logs.openstack.org/91/559191/1/check/openstack-helm-dev-deploy-ceph-rbd-ovs/f901a72/ : SUCCESS in 1h 01m 51s\n- openstack-helm-dev-deploy-nfs-ovs http://logs.openstack.org/91/559191/1/check/openstack-helm-dev-deploy-nfs-ovs/91da016/ : SUCCESS in 1h 11m 54s\n- openstack-helm-dev-deploy-ceph-lb http://logs.openstack.org/91/559191/1/check/openstack-helm-dev-deploy-ceph-lb/792613c/ : SUCCESS in 1h 07m 54s (non-voting)\n- openstack-helm-dev-deploy-nfs-lb http://logs.openstack.org/91/559191/1/check/openstack-helm-dev-deploy-nfs-lb/4c83910/ : SUCCESS in 48m 17s (non-voting)\n- openstack-helm-dev-deploy-nfs-ldap http://logs.openstack.org/91/559191/1/check/openstack-helm-dev-deploy-nfs-ldap/a278bbf/ : SUCCESS in 51m 34s (non-voting)\n- openstack-helm-multinode-ubuntu http://logs.openstack.org/91/559191/1/check/openstack-helm-multinode-ubuntu/769ed45/ : SUCCESS in 1h 57m 51s (non-voting)\n- openstack-helm-ironic-ubuntu http://logs.openstack.org/91/559191/1/check/openstack-helm-ironic-ubuntu/407b4c6/ : SUCCESS in 1h 12m 53s (non-voting)\n- openstack-helm-armada-fullstack-deploy http://logs.openstack.org/91/559191/1/check/openstack-helm-armada-fullstack-deploy/9a323ac/ : SUCCESS in 2h 28m 58s (non-voting)\n- openstack-helm-kolla-deploy-ceph-ovs http://logs.openstack.org/91/559191/1/check/openstack-helm-kolla-deploy-ceph-ovs/7854acb/ : SUCCESS in 1h 03m 18s\n- openstack-helm-ocata-loci-deploy-ceph http://logs.openstack.org/91/559191/1/check/openstack-helm-ocata-loci-deploy-ceph/9b96216/ : SUCCESS in 1h 04m 59s (non-voting)\n- openstack-helm-ocata-kolla-deploy-ceph http://logs.openstack.org/91/559191/1/check/openstack-helm-ocata-kolla-deploy-ceph/70994ee/ : SUCCESS in 1h 08m 24s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e4a5b09022e1970a23163286d0235bbfe88f2a31","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2018-04-06 17:11:05.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"85b2fb4ddba6af34f99436064dc9e590fbbf07ae","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2018-04-06 17:12:13.000000000","message":"Patch Set 2: Workflow-1","accounts_in_message":[],"_revision_number":2},{"id":"b6033d17144f37e842d1ab7fca9497f1ed34cd77","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-06 19:34:39.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/91/559191/2/check/build-openstack-sphinx-docs/a2f99cb/html/ : SUCCESS in 3m 38s\n- openstack-helm-linter http://logs.openstack.org/91/559191/2/check/openstack-helm-linter/0f71284/ : SUCCESS in 1m 10s\n- openstack-helm-dev-deploy-ceph-radosgw-ovs http://logs.openstack.org/91/559191/2/check/openstack-helm-dev-deploy-ceph-radosgw-ovs/8c65a37/ : SUCCESS in 1h 04m 41s\n- openstack-helm-dev-deploy-ceph-rbd-ovs http://logs.openstack.org/91/559191/2/check/openstack-helm-dev-deploy-ceph-rbd-ovs/c676a8c/ : SUCCESS in 1h 22m 36s\n- openstack-helm-dev-deploy-nfs-ovs http://logs.openstack.org/91/559191/2/check/openstack-helm-dev-deploy-nfs-ovs/d0345f6/ : SUCCESS in 47m 49s\n- openstack-helm-dev-deploy-ceph-lb http://logs.openstack.org/91/559191/2/check/openstack-helm-dev-deploy-ceph-lb/c317b92/ : SUCCESS in 1h 00m 00s (non-voting)\n- openstack-helm-dev-deploy-nfs-lb http://logs.openstack.org/91/559191/2/check/openstack-helm-dev-deploy-nfs-lb/b9eee2d/ : SUCCESS in 48m 23s (non-voting)\n- openstack-helm-dev-deploy-nfs-ldap http://logs.openstack.org/91/559191/2/check/openstack-helm-dev-deploy-nfs-ldap/976ba7d/ : SUCCESS in 50m 51s (non-voting)\n- openstack-helm-multinode-ubuntu http://logs.openstack.org/91/559191/2/check/openstack-helm-multinode-ubuntu/e8e7ac1/ : SUCCESS in 1h 57m 33s (non-voting)\n- openstack-helm-ironic-ubuntu http://logs.openstack.org/91/559191/2/check/openstack-helm-ironic-ubuntu/e0cab1d/ : SUCCESS in 1h 07m 03s (non-voting)\n- openstack-helm-armada-fullstack-deploy http://logs.openstack.org/91/559191/2/check/openstack-helm-armada-fullstack-deploy/6c340ed/ : SUCCESS in 2h 18m 00s (non-voting)\n- openstack-helm-kolla-deploy-ceph-ovs http://logs.openstack.org/91/559191/2/check/openstack-helm-kolla-deploy-ceph-ovs/2743c89/ : SUCCESS in 1h 10m 17s\n- openstack-helm-ocata-loci-deploy-ceph http://logs.openstack.org/91/559191/2/check/openstack-helm-ocata-loci-deploy-ceph/6e846ed/ : SUCCESS in 1h 07m 43s (non-voting)\n- openstack-helm-ocata-kolla-deploy-ceph http://logs.openstack.org/91/559191/2/check/openstack-helm-ocata-kolla-deploy-ceph/d5402c8/ : SUCCESS in 1h 07m 30s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"f7817712ea27faa834a6ce2fbc7693e9544113d2","author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"date":"2018-04-06 23:06:45.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"d040c4d58e9b065b469f5bb56e6b1b1195135e1a","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2018-04-06 23:09:00.000000000","message":"Patch Set 2: -Workflow","accounts_in_message":[],"_revision_number":2},{"id":"f04256d757d0fcf33b166c765045f8bc548af5dc","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2018-04-08 17:07:12.000000000","message":"Patch Set 2: Workflow+1 Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"9d5ba3c7a0f962b14cff652ae3aa955b86f4a3f6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-08 17:07:23.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"656e645399d6785edebe788af37ed382f495959e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-08 18:25:41.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/91/559191/2/gate/build-openstack-sphinx-docs/b1ba53e/html/ : SUCCESS in 4m 17s\n- openstack-helm-linter http://logs.openstack.org/91/559191/2/gate/openstack-helm-linter/05ac7d5/ : SUCCESS in 1m 40s\n- openstack-helm-dev-deploy-ceph-radosgw-ovs http://logs.openstack.org/91/559191/2/gate/openstack-helm-dev-deploy-ceph-radosgw-ovs/8e2524c/ : SUCCESS in 1h 08m 44s\n- openstack-helm-dev-deploy-ceph-rbd-ovs http://logs.openstack.org/91/559191/2/gate/openstack-helm-dev-deploy-ceph-rbd-ovs/1084edb/ : SUCCESS in 1h 09m 45s\n- openstack-helm-dev-deploy-nfs-ovs http://logs.openstack.org/91/559191/2/gate/openstack-helm-dev-deploy-nfs-ovs/673a1d9/ : SUCCESS in 57m 42s\n- openstack-helm-kolla-deploy-ceph-ovs http://logs.openstack.org/91/559191/2/gate/openstack-helm-kolla-deploy-ceph-ovs/12b94d0/ : SUCCESS in 1h 17m 06s","accounts_in_message":[],"_revision_number":2},{"id":"491a1bebd6b5f5537cf1903249a078ea5b4706c6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-08 18:25:41.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"28734352741bae228a4ea4f40bcacc33764221eb","revisions":{"65da8888a3d75608255c29bcf74ac56dfba1e38e":{"kind":"REWORK","_number":1,"created":"2018-04-05 23:41:52.000000000","uploader":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"ref":"refs/changes/91/559191/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/91/559191/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/91/559191/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/91/559191/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/91/559191/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/91/559191/1"}}},"commit":{"parents":[{"commit":"44841fbffcf75321243cd2352025b5f33d84feca","subject":"Storage: increase robustness of storage clean jobs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/44841fbffcf75321243cd2352025b5f33d84feca"}]}],"author":{"name":"Tin Lam","email":"tin@irrational.io","date":"2018-04-05 23:41:12.000000000","tz":-300},"committer":{"name":"Tin Lam","email":"tin@irrational.io","date":"2018-04-05 23:41:51.000000000","tz":-300},"subject":"WIP: Add better domain config handling","message":"WIP: Add better domain config handling\n\nChange-Id: I17a19046fa96e0f3e8fb029c156ba79c924a0097\nSigned-off-by: Tin Lam \u003ctin@irrational.io\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/65da8888a3d75608255c29bcf74ac56dfba1e38e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/65da8888a3d75608255c29bcf74ac56dfba1e38e"}]},"branch":"refs/heads/master"},"28734352741bae228a4ea4f40bcacc33764221eb":{"kind":"REWORK","_number":2,"created":"2018-04-06 17:11:05.000000000","uploader":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"ref":"refs/changes/91/559191/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/91/559191/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/91/559191/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/91/559191/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/91/559191/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/91/559191/2"}}},"commit":{"parents":[{"commit":"44841fbffcf75321243cd2352025b5f33d84feca","subject":"Storage: increase robustness of storage clean jobs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/44841fbffcf75321243cd2352025b5f33d84feca"}]}],"author":{"name":"Tin Lam","email":"tin@irrational.io","date":"2018-04-05 23:41:12.000000000","tz":-300},"committer":{"name":"Tin Lam","email":"tin@irrational.io","date":"2018-04-06 17:08:01.000000000","tz":-300},"subject":"Add robust ldap domain-specific config","message":"Add robust ldap domain-specific config\n\nThis patch set provides PATCH capability for ldap-backed domain config,\nand prevents silent failure if the configuration contains erroneous\nsetting.  This also moves from loading .conf files into DB directly,\nand uses the API endpoints.\n\nChange-Id: I17a19046fa96e0f3e8fb029c156ba79c924a0097\nSigned-off-by: Tin Lam \u003ctin@irrational.io\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/28734352741bae228a4ea4f40bcacc33764221eb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/28734352741bae228a4ea4f40bcacc33764221eb"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}