)]}'
{"helm-toolkit/templates/manifests/_job-db-sync.yaml.tpl":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"fec634d484d8d98a13d4a2eafdfb9af71b27a310","unresolved":false,"context_lines":[{"line_number":68,"context_line":"              mountPath: /tmp/db-sync.sh"},{"line_number":69,"context_line":"              subPath: db-sync.sh"},{"line_number":70,"context_line":"              readOnly: true"},{"line_number":71,"context_line":"{{- if ne $serviceName \"glance\" }}"},{"line_number":72,"context_line":"            - name: etc-service"},{"line_number":73,"context_line":"              mountPath: {{ dir $dbToSync.configFile | quote }}"},{"line_number":74,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"9f6a8fd7_4ad9adf0","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":34},"updated":"2018-04-23 16:04:45.000000000","message":"this is generic code\n\nshould it have explicit knowledge of glance?","commit_id":"fb2f474568db03a477a65c4a20fbe56763c8d815"},{"author":{"_account_id":25050,"name":"Danfly","email":"910290847@qq.com","username":"Danfly"},"change_message_id":"e6afb5ee5c039aca94233027554fda79d64f99c3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"              mountPath: /tmp/db-sync.sh"},{"line_number":69,"context_line":"              subPath: db-sync.sh"},{"line_number":70,"context_line":"              readOnly: true"},{"line_number":71,"context_line":"{{- if ne $serviceName \"glance\" }}"},{"line_number":72,"context_line":"            - name: etc-service"},{"line_number":73,"context_line":"              mountPath: {{ dir $dbToSync.configFile | quote }}"},{"line_number":74,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"9f6a8fd7_f85badf2","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":34},"in_reply_to":"9f6a8fd7_4ad9adf0","updated":"2018-04-24 02:55:31.000000000","message":"Thank you for review. The pod should not mount the volume \"etc-service\" ,because it will override the  original dictionary /etc/glance/metadefs.\nwe will patch here or the glance job-db-sync.yaml. Maybe we shoud both patch them ,we define another value \"etc-service-mount\" like \"serviceName\", when \"etc-service-mount\" is True ,we mount volume \"etc-service\",  when False, we do not mount \"etc-service“？","commit_id":"fb2f474568db03a477a65c4a20fbe56763c8d815"}]}