)]}'
{"id":"openstack%2Fopenstack-helm~567244","triplet_id":"openstack%2Fopenstack-helm~master~I6628bc50433b4b69533f5d57ae44363634813243","project":"openstack/openstack-helm","branch":"master","hashtags":[],"change_id":"I6628bc50433b4b69533f5d57ae44363634813243","subject":"Remove the unused \"IFS\" defined","status":"ABANDONED","created":"2018-05-09 14:47:49.000000000","updated":"2018-05-19 13:53:19.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1e5d850375c7d0f272d685882c9e4980346b85a3","_number":567244,"virtual_id_number":567244,"owner":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":-1,"date":"2018-05-09 17:04:43.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":14151,"name":"ziyu032","email":"chen.qiaomin@99cloud.net","username":"ziyu032"},{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":14151,"name":"ziyu032","email":"chen.qiaomin@99cloud.net","username":"ziyu032"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2018-05-09 15:53:57.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":-1,"date":"2018-05-13 04:26:55.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":14151,"name":"ziyu032","email":"chen.qiaomin@99cloud.net","username":"ziyu032"},{"value":-1,"date":"2018-05-10 03:59:00.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":14151,"name":"ziyu032","email":"chen.qiaomin@99cloud.net","username":"ziyu032"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":14151,"name":"ziyu032","email":"chen.qiaomin@99cloud.net","username":"ziyu032"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-05-09 15:53:57.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2018-05-09 17:04:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-05-10 03:59:00.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"},{"updated":"2018-05-13 04:26:55.000000000","updated_by":{"_account_id":14151,"name":"ziyu032","email":"chen.qiaomin@99cloud.net","username":"ziyu032"},"reviewer":{"_account_id":14151,"name":"ziyu032","email":"chen.qiaomin@99cloud.net","username":"ziyu032"},"state":"REVIEWER"}],"messages":[{"id":"5e6a34669f8a5b38367f01855e39a264cd3f5cf1","author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"date":"2018-05-09 14:47:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e9cb14afff4a8f14aded838288b53f2793766eef","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2018-05-09 15:53:57.000000000","message":"Patch Set 1: Code-Review-1\n\nIs it not used in the for loop directly below its declaration?","accounts_in_message":[],"_revision_number":1},{"id":"0ca724c20114e4b8f7c6e73281b1ea8d4d990496","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-09 17:04:43.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs http://logs.openstack.org/44/567244/1/check/build-openstack-sphinx-docs/4b72b79/html/ : SUCCESS in 3m 50s\n- openstack-helm-linter http://logs.openstack.org/44/567244/1/check/openstack-helm-linter/af98ee8/ : SUCCESS in 1m 06s\n- openstack-helm-dev-deploy-ceph-radosgw-ovs http://logs.openstack.org/44/567244/1/check/openstack-helm-dev-deploy-ceph-radosgw-ovs/bfd888f/ : FAILURE in 52m 10s\n- openstack-helm-dev-deploy-ceph-rbd-ovs http://logs.openstack.org/44/567244/1/check/openstack-helm-dev-deploy-ceph-rbd-ovs/a14d8a1/ : FAILURE in 41m 59s\n- openstack-helm-dev-deploy-nfs-ovs http://logs.openstack.org/44/567244/1/check/openstack-helm-dev-deploy-nfs-ovs/db02b80/ : FAILURE in 35m 10s\n- openstack-helm-dev-deploy-ceph-lb http://logs.openstack.org/44/567244/1/check/openstack-helm-dev-deploy-ceph-lb/2e89303/ : FAILURE in 50m 33s (non-voting)\n- openstack-helm-dev-deploy-nfs-lb http://logs.openstack.org/44/567244/1/check/openstack-helm-dev-deploy-nfs-lb/7dc4a0c/ : FAILURE in 32m 36s (non-voting)\n- openstack-helm-dev-deploy-nfs-ldap http://logs.openstack.org/44/567244/1/check/openstack-helm-dev-deploy-nfs-ldap/f988d36/ : FAILURE in 35m 48s (non-voting)\n- openstack-helm-multinode-ubuntu http://logs.openstack.org/44/567244/1/check/openstack-helm-multinode-ubuntu/9716d89/ : FAILURE in 1h 25m 40s (non-voting)\n- openstack-helm-ironic-ubuntu http://logs.openstack.org/44/567244/1/check/openstack-helm-ironic-ubuntu/13c306c/ : FAILURE in 47m 02s (non-voting)\n- openstack-helm-armada-fullstack-deploy http://logs.openstack.org/44/567244/1/check/openstack-helm-armada-fullstack-deploy/2ab3a2c/ : FAILURE in 1h 29m 12s (non-voting)\n- openstack-helm-kolla-deploy-ceph-ovs http://logs.openstack.org/44/567244/1/check/openstack-helm-kolla-deploy-ceph-ovs/c3b9022/ : FAILURE in 48m 43s\n- openstack-helm-ocata-loci-deploy-ceph http://logs.openstack.org/44/567244/1/check/openstack-helm-ocata-loci-deploy-ceph/551295b/ : FAILURE in 47m 31s (non-voting)\n- openstack-helm-ocata-kolla-deploy-ceph http://logs.openstack.org/44/567244/1/check/openstack-helm-ocata-kolla-deploy-ceph/3d50152/ : FAILURE in 46m 31s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ceffaca428e2020fba77840599ccc47d68f296ad","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2018-05-10 03:59:00.000000000","message":"Patch Set 1: Code-Review-1\n\n@wu.chunyang - thanks for the patch but it is used, IFS is \u0027special\u0027 in [ba]sh; see https://www.gnu.org/software/bash/manual/html_node/Word-Splitting.html","accounts_in_message":[],"_revision_number":1},{"id":"ebdd9f5cca5f4b03a178eb539b6f4eb891cceb7b","author":{"_account_id":14151,"name":"ziyu032","email":"chen.qiaomin@99cloud.net","username":"ziyu032"},"date":"2018-05-13 04:26:55.000000000","message":"Patch Set 1: Code-Review-1\n\n\u003e @wu.chunyang - thanks for the patch but it is used, IFS is\n \u003e \u0027special\u0027 in [ba]sh; see https://www.gnu.org/software/bash/manual/html_node/Word-Splitting.html\n\nagree, this ps is unnecessary for me","accounts_in_message":[],"_revision_number":1},{"id":"1e5d850375c7d0f272d685882c9e4980346b85a3","author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"date":"2018-05-19 13:53:19.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"aeeb60a9dc43d60b6bea8d7d44ee09691239dfe9","revisions":{"aeeb60a9dc43d60b6bea8d7d44ee09691239dfe9":{"kind":"REWORK","_number":1,"created":"2018-05-09 14:47:49.000000000","uploader":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"ref":"refs/changes/44/567244/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/44/567244/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/567244/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/567244/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/44/567244/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/44/567244/1"}}},"commit":{"parents":[{"commit":"0117c1434ce66161a30a713c849a5d6dfe4aa805","subject":"Merge \"Nova: Don\u0027t set console server_proxyclient_address as null\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/0117c1434ce66161a30a713c849a5d6dfe4aa805"}]}],"author":{"name":"wu.chunyang","email":"wu.chunyang@99cloud.net","date":"2018-05-09 14:45:33.000000000","tz":480},"committer":{"name":"wu.chunyang","email":"wu.chunyang@99cloud.net","date":"2018-05-09 14:47:46.000000000","tz":480},"subject":"Remove the unused \"IFS\" defined","message":"Remove the unused \"IFS\" defined\n\nthe \"IFS\" used nowhere, remove it is safe\n\nChange-Id: I6628bc50433b4b69533f5d57ae44363634813243\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/aeeb60a9dc43d60b6bea8d7d44ee09691239dfe9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/aeeb60a9dc43d60b6bea8d7d44ee09691239dfe9"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"0117c1434ce66161a30a713c849a5d6dfe4aa805","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}