)]}'
{"tools/images/elasticsearch-s3/Makefile":[{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"f71e204c74b9bc9a2021b19f06be4e9a2b473bbd","unresolved":false,"context_lines":[{"line_number":19,"context_line":"IMAGE_NAME                 ?\u003d elasticsearch-s3"},{"line_number":20,"context_line":"IMAGE_PREFIX               ?\u003d openstackhelm"},{"line_number":21,"context_line":"IMAGE_TAG                  ?\u003d v0.1.0"},{"line_number":22,"context_line":"LABEL                      ?\u003d putlabelshere"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"IMAGE :\u003d ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${IMAGE_NAME}:${IMAGE_TAG}"},{"line_number":25,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5f7c97a3_fc097430","line":22,"updated":"2018-06-11 19:31:31.000000000","message":"If a label is not specified, should the default behavior be to not label, rather than putlabelshere?","commit_id":"4ab025098aad4b9e06ee42e663a0cbfe481a612d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"6540a99d87dc7726d36c7c844bdd41d95aa514ff","unresolved":false,"context_lines":[{"line_number":19,"context_line":"IMAGE_NAME                 ?\u003d elasticsearch-s3"},{"line_number":20,"context_line":"IMAGE_PREFIX               ?\u003d openstackhelm"},{"line_number":21,"context_line":"IMAGE_TAG                  ?\u003d v0.1.0"},{"line_number":22,"context_line":"LABEL                      ?\u003d putlabelshere"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"IMAGE :\u003d ${DOCKER_REGISTRY}/${IMAGE_PREFIX}/${IMAGE_NAME}:${IMAGE_TAG}"},{"line_number":25,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5f7c97a3_41d66a51","line":22,"in_reply_to":"5f7c97a3_fc097430","updated":"2018-06-12 14:27:45.000000000","message":"This was put here to match the other Makefiles we have for images in the repository. I can\u0027t speak to what we should do for a default, but if we land on something, it should be applied across all Makefiles we\u0027ve got currently\n\nFor example: https://github.com/openstack/openstack-helm/blob/master/tools/images/libvirt/Makefile#L28","commit_id":"4ab025098aad4b9e06ee42e663a0cbfe481a612d"}]}
