)]}'
{"cinder/templates/bin/_external-ceph-rbd-admin-keyring.sh.tpl":[{"author":{"_account_id":21691,"name":"weizj","email":"wzj334965317@outlook.com","username":"ZhijunWei"},"change_message_id":"1016432882ffa7296ccc17ac102fe282948ad246","unresolved":false,"context_lines":[{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"set -ex"},{"line_number":20,"context_line":"export HOME\u003d/tmp"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"cat \u003c\u003cEOF \u003e /etc/ceph/ceph.client.admin.keyring"},{"line_number":23,"context_line":"[client.admin]"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"5f7c97a3_a70dfb35","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":16},"updated":"2018-06-26 06:00:07.000000000","message":"seem s the env HOME is used nowhere","commit_id":"af4a60a671f7c3ed3a79843aebfb8171f5c3f1e8"},{"author":{"_account_id":21830,"name":"Jaesang Lee","email":"jaesang_lee@sk.com","username":"jaesanglee"},"change_message_id":"665225cf5247d3cab0981a634a0d95cc44db5ab1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"set -ex"},{"line_number":20,"context_line":"export HOME\u003d/tmp"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"cat \u003c\u003cEOF \u003e /etc/ceph/ceph.client.admin.keyring"},{"line_number":23,"context_line":"[client.admin]"}],"source_content_type":"text/x-smarty","patch_set":6,"id":"5f7c97a3_8b309308","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":16},"in_reply_to":"5f7c97a3_a70dfb35","updated":"2018-07-02 01:16:08.000000000","message":"Done","commit_id":"af4a60a671f7c3ed3a79843aebfb8171f5c3f1e8"},{"author":{"_account_id":21691,"name":"weizj","email":"wzj334965317@outlook.com","username":"ZhijunWei"},"change_message_id":"5d7b70d2ebf4450a4de6e6d0580aff7e325f338c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"{{- if .Values.backup.external_ceph_rbd.admin_keyring }}"},{"line_number":25,"context_line":"    key \u003d {{ .Values.backup.external_ceph_rbd.admin_keyring }}"},{"line_number":26,"context_line":"{{- else }}"},{"line_number":27,"context_line":"    key \u003d \"You must define the ceph admin keyring in values.yaml.\""},{"line_number":28,"context_line":"{{- end }}"},{"line_number":29,"context_line":"EOF"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":6,"id":"5f7c97a3_67412336","line":27,"range":{"start_line":27,"start_character":4,"end_line":27,"end_character":65},"updated":"2018-06-26 06:02:17.000000000","message":"and where the admin_keyring is not defined, the key is the string, is not a good idea for me","commit_id":"af4a60a671f7c3ed3a79843aebfb8171f5c3f1e8"},{"author":{"_account_id":21830,"name":"Jaesang Lee","email":"jaesang_lee@sk.com","username":"jaesanglee"},"change_message_id":"665225cf5247d3cab0981a634a0d95cc44db5ab1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"{{- if .Values.backup.external_ceph_rbd.admin_keyring }}"},{"line_number":25,"context_line":"    key \u003d {{ .Values.backup.external_ceph_rbd.admin_keyring }}"},{"line_number":26,"context_line":"{{- else }}"},{"line_number":27,"context_line":"    key \u003d \"You must define the ceph admin keyring in values.yaml.\""},{"line_number":28,"context_line":"{{- end }}"},{"line_number":29,"context_line":"EOF"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":6,"id":"5f7c97a3_2b37ff00","line":27,"range":{"start_line":27,"start_character":4,"end_line":27,"end_character":65},"in_reply_to":"5f7c97a3_67412336","updated":"2018-07-02 01:16:08.000000000","message":"Done","commit_id":"af4a60a671f7c3ed3a79843aebfb8171f5c3f1e8"}],"cinder/templates/configmap-backup.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"b6c2dd57aeacb482546efa3a2a1b44157bce14b9","unresolved":false,"context_lines":[{"line_number":38,"context_line":"{{- end }}"},{"line_number":39,"context_line":"{{- end }}"},{"line_number":40,"context_line":"{{- end }}"},{"line_number":41,"context_line":"{{- if .Values.manifests.external_ceph_rbd_configmap_etc }}"},{"line_number":42,"context_line":"{{- list \"external-ceph-rbd-etc\" . | include \"external_ceph_rbd.configmap.etc\" }}"},{"line_number":43,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_b3ae412d","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":10},"updated":"2018-06-18 13:29:08.000000000","message":"why are we doing it this way, seems complex? this pattern makes more sense when used with daemonsets that can be targeted on a per host/label basis.","commit_id":"633ecc6f4ca940f75e0cc8bc71345555ac83c521"},{"author":{"_account_id":21830,"name":"Jaesang Lee","email":"jaesang_lee@sk.com","username":"jaesanglee"},"change_message_id":"fb60798763dae8e759e946d0fb2668cdeeae5db2","unresolved":false,"context_lines":[{"line_number":38,"context_line":"{{- end }}"},{"line_number":39,"context_line":"{{- end }}"},{"line_number":40,"context_line":"{{- end }}"},{"line_number":41,"context_line":"{{- if .Values.manifests.external_ceph_rbd_configmap_etc }}"},{"line_number":42,"context_line":"{{- list \"external-ceph-rbd-etc\" . | include \"external_ceph_rbd.configmap.etc\" }}"},{"line_number":43,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_6eb985ea","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":10},"in_reply_to":"5f7c97a3_b3ae412d","updated":"2018-06-19 08:14:52.000000000","message":"Great catch, I agree that it isn\u0027t necessary to use this condition here.","commit_id":"633ecc6f4ca940f75e0cc8bc71345555ac83c521"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"af6a4cfe700e8797dd1c9c60b7943d6755a71e7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5f7c97a3_28d298d0","updated":"2018-07-02 13:48:02.000000000","message":"this file is not required","commit_id":"005e9297ddf9d659e95787fff56586db8e29b5bb"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"af6a4cfe700e8797dd1c9c60b7943d6755a71e7e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"metadata:"},{"line_number":23,"context_line":"  name: cinder-external-ceph-rbd-etc"},{"line_number":24,"context_line":"data:"},{"line_number":25,"context_line":"  ceph.conf: |"},{"line_number":26,"context_line":"{{ include \"helm-toolkit.utils.to_ini\" .Values.backup.external_ceph_rbd.conf | indent 4 }}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_68e9707d","line":25,"range":{"start_line":25,"start_character":2,"end_line":25,"end_character":11},"updated":"2018-07-02 13:48:02.000000000","message":"if this was renamed to external-backup-ceph.conf, this could be incorporated into the main etc configmap in the same way you have done for the script.","commit_id":"005e9297ddf9d659e95787fff56586db8e29b5bb"},{"author":{"_account_id":21830,"name":"Jaesang Lee","email":"jaesang_lee@sk.com","username":"jaesanglee"},"change_message_id":"501e2742064a403c088fd3f64534d368ea6f7723","unresolved":false,"context_lines":[{"line_number":22,"context_line":"metadata:"},{"line_number":23,"context_line":"  name: cinder-external-ceph-rbd-etc"},{"line_number":24,"context_line":"data:"},{"line_number":25,"context_line":"  ceph.conf: |"},{"line_number":26,"context_line":"{{ include \"helm-toolkit.utils.to_ini\" .Values.backup.external_ceph_rbd.conf | indent 4 }}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_f969c6f7","line":25,"range":{"start_line":25,"start_character":2,"end_line":25,"end_character":11},"in_reply_to":"5f7c97a3_68e9707d","updated":"2018-07-03 04:43:00.000000000","message":"pretty good advice.","commit_id":"005e9297ddf9d659e95787fff56586db8e29b5bb"}],"cinder/templates/configmap-bin.yaml":[{"author":{"_account_id":23981,"name":"Richard Wellum (rwellum)","email":"richwellum@gmail.com","username":"richwellum"},"change_message_id":"b2fa1e3c69c7cbbb0fa4001287132976cc9a2606","unresolved":false,"context_lines":[{"line_number":70,"context_line":"{{- end }}"},{"line_number":71,"context_line":"{{- if .Values.backup.external_ceph_rbd.enabled }}"},{"line_number":72,"context_line":"  external-ceph-rbd-admin-keyring.sh: |"},{"line_number":73,"context_line":"{{ tuple \"bin/_external-ceph-rbd-admin-keyring.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":74,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5f7c97a3_dee46210","line":73,"updated":"2018-07-10 16:13:07.000000000","message":"Can you wrap this to be under 80 chars like rest of file?","commit_id":"2c96100d653c4ad8835a150913ef2b6b4852e250"},{"author":{"_account_id":23981,"name":"Richard Wellum (rwellum)","email":"richwellum@gmail.com","username":"richwellum"},"change_message_id":"aa16755bfa0ea88ee3b6e7cfb7996a2eb699ea5d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"{{- end }}"},{"line_number":71,"context_line":"{{- if .Values.backup.external_ceph_rbd.enabled }}"},{"line_number":72,"context_line":"  external-ceph-rbd-admin-keyring.sh: |"},{"line_number":73,"context_line":"{{ tuple \"bin/_external-ceph-rbd-admin-keyring.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":74,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5f7c97a3_03868817","line":73,"in_reply_to":"5f7c97a3_49b5f1ec","updated":"2018-07-16 14:34:05.000000000","message":"Yes if it\u0027s that way in other files I guess this is ok - maybe no realistic choice in a template.","commit_id":"2c96100d653c4ad8835a150913ef2b6b4852e250"},{"author":{"_account_id":21830,"name":"Jaesang Lee","email":"jaesang_lee@sk.com","username":"jaesanglee"},"change_message_id":"40a9a7b3416c103ac049d18b3c652c8fe291fcae","unresolved":false,"context_lines":[{"line_number":70,"context_line":"{{- end }}"},{"line_number":71,"context_line":"{{- if .Values.backup.external_ceph_rbd.enabled }}"},{"line_number":72,"context_line":"  external-ceph-rbd-admin-keyring.sh: |"},{"line_number":73,"context_line":"{{ tuple \"bin/_external-ceph-rbd-admin-keyring.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":74,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5f7c97a3_49b5f1ec","line":73,"in_reply_to":"5f7c97a3_dee46210","updated":"2018-07-11 00:32:36.000000000","message":"In principle, it is correct to write within 80 characters. Unfortunately, however, other parts of template file that use \u0027include/ have been over 80 characters long because it is impossible to change the line while using the pipeline. . (for example, there are 168 character per one line in cinder/template/configmap-etc.yaml) \nIs there a real way to reduce it?","commit_id":"2c96100d653c4ad8835a150913ef2b6b4852e250"}],"cinder/templates/configmap-etc.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"9a161f7afaf266d2cb06552ac0ab74d17ec10a72","unresolved":false,"context_lines":[{"line_number":142,"context_line":"metadata:"},{"line_number":143,"context_line":"  name: cinder-external-ceph-rbd-etc"},{"line_number":144,"context_line":"data:"},{"line_number":145,"context_line":"  external-backup-ceph.conf: |"},{"line_number":146,"context_line":"{{ include \"helm-toolkit.utils.to_ini\" .Values.backup.external_ceph_rbd.conf | indent 4 }}"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_d5ae0a80","line":146,"range":{"start_line":145,"start_character":0,"end_line":146,"end_character":90},"updated":"2018-07-03 09:17:31.000000000","message":"if you wrap this in the conditional, just as you have for the bin-configmap, the `cinder-external-ceph-rbd-etc` is not required - and you can incorp this in the main `configmsp-etc`","commit_id":"1a588b80f3e37851114fd34f449ecdd62553ae67"},{"author":{"_account_id":21830,"name":"Jaesang Lee","email":"jaesang_lee@sk.com","username":"jaesanglee"},"change_message_id":"07dea2901e1840394a0c2ce2fc87b00d7b5002af","unresolved":false,"context_lines":[{"line_number":142,"context_line":"metadata:"},{"line_number":143,"context_line":"  name: cinder-external-ceph-rbd-etc"},{"line_number":144,"context_line":"data:"},{"line_number":145,"context_line":"  external-backup-ceph.conf: |"},{"line_number":146,"context_line":"{{ include \"helm-toolkit.utils.to_ini\" .Values.backup.external_ceph_rbd.conf | indent 4 }}"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_9450820b","line":146,"range":{"start_line":145,"start_character":0,"end_line":146,"end_character":90},"in_reply_to":"5f7c97a3_d5ae0a80","updated":"2018-07-04 02:08:10.000000000","message":"I have integrated \u0027cinder-external-ceph-rbd-etc\u0027 into cinder-etc as advised.","commit_id":"1a588b80f3e37851114fd34f449ecdd62553ae67"}],"cinder/templates/deployment-backup.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"af6a4cfe700e8797dd1c9c60b7943d6755a71e7e","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            {{ if or (eq .Values.conf.cinder.DEFAULT.backup_driver \"cinder.backup.drivers.ceph\") (include \"cinder.utils.is_ceph_volume_configured\" $envAll) }}"},{"line_number":150,"context_line":"            - name: etcceph"},{"line_number":151,"context_line":"              mountPath: /etc/ceph"},{"line_number":152,"context_line":"            {{- if .Values.backup.external_ceph_rbd.enabled }}"},{"line_number":153,"context_line":"            - name: cinder-external-ceph-rbd-etc"},{"line_number":154,"context_line":"              mountPath: /etc/ceph/ceph.conf"},{"line_number":155,"context_line":"              subPath: ceph.conf"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_28a93824","line":152,"range":{"start_line":152,"start_character":16,"end_line":152,"end_character":19},"updated":"2018-07-02 13:48:02.000000000","message":"this may be better as `if not` and the sections bellow inverted, as the primary use will not have external ceph for rbd based backup","commit_id":"005e9297ddf9d659e95787fff56586db8e29b5bb"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"af6a4cfe700e8797dd1c9c60b7943d6755a71e7e","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            {{- if .Values.backup.external_ceph_rbd.enabled }}"},{"line_number":153,"context_line":"            - name: cinder-external-ceph-rbd-etc"},{"line_number":154,"context_line":"              mountPath: /etc/ceph/ceph.conf"},{"line_number":155,"context_line":"              subPath: ceph.conf"},{"line_number":156,"context_line":"              readOnly: true"},{"line_number":157,"context_line":"            {{- else }}"},{"line_number":158,"context_line":"            - name: ceph-etc"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_28fb7848","line":155,"range":{"start_line":155,"start_character":23,"end_line":155,"end_character":32},"updated":"2018-07-02 13:48:02.000000000","message":"external-backup-ceph.conf","commit_id":"005e9297ddf9d659e95787fff56586db8e29b5bb"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"af6a4cfe700e8797dd1c9c60b7943d6755a71e7e","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            name: ceph-etc"},{"line_number":211,"context_line":"            defaultMode: 0444"},{"line_number":212,"context_line":"        {{ end }}"},{"line_number":213,"context_line":"        {{- if .Values.backup.external_ceph_rbd.enabled }}"},{"line_number":214,"context_line":"        - name: cinder-external-ceph-rbd-etc"},{"line_number":215,"context_line":"          configMap:"},{"line_number":216,"context_line":"            name: cinder-external-ceph-rbd-etc"},{"line_number":217,"context_line":"            defaultMode: 0444"},{"line_number":218,"context_line":"        {{- end }}"},{"line_number":219,"context_line":"        {{- if eq .Values.conf.cinder.DEFAULT.backup_driver \"cinder.backup.drivers.ceph\" }}"},{"line_number":220,"context_line":"        - name: ceph-backup-keyring"},{"line_number":221,"context_line":"          secret:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_489b5416","line":218,"range":{"start_line":213,"start_character":0,"end_line":218,"end_character":18},"updated":"2018-07-02 13:48:02.000000000","message":"not required if we load the config file into the main service etc configmap.","commit_id":"005e9297ddf9d659e95787fff56586db8e29b5bb"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"9a161f7afaf266d2cb06552ac0ab74d17ec10a72","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            name: ceph-etc"},{"line_number":211,"context_line":"            defaultMode: 0444"},{"line_number":212,"context_line":"        {{ end }}"},{"line_number":213,"context_line":"        {{- if .Values.backup.external_ceph_rbd.enabled }}"},{"line_number":214,"context_line":"        - name: cinder-external-ceph-rbd-etc"},{"line_number":215,"context_line":"          configMap:"},{"line_number":216,"context_line":"            name: cinder-external-ceph-rbd-etc"},{"line_number":217,"context_line":"            defaultMode: 0444"},{"line_number":218,"context_line":"        {{- end }}"},{"line_number":219,"context_line":"        {{- if eq .Values.conf.cinder.DEFAULT.backup_driver \"cinder.backup.drivers.ceph\" }}"},{"line_number":220,"context_line":"        - name: ceph-backup-keyring"},{"line_number":221,"context_line":"          secret:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_35b89ec5","line":218,"range":{"start_line":213,"start_character":0,"end_line":218,"end_character":18},"updated":"2018-07-03 09:17:31.000000000","message":"not required.","commit_id":"1a588b80f3e37851114fd34f449ecdd62553ae67"}],"cinder/templates/job-backup-storage-init.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"9a161f7afaf266d2cb06552ac0ab74d17ec10a72","unresolved":false,"context_lines":[{"line_number":157,"context_line":"          configMap:"},{"line_number":158,"context_line":"            name: ceph-etc"},{"line_number":159,"context_line":"            defaultMode: 0444"},{"line_number":160,"context_line":"        {{- if .Values.backup.external_ceph_rbd.enabled }}"},{"line_number":161,"context_line":"        - name: cinder-external-ceph-rbd-etc"},{"line_number":162,"context_line":"          configMap:"},{"line_number":163,"context_line":"            name: cinder-external-ceph-rbd-etc"},{"line_number":164,"context_line":"            defaultMode: 0444"},{"line_number":165,"context_line":"        {{- end }}"},{"line_number":166,"context_line":"        {{- if empty .Values.conf.ceph.admin_keyring }}"},{"line_number":167,"context_line":"        - name: ceph-keyring"},{"line_number":168,"context_line":"          secret:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_d5fcca73","line":165,"range":{"start_line":160,"start_character":0,"end_line":165,"end_character":18},"updated":"2018-07-03 09:17:31.000000000","message":"not required","commit_id":"1a588b80f3e37851114fd34f449ecdd62553ae67"}],"cinder/values.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"50acaf75bc580b0f804396ebaa1a95facc1caa72","unresolved":false,"context_lines":[{"line_number":793,"context_line":"      class_name: general"},{"line_number":794,"context_line":"      size: 10Gi"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"backup_ceph:"},{"line_number":797,"context_line":"  enabled: false"},{"line_number":798,"context_line":"  admin_keyring: null"},{"line_number":799,"context_line":"  conf:"},{"line_number":800,"context_line":"    global:"},{"line_number":801,"context_line":"      mon_host: null"},{"line_number":802,"context_line":"    osd:"},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"dependencies:"},{"line_number":805,"context_line":"  dynamic:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_924b3baf","line":802,"range":{"start_line":796,"start_character":0,"end_line":802,"end_character":8},"updated":"2018-06-14 14:55:54.000000000","message":"can we move this to live under the `backup` key as `external_ceph_rbd`","commit_id":"705cddda0b741719d1062f52f3f0352105f60d96"},{"author":{"_account_id":21830,"name":"Jaesang Lee","email":"jaesang_lee@sk.com","username":"jaesanglee"},"change_message_id":"8bcbecf5e79649f7149ec5b6ae5a5c80cefe4cc1","unresolved":false,"context_lines":[{"line_number":793,"context_line":"      class_name: general"},{"line_number":794,"context_line":"      size: 10Gi"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"backup_ceph:"},{"line_number":797,"context_line":"  enabled: false"},{"line_number":798,"context_line":"  admin_keyring: null"},{"line_number":799,"context_line":"  conf:"},{"line_number":800,"context_line":"    global:"},{"line_number":801,"context_line":"      mon_host: null"},{"line_number":802,"context_line":"    osd:"},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"dependencies:"},{"line_number":805,"context_line":"  dynamic:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_214f69bf","line":802,"range":{"start_line":796,"start_character":0,"end_line":802,"end_character":8},"in_reply_to":"5f7c97a3_924b3baf","updated":"2018-06-15 00:16:38.000000000","message":"Yes, It seems like a much better key name.","commit_id":"705cddda0b741719d1062f52f3f0352105f60d96"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"56a5b7e4b886f144f825af88ab79632c8aa45a81","unresolved":false,"context_lines":[{"line_number":793,"context_line":"      class_name: general"},{"line_number":794,"context_line":"      size: 10Gi"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"external_ceph_rbd:"},{"line_number":797,"context_line":"  enabled: false"},{"line_number":798,"context_line":"  admin_keyring: null"},{"line_number":799,"context_line":"  conf:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_42f5b5cb","line":796,"range":{"start_line":796,"start_character":0,"end_line":796,"end_character":18},"updated":"2018-06-15 15:10:18.000000000","message":"still need to move this under the `backup` key.","commit_id":"29c02ef6aa1ea303c40f23fa65fedcfc0761a68d"},{"author":{"_account_id":21830,"name":"Jaesang Lee","email":"jaesang_lee@sk.com","username":"jaesanglee"},"change_message_id":"0dad18b60b9c7ec4762a5f2c8410a723142bf01b","unresolved":false,"context_lines":[{"line_number":793,"context_line":"      class_name: general"},{"line_number":794,"context_line":"      size: 10Gi"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"external_ceph_rbd:"},{"line_number":797,"context_line":"  enabled: false"},{"line_number":798,"context_line":"  admin_keyring: null"},{"line_number":799,"context_line":"  conf:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_67478d20","line":796,"range":{"start_line":796,"start_character":0,"end_line":796,"end_character":18},"in_reply_to":"5f7c97a3_42f5b5cb","updated":"2018-06-17 22:58:26.000000000","message":"It is reasonable. It was in patch 5.","commit_id":"29c02ef6aa1ea303c40f23fa65fedcfc0761a68d"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"9a161f7afaf266d2cb06552ac0ab74d17ec10a72","unresolved":false,"context_lines":[{"line_number":1234,"context_line":"  deployment_backup: true"},{"line_number":1235,"context_line":"  deployment_scheduler: true"},{"line_number":1236,"context_line":"  deployment_volume: true"},{"line_number":1237,"context_line":"  external_ceph_rbd_configmap_etc: false"},{"line_number":1238,"context_line":"  ingress_api: true"},{"line_number":1239,"context_line":"  job_backup_storage_init: true"},{"line_number":1240,"context_line":"  job_bootstrap: true"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_f5ff8663","line":1237,"range":{"start_line":1237,"start_character":2,"end_line":1237,"end_character":40},"updated":"2018-07-03 09:17:31.000000000","message":"not used anywhere.","commit_id":"1a588b80f3e37851114fd34f449ecdd62553ae67"}]}