)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"change_message_id":"2a2376573ddd6baf2ac583b341567dc899166486","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add fluentbit sidecars to ceph mon and ceph osd charts"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This adds fluentbit sidecar containers to the ceph mon and ceph"},{"line_number":10,"context_line":"osd charts, allowing for the gathering of ceph logs that arent"},{"line_number":11,"context_line":"sent to stdout and stderr. This sidecar container mounts a shared"},{"line_number":12,"context_line":"directory on /var/log/ceph, and fluentbit is configured to tail"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5f7c97a3_32f69eda","line":9,"updated":"2018-06-18 22:29:53.000000000","message":"Steve I feel like we could just concatenate all your commit messages together and turn it into our comprehensive technical documentation.  You could read these things to children as bedtime stories.","commit_id":"68c5f45b62de5558ca0acfb69ef2a2571a46cbc8"}],"ceph-osd/templates/utils/_osd_daemonset_overrides.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"0dad8985a2f649fd505b343f70efb70c3b109492","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    {{- $container :\u003d first $context.Values.__daemonset_yaml.spec.template.spec.containers }}"},{"line_number":223,"context_line":"    {{- $_ :\u003d set $container \"name\" $current_dict.dns_1123_name }}"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    {{/* get fluentbit sidecar container out of defined container list */}}"},{"line_number":226,"context_line":"    {{- $fluentbit_sidecar :\u003d last $context.Values.__daemonset_yaml.spec.template.spec.containers }}"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    {{/* add ceph-osd container and fluentbit sidecar container to list of containers */}}"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    {{- $cont_list :\u003d list $container $fluentbit_sidecar }}"},{"line_number":231,"context_line":"    {{- $_ :\u003d set $context.Values.__daemonset_yaml.spec.template.spec \"containers\" $cont_list }}"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    {{/* cross-reference configmap name to container volume definitions */}}"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"5f7c97a3_5a8fbacc","line":230,"range":{"start_line":225,"start_character":0,"end_line":230,"end_character":59},"updated":"2018-06-18 16:17:53.000000000","message":"can we iterate through this, rather than make assumptions? at the very least we will need to account for the case, where the 1st and last container are the same (ie - hen the fluentbit sidecars is not present)","commit_id":"06609c96b4d9aca5942488618c40bf3873028d18"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"ddf37dca3fe3285e46cba43637da078508ba1808","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    {{- $_ :\u003d set $context.Values.__daemonset_yaml.metadata \"name\" $current_dict.dns_1123_name }}"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    {{/* set container names and add to the list of containers for the pod */}}"},{"line_number":221,"context_line":"    {{ $_ :\u003d set $context.Values \"__containers_list\" ( list ) }}"},{"line_number":222,"context_line":"    {{- range $container :\u003d $context.Values.__daemonset_yaml.spec.template.spec.containers }}"},{"line_number":223,"context_line":"    {{- if eq $container.name \"osd-pod\" }}"},{"line_number":224,"context_line":"    {{- $_ :\u003d set $container \"name\" $current_dict.dns_1123_name }}"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"5f7c97a3_e92ef840","line":221,"range":{"start_line":221,"start_character":6,"end_line":221,"end_character":7},"updated":"2018-06-19 01:00:57.000000000","message":"nit: could do with a leading `-` here","commit_id":"68c5f45b62de5558ca0acfb69ef2a2571a46cbc8"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"0929c500f48f47a31f2a40d41e8348b301044eac","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    {{- $_ :\u003d set $context.Values.__daemonset_yaml.metadata \"name\" $current_dict.dns_1123_name }}"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    {{/* set container names and add to the list of containers for the pod */}}"},{"line_number":221,"context_line":"    {{ $_ :\u003d set $context.Values \"__containers_list\" ( list ) }}"},{"line_number":222,"context_line":"    {{- range $container :\u003d $context.Values.__daemonset_yaml.spec.template.spec.containers }}"},{"line_number":223,"context_line":"    {{- if eq $container.name \"osd-pod\" }}"},{"line_number":224,"context_line":"    {{- $_ :\u003d set $container \"name\" $current_dict.dns_1123_name }}"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"5f7c97a3_2a34d0de","line":221,"range":{"start_line":221,"start_character":6,"end_line":221,"end_character":7},"in_reply_to":"5f7c97a3_e92ef840","updated":"2018-06-19 14:22:10.000000000","message":"Done","commit_id":"68c5f45b62de5558ca0acfb69ef2a2571a46cbc8"}],"ceph-osd/values.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"ddf37dca3fe3285e46cba43637da078508ba1808","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        Log_Level: info"},{"line_number":139,"context_line":"        Parsers_File: parsers.conf"},{"line_number":140,"context_line":"    - ceph_tail:"},{"line_number":141,"context_line":"        header: input"},{"line_number":142,"context_line":"        Name: tail"},{"line_number":143,"context_line":"        Tag: ceph-osd.*"},{"line_number":144,"context_line":"        Path: /var/log/ceph/ceph-osd.**.log"},{"line_number":145,"context_line":"        Parser: syslog"},{"line_number":146,"context_line":"        DB: /var/log/ceph/ceph-osd.db"},{"line_number":147,"context_line":"        Mem_Buf_Limit: 5MB"},{"line_number":148,"context_line":"        Refresh_Interval: 10s"},{"line_number":149,"context_line":"    - fluentd_output:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_c9b9bcec","line":146,"range":{"start_line":141,"start_character":0,"end_line":146,"end_character":37},"updated":"2018-06-19 01:00:57.000000000","message":"we should note that although exposed as params, these values are effectively fixed.","commit_id":"68c5f45b62de5558ca0acfb69ef2a2571a46cbc8"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"0929c500f48f47a31f2a40d41e8348b301044eac","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        Log_Level: info"},{"line_number":139,"context_line":"        Parsers_File: parsers.conf"},{"line_number":140,"context_line":"    - ceph_tail:"},{"line_number":141,"context_line":"        header: input"},{"line_number":142,"context_line":"        Name: tail"},{"line_number":143,"context_line":"        Tag: ceph-osd.*"},{"line_number":144,"context_line":"        Path: /var/log/ceph/ceph-osd.**.log"},{"line_number":145,"context_line":"        Parser: syslog"},{"line_number":146,"context_line":"        DB: /var/log/ceph/ceph-osd.db"},{"line_number":147,"context_line":"        Mem_Buf_Limit: 5MB"},{"line_number":148,"context_line":"        Refresh_Interval: 10s"},{"line_number":149,"context_line":"    - fluentd_output:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_8a73a4b4","line":146,"range":{"start_line":141,"start_character":0,"end_line":146,"end_character":37},"in_reply_to":"5f7c97a3_c9b9bcec","updated":"2018-06-19 14:22:10.000000000","message":"Done","commit_id":"68c5f45b62de5558ca0acfb69ef2a2571a46cbc8"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"ddf37dca3fe3285e46cba43637da078508ba1808","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        header: output"},{"line_number":151,"context_line":"        Name: forward"},{"line_number":152,"context_line":"        Match: \"*\""},{"line_number":153,"context_line":"        Host: ${FLUENTD_HOST}"},{"line_number":154,"context_line":"        Port: ${FLUENTD_PORT}"},{"line_number":155,"context_line":"  parsers:"},{"line_number":156,"context_line":"    - syslog:"},{"line_number":157,"context_line":"        header: parser"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_a984800c","line":154,"range":{"start_line":153,"start_character":0,"end_line":154,"end_character":29},"updated":"2018-06-19 01:00:57.000000000","message":"how are these populated? we should either note that these are driven by the env vars on the pod, in which case they are like above - not parameters that can be changed, or ideally drive them in the same way we drive other config params in osh, and set them to `null` here and then populate during rendering of the configmap.","commit_id":"68c5f45b62de5558ca0acfb69ef2a2571a46cbc8"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"0929c500f48f47a31f2a40d41e8348b301044eac","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        header: output"},{"line_number":151,"context_line":"        Name: forward"},{"line_number":152,"context_line":"        Match: \"*\""},{"line_number":153,"context_line":"        Host: ${FLUENTD_HOST}"},{"line_number":154,"context_line":"        Port: ${FLUENTD_PORT}"},{"line_number":155,"context_line":"  parsers:"},{"line_number":156,"context_line":"    - syslog:"},{"line_number":157,"context_line":"        header: parser"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_ea42583b","line":154,"range":{"start_line":153,"start_character":0,"end_line":154,"end_character":29},"in_reply_to":"5f7c97a3_a984800c","updated":"2018-06-19 14:22:10.000000000","message":"Done","commit_id":"68c5f45b62de5558ca0acfb69ef2a2571a46cbc8"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"ddf37dca3fe3285e46cba43637da078508ba1808","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        Types: \"pid:integer\""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"logging:"},{"line_number":167,"context_line":"  fluentd:"},{"line_number":168,"context_line":"    enabled: false"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"dependencies:"},{"line_number":171,"context_line":"  dynamic:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_49e4cc0e","line":168,"range":{"start_line":167,"start_character":10,"end_line":168,"end_character":18},"updated":"2018-06-19 01:00:57.000000000","message":"why do we need a key for enabling? this would be cleaner as a single `fluentd: true/false` toggle","commit_id":"68c5f45b62de5558ca0acfb69ef2a2571a46cbc8"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"0929c500f48f47a31f2a40d41e8348b301044eac","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        Types: \"pid:integer\""},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"logging:"},{"line_number":167,"context_line":"  fluentd:"},{"line_number":168,"context_line":"    enabled: false"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"dependencies:"},{"line_number":171,"context_line":"  dynamic:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_2a3930ce","line":168,"range":{"start_line":167,"start_character":10,"end_line":168,"end_character":18},"in_reply_to":"5f7c97a3_49e4cc0e","updated":"2018-06-19 14:22:10.000000000","message":"Done","commit_id":"68c5f45b62de5558ca0acfb69ef2a2571a46cbc8"}],"tools/deployment/developer/ceph/040-ceph.sh":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"ddf37dca3fe3285e46cba43637da078508ba1808","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    mds: 1"},{"line_number":162,"context_line":"    mgr: 1"},{"line_number":163,"context_line":"    rgw: 1"},{"line_number":164,"context_line":"logging:"},{"line_number":165,"context_line":"  fluentd:"},{"line_number":166,"context_line":"    enabled: true"},{"line_number":167,"context_line":"EOF"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"for CHART in ceph-mon ceph-osd ceph-client; do"}],"source_content_type":"text/x-sh","patch_set":8,"id":"5f7c97a3_e98fd81f","line":166,"range":{"start_line":164,"start_character":0,"end_line":166,"end_character":17},"updated":"2018-06-19 01:00:57.000000000","message":"do we want to enable this, when fluentd is not present (yet!) in the developer env?","commit_id":"68c5f45b62de5558ca0acfb69ef2a2571a46cbc8"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"0929c500f48f47a31f2a40d41e8348b301044eac","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    mds: 1"},{"line_number":162,"context_line":"    mgr: 1"},{"line_number":163,"context_line":"    rgw: 1"},{"line_number":164,"context_line":"logging:"},{"line_number":165,"context_line":"  fluentd:"},{"line_number":166,"context_line":"    enabled: true"},{"line_number":167,"context_line":"EOF"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"for CHART in ceph-mon ceph-osd ceph-client; do"}],"source_content_type":"text/x-sh","patch_set":8,"id":"5f7c97a3_eafa58b8","line":166,"range":{"start_line":164,"start_character":0,"end_line":166,"end_character":17},"in_reply_to":"5f7c97a3_e98fd81f","updated":"2018-06-19 14:22:10.000000000","message":"Done","commit_id":"68c5f45b62de5558ca0acfb69ef2a2571a46cbc8"}],"tools/deployment/multinode/030-ceph.sh":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"ddf37dca3fe3285e46cba43637da078508ba1808","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        journal:"},{"line_number":75,"context_line":"          type: directory"},{"line_number":76,"context_line":"          location: /var/lib/openstack-helm/ceph/osd/journal-one"},{"line_number":77,"context_line":"logging:"},{"line_number":78,"context_line":"  fluentd:"},{"line_number":79,"context_line":"    enabled: true"},{"line_number":80,"context_line":"EOF"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"for CHART in ceph-mon ceph-osd ceph-client; do"}],"source_content_type":"text/x-sh","patch_set":8,"id":"5f7c97a3_8996643e","line":79,"range":{"start_line":77,"start_character":0,"end_line":79,"end_character":17},"updated":"2018-06-19 01:00:57.000000000","message":"do we want to enable this, when fluentd is not present (yet!) in the multinode gate env?","commit_id":"68c5f45b62de5558ca0acfb69ef2a2571a46cbc8"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"0929c500f48f47a31f2a40d41e8348b301044eac","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        journal:"},{"line_number":75,"context_line":"          type: directory"},{"line_number":76,"context_line":"          location: /var/lib/openstack-helm/ceph/osd/journal-one"},{"line_number":77,"context_line":"logging:"},{"line_number":78,"context_line":"  fluentd:"},{"line_number":79,"context_line":"    enabled: true"},{"line_number":80,"context_line":"EOF"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"for CHART in ceph-mon ceph-osd ceph-client; do"}],"source_content_type":"text/x-sh","patch_set":8,"id":"5f7c97a3_4a258c5b","line":79,"range":{"start_line":77,"start_character":0,"end_line":79,"end_character":17},"in_reply_to":"5f7c97a3_8996643e","updated":"2018-06-19 14:22:10.000000000","message":"Done","commit_id":"68c5f45b62de5558ca0acfb69ef2a2571a46cbc8"}]}