)]}'
{"barbican/templates/deployment-api.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"e1559cfaf3fbc56a10f4b55ccb8957fe4a5de741","unresolved":false,"context_lines":[{"line_number":83,"context_line":"              subPath: barbican.conf"},{"line_number":84,"context_line":"              readOnly: true"},{"line_number":85,"context_line":"            - name: barbican-etc"},{"line_number":86,"context_line":"              mountPath: /etc/barbican/logging.conf"},{"line_number":87,"context_line":"              subPath: logging.conf"},{"line_number":88,"context_line":"              readOnly: true"},{"line_number":89,"context_line":"            - name: barbican-etc"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"5f7c97a3_1b6b5ff1","line":86,"range":{"start_line":86,"start_character":25,"end_line":86,"end_character":51},"updated":"2018-06-20 00:57:16.000000000","message":"in a future ps - it would be nice to drive this from the config param that states where it is.","commit_id":"bd740cd1633de63d6ec1ff0dc4cae2670d8553d5"}],"barbican/templates/job-bootstrap.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"e1559cfaf3fbc56a10f4b55ccb8957fe4a5de741","unresolved":false,"context_lines":[{"line_number":17,"context_line":"{{- define \"barbican.templates._job_bootstrap.pod_volumes\" -}}"},{"line_number":18,"context_line":"{{- $envAll :\u003d index . 0 -}}"},{"line_number":19,"context_line":"volumeMounts:"},{"line_number":20,"context_line":"  - name: barbican-etc"},{"line_number":21,"context_line":"    mountPath: /etc/barbican/logging.conf"},{"line_number":22,"context_line":"    subPath: logging.conf"},{"line_number":23,"context_line":"    readOnly: true"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"5f7c97a3_7b4db397","line":20,"range":{"start_line":20,"start_character":10,"end_line":20,"end_character":22},"updated":"2018-06-20 00:57:16.000000000","message":"should be `bootstrap-conf`.","commit_id":"bd740cd1633de63d6ec1ff0dc4cae2670d8553d5"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"e1559cfaf3fbc56a10f4b55ccb8957fe4a5de741","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    mountPath: /etc/barbican/logging.conf"},{"line_number":22,"context_line":"    subPath: logging.conf"},{"line_number":23,"context_line":"    readOnly: true"},{"line_number":24,"context_line":"volumes:"},{"line_number":25,"context_line":"  - name: barbican-etc"},{"line_number":26,"context_line":"    configMap:"},{"line_number":27,"context_line":"      name: barbican-etc"},{"line_number":28,"context_line":"      defaultMode: 0444"},{"line_number":29,"context_line":"{{- end }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{{- if and .Values.manifests.job_bootstrap .Values.bootstrap.enabled }}"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"5f7c97a3_9b7e8fad","line":28,"range":{"start_line":24,"start_character":0,"end_line":28,"end_character":23},"updated":"2018-06-20 00:57:16.000000000","message":"not required (see above)","commit_id":"bd740cd1633de63d6ec1ff0dc4cae2670d8553d5"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"e9bf218fd108450af082d41696dc8717d95c30ba","unresolved":false,"context_lines":[{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if and .Values.manifests.job_bootstrap .Values.bootstrap.enabled }}"},{"line_number":18,"context_line":"{{- $bootstrapJob :\u003d dict \"envAll\" . \"serviceName\" \"barbican\" \"keystoneUser\" .Values.bootstrap.ks_user \"logConfigFile\" \"/etc/barbican/logging.conf\" -}}"},{"line_number":19,"context_line":"{{ $bootstrapJob | include \"helm-toolkit.manifests.job_bootstrap\" }}"},{"line_number":20,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"5f7c97a3_8073134e","line":18,"range":{"start_line":18,"start_character":119,"end_line":18,"end_character":147},"updated":"2018-06-25 18:59:47.000000000","message":".Values.conf.barbican.DEFAULT.transport_url.log_config_append","commit_id":"b179bcdd0a86c1ec67aca5b7608231b10efd7145"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"28f8d0863ed06dbc3a40bd930f7f751f882c8729","unresolved":false,"context_lines":[{"line_number":15,"context_line":"*/}}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{- if and .Values.manifests.job_bootstrap .Values.bootstrap.enabled }}"},{"line_number":18,"context_line":"{{- $bootstrapJob :\u003d dict \"envAll\" . \"serviceName\" \"barbican\" \"keystoneUser\" .Values.bootstrap.ks_user \"logConfigFile\" \"/etc/barbican/logging.conf\" -}}"},{"line_number":19,"context_line":"{{ $bootstrapJob | include \"helm-toolkit.manifests.job_bootstrap\" }}"},{"line_number":20,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"5f7c97a3_00e383d9","line":18,"range":{"start_line":18,"start_character":119,"end_line":18,"end_character":147},"in_reply_to":"5f7c97a3_8073134e","updated":"2018-06-25 19:07:31.000000000","message":"Done","commit_id":"b179bcdd0a86c1ec67aca5b7608231b10efd7145"}],"barbican/values.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"163a4b373876d77bba68b9f36644a9e003bca940","unresolved":false,"context_lines":[{"line_number":446,"context_line":"      handlers: null"},{"line_number":447,"context_line":"    logger_barbican:"},{"line_number":448,"context_line":"      level: INFO"},{"line_number":449,"context_line":"      handlers: stdout, stderr"},{"line_number":450,"context_line":"      qualname: barbican"},{"line_number":451,"context_line":"    logger_amqp:"},{"line_number":452,"context_line":"      level: WARNING"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5f7c97a3_6a096829","line":449,"range":{"start_line":449,"start_character":16,"end_line":449,"end_character":30},"updated":"2018-06-19 14:09:50.000000000","message":"should be in list format","commit_id":"58b197d4142e1792c275f0d00a7ebe578f41278d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"22fdd66819fa7884960b04d80d46b9869eb74299","unresolved":false,"context_lines":[{"line_number":446,"context_line":"      handlers: null"},{"line_number":447,"context_line":"    logger_barbican:"},{"line_number":448,"context_line":"      level: INFO"},{"line_number":449,"context_line":"      handlers: stdout, stderr"},{"line_number":450,"context_line":"      qualname: barbican"},{"line_number":451,"context_line":"    logger_amqp:"},{"line_number":452,"context_line":"      level: WARNING"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5f7c97a3_8d4ade58","line":449,"range":{"start_line":449,"start_character":16,"end_line":449,"end_character":30},"in_reply_to":"5f7c97a3_6a096829","updated":"2018-06-19 14:40:11.000000000","message":"Done","commit_id":"58b197d4142e1792c275f0d00a7ebe578f41278d"}],"cinder/templates/configmap-etc.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"4513b99100f6ca573949808e03ac489fb54b84e4","unresolved":false,"context_lines":[{"line_number":98,"context_line":"{{ $fluentd_host :\u003d tuple \"fluentd\" \"internal\" $envAll | include \"helm-toolkit.endpoints.hostname_namespaced_endpoint_lookup\" }}"},{"line_number":99,"context_line":"{{ $fluentd_port :\u003d tuple \"fluentd\" \"internal\" \"service\" $envAll | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":100,"context_line":"{{ $fluentd_args :\u003d printf \"(\u0027openstack.cinder\u0027, \u0027%s\u0027, %s)\" $fluentd_host $fluentd_port }}"},{"line_number":101,"context_line":"{{ set .Values.conf.logging.handler_fluent \"args\" $fluentd_args }}"},{"line_number":102,"context_line":"{{- end -}}"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"{{- if and .Values.logging.fluentd.enabled (empty .Values.conf.cinder.DEFAULT.log_config_append) -}}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_496a8c1b","line":101,"range":{"start_line":101,"start_character":0,"end_line":101,"end_character":3},"updated":"2018-06-19 01:18:40.000000000","message":"we should ensure the output is suppressed here with `{{- $_ :\u003d `","commit_id":"8d4d7f2f978403b6c0c167d808fe8d3d1d0405a9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"4513b99100f6ca573949808e03ac489fb54b84e4","unresolved":false,"context_lines":[{"line_number":102,"context_line":"{{- end -}}"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"{{- if and .Values.logging.fluentd.enabled (empty .Values.conf.cinder.DEFAULT.log_config_append) -}}"},{"line_number":105,"context_line":"{{ set .Values.conf.cinder.DEFAULT \"log_config_append\" \"/etc/cinder/logging.conf\" }}"},{"line_number":106,"context_line":"{{- end -}}"},{"line_number":107,"context_line":"---"},{"line_number":108,"context_line":"apiVersion: v1"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_097494fd","line":105,"range":{"start_line":105,"start_character":0,"end_line":105,"end_character":7},"updated":"2018-06-19 01:18:40.000000000","message":"we should ensure output is suppressed with `{{- $_ :\u003d `","commit_id":"8d4d7f2f978403b6c0c167d808fe8d3d1d0405a9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"e1559cfaf3fbc56a10f4b55ccb8957fe4a5de741","unresolved":false,"context_lines":[{"line_number":95,"context_line":"{{- end -}}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"{{- if and (empty .Values.conf.logging.handler_fluent) (has \"fluent\" .Values.conf.logging.handlers.keys) -}}"},{"line_number":98,"context_line":"{{ $fluentd_host :\u003d tuple \"fluentd\" \"internal\" $envAll | include \"helm-toolkit.endpoints.hostname_namespaced_endpoint_lookup\" }}"},{"line_number":99,"context_line":"{{ $fluentd_port :\u003d tuple \"fluentd\" \"internal\" \"service\" $envAll | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":100,"context_line":"{{ $fluent_args :\u003d printf \"(\u0027openstack.cinder\u0027, \u0027%s\u0027, %s)\" $fluentd_host $fluentd_port }}"},{"line_number":101,"context_line":"{{- $handler_fluent :\u003d dict \"class\" \"fluent.handler.FluentHandler\" \"formatter\" \"fluent\" \"args\" $fluent_args -}}"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"5f7c97a3_fb58e357","line":98,"range":{"start_line":98,"start_character":0,"end_line":98,"end_character":2},"updated":"2018-06-20 00:57:16.000000000","message":"nit: (non-blocking) we should be able to prefix these with `{{-` to avoid excess ws in rendered output.","commit_id":"bd740cd1633de63d6ec1ff0dc4cae2670d8553d5"}],"cinder/values.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"4513b99100f6ca573949808e03ac489fb54b84e4","unresolved":false,"context_lines":[{"line_number":765,"context_line":"      qualname: cinder"},{"line_number":766,"context_line":"    logger_amqp:"},{"line_number":767,"context_line":"      level: WARNING"},{"line_number":768,"context_line":"      handlers: stderr"},{"line_number":769,"context_line":"      qualname: amqp"},{"line_number":770,"context_line":"    logger_amqplib:"},{"line_number":771,"context_line":"      level: WARNING"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_89ce642b","line":768,"range":{"start_line":768,"start_character":6,"end_line":768,"end_character":22},"updated":"2018-06-19 01:18:40.000000000","message":"do we have any way to drive these on a wholescale basis?","commit_id":"8d4d7f2f978403b6c0c167d808fe8d3d1d0405a9"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"22fdd66819fa7884960b04d80d46b9869eb74299","unresolved":false,"context_lines":[{"line_number":765,"context_line":"      qualname: cinder"},{"line_number":766,"context_line":"    logger_amqp:"},{"line_number":767,"context_line":"      level: WARNING"},{"line_number":768,"context_line":"      handlers: stderr"},{"line_number":769,"context_line":"      qualname: amqp"},{"line_number":770,"context_line":"    logger_amqplib:"},{"line_number":771,"context_line":"      level: WARNING"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_f59b2bc5","line":768,"range":{"start_line":768,"start_character":6,"end_line":768,"end_character":22},"in_reply_to":"5f7c97a3_89ce642b","updated":"2018-06-19 14:40:11.000000000","message":"How do you mean? Each logger needs the level and handler identified as far as I\u0027m aware.","commit_id":"8d4d7f2f978403b6c0c167d808fe8d3d1d0405a9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"4513b99100f6ca573949808e03ac489fb54b84e4","unresolved":false,"context_lines":[{"line_number":972,"context_line":"logging:"},{"line_number":973,"context_line":"  fluentd:"},{"line_number":974,"context_line":"    enabled: true"},{"line_number":975,"context_line":"    handler:"},{"line_number":976,"context_line":"      class: fluent.handler.FluentHandler"},{"line_number":977,"context_line":"      formatter: fluent"},{"line_number":978,"context_line":"    formatter:"},{"line_number":979,"context_line":"      class: oslo_log.formatters.FluentFormatter"},{"line_number":980,"context_line":""},{"line_number":981,"context_line":"# Names of secrets used by bootstrap and environmental checks"},{"line_number":982,"context_line":"secrets:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f7c97a3_694e68c3","line":979,"range":{"start_line":975,"start_character":0,"end_line":979,"end_character":48},"updated":"2018-06-19 01:18:40.000000000","message":"is this required? would it not be better to embed this within the configmap rendering - as its not going to change.","commit_id":"8d4d7f2f978403b6c0c167d808fe8d3d1d0405a9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"163a4b373876d77bba68b9f36644a9e003bca940","unresolved":false,"context_lines":[{"line_number":769,"context_line":"      handlers: null"},{"line_number":770,"context_line":"    logger_cinder:"},{"line_number":771,"context_line":"      level: INFO"},{"line_number":772,"context_line":"      handlers: stdout, stderr"},{"line_number":773,"context_line":"      qualname: cinder"},{"line_number":774,"context_line":"    logger_amqp:"},{"line_number":775,"context_line":"      level: WARNING"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5f7c97a3_4a1fcc5a","line":772,"range":{"start_line":772,"start_character":16,"end_line":772,"end_character":30},"updated":"2018-06-19 14:09:50.000000000","message":"should be in list format","commit_id":"58b197d4142e1792c275f0d00a7ebe578f41278d"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"22fdd66819fa7884960b04d80d46b9869eb74299","unresolved":false,"context_lines":[{"line_number":769,"context_line":"      handlers: null"},{"line_number":770,"context_line":"    logger_cinder:"},{"line_number":771,"context_line":"      level: INFO"},{"line_number":772,"context_line":"      handlers: stdout, stderr"},{"line_number":773,"context_line":"      qualname: cinder"},{"line_number":774,"context_line":"    logger_amqp:"},{"line_number":775,"context_line":"      level: WARNING"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5f7c97a3_ed2d928f","line":772,"range":{"start_line":772,"start_character":16,"end_line":772,"end_character":30},"in_reply_to":"5f7c97a3_4a1fcc5a","updated":"2018-06-19 14:40:11.000000000","message":"Done","commit_id":"58b197d4142e1792c275f0d00a7ebe578f41278d"}]}