)]}'
{"libvirt/templates/daemonset-libvirt.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"ee03a023dd6f9baf3163f89c78aebb5759801f4d","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                - virsh"},{"line_number":128,"context_line":"                - version"},{"line_number":129,"context_line":"                - --daemon"},{"line_number":130,"context_line":"            initialDelaySeconds: 20"},{"line_number":131,"context_line":"            periodSeconds: 10"},{"line_number":132,"context_line":"          volumeMounts:"},{"line_number":133,"context_line":"            - name: libvirt-bin"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5f7c97a3_0a7f22df","line":130,"range":{"start_line":130,"start_character":0,"end_line":130,"end_character":35},"updated":"2018-06-25 17:39:57.000000000","message":"libVirt usually starts up quickly, 20s is fine but lower would also be ok","commit_id":"52e569575e6bbec7dca1ed96b5d72658ff9da1c8"}],"nova/templates/bin/_nova-api-metadata.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6e8b246d65d69178e39a574ff7750a4e3e028207","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2017-2018 The Openstack-Helm Authors."},{"line_number":5,"context_line":"Copyright 2018 OpenStack Tripleo-Common Authors."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":8,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":25,"id":"5f7c97a3_f4e7a30e","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":48},"updated":"2018-07-02 10:11:20.000000000","message":"?","commit_id":"cd031e74e14f95821266477121981f8cc8105956"}],"nova/templates/bin/_nova-compute-ironic.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6e8b246d65d69178e39a574ff7750a4e3e028207","unresolved":false,"context_lines":[{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"function readyCheck () {"},{"line_number":30,"context_line":"  bash -c \u0027ss -n -p -A tcp \"( dst :${RABBITMQ_PORTS} )\" | grep \"nova-compute\"\u0027"},{"line_number":31,"context_line":"  exit $?"},{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":25,"id":"5f7c97a3_b48e0b24","line":30,"range":{"start_line":30,"start_character":58,"end_line":30,"end_character":77},"updated":"2018-07-02 10:11:20.000000000","message":"we should use `grep -q` here, to suppress filling kubectl output.","commit_id":"cd031e74e14f95821266477121981f8cc8105956"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6e8b246d65d69178e39a574ff7750a4e3e028207","unresolved":false,"context_lines":[{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"function readyCheck () {"},{"line_number":30,"context_line":"  bash -c \u0027ss -n -p -A tcp \"( dst :${RABBITMQ_PORTS} )\" | grep \"nova-compute\"\u0027"},{"line_number":31,"context_line":"  exit $?"},{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":25,"id":"5f7c97a3_5480d7f7","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":9},"updated":"2018-07-02 10:11:20.000000000","message":"why spawn another bash simply to get the exit code from it? we have set -e on line 19","commit_id":"cd031e74e14f95821266477121981f8cc8105956"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"75ae8e7ab2129a512e26310c7d211256e34aef3a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"function readyCheck () {"},{"line_number":30,"context_line":"  bash -c \u0027ss -n -p -A tcp \"( dst :${RABBITMQ_PORTS} )\" | grep \"nova-compute\"\u0027"},{"line_number":31,"context_line":"  exit $?"},{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":25,"id":"5f7c97a3_e35a831c","line":30,"range":{"start_line":30,"start_character":2,"end_line":30,"end_character":9},"in_reply_to":"5f7c97a3_5480d7f7","updated":"2018-07-02 14:01:08.000000000","message":"Done","commit_id":"cd031e74e14f95821266477121981f8cc8105956"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"75ae8e7ab2129a512e26310c7d211256e34aef3a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"function readyCheck () {"},{"line_number":30,"context_line":"  bash -c \u0027ss -n -p -A tcp \"( dst :${RABBITMQ_PORTS} )\" | grep \"nova-compute\"\u0027"},{"line_number":31,"context_line":"  exit $?"},{"line_number":32,"context_line":"}"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":25,"id":"5f7c97a3_83970f9d","line":30,"range":{"start_line":30,"start_character":58,"end_line":30,"end_character":77},"in_reply_to":"5f7c97a3_b48e0b24","updated":"2018-07-02 14:01:08.000000000","message":"Done","commit_id":"cd031e74e14f95821266477121981f8cc8105956"}],"nova/templates/bin/_nova-compute.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6e8b246d65d69178e39a574ff7750a4e3e028207","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2017-2018 The Openstack-Helm Authors."},{"line_number":5,"context_line":"Copyright 2018 OpenStack Tripleo-Common Authors."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":8,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":25,"id":"5f7c97a3_d4a86779","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":48},"updated":"2018-07-02 10:11:20.000000000","message":"?","commit_id":"cd031e74e14f95821266477121981f8cc8105956"},{"author":{"_account_id":28162,"name":"Ruslan Khanbikov","email":"rkhanbikov@gmail.com","username":"rkhanbikov"},"change_message_id":"d28b17be8e964db82008de413f5b9411457f4724","unresolved":false,"context_lines":[{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"function readinessProbe () {"},{"line_number":30,"context_line":"  ss -n -p -A tcp \"( dst :${RABBITMQ_PORTS} )\" | grep -q \"nova-compute\""},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"$COMMAND"}],"source_content_type":"text/x-smarty","patch_set":28,"id":"5f7c97a3_c4f66c91","line":30,"updated":"2018-07-02 16:45:12.000000000","message":"if rabbitmq is not accessible for some reason, will we mark nova-compute unhealthy?","commit_id":"30190887151edd4339c62095e177256b87854c44"},{"author":{"_account_id":28162,"name":"Ruslan Khanbikov","email":"rkhanbikov@gmail.com","username":"rkhanbikov"},"change_message_id":"9874a82437db91828df9d00198b9b81b59e90913","unresolved":false,"context_lines":[{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"function readinessProbe () {"},{"line_number":30,"context_line":"  ss -n -p -A tcp \"( dst :${RABBITMQ_PORTS} )\" | grep -q \"nova-compute\""},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"$COMMAND"}],"source_content_type":"text/x-smarty","patch_set":28,"id":"5f7c97a3_d1561506","line":30,"in_reply_to":"5f7c97a3_56b52ecf","updated":"2018-07-03 15:35:08.000000000","message":"I agree with you and I\u0027m ok to start from that, but my concern is that we can confuse people marking nova-compute unhealthy, at the same time, rabbitmq might work but slowly. We might need to focus on rabbitmq liveness probe instead and make it clearer and reliable.","commit_id":"30190887151edd4339c62095e177256b87854c44"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"186c97d4721bd0497b86295203d433f665f080a1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"function readinessProbe () {"},{"line_number":30,"context_line":"  ss -n -p -A tcp \"( dst :${RABBITMQ_PORTS} )\" | grep -q \"nova-compute\""},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"$COMMAND"}],"source_content_type":"text/x-smarty","patch_set":28,"id":"5f7c97a3_56b52ecf","line":30,"in_reply_to":"5f7c97a3_c4f66c91","updated":"2018-07-02 21:42:29.000000000","message":"yes. if nova-compute or nova-conductor can\u0027t communicate through the amqp exchange, I don\u0027t think the pod should be deemed healthy.  The alternative would be just to check the process is running, but a success doesn\u0027t mean everything works.  Thoughts?","commit_id":"30190887151edd4339c62095e177256b87854c44"}],"nova/templates/bin/_nova-conductor.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6e8b246d65d69178e39a574ff7750a4e3e028207","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2017-2018 The Openstack-Helm Authors."},{"line_number":5,"context_line":"Copyright 2018 OpenStack Tripleo-Common Authors."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":8,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":25,"id":"5f7c97a3_94b42fd6","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":48},"updated":"2018-07-02 10:11:20.000000000","message":"?","commit_id":"cd031e74e14f95821266477121981f8cc8105956"}],"nova/templates/bin/_nova-consoleauth.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6e8b246d65d69178e39a574ff7750a4e3e028207","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2017-2018 The Openstack-Helm Authors."},{"line_number":5,"context_line":"Copyright 2018 OpenStack Tripleo-Common Authors."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":8,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":25,"id":"5f7c97a3_14c81f54","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":48},"updated":"2018-07-02 10:11:20.000000000","message":"?","commit_id":"cd031e74e14f95821266477121981f8cc8105956"}],"nova/templates/bin/_nova-readiness.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"7f742e958746831a6dbefdc313780866dfa232a0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2018 OpenStack Tripleo-Common authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":13,"id":"5f7c97a3_b56beaed","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":48},"updated":"2018-06-26 03:38:37.000000000","message":"we should also insert osh attribution.","commit_id":"d883eee6cd9fb2420869624d4a9a7f24cba8a6bf"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"a403e2fea7856e983f956a88220bace3153e3124","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2018 OpenStack Tripleo-Common authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":13,"id":"5f7c97a3_9536ee01","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":48},"in_reply_to":"5f7c97a3_b56beaed","updated":"2018-06-26 04:04:01.000000000","message":"Done","commit_id":"d883eee6cd9fb2420869624d4a9a7f24cba8a6bf"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"7f742e958746831a6dbefdc313780866dfa232a0","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"process\u003d\"${1:-process}\""},{"line_number":27,"context_line":"shift 1"},{"line_number":28,"context_line":"args\u003d{{ printf \"${@:-%s}\" $rabbitmqPort }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"healthcheck_port () {"},{"line_number":31,"context_line":"  process\u003d$1"}],"source_content_type":"text/x-smarty","patch_set":13,"id":"5f7c97a3_558856c4","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":42},"updated":"2018-06-26 03:38:37.000000000","message":"we should get this via an env or argument from the pod.","commit_id":"d883eee6cd9fb2420869624d4a9a7f24cba8a6bf"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"a403e2fea7856e983f956a88220bace3153e3124","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"process\u003d\"${1:-process}\""},{"line_number":27,"context_line":"shift 1"},{"line_number":28,"context_line":"args\u003d{{ printf \"${@:-%s}\" $rabbitmqPort }}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"healthcheck_port () {"},{"line_number":31,"context_line":"  process\u003d$1"}],"source_content_type":"text/x-smarty","patch_set":13,"id":"5f7c97a3_f09df0ba","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":42},"in_reply_to":"5f7c97a3_558856c4","updated":"2018-06-26 04:04:01.000000000","message":"Done","commit_id":"d883eee6cd9fb2420869624d4a9a7f24cba8a6bf"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"7f742e958746831a6dbefdc313780866dfa232a0","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  ss -ntp | awk \u0027{print $5,\"-\",$6}\u0027 | egrep \":($ports)\" | grep \"$process\""},{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"if healthcheck_port $process $args"},{"line_number":46,"context_line":"then"},{"line_number":47,"context_line":"  exit 0"},{"line_number":48,"context_line":"else"}],"source_content_type":"text/x-smarty","patch_set":13,"id":"5f7c97a3_d5622616","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":34},"updated":"2018-06-26 03:38:37.000000000","message":"can we use the same style as in other places within osh, ie:\n\nif foo; then","commit_id":"d883eee6cd9fb2420869624d4a9a7f24cba8a6bf"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"a403e2fea7856e983f956a88220bace3153e3124","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  ss -ntp | awk \u0027{print $5,\"-\",$6}\u0027 | egrep \":($ports)\" | grep \"$process\""},{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"if healthcheck_port $process $args"},{"line_number":46,"context_line":"then"},{"line_number":47,"context_line":"  exit 0"},{"line_number":48,"context_line":"else"}],"source_content_type":"text/x-smarty","patch_set":13,"id":"5f7c97a3_b539aaf1","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":34},"in_reply_to":"5f7c97a3_d5622616","updated":"2018-06-26 04:04:01.000000000","message":"Done","commit_id":"d883eee6cd9fb2420869624d4a9a7f24cba8a6bf"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"7f742e958746831a6dbefdc313780866dfa232a0","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  exit 0"},{"line_number":48,"context_line":"else"},{"line_number":49,"context_line":"  ports\u003d${args// /,}"},{"line_number":50,"context_line":"  echo \"There is no $process process with opened RabbitMQ ports ($ports) running in the container\""},{"line_number":51,"context_line":"  exit 1"},{"line_number":52,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":13,"id":"5f7c97a3_758312aa","line":50,"range":{"start_line":50,"start_character":84,"end_line":50,"end_character":87},"updated":"2018-06-26 03:38:37.000000000","message":"this container\u0027s network and pid namespace","commit_id":"d883eee6cd9fb2420869624d4a9a7f24cba8a6bf"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"7f742e958746831a6dbefdc313780866dfa232a0","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  exit 0"},{"line_number":48,"context_line":"else"},{"line_number":49,"context_line":"  ports\u003d${args// /,}"},{"line_number":50,"context_line":"  echo \"There is no $process process with opened RabbitMQ ports ($ports) running in the container\""},{"line_number":51,"context_line":"  exit 1"},{"line_number":52,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":13,"id":"5f7c97a3_75ac7234","line":50,"range":{"start_line":50,"start_character":2,"end_line":50,"end_character":98},"updated":"2018-06-26 03:38:37.000000000","message":"we should suppress this output to prevent it appearing in kubectl output, perhaps a comment would be more appropriate.","commit_id":"d883eee6cd9fb2420869624d4a9a7f24cba8a6bf"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"a403e2fea7856e983f956a88220bace3153e3124","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  exit 0"},{"line_number":48,"context_line":"else"},{"line_number":49,"context_line":"  ports\u003d${args// /,}"},{"line_number":50,"context_line":"  echo \"There is no $process process with opened RabbitMQ ports ($ports) running in the container\""},{"line_number":51,"context_line":"  exit 1"},{"line_number":52,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":13,"id":"5f7c97a3_3013685b","line":50,"range":{"start_line":50,"start_character":84,"end_line":50,"end_character":87},"in_reply_to":"5f7c97a3_758312aa","updated":"2018-06-26 04:04:01.000000000","message":"Done","commit_id":"d883eee6cd9fb2420869624d4a9a7f24cba8a6bf"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"a403e2fea7856e983f956a88220bace3153e3124","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  exit 0"},{"line_number":48,"context_line":"else"},{"line_number":49,"context_line":"  ports\u003d${args// /,}"},{"line_number":50,"context_line":"  echo \"There is no $process process with opened RabbitMQ ports ($ports) running in the container\""},{"line_number":51,"context_line":"  exit 1"},{"line_number":52,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":13,"id":"5f7c97a3_550db63b","line":50,"range":{"start_line":50,"start_character":2,"end_line":50,"end_character":98},"in_reply_to":"5f7c97a3_75ac7234","updated":"2018-06-26 04:04:01.000000000","message":"Done","commit_id":"d883eee6cd9fb2420869624d4a9a7f24cba8a6bf"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"76951b7d28a69e4b6f6797c6ca8992cba9772d5a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"set -ex"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"process\u003d\"${1:-process}\""},{"line_number":27,"context_line":"shift 1"},{"line_number":28,"context_line":"args\u003d\"${RABBITMQ_PORTS}\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"healthcheck_port () {"}],"source_content_type":"text/x-smarty","patch_set":14,"id":"5f7c97a3_50e62418","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":7},"updated":"2018-06-26 04:06:11.000000000","message":"this will be removed in next patch","commit_id":"3aabfe2629fe9b246ba263af96b29defc0a5356c"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"cb732cdd13108c26c8edbd70b0fffda6d77968d2","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  shift 1"},{"line_number":39,"context_line":"  args\u003d$@"},{"line_number":40,"context_line":"  ports\u003d${args// /|}"},{"line_number":41,"context_line":"  ss -ntp | awk \u0027{print $5,\"-\",$6}\u0027 | egrep \":($ports)\" | grep \"$process\""},{"line_number":42,"context_line":"}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"if healthcheck_port $process $args ; then"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"5f7c97a3_a7f41b88","line":41,"range":{"start_line":40,"start_character":0,"end_line":41,"end_character":73},"updated":"2018-06-26 06:35:50.000000000","message":"see if this can be cleaned up","commit_id":"6f1b2600cdf2fba231650abfec52fdfe12900d27"},{"author":{"_account_id":24816,"name":"Anthony Bellino","email":"ab2434@att.com","username":"anthony.bellino"},"change_message_id":"90e7d0bf552b699a06c86f569e24b8d7a5e17918","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  shift 1"},{"line_number":39,"context_line":"  args\u003d$@"},{"line_number":40,"context_line":"  ports\u003d${args// /|}"},{"line_number":41,"context_line":"  ss -ntp | awk \u0027{print $5,\"-\",$6}\u0027 | egrep \":($ports)\" | grep \"$process\""},{"line_number":42,"context_line":"}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"if healthcheck_port $process $args ; then"}],"source_content_type":"text/x-smarty","patch_set":16,"id":"5f7c97a3_faa62154","line":41,"range":{"start_line":40,"start_character":0,"end_line":41,"end_character":73},"in_reply_to":"5f7c97a3_a7f41b88","updated":"2018-06-26 14:13:23.000000000","message":"ss -ntp | awk -v ports\u003d$ports -v process\u003d$process \u0027match($0, ports) \u0026\u0026 match($0, process){print $5,\"-\",$6}\u0027","commit_id":"6f1b2600cdf2fba231650abfec52fdfe12900d27"}],"nova/templates/bin/_nova-scheduler.sh.tpl":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6e8b246d65d69178e39a574ff7750a4e3e028207","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2017-2018 The Openstack-Helm Authors."},{"line_number":5,"context_line":"Copyright 2018 OpenStack Tripleo-Common Authors."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":8,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":25,"id":"5f7c97a3_f4bc83b6","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":48},"updated":"2018-07-02 10:11:20.000000000","message":"?","commit_id":"cd031e74e14f95821266477121981f8cc8105956"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"75ae8e7ab2129a512e26310c7d211256e34aef3a","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2017-2018 The Openstack-Helm Authors."},{"line_number":5,"context_line":"Copyright 2018 OpenStack Tripleo-Common Authors."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":8,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":25,"id":"5f7c97a3_c35f470d","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":48},"in_reply_to":"5f7c97a3_f4bc83b6","updated":"2018-07-02 14:01:08.000000000","message":"will remove all in next patch","commit_id":"cd031e74e14f95821266477121981f8cc8105956"}],"nova/templates/daemonset-compute.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"b903faf4d856efdca881435fc136b5602543ca1a","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            exec:"},{"line_number":174,"context_line":"              command:"},{"line_number":175,"context_line":"                - bash"},{"line_number":176,"context_line":"                - /tmp/nova-readiness.sh"},{"line_number":177,"context_line":"                - nova-compute"},{"line_number":178,"context_line":"            initialDelaySeconds: 10"},{"line_number":179,"context_line":"            periodSeconds: 20"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"5f7c97a3_7042c90f","line":176,"range":{"start_line":176,"start_character":23,"end_line":176,"end_character":37},"updated":"2018-07-01 12:10:52.000000000","message":"why not have the readiness function as part of the pod specific script? this way as we grow more application specific logic into a richer set of checks, we can do so more easily, in addition to having all logic related to a service (eg nova-compute) in one location.","commit_id":"757687a61c161aa46753a0a374fb28cf63d93cd7"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"605ff9dcecc2fe947febaa071672fcf528ec3c3e","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            exec:"},{"line_number":174,"context_line":"              command:"},{"line_number":175,"context_line":"                - bash"},{"line_number":176,"context_line":"                - /tmp/nova-readiness.sh"},{"line_number":177,"context_line":"                - nova-compute"},{"line_number":178,"context_line":"            initialDelaySeconds: 10"},{"line_number":179,"context_line":"            periodSeconds: 20"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"5f7c97a3_0b47a44e","line":176,"range":{"start_line":176,"start_character":23,"end_line":176,"end_character":37},"in_reply_to":"5f7c97a3_7042c90f","updated":"2018-07-01 17:13:05.000000000","message":"I can make the change.  The thought is to consolidate the readiness check to some degree without pasting the same script everywhere until we need to break them out when needed.","commit_id":"757687a61c161aa46753a0a374fb28cf63d93cd7"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6e8b246d65d69178e39a574ff7750a4e3e028207","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            exec:"},{"line_number":174,"context_line":"              command:"},{"line_number":175,"context_line":"                - /tmp/nova-compute.sh"},{"line_number":176,"context_line":"                - readyCheck"},{"line_number":177,"context_line":"            initialDelaySeconds: 10"},{"line_number":178,"context_line":"            periodSeconds: 20"},{"line_number":179,"context_line":"          volumeMounts:"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"5f7c97a3_54e3f7d8","line":176,"range":{"start_line":176,"start_character":18,"end_line":176,"end_character":28},"updated":"2018-07-02 10:11:20.000000000","message":"why not just call this `readinessProbe` to align with the caller.","commit_id":"cd031e74e14f95821266477121981f8cc8105956"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"75ae8e7ab2129a512e26310c7d211256e34aef3a","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            exec:"},{"line_number":174,"context_line":"              command:"},{"line_number":175,"context_line":"                - /tmp/nova-compute.sh"},{"line_number":176,"context_line":"                - readyCheck"},{"line_number":177,"context_line":"            initialDelaySeconds: 10"},{"line_number":178,"context_line":"            periodSeconds: 20"},{"line_number":179,"context_line":"          volumeMounts:"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"5f7c97a3_a39a4bc1","line":176,"range":{"start_line":176,"start_character":18,"end_line":176,"end_character":28},"in_reply_to":"5f7c97a3_54e3f7d8","updated":"2018-07-02 14:01:08.000000000","message":"Done","commit_id":"cd031e74e14f95821266477121981f8cc8105956"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6e8b246d65d69178e39a574ff7750a4e3e028207","unresolved":false,"context_lines":[{"line_number":174,"context_line":"              command:"},{"line_number":175,"context_line":"                - /tmp/nova-compute.sh"},{"line_number":176,"context_line":"                - readyCheck"},{"line_number":177,"context_line":"            initialDelaySeconds: 10"},{"line_number":178,"context_line":"            periodSeconds: 20"},{"line_number":179,"context_line":"          volumeMounts:"},{"line_number":180,"context_line":"            - name: nova-bin"},{"line_number":181,"context_line":"              mountPath: /tmp/nova-compute.sh"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"5f7c97a3_14cd7f5d","line":178,"range":{"start_line":177,"start_character":0,"end_line":178,"end_character":29},"updated":"2018-07-02 10:11:20.000000000","message":"where are these values coming from?","commit_id":"cd031e74e14f95821266477121981f8cc8105956"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"75ae8e7ab2129a512e26310c7d211256e34aef3a","unresolved":false,"context_lines":[{"line_number":174,"context_line":"              command:"},{"line_number":175,"context_line":"                - /tmp/nova-compute.sh"},{"line_number":176,"context_line":"                - readyCheck"},{"line_number":177,"context_line":"            initialDelaySeconds: 10"},{"line_number":178,"context_line":"            periodSeconds: 20"},{"line_number":179,"context_line":"          volumeMounts:"},{"line_number":180,"context_line":"            - name: nova-bin"},{"line_number":181,"context_line":"              mountPath: /tmp/nova-compute.sh"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"5f7c97a3_23a63b0f","line":178,"range":{"start_line":177,"start_character":0,"end_line":178,"end_character":29},"in_reply_to":"5f7c97a3_14cd7f5d","updated":"2018-07-02 14:01:08.000000000","message":"should this be inline with the LMA stacks\u0027 values of 20/10?","commit_id":"cd031e74e14f95821266477121981f8cc8105956"}],"nova/templates/deployment-novncproxy.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"ee03a023dd6f9baf3163f89c78aebb5759801f4d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            tcpSocket:"},{"line_number":96,"context_line":"              port: {{ tuple \"compute_novnc_proxy\" \"internal\" \"novnc_proxy\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":97,"context_line":"            initialDelaySeconds: 20"},{"line_number":98,"context_line":"            periodSeconds: 10"},{"line_number":99,"context_line":"          volumeMounts:"},{"line_number":100,"context_line":"            - name: nova-bin"},{"line_number":101,"context_line":"              mountPath: /tmp/nova-console-proxy.sh"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5f7c97a3_ca55aa51","line":98,"range":{"start_line":98,"start_character":0,"end_line":98,"end_character":29},"updated":"2018-06-25 17:39:57.000000000","message":"almost all of these default to 10s\n\nhow heavy weight is this?  does it produce a lot of logging?\n\nthey seems quite frequent ... i worry we\u0027ll end up doing more work probing than anything else","commit_id":"52e569575e6bbec7dca1ed96b5d72658ff9da1c8"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"55052ac5d436763327d6e9d4606d3628854437d2","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            tcpSocket:"},{"line_number":96,"context_line":"              port: {{ tuple \"compute_novnc_proxy\" \"internal\" \"novnc_proxy\" . | include \"helm-toolkit.endpoints.endpoint_port_lookup\" }}"},{"line_number":97,"context_line":"            initialDelaySeconds: 20"},{"line_number":98,"context_line":"            periodSeconds: 10"},{"line_number":99,"context_line":"          volumeMounts:"},{"line_number":100,"context_line":"            - name: nova-bin"},{"line_number":101,"context_line":"              mountPath: /tmp/nova-console-proxy.sh"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5f7c97a3_451aed7c","line":98,"range":{"start_line":98,"start_character":0,"end_line":98,"end_character":29},"in_reply_to":"5f7c97a3_ca55aa51","updated":"2018-06-25 18:29:32.000000000","message":"Agreed. While these are not heavy, it probably doesn\u0027t need to be 10 second. I think we can bump these to 15 or 20 seconds, but waiting for feedback. ATM, I want to make sure the readinessProbes are working properly prior to tuning the seconds.","commit_id":"52e569575e6bbec7dca1ed96b5d72658ff9da1c8"}]}