)]}'
{"ingress/templates/bin/_ingress-vip.sh.tpl":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"253281e84a3e83233c072a1175f69ef8d26a5803","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function kernel_modules () {"},{"line_number":23,"context_line":"  chroot /mnt/host-rootfs modprobe dummy"},{"line_number":24,"context_line":"  chroot /mnt/host-rootfs modprobe ip_vs"},{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"function start () {"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"5f7c97a3_2ae9be7d","line":24,"range":{"start_line":24,"start_character":25,"end_line":24,"end_character":26},"updated":"2018-06-25 17:47:29.000000000","message":"ip_vs is needed for newer k8s or for keepalived?","commit_id":"4f42e53a0aa8b1b7354489225b2160c44e360f8c"},{"author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"change_message_id":"1361c8ccccc0dae08b1c13858fea070d73c1d353","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"function kernel_modules () {"},{"line_number":23,"context_line":"  chroot /mnt/host-rootfs modprobe dummy"},{"line_number":24,"context_line":"  chroot /mnt/host-rootfs modprobe ip_vs"},{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"function start () {"}],"source_content_type":"text/x-smarty","patch_set":3,"id":"5f7c97a3_d536a6b4","line":24,"range":{"start_line":24,"start_character":25,"end_line":24,"end_character":26},"in_reply_to":"5f7c97a3_2ae9be7d","updated":"2018-06-26 08:14:52.000000000","message":"keepalived","commit_id":"4f42e53a0aa8b1b7354489225b2160c44e360f8c"}],"ingress/templates/configmap-bin.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"253281e84a3e83233c072a1175f69ef8d26a5803","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  image-repo-sync.sh: |"},{"line_number":27,"context_line":"{{- include \"helm-toolkit.scripts.image_repo_sync\" . | indent 4 }}"},{"line_number":28,"context_line":"{{- end }}"},{"line_number":29,"context_line":"{{- if and .Values.network.host_namespace .Values.network.vip.enable }}"},{"line_number":30,"context_line":"  ingress-vip.sh: |"},{"line_number":31,"context_line":"{{ tuple \"bin/_ingress-vip.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":32,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_8af9f24e","line":29,"updated":"2018-06-25 17:47:29.000000000","message":"vip.managed -\u003e vip.enable i think reasonable\n\ni wonder if that shouldn\u0027t be a sep PS?","commit_id":"4f42e53a0aa8b1b7354489225b2160c44e360f8c"},{"author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"change_message_id":"1361c8ccccc0dae08b1c13858fea070d73c1d353","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  image-repo-sync.sh: |"},{"line_number":27,"context_line":"{{- include \"helm-toolkit.scripts.image_repo_sync\" . | indent 4 }}"},{"line_number":28,"context_line":"{{- end }}"},{"line_number":29,"context_line":"{{- if and .Values.network.host_namespace .Values.network.vip.enable }}"},{"line_number":30,"context_line":"  ingress-vip.sh: |"},{"line_number":31,"context_line":"{{ tuple \"bin/_ingress-vip.sh.tpl\" . | include \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":32,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_9a1ff66e","line":29,"in_reply_to":"5f7c97a3_8af9f24e","updated":"2018-06-26 08:14:52.000000000","message":"yeah, but it seems broadly being used already. this change will be removed from the following patchset.","commit_id":"4f42e53a0aa8b1b7354489225b2160c44e360f8c"}],"ingress/templates/deployment-ingress.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"253281e84a3e83233c072a1175f69ef8d26a5803","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                - NET_ADMIN"},{"line_number":215,"context_line":"            runAsUser: 0"},{"line_number":216,"context_line":"          env:"},{"line_number":217,"context_line":"          - name: KEEPALIVED_INTERFACE"},{"line_number":218,"context_line":"            value: {{ .Values.network.vip.interface | quote }}"},{"line_number":219,"context_line":"          command:"},{"line_number":220,"context_line":"            - /tmp/ingress-vip.sh"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_aa894ec7","line":217,"range":{"start_line":217,"start_character":0,"end_line":217,"end_character":38},"updated":"2018-06-25 17:47:29.000000000","message":"vip doesn\u0027t really have an interface\n\nthis introduces more things to set (get right)\n\nif not explicitly set ... what happens?","commit_id":"4f42e53a0aa8b1b7354489225b2160c44e360f8c"},{"author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"change_message_id":"1361c8ccccc0dae08b1c13858fea070d73c1d353","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                - NET_ADMIN"},{"line_number":215,"context_line":"            runAsUser: 0"},{"line_number":216,"context_line":"          env:"},{"line_number":217,"context_line":"          - name: KEEPALIVED_INTERFACE"},{"line_number":218,"context_line":"            value: {{ .Values.network.vip.interface | quote }}"},{"line_number":219,"context_line":"          command:"},{"line_number":220,"context_line":"            - /tmp/ingress-vip.sh"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_fd4ce476","line":217,"range":{"start_line":217,"start_character":0,"end_line":217,"end_character":38},"in_reply_to":"5f7c97a3_aa894ec7","updated":"2018-06-26 08:14:52.000000000","message":"when using keepalived, vip needs real interface to be assigned to work properly. if it is not set correctly, ingress pod won\u0027t be ready. we could consider using default route interface if it not set explicitly.","commit_id":"4f42e53a0aa8b1b7354489225b2160c44e360f8c"}],"ingress/values.yaml":[{"author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"change_message_id":"a3a1a8cd69ee7f7392b37f247273fe796c3621a7","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    # possible options: routed, keepalived"},{"line_number":104,"context_line":"    mode: routed"},{"line_number":105,"context_line":"    interface: ingress-vip"},{"line_number":106,"context_line":"    addr: 172.18.0.1"},{"line_number":107,"context_line":"  ingress:"},{"line_number":108,"context_line":"    annotations:"},{"line_number":109,"context_line":"      #NOTE(portdirect): if left blank this is populated from"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_455904fb","line":106,"range":{"start_line":106,"start_character":10,"end_line":106,"end_character":20},"updated":"2018-07-02 08:32:13.000000000","message":"I assumed vip is always with /32 mask. let me know if you think differently.","commit_id":"35e0f10bc9f66d8bc861ddc71cba61ee15a81bcf"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"a409e4a98a4366cc8e12b1abbd1fbd1277d979a1","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    # possible options: routed, keepalived"},{"line_number":104,"context_line":"    mode: routed"},{"line_number":105,"context_line":"    interface: ingress-vip"},{"line_number":106,"context_line":"    addr: 172.18.0.1"},{"line_number":107,"context_line":"  ingress:"},{"line_number":108,"context_line":"    annotations:"},{"line_number":109,"context_line":"      #NOTE(portdirect): if left blank this is populated from"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_dc2db3fc","line":106,"range":{"start_line":106,"start_character":10,"end_line":106,"end_character":20},"in_reply_to":"5f7c97a3_455904fb","updated":"2018-07-17 14:13:21.000000000","message":"it may sometimes be with another mask - can we retain the existing behavior please.","commit_id":"35e0f10bc9f66d8bc861ddc71cba61ee15a81bcf"},{"author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"change_message_id":"f745d1ed2bb77c3f8bd7e3804abf2674860dfdbf","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    # possible options: routed, keepalived"},{"line_number":104,"context_line":"    mode: routed"},{"line_number":105,"context_line":"    interface: ingress-vip"},{"line_number":106,"context_line":"    addr: 172.18.0.1"},{"line_number":107,"context_line":"  ingress:"},{"line_number":108,"context_line":"    annotations:"},{"line_number":109,"context_line":"      #NOTE(portdirect): if left blank this is populated from"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_b26b2d1a","line":106,"range":{"start_line":106,"start_character":10,"end_line":106,"end_character":20},"in_reply_to":"5f7c97a3_dc2db3fc","updated":"2018-07-18 08:05:18.000000000","message":"no problem.","commit_id":"35e0f10bc9f66d8bc861ddc71cba61ee15a81bcf"}],"tools/deployment/baremetal/020-ingress.sh":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"253281e84a3e83233c072a1175f69ef8d26a5803","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  --set deployment.type\u003dDaemonSet \\"},{"line_number":28,"context_line":"  --set network.host_namespace\u003dtrue \\"},{"line_number":29,"context_line":"  --set network.vip.enable\u003dfalse \\"},{"line_number":30,"context_line":"  --set network.vip.addr\u003d172.18.0.1 \\"},{"line_number":31,"context_line":"  --set conf.services.udp.53\u003d\u0027kube-system/kube-dns:53\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"#NOTE: Deploy namespace ingress"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5f7c97a3_8aa7b250","line":30,"range":{"start_line":30,"start_character":25,"end_line":30,"end_character":35},"updated":"2018-06-25 17:47:29.000000000","message":"172.18.0.1/32 changes to 172.18.0.1 there\nwhat that because the /32 wasn\u0027t needed in the past (for example ip addr assumes a /32) or because we no longer need it for some other reason?","commit_id":"4f42e53a0aa8b1b7354489225b2160c44e360f8c"},{"author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"change_message_id":"1361c8ccccc0dae08b1c13858fea070d73c1d353","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  --set deployment.type\u003dDaemonSet \\"},{"line_number":28,"context_line":"  --set network.host_namespace\u003dtrue \\"},{"line_number":29,"context_line":"  --set network.vip.enable\u003dfalse \\"},{"line_number":30,"context_line":"  --set network.vip.addr\u003d172.18.0.1 \\"},{"line_number":31,"context_line":"  --set conf.services.udp.53\u003d\u0027kube-system/kube-dns:53\u0027"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"#NOTE: Deploy namespace ingress"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5f7c97a3_fdd14458","line":30,"range":{"start_line":30,"start_character":25,"end_line":30,"end_character":35},"in_reply_to":"5f7c97a3_8aa7b250","updated":"2018-06-26 08:14:52.000000000","message":"this file change won\u0027t be necessary anymore since we agreed to keep the existing option.","commit_id":"4f42e53a0aa8b1b7354489225b2160c44e360f8c"}]}
