)]}'
{"id":"openstack%2Fopenstack-helm~577353","triplet_id":"openstack%2Fopenstack-helm~master~I7dd164134e18998d4d2688cb0618cc699a92d166","project":"openstack/openstack-helm","branch":"master","topic":"ingress-vip","hashtags":[],"change_id":"I7dd164134e18998d4d2688cb0618cc699a92d166","subject":"[ingress] introduce keepalived sidecar for ingress vip","status":"MERGED","created":"2018-06-22 06:24:35.000000000","updated":"2018-07-19 23:46:37.000000000","submitted":"2018-07-19 23:46:30.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":11,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"577353-1532043990016-791aaf54","meta_rev_id":"f6876391469d61acaf3f1c42b893ba59246681cf","_number":577353,"virtual_id_number":577353,"owner":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":16513,"name":"Seungkyu Ahn","email":"seungkyua@gmail.com","username":"seungkyu"},{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},{"value":0,"date":"2018-07-18 08:05:18.000000000","_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"date":"2018-07-19 23:46:37.000000000","post_submit":true,"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"value":2,"date":"2018-07-19 23:46:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"all":[{"value":0,"_account_id":16513,"name":"Seungkyu Ahn","email":"seungkyua@gmail.com","username":"seungkyu"},{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},{"value":0,"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},{"value":2,"date":"2018-07-19 14:44:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2018-07-19 22:34:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"all":[{"value":0,"_account_id":16513,"name":"Seungkyu Ahn","email":"seungkyua@gmail.com","username":"seungkyu"},{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},{"value":0,"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2018-07-19 22:34:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},{"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":16513,"name":"Seungkyu Ahn","email":"seungkyua@gmail.com","username":"seungkyu"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-06-25 12:27:24.000000000","updated_by":{"_account_id":16513,"name":"Seungkyu Ahn","email":"seungkyua@gmail.com","username":"seungkyu"},"reviewer":{"_account_id":16513,"name":"Seungkyu Ahn","email":"seungkyua@gmail.com","username":"seungkyu"},"state":"REVIEWER"},{"updated":"2018-07-16 08:58:05.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"},{"updated":"2018-07-17 14:05:54.000000000","updated_by":{"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},"reviewer":{"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},"state":"REVIEWER"},{"updated":"2018-07-19 14:44:46.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2018-07-19 22:34:46.000000000","updated_by":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"reviewer":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"state":"REVIEWER"},{"updated":"2018-07-19 23:46:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-07-19 23:46:37.000000000","updated_by":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"reviewer":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"state":"REVIEWER"}],"messages":[{"id":"ba4bc0b8f4b6ad2788cf58aca9b791a195da601b","author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"date":"2018-06-22 06:24:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e6e80d2bc366d9a8cde3755d7fd0d7c9aa5ae73e","author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"date":"2018-06-22 08:00:09.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"d1d02d120e8ab10d669e2533062ef0ce6b167246","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-22 10:13:29.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/53/577353/2/check/build-openstack-sphinx-docs/8a90107/html/ : SUCCESS in 5m 11s\n- openstack-helm-linter http://logs.openstack.org/53/577353/2/check/openstack-helm-linter/50f04af/ : SUCCESS in 2m 04s\n- openstack-helm-dev-deploy-ceph-radosgw-ovs http://logs.openstack.org/53/577353/2/check/openstack-helm-dev-deploy-ceph-radosgw-ovs/75b03c6/ : SUCCESS in 59m 26s\n- openstack-helm-dev-deploy-ceph-rbd-ovs http://logs.openstack.org/53/577353/2/check/openstack-helm-dev-deploy-ceph-rbd-ovs/c3f8bc7/ : SUCCESS in 53m 41s\n- openstack-helm-dev-deploy-nfs-ovs http://logs.openstack.org/53/577353/2/check/openstack-helm-dev-deploy-nfs-ovs/863c9ba/ : SUCCESS in 47m 01s\n- openstack-helm-dev-deploy-ceph-lb http://logs.openstack.org/53/577353/2/check/openstack-helm-dev-deploy-ceph-lb/3250196/ : TIMED_OUT in 2h 01m 12s (non-voting)\n- openstack-helm-dev-deploy-nfs-lb http://logs.openstack.org/53/577353/2/check/openstack-helm-dev-deploy-nfs-lb/e22301e/ : FAILURE in 37m 18s (non-voting)\n- openstack-helm-dev-deploy-nfs-ldap http://logs.openstack.org/53/577353/2/check/openstack-helm-dev-deploy-nfs-ldap/553676c/ : SUCCESS in 48m 13s (non-voting)\n- openstack-helm-multinode-ubuntu http://logs.openstack.org/53/577353/2/check/openstack-helm-multinode-ubuntu/e357580/ : SUCCESS in 1h 50m 00s (non-voting)\n- openstack-helm-ironic-ubuntu http://logs.openstack.org/53/577353/2/check/openstack-helm-ironic-ubuntu/8011eda/ : SUCCESS in 1h 02m 30s (non-voting)\n- openstack-helm-armada-fullstack-deploy http://logs.openstack.org/53/577353/2/check/openstack-helm-armada-fullstack-deploy/d2757b4/ : FAILURE in 1h 11m 51s (non-voting)\n- openstack-helm-kolla-deploy-ceph-ovs http://logs.openstack.org/53/577353/2/check/openstack-helm-kolla-deploy-ceph-ovs/72ffa8f/ : SUCCESS in 56m 13s\n- openstack-helm-ocata-loci-deploy-ceph http://logs.openstack.org/53/577353/2/check/openstack-helm-ocata-loci-deploy-ceph/8e69494/ : SUCCESS in 58m 12s (non-voting)\n- openstack-helm-ocata-kolla-deploy-ceph http://logs.openstack.org/53/577353/2/check/openstack-helm-ocata-kolla-deploy-ceph/4ec0606/ : SUCCESS in 54m 36s (non-voting)\n- openstack-helm-pike-loci-deploy-ceph http://logs.openstack.org/53/577353/2/check/openstack-helm-pike-loci-deploy-ceph/7a5ad6b/ : SUCCESS in 1h 01m 54s (non-voting)\n- openstack-helm-pike-kolla-deploy-ceph http://logs.openstack.org/53/577353/2/check/openstack-helm-pike-kolla-deploy-ceph/cf587fb/ : SUCCESS in 59m 01s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"caf5487483e1571b9ad68bbe637502f057d73435","author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"date":"2018-06-25 03:49:39.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"2693a0e21ed5bb356e2cf84c736ae19f5a2e67f0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-25 05:51:37.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/53/577353/3/check/build-openstack-sphinx-docs/9266150/html/ : SUCCESS in 4m 10s\n- openstack-helm-linter http://logs.openstack.org/53/577353/3/check/openstack-helm-linter/7c30d61/ : SUCCESS in 1m 24s\n- openstack-helm-dev-deploy-ceph-radosgw-ovs http://logs.openstack.org/53/577353/3/check/openstack-helm-dev-deploy-ceph-radosgw-ovs/c9f38ea/ : SUCCESS in 54m 13s\n- openstack-helm-dev-deploy-ceph-rbd-ovs http://logs.openstack.org/53/577353/3/check/openstack-helm-dev-deploy-ceph-rbd-ovs/65be225/ : SUCCESS in 55m 59s\n- openstack-helm-dev-deploy-nfs-ovs http://logs.openstack.org/53/577353/3/check/openstack-helm-dev-deploy-nfs-ovs/821ac32/ : SUCCESS in 1h 01m 58s\n- openstack-helm-dev-deploy-ceph-lb http://logs.openstack.org/53/577353/3/check/openstack-helm-dev-deploy-ceph-lb/ac003e8/ : SUCCESS in 52m 38s (non-voting)\n- openstack-helm-dev-deploy-nfs-lb http://logs.openstack.org/53/577353/3/check/openstack-helm-dev-deploy-nfs-lb/b34727a/ : SUCCESS in 43m 48s (non-voting)\n- openstack-helm-dev-deploy-nfs-ldap http://logs.openstack.org/53/577353/3/check/openstack-helm-dev-deploy-nfs-ldap/eab2a12/ : SUCCESS in 47m 59s (non-voting)\n- openstack-helm-multinode-ubuntu http://logs.openstack.org/53/577353/3/check/openstack-helm-multinode-ubuntu/18a7197/ : SUCCESS in 1h 37m 41s (non-voting)\n- openstack-helm-ironic-ubuntu http://logs.openstack.org/53/577353/3/check/openstack-helm-ironic-ubuntu/21db603/ : SUCCESS in 1h 01m 25s (non-voting)\n- openstack-helm-armada-fullstack-deploy http://logs.openstack.org/53/577353/3/check/openstack-helm-armada-fullstack-deploy/13e123b/ : FAILURE in 1h 06m 04s (non-voting)\n- openstack-helm-kolla-deploy-ceph-ovs http://logs.openstack.org/53/577353/3/check/openstack-helm-kolla-deploy-ceph-ovs/523446d/ : SUCCESS in 57m 23s\n- openstack-helm-ocata-loci-deploy-ceph http://logs.openstack.org/53/577353/3/check/openstack-helm-ocata-loci-deploy-ceph/dc4ec35/ : SUCCESS in 1h 00m 44s (non-voting)\n- openstack-helm-ocata-kolla-deploy-ceph http://logs.openstack.org/53/577353/3/check/openstack-helm-ocata-kolla-deploy-ceph/fa21d64/ : SUCCESS in 1h 12m 53s (non-voting)\n- openstack-helm-pike-loci-deploy-ceph http://logs.openstack.org/53/577353/3/check/openstack-helm-pike-loci-deploy-ceph/399c86e/ : TIMED_OUT in 2h 00m 48s (non-voting)\n- openstack-helm-pike-kolla-deploy-ceph http://logs.openstack.org/53/577353/3/check/openstack-helm-pike-kolla-deploy-ceph/cdcbd32/ : SUCCESS in 1h 22m 28s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"e3f53f4f6b529682dbce1a48de3c04877b7a9533","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2018-06-25 05:58:03.000000000","message":"Patch Set 3:\n\nThis is quite interesting, but as the ingress controller should be run as a daemonset, when managing host interfaces - do we get any value from this approach? If run as a deployment there\u0027s the possibility of a lot of mess being left on nodes, and unhealthy routes being left.","accounts_in_message":[],"_revision_number":3},{"id":"254ff4a02ea49a6808c1b16a16a5c91de4e6b2bb","author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"date":"2018-06-25 06:31:07.000000000","message":"Patch Set 3:\n\n\u003e This is quite interesting, but as the ingress controller should be\n \u003e run as a daemonset, when managing host interfaces - do we get any\n \u003e value from this approach? If run as a deployment there\u0027s the\n \u003e possibility of a lot of mess being left on nodes, and unhealthy\n \u003e routes being left.\n\nI guess fast failover is critical where ingress is the only access point to openstack services from external. As I described in commit message, it takes too long time to move the existing ingress pod to healthy node when node failure. keepalived ensures nearly immediate failover to another healthy ingress pod with this way.\nI don\u0027t get \"unhealthy routes\" part..adding or removing vip is managed by keepalived very well.","accounts_in_message":[],"_revision_number":3},{"id":"4bafba06e0baa39b41f1ba7c80643b30f34143ac","author":{"_account_id":16513,"name":"Seungkyu Ahn","email":"seungkyua@gmail.com","username":"seungkyu"},"date":"2018-06-25 12:27:24.000000000","message":"Patch Set 3:\n\nA keepalived must have at least two instances to communicate through vrrp. In that sense, daemonset is the better way. If only one keepalived is running, the recovery time is equal to the node failover time. (I stopped the kubelet process and tested it with node notReay state)","accounts_in_message":[],"_revision_number":3},{"id":"14d379a226abf41ee1aa7d1ca21e126c704c90e7","author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"date":"2018-06-25 14:39:48.000000000","message":"Patch Set 3:\n\nI might misunderstood the first question, let me try answer again.\n1) with the existing VIP approach, which restricts replica to 1, it takes unacceptable time to failover when node with the ingress pod fails.\n2) with the proposed approach, keepalived container in an ingress pod ensures VIP is always owned by a healthy pod in a healthy node.\n3) it works with 1 replica as existing VIP approach does, but to cover node failure scenario it requires at least 2 replicas regardless of deployment or daemonset (i did the test with 3 replicas).\n4) i can confirm that there are no stale network states left when ingress pod removed.\n5) it would be very thankful if you feel this idea cannot be merged, since i have to find out another way in a very short time frame for internal schedule.","accounts_in_message":[],"_revision_number":3},{"id":"7f4140042c5abac46af6caa305260b00f5b07d04","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2018-06-25 14:49:01.000000000","message":"Patch Set 3:\n\n\u003e I might misunderstood the first question, let me try answer again.\n \u003e 1) with the existing VIP approach, which restricts replica to 1, it\n \u003e takes unacceptable time to failover when node with the ingress pod\n \u003e fails.\n \u003e 2) with the proposed approach, keepalived container in an ingress\n \u003e pod ensures VIP is always owned by a healthy pod in a healthy node.\n \u003e 3) it works with 1 replica as existing VIP approach does, but to\n \u003e cover node failure scenario it requires at least 2 replicas\n \u003e regardless of deployment or daemonset (i did the test with 3\n \u003e replicas).\n \u003e 4) i can confirm that there are no stale network states left when\n \u003e ingress pod removed.\n \u003e 5) it would be very thankful if you feel this idea cannot be\n \u003e merged, since i have to find out another way in a very short time\n \u003e frame for internal schedule.\n\nAh - this explains a lot - thanks.\n\n1) The current approach is typically used at present in combination with our calico chart to advertise the IP via BGP to a tor, effectively providing an ecmp address for the controllers which run as a DS, so we can run any number of ingress controllers.\n(I hope this clarification answers points 2-4 as well)\n\n5) I think we should be able to merge this, provided we allow users to select both the current method and yours - which is a great enhancement for people who don\u0027t have the ability to peer with their fabric. For us to do this I think we need to make the following changes:\n * - don\u0027t change the vip.manage to vip.enable - as this is in use by many deployments at present.\n * - allow the method to be selected, so we can deploy either the existing approach for scenarios where peering is possible and the keepalive approach for when it\u0027s not.","accounts_in_message":[],"_revision_number":3},{"id":"70fd37b0c354951cf0e641813b7b50823878ece6","author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"date":"2018-06-25 14:57:56.000000000","message":"Patch Set 3:\n\n\u003e \u003e I might misunderstood the first question, let me try answer\n \u003e again.\n \u003e \u003e 1) with the existing VIP approach, which restricts replica to 1,\n \u003e it\n \u003e \u003e takes unacceptable time to failover when node with the ingress\n \u003e pod\n \u003e \u003e fails.\n \u003e \u003e 2) with the proposed approach, keepalived container in an ingress\n \u003e \u003e pod ensures VIP is always owned by a healthy pod in a healthy\n \u003e node.\n \u003e \u003e 3) it works with 1 replica as existing VIP approach does, but to\n \u003e \u003e cover node failure scenario it requires at least 2 replicas\n \u003e \u003e regardless of deployment or daemonset (i did the test with 3\n \u003e \u003e replicas).\n \u003e \u003e 4) i can confirm that there are no stale network states left when\n \u003e \u003e ingress pod removed.\n \u003e \u003e 5) it would be very thankful if you feel this idea cannot be\n \u003e \u003e merged, since i have to find out another way in a very short time\n \u003e \u003e frame for internal schedule.\n \u003e \n \u003e Ah - this explains a lot - thanks.\n \u003e \n \u003e 1) The current approach is typically used at present in combination\n \u003e with our calico chart to advertise the IP via BGP to a tor,\n \u003e effectively providing an ecmp address for the controllers which run\n \u003e as a DS, so we can run any number of ingress controllers.\n \u003e (I hope this clarification answers points 2-4 as well)\n \nit makes sense now. I\u0027ll try this approach as well when applicable.\n\n \u003e 5) I think we should be able to merge this, provided we allow users\n \u003e to select both the current method and yours - which is a great\n \u003e enhancement for people who don\u0027t have the ability to peer with\n \u003e their fabric. For us to do this I think we need to make the\n \u003e following changes:\n \u003e * - don\u0027t change the vip.manage to vip.enable - as this is in use\n \u003e by many deployments at present.\n \u003e * - allow the method to be selected, so we can deploy either the\n \u003e existing approach for scenarios where peering is possible and the\n \u003e keepalive approach for when it\u0027s not.\n\nsure, thanks.","accounts_in_message":[],"_revision_number":3},{"id":"253281e84a3e83233c072a1175f69ef8d26a5803","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2018-06-25 17:47:29.000000000","message":"Patch Set 3:\n\n(4 comments)","accounts_in_message":[],"_revision_number":3},{"id":"1361c8ccccc0dae08b1c13858fea070d73c1d353","author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"date":"2018-06-26 08:14:52.000000000","message":"Patch Set 3:\n\n(4 comments)","accounts_in_message":[],"_revision_number":3},{"id":"e651a1bd69f5dcb07301454f016bb16e52c8e3a0","author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"date":"2018-07-02 08:25:39.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"22bad57c74a668f02bd0e758f067f8e95d3c737c","author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"date":"2018-07-02 08:31:22.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"a3a1a8cd69ee7f7392b37f247273fe796c3621a7","author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"date":"2018-07-02 08:32:13.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"be7a2785894a2207d3fc60aeae6cf80582ae3652","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-02 10:27:30.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/53/577353/5/check/build-openstack-sphinx-docs/814a897/html/ : SUCCESS in 4m 50s\n- openstack-helm-linter http://logs.openstack.org/53/577353/5/check/openstack-helm-linter/da7a4f7/ : SUCCESS in 1m 58s\n- openstack-helm-dev-deploy-ceph-swift-ovs http://logs.openstack.org/53/577353/5/check/openstack-helm-dev-deploy-ceph-swift-ovs/c8481de/ : SUCCESS in 1h 01m 02s\n- openstack-helm-dev-deploy-ceph-radosgw-ovs http://logs.openstack.org/53/577353/5/check/openstack-helm-dev-deploy-ceph-radosgw-ovs/1191802/ : SUCCESS in 59m 13s\n- openstack-helm-dev-deploy-ceph-rbd-ovs http://logs.openstack.org/53/577353/5/check/openstack-helm-dev-deploy-ceph-rbd-ovs/11f6ade/ : SUCCESS in 55m 12s\n- openstack-helm-dev-deploy-nfs-ovs http://logs.openstack.org/53/577353/5/check/openstack-helm-dev-deploy-nfs-ovs/82a5688/ : SUCCESS in 46m 11s\n- openstack-helm-dev-deploy-ceph-lb http://logs.openstack.org/53/577353/5/check/openstack-helm-dev-deploy-ceph-lb/3d71c2e/ : SUCCESS in 56m 37s (non-voting)\n- openstack-helm-dev-deploy-nfs-lb http://logs.openstack.org/53/577353/5/check/openstack-helm-dev-deploy-nfs-lb/ed43338/ : SUCCESS in 44m 28s (non-voting)\n- openstack-helm-dev-deploy-nfs-ldap http://logs.openstack.org/53/577353/5/check/openstack-helm-dev-deploy-nfs-ldap/6d744f5/ : SUCCESS in 48m 58s (non-voting)\n- openstack-helm-multinode-ubuntu http://logs.openstack.org/53/577353/5/check/openstack-helm-multinode-ubuntu/0650ef4/ : SUCCESS in 1h 50m 11s (non-voting)\n- openstack-helm-ironic-ubuntu http://logs.openstack.org/53/577353/5/check/openstack-helm-ironic-ubuntu/0dc7182/ : SUCCESS in 59m 51s (non-voting)\n- openstack-helm-armada-fullstack-deploy http://logs.openstack.org/53/577353/5/check/openstack-helm-armada-fullstack-deploy/f121c73/ : SUCCESS in 1h 30m 36s (non-voting)\n- openstack-helm-kolla-deploy-ceph-ovs http://logs.openstack.org/53/577353/5/check/openstack-helm-kolla-deploy-ceph-ovs/a380eb4/ : SUCCESS in 59m 16s\n- openstack-helm-ocata-loci-deploy-ceph http://logs.openstack.org/53/577353/5/check/openstack-helm-ocata-loci-deploy-ceph/ab14085/ : SUCCESS in 1h 00m 32s (non-voting)\n- openstack-helm-ocata-kolla-deploy-ceph http://logs.openstack.org/53/577353/5/check/openstack-helm-ocata-kolla-deploy-ceph/9ad2bfe/ : SUCCESS in 1h 01m 13s (non-voting)\n- openstack-helm-pike-loci-deploy-ceph http://logs.openstack.org/53/577353/5/check/openstack-helm-pike-loci-deploy-ceph/40dab76/ : FAILURE in 1h 06m 39s (non-voting)\n- openstack-helm-pike-kolla-deploy-ceph http://logs.openstack.org/53/577353/5/check/openstack-helm-pike-kolla-deploy-ceph/81c2312/ : SUCCESS in 1h 02m 41s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"bed0c14facb75c2f0faaad67b79f86c1a7c9e6e3","author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"date":"2018-07-16 06:42:43.000000000","message":"Patch Set 5:\n\nreview please?","accounts_in_message":[],"_revision_number":5},{"id":"7771ebbe1e849126a47759471eb5e76e7254ee4a","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2018-07-16 08:58:05.000000000","message":"Patch Set 5:\n\ni don\u0027t have a strong opinion on this as-is\n\nit doesn\u0027t change the defaults, but it does introduce something we\u0027ve not tested\n\nmy preference is we be given a little more time (and perhaps a bit of prodding or nagging on irc if that helps) where we can spin this up and test it","accounts_in_message":[],"_revision_number":5},{"id":"6f08e094adce035a434b2d396b4a4d1caccc32eb","author":{"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},"date":"2018-07-17 14:05:54.000000000","message":"Patch Set 5:\n\nIn my team, we have been testing this option. it passes all the gates. I understand it can be new for core reviewers. but we need clear feedback on what to do more. \n\nIf you have any questions to clarify something you want to know more, pls put on here or put on openstack mailing list. otherwise, pls let us know what we need to do more on this stage.","accounts_in_message":[],"_revision_number":5},{"id":"a409e4a98a4366cc8e12b1abbd1fbd1277d979a1","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2018-07-17 14:13:21.000000000","message":"Patch Set 5: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"5a470bf8ecdfc0b9beb77c8675ad5b582449c90e","author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"date":"2018-07-18 08:04:02.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"f745d1ed2bb77c3f8bd7e3804abf2674860dfdbf","author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"date":"2018-07-18 08:05:18.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"13946301a19d0a9d47c2b80c0de1a2ebcb8d43db","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-18 10:00:57.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/53/577353/6/check/build-openstack-sphinx-docs/99e6fe3/html/ : SUCCESS in 5m 22s\n- openstack-helm-linter http://logs.openstack.org/53/577353/6/check/openstack-helm-linter/14d5708/ : SUCCESS in 2m 58s\n- openstack-helm-dev-deploy-ceph-swift-ovs http://logs.openstack.org/53/577353/6/check/openstack-helm-dev-deploy-ceph-swift-ovs/f26cff6/ : SUCCESS in 1h 00m 36s\n- openstack-helm-dev-deploy-ceph-radosgw-ovs http://logs.openstack.org/53/577353/6/check/openstack-helm-dev-deploy-ceph-radosgw-ovs/d640b94/ : SUCCESS in 1h 05m 27s\n- openstack-helm-dev-deploy-ceph-rbd-ovs http://logs.openstack.org/53/577353/6/check/openstack-helm-dev-deploy-ceph-rbd-ovs/bf0318f/ : SUCCESS in 58m 38s\n- openstack-helm-dev-deploy-nfs-ovs http://logs.openstack.org/53/577353/6/check/openstack-helm-dev-deploy-nfs-ovs/8faf108/ : SUCCESS in 52m 48s\n- openstack-helm-dev-deploy-ceph-lb http://logs.openstack.org/53/577353/6/check/openstack-helm-dev-deploy-ceph-lb/6b0fd69/ : SUCCESS in 1h 00m 27s (non-voting)\n- openstack-helm-dev-deploy-nfs-lb http://logs.openstack.org/53/577353/6/check/openstack-helm-dev-deploy-nfs-lb/3376e9f/ : SUCCESS in 45m 48s (non-voting)\n- openstack-helm-dev-deploy-nfs-ldap http://logs.openstack.org/53/577353/6/check/openstack-helm-dev-deploy-nfs-ldap/9d1d222/ : SUCCESS in 48m 01s (non-voting)\n- openstack-helm-multinode-ubuntu http://logs.openstack.org/53/577353/6/check/openstack-helm-multinode-ubuntu/cbc95db/ : SUCCESS in 1h 43m 29s (non-voting)\n- openstack-helm-ironic-ubuntu http://logs.openstack.org/53/577353/6/check/openstack-helm-ironic-ubuntu/c2ae4bf/ : SUCCESS in 1h 05m 27s (non-voting)\n- openstack-helm-armada-fullstack-deploy http://logs.openstack.org/53/577353/6/check/openstack-helm-armada-fullstack-deploy/2c46a57/ : FAILURE in 46m 15s (non-voting)\n- openstack-helm-kolla-deploy-ceph-ovs http://logs.openstack.org/53/577353/6/check/openstack-helm-kolla-deploy-ceph-ovs/74b0fe9/ : SUCCESS in 59m 41s\n- openstack-helm-ocata-loci-deploy-ceph http://logs.openstack.org/53/577353/6/check/openstack-helm-ocata-loci-deploy-ceph/8ff192e/ : SUCCESS in 1h 02m 04s (non-voting)\n- openstack-helm-ocata-kolla-deploy-ceph http://logs.openstack.org/53/577353/6/check/openstack-helm-ocata-kolla-deploy-ceph/30e6f83/ : SUCCESS in 58m 25s (non-voting)\n- openstack-helm-pike-loci-deploy-ceph http://logs.openstack.org/53/577353/6/check/openstack-helm-pike-loci-deploy-ceph/2ef328d/ : SUCCESS in 1h 09m 47s (non-voting)\n- openstack-helm-pike-kolla-deploy-ceph http://logs.openstack.org/53/577353/6/check/openstack-helm-pike-kolla-deploy-ceph/9115f8d/ : SUCCESS in 1h 01m 56s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"cf3570e2f2e15334676afecdbca7826483814ee1","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2018-07-19 14:44:46.000000000","message":"Patch Set 6: Code-Review+2","accounts_in_message":[],"_revision_number":6},{"id":"410546db1d47776d21483c8cd7623f7d7d5f765a","author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"date":"2018-07-19 22:34:46.000000000","message":"Patch Set 6: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":6},{"id":"58377d74a9d63851c15da97994a51a70238852cd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-19 22:35:00.000000000","message":"Patch Set 6: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":6},{"id":"7f1bdf0ffa8e80c9b589f2b76e3cb077c475e4f8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-19 23:46:29.000000000","message":"Patch Set 6: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/53/577353/6/gate/build-openstack-sphinx-docs/9136cd3/html/ : SUCCESS in 5m 32s\n- openstack-helm-linter http://logs.openstack.org/53/577353/6/gate/openstack-helm-linter/9b642a5/ : SUCCESS in 2m 49s\n- openstack-helm-dev-deploy-ceph-swift-ovs http://logs.openstack.org/53/577353/6/gate/openstack-helm-dev-deploy-ceph-swift-ovs/6c002eb/ : SUCCESS in 1h 01m 10s\n- openstack-helm-dev-deploy-ceph-radosgw-ovs http://logs.openstack.org/53/577353/6/gate/openstack-helm-dev-deploy-ceph-radosgw-ovs/45870e3/ : SUCCESS in 57m 40s\n- openstack-helm-dev-deploy-ceph-rbd-ovs http://logs.openstack.org/53/577353/6/gate/openstack-helm-dev-deploy-ceph-rbd-ovs/ac0c047/ : SUCCESS in 1h 00m 53s\n- openstack-helm-dev-deploy-nfs-ovs http://logs.openstack.org/53/577353/6/gate/openstack-helm-dev-deploy-nfs-ovs/e1141ac/ : SUCCESS in 45m 38s\n- openstack-helm-kolla-deploy-ceph-ovs http://logs.openstack.org/53/577353/6/gate/openstack-helm-kolla-deploy-ceph-ovs/53a4fec/ : SUCCESS in 1h 02m 55s","accounts_in_message":[],"_revision_number":6},{"id":"a10cb73a5d8078f325a7278a91e9fb4ee25d4f97","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-19 23:46:30.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":6},{"id":"8c2cffa387fe7d6aaebd900076f9a5aaac7f09c0","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2018-07-19 23:46:37.000000000","message":"Patch Set 6:\n\nBuild Failed \n\nhttp://10.24.20.18:30081/job/charts/job/openstack/job/openstack-helm/job/ingress/1/ : FAILURE","accounts_in_message":[],"_revision_number":6},{"id":"b0b3017940ec59a0eaca83247c0d365738ad29eb","author":{"_account_id":26201,"name":"AT\u0026T Openstack-Helm CI","email":"stacey.fletcher@att.com","username":"ATT-OSH-CI"},"date":"2018-07-19 23:46:37.000000000","message":"Patch Set 6:\n\nBuild Started http://10.24.20.18:30081/job/charts/job/openstack/job/openstack-helm/job/ingress/1/","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"b37eb252e42b67a64fb43ea84b819d62246b1317","revisions":{"e57a3321ecfed506915f0c68547811b21b3c949a":{"kind":"REWORK","_number":1,"created":"2018-06-22 06:24:35.000000000","uploader":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"ref":"refs/changes/53/577353/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/53/577353/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/1"}}},"commit":{"parents":[{"commit":"e68ec9814c678fe3bcdc9e3c5f5247d441effaae","subject":"Merge \"Update the typo \"dont\" to \"don\u0027t\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/e68ec9814c678fe3bcdc9e3c5f5247d441effaae"}]}],"author":{"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","date":"2018-06-22 04:59:24.000000000","tz":540},"committer":{"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","date":"2018-06-22 06:24:03.000000000","tz":540},"subject":"[ingress] introduce keepalived sidecar for ingress vip","message":"[ingress] introduce keepalived sidecar for ingress vip\n\nCurrent way of handling vip works but it takes too long time to\nfailover in host failure scenario, which is very critical.\nAlso, the constraint of 1 replicaset when vip is enabled is removed.\n\"vip.manage\" is changed to \"vip.enable\" as well.\n\nChange-Id: I7dd164134e18998d4d2688cb0618cc699a92d166\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/e57a3321ecfed506915f0c68547811b21b3c949a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/e57a3321ecfed506915f0c68547811b21b3c949a"}]},"branch":"refs/heads/master"},"255cb94c9ae377eb2d52ebf4b43f61e7ba2d07ce":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2018-06-22 08:00:09.000000000","uploader":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"ref":"refs/changes/53/577353/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/53/577353/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/2"}}},"commit":{"parents":[{"commit":"e68ec9814c678fe3bcdc9e3c5f5247d441effaae","subject":"Merge \"Update the typo \"dont\" to \"don\u0027t\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/e68ec9814c678fe3bcdc9e3c5f5247d441effaae"}]}],"author":{"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","date":"2018-06-22 04:59:24.000000000","tz":540},"committer":{"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","date":"2018-06-22 07:48:16.000000000","tz":540},"subject":"[ingress] introduce keepalived sidecar for ingress vip","message":"[ingress] introduce keepalived sidecar for ingress vip\n\nCurrent way of handling vip works but when node fails, k8s waits for\npod_eviction_timeout before moving ingress pod to healthy node,\nwhich takes 5min by default.\nBy running keepalived sidecar container, vip can be moved to healthy\nhost immediately.\nAlso, with this way, we can run multiple instance of ingress pod when\nvip enabled.\nMinor but changed \"vip.manage\" to \"vip.enable\".\n\nChange-Id: I7dd164134e18998d4d2688cb0618cc699a92d166\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/255cb94c9ae377eb2d52ebf4b43f61e7ba2d07ce"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/255cb94c9ae377eb2d52ebf4b43f61e7ba2d07ce"}]},"branch":"refs/heads/master"},"4f42e53a0aa8b1b7354489225b2160c44e360f8c":{"kind":"REWORK","_number":3,"created":"2018-06-25 03:49:39.000000000","uploader":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"ref":"refs/changes/53/577353/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/53/577353/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/3"}}},"commit":{"parents":[{"commit":"1d0dedb09a4a0240608dcb175f462a774b9587d4","subject":"Merge \"[ingress] fix ingress-vip container to exit immediately with sigterm\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/1d0dedb09a4a0240608dcb175f462a774b9587d4"}]}],"author":{"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","date":"2018-06-22 04:59:24.000000000","tz":540},"committer":{"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","date":"2018-06-25 03:49:28.000000000","tz":540},"subject":"[ingress] introduce keepalived sidecar for ingress vip","message":"[ingress] introduce keepalived sidecar for ingress vip\n\nCurrent way of handling vip works but when node fails, k8s waits for\npod_eviction_timeout before moving ingress pod to healthy node,\nwhich takes 5min by default.\nBy running keepalived sidecar container, vip can be moved to healthy\nhost immediately.\nAlso, with this way, we can run multiple instance of ingress pod when\nvip enabled.\nMinor but changed \"vip.manage\" to \"vip.enable\".\n\nChange-Id: I7dd164134e18998d4d2688cb0618cc699a92d166\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/4f42e53a0aa8b1b7354489225b2160c44e360f8c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/4f42e53a0aa8b1b7354489225b2160c44e360f8c"}]},"branch":"refs/heads/master"},"b10724838adf54ba2deab36575e06b4d9fb29f8c":{"kind":"REWORK","_number":4,"created":"2018-07-02 08:25:39.000000000","uploader":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"ref":"refs/changes/53/577353/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/53/577353/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/4"}}},"commit":{"parents":[{"commit":"1d0dedb09a4a0240608dcb175f462a774b9587d4","subject":"Merge \"[ingress] fix ingress-vip container to exit immediately with sigterm\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/1d0dedb09a4a0240608dcb175f462a774b9587d4"}]}],"author":{"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","date":"2018-06-22 04:59:24.000000000","tz":540},"committer":{"name":"Hyunsun","email":"hyunsun.moon@gmail.com","date":"2018-07-02 08:25:36.000000000","tz":0},"subject":"[ingress] introduce keepalived sidecar for ingress vip","message":"[ingress] introduce keepalived sidecar for ingress vip\n\nAdded new method of serving VIP with keepalived, which ensures\nVIP is always owned by a healthy pod in a healthy node.\nUser can select prefered VIP method by setting \"network.vip.mode\"\nto \"keepalived\" or \"routed\".\n\nChange-Id: I7dd164134e18998d4d2688cb0618cc699a92d166\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/b10724838adf54ba2deab36575e06b4d9fb29f8c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/b10724838adf54ba2deab36575e06b4d9fb29f8c"}]},"branch":"refs/heads/master"},"35e0f10bc9f66d8bc861ddc71cba61ee15a81bcf":{"kind":"REWORK","_number":5,"created":"2018-07-02 08:31:22.000000000","uploader":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"ref":"refs/changes/53/577353/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/53/577353/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/5"}}},"commit":{"parents":[{"commit":"1d0dedb09a4a0240608dcb175f462a774b9587d4","subject":"Merge \"[ingress] fix ingress-vip container to exit immediately with sigterm\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/1d0dedb09a4a0240608dcb175f462a774b9587d4"}]}],"author":{"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","date":"2018-06-22 04:59:24.000000000","tz":540},"committer":{"name":"Hyunsun","email":"hyunsun.moon@gmail.com","date":"2018-07-02 08:31:09.000000000","tz":0},"subject":"[ingress] introduce keepalived sidecar for ingress vip","message":"[ingress] introduce keepalived sidecar for ingress vip\n\nAdded new method of serving VIP with keepalived, which ensures\nVIP is always owned by a healthy pod in a healthy node.\nUser can select prefered VIP method by setting \"network.vip.mode\"\nto \"keepalived\" or \"routed\".\n\nChange-Id: I7dd164134e18998d4d2688cb0618cc699a92d166\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/35e0f10bc9f66d8bc861ddc71cba61ee15a81bcf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/35e0f10bc9f66d8bc861ddc71cba61ee15a81bcf"}]},"branch":"refs/heads/master"},"b37eb252e42b67a64fb43ea84b819d62246b1317":{"kind":"REWORK","_number":6,"created":"2018-07-18 08:04:02.000000000","uploader":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"ref":"refs/changes/53/577353/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/53/577353/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/53/577353/6"}}},"commit":{"parents":[{"commit":"1d0dedb09a4a0240608dcb175f462a774b9587d4","subject":"Merge \"[ingress] fix ingress-vip container to exit immediately with sigterm\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/1d0dedb09a4a0240608dcb175f462a774b9587d4"}]}],"author":{"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","date":"2018-06-22 04:59:24.000000000","tz":540},"committer":{"name":"Hyunsun","email":"hyunsun.moon@gmail.com","date":"2018-07-18 08:01:24.000000000","tz":0},"subject":"[ingress] introduce keepalived sidecar for ingress vip","message":"[ingress] introduce keepalived sidecar for ingress vip\n\nAdded new method of serving VIP with keepalived, which ensures\nVIP is always owned by a healthy pod in a healthy node.\nUser can select prefered VIP method by setting \"network.vip.mode\"\nto \"keepalived\" or \"routed\".\n\nChange-Id: I7dd164134e18998d4d2688cb0618cc699a92d166\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/b37eb252e42b67a64fb43ea84b819d62246b1317"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/b37eb252e42b67a64fb43ea84b819d62246b1317"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
