)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"75b063e21271e54fa98de7ab905b793859687dfd","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Keystone token expiration, rotation frequency and active keys values should follow the formula"},{"line_number":10,"context_line":"max_active_keys \u003d (token_expiration / rotation_frequency) + 2"},{"line_number":11,"context_line":"max_active_keys by default is 3"},{"line_number":12,"context_line":"token expiration set to 3600 (1h)"},{"line_number":13,"context_line":"so rotation frequency should be 1 hour"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ia04daec9b2905ef2d3f2d4fbb43557dda220dc70"},{"line_number":16,"context_line":"Signed-off-by: Ruslan Khanbikov \u003crk760n@att.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_12c71d49","line":13,"range":{"start_line":11,"start_character":0,"end_line":13,"end_character":38},"updated":"2018-06-27 22:27:45.000000000","message":"this should probably be updated","commit_id":"6eb302e4a773bf81d5c86744f55404138cf9d834"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"c33ae08835e5480f45a3cc21d5546b941248154f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Keystone token expiration, rotation frequency and active keys values should follow the formula"},{"line_number":10,"context_line":"max_active_keys \u003d (token_expiration / rotation_frequency) + 2"},{"line_number":11,"context_line":"max_active_keys by default is 3"},{"line_number":12,"context_line":"token expiration set to 3600 (1h)"},{"line_number":13,"context_line":"so rotation frequency should be 1 hour"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ia04daec9b2905ef2d3f2d4fbb43557dda220dc70"},{"line_number":16,"context_line":"Signed-off-by: Ruslan Khanbikov \u003crk760n@att.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_2d0bd822","line":13,"range":{"start_line":11,"start_character":0,"end_line":13,"end_character":38},"in_reply_to":"5f7c97a3_12c71d49","updated":"2018-06-27 22:52:09.000000000","message":"Done","commit_id":"6eb302e4a773bf81d5c86744f55404138cf9d834"}],"keystone/values.yaml":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"bba91c0217db7f30a4f5ce3defb0f027e008845d","unresolved":false,"context_lines":[{"line_number":314,"context_line":"    user: keystone"},{"line_number":315,"context_line":"    group: keystone"},{"line_number":316,"context_line":"  fernet_rotate:"},{"line_number":317,"context_line":"    # NOTE(rk760n): key rotation frequency, token expiration, active keys should statisfy the formula"},{"line_number":318,"context_line":"    # max_active_keys \u003d (token_expiration / rotation_frequency) + 2"},{"line_number":319,"context_line":"    # as expiration is 1 h by default, and max_active_keys set to 3 by default, rotation_frequency need to be adjusted"},{"line_number":320,"context_line":"    # hourly"},{"line_number":321,"context_line":"    cron: \"0 * * * *\""},{"line_number":322,"context_line":"    user: keystone"},{"line_number":323,"context_line":"    group: keystone"},{"line_number":324,"context_line":"    history:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_f7e133ff","line":321,"range":{"start_line":317,"start_character":4,"end_line":321,"end_character":21},"updated":"2018-06-27 21:29:50.000000000","message":"rotating keys every hour is a bit much, is there a direct need for this? I see the formula here[0].\n\n[0] https://docs.openstack.org/keystone/pike/admin/identity-fernet-token-faq.html#i-rotated-keys-and-now-tokens-are-invalidating-early-what-did-i-do","commit_id":"4cb6e2da9e20e549fed633c631d8fc353369b4c4"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"690e00d95ae4c7f23c88344ca51da339de17dab5","unresolved":false,"context_lines":[{"line_number":315,"context_line":"    group: keystone"},{"line_number":316,"context_line":"  fernet_rotate:"},{"line_number":317,"context_line":"    # NOTE(rk760n): key rotation frequency, token expiration, active keys should statisfy the formula"},{"line_number":318,"context_line":"    # max_active_keys \u003d (token_expiration / rotation_frequency) + 2"},{"line_number":319,"context_line":"    # as expiration is 1 h by default, and max_active_keys set to 3 by default, rotation_frequency need to be adjusted"},{"line_number":320,"context_line":"    # hourly"},{"line_number":321,"context_line":"    cron: \"0 * * * *\""},{"line_number":322,"context_line":"    user: keystone"},{"line_number":323,"context_line":"    group: keystone"},{"line_number":324,"context_line":"    history:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_d76517b1","line":321,"range":{"start_line":318,"start_character":0,"end_line":321,"end_character":21},"updated":"2018-06-27 21:25:55.000000000","message":"while the math works out, would an hour rotation be too frequent?  if I get a token, by the time it expires, the set of keys are also being rotated.","commit_id":"4cb6e2da9e20e549fed633c631d8fc353369b4c4"},{"author":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"change_message_id":"257c7d180d05b1f3785a9cfc2455b03eed9b556a","unresolved":false,"context_lines":[{"line_number":344,"context_line":"      max_token_size: 255"},{"line_number":345,"context_line":"    token:"},{"line_number":346,"context_line":"      provider: fernet"},{"line_number":347,"context_line":"      expiration: 43200"},{"line_number":348,"context_line":"    identity:"},{"line_number":349,"context_line":"      domain_specific_drivers_enabled: True"},{"line_number":350,"context_line":"      domain_config_dir: /etc/keystonedomains"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_0d84dcb1","line":347,"range":{"start_line":347,"start_character":6,"end_line":347,"end_character":23},"updated":"2018-06-28 00:14:00.000000000","message":"I suggest a YAML comment that says how many hours this equates to","commit_id":"3443c768fe70a4bd3c75beb0423f559d377bf647"},{"author":{"_account_id":28162,"name":"Ruslan Khanbikov","email":"rkhanbikov@gmail.com","username":"rkhanbikov"},"change_message_id":"01612533de4f46c16a965d5168569055ce40dfc7","unresolved":false,"context_lines":[{"line_number":344,"context_line":"      max_token_size: 255"},{"line_number":345,"context_line":"    token:"},{"line_number":346,"context_line":"      provider: fernet"},{"line_number":347,"context_line":"      expiration: 43200"},{"line_number":348,"context_line":"    identity:"},{"line_number":349,"context_line":"      domain_specific_drivers_enabled: True"},{"line_number":350,"context_line":"      domain_config_dir: /etc/keystonedomains"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_030eed32","line":347,"range":{"start_line":347,"start_character":6,"end_line":347,"end_character":23},"in_reply_to":"5f7c97a3_0d84dcb1","updated":"2018-06-28 00:44:09.000000000","message":"done","commit_id":"3443c768fe70a4bd3c75beb0423f559d377bf647"}]}