)]}'
{".zuul.yaml":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"cd37fd03a7ca15a86d00a1792fdd468d00006a50","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    name: openstack-helm-dev-deploy-nfs-ldap"},{"line_number":219,"context_line":"    vars:"},{"line_number":220,"context_line":"      idp_backend: ldap"},{"line_number":221,"context_line":"      zuul_osh_infra_relative_path: ../openstack-helm-infra/"},{"line_number":222,"context_line":"    parent: openstack-helm-dev-deploy"},{"line_number":223,"context_line":"    run: tools/gate/playbooks/dev-deploy-nfs.yaml"},{"line_number":224,"context_line":"    required-projects:"},{"line_number":225,"context_line":"      - openstack/openstack-helm-infra"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"- job:"},{"line_number":228,"context_line":"    name: openstack-helm-multinode"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f7c97a3_35833006","line":225,"range":{"start_line":221,"start_character":0,"end_line":225,"end_character":38},"updated":"2018-07-10 20:54:52.000000000","message":"These should have been inherited from the parent","commit_id":"f495e390a4540c1aa65fcd15dfab85c763c1f944"}],"tools/deployment/developer/ldap/080-keystone.sh":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"abb79fd87b38290858833547f9e57f2b246160db","unresolved":false,"context_lines":[{"line_number":17,"context_line":"set -xe"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"#NOTE: Lint and package chart"},{"line_number":20,"context_line":"make ldap"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"#NOTE: Deploy command"},{"line_number":23,"context_line":": ${OSH_INFRA_PATH:\u003d\"../openstack-helm-infra\"}"}],"source_content_type":"text/x-sh","patch_set":8,"id":"5f7c97a3_a84cb675","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":9},"updated":"2018-07-11 10:23:34.000000000","message":"this would not work if we remove the ldap folder from ash - as this is executed with  chdir: \"{{ zuul_osh_relative_path | default(zuul.project.src_dir) }}\". we should also remove the folder as well as we would be solely dependent on OSH-infra\u0027s ldap.","commit_id":"c7369b1abc8e7e1c1bfcc75897a53a734e008cc3"}],"tools/gate/playbooks/dev-deploy-nfs.yaml":[{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"bd805464656a2dc96207bec2da23b02e00c030ef","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        OSH_EXTRA_HELM_ARGS: \"{{ zuul_osh_extra_helm_args_relative_path | default(\u0027\u0027) }}\""},{"line_number":108,"context_line":"        OSH_INFRA_PATH: \"{{ zuul_osh_infra_relative_path | default(\u0027\u0027) }}\""},{"line_number":109,"context_line":"      args:"},{"line_number":110,"context_line":"        chdir: \"{{ zuul_osh_infra_relative_path | default(zuul.projects[\u0027git.openstack.org/openstack/openstack-helm-infra\u0027].src_dir) }}\""},{"line_number":111,"context_line":"    - name: Deploy Keystone with LDAP Backend"},{"line_number":112,"context_line":"      when: idp_backend is defined and idp_backend \u003d\u003d \"ldap\""},{"line_number":113,"context_line":"      shell: |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_ba074481","line":110,"range":{"start_line":110,"start_character":19,"end_line":110,"end_character":47},"updated":"2018-07-10 02:37:30.000000000","message":"This doesn\u0027t appear to be set correctly (causing this error: \"OSError: [Errno 2] No such file or directory: \u0027/home/openstack-helm-infra\u0027\" http://logs.openstack.org/45/579045/3/check/openstack-helm-dev-deploy-nfs-ldap/5139e4a/ara-report/).\n\nIt should be here: https://github.com/openstack/openstack-helm/blob/b4abb6329833547cc2b92b9bdeb73be854c069eb/.zuul.yaml#L220\n\nJust like it\u0027s defined here: https://github.com/openstack/openstack-helm/blob/b4abb6329833547cc2b92b9bdeb73be854c069eb/.zuul.yaml#L229","commit_id":"2e106ad4e9fd713eeaee14378e31ec75d7f97b80"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"80afd99d6688f4557a55dcb831fcc8023c30c99b","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        OSH_EXTRA_HELM_ARGS: \"{{ zuul_osh_extra_helm_args_relative_path | default(\u0027\u0027) }}\""},{"line_number":108,"context_line":"        OSH_INFRA_PATH: \"{{ zuul_osh_infra_relative_path | default(\u0027\u0027) }}\""},{"line_number":109,"context_line":"      args:"},{"line_number":110,"context_line":"        chdir: \"{{ zuul_osh_infra_relative_path | default(zuul.projects[\u0027git.openstack.org/openstack/openstack-helm-infra\u0027].src_dir) }}\""},{"line_number":111,"context_line":"    - name: Deploy Keystone with LDAP Backend"},{"line_number":112,"context_line":"      when: idp_backend is defined and idp_backend \u003d\u003d \"ldap\""},{"line_number":113,"context_line":"      shell: |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_dd2f9a86","line":110,"range":{"start_line":110,"start_character":19,"end_line":110,"end_character":47},"in_reply_to":"5f7c97a3_ba074481","updated":"2018-07-10 03:11:21.000000000","message":"shouldn\u0027t this be correctly inherited from here: https://github.com/openstack/openstack-helm/blob/b4abb6329833547cc2b92b9bdeb73be854c069eb/.zuul.yaml#L167","commit_id":"2e106ad4e9fd713eeaee14378e31ec75d7f97b80"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"faa48faab68e931e8d39efb084c16f543a052f20","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        OSH_EXTRA_HELM_ARGS: \"{{ zuul_osh_extra_helm_args_relative_path | default(\u0027\u0027) }}\""},{"line_number":108,"context_line":"        OSH_INFRA_PATH: \"{{ zuul_osh_infra_relative_path | default(\u0027\u0027) }}\""},{"line_number":109,"context_line":"      args:"},{"line_number":110,"context_line":"        chdir: \"{{ zuul_osh_infra_relative_path | default(zuul.projects[\u0027git.openstack.org/openstack/openstack-helm-infra\u0027].src_dir) }}\""},{"line_number":111,"context_line":"    - name: Deploy Keystone with LDAP Backend"},{"line_number":112,"context_line":"      when: idp_backend is defined and idp_backend \u003d\u003d \"ldap\""},{"line_number":113,"context_line":"      shell: |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_01359bda","line":110,"range":{"start_line":110,"start_character":19,"end_line":110,"end_character":47},"in_reply_to":"5f7c97a3_dd2f9a86","updated":"2018-07-10 16:41:59.000000000","message":"I thought it inherited it, but it looks like it doesn\u0027t","commit_id":"2e106ad4e9fd713eeaee14378e31ec75d7f97b80"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"bd805464656a2dc96207bec2da23b02e00c030ef","unresolved":false,"context_lines":[{"line_number":109,"context_line":"      args:"},{"line_number":110,"context_line":"        chdir: \"{{ zuul_osh_infra_relative_path | default(zuul.projects[\u0027git.openstack.org/openstack/openstack-helm-infra\u0027].src_dir) }}\""},{"line_number":111,"context_line":"    - name: Deploy Keystone with LDAP Backend"},{"line_number":112,"context_line":"      when: idp_backend is defined and idp_backend \u003d\u003d \"ldap\""},{"line_number":113,"context_line":"      shell: |"},{"line_number":114,"context_line":"        set -xe;"},{"line_number":115,"context_line":"        ./tools/deployment/developer/ldap/080-keystone.sh"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_7a968c3f","line":112,"range":{"start_line":112,"start_character":6,"end_line":112,"end_character":60},"updated":"2018-07-10 02:37:30.000000000","message":"This is no longer true as now 080-keystone.sh only deploys Keystone sans ldap.","commit_id":"2e106ad4e9fd713eeaee14378e31ec75d7f97b80"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"80afd99d6688f4557a55dcb831fcc8023c30c99b","unresolved":false,"context_lines":[{"line_number":109,"context_line":"      args:"},{"line_number":110,"context_line":"        chdir: \"{{ zuul_osh_infra_relative_path | default(zuul.projects[\u0027git.openstack.org/openstack/openstack-helm-infra\u0027].src_dir) }}\""},{"line_number":111,"context_line":"    - name: Deploy Keystone with LDAP Backend"},{"line_number":112,"context_line":"      when: idp_backend is defined and idp_backend \u003d\u003d \"ldap\""},{"line_number":113,"context_line":"      shell: |"},{"line_number":114,"context_line":"        set -xe;"},{"line_number":115,"context_line":"        ./tools/deployment/developer/ldap/080-keystone.sh"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_fa237cb9","line":112,"range":{"start_line":112,"start_character":6,"end_line":112,"end_character":60},"in_reply_to":"5f7c97a3_7a968c3f","updated":"2018-07-10 03:11:21.000000000","message":"This is still needed because 080-keystone.sh in ldap has a ldap-domain override in the keystone install. If we can fuse that back with the other 080-keystone.sh then we should just remove this task all together, but as is we would still need it.","commit_id":"2e106ad4e9fd713eeaee14378e31ec75d7f97b80"}]}