)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"61adf574a92bc8751740a7110f1f873bde4fc922","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Implements: ceph/rbd utility script"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is an effort to implement ceph and rbd utility."},{"line_number":10,"context_line":"This utilities can be used to perform ceph/rbd operations without having to drop into container shell using kubectl exec"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I58f016c7df7d9fb062dc6ee2ea4b8d8dbcb22c1a"},{"line_number":13,"context_line":"Signed-off-by: Sreejith Punnapuzha \u003cSreejith.Punnapuzha@outlook.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5f7c97a3_9d0122b8","line":10,"range":{"start_line":10,"start_character":71,"end_line":10,"end_character":80},"updated":"2018-08-01 16:33:57.000000000","message":"wrap commit msg","commit_id":"dd944b330db4c567300312695c144f0423d3f3f1"}],"ceph-provisioners/templates/bin/utilities/_cliceph.tpl":[{"author":{"_account_id":28704,"name":"Al Lau","email":"al070e@att.com","username":"al070e"},"change_message_id":"f21cc1b1fe26a68b345bc8c72826fae9c3714cc9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"#!/usr/bin/env bash"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"set -e"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":5,"id":"5f7c97a3_5989b56d","line":19,"updated":"2018-07-27 22:04:56.000000000","message":"Don\u0027t need this line as line #1 already had the #!/bin/bash","commit_id":"80063b1026ef45a44106372d0884a246f3635d91"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"829cd7b3c3aa2371d683d5d23ec6ec86c3b5c001","unresolved":false,"context_lines":[{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"#!/usr/bin/env bash"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"set -e"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":5,"id":"5f7c97a3_cc1f0ab6","line":19,"in_reply_to":"5f7c97a3_5989b56d","updated":"2018-07-31 15:09:31.000000000","message":"this env bash is used by the script where as the initial bin/bash is used by the template file","commit_id":"80063b1026ef45a44106372d0884a246f3635d91"},{"author":{"_account_id":28704,"name":"Al Lau","email":"al070e@att.com","username":"al070e"},"change_message_id":"e46008370e789a3c58a2500d816a7c0661a7c008","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#!/usr/bin/env bash"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"set -e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"if [[ $1 \u003d~ ceph.* ]] || [[ $1 \u003d~ rbd.* ]] || [[ $1 \u003d~ rados.* ]];"},{"line_number":24,"context_line":"  then"},{"line_number":25,"context_line":"    #Gather the container ulr with hash"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"5f7c97a3_5996954c","line":22,"updated":"2018-07-27 22:29:23.000000000","message":"It would be really beneficial to provide the -h|--help option to display the synopsis for cliceph script.  Tell the users where they need to be and as which login (root most likely) in order to run this script.","commit_id":"80063b1026ef45a44106372d0884a246f3635d91"},{"author":{"_account_id":28704,"name":"Al Lau","email":"al070e@att.com","username":"al070e"},"change_message_id":"f21cc1b1fe26a68b345bc8c72826fae9c3714cc9","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"set -e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"if [[ $1 \u003d~ ceph.* ]] || [[ $1 \u003d~ rbd.* ]] || [[ $1 \u003d~ rados.* ]];"},{"line_number":24,"context_line":"  then"},{"line_number":25,"context_line":"    #Gather the container ulr with hash"},{"line_number":26,"context_line":"    IMAGE\u003d`docker image inspect $(docker image ls | grep -i ceph-config-helper| awk \u0027{print$3}\u0027)|jq -j .[0].RepoDigests[]`"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"5f7c97a3_19ceddb6","line":23,"updated":"2018-07-27 22:04:56.000000000","message":"If someone run cliceph without any arguments, the echo message in the else cause may not make sense.  Best way is to check for the $# the cliceph script was invoked with.","commit_id":"80063b1026ef45a44106372d0884a246f3635d91"},{"author":{"_account_id":28704,"name":"Al Lau","email":"al070e@att.com","username":"al070e"},"change_message_id":"f21cc1b1fe26a68b345bc8c72826fae9c3714cc9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"set -e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"if [[ $1 \u003d~ ceph.* ]] || [[ $1 \u003d~ rbd.* ]] || [[ $1 \u003d~ rados.* ]];"},{"line_number":24,"context_line":"  then"},{"line_number":25,"context_line":"    #Gather the container ulr with hash"},{"line_number":26,"context_line":"    IMAGE\u003d`docker image inspect $(docker image ls | grep -i ceph-config-helper| awk \u0027{print$3}\u0027)|jq -j .[0].RepoDigests[]`"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":5,"id":"5f7c97a3_f93d218d","line":24,"updated":"2018-07-27 22:04:56.000000000","message":"I think the indent is not needed for \"then\".","commit_id":"80063b1026ef45a44106372d0884a246f3635d91"},{"author":{"_account_id":28704,"name":"Al Lau","email":"al070e@att.com","username":"al070e"},"change_message_id":"f21cc1b1fe26a68b345bc8c72826fae9c3714cc9","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        $IMAGE $*"},{"line_number":47,"context_line":"else"},{"line_number":48,"context_line":"  echo \"Command not supported\""},{"line_number":49,"context_line":"  echo \"Valid commands are ceph, ceph-disk, rbd and rados\""},{"line_number":50,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"5f7c97a3_79b4b11d","line":49,"updated":"2018-07-27 22:04:56.000000000","message":"May be good to provide \"exit 1\" to show that the script had failed.","commit_id":"80063b1026ef45a44106372d0884a246f3635d91"},{"author":{"_account_id":28704,"name":"Al Lau","email":"al070e@att.com","username":"al070e"},"change_message_id":"f21cc1b1fe26a68b345bc8c72826fae9c3714cc9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"else"},{"line_number":48,"context_line":"  echo \"Command not supported\""},{"line_number":49,"context_line":"  echo \"Valid commands are ceph, ceph-disk, rbd and rados\""},{"line_number":50,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"5f7c97a3_59b77523","line":50,"updated":"2018-07-27 22:04:56.000000000","message":"Does this script need to provide the exit status like $? from the docker command to clean up the $DIR?","commit_id":"80063b1026ef45a44106372d0884a246f3635d91"}],"ceph-provisioners/templates/bin/utilities/_move.sh.tpl":[{"author":{"_account_id":28704,"name":"Al Lau","email":"al070e@att.com","username":"al070e"},"change_message_id":"f21cc1b1fe26a68b345bc8c72826fae9c3714cc9","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"set -ex"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"cp /tmp/cliceph /usr/local/bin/"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"5f7c97a3_1616ac59","line":21,"updated":"2018-07-27 22:04:56.000000000","message":"The execution bit on the cliceph file should be on.  You can change the cp command to\n\n[[ -x /tmp/cliceph ]] \u0026\u0026 cp /tmp/cliceph /usr/local/bin/","commit_id":"80063b1026ef45a44106372d0884a246f3635d91"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"829cd7b3c3aa2371d683d5d23ec6ec86c3b5c001","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"set -ex"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"cp /tmp/cliceph /usr/local/bin/"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"5f7c97a3_8c435297","line":21,"in_reply_to":"5f7c97a3_1616ac59","updated":"2018-07-31 15:09:31.000000000","message":"Permissions are set using helm chart","commit_id":"80063b1026ef45a44106372d0884a246f3635d91"}],"ceph-provisioners/templates/bin/utils/_cliceph.tpl":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"1b6c5bbd8ba7e2af4b50d0c75bbf9e8e97f8cb06","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2017 The Openstack-Helm Authors."}],"source_content_type":"text/x-smarty","patch_set":8,"id":"5f7c97a3_9de5a240","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":19},"updated":"2018-08-01 16:31:44.000000000","message":"#!/bin/bash","commit_id":"dd944b330db4c567300312695c144f0423d3f3f1"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"1b6c5bbd8ba7e2af4b50d0c75bbf9e8e97f8cb06","unresolved":false,"context_lines":[{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"set -e"},{"line_number":20,"context_line":"if [[ $1 \u003d\u003d -h ]] || [[ $1 \u003d\u003d -help ]] || [[ $1 \u003d\u003d --h ]] || [[ $1 \u003d\u003d --help ]];"},{"line_number":21,"context_line":"then"},{"line_number":22,"context_line":"  echo \"Valid Option are cliceph ceph, cliceph ceph-disk, cliceph rbd and cliceph rados\""}],"source_content_type":"text/x-smarty","patch_set":8,"id":"5f7c97a3_5deb8a0f","line":19,"range":{"start_line":19,"start_character":3,"end_line":19,"end_character":4},"updated":"2018-08-01 16:31:44.000000000","message":"set -ex ?","commit_id":"dd944b330db4c567300312695c144f0423d3f3f1"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"1b6c5bbd8ba7e2af4b50d0c75bbf9e8e97f8cb06","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"if [[ $1 \u003d~ ceph.* ]] || [[ $1 \u003d\u003d rbd ]] || [[ $1 \u003d\u003d rados ]];"},{"line_number":28,"context_line":"then"},{"line_number":29,"context_line":"    #Gather the container ulr with hash"},{"line_number":30,"context_line":"    IMAGE\u003d`docker image inspect $(docker image ls | grep -i ceph-config-helper| awk \u0027{print$3}\u0027)|jq -j .[0].RepoDigests[]`"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    #trap function"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"5f7c97a3_ddb79a21","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":6},"updated":"2018-08-01 16:31:44.000000000","message":"#\u003cspace\u003ecomment","commit_id":"dd944b330db4c567300312695c144f0423d3f3f1"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"1b6c5bbd8ba7e2af4b50d0c75bbf9e8e97f8cb06","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"if [[ $1 \u003d~ ceph.* ]] || [[ $1 \u003d\u003d rbd ]] || [[ $1 \u003d\u003d rados ]];"},{"line_number":28,"context_line":"then"},{"line_number":29,"context_line":"    #Gather the container ulr with hash"},{"line_number":30,"context_line":"    IMAGE\u003d`docker image inspect $(docker image ls | grep -i ceph-config-helper| awk \u0027{print$3}\u0027)|jq -j .[0].RepoDigests[]`"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    #trap function"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"5f7c97a3_9d3362c4","line":29,"range":{"start_line":29,"start_character":26,"end_line":29,"end_character":29},"updated":"2018-08-01 16:31:44.000000000","message":"URL","commit_id":"dd944b330db4c567300312695c144f0423d3f3f1"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"1b6c5bbd8ba7e2af4b50d0c75bbf9e8e97f8cb06","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"if [[ $1 \u003d~ ceph.* ]] || [[ $1 \u003d\u003d rbd ]] || [[ $1 \u003d\u003d rados ]];"},{"line_number":28,"context_line":"then"},{"line_number":29,"context_line":"    #Gather the container ulr with hash"},{"line_number":30,"context_line":"    IMAGE\u003d`docker image inspect $(docker image ls | grep -i ceph-config-helper| awk \u0027{print$3}\u0027)|jq -j .[0].RepoDigests[]`"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    #trap function"}],"source_content_type":"text/x-smarty","patch_set":8,"id":"5f7c97a3_5dc4ea93","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":4},"updated":"2018-08-01 16:31:44.000000000","message":"inconsistent indent","commit_id":"dd944b330db4c567300312695c144f0423d3f3f1"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"2f9a37035234970fa45237987932edfe94917822","unresolved":false,"context_lines":[{"line_number":19,"context_line":"set -ex"},{"line_number":20,"context_line":"if [[ $1 \u003d\u003d -h ]] || [[ $1 \u003d\u003d -help ]] || [[ $1 \u003d\u003d --h ]] || [[ $1 \u003d\u003d --help ]];"},{"line_number":21,"context_line":"then"},{"line_number":22,"context_line":"  echo \"Valid Option are cliceph ceph, cliceph ceph-disk, cliceph rbd and cliceph rados\""},{"line_number":23,"context_line":"  echo \"Example: \u0027cliceph ceph osd tree\u0027\""},{"line_number":24,"context_line":"  exit 0"},{"line_number":25,"context_line":"fi"}],"source_content_type":"text/x-smarty","patch_set":18,"id":"3f79a3b5_831c4878","line":22,"range":{"start_line":22,"start_character":25,"end_line":22,"end_character":32},"updated":"2018-08-28 16:38:48.000000000","message":"can we make it as cephcli ?\nalso what about cliceph radosgw-admin ?","commit_id":"194eacd15044748eea8a1be4755344bbcacd503e"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"2f9a37035234970fa45237987932edfe94917822","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    DIR\u003d$(mktemp -d -t ceph-runtime.XXXXXX) || exit 1"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    # Gather Ceph keys and ceph Conf from k8s cluster"},{"line_number":43,"context_line":"    kubectl get secrets ceph-client-admin-keyring -n ceph -o json|jq -j  .data[]| base64 --decode \u003e $DIR/ceph.client.admin.keyring"},{"line_number":44,"context_line":"    kubectl get cm -n ceph ceph-etc -o json|jq -j  .data[] \u003e $DIR/ceph.conf"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    docker run --rm -it \\"}],"source_content_type":"text/x-smarty","patch_set":18,"id":"3f79a3b5_6e7313b6","line":43,"range":{"start_line":43,"start_character":35,"end_line":43,"end_character":36},"updated":"2018-08-28 16:38:48.000000000","message":"better if we read this keyring and namespace from values.yaml\n\nbetter if mount this secret  inside the pod so that we can avoid using kubectl utility.","commit_id":"194eacd15044748eea8a1be4755344bbcacd503e"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"d36308551d8220830cdd8a61783eb4a2c9dbf373","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    DIR\u003d$(mktemp -d -t ceph-runtime.XXXXXX) || exit 1"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    # Gather Ceph keys and ceph Conf from k8s cluster"},{"line_number":43,"context_line":"    kubectl get secrets ceph-client-admin-keyring -n ceph -o json|jq -j  .data[]| base64 --decode \u003e $DIR/ceph.client.admin.keyring"},{"line_number":44,"context_line":"    kubectl get cm -n ceph ceph-etc -o json|jq -j  .data[] \u003e $DIR/ceph.conf"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    docker run --rm -it \\"}],"source_content_type":"text/x-smarty","patch_set":18,"id":"3f79a3b5_bbc64868","line":43,"range":{"start_line":43,"start_character":35,"end_line":43,"end_character":36},"in_reply_to":"3f79a3b5_6e7313b6","updated":"2018-08-28 18:21:05.000000000","message":"this utility will do a docker run from the host. we cannot mount a k8s secret on docker run","commit_id":"194eacd15044748eea8a1be4755344bbcacd503e"},{"author":{"_account_id":28372,"name":"chinasubbareddy mallavarapu","email":"cr3938@att.com","username":"chinasubbareddy"},"change_message_id":"2f9a37035234970fa45237987932edfe94917822","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    # Gather Ceph keys and ceph Conf from k8s cluster"},{"line_number":43,"context_line":"    kubectl get secrets ceph-client-admin-keyring -n ceph -o json|jq -j  .data[]| base64 --decode \u003e $DIR/ceph.client.admin.keyring"},{"line_number":44,"context_line":"    kubectl get cm -n ceph ceph-etc -o json|jq -j  .data[] \u003e $DIR/ceph.conf"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    docker run --rm -it \\"},{"line_number":47,"context_line":"        --net host \\"}],"source_content_type":"text/x-smarty","patch_set":18,"id":"3f79a3b5_ae604bd1","line":44,"range":{"start_line":44,"start_character":27,"end_line":44,"end_character":31},"updated":"2018-08-28 16:38:48.000000000","message":"please read configmap from values.yaml\n\nalso you can directly mount this configmap so that easy to copy ad you can avoid using kubectl command","commit_id":"194eacd15044748eea8a1be4755344bbcacd503e"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"d36308551d8220830cdd8a61783eb4a2c9dbf373","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    # Gather Ceph keys and ceph Conf from k8s cluster"},{"line_number":43,"context_line":"    kubectl get secrets ceph-client-admin-keyring -n ceph -o json|jq -j  .data[]| base64 --decode \u003e $DIR/ceph.client.admin.keyring"},{"line_number":44,"context_line":"    kubectl get cm -n ceph ceph-etc -o json|jq -j  .data[] \u003e $DIR/ceph.conf"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    docker run --rm -it \\"},{"line_number":47,"context_line":"        --net host \\"}],"source_content_type":"text/x-smarty","patch_set":18,"id":"3f79a3b5_3ba8f88a","line":44,"range":{"start_line":44,"start_character":27,"end_line":44,"end_character":31},"in_reply_to":"3f79a3b5_ae604bd1","updated":"2018-08-28 18:21:05.000000000","message":"this utility will do a docker run from the host. we cannot mount a k8s configmap on docker run","commit_id":"194eacd15044748eea8a1be4755344bbcacd503e"}],"ceph-provisioners/templates/configmap-bin.yaml":[{"author":{"_account_id":28704,"name":"Al Lau","email":"al070e@att.com","username":"al070e"},"change_message_id":"f21cc1b1fe26a68b345bc8c72826fae9c3714cc9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"{{ tuple \"bin/provisioner/rbd/_start.sh.tpl\" . | include  \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  cliceph: |"},{"line_number":44,"context_line":"{{ tuple \"bin/utilities/_cliceph.tpl\" . | include  \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":45,"context_line":"  move.sh: |"},{"line_number":46,"context_line":"{{ tuple \"bin/utilities/_move.sh.tpl\" . | include  \"helm-toolkit.utils.template\" | indent 4 }}"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_592d358e","line":44,"updated":"2018-07-27 22:04:56.000000000","message":"bin/utils as directory name to be consistent with other ceph-*/templates/bin/utils?","commit_id":"80063b1026ef45a44106372d0884a246f3635d91"}],"ceph-provisioners/templates/job-utilities.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"61adf574a92bc8751740a7110f1f873bde4fc922","unresolved":false,"context_lines":[{"line_number":74,"context_line":"              mountPath: /tmp/move.sh"},{"line_number":75,"context_line":"              subPath: move.sh"},{"line_number":76,"context_line":"              readOnly: true"},{"line_number":77,"context_line":"            - name: host-usr-local-bin"},{"line_number":78,"context_line":"              mountPath: /usr/local/bin"},{"line_number":79,"context_line":"            - name: ceph-provisioners-bin"},{"line_number":80,"context_line":"              mountPath: /tmp/cliceph"},{"line_number":81,"context_line":"              subPath: cliceph"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_dd131a01","line":78,"range":{"start_line":77,"start_character":14,"end_line":78,"end_character":39},"updated":"2018-08-01 16:33:57.000000000","message":"i\u0027m not a fan of things touching /usr/local/bin/ etc on the hosts\n\nif we must copy things in, we should be clear about the paths and impact","commit_id":"dd944b330db4c567300312695c144f0423d3f3f1"},{"author":{"_account_id":28704,"name":"Al Lau","email":"al070e@att.com","username":"al070e"},"change_message_id":"fb6d5e2ec27bc5659f7c1475fa22b970e3257663","unresolved":false,"context_lines":[{"line_number":51,"context_line":"apiVersion: batch/v1"},{"line_number":52,"context_line":"kind: Job"},{"line_number":53,"context_line":"metadata:"},{"line_number":54,"context_line":"  name: ceph-client-utilities"},{"line_number":55,"context_line":"spec:"},{"line_number":56,"context_line":"  template:"},{"line_number":57,"context_line":"    metadata:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_4766752c","line":54,"updated":"2018-08-14 16:20:36.000000000","message":"Not using $serviceAccountName for metadata.name?","commit_id":"03e7d33b62c9bf3995320802f68c27924f849898"},{"author":{"_account_id":28704,"name":"Al Lau","email":"al070e@att.com","username":"al070e"},"change_message_id":"fb6d5e2ec27bc5659f7c1475fa22b970e3257663","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  template:"},{"line_number":57,"context_line":"    metadata:"},{"line_number":58,"context_line":"      labels:"},{"line_number":59,"context_line":"{{ tuple $envAll \"ceph\" \"ceph_client_utilities\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":60,"context_line":"    spec:"},{"line_number":61,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":62,"context_line":"      backoffLimit: 5"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_0745dd6f","line":59,"updated":"2018-08-14 16:20:36.000000000","message":"Not sure the \u0027_\u0027s in \"ceph_client_utilities\" would work.  Should use $serviceAccountName for \"ceph_client_utilities\" similar to line 21.","commit_id":"03e7d33b62c9bf3995320802f68c27924f849898"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"476bc6ed3d4649e5880018b549edd3c7e98936b2","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  template:"},{"line_number":57,"context_line":"    metadata:"},{"line_number":58,"context_line":"      labels:"},{"line_number":59,"context_line":"{{ tuple $envAll \"ceph\" \"ceph_client_utilities\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":60,"context_line":"    spec:"},{"line_number":61,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":62,"context_line":"      backoffLimit: 5"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_fd5ab080","line":59,"in_reply_to":"3f79a3b5_0745dd6f","updated":"2018-08-14 17:32:11.000000000","message":"ceph_client_utilities is the node label applied in as part of the deployment. Label and Service account names are different.","commit_id":"03e7d33b62c9bf3995320802f68c27924f849898"}],"ceph-provisioners/values.yaml":[{"author":{"_account_id":28704,"name":"Al Lau","email":"al070e@att.com","username":"al070e"},"change_message_id":"f21cc1b1fe26a68b345bc8c72826fae9c3714cc9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  provisioner:"},{"line_number":48,"context_line":"    node_selector_key: openstack-control-plane"},{"line_number":49,"context_line":"    node_selector_value: enabled"},{"line_number":50,"context_line":"  utilities:"},{"line_number":51,"context_line":"    node_selector_key: openstack-helm-node-class"},{"line_number":52,"context_line":"    node_selector_value: primary"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_3985d959","line":50,"updated":"2018-07-27 22:04:56.000000000","message":"utilities -\u003e utils?","commit_id":"80063b1026ef45a44106372d0884a246f3635d91"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"1b6c5bbd8ba7e2af4b50d0c75bbf9e8e97f8cb06","unresolved":false,"context_lines":[{"line_number":95,"context_line":"          cpu: \"2000m\""},{"line_number":96,"context_line":"      ceph_client_utilities:"},{"line_number":97,"context_line":"        limits:"},{"line_number":98,"context_line":"          memory: \"1024Mi\""},{"line_number":99,"context_line":"          cpu: \"2000m\""},{"line_number":100,"context_line":"        requests:"},{"line_number":101,"context_line":"          memory: \"128Mi\""},{"line_number":102,"context_line":"          cpu: \"500m\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_5d52aadb","line":99,"range":{"start_line":98,"start_character":10,"end_line":99,"end_character":22},"updated":"2018-08-01 16:31:44.000000000","message":"memory seems high?","commit_id":"dd944b330db4c567300312695c144f0423d3f3f1"}],"tools/deployment/developer/ceph/040-ceph.sh":[{"author":{"_account_id":28704,"name":"Al Lau","email":"al070e@att.com","username":"al070e"},"change_message_id":"fb6d5e2ec27bc5659f7c1475fa22b970e3257663","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  cephfs_provisioner: true"},{"line_number":53,"context_line":"  client_secrets: false"},{"line_number":54,"context_line":"  rgw_keystone_user_and_endpoints: false"},{"line_number":55,"context_line":"ceph_client_utilities:"},{"line_number":56,"context_line":"  enabled: true"},{"line_number":57,"context_line":"bootstrap:"},{"line_number":58,"context_line":"  enabled: true"}],"source_content_type":"text/x-sh","patch_set":14,"id":"3f79a3b5_8249db60","line":55,"updated":"2018-08-14 16:20:36.000000000","message":"This is also set in ceph-provisioners/values.yaml file.  Do we need both?","commit_id":"03e7d33b62c9bf3995320802f68c27924f849898"},{"author":{"_account_id":22713,"name":"Sreejith Punnapuzha","email":"Sreejith.Punnapuzha@outlook.com","username":"sreejith"},"change_message_id":"0b41a53b7108c24e94e9a09ce61c09a99b9e4cdf","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  cephfs_provisioner: true"},{"line_number":53,"context_line":"  client_secrets: false"},{"line_number":54,"context_line":"  rgw_keystone_user_and_endpoints: false"},{"line_number":55,"context_line":"ceph_client_utilities:"},{"line_number":56,"context_line":"  enabled: true"},{"line_number":57,"context_line":"bootstrap:"},{"line_number":58,"context_line":"  enabled: true"}],"source_content_type":"text/x-sh","patch_set":14,"id":"3f79a3b5_5d90844a","line":55,"in_reply_to":"3f79a3b5_8249db60","updated":"2018-08-14 17:21:03.000000000","message":"This enables ceph_client_utilities deployment and label assignment. with out this the utility will not be installed","commit_id":"03e7d33b62c9bf3995320802f68c27924f849898"}]}