)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"f16a4fb7ce37e2c7db75ab8ccdff70aebecf99bf","unresolved":false,"context_lines":[{"line_number":9,"context_line":"- make mon port overridable through env variable"},{"line_number":10,"context_line":"- update ceph.conf to include fqdn with port number"},{"line_number":11,"context_line":"- add mon_add: to ceph global conf"},{"line_number":12,"context_line":"- updating ClusterRoleBinding name for cephfs and rbd provisioner."},{"line_number":13,"context_line":"- remove unused network.port section as we specify ports through endpoints"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"With these changes, ceph mon can run on different port"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_61b3730b","line":12,"range":{"start_line":12,"start_character":65,"end_line":12,"end_character":66},"updated":"2018-08-13 18:27:05.000000000","message":"trailing . - other lines don\u0027t have it :)","commit_id":"2b5b2442a57190737bdfb8ca0c860f49ea95266b"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"f16a4fb7ce37e2c7db75ab8ccdff70aebecf99bf","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- update ceph.conf to include fqdn with port number"},{"line_number":11,"context_line":"- add mon_add: to ceph global conf"},{"line_number":12,"context_line":"- updating ClusterRoleBinding name for cephfs and rbd provisioner."},{"line_number":13,"context_line":"- remove unused network.port section as we specify ports through endpoints"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"With these changes, ceph mon can run on different port"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_81b80fe5","line":13,"range":{"start_line":13,"start_character":65,"end_line":13,"end_character":74},"updated":"2018-08-13 18:27:05.000000000","message":"wrap to next line?","commit_id":"2b5b2442a57190737bdfb8ca0c860f49ea95266b"}],"ceph-client/values.yaml":[{"author":{"_account_id":28704,"name":"Al Lau","email":"al070e@att.com","username":"al070e"},"change_message_id":"4599908236561d06f5a343f9731c65fa2add99c3","unresolved":false,"context_lines":[{"line_number":288,"context_line":"      cephx_require_signatures: false"},{"line_number":289,"context_line":"      cephx_cluster_require_signatures: true"},{"line_number":290,"context_line":"      cephx_service_require_signatures: false"},{"line_number":291,"context_line":"      mon_addr: :6789"},{"line_number":292,"context_line":"    osd:"},{"line_number":293,"context_line":"      osd_mkfs_type: xfs"},{"line_number":294,"context_line":"      osd_mkfs_options_xfs: -f -i size\u003d2048"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_b73d4990","line":291,"updated":"2018-08-13 20:13:56.000000000","message":"Use mon_port as other places use ${MON_PORT}","commit_id":"2b5b2442a57190737bdfb8ca0c860f49ea95266b"},{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"7d8a7a49003049972d146087f73594c54ed47eb6","unresolved":false,"context_lines":[{"line_number":288,"context_line":"      cephx_require_signatures: false"},{"line_number":289,"context_line":"      cephx_cluster_require_signatures: true"},{"line_number":290,"context_line":"      cephx_service_require_signatures: false"},{"line_number":291,"context_line":"      mon_addr: :6789"},{"line_number":292,"context_line":"    osd:"},{"line_number":293,"context_line":"      osd_mkfs_type: xfs"},{"line_number":294,"context_line":"      osd_mkfs_options_xfs: -f -i size\u003d2048"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_37cff956","line":291,"in_reply_to":"3f79a3b5_b73d4990","updated":"2018-08-13 20:28:15.000000000","message":"Al, this is to specify mon address with port number. \nThis should not be set with MON_PORT","commit_id":"2b5b2442a57190737bdfb8ca0c860f49ea95266b"}],"ceph-mon/templates/configmap-etc.yaml":[{"author":{"_account_id":28704,"name":"Al Lau","email":"al070e@att.com","username":"al070e"},"change_message_id":"4599908236561d06f5a343f9731c65fa2add99c3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"{{- $_ :\u003d $monHost | set .Values.conf.ceph.global \"mon_host\" -}}"},{"line_number":27,"context_line":"{{- end -}}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{{- if empty .Values.conf.ceph.global.fsid -}}"},{"line_number":30,"context_line":"{{- $_ :\u003d uuidv4 | set .Values.conf.ceph.global \"fsid\" -}}"},{"line_number":31,"context_line":"{{- end -}}"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_972fed3d","line":29,"updated":"2018-08-13 20:13:56.000000000","message":"Now that monitor port is not static any more, do we need to check for the monitor port that is similar to fsid and mon_host?","commit_id":"2b5b2442a57190737bdfb8ca0c860f49ea95266b"}],"ceph-mon/values.yaml":[{"author":{"_account_id":28704,"name":"Al Lau","email":"al070e@att.com","username":"al070e"},"change_message_id":"cfd0a9107615393730c15389a10c61771bb9f823","unresolved":false,"context_lines":[{"line_number":153,"context_line":"      cephx_require_signatures: false"},{"line_number":154,"context_line":"      cephx_cluster_require_signatures: true"},{"line_number":155,"context_line":"      cephx_service_require_signatures: false"},{"line_number":156,"context_line":"      mon_addr: :6789"},{"line_number":157,"context_line":"    osd:"},{"line_number":158,"context_line":"      osd_mkfs_type: xfs"},{"line_number":159,"context_line":"      osd_mkfs_options_xfs: -f -i size\u003d2048"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_a1a219fb","line":156,"updated":"2018-08-10 13:21:39.000000000","message":"The ceph.conf comes from these ceph-{mon,osd,client,provision}/values.yaml files.  So, I would think the other three values.yaml files need changing as well.\n\nIt may be worth the effort to have one place where we define the ceph.conf content and include it in all the four values.yaml files.","commit_id":"09366ccfca33961367257960486d26db4703267a"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"59463e88eb863c3146e2ee141d1a417dea3019f4","unresolved":false,"context_lines":[{"line_number":153,"context_line":"      cephx_require_signatures: false"},{"line_number":154,"context_line":"      cephx_cluster_require_signatures: true"},{"line_number":155,"context_line":"      cephx_service_require_signatures: false"},{"line_number":156,"context_line":"      mon_addr: :6789"},{"line_number":157,"context_line":"    osd:"},{"line_number":158,"context_line":"      osd_mkfs_type: xfs"},{"line_number":159,"context_line":"      osd_mkfs_options_xfs: -f -i size\u003d2048"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_d74565b5","line":156,"range":{"start_line":156,"start_character":6,"end_line":156,"end_character":21},"updated":"2018-08-13 20:30:10.000000000","message":"should this not be automatically populated if not set?","commit_id":"2b5b2442a57190737bdfb8ca0c860f49ea95266b"}],"ceph-osd/values.yaml":[{"author":{"_account_id":28704,"name":"Al Lau","email":"al070e@att.com","username":"al070e"},"change_message_id":"4599908236561d06f5a343f9731c65fa2add99c3","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      cephx_require_signatures: false"},{"line_number":89,"context_line":"      cephx_cluster_require_signatures: true"},{"line_number":90,"context_line":"      cephx_service_require_signatures: false"},{"line_number":91,"context_line":"      mon_addr: :6789"},{"line_number":92,"context_line":"    osd:"},{"line_number":93,"context_line":"      osd_mkfs_type: xfs"},{"line_number":94,"context_line":"      osd_mkfs_options_xfs: -f -i size\u003d2048"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_d751e5da","line":91,"updated":"2018-08-13 20:13:56.000000000","message":"mon_port?","commit_id":"2b5b2442a57190737bdfb8ca0c860f49ea95266b"},{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"7d8a7a49003049972d146087f73594c54ed47eb6","unresolved":false,"context_lines":[{"line_number":88,"context_line":"      cephx_require_signatures: false"},{"line_number":89,"context_line":"      cephx_cluster_require_signatures: true"},{"line_number":90,"context_line":"      cephx_service_require_signatures: false"},{"line_number":91,"context_line":"      mon_addr: :6789"},{"line_number":92,"context_line":"    osd:"},{"line_number":93,"context_line":"      osd_mkfs_type: xfs"},{"line_number":94,"context_line":"      osd_mkfs_options_xfs: -f -i size\u003d2048"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_17fbdd78","line":91,"in_reply_to":"3f79a3b5_d751e5da","updated":"2018-08-13 20:28:15.000000000","message":"no this needs to be mon_addr as per RHT recommendation.","commit_id":"2b5b2442a57190737bdfb8ca0c860f49ea95266b"}],"tools/deployment/developer/ceph/040-ceph.sh":[{"author":{"_account_id":28704,"name":"Al Lau","email":"al070e@att.com","username":"al070e"},"change_message_id":"cfd0a9107615393730c15389a10c61771bb9f823","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  public: 172.17.0.1/16"},{"line_number":61,"context_line":"  cluster: 172.17.0.1/16"},{"line_number":62,"context_line":"  port:"},{"line_number":63,"context_line":"    mon: 6789"},{"line_number":64,"context_line":"    rgw: 8088"},{"line_number":65,"context_line":"    mgr: 7000"},{"line_number":66,"context_line":"deployment:"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3f79a3b5_4168e585","line":63,"updated":"2018-08-10 13:21:39.000000000","message":"Can you make this derive from endpoints.ceph_mon.port.mon.default instead of hard coding?","commit_id":"09366ccfca33961367257960486d26db4703267a"},{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"99df03c9d5f65297f788b5a61e19c00b0a489a9d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  public: 172.17.0.1/16"},{"line_number":61,"context_line":"  cluster: 172.17.0.1/16"},{"line_number":62,"context_line":"  port:"},{"line_number":63,"context_line":"    mon: 6789"},{"line_number":64,"context_line":"    rgw: 8088"},{"line_number":65,"context_line":"    mgr: 7000"},{"line_number":66,"context_line":"deployment:"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3f79a3b5_40cd1864","line":63,"in_reply_to":"3f79a3b5_4168e585","updated":"2018-08-13 14:48:11.000000000","message":"Actually i now understand you point. So first of all, i need to review if we actually use these values somewhere in chart (network.port.mon). I don\u0027t think we are. \n2) I think in values.yaml, we have to hard code these port. But for configmap-etc we can fetch port number by using helm-toolkit function.","commit_id":"09366ccfca33961367257960486d26db4703267a"},{"author":{"_account_id":24165,"name":"Renis Makadia","email":"renis.makadia@att.com","username":"renmak"},"change_message_id":"a567c684b4fd696f15fb5d14f727bcf7c104f4a6","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  public: 172.17.0.1/16"},{"line_number":61,"context_line":"  cluster: 172.17.0.1/16"},{"line_number":62,"context_line":"  port:"},{"line_number":63,"context_line":"    mon: 6789"},{"line_number":64,"context_line":"    rgw: 8088"},{"line_number":65,"context_line":"    mgr: 7000"},{"line_number":66,"context_line":"deployment:"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3f79a3b5_c06128ab","line":63,"in_reply_to":"3f79a3b5_4168e585","updated":"2018-08-13 14:33:54.000000000","message":"When you run this script, ceph is not installed yet thus end points are not available.","commit_id":"09366ccfca33961367257960486d26db4703267a"}]}
