)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"efe70cbafdc09f0e4711ca92c6175b95bfbfb7c5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Roy Tang \u003crt7380@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-13 11:01:57 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[US 445734] Neutron TaaS support as L2 Extension."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is the initial draft to enhance neutron in ocata to"},{"line_number":10,"context_line":"support Tap-as-a-service (TaaS) as a L2 Extension."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_e368ee1d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":49},"updated":"2018-08-13 15:28:18.000000000","message":"probably don\u0027t want/need the US reference in the comment","commit_id":"ba39f337c471d93788e99fc5d147e59fd4a443f8"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"ac52bce2550210b93f7e39ea2ec918d6e4f5275a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Roy Tang \u003crt7380@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-13 13:27:19 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Neutron TaaS support as L2 Extension."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is the initial draft to enhance neutron in ocata to"},{"line_number":10,"context_line":"support Tap-as-a-service (TaaS) as a L2 Extension."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_a18bcb1c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":37},"updated":"2018-08-13 18:29:23.000000000","message":"[neutron] TaaS support as L2 extension\n\n?\n\nstyle, not strongly enforced","commit_id":"dc516822466b5b91556ca5c03bc4fb385a62fbc8"}],"neutron/templates/bin/_neutron-openvswitch-agent.sh.tpl":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"efe70cbafdc09f0e4711ca92c6175b95bfbfb7c5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"{{- if ( contains \"taas\" .Values.conf.plugins.ml2_conf.agent.extensions ) }} \\"},{"line_number":27,"context_line":"  --config-file /etc/neutron/taas_plugin.ini"},{"line_number":28,"context_line":"{{- end }}"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3f79a3b5_034deac2","line":29,"updated":"2018-08-13 15:28:18.000000000","message":"ws","commit_id":"ba39f337c471d93788e99fc5d147e59fd4a443f8"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"e27d3279e7bac4d93dada0f06d279e58f1b2fbf1","unresolved":false,"context_lines":[{"line_number":26,"context_line":"{{- if ( contains \"taas\" .Values.conf.plugins.ml2_conf.agent.extensions ) }} \\"},{"line_number":27,"context_line":"  --config-file /etc/neutron/taas_plugin.ini"},{"line_number":28,"context_line":"{{- end }}"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3f79a3b5_2f148743","line":29,"in_reply_to":"3f79a3b5_034deac2","updated":"2018-08-13 17:26:48.000000000","message":"yep. removed","commit_id":"ba39f337c471d93788e99fc5d147e59fd4a443f8"}],"neutron/templates/bin/_neutron-sriov-agent.sh.tpl":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"efe70cbafdc09f0e4711ca92c6175b95bfbfb7c5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"{{- if ( contains \"taas\" .Values.conf.plugins.ml2_conf.agent.extensions ) }} \\"},{"line_number":26,"context_line":"  --config-file /etc/neutron/taas_plugin.ini"},{"line_number":27,"context_line":"{{- end }}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3f79a3b5_234a66ab","line":28,"updated":"2018-08-13 15:28:18.000000000","message":"ws","commit_id":"ba39f337c471d93788e99fc5d147e59fd4a443f8"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"e27d3279e7bac4d93dada0f06d279e58f1b2fbf1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"{{- if ( contains \"taas\" .Values.conf.plugins.ml2_conf.agent.extensions ) }} \\"},{"line_number":26,"context_line":"  --config-file /etc/neutron/taas_plugin.ini"},{"line_number":27,"context_line":"{{- end }}"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3f79a3b5_4f11c351","line":28,"in_reply_to":"3f79a3b5_234a66ab","updated":"2018-08-13 17:26:48.000000000","message":"yep removed","commit_id":"ba39f337c471d93788e99fc5d147e59fd4a443f8"}],"neutron/templates/configmap-etc.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"5471747b047cdd3cc341452b4acd63d3c6d3d264","unresolved":false,"context_lines":[{"line_number":193,"context_line":"{{ include \"helm-toolkit.utils.to_oslo_conf\" $envAll.Values.conf.metadata_agent | indent 4 }}"},{"line_number":194,"context_line":"  metering_agent.ini: |"},{"line_number":195,"context_line":"{{ include \"helm-toolkit.utils.to_oslo_conf\" $envAll.Values.conf.metering_agent | indent 4 }}"},{"line_number":196,"context_line":"  taas_plugin.ini: |"},{"line_number":197,"context_line":"{{ include \"helm-toolkit.utils.to_oslo_conf\" $envAll.Values.conf.taas_plugin | indent 4 }}"},{"line_number":198,"context_line":"  ml2_conf.ini: |"},{"line_number":199,"context_line":"{{ include \"helm-toolkit.utils.to_oslo_conf\" $envAll.Values.conf.plugins.ml2_conf | indent 4 }}"},{"line_number":200,"context_line":"  ml2_conf_sriov.ini: |"},{"line_number":201,"context_line":"{{ include \"helm-toolkit.utils.to_oslo_conf\" $envAll.Values.conf.plugins.ml2_conf_sriov | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_e1a9c37b","line":198,"range":{"start_line":196,"start_character":1,"end_line":198,"end_character":2},"updated":"2018-08-13 18:30:52.000000000","message":"should these configmap be wrapped in conditionals as well as they are conditionally mounted?","commit_id":"dc516822466b5b91556ca5c03bc4fb385a62fbc8"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"c93a49c00816d254866076f05506e6573f84a8c9","unresolved":false,"context_lines":[{"line_number":193,"context_line":"{{ include \"helm-toolkit.utils.to_oslo_conf\" $envAll.Values.conf.metadata_agent | indent 4 }}"},{"line_number":194,"context_line":"  metering_agent.ini: |"},{"line_number":195,"context_line":"{{ include \"helm-toolkit.utils.to_oslo_conf\" $envAll.Values.conf.metering_agent | indent 4 }}"},{"line_number":196,"context_line":"  taas_plugin.ini: |"},{"line_number":197,"context_line":"{{ include \"helm-toolkit.utils.to_oslo_conf\" $envAll.Values.conf.taas_plugin | indent 4 }}"},{"line_number":198,"context_line":"  ml2_conf.ini: |"},{"line_number":199,"context_line":"{{ include \"helm-toolkit.utils.to_oslo_conf\" $envAll.Values.conf.plugins.ml2_conf | indent 4 }}"},{"line_number":200,"context_line":"  ml2_conf_sriov.ini: |"},{"line_number":201,"context_line":"{{ include \"helm-toolkit.utils.to_oslo_conf\" $envAll.Values.conf.plugins.ml2_conf_sriov | indent 4 }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_5aa89c8a","line":198,"range":{"start_line":196,"start_character":1,"end_line":198,"end_character":2},"in_reply_to":"3f79a3b5_e1a9c37b","updated":"2018-08-13 21:11:57.000000000","message":"I can add the check, but is there any harm leaving it here?  no checks was added for all the sriov related config also, I was just trying to be consistent also.","commit_id":"dc516822466b5b91556ca5c03bc4fb385a62fbc8"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"5471747b047cdd3cc341452b4acd63d3c6d3d264","unresolved":false,"context_lines":[{"line_number":199,"context_line":"{{ include \"helm-toolkit.utils.to_oslo_conf\" $envAll.Values.conf.plugins.ml2_conf | indent 4 }}"},{"line_number":200,"context_line":"  ml2_conf_sriov.ini: |"},{"line_number":201,"context_line":"{{ include \"helm-toolkit.utils.to_oslo_conf\" $envAll.Values.conf.plugins.ml2_conf_sriov | indent 4 }}"},{"line_number":202,"context_line":"  taas.ini: |"},{"line_number":203,"context_line":"{{ include \"helm-toolkit.utils.to_oslo_conf\" $envAll.Values.conf.plugins.taas| indent 4 }}"},{"line_number":204,"context_line":"  macvtap_agent.ini: |"},{"line_number":205,"context_line":"{{ include \"helm-toolkit.utils.to_oslo_conf\" $envAll.Values.conf.plugins.macvtap_agent | indent 4 }}"},{"line_number":206,"context_line":"  linuxbridge_agent.ini: |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_01a71fa9","line":203,"range":{"start_line":202,"start_character":1,"end_line":203,"end_character":90},"updated":"2018-08-13 18:30:52.000000000","message":"ditto","commit_id":"dc516822466b5b91556ca5c03bc4fb385a62fbc8"}],"neutron/values.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"f7ecacc3c28ed2ea57a33fd6d6948f2e1efca83d","unresolved":false,"context_lines":[{"line_number":1556,"context_line":"    taas:"},{"line_number":1557,"context_line":"      taas:"},{"line_number":1558,"context_line":"        driver: neutron_taas.services.taas.drivers.linux.ovs_taas.OvsTaasDriver"},{"line_number":1559,"context_line":"        enabled: True"},{"line_number":1560,"context_line":"        vlan_range_start: 3000"},{"line_number":1561,"context_line":"        vlan_range_end: 3500"},{"line_number":1562,"context_line":"    openvswitch_agent:"},{"line_number":1563,"context_line":"      agent:"},{"line_number":1564,"context_line":"        tunnel_types: vxlan"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_b78c2280","line":1561,"range":{"start_line":1559,"start_character":0,"end_line":1561,"end_character":28},"updated":"2018-08-16 15:17:46.000000000","message":"we prob want these to be left as defaults by default.","commit_id":"e0eb50f83c0afa92a81b0a43d8bc158fc01a08b2"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"4d90786d3f9a4e9be1c73628fe8ea0920a72bd0d","unresolved":false,"context_lines":[{"line_number":1556,"context_line":"    taas:"},{"line_number":1557,"context_line":"      taas:"},{"line_number":1558,"context_line":"        driver: neutron_taas.services.taas.drivers.linux.ovs_taas.OvsTaasDriver"},{"line_number":1559,"context_line":"        enabled: True"},{"line_number":1560,"context_line":"        vlan_range_start: 3000"},{"line_number":1561,"context_line":"        vlan_range_end: 3500"},{"line_number":1562,"context_line":"    openvswitch_agent:"},{"line_number":1563,"context_line":"      agent:"},{"line_number":1564,"context_line":"        tunnel_types: vxlan"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_aefb6b45","line":1561,"range":{"start_line":1559,"start_character":0,"end_line":1561,"end_character":28},"in_reply_to":"3f79a3b5_b78c2280","updated":"2018-08-16 19:06:58.000000000","message":"you want me to comment this out too?  or remove them altogether?","commit_id":"e0eb50f83c0afa92a81b0a43d8bc158fc01a08b2"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"f7ecacc3c28ed2ea57a33fd6d6948f2e1efca83d","unresolved":false,"context_lines":[{"line_number":1588,"context_line":"      sriov_nic:"},{"line_number":1589,"context_line":"        physical_device_mappings: physnet2:enp3s0f1"},{"line_number":1590,"context_line":"        exclude_devices: null"},{"line_number":1591,"context_line":"  taas_plugin:"},{"line_number":1592,"context_line":"    service_providers:"},{"line_number":1593,"context_line":"      service_provider: TAAS:TAAS:neutron_taas.services.taas.service_drivers.taas_rpc.TaasRpcDriver:default"},{"line_number":1594,"context_line":"  dhcp_agent:"},{"line_number":1595,"context_line":"    DEFAULT:"},{"line_number":1596,"context_line":"      #(NOTE)portdirect: if unset this is populated dyanmicly from the value in"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_d7951e8a","line":1593,"range":{"start_line":1591,"start_character":0,"end_line":1593,"end_character":107},"updated":"2018-08-16 15:17:46.000000000","message":"we prob want this to be commented out by default.","commit_id":"e0eb50f83c0afa92a81b0a43d8bc158fc01a08b2"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"4d90786d3f9a4e9be1c73628fe8ea0920a72bd0d","unresolved":false,"context_lines":[{"line_number":1588,"context_line":"      sriov_nic:"},{"line_number":1589,"context_line":"        physical_device_mappings: physnet2:enp3s0f1"},{"line_number":1590,"context_line":"        exclude_devices: null"},{"line_number":1591,"context_line":"  taas_plugin:"},{"line_number":1592,"context_line":"    service_providers:"},{"line_number":1593,"context_line":"      service_provider: TAAS:TAAS:neutron_taas.services.taas.service_drivers.taas_rpc.TaasRpcDriver:default"},{"line_number":1594,"context_line":"  dhcp_agent:"},{"line_number":1595,"context_line":"    DEFAULT:"},{"line_number":1596,"context_line":"      #(NOTE)portdirect: if unset this is populated dyanmicly from the value in"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_eed883f1","line":1593,"range":{"start_line":1591,"start_character":0,"end_line":1593,"end_character":107},"in_reply_to":"3f79a3b5_d7951e8a","updated":"2018-08-16 19:06:58.000000000","message":"Is it better to comment them out or just remove them.  Actually if I remove them, it will break the configmap-etc right?","commit_id":"e0eb50f83c0afa92a81b0a43d8bc158fc01a08b2"}]}
