)]}'
{"id":"openstack%2Fopenstack-helm~592570","triplet_id":"openstack%2Fopenstack-helm~master~Idd26fd3c19191f3c3e0aeb6fa3efa9a4ec48ee54","project":"openstack/openstack-helm","branch":"master","topic":"592152","hashtags":[],"change_id":"Idd26fd3c19191f3c3e0aeb6fa3efa9a4ec48ee54","subject":"Libvirt: Warn if hugetlb cgroup controller is enabled","status":"MERGED","created":"2018-08-16 16:13:38.000000000","updated":"2018-08-16 22:21:17.000000000","submitted":"2018-08-16 22:21:17.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"592570-1534458077263-4bddaeb8","meta_rev_id":"bbacf78b56a5a103d8683c298334a57535b9bb6e","_number":592570,"virtual_id_number":592570,"owner":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":28162,"name":"Ruslan Khanbikov","email":"rkhanbikov@gmail.com","username":"rkhanbikov"},{"value":0,"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":0,"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"value":2,"date":"2018-08-16 22:21:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},{"value":0,"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"recommended":{"_account_id":28162,"name":"Ruslan Khanbikov","email":"rkhanbikov@gmail.com","username":"rkhanbikov"},"all":[{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":1,"date":"2018-08-16 19:08:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28162,"name":"Ruslan Khanbikov","email":"rkhanbikov@gmail.com","username":"rkhanbikov"},{"value":2,"date":"2018-08-16 18:40:35.000000000","_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":2,"date":"2018-08-16 21:09:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},{"value":0,"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"all":[{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"date":"2018-08-16 16:25:26.000000000","_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"value":0,"_account_id":28162,"name":"Ruslan Khanbikov","email":"rkhanbikov@gmail.com","username":"rkhanbikov"},{"value":0,"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"value":1,"date":"2018-08-16 21:09:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2018-08-16 16:25:26.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},{"value":0,"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},{"_account_id":28162,"name":"Ruslan Khanbikov","email":"rkhanbikov@gmail.com","username":"rkhanbikov"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-08-16 16:14:14.000000000","updated_by":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"reviewer":{"_account_id":26686,"name":"Craig Anderson","email":"craig.cigar.anderson@gmail.com","username":"canderson"},"state":"REVIEWER"},{"updated":"2018-08-16 16:14:58.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"},{"updated":"2018-08-16 16:25:26.000000000","updated_by":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"reviewer":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"state":"REVIEWER"},{"updated":"2018-08-16 16:25:26.000000000","updated_by":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"reviewer":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"state":"REVIEWER"},{"updated":"2018-08-16 18:40:35.000000000","updated_by":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"reviewer":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"state":"REVIEWER"},{"updated":"2018-08-16 19:08:34.000000000","updated_by":{"_account_id":28162,"name":"Ruslan Khanbikov","email":"rkhanbikov@gmail.com","username":"rkhanbikov"},"reviewer":{"_account_id":28162,"name":"Ruslan Khanbikov","email":"rkhanbikov@gmail.com","username":"rkhanbikov"},"state":"REVIEWER"},{"updated":"2018-08-16 21:09:11.000000000","updated_by":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"reviewer":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"state":"REVIEWER"},{"updated":"2018-08-16 22:21:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"aaf1c42e0900d5c3f43b20b1c52b6126ed4f8168","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2018-08-16 16:13:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4d9baf769bf271078b56555e55513a09cc37f749","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2018-08-16 16:22:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"bbfe1575d5bae0748ee577e1f6e8bd3f90a7c387","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-16 18:35:31.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/70/592570/2/check/build-openstack-sphinx-docs/5dcfe94/html/ : SUCCESS in 6m 04s\n- openstack-helm-linter http://logs.openstack.org/70/592570/2/check/openstack-helm-linter/b47ea68/ : SUCCESS in 1m 44s\n- openstack-helm-dev-deploy-ceph-swift-ovs http://logs.openstack.org/70/592570/2/check/openstack-helm-dev-deploy-ceph-swift-ovs/fb31aff/ : SUCCESS in 1h 04m 01s\n- openstack-helm-dev-deploy-ceph-radosgw-ovs http://logs.openstack.org/70/592570/2/check/openstack-helm-dev-deploy-ceph-radosgw-ovs/25663d4/ : SUCCESS in 56m 21s\n- openstack-helm-dev-deploy-ceph-rbd-ovs http://logs.openstack.org/70/592570/2/check/openstack-helm-dev-deploy-ceph-rbd-ovs/2fc88b0/ : SUCCESS in 1h 02m 21s\n- openstack-helm-dev-deploy-nfs-ovs http://logs.openstack.org/70/592570/2/check/openstack-helm-dev-deploy-nfs-ovs/89c7bf3/ : SUCCESS in 43m 24s\n- openstack-helm-dev-deploy-ceph-lb http://logs.openstack.org/70/592570/2/check/openstack-helm-dev-deploy-ceph-lb/09bb892/ : SUCCESS in 55m 37s (non-voting)\n- openstack-helm-dev-deploy-nfs-lb http://logs.openstack.org/70/592570/2/check/openstack-helm-dev-deploy-nfs-lb/ae637d5/ : SUCCESS in 46m 48s (non-voting)\n- openstack-helm-dev-deploy-nfs-ldap http://logs.openstack.org/70/592570/2/check/openstack-helm-dev-deploy-nfs-ldap/bbfe3ac/ : SUCCESS in 48m 54s (non-voting)\n- openstack-helm-multinode-ubuntu http://logs.openstack.org/70/592570/2/check/openstack-helm-multinode-ubuntu/1dd67ea/ : SUCCESS in 1h 31m 57s (non-voting)\n- openstack-helm-ironic-ubuntu http://logs.openstack.org/70/592570/2/check/openstack-helm-ironic-ubuntu/726783f/ : SUCCESS in 1h 04m 37s (non-voting)\n- openstack-helm-armada-fullstack-deploy http://logs.openstack.org/70/592570/2/check/openstack-helm-armada-fullstack-deploy/ce752d2/ : SUCCESS in 1h 56m 56s (non-voting)\n- openstack-helm-kolla-deploy-ceph-ovs http://logs.openstack.org/70/592570/2/check/openstack-helm-kolla-deploy-ceph-ovs/dab291b/ : SUCCESS in 59m 35s\n- openstack-helm-ocata-loci-deploy-ceph http://logs.openstack.org/70/592570/2/check/openstack-helm-ocata-loci-deploy-ceph/ddea03e/ : SUCCESS in 58m 15s (non-voting)\n- openstack-helm-ocata-kolla-deploy-ceph http://logs.openstack.org/70/592570/2/check/openstack-helm-ocata-kolla-deploy-ceph/364538a/ : SUCCESS in 59m 27s (non-voting)\n- openstack-helm-pike-loci-deploy-ceph http://logs.openstack.org/70/592570/2/check/openstack-helm-pike-loci-deploy-ceph/71fa08a/ : SUCCESS in 58m 32s (non-voting)\n- openstack-helm-pike-kolla-deploy-ceph http://logs.openstack.org/70/592570/2/check/openstack-helm-pike-kolla-deploy-ceph/c16f6d0/ : SUCCESS in 1h 00m 16s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"dbfde4f612b1980baef11010fbdeb8cb104059a0","author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"date":"2018-08-16 18:40:35.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"434ac78122f942bd0d3c5c41fdd549078972bb5e","author":{"_account_id":28162,"name":"Ruslan Khanbikov","email":"rkhanbikov@gmail.com","username":"rkhanbikov"},"date":"2018-08-16 19:08:34.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"b18ebdedbe2d3111ff0bac621a9ed02dfceac6d7","author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"date":"2018-08-16 21:09:11.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nWould of been nice to indicate what grub parameter to set to disable hugetlb cgroups but thats a minor nit","accounts_in_message":[],"_revision_number":2},{"id":"868def04bc94ec0ef94b9c22b0bdae25b3f2d38b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-16 21:09:23.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"cb43b2e92bc2b4562386e3a0fa2d5851c3ae2bb7","author":{"_account_id":7769,"name":"Pentheus","display_name":"Alan Meadows","email":"alan.meadows@gmail.com","username":"alanmeadows"},"date":"2018-08-16 21:11:36.000000000","message":"Patch Set 2:\n\n... in the warning, I meant (the commit has it)","accounts_in_message":[],"_revision_number":2},{"id":"8ff057fa5c4aa1eefbc600a68d148314e36f89ef","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-16 22:21:17.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/70/592570/2/gate/build-openstack-sphinx-docs/ca632c3/html/ : SUCCESS in 6m 08s\n- openstack-helm-linter http://logs.openstack.org/70/592570/2/gate/openstack-helm-linter/ada5fe4/ : SUCCESS in 2m 35s\n- openstack-helm-dev-deploy-ceph-swift-ovs http://logs.openstack.org/70/592570/2/gate/openstack-helm-dev-deploy-ceph-swift-ovs/5d69dba/ : SUCCESS in 1h 02m 53s\n- openstack-helm-dev-deploy-ceph-radosgw-ovs http://logs.openstack.org/70/592570/2/gate/openstack-helm-dev-deploy-ceph-radosgw-ovs/e5b15d5/ : SUCCESS in 59m 02s\n- openstack-helm-dev-deploy-ceph-rbd-ovs http://logs.openstack.org/70/592570/2/gate/openstack-helm-dev-deploy-ceph-rbd-ovs/fe0d520/ : SUCCESS in 1h 09m 31s\n- openstack-helm-dev-deploy-nfs-ovs http://logs.openstack.org/70/592570/2/gate/openstack-helm-dev-deploy-nfs-ovs/e730509/ : SUCCESS in 46m 23s\n- openstack-helm-kolla-deploy-ceph-ovs http://logs.openstack.org/70/592570/2/gate/openstack-helm-kolla-deploy-ceph-ovs/6a53ad4/ : SUCCESS in 1h 04m 06s","accounts_in_message":[],"_revision_number":2},{"id":"50a3d3df5326ca2b0eaff4ff02a0c3878708b335","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-16 22:21:17.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"98b3984ec7048ce48dce9905485093be28993928","revisions":{"13945bb52285112175d128a992c15305a302ee45":{"kind":"REWORK","_number":1,"created":"2018-08-16 16:13:38.000000000","uploader":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"ref":"refs/changes/70/592570/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/70/592570/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/70/592570/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/70/592570/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/70/592570/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/70/592570/1"}}},"commit":{"parents":[{"commit":"da01b0c09c906a08da4cb11de47970e6f2f56dd9","subject":"Libvirt: gracefully shutdown libvirt process on container stop.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/da01b0c09c906a08da4cb11de47970e6f2f56dd9"}]}],"author":{"name":"Pete Birley","email":"pete@port.direct","date":"2018-08-16 16:11:09.000000000","tz":-300},"committer":{"name":"Pete Birley","email":"pete@port.direct","date":"2018-08-16 16:11:09.000000000","tz":-300},"subject":"Libvirt: Warn if hugetlb cgroup controller is enabled","message":"Libvirt: Warn if hugetlb cgroup controller is enabled\n\nThis PS adds a warning if the hugetlb cgroup controller is enabled\nas it prevents restarts of the libvirt pod without shutting down\nkvm vms. The controller can be disabled by passing\n`cgroup_disable\u003dhugetlb` to the kernel params.\n\nChange-Id: Idd26fd3c19191f3c3e0aeb6fa3efa9a4ec48ee54\nSigned-off-by: Pete Birley \u003cpete@port.direct\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/13945bb52285112175d128a992c15305a302ee45"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/13945bb52285112175d128a992c15305a302ee45"}]},"branch":"refs/heads/master"},"98b3984ec7048ce48dce9905485093be28993928":{"kind":"REWORK","_number":2,"created":"2018-08-16 16:22:00.000000000","uploader":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"ref":"refs/changes/70/592570/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/70/592570/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/70/592570/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/70/592570/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/70/592570/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/70/592570/2"}}},"commit":{"parents":[{"commit":"da01b0c09c906a08da4cb11de47970e6f2f56dd9","subject":"Libvirt: gracefully shutdown libvirt process on container stop.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/da01b0c09c906a08da4cb11de47970e6f2f56dd9"}]}],"author":{"name":"Pete Birley","email":"pete@port.direct","date":"2018-08-16 16:11:09.000000000","tz":-300},"committer":{"name":"Pete Birley","email":"pete@port.direct","date":"2018-08-16 16:21:53.000000000","tz":-300},"subject":"Libvirt: Warn if hugetlb cgroup controller is enabled","message":"Libvirt: Warn if hugetlb cgroup controller is enabled\n\nThis PS adds a warning if the hugetlb cgroup controller is enabled\nas it prevents restarts of the libvirt pod without shutting down\nkvm vms. The controller can be disabled by passing\n`cgroup_disable\u003dhugetlb` to the kernel params.\n\nChange-Id: Idd26fd3c19191f3c3e0aeb6fa3efa9a4ec48ee54\nSigned-off-by: Pete Birley \u003cpete@port.direct\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/98b3984ec7048ce48dce9905485093be28993928"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/98b3984ec7048ce48dce9905485093be28993928"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
