)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"a86b259f3c778390e8080c76ba91ef2088dbdaca","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Neutron TaaS support as L2 Extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is the second draft to enhance neutron in ocata to support Tap-as-a-service (TaaS) as a L2 Extension."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I96951b38dd43ab4904339b778b5726a579c76a4c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_e163ea18","line":9,"range":{"start_line":9,"start_character":70,"end_line":9,"end_character":76},"updated":"2018-09-06 23:47:21.000000000","message":"wrap","commit_id":"0439fad704d247f6e92c51763c2cd7acbfedf1aa"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"6956eb1d96f72c9fc8dcc04f117573a15da32915","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Neutron TaaS support as L2 Extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is the second draft to enhance neutron in ocata to support Tap-as-a-service (TaaS) as a L2 Extension."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I96951b38dd43ab4904339b778b5726a579c76a4c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_2a1e8eba","line":9,"range":{"start_line":9,"start_character":70,"end_line":9,"end_character":76},"in_reply_to":"3f79a3b5_e163ea18","updated":"2018-09-07 14:19:02.000000000","message":"fixed","commit_id":"0439fad704d247f6e92c51763c2cd7acbfedf1aa"}],"neutron/templates/bin/_db-sync.sh.tpl":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"a86b259f3c778390e8080c76ba91ef2088dbdaca","unresolved":false,"context_lines":[{"line_number":21,"context_line":"neutron-db-manage \\"},{"line_number":22,"context_line":"  --config-file /etc/neutron/neutron.conf \\"},{"line_number":23,"context_line":"  --config-file /etc/neutron/plugins/ml2/ml2_conf.ini \\"},{"line_number":24,"context_line":"{{- if .Values.conf.plugins.taas.taas.enabled }}"},{"line_number":25,"context_line":"  --subproject tap-as-a-service \\"},{"line_number":26,"context_line":"{{- end }}"},{"line_number":27,"context_line":"  upgrade head"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3f79a3b5_41789ebf","line":24,"range":{"start_line":24,"start_character":15,"end_line":24,"end_character":45},"updated":"2018-09-06 23:47:21.000000000","message":"this means we have to have conf.plugins.taas.taas.enabled\nmaybe we can check for the existence of conf.plugins.taas outside of this?","commit_id":"0439fad704d247f6e92c51763c2cd7acbfedf1aa"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"6956eb1d96f72c9fc8dcc04f117573a15da32915","unresolved":false,"context_lines":[{"line_number":21,"context_line":"neutron-db-manage \\"},{"line_number":22,"context_line":"  --config-file /etc/neutron/neutron.conf \\"},{"line_number":23,"context_line":"  --config-file /etc/neutron/plugins/ml2/ml2_conf.ini \\"},{"line_number":24,"context_line":"{{- if .Values.conf.plugins.taas.taas.enabled }}"},{"line_number":25,"context_line":"  --subproject tap-as-a-service \\"},{"line_number":26,"context_line":"{{- end }}"},{"line_number":27,"context_line":"  upgrade head"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3f79a3b5_aacdbe30","line":24,"range":{"start_line":24,"start_character":15,"end_line":24,"end_character":45},"in_reply_to":"3f79a3b5_41789ebf","updated":"2018-09-07 14:19:02.000000000","message":"If am checking for enabled because by default it is disabled, can you elaborate on what kind of check you have in mind?","commit_id":"0439fad704d247f6e92c51763c2cd7acbfedf1aa"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"df1b770d772084c925f9cc8b5f13c036f93fc372","unresolved":false,"context_lines":[{"line_number":21,"context_line":"neutron-db-manage \\"},{"line_number":22,"context_line":"  --config-file /etc/neutron/neutron.conf \\"},{"line_number":23,"context_line":"  --config-file /etc/neutron/plugins/ml2/ml2_conf.ini \\"},{"line_number":24,"context_line":"{{- if .Values.conf.plugins.taas.taas.enabled }}"},{"line_number":25,"context_line":"  --subproject tap-as-a-service \\"},{"line_number":26,"context_line":"{{- end }}"},{"line_number":27,"context_line":"  upgrade head"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3f79a3b5_aacb77a1","line":24,"range":{"start_line":24,"start_character":15,"end_line":24,"end_character":45},"in_reply_to":"3f79a3b5_5fd8637d","updated":"2018-09-07 19:39:01.000000000","message":"I agree on have to define conf.plugins.taas.taas.enabled, but it is defined in values.yaml and I am using it in many places, so shouldn\u0027t be a problem, although I am entertaining the idea making it more robust, although I have trouble understanding how to check on the outside.  Ping me and I will see what I can.  Thanks","commit_id":"0439fad704d247f6e92c51763c2cd7acbfedf1aa"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"8b58d969911b024b0b919a8f83bd6c64e7ae635c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"neutron-db-manage \\"},{"line_number":22,"context_line":"  --config-file /etc/neutron/neutron.conf \\"},{"line_number":23,"context_line":"  --config-file /etc/neutron/plugins/ml2/ml2_conf.ini \\"},{"line_number":24,"context_line":"{{- if .Values.conf.plugins.taas.taas.enabled }}"},{"line_number":25,"context_line":"  --subproject tap-as-a-service \\"},{"line_number":26,"context_line":"{{- end }}"},{"line_number":27,"context_line":"  upgrade head"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3f79a3b5_fac05a4c","line":24,"range":{"start_line":24,"start_character":15,"end_line":24,"end_character":45},"in_reply_to":"3f79a3b5_aacb77a1","updated":"2018-09-07 22:19:44.000000000","message":"oh I over-think it... do you mean to change the check to\n\n{{- if .Values.conf.plugins.taas }}\n  --subproject tap-as-a-service \\\n{{- end }}\n\nbut if I am just checking the outside this way, it is not sufficient, as the default is \"enabled: false\", so I don\u0027t really want to add that flag is taas is not enabled.  Thoughts?","commit_id":"0439fad704d247f6e92c51763c2cd7acbfedf1aa"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"1c722badca86d963a8a51d54714a372b98a7d0aa","unresolved":false,"context_lines":[{"line_number":21,"context_line":"neutron-db-manage \\"},{"line_number":22,"context_line":"  --config-file /etc/neutron/neutron.conf \\"},{"line_number":23,"context_line":"  --config-file /etc/neutron/plugins/ml2/ml2_conf.ini \\"},{"line_number":24,"context_line":"{{- if .Values.conf.plugins.taas.taas.enabled }}"},{"line_number":25,"context_line":"  --subproject tap-as-a-service \\"},{"line_number":26,"context_line":"{{- end }}"},{"line_number":27,"context_line":"  upgrade head"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3f79a3b5_5fd8637d","line":24,"range":{"start_line":24,"start_character":15,"end_line":24,"end_character":45},"in_reply_to":"3f79a3b5_aacdbe30","updated":"2018-09-07 18:47:36.000000000","message":"it means we have to define conf.plugins.taas.taas.enabled\nanything less than that will cause template errors\n\nif we could check for conf.plugins.taas \u0027on the outside\u0027 it would be more robust","commit_id":"0439fad704d247f6e92c51763c2cd7acbfedf1aa"}],"neutron/values.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"a86b259f3c778390e8080c76ba91ef2088dbdaca","unresolved":false,"context_lines":[{"line_number":1437,"context_line":"      pods:"},{"line_number":1438,"context_line":"        - ovs_agent"},{"line_number":1439,"context_line":"        - sriov_agent"},{"line_number":1440,"context_line":"      content: |"},{"line_number":1441,"context_line":"        # neutron-rootwrap command filters for nodes on which neutron "},{"line_number":1442,"context_line":"        # tap-as-a-service(taas) is eanbled.  Taas uses this command"},{"line_number":1443,"context_line":"        # as part of its flow control."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_2156c22b","line":1440,"range":{"start_line":1440,"start_character":0,"end_line":1440,"end_character":16},"updated":"2018-09-06 23:47:21.000000000","message":"i don\u0027t mind the inline \u0027ini file\u0027 so much but elsewhere it looks like we\u0027re using yaml and htk has a to_oslo function to generate things\n\nis that the preferred approach?","commit_id":"0439fad704d247f6e92c51763c2cd7acbfedf1aa"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"a86b259f3c778390e8080c76ba91ef2088dbdaca","unresolved":false,"context_lines":[{"line_number":1438,"context_line":"        - ovs_agent"},{"line_number":1439,"context_line":"        - sriov_agent"},{"line_number":1440,"context_line":"      content: |"},{"line_number":1441,"context_line":"        # neutron-rootwrap command filters for nodes on which neutron "},{"line_number":1442,"context_line":"        # tap-as-a-service(taas) is eanbled.  Taas uses this command"},{"line_number":1443,"context_line":"        # as part of its flow control."},{"line_number":1444,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_01506631","line":1441,"range":{"start_line":1441,"start_character":69,"end_line":1441,"end_character":70},"updated":"2018-09-06 23:47:21.000000000","message":"tws","commit_id":"0439fad704d247f6e92c51763c2cd7acbfedf1aa"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"6956eb1d96f72c9fc8dcc04f117573a15da32915","unresolved":false,"context_lines":[{"line_number":1438,"context_line":"        - ovs_agent"},{"line_number":1439,"context_line":"        - sriov_agent"},{"line_number":1440,"context_line":"      content: |"},{"line_number":1441,"context_line":"        # neutron-rootwrap command filters for nodes on which neutron "},{"line_number":1442,"context_line":"        # tap-as-a-service(taas) is eanbled.  Taas uses this command"},{"line_number":1443,"context_line":"        # as part of its flow control."},{"line_number":1444,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_cad03acb","line":1441,"range":{"start_line":1441,"start_character":69,"end_line":1441,"end_character":70},"in_reply_to":"3f79a3b5_01506631","updated":"2018-09-07 14:19:02.000000000","message":"fixed","commit_id":"0439fad704d247f6e92c51763c2cd7acbfedf1aa"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"598ff5dcd0c702bb49a21b43cb28e020a59e152c","unresolved":false,"context_lines":[{"line_number":1435,"context_line":"          # Adjust to suit local requirements."},{"line_number":1436,"context_line":"    taas:"},{"line_number":1437,"context_line":"      pods:"},{"line_number":1438,"context_line":"        - ovs_agent"},{"line_number":1439,"context_line":"        - sriov_agent"},{"line_number":1440,"context_line":"      content: |"},{"line_number":1441,"context_line":"        # neutron-rootwrap command filters for nodes on which neutron"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_f20fe485","line":1438,"range":{"start_line":1438,"start_character":10,"end_line":1438,"end_character":19},"updated":"2018-09-11 19:53:12.000000000","message":"should this also be on the linuxbridge agent?","commit_id":"2f5a1c0c7751ba340d493f3c6f08a23454a7cc38"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"1d8529aca5ed9393b3bd9bca23030ca11c80f9ff","unresolved":false,"context_lines":[{"line_number":1435,"context_line":"          # Adjust to suit local requirements."},{"line_number":1436,"context_line":"    taas:"},{"line_number":1437,"context_line":"      pods:"},{"line_number":1438,"context_line":"        - ovs_agent"},{"line_number":1439,"context_line":"        - sriov_agent"},{"line_number":1440,"context_line":"      content: |"},{"line_number":1441,"context_line":"        # neutron-rootwrap command filters for nodes on which neutron"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_524c98c7","line":1438,"range":{"start_line":1438,"start_character":10,"end_line":1438,"end_character":19},"in_reply_to":"3f79a3b5_f20fe485","updated":"2018-09-11 19:55:45.000000000","message":"Nope... currently taas nic driver is only available for ovs and sriov, and the req is only for sriov and ovs.","commit_id":"2f5a1c0c7751ba340d493f3c6f08a23454a7cc38"}]}