)]}'
{"id":"openstack%2Fopenstack-helm~600853","triplet_id":"openstack%2Fopenstack-helm~master~Ib33181943d90278e1e1e9498bb0d77fd6c029ce5","project":"openstack/openstack-helm","branch":"master","topic":"bug/neutron-null-exclude-devices","hashtags":[],"change_id":"Ib33181943d90278e1e1e9498bb0d77fd6c029ce5","subject":"Change default SRIOV exclude_devices to \"\"","status":"MERGED","created":"2018-09-07 19:56:29.000000000","updated":"2018-09-14 03:23:48.000000000","submitted":"2018-09-14 03:23:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"600853-1536895428264-37aee634","meta_rev_id":"a179ff9d54e62c00e0cb97c36603ef4b7feb835f","_number":600853,"virtual_id_number":600853,"owner":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":2,"date":"2018-09-14 03:23:48.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"all":[{"value":2,"date":"2018-09-14 02:22:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":2,"date":"2018-09-14 02:24:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"all":[{"value":1,"date":"2018-09-14 02:22:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-09-14 02:22:29.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"},{"updated":"2018-09-14 02:24:19.000000000","updated_by":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"reviewer":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"state":"REVIEWER"},{"updated":"2018-09-14 03:23:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"aba5d52563f4ebb8fea7ec3b23b3b788978c2aec","author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"date":"2018-09-07 19:56:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1179109a563bf62b23cf13aacce391acd9ddeb13","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-09-07 22:02:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/53/600853/1/check/openstack-tox-docs/cd98b35/html/ : SUCCESS in 4m 11s\n- openstack-helm-linter http://logs.openstack.org/53/600853/1/check/openstack-helm-linter/5200749/ : SUCCESS in 1m 43s\n- openstack-helm-dev-deploy-ceph-swift-ovs http://logs.openstack.org/53/600853/1/check/openstack-helm-dev-deploy-ceph-swift-ovs/920498e/ : SUCCESS in 1h 03m 48s\n- openstack-helm-dev-deploy-ceph-radosgw-ovs http://logs.openstack.org/53/600853/1/check/openstack-helm-dev-deploy-ceph-radosgw-ovs/d73043f/ : SUCCESS in 1h 02m 44s\n- openstack-helm-dev-deploy-ceph-rbd-ovs http://logs.openstack.org/53/600853/1/check/openstack-helm-dev-deploy-ceph-rbd-ovs/87c887d/ : SUCCESS in 56m 52s\n- openstack-helm-dev-deploy-nfs-ovs http://logs.openstack.org/53/600853/1/check/openstack-helm-dev-deploy-nfs-ovs/2b78a0a/ : SUCCESS in 47m 20s\n- openstack-helm-dev-deploy-ceph-lb http://logs.openstack.org/53/600853/1/check/openstack-helm-dev-deploy-ceph-lb/b10950d/ : SUCCESS in 1h 12m 17s (non-voting)\n- openstack-helm-dev-deploy-nfs-lb http://logs.openstack.org/53/600853/1/check/openstack-helm-dev-deploy-nfs-lb/4d5850a/ : SUCCESS in 47m 03s (non-voting)\n- openstack-helm-dev-deploy-nfs-ldap http://logs.openstack.org/53/600853/1/check/openstack-helm-dev-deploy-nfs-ldap/c780406/ : SUCCESS in 53m 23s (non-voting)\n- openstack-helm-multinode-ubuntu http://logs.openstack.org/53/600853/1/check/openstack-helm-multinode-ubuntu/8c0a9b5/ : SUCCESS in 1h 41m 02s (non-voting)\n- openstack-helm-ironic-ubuntu http://logs.openstack.org/53/600853/1/check/openstack-helm-ironic-ubuntu/e4f954d/ : SUCCESS in 1h 02m 57s (non-voting)\n- openstack-helm-armada-fullstack-deploy http://logs.openstack.org/53/600853/1/check/openstack-helm-armada-fullstack-deploy/422f2cb/ : SUCCESS in 2h 03m 29s (non-voting)\n- openstack-helm-kolla-deploy-ceph-ovs http://logs.openstack.org/53/600853/1/check/openstack-helm-kolla-deploy-ceph-ovs/74e48de/ : SUCCESS in 1h 04m 01s\n- openstack-helm-ocata-loci-deploy-ceph http://logs.openstack.org/53/600853/1/check/openstack-helm-ocata-loci-deploy-ceph/038a04a/ : SUCCESS in 56m 33s (non-voting)\n- openstack-helm-ocata-kolla-deploy-ceph http://logs.openstack.org/53/600853/1/check/openstack-helm-ocata-kolla-deploy-ceph/c76e92e/ : SUCCESS in 53m 21s (non-voting)\n- openstack-helm-pike-loci-deploy-ceph http://logs.openstack.org/53/600853/1/check/openstack-helm-pike-loci-deploy-ceph/34658ed/ : SUCCESS in 1h 04m 20s (non-voting)\n- openstack-helm-pike-kolla-deploy-ceph http://logs.openstack.org/53/600853/1/check/openstack-helm-pike-kolla-deploy-ceph/fe14f02/ : SUCCESS in 1h 05m 04s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c05aeac5e5694f128a8191d21313f66abcea0d87","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2018-09-07 22:05:03.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d781983586013d53e6fc404e7f3a36f5549a00f4","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2018-09-10 03:08:24.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"c06d5407e8673c4e4751738782d0ddf88917e3c6","author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"date":"2018-09-13 21:54:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"27ead773f30e076dcd576fa3e08f51cae934a3c4","author":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"date":"2018-09-13 21:54:47.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8905c9bf59833d7e8ea26c89d8c594cb4d626c08","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-09-13 23:42:14.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/53/600853/2/check/openstack-tox-docs/c8b6d04/html/ : SUCCESS in 4m 37s\n- openstack-helm-linter http://logs.openstack.org/53/600853/2/check/openstack-helm-linter/e5c7633/ : SUCCESS in 2m 36s\n- openstack-helm-dev-deploy-ceph-swift-ovs http://logs.openstack.org/53/600853/2/check/openstack-helm-dev-deploy-ceph-swift-ovs/0115c38/ : SUCCESS in 58m 17s\n- openstack-helm-dev-deploy-ceph-radosgw-ovs http://logs.openstack.org/53/600853/2/check/openstack-helm-dev-deploy-ceph-radosgw-ovs/1a7f410/ : SUCCESS in 1h 00m 52s\n- openstack-helm-dev-deploy-ceph-rbd-ovs http://logs.openstack.org/53/600853/2/check/openstack-helm-dev-deploy-ceph-rbd-ovs/decfbd3/ : SUCCESS in 1h 00m 34s\n- openstack-helm-dev-deploy-nfs-ovs http://logs.openstack.org/53/600853/2/check/openstack-helm-dev-deploy-nfs-ovs/d881d36/ : SUCCESS in 44m 47s\n- openstack-helm-dev-deploy-ceph-lb http://logs.openstack.org/53/600853/2/check/openstack-helm-dev-deploy-ceph-lb/d40b60c/ : SUCCESS in 56m 37s (non-voting)\n- openstack-helm-dev-deploy-nfs-lb http://logs.openstack.org/53/600853/2/check/openstack-helm-dev-deploy-nfs-lb/01e8487/ : SUCCESS in 47m 06s (non-voting)\n- openstack-helm-dev-deploy-nfs-ldap http://logs.openstack.org/53/600853/2/check/openstack-helm-dev-deploy-nfs-ldap/de672e8/ : SUCCESS in 47m 47s (non-voting)\n- openstack-helm-multinode-ubuntu http://logs.openstack.org/53/600853/2/check/openstack-helm-multinode-ubuntu/521dcba/ : SUCCESS in 1h 36m 38s (non-voting)\n- openstack-helm-ironic-ubuntu http://logs.openstack.org/53/600853/2/check/openstack-helm-ironic-ubuntu/fb114b3/ : SUCCESS in 1h 01m 22s (non-voting)\n- openstack-helm-armada-fullstack-deploy http://logs.openstack.org/53/600853/2/check/openstack-helm-armada-fullstack-deploy/0c6083c/ : SUCCESS in 1h 44m 34s (non-voting)\n- openstack-helm-kolla-deploy-ceph-ovs http://logs.openstack.org/53/600853/2/check/openstack-helm-kolla-deploy-ceph-ovs/6a4fdd9/ : SUCCESS in 1h 04m 08s\n- openstack-helm-ocata-loci-deploy-ceph http://logs.openstack.org/53/600853/2/check/openstack-helm-ocata-loci-deploy-ceph/ac15f29/ : SUCCESS in 1h 00m 52s (non-voting)\n- openstack-helm-ocata-kolla-deploy-ceph http://logs.openstack.org/53/600853/2/check/openstack-helm-ocata-kolla-deploy-ceph/e78f3c3/ : SUCCESS in 59m 09s (non-voting)\n- openstack-helm-pike-loci-deploy-ceph http://logs.openstack.org/53/600853/2/check/openstack-helm-pike-loci-deploy-ceph/b09038c/ : SUCCESS in 1h 03m 55s (non-voting)\n- openstack-helm-pike-kolla-deploy-ceph http://logs.openstack.org/53/600853/2/check/openstack-helm-pike-kolla-deploy-ceph/178a8cb/ : SUCCESS in 1h 03m 24s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"d87eb42c4ff00ef1145120787676672719403e7e","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2018-09-14 02:22:29.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"4485009f43a958c92cfd2c83fec4d61efde0662c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-09-14 02:22:40.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"700d2293669a2538915083c14bdd4834aab4249d","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2018-09-14 02:24:19.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"5ff92029c41b6bb44d0d6c1c78e62ba6d72dc92d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-09-14 03:23:48.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"0006f6e6de3176d1f688432c3385bed5e341c403","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-09-14 03:23:48.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/53/600853/2/gate/openstack-tox-docs/c58a3f8/html/ : SUCCESS in 3m 43s\n- openstack-helm-linter http://logs.openstack.org/53/600853/2/gate/openstack-helm-linter/1011e26/ : SUCCESS in 1m 24s\n- openstack-helm-dev-deploy-ceph-swift-ovs http://logs.openstack.org/53/600853/2/gate/openstack-helm-dev-deploy-ceph-swift-ovs/a56b36b/ : SUCCESS in 1h 00m 15s\n- openstack-helm-dev-deploy-ceph-radosgw-ovs http://logs.openstack.org/53/600853/2/gate/openstack-helm-dev-deploy-ceph-radosgw-ovs/42ff711/ : SUCCESS in 57m 10s\n- openstack-helm-dev-deploy-ceph-rbd-ovs http://logs.openstack.org/53/600853/2/gate/openstack-helm-dev-deploy-ceph-rbd-ovs/a7368d4/ : SUCCESS in 57m 30s\n- openstack-helm-dev-deploy-nfs-ovs http://logs.openstack.org/53/600853/2/gate/openstack-helm-dev-deploy-nfs-ovs/c3e7861/ : SUCCESS in 49m 17s\n- openstack-helm-kolla-deploy-ceph-ovs http://logs.openstack.org/53/600853/2/gate/openstack-helm-kolla-deploy-ceph-ovs/d4e242b/ : SUCCESS in 59m 46s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"7df16a8a102660c185580268686babb8acd48477","revisions":{"442c76003ef3bcb2c0bc8a7943fca400d2ac7a15":{"kind":"REWORK","_number":1,"created":"2018-09-07 19:56:29.000000000","uploader":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"ref":"refs/changes/53/600853/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/53/600853/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/600853/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/600853/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/600853/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/53/600853/1"}}},"commit":{"parents":[{"commit":"8b3a4a6b3e6c6ee3fea9d251725252105c2d50bc","subject":"fix the link in README.rst","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/8b3a4a6b3e6c6ee3fea9d251725252105c2d50bc"}]}],"author":{"name":"Matt McEuen","email":"matt.mceuen@att.com","date":"2018-09-07 19:55:11.000000000","tz":-300},"committer":{"name":"Matt McEuen","email":"matt.mceuen@att.com","date":"2018-09-07 19:55:11.000000000","tz":-300},"subject":"Change default SRIOV exclude_devices to \"\"","message":"Change default SRIOV exclude_devices to \"\"\n\nThe current default for exclude_devices is null, which will\nrender suboptimally when using secret-based configmaps.\nThis changes to \"\" which will render correctly when SRIOV\nis enabled.\n\nChange-Id: Ib33181943d90278e1e1e9498bb0d77fd6c029ce5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/442c76003ef3bcb2c0bc8a7943fca400d2ac7a15"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/442c76003ef3bcb2c0bc8a7943fca400d2ac7a15"}]},"branch":"refs/heads/master"},"7df16a8a102660c185580268686babb8acd48477":{"kind":"REWORK","_number":2,"created":"2018-09-13 21:54:00.000000000","uploader":{"_account_id":22477,"name":"Matt McEuen","email":"matt.mceuen@att.com","username":"mattmceuen"},"ref":"refs/changes/53/600853/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/53/600853/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/600853/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/600853/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/53/600853/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/53/600853/2"}}},"commit":{"parents":[{"commit":"8b3a4a6b3e6c6ee3fea9d251725252105c2d50bc","subject":"fix the link in README.rst","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/8b3a4a6b3e6c6ee3fea9d251725252105c2d50bc"}]}],"author":{"name":"Matt McEuen","email":"matt.mceuen@att.com","date":"2018-09-07 19:55:11.000000000","tz":-300},"committer":{"name":"Matt McEuen","email":"matt.mceuen@att.com","date":"2018-09-13 21:52:36.000000000","tz":-300},"subject":"Change default SRIOV exclude_devices to \"\"","message":"Change default SRIOV exclude_devices to \"\"\n\nThe current default for exclude_devices is null, which will\nrender suboptimally when using secret-based configmaps.\nThis changes it to \"\" (empty string) which will render correctly\nwhen SRIOV is enabled.\n\nChange-Id: Ib33181943d90278e1e1e9498bb0d77fd6c029ce5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/7df16a8a102660c185580268686babb8acd48477"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/7df16a8a102660c185580268686babb8acd48477"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}