)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"c3da3ecf4795e98d2eb2eab6b376c8a5fd18ba40","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch set adds in apparmor security annotations to Deployment"},{"line_number":10,"context_line":"and Daemonset manifests for the following components: keystone,"},{"line_number":11,"context_line":"heat, cinder, glance, and horizon. Neutron and nova will be covered"},{"line_number":12,"context_line":"in a different commit due to increased complexity."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I905cb38caf0c3bcf2d55d59f13b4efb7c61a4331"},{"line_number":15,"context_line":"Co-Authored-By: Cliff Parsons \u003ccliff.parsons@att.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":78,"id":"bfdaf3ff_ddef4885","line":12,"range":{"start_line":11,"start_character":35,"end_line":12,"end_character":50},"updated":"2019-01-14 07:50:52.000000000","message":"don\u0027t really need the comment on what comes elsewhere, once merged git log will show this and other other PS","commit_id":"a3738277c9e0e637aa0b98e7bdd861d073b9f8c1"}],"cinder/templates/deployment-api.yaml":[{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"f1b9a524acb985080838cbdeb48741373e6f4abc","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      labels:"},{"line_number":43,"context_line":"{{ tuple $envAll \"cinder\" \"api\" | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":44,"context_line":"      annotations:"},{"line_number":45,"context_line":"{{- $_ :\u003d set $envAll.Values \"__containerList\" (list \"cinder-api\" \"init\") -}}"},{"line_number":46,"context_line":"{{- if eq ( split \"://\" .Values.conf.cinder.coordination.backend_url )._0 \"file\" }}"},{"line_number":47,"context_line":"{{- $_ :\u003d set $envAll.Values \"__containerList\" (append $envAll.Values.__containerList \"ceph-coordination-volume-perms\") -}}"},{"line_number":48,"context_line":"{{- end }}"},{"line_number":49,"context_line":"{{- dict \"envAll\" $envAll \"podName\" \"cinder-api\" \"containerNames\" $envAll.Values.__containerList | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 8 }}"},{"line_number":50,"context_line":"        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":51,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":52,"context_line":"    spec:"}],"source_content_type":"text/x-yaml","patch_set":47,"id":"3f79a3b5_3385b053","line":49,"range":{"start_line":45,"start_character":0,"end_line":49,"end_character":191},"updated":"2018-10-26 20:09:07.000000000","message":"Is it possible to use https://github.com/Masterminds/sprig/blob/master/docs/dicts.md#merge here instead of mutating values.yaml? I feel like the less mutations to the \"global state\" the better.\n\nSame for all occurrences of this in this changeset.","commit_id":"c40265bac63f9b78836dde68ce4ef6f4588512c5"}],"cinder/templates/deployment-backup.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"bf5c097fbc88c4fab87f80cd0d18c123cf51fd79","unresolved":false,"context_lines":[{"line_number":49,"context_line":"{{- if include \"cinder.utils.is_ceph_volume_configured\" $envAll }}"},{"line_number":50,"context_line":"{{- $_ :\u003d set $envAll.Values \"__containerList\" (append $envAll.Values.__containerList \"ceph-keyring-placement\") -}}"},{"line_number":51,"context_line":"{{- end }}"},{"line_number":52,"context_line":"{{- if eq .Values.conf.cinder.DEFAULT.backup_driver \"cinder.backup.drivers.posix\" }}"},{"line_number":53,"context_line":"{{- $_ :\u003d set $envAll.Values \"__containerList\" (append $envAll.Values.__containerList \"ceph-backup-volume-perms\") -}}"},{"line_number":54,"context_line":"{{- end }}"},{"line_number":55,"context_line":"{{- if eq ( split \"://\" .Values.conf.cinder.coordination.backend_url )._0 \"file\" }}"},{"line_number":56,"context_line":"{{- $_ :\u003d set $envAll.Values \"__containerList\" (append $envAll.Values.__containerList \"ceph-coordination-volume-perms\") -}}"},{"line_number":57,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":45,"id":"3f79a3b5_8881d94f","line":54,"range":{"start_line":52,"start_character":0,"end_line":54,"end_character":10},"updated":"2018-10-16 16:13:44.000000000","message":"should this not be exclusive with l46-47 so at a minimum we can contain in an elif?","commit_id":"e400f8b2ec6fdbf4118d745c0ef41e8e94310297"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"5032c6e9edfeb9e285b1a137b861487ea73de985","unresolved":false,"context_lines":[{"line_number":49,"context_line":"{{- if include \"cinder.utils.is_ceph_volume_configured\" $envAll }}"},{"line_number":50,"context_line":"{{- $_ :\u003d set $envAll.Values \"__containerList\" (append $envAll.Values.__containerList \"ceph-keyring-placement\") -}}"},{"line_number":51,"context_line":"{{- end }}"},{"line_number":52,"context_line":"{{- if eq .Values.conf.cinder.DEFAULT.backup_driver \"cinder.backup.drivers.posix\" }}"},{"line_number":53,"context_line":"{{- $_ :\u003d set $envAll.Values \"__containerList\" (append $envAll.Values.__containerList \"ceph-backup-volume-perms\") -}}"},{"line_number":54,"context_line":"{{- end }}"},{"line_number":55,"context_line":"{{- if eq ( split \"://\" .Values.conf.cinder.coordination.backend_url )._0 \"file\" }}"},{"line_number":56,"context_line":"{{- $_ :\u003d set $envAll.Values \"__containerList\" (append $envAll.Values.__containerList \"ceph-coordination-volume-perms\") -}}"},{"line_number":57,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":45,"id":"3f79a3b5_170ba021","line":54,"range":{"start_line":52,"start_character":0,"end_line":54,"end_character":10},"in_reply_to":"3f79a3b5_8881d94f","updated":"2018-10-16 19:26:00.000000000","message":"The reason I coded it this way is because the creation of the containers was done in the same manner (no signs of exclusivity between the posix and ceph drivers). As far as I know, Cinder may need both containers at once, as it does have multiple backend storage capability.","commit_id":"e400f8b2ec6fdbf4118d745c0ef41e8e94310297"}],"cinder/values.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"df4bb09627d717235094c7a0fd7f51f04bec1fdf","unresolved":false,"context_lines":[{"line_number":248,"context_line":"          cpu: \"2000m\""},{"line_number":249,"context_line":"  mandatory_access_control:"},{"line_number":250,"context_line":"    type: apparmor"},{"line_number":251,"context_line":"    cinder-api:"},{"line_number":252,"context_line":"      cinder-api: localhost/docker-default"},{"line_number":253,"context_line":"      ceph-coordination-volume-perms: localhost/docker-default"},{"line_number":254,"context_line":"      init: localhost/docker-default"},{"line_number":255,"context_line":"    cinder-backup:"},{"line_number":256,"context_line":"      cinder-backup: localhost/docker-default"},{"line_number":257,"context_line":"      ceph-coordination-volume-perms: localhost/docker-default"},{"line_number":258,"context_line":"      ceph-backup-keyring-placement: localhost/docker-default"},{"line_number":259,"context_line":"      ceph-keyring-placement: localhost/docker-default"},{"line_number":260,"context_line":"      ceph-backup-volume-perms: localhost/docker-default"},{"line_number":261,"context_line":"      init: localhost/docker-default"},{"line_number":262,"context_line":"    cinder-scheduler:"},{"line_number":263,"context_line":"      cinder-scheduler: localhost/docker-default"},{"line_number":264,"context_line":"      ceph-coordination-volume-perms: localhost/docker-default"},{"line_number":265,"context_line":"      init: localhost/docker-default"},{"line_number":266,"context_line":"    cinder-volume:"},{"line_number":267,"context_line":"      cinder-volume: localhost/docker-default"},{"line_number":268,"context_line":"      ceph-keyring-placement: localhost/docker-default"},{"line_number":269,"context_line":"      ceph-coordination-volume-perms: localhost/docker-default"},{"line_number":270,"context_line":"      init: localhost/docker-default"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"bootstrap:"},{"line_number":273,"context_line":"  enabled: true"}],"source_content_type":"text/x-yaml","patch_set":78,"id":"9fdfeff1_c03695b5","line":270,"range":{"start_line":251,"start_character":0,"end_line":270,"end_character":36},"updated":"2019-01-21 15:18:20.000000000","message":"if these were placed under an \u0027apparmour\u0027 key it would open the door to adding selinux in a much simpler manner, where they could be toggled based on the value specified in line 250 - we should also add \u0027null\u0027 as an option here.","commit_id":"a3738277c9e0e637aa0b98e7bdd861d073b9f8c1"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"1cf47d46f94fe8df18f96a7c9d97cd05908295dd","unresolved":false,"context_lines":[{"line_number":248,"context_line":"          cpu: \"2000m\""},{"line_number":249,"context_line":"  mandatory_access_control:"},{"line_number":250,"context_line":"    type: apparmor"},{"line_number":251,"context_line":"    cinder-api:"},{"line_number":252,"context_line":"      cinder-api: localhost/docker-default"},{"line_number":253,"context_line":"      ceph-coordination-volume-perms: localhost/docker-default"},{"line_number":254,"context_line":"      init: localhost/docker-default"},{"line_number":255,"context_line":"    cinder-backup:"},{"line_number":256,"context_line":"      cinder-backup: localhost/docker-default"},{"line_number":257,"context_line":"      ceph-coordination-volume-perms: localhost/docker-default"},{"line_number":258,"context_line":"      ceph-backup-keyring-placement: localhost/docker-default"},{"line_number":259,"context_line":"      ceph-keyring-placement: localhost/docker-default"},{"line_number":260,"context_line":"      ceph-backup-volume-perms: localhost/docker-default"},{"line_number":261,"context_line":"      init: localhost/docker-default"},{"line_number":262,"context_line":"    cinder-scheduler:"},{"line_number":263,"context_line":"      cinder-scheduler: localhost/docker-default"},{"line_number":264,"context_line":"      ceph-coordination-volume-perms: localhost/docker-default"},{"line_number":265,"context_line":"      init: localhost/docker-default"},{"line_number":266,"context_line":"    cinder-volume:"},{"line_number":267,"context_line":"      cinder-volume: localhost/docker-default"},{"line_number":268,"context_line":"      ceph-keyring-placement: localhost/docker-default"},{"line_number":269,"context_line":"      ceph-coordination-volume-perms: localhost/docker-default"},{"line_number":270,"context_line":"      init: localhost/docker-default"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"bootstrap:"},{"line_number":273,"context_line":"  enabled: true"}],"source_content_type":"text/x-yaml","patch_set":78,"id":"9fdfeff1_1ed71af0","line":270,"range":{"start_line":251,"start_character":0,"end_line":270,"end_character":36},"in_reply_to":"9fdfeff1_c03695b5","updated":"2019-01-21 17:06:44.000000000","message":"Yikes..that\u0027s a good suggestion, but at this point that will require a change to the HTK function which reads these lines, and then would also require multiple repo updates, since there have already been several other commmits (merged) that have used the apparmor HTK annotation function.","commit_id":"a3738277c9e0e637aa0b98e7bdd861d073b9f8c1"}],"nova/templates/daemonset-compute.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"8ef9ed3af884b3b3f70e2f26cbaf2b5fd2f68108","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      labels:"},{"line_number":44,"context_line":"{{ tuple $envAll .Chart.Name $daemonset | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":45,"context_line":"      annotations:"},{"line_number":46,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"nova-compute-default\" \"containerNames\" (list \"nova-compute-default\" \"nova-compute-init\" \"init\") | include \"helm-toolkit.snippets.kubernetes_apparmor_annotation\" | indent 8 }}"},{"line_number":47,"context_line":"{{- if .Values.conf.ceph.enabled }}"},{"line_number":48,"context_line":"{{- if empty .Values.conf.ceph.cinder.keyring }}"},{"line_number":49,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"nova-compute-default\" \"containerNames\" (list \"ceph-admin-keyring-placement\") | include \"helm-toolkit.snippets.kubernetes_apparmor_annotation\" | indent 8 }}"},{"line_number":50,"context_line":"{{ end }}"},{"line_number":51,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"nova-compute-default\" \"containerNames\" (list \"ceph-keyring-placement\") | include \"helm-toolkit.snippets.kubernetes_apparmor_annotation\" | indent 8 }}"},{"line_number":52,"context_line":"{{ end }}"},{"line_number":53,"context_line":"{{- if eq .Values.console.console_kind \"novnc\"}}"},{"line_number":54,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"nova-compute-default\" \"containerNames\" (list \"nova-compute-vnc-init\") | include \"helm-toolkit.snippets.kubernetes_apparmor_annotation\" | indent 8 }}"},{"line_number":55,"context_line":"{{ end }}"},{"line_number":56,"context_line":"{{- if eq .Values.console.console_kind \"spice\"}}"},{"line_number":57,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"nova-compute-default\" \"containerNames\" (list \"nova-compute-spice-init\") | include \"helm-toolkit.snippets.kubernetes_apparmor_annotation\" | indent 8 }}"},{"line_number":58,"context_line":"{{ end }}"},{"line_number":59,"context_line":"        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":60,"context_line":"    spec:"},{"line_number":61,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"3f79a3b5_942fa488","line":58,"range":{"start_line":46,"start_character":0,"end_line":58,"end_character":9},"updated":"2018-10-04 14:52:22.000000000","message":"can the dict generation be wrapped in a conditional: whihc would ideally add to a common base, and then the function called. As it stands this, and cinder etc are very hard to read.","commit_id":"c1974fbeb4b68978bd05b43c573f385a56910522"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"eb540556aad3e3176f1b38c1a3440777a670fc56","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      labels:"},{"line_number":44,"context_line":"{{ tuple $envAll .Chart.Name $daemonset | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":45,"context_line":"      annotations:"},{"line_number":46,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"nova-compute-default\" \"containerNames\" (list \"nova-compute-default\" \"nova-compute-init\" \"init\") | include \"helm-toolkit.snippets.kubernetes_apparmor_annotation\" | indent 8 }}"},{"line_number":47,"context_line":"{{- if .Values.conf.ceph.enabled }}"},{"line_number":48,"context_line":"{{- if empty .Values.conf.ceph.cinder.keyring }}"},{"line_number":49,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"nova-compute-default\" \"containerNames\" (list \"ceph-admin-keyring-placement\") | include \"helm-toolkit.snippets.kubernetes_apparmor_annotation\" | indent 8 }}"},{"line_number":50,"context_line":"{{ end }}"},{"line_number":51,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"nova-compute-default\" \"containerNames\" (list \"ceph-keyring-placement\") | include \"helm-toolkit.snippets.kubernetes_apparmor_annotation\" | indent 8 }}"},{"line_number":52,"context_line":"{{ end }}"},{"line_number":53,"context_line":"{{- if eq .Values.console.console_kind \"novnc\"}}"},{"line_number":54,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"nova-compute-default\" \"containerNames\" (list \"nova-compute-vnc-init\") | include \"helm-toolkit.snippets.kubernetes_apparmor_annotation\" | indent 8 }}"},{"line_number":55,"context_line":"{{ end }}"},{"line_number":56,"context_line":"{{- if eq .Values.console.console_kind \"spice\"}}"},{"line_number":57,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"nova-compute-default\" \"containerNames\" (list \"nova-compute-spice-init\") | include \"helm-toolkit.snippets.kubernetes_apparmor_annotation\" | indent 8 }}"},{"line_number":58,"context_line":"{{ end }}"},{"line_number":59,"context_line":"        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":60,"context_line":"    spec:"},{"line_number":61,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"3f79a3b5_6e84730f","line":58,"range":{"start_line":46,"start_character":0,"end_line":58,"end_character":9},"in_reply_to":"3f79a3b5_031fd8b8","updated":"2018-10-04 19:27:25.000000000","message":"Looking at this, I think it might be easier to just build out the containerNames list and call the annotation once.  See if it is any better (though it is gotpl), if not we can go back to your idea of using a base dictionary and set.","commit_id":"c1974fbeb4b68978bd05b43c573f385a56910522"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"761edc75e2303df7ec22b85709b1c81c3ed05b72","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      labels:"},{"line_number":44,"context_line":"{{ tuple $envAll .Chart.Name $daemonset | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":45,"context_line":"      annotations:"},{"line_number":46,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"nova-compute-default\" \"containerNames\" (list \"nova-compute-default\" \"nova-compute-init\" \"init\") | include \"helm-toolkit.snippets.kubernetes_apparmor_annotation\" | indent 8 }}"},{"line_number":47,"context_line":"{{- if .Values.conf.ceph.enabled }}"},{"line_number":48,"context_line":"{{- if empty .Values.conf.ceph.cinder.keyring }}"},{"line_number":49,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"nova-compute-default\" \"containerNames\" (list \"ceph-admin-keyring-placement\") | include \"helm-toolkit.snippets.kubernetes_apparmor_annotation\" | indent 8 }}"},{"line_number":50,"context_line":"{{ end }}"},{"line_number":51,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"nova-compute-default\" \"containerNames\" (list \"ceph-keyring-placement\") | include \"helm-toolkit.snippets.kubernetes_apparmor_annotation\" | indent 8 }}"},{"line_number":52,"context_line":"{{ end }}"},{"line_number":53,"context_line":"{{- if eq .Values.console.console_kind \"novnc\"}}"},{"line_number":54,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"nova-compute-default\" \"containerNames\" (list \"nova-compute-vnc-init\") | include \"helm-toolkit.snippets.kubernetes_apparmor_annotation\" | indent 8 }}"},{"line_number":55,"context_line":"{{ end }}"},{"line_number":56,"context_line":"{{- if eq .Values.console.console_kind \"spice\"}}"},{"line_number":57,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"nova-compute-default\" \"containerNames\" (list \"nova-compute-spice-init\") | include \"helm-toolkit.snippets.kubernetes_apparmor_annotation\" | indent 8 }}"},{"line_number":58,"context_line":"{{ end }}"},{"line_number":59,"context_line":"        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":60,"context_line":"    spec:"},{"line_number":61,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"3f79a3b5_974ec637","line":58,"range":{"start_line":46,"start_character":0,"end_line":58,"end_character":9},"in_reply_to":"3f79a3b5_942fa488","updated":"2018-10-04 15:38:46.000000000","message":"I understand it\u0027s not easy to read, but I\u0027m not entirely sure what you are asking. The \"which would ideally add to a common base\" part is the part I\u0027m having trouble with. Can you elaborate?","commit_id":"c1974fbeb4b68978bd05b43c573f385a56910522"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"5335b2c2014ed4dfbe863c07b3c4ccb8d6ff5c6b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      labels:"},{"line_number":44,"context_line":"{{ tuple $envAll .Chart.Name $daemonset | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":45,"context_line":"      annotations:"},{"line_number":46,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"nova-compute-default\" \"containerNames\" (list \"nova-compute-default\" \"nova-compute-init\" \"init\") | include \"helm-toolkit.snippets.kubernetes_apparmor_annotation\" | indent 8 }}"},{"line_number":47,"context_line":"{{- if .Values.conf.ceph.enabled }}"},{"line_number":48,"context_line":"{{- if empty .Values.conf.ceph.cinder.keyring }}"},{"line_number":49,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"nova-compute-default\" \"containerNames\" (list \"ceph-admin-keyring-placement\") | include \"helm-toolkit.snippets.kubernetes_apparmor_annotation\" | indent 8 }}"},{"line_number":50,"context_line":"{{ end }}"},{"line_number":51,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"nova-compute-default\" \"containerNames\" (list \"ceph-keyring-placement\") | include \"helm-toolkit.snippets.kubernetes_apparmor_annotation\" | indent 8 }}"},{"line_number":52,"context_line":"{{ end }}"},{"line_number":53,"context_line":"{{- if eq .Values.console.console_kind \"novnc\"}}"},{"line_number":54,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"nova-compute-default\" \"containerNames\" (list \"nova-compute-vnc-init\") | include \"helm-toolkit.snippets.kubernetes_apparmor_annotation\" | indent 8 }}"},{"line_number":55,"context_line":"{{ end }}"},{"line_number":56,"context_line":"{{- if eq .Values.console.console_kind \"spice\"}}"},{"line_number":57,"context_line":"{{ dict \"envAll\" $envAll \"podName\" \"nova-compute-default\" \"containerNames\" (list \"nova-compute-spice-init\") | include \"helm-toolkit.snippets.kubernetes_apparmor_annotation\" | indent 8 }}"},{"line_number":58,"context_line":"{{ end }}"},{"line_number":59,"context_line":"        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":60,"context_line":"    spec:"},{"line_number":61,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"3f79a3b5_031fd8b8","line":58,"range":{"start_line":46,"start_character":0,"end_line":58,"end_character":9},"in_reply_to":"3f79a3b5_942fa488","updated":"2018-10-04 18:53:58.000000000","message":"will take a stab at making this a bit more readable.","commit_id":"c1974fbeb4b68978bd05b43c573f385a56910522"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"bcba30b04e637cb4c1271813e25ee4d2c858c6a1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      labels:"},{"line_number":44,"context_line":"{{ tuple $envAll .Chart.Name $daemonset | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":45,"context_line":"      annotations:"},{"line_number":46,"context_line":"{{- $_ :\u003d set $envAll.Values \"__containerList\" (list \"nova-compute-default\" \"nova-compute-init\" \"init\") -}}"},{"line_number":47,"context_line":"{{- if .Values.conf.ceph.enabled }}"},{"line_number":48,"context_line":"{{- if empty .Values.conf.ceph.cinder.keyring }}"},{"line_number":49,"context_line":"{{- $__containerList :\u003d append $envAll.Values.__containerList \"ceph-admin-keyring-placement\" -}}"},{"line_number":50,"context_line":"{{- $_ :\u003d set $envAll.Values \"__containerList\" $__containerList -}}"},{"line_number":51,"context_line":"{{ end }}"},{"line_number":52,"context_line":"{{- $__containerList :\u003d append $envAll.Values.__containerList \"ceph-keyring-placement\" -}}"},{"line_number":53,"context_line":"{{- $_ :\u003d set $envAll.Values \"__containerList\" $__containerList -}}"},{"line_number":54,"context_line":"{{ end }}"},{"line_number":55,"context_line":"{{- if eq .Values.console.console_kind \"novnc\" }}"},{"line_number":56,"context_line":"{{- $__containerList :\u003d append $envAll.Values.__containerList \"nova-compute-vnc-init\" -}}"},{"line_number":57,"context_line":"{{- $_ :\u003d set $envAll.Values \"__containerList\" $__containerList -}}"},{"line_number":58,"context_line":"{{ end }}"},{"line_number":59,"context_line":"{{- if eq .Values.console.console_kind \"spice\" }}"},{"line_number":60,"context_line":"{{- $__containerList :\u003d append $envAll.Values.__containerList \"nova-compute-spice-init\" -}}"},{"line_number":61,"context_line":"{{- $_ :\u003d set $envAll.Values \"__containerList\" $__containerList -}}"},{"line_number":62,"context_line":"{{ end }}"},{"line_number":63,"context_line":"{{- $apparmor :\u003d dict \"envAll\" $envAll \"podName\" \"nova-compute-default\" }}"},{"line_number":64,"context_line":"{{- $_ :\u003d set $apparmor \"containerNames\" $envAll.Values.__containerList }}"},{"line_number":65,"context_line":"{{ $apparmor | include \"helm-toolkit.snippets.kubernetes_apparmor_annotation\" | indent 8 }}"},{"line_number":66,"context_line":"        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":67,"context_line":"    spec:"},{"line_number":68,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":69,"context_line":"      nodeSelector:"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"3f79a3b5_eecac345","line":66,"range":{"start_line":46,"start_character":0,"end_line":66,"end_character":1},"updated":"2018-10-04 19:34:14.000000000","message":"actually this looks kind of confusing too.  Will try something to see if gotpl will work","commit_id":"82197851b5be1653149185ac5461213f43849706"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"f3745d201e75c5e2e145ea38dcb627be9dddbafa","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      labels:"},{"line_number":44,"context_line":"{{ tuple $envAll .Chart.Name $daemonset | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":45,"context_line":"      annotations:"},{"line_number":46,"context_line":"{{- $_ :\u003d set $envAll.Values \"__containerList\" (list \"nova-compute-default\" \"nova-compute-init\" \"init\") -}}"},{"line_number":47,"context_line":"{{- if .Values.conf.ceph.enabled }}"},{"line_number":48,"context_line":"{{- if empty .Values.conf.ceph.cinder.keyring }}"},{"line_number":49,"context_line":"{{- $_ :\u003d set $envAll.Values \"__containerList\" (append $envAll.Values.__containerList \"ceph-admin-keyring-placement\") -}}"},{"line_number":50,"context_line":"{{- end }}"},{"line_number":51,"context_line":"{{- $_ :\u003d set $envAll.Values \"__containerList\" (append $envAll.Values.__containerList \"ceph-keyring-placement\") -}}"},{"line_number":52,"context_line":"{{- end }}"},{"line_number":53,"context_line":"{{- if eq .Values.console.console_kind \"novnc\"}}"},{"line_number":54,"context_line":"{{- $_ :\u003d set $envAll.Values \"__containerList\" (append $envAll.Values.__containerList \"nova-compute-vnc-init\") -}}"},{"line_number":55,"context_line":"{{- end }}"},{"line_number":56,"context_line":"{{- if eq .Values.console.console_kind \"spice\"}}"},{"line_number":57,"context_line":"{{- $_ :\u003d set $envAll.Values \"__containerList\" (append $envAll.Values.__containerList \"nova-compute-spice-init\") -}}"},{"line_number":58,"context_line":"{{- end }}"},{"line_number":59,"context_line":"{{- dict \"envAll\" $envAll \"podName\" \"nova-compute-default\" \"containerNames\" $envAll.Values.__containerList | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 8 }}"},{"line_number":60,"context_line":"        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":61,"context_line":"    spec:"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"3f79a3b5_35f9d84e","line":58,"range":{"start_line":46,"start_character":0,"end_line":58,"end_character":10},"updated":"2018-10-31 07:18:18.000000000","message":"Perhaps we should clean this up, it is kind if unwieldy looking.","commit_id":"e4e2e25a902014bf0d33eeb12839fb52e5addd9d"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"ade7d9d61deb7acc45c621babe5e1b1314713f35","unresolved":false,"context_lines":[{"line_number":43,"context_line":"      labels:"},{"line_number":44,"context_line":"{{ tuple $envAll .Chart.Name $daemonset | include \"helm-toolkit.snippets.kubernetes_metadata_labels\" | indent 8 }}"},{"line_number":45,"context_line":"      annotations:"},{"line_number":46,"context_line":"{{- $_ :\u003d set $envAll.Values \"__containerList\" (list \"nova-compute-default\" \"nova-compute-init\" \"init\") -}}"},{"line_number":47,"context_line":"{{- if .Values.conf.ceph.enabled }}"},{"line_number":48,"context_line":"{{- if empty .Values.conf.ceph.cinder.keyring }}"},{"line_number":49,"context_line":"{{- $_ :\u003d set $envAll.Values \"__containerList\" (append $envAll.Values.__containerList \"ceph-admin-keyring-placement\") -}}"},{"line_number":50,"context_line":"{{- end }}"},{"line_number":51,"context_line":"{{- $_ :\u003d set $envAll.Values \"__containerList\" (append $envAll.Values.__containerList \"ceph-keyring-placement\") -}}"},{"line_number":52,"context_line":"{{- end }}"},{"line_number":53,"context_line":"{{- if eq .Values.console.console_kind \"novnc\"}}"},{"line_number":54,"context_line":"{{- $_ :\u003d set $envAll.Values \"__containerList\" (append $envAll.Values.__containerList \"nova-compute-vnc-init\") -}}"},{"line_number":55,"context_line":"{{- end }}"},{"line_number":56,"context_line":"{{- if eq .Values.console.console_kind \"spice\"}}"},{"line_number":57,"context_line":"{{- $_ :\u003d set $envAll.Values \"__containerList\" (append $envAll.Values.__containerList \"nova-compute-spice-init\") -}}"},{"line_number":58,"context_line":"{{- end }}"},{"line_number":59,"context_line":"{{- dict \"envAll\" $envAll \"podName\" \"nova-compute-default\" \"containerNames\" $envAll.Values.__containerList | include \"helm-toolkit.snippets.kubernetes_mandatory_access_control_annotation\" | indent 8 }}"},{"line_number":60,"context_line":"        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":61,"context_line":"    spec:"}],"source_content_type":"text/x-yaml","patch_set":57,"id":"3f79a3b5_d703c174","line":58,"range":{"start_line":46,"start_character":0,"end_line":58,"end_character":10},"in_reply_to":"3f79a3b5_35f9d84e","updated":"2018-10-31 14:21:53.000000000","message":"I\u0027ve spent quite a while trying to optimize this conditional container stuff. Do you have any suggestions?","commit_id":"e4e2e25a902014bf0d33eeb12839fb52e5addd9d"}],"tools/deployment/common/confirm-apparmor-profiles.sh":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"0f40c160d84ca91f8043c4b8bd2474ba4d28b519","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  exit 1"},{"line_number":65,"context_line":"fi"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# Make a list of pods (only non-job pods) for the components under test."},{"line_number":68,"context_line":"cinder_pods\u003d`kubectl get pods -n openstack --show-labels\u003dtrue | \\"},{"line_number":69,"context_line":"             grep pod-template | grep cinder |  awk -F\u0027 \u0027 \u0027{print $1}\u0027`"},{"line_number":70,"context_line":"horizon_pods\u003d`kubectl get pods -n openstack --show-labels\u003dtrue | \\"},{"line_number":71,"context_line":"              grep pod-template | grep horizon |  awk -F\u0027 \u0027 \u0027{print $1}\u0027`"},{"line_number":72,"context_line":"keystone_pods\u003d`kubectl get pods -n openstack --show-labels\u003dtrue | \\"},{"line_number":73,"context_line":"               grep pod-template | grep keystone |  awk -F\u0027 \u0027 \u0027{print $1}\u0027`"},{"line_number":74,"context_line":"heat_pods\u003d`kubectl get pods -n openstack --show-labels\u003dtrue | \\"},{"line_number":75,"context_line":"           grep pod-template | grep heat |  awk -F\u0027 \u0027 \u0027{print $1}\u0027`"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# Go through the components under test and make sure all pod processes"},{"line_number":78,"context_line":"# are enforced by the correct profile."},{"line_number":79,"context_line":"for pod in $cinder_pods"},{"line_number":80,"context_line":"do"},{"line_number":81,"context_line":"  check_pod $pod \"cinder\""},{"line_number":82,"context_line":"done"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"for pod in $horizon_pods"},{"line_number":85,"context_line":"do"},{"line_number":86,"context_line":"  check_pod $pod \"horizon\""},{"line_number":87,"context_line":"done"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"for pod in $keystone_pods"},{"line_number":90,"context_line":"do"},{"line_number":91,"context_line":"  check_pod $pod \"keystone\""},{"line_number":92,"context_line":"done"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"for pod in $heat_pods"},{"line_number":95,"context_line":"do"},{"line_number":96,"context_line":"  check_pod $pod \"heat\""},{"line_number":97,"context_line":"done"}],"source_content_type":"text/x-sh","patch_set":33,"id":"3f79a3b5_77e8117a","line":97,"range":{"start_line":67,"start_character":0,"end_line":97,"end_character":4},"updated":"2018-10-02 01:49:07.000000000","message":"this can probably be refactored into a function.","commit_id":"f1e3ca22bf83823756bbfa7d375ead8c8ae4a71d"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"df6ed2919dea879483eae20e56b552d03453f403","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  # are not processes we care about. Then filter to get only the"},{"line_number":38,"context_line":"  # processes that are part of the component (rather than OS/kernel)"},{"line_number":39,"context_line":"  # processes. The profile used for the process is the first column."},{"line_number":40,"context_line":"  profiles\u003d`kubectl exec -it $pod -n openstack -- ps auxZ | grep -v \"LABEL\" | grep -v \"grep\" | \\"},{"line_number":41,"context_line":"            grep -v \"kubectl exec\" | grep $component | \\"},{"line_number":42,"context_line":"            awk -F\u0027 \u0027 \u0027{print $1}\u0027`"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-sh","patch_set":35,"id":"3f79a3b5_d3ab2b1b","line":40,"range":{"start_line":40,"start_character":25,"end_line":40,"end_character":28},"updated":"2018-10-02 15:32:13.000000000","message":"Let\u0027s remove this as discussed, it\u0027s not necessary and causes nuisance TTY errors.","commit_id":"6bbe18039322165627f9d56efc531eaa9198929d"}],"tools/overrides/apparmor/horizon_custom_apparmor.yaml":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"f3745d201e75c5e2e145ea38dcb627be9dddbafa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":57,"id":"3f79a3b5_5597b4eb","updated":"2018-10-31 07:18:18.000000000","message":"Should this not bake into the horizon/values.yaml as well?","commit_id":"e4e2e25a902014bf0d33eeb12839fb52e5addd9d"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"ade7d9d61deb7acc45c621babe5e1b1314713f35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":57,"id":"3f79a3b5_d7b501d1","in_reply_to":"3f79a3b5_5597b4eb","updated":"2018-10-31 14:21:53.000000000","message":"This is the dummy custom profile only for the gate test. I only added the runtime/default profile for the values.yaml files.","commit_id":"e4e2e25a902014bf0d33eeb12839fb52e5addd9d"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"99f6601ff568786a74e013cd779a135ec346378d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":57,"id":"3f79a3b5_d776610c","in_reply_to":"3f79a3b5_d7b501d1","updated":"2018-10-31 14:22:48.000000000","message":"See https://review.openstack.org/#/c/602365/57/horizon/values.yaml","commit_id":"e4e2e25a902014bf0d33eeb12839fb52e5addd9d"}],"zuul.d/project.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"change_message_id":"2a0785db4debe26147a6a577e8cd6cf5c62f8258","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# and jobs are defined."},{"line_number":19,"context_line":"# NOTE(evrardjp): Some jobs and playbooks haven\u0027t been"},{"line_number":20,"context_line":"# migrated to openstack-helm-infra yet."},{"line_number":21,"context_line":"- project:"},{"line_number":22,"context_line":"    templates:"},{"line_number":23,"context_line":"      - publish-openstack-docs-pti"},{"line_number":24,"context_line":"    check:"},{"line_number":25,"context_line":"      jobs:"},{"line_number":26,"context_line":"        - openstack-helm-lint"},{"line_number":27,"context_line":"        - openstack-helm-bandit"},{"line_number":28,"context_line":"        - openstack-helm-keystone"},{"line_number":29,"context_line":"        - openstack-helm-keystone-ldap"},{"line_number":30,"context_line":"        - openstack-helm-glance"},{"line_number":31,"context_line":"        - openstack-helm-heat"},{"line_number":32,"context_line":"        - openstack-helm-cinder"},{"line_number":33,"context_line":"        - openstack-helm-compute-kit"},{"line_number":34,"context_line":"    gate:"},{"line_number":35,"context_line":"      jobs:"},{"line_number":36,"context_line":"        - openstack-helm-lint"},{"line_number":37,"context_line":"        - openstack-helm-keystone"},{"line_number":38,"context_line":"        - openstack-helm-keystone-ldap"},{"line_number":39,"context_line":"        - openstack-helm-glance"},{"line_number":40,"context_line":"        - openstack-helm-heat"},{"line_number":41,"context_line":"        - openstack-helm-cinder"},{"line_number":42,"context_line":"        - openstack-helm-compute-kit"},{"line_number":43,"context_line":"    periodic:"},{"line_number":44,"context_line":"      jobs:"},{"line_number":45,"context_line":"        - openstack-helm-multinode-temp-ubuntu"},{"line_number":46,"context_line":"        - openstack-helm-ironic-ubuntu"},{"line_number":47,"context_line":"        - openstack-helm-armada-deploy"},{"line_number":48,"context_line":"        - openstack-helm-armada-update-uuid"},{"line_number":49,"context_line":"    experimental:"},{"line_number":50,"context_line":"      jobs:"},{"line_number":51,"context_line":"        # - openstack-helm-multinode-temp-centos"},{"line_number":52,"context_line":"        # # NOTE(lamt): Make fedora job experimental until issues with gates are resolved."},{"line_number":53,"context_line":"        # - openstack-helm-multinode-temp-fedora"},{"line_number":54,"context_line":"        # - openstack-helm-multinode-temp-tempest"},{"line_number":55,"context_line":"        - openstack-helm-armada-deploy"},{"line_number":56,"context_line":"        - openstack-helm-armada-update-uuid"},{"line_number":57,"context_line":"        - openstack-helm-armada-fullstack-deploy"},{"line_number":58,"context_line":"        - openstack-helm-deploy-security-features"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":79,"id":"9fdfeff1_10a8d41d","line":59,"range":{"start_line":21,"start_character":2,"end_line":59,"end_character":0},"updated":"2019-02-13 19:10:57.000000000","message":"Job openstack-helm-armada-fullstack-deploy not defined","commit_id":"b2789a83c147f3a71e0f7ff6f1ce8ed71ab4fb74"}]}