)]}'
{"id":"openstack%2Fopenstack-helm~603455","triplet_id":"openstack%2Fopenstack-helm~master~I01f8ce1f36b6053a5ef68119d87b67050ffe99d1","project":"openstack/openstack-helm","branch":"master","topic":"vf/mtu","hashtags":[],"change_id":"I01f8ce1f36b6053a5ef68119d87b67050ffe99d1","subject":"SRIOV: Limit number of vfs to n-1 created by default","status":"MERGED","created":"2018-09-18 17:42:10.000000000","updated":"2018-10-01 07:25:40.000000000","submitted":"2018-10-01 07:25:40.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"603455-1538378740961-fbf4e33a","meta_rev_id":"d0cfa678f3f90298e46739748bc1fe629bfeca36","_number":603455,"virtual_id_number":603455,"owner":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":2,"date":"2018-10-01 07:25:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"all":[{"value":2,"date":"2018-09-19 01:20:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"all":[{"value":1,"date":"2018-10-01 06:16:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-10-01 06:16:57.000000000","updated_by":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"reviewer":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"state":"REVIEWER"},{"updated":"2018-10-01 07:25:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8f7c79aa5cd85ff90ed6cdab6387f1082a2cc762","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2018-09-18 17:42:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b5a2e11a2fd259d088226023b470e5077373223f","author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"date":"2018-09-18 17:43:06.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"15c7cde1164d7c93becf0d0f42da3316e8bb0bb9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-09-18 21:00:15.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-docs http://logs.openstack.org/55/603455/2/check/openstack-tox-docs/96fbecd/html/ : SUCCESS in 4m 59s\n- openstack-helm-linter http://logs.openstack.org/55/603455/2/check/openstack-helm-linter/1adb963/ : SUCCESS in 2m 29s\n- openstack-helm-dev-deploy-ceph-swift-ovs http://logs.openstack.org/55/603455/2/check/openstack-helm-dev-deploy-ceph-swift-ovs/3e4a68a/ : FAILURE in 59m 26s\n- openstack-helm-dev-deploy-ceph-radosgw-ovs http://logs.openstack.org/55/603455/2/check/openstack-helm-dev-deploy-ceph-radosgw-ovs/9fc1c1a/ : FAILURE in 57m 59s\n- openstack-helm-dev-deploy-ceph-rbd-ovs http://logs.openstack.org/55/603455/2/check/openstack-helm-dev-deploy-ceph-rbd-ovs/55fd945/ : FAILURE in 56m 20s\n- openstack-helm-dev-deploy-nfs-ovs http://logs.openstack.org/55/603455/2/check/openstack-helm-dev-deploy-nfs-ovs/10ed33b/ : FAILURE in 48m 45s\n- openstack-helm-dev-deploy-ceph-lb http://logs.openstack.org/55/603455/2/check/openstack-helm-dev-deploy-ceph-lb/d8ee5c4/ : FAILURE in 56m 32s (non-voting)\n- openstack-helm-dev-deploy-nfs-lb http://logs.openstack.org/55/603455/2/check/openstack-helm-dev-deploy-nfs-lb/6edc91c/ : FAILURE in 48m 48s (non-voting)\n- openstack-helm-dev-deploy-nfs-ldap http://logs.openstack.org/55/603455/2/check/openstack-helm-dev-deploy-nfs-ldap/2200c53/ : FAILURE in 50m 53s (non-voting)\n- openstack-helm-multinode-ubuntu http://logs.openstack.org/55/603455/2/check/openstack-helm-multinode-ubuntu/2d5b0b7/ : SUCCESS in 1h 45m 29s (non-voting)\n- openstack-helm-ironic-ubuntu http://logs.openstack.org/55/603455/2/check/openstack-helm-ironic-ubuntu/2e2a738/ : SUCCESS in 1h 06m 35s (non-voting)\n- openstack-helm-armada-fullstack-deploy http://logs.openstack.org/55/603455/2/check/openstack-helm-armada-fullstack-deploy/38f851b/ : SUCCESS in 1h 56m 54s (non-voting)\n- openstack-helm-kolla-deploy-ceph-ovs http://logs.openstack.org/55/603455/2/check/openstack-helm-kolla-deploy-ceph-ovs/d3adb53/ : FAILURE in 58m 54s\n- openstack-helm-ocata-loci-deploy-ceph http://logs.openstack.org/55/603455/2/check/openstack-helm-ocata-loci-deploy-ceph/56f364d/ : FAILURE in 58m 41s (non-voting)\n- openstack-helm-ocata-kolla-deploy-ceph http://logs.openstack.org/55/603455/2/check/openstack-helm-ocata-kolla-deploy-ceph/b5b2849/ : FAILURE in 58m 03s (non-voting)\n- openstack-helm-pike-loci-deploy-ceph http://logs.openstack.org/55/603455/2/check/openstack-helm-pike-loci-deploy-ceph/d6fe0dd/ : FAILURE in 56m 13s (non-voting)\n- openstack-helm-pike-kolla-deploy-ceph http://logs.openstack.org/55/603455/2/check/openstack-helm-pike-kolla-deploy-ceph/3983e8c/ : FAILURE in 58m 47s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"fab39df1d60774953e3dcd530229ca9e4824a748","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2018-09-19 01:20:30.000000000","message":"Patch Set 2: Code-Review+2\n\n#COMMENT\nvs\n# COMMENT\n\ni take it you do the former deliberately?","accounts_in_message":[],"_revision_number":2},{"id":"23bea663187e55ff542777dbba56c3ad3ce5fa60","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2018-09-19 03:20:24.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"fd8580d5c904eeddc3dda83a786380980b90f066","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-09-19 05:26:43.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/55/603455/2/check/openstack-tox-docs/ef80567/html/ : SUCCESS in 3m 33s\n- openstack-helm-linter http://logs.openstack.org/55/603455/2/check/openstack-helm-linter/0b8e198/ : SUCCESS in 1m 37s\n- openstack-helm-dev-deploy-ceph-swift-ovs http://logs.openstack.org/55/603455/2/check/openstack-helm-dev-deploy-ceph-swift-ovs/e6c36a9/ : SUCCESS in 59m 57s\n- openstack-helm-dev-deploy-ceph-radosgw-ovs http://logs.openstack.org/55/603455/2/check/openstack-helm-dev-deploy-ceph-radosgw-ovs/f947827/ : SUCCESS in 55m 56s\n- openstack-helm-dev-deploy-ceph-rbd-ovs http://logs.openstack.org/55/603455/2/check/openstack-helm-dev-deploy-ceph-rbd-ovs/bd7072d/ : SUCCESS in 59m 33s\n- openstack-helm-dev-deploy-nfs-ovs http://logs.openstack.org/55/603455/2/check/openstack-helm-dev-deploy-nfs-ovs/2e6b6db/ : SUCCESS in 44m 42s\n- openstack-helm-dev-deploy-ceph-lb http://logs.openstack.org/55/603455/2/check/openstack-helm-dev-deploy-ceph-lb/8e0897c/ : POST_FAILURE in 25m 22s (non-voting)\n- openstack-helm-dev-deploy-nfs-lb http://logs.openstack.org/55/603455/2/check/openstack-helm-dev-deploy-nfs-lb/1f939d5/ : SUCCESS in 41m 47s (non-voting)\n- openstack-helm-dev-deploy-nfs-ldap http://logs.openstack.org/55/603455/2/check/openstack-helm-dev-deploy-nfs-ldap/50d0943/ : SUCCESS in 48m 18s (non-voting)\n- openstack-helm-multinode-ubuntu http://logs.openstack.org/55/603455/2/check/openstack-helm-multinode-ubuntu/dd4539d/ : SUCCESS in 1h 40m 46s (non-voting)\n- openstack-helm-ironic-ubuntu http://logs.openstack.org/55/603455/2/check/openstack-helm-ironic-ubuntu/c32777d/ : SUCCESS in 1h 00m 37s (non-voting)\n- openstack-helm-armada-fullstack-deploy http://logs.openstack.org/55/603455/2/check/openstack-helm-armada-fullstack-deploy/c8c52e4/ : SUCCESS in 2h 00m 29s (non-voting)\n- openstack-helm-kolla-deploy-ceph-ovs http://logs.openstack.org/55/603455/2/check/openstack-helm-kolla-deploy-ceph-ovs/81b50ca/ : SUCCESS in 59m 06s\n- openstack-helm-ocata-loci-deploy-ceph http://logs.openstack.org/55/603455/2/check/openstack-helm-ocata-loci-deploy-ceph/cbc3357/ : SUCCESS in 55m 09s (non-voting)\n- openstack-helm-ocata-kolla-deploy-ceph http://logs.openstack.org/55/603455/2/check/openstack-helm-ocata-kolla-deploy-ceph/682c393/ : SUCCESS in 1h 04m 24s (non-voting)\n- openstack-helm-pike-loci-deploy-ceph http://logs.openstack.org/55/603455/2/check/openstack-helm-pike-loci-deploy-ceph/d752138/ : SUCCESS in 1h 00m 53s (non-voting)\n- openstack-helm-pike-kolla-deploy-ceph http://logs.openstack.org/55/603455/2/check/openstack-helm-pike-kolla-deploy-ceph/306e39a/ : SUCCESS in 1h 10m 05s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"8c2e4ec5771a3f3b2d74210dc70a07a2bcb0717f","author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"date":"2018-10-01 06:16:57.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"6a8101870ca21392b1ce844fb2dcc53953d46c3e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-01 06:17:09.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"6857e560778c70d198100cf5ccd327c04213d56e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-01 07:25:40.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"406e48cbe13fd32669764d44805a8d431163f517","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-10-01 07:25:40.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/55/603455/2/gate/openstack-tox-docs/1c3621f/html/ : SUCCESS in 5m 34s\n- openstack-helm-linter http://logs.openstack.org/55/603455/2/gate/openstack-helm-linter/e528a4d/ : SUCCESS in 2m 32s\n- openstack-helm-dev-deploy-ceph-swift-ovs http://logs.openstack.org/55/603455/2/gate/openstack-helm-dev-deploy-ceph-swift-ovs/cb867db/ : SUCCESS in 1h 02m 31s\n- openstack-helm-dev-deploy-ceph-radosgw-ovs http://logs.openstack.org/55/603455/2/gate/openstack-helm-dev-deploy-ceph-radosgw-ovs/e860f7f/ : SUCCESS in 1h 00m 32s\n- openstack-helm-dev-deploy-ceph-rbd-ovs http://logs.openstack.org/55/603455/2/gate/openstack-helm-dev-deploy-ceph-rbd-ovs/47c8ae7/ : SUCCESS in 56m 52s\n- openstack-helm-dev-deploy-nfs-ovs http://logs.openstack.org/55/603455/2/gate/openstack-helm-dev-deploy-nfs-ovs/e3d6d7f/ : SUCCESS in 45m 51s\n- openstack-helm-kolla-deploy-ceph-ovs http://logs.openstack.org/55/603455/2/gate/openstack-helm-kolla-deploy-ceph-ovs/9df7655/ : SUCCESS in 58m 46s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"a5d6be32c71e9e9b5b591ac960e459eff4d98a5e","revisions":{"b4562c71e026054d01bc92c28a653354adf86d40":{"kind":"REWORK","_number":1,"created":"2018-09-18 17:42:10.000000000","uploader":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"ref":"refs/changes/55/603455/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/55/603455/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/55/603455/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/55/603455/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/55/603455/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/55/603455/1"}}},"commit":{"parents":[{"commit":"8e4ee070e65d54e2e5aa23b03febfac281278bf3","subject":"SRIOV: Set sriov device mtu","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/8e4ee070e65d54e2e5aa23b03febfac281278bf3"}]}],"author":{"name":"Pete Birley","email":"pete@port.direct","date":"2018-09-18 17:40:13.000000000","tz":-300},"committer":{"name":"Pete Birley","email":"pete@port.direct","date":"2018-09-18 17:40:13.000000000","tz":-300},"subject":"SRIOV: Limit number of vfs to n-1 created by default","message":"SRIOV: Limit number of vfs to n-1 created by default\n\nThis PS udpates the sriov init script to by default create the\nmax number of vfs supported by the card -1. Which works round\nissues encoutered with many cards that prevents ther theroretical\nmax being attainable.\n\nChange-Id: I01f8ce1f36b6053a5ef68119d87b67050ffe99d1\nSigned-off-by: Pete Birley \u003cpete@port.direct\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/b4562c71e026054d01bc92c28a653354adf86d40"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/b4562c71e026054d01bc92c28a653354adf86d40"}]},"branch":"refs/heads/master"},"a5d6be32c71e9e9b5b591ac960e459eff4d98a5e":{"kind":"REWORK","_number":2,"created":"2018-09-18 17:43:06.000000000","uploader":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"ref":"refs/changes/55/603455/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-helm","ref":"refs/changes/55/603455/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/55/603455/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/55/603455/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-helm refs/changes/55/603455/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-helm refs/changes/55/603455/2"}}},"commit":{"parents":[{"commit":"8e4ee070e65d54e2e5aa23b03febfac281278bf3","subject":"SRIOV: Set sriov device mtu","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/8e4ee070e65d54e2e5aa23b03febfac281278bf3"}]}],"author":{"name":"Pete Birley","email":"pete@port.direct","date":"2018-09-18 17:40:13.000000000","tz":-300},"committer":{"name":"Pete Birley","email":"petebirley@gmail.com","date":"2018-09-18 17:43:03.000000000","tz":0},"subject":"SRIOV: Limit number of vfs to n-1 created by default","message":"SRIOV: Limit number of vfs to n-1 created by default\n\nThis PS udpates the sriov init script to by default create the\nmax number of vfs supported by the card -1. Which works round\nissues encoutered with many cards that prevents ther theroretical\nmax being attainable.\n\nChange-Id: I01f8ce1f36b6053a5ef68119d87b67050ffe99d1\nSigned-off-by: Pete Birley \u003cpete@port.direct\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/a5d6be32c71e9e9b5b591ac960e459eff4d98a5e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-helm/commit/a5d6be32c71e9e9b5b591ac960e459eff4d98a5e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
