)]}'
{"tools/deployment/common/setup-apparmor.sh":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"dc3a083f77fbf678c739de14bb754ce28f5f906b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"set -xe"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Installs apparmor"},{"line_number":20,"context_line":"sudo apt-get install appamor"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"tee /tmp/apparmor.profile \u003c\u003c EOF"},{"line_number":23,"context_line":"#include \u003ctunables/global\u003e"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_33d6bbf4","line":20,"range":{"start_line":20,"start_character":5,"end_line":20,"end_character":12},"updated":"2018-09-25 10:57:45.000000000","message":"that will become ubuntu/debian specific, and not support suse.","commit_id":"5b55ae3062a26c65a65a68a964f739b5ee2acb57"}],"tools/gate/playbooks/dev-deploy-nfs.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"dc3a083f77fbf678c739de14bb754ce28f5f906b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        ./tools/deployment/developer/nfs/020-setup-client.sh"},{"line_number":48,"context_line":"      args:"},{"line_number":49,"context_line":"        chdir: \"{{ zuul_osh_relative_path | default(zuul.project.src_dir) }}\""},{"line_number":50,"context_line":"    - name: Setup AppArmor"},{"line_number":51,"context_line":"      when: ansible_distribution \u003d\u003d \u0027Ubuntu\u0027"},{"line_number":52,"context_line":"      shell: |"},{"line_number":53,"context_line":"        set -xe;"},{"line_number":54,"context_line":"        ./tools/deployment/common/setup-apparmor.sh"},{"line_number":55,"context_line":"      args:"},{"line_number":56,"context_line":"        chdir: \"{{ zuul_osh_relative_path | default(zuul.project.src_dir) }}\""},{"line_number":57,"context_line":"    - name: Deploy Ingress"},{"line_number":58,"context_line":"      environment:"},{"line_number":59,"context_line":"        OSH_OPENSTACK_RELEASE: \"{{ osh_openstack_release }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_33ef9bb2","line":56,"range":{"start_line":50,"start_character":0,"end_line":56,"end_character":77},"updated":"2018-09-25 10:57:45.000000000","message":"why not setting this in gating based on node details, vs doing this inline in this script? Wouldn\u0027t you consider apparmor as installed on the system, and then you consider you must deploy OSH on an apparmor enabled system?","commit_id":"5b55ae3062a26c65a65a68a964f739b5ee2acb57"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"5650277497c9efbfac52c8ec65ac657b703472f7","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        ./tools/deployment/developer/nfs/020-setup-client.sh"},{"line_number":48,"context_line":"      args:"},{"line_number":49,"context_line":"        chdir: \"{{ zuul_osh_relative_path | default(zuul.project.src_dir) }}\""},{"line_number":50,"context_line":"    - name: Setup AppArmor"},{"line_number":51,"context_line":"      when: ansible_distribution \u003d\u003d \u0027Ubuntu\u0027"},{"line_number":52,"context_line":"      shell: |"},{"line_number":53,"context_line":"        set -xe;"},{"line_number":54,"context_line":"        ./tools/deployment/common/setup-apparmor.sh"},{"line_number":55,"context_line":"      args:"},{"line_number":56,"context_line":"        chdir: \"{{ zuul_osh_relative_path | default(zuul.project.src_dir) }}\""},{"line_number":57,"context_line":"    - name: Deploy Ingress"},{"line_number":58,"context_line":"      environment:"},{"line_number":59,"context_line":"        OSH_OPENSTACK_RELEASE: \"{{ osh_openstack_release }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_d965214b","line":56,"range":{"start_line":50,"start_character":0,"end_line":56,"end_character":77},"in_reply_to":"3f79a3b5_33ef9bb2","updated":"2018-09-25 17:17:08.000000000","message":"The rationale is to demonstrate we can load a custom apparmor profile in the gate\u0027s pipeline.  In that regard, I\u0027d prefer to always put in an apparmor profile - perhaps in a separate job vs impacting - to ensure it shows it works vs. trying to detect if apparmor and an existent profile are there.  If none of the nodes in zuul have apparmor, this may end up not being exercised.\n\nThis patch set should probably be fused into one Cliff is working on, it is now just here to ensure it can be done in the gate as this has been tested locally.","commit_id":"5b55ae3062a26c65a65a68a964f739b5ee2acb57"},{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"2e75625e09f7c823328d13488e87797dec38d08e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        ./tools/deployment/developer/nfs/020-setup-client.sh"},{"line_number":48,"context_line":"      args:"},{"line_number":49,"context_line":"        chdir: \"{{ zuul_osh_relative_path | default(zuul.project.src_dir) }}\""},{"line_number":50,"context_line":"    - name: Setup AppArmor"},{"line_number":51,"context_line":"      when: ansible_distribution \u003d\u003d \u0027Ubuntu\u0027"},{"line_number":52,"context_line":"      shell: |"},{"line_number":53,"context_line":"        set -xe;"},{"line_number":54,"context_line":"        ./tools/deployment/common/setup-apparmor.sh"},{"line_number":55,"context_line":"      args:"},{"line_number":56,"context_line":"        chdir: \"{{ zuul_osh_relative_path | default(zuul.project.src_dir) }}\""},{"line_number":57,"context_line":"    - name: Deploy Ingress"},{"line_number":58,"context_line":"      environment:"},{"line_number":59,"context_line":"        OSH_OPENSTACK_RELEASE: \"{{ osh_openstack_release }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_5f001101","line":56,"range":{"start_line":50,"start_character":0,"end_line":56,"end_character":77},"in_reply_to":"3f79a3b5_d965214b","updated":"2018-09-25 18:15:57.000000000","message":"I will combine these changes with the other commit (https://review.openstack.org/#/c/602365/) and try to get it working with the gate.","commit_id":"5b55ae3062a26c65a65a68a964f739b5ee2acb57"}]}