)]}'
{"neutron/templates/bin/_neutron-sriov-agent-init.sh.tpl":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"7303c59d9bcee0d937cc98d4a00dc1dbfbfea07c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{{ if ( has \"besteffort\" .Values.conf.sriov_init ) }}set -x{{ else }}set -ex{{ end }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{- range $k, $sriov :\u003d .Values.network.interface.sriov }}"},{"line_number":22,"context_line":"if [ \"x{{ $sriov.num_vfs }}\" !\u003d \"x\" ]; then"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3f79a3b5_25f22ee4","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":85},"updated":"2018-10-04 03:17:46.000000000","message":"might be more readable to split that over multiple lines","commit_id":"6ec9b30bcb0982d412011bfab662be9cce5b4863"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"8cca01d10fbd7f483cc328cb998b1f6dd689e318","unresolved":false,"context_lines":[{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{{ if ( has \"besteffort\" .Values.conf.sriov_init ) }}set -x{{ else }}set -ex{{ end }}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{- range $k, $sriov :\u003d .Values.network.interface.sriov }}"},{"line_number":22,"context_line":"if [ \"x{{ $sriov.num_vfs }}\" !\u003d \"x\" ]; then"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"3f79a3b5_b3119952","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":85},"in_reply_to":"3f79a3b5_25f22ee4","updated":"2018-10-04 13:51:06.000000000","message":"done.","commit_id":"6ec9b30bcb0982d412011bfab662be9cce5b4863"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"2e8fae42eaaf4812c1a3fc15601a39d96fbce581","unresolved":false,"context_lines":[{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{{- if ( has \"besteffort\" .Values.conf.sriov_init ) }}"},{"line_number":20,"context_line":"set -x"},{"line_number":21,"context_line":"{{- else }}"},{"line_number":22,"context_line":"set -ex"},{"line_number":23,"context_line":"{{- end }}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{{- range $k, $sriov :\u003d .Values.network.interface.sriov }}"},{"line_number":26,"context_line":"if [ \"x{{ $sriov.num_vfs }}\" !\u003d \"x\" ]; then"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3f79a3b5_446b41b8","line":23,"range":{"start_line":19,"start_character":0,"end_line":23,"end_character":10},"updated":"2018-10-09 17:36:18.000000000","message":"why not\n\nset -x\n\n{{ if blah blah blah }}\nset -e\n{{ end }}\n\n?","commit_id":"9e1c36a7c2bc94b61a3484bd393d3b4e58fde4a4"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"e919fa9c1601d611d4b64a35ef0062822770135a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"limitations under the License."},{"line_number":17,"context_line":"*/}}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"{{- if ( has \"besteffort\" .Values.conf.sriov_init ) }}"},{"line_number":20,"context_line":"set -x"},{"line_number":21,"context_line":"{{- else }}"},{"line_number":22,"context_line":"set -ex"},{"line_number":23,"context_line":"{{- end }}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{{- range $k, $sriov :\u003d .Values.network.interface.sriov }}"},{"line_number":26,"context_line":"if [ \"x{{ $sriov.num_vfs }}\" !\u003d \"x\" ]; then"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3f79a3b5_c4baf109","line":23,"range":{"start_line":19,"start_character":0,"end_line":23,"end_character":10},"in_reply_to":"3f79a3b5_446b41b8","updated":"2018-10-09 17:52:30.000000000","message":"don\u0027t see why not, will be done","commit_id":"9e1c36a7c2bc94b61a3484bd393d3b4e58fde4a4"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"2e8fae42eaaf4812c1a3fc15601a39d96fbce581","unresolved":false,"context_lines":[{"line_number":63,"context_line":"{{- end }}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"{{- if ( has \"besteffort\" .Values.conf.sriov_init ) }}"},{"line_number":67,"context_line":"exit 0"},{"line_number":68,"context_line":"{{ end }}"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3f79a3b5_046549e2","line":68,"range":{"start_line":66,"start_character":0,"end_line":68,"end_character":9},"updated":"2018-10-09 17:36:18.000000000","message":"exit $?","commit_id":"9e1c36a7c2bc94b61a3484bd393d3b4e58fde4a4"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"e919fa9c1601d611d4b64a35ef0062822770135a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"{{- end }}"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"{{- if ( has \"besteffort\" .Values.conf.sriov_init ) }}"},{"line_number":67,"context_line":"exit 0"},{"line_number":68,"context_line":"{{ end }}"}],"source_content_type":"text/x-smarty","patch_set":5,"id":"3f79a3b5_6458bdf8","line":68,"range":{"start_line":66,"start_character":0,"end_line":68,"end_character":9},"in_reply_to":"3f79a3b5_046549e2","updated":"2018-10-09 17:52:30.000000000","message":"But then it is not \"best effort\" anymore","commit_id":"9e1c36a7c2bc94b61a3484bd393d3b4e58fde4a4"}],"neutron/values.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"7303c59d9bcee0d937cc98d4a00dc1dbfbfea07c","unresolved":false,"context_lines":[{"line_number":1650,"context_line":"        apply-to: all"},{"line_number":1651,"context_line":"        pattern: \u0027(notifications)\\.\u0027"},{"line_number":1652,"context_line":"  sriov_init:"},{"line_number":1653,"context_line":"    - "},{"line_number":1654,"context_line":"    ## To prevent sriov init script from failing for debug purpose, set to"},{"line_number":1655,"context_line":"    ## sriov_init:"},{"line_number":1656,"context_line":"    ##   - besteffort"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_c567bab7","line":1653,"range":{"start_line":1653,"start_character":5,"end_line":1653,"end_character":6},"updated":"2018-10-04 03:17:46.000000000","message":"tws","commit_id":"6ec9b30bcb0982d412011bfab662be9cce5b4863"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"8cca01d10fbd7f483cc328cb998b1f6dd689e318","unresolved":false,"context_lines":[{"line_number":1650,"context_line":"        apply-to: all"},{"line_number":1651,"context_line":"        pattern: \u0027(notifications)\\.\u0027"},{"line_number":1652,"context_line":"  sriov_init:"},{"line_number":1653,"context_line":"    - "},{"line_number":1654,"context_line":"    ## To prevent sriov init script from failing for debug purpose, set to"},{"line_number":1655,"context_line":"    ## sriov_init:"},{"line_number":1656,"context_line":"    ##   - besteffort"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_131c0d64","line":1653,"range":{"start_line":1653,"start_character":5,"end_line":1653,"end_character":6},"in_reply_to":"3f79a3b5_c567bab7","updated":"2018-10-04 13:51:06.000000000","message":"Good catch.","commit_id":"6ec9b30bcb0982d412011bfab662be9cce5b4863"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"a8008817de123ed3263016f3d3b1d038c3b6b1bb","unresolved":false,"context_lines":[{"line_number":1653,"context_line":"    -"},{"line_number":1654,"context_line":"    ## To prevent sriov init script from failing for debug purpose, set to"},{"line_number":1655,"context_line":"    ## sriov_init:"},{"line_number":1656,"context_line":"    ##   - besteffort"},{"line_number":1657,"context_line":""},{"line_number":1658,"context_line":"# Names of secrets used by bootstrap and environmental checks"},{"line_number":1659,"context_line":"secrets:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_44c7c199","line":1656,"range":{"start_line":1656,"start_character":0,"end_line":1656,"end_character":21},"updated":"2018-10-09 17:42:25.000000000","message":"maybe we want\n\n  sriov_init.besteffort: true\n\nor\n\n  sriov_init.error_fail: false\n\n?","commit_id":"9e1c36a7c2bc94b61a3484bd393d3b4e58fde4a4"},{"author":{"_account_id":18250,"name":"Roy Tang","email":"roy.s.tang@att.com","username":"rt7380"},"change_message_id":"e919fa9c1601d611d4b64a35ef0062822770135a","unresolved":false,"context_lines":[{"line_number":1653,"context_line":"    -"},{"line_number":1654,"context_line":"    ## To prevent sriov init script from failing for debug purpose, set to"},{"line_number":1655,"context_line":"    ## sriov_init:"},{"line_number":1656,"context_line":"    ##   - besteffort"},{"line_number":1657,"context_line":""},{"line_number":1658,"context_line":"# Names of secrets used by bootstrap and environmental checks"},{"line_number":1659,"context_line":"secrets:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_a45ed5e5","line":1656,"range":{"start_line":1656,"start_character":0,"end_line":1656,"end_character":21},"in_reply_to":"3f79a3b5_44c7c199","updated":"2018-10-09 17:52:30.000000000","message":"That was actually my initial thought, but since this is a short term fix, I actually didn\u0027t even want the comments there but I add one anyway.","commit_id":"9e1c36a7c2bc94b61a3484bd393d3b4e58fde4a4"}]}