)]}'
{"neutron/templates/bin/_db-sync.sh.tpl":[{"author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"change_message_id":"98bf26902afba2586180d3e3a691bbc3566ecabc","unresolved":false,"context_lines":[{"line_number":24,"context_line":"{{- if .Values.conf.plugins.taas.taas.enabled }}"},{"line_number":25,"context_line":"  --subproject tap-as-a-service \\"},{"line_number":26,"context_line":"{{- end }}"},{"line_number":27,"context_line":"{{- if .Values.manifests.daemonset_lbaas_agent }}"},{"line_number":28,"context_line":"  --subproject neutron-lbaas \\"},{"line_number":29,"context_line":"{{- end }}"},{"line_number":30,"context_line":"  upgrade head"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3f79a3b5_c3278bce","line":27,"range":{"start_line":27,"start_character":7,"end_line":27,"end_character":46},"updated":"2018-11-30 03:42:58.000000000","message":"you may want to add Values.conf.plugins.lbaas.lbaas.enabled for consistency with taas and supporting some other 3rd party drivers without agent.","commit_id":"f14d8b53a84da36cf65540c9139694e45d240a88"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"2663ee0be92e795f48d02fe58545234dccfe842f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  --subproject neutron-lbaas \\"},{"line_number":29,"context_line":"{{- end }}"},{"line_number":30,"context_line":"  upgrade head"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3f79a3b5_3c6d6a00","line":32,"range":{"start_line":31,"start_character":0,"end_line":32,"end_character":0},"updated":"2018-11-11 18:59:41.000000000","message":"tws","commit_id":"f14d8b53a84da36cf65540c9139694e45d240a88"}],"neutron/templates/bin/_neutron-lbaas-agent.sh.tpl":[{"author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"change_message_id":"98bf26902afba2586180d3e3a691bbc3566ecabc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{{/*"},{"line_number":4,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":7,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3f79a3b5_90a1d7aa","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":14},"updated":"2018-11-30 03:42:58.000000000","message":"2018","commit_id":"f14d8b53a84da36cf65540c9139694e45d240a88"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d26f7c457a2f88c9b344c93c3c61a69cacf165ba","unresolved":false,"context_lines":[{"line_number":19,"context_line":"set -x"},{"line_number":20,"context_line":"exec neutron-lbaasv2-agent \\"},{"line_number":21,"context_line":"      --config-file /etc/neutron/neutron.conf \\"},{"line_number":22,"context_line":"      --config-file /etc/neutron/plugins/ml2/ml2_conf.ini "},{"line_number":23,"context_line":"{{- if ( has \"openvswitch\" .Values.network.backend ) }} \\"},{"line_number":24,"context_line":"      --config-file /etc/neutron/plugins/ml2/openvswitch_agent.ini \\"},{"line_number":25,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3f79a3b5_cbe2c79c","line":22,"updated":"2018-10-11 17:46:55.000000000","message":"this may be an issue if the neutron plugin is not ml2\ncan we do this in a way that is configurable?","commit_id":"f14d8b53a84da36cf65540c9139694e45d240a88"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"2663ee0be92e795f48d02fe58545234dccfe842f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"set -x"},{"line_number":20,"context_line":"exec neutron-lbaasv2-agent \\"},{"line_number":21,"context_line":"      --config-file /etc/neutron/neutron.conf \\"},{"line_number":22,"context_line":"      --config-file /etc/neutron/plugins/ml2/ml2_conf.ini "},{"line_number":23,"context_line":"{{- if ( has \"openvswitch\" .Values.network.backend ) }} \\"},{"line_number":24,"context_line":"      --config-file /etc/neutron/plugins/ml2/openvswitch_agent.ini \\"},{"line_number":25,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3f79a3b5_dc7796d1","line":22,"range":{"start_line":22,"start_character":57,"end_line":22,"end_character":58},"updated":"2018-11-11 18:59:41.000000000","message":"tws","commit_id":"f14d8b53a84da36cf65540c9139694e45d240a88"},{"author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"change_message_id":"98bf26902afba2586180d3e3a691bbc3566ecabc","unresolved":false,"context_lines":[{"line_number":19,"context_line":"set -x"},{"line_number":20,"context_line":"exec neutron-lbaasv2-agent \\"},{"line_number":21,"context_line":"      --config-file /etc/neutron/neutron.conf \\"},{"line_number":22,"context_line":"      --config-file /etc/neutron/plugins/ml2/ml2_conf.ini "},{"line_number":23,"context_line":"{{- if ( has \"openvswitch\" .Values.network.backend ) }} \\"},{"line_number":24,"context_line":"      --config-file /etc/neutron/plugins/ml2/openvswitch_agent.ini \\"},{"line_number":25,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3f79a3b5_70967b3e","line":22,"in_reply_to":"3f79a3b5_cbe2c79c","updated":"2018-11-30 03:42:58.000000000","message":"I basically agree on your comment, but all other agents assume ml2 is the plugin. this can be addressed in a separate patch with all other agents.","commit_id":"f14d8b53a84da36cf65540c9139694e45d240a88"},{"author":{"_account_id":8181,"name":"Jaesuk Ahn","email":"bluejay.ahn@gmail.com","username":"blujeay.kr"},"change_message_id":"1784d25f6ced6cda1f93cb324e5d7242af3adb1f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"set -x"},{"line_number":20,"context_line":"exec neutron-lbaasv2-agent \\"},{"line_number":21,"context_line":"      --config-file /etc/neutron/neutron.conf \\"},{"line_number":22,"context_line":"      --config-file /etc/neutron/plugins/ml2/ml2_conf.ini "},{"line_number":23,"context_line":"{{- if ( has \"openvswitch\" .Values.network.backend ) }} \\"},{"line_number":24,"context_line":"      --config-file /etc/neutron/plugins/ml2/openvswitch_agent.ini \\"},{"line_number":25,"context_line":"{{- end }}"}],"source_content_type":"text/x-smarty","patch_set":2,"id":"bfdaf3ff_8f172e52","line":22,"range":{"start_line":22,"start_character":57,"end_line":22,"end_character":58},"updated":"2019-01-15 08:31:23.000000000","message":"trailing white space.","commit_id":"b2b70f0ef59d046e2945b012bb8b042d70d1ff20"}],"neutron/templates/bin/_neutron-server.sh.tpl":[{"author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"change_message_id":"98bf26902afba2586180d3e3a691bbc3566ecabc","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{{- if ( has \"sriov\" .Values.network.backend ) }} \\"},{"line_number":30,"context_line":"        --config-file /etc/neutron/plugins/ml2/sriov_agent.ini"},{"line_number":31,"context_line":"{{- end }}"},{"line_number":32,"context_line":"{{ if .Values.manifests.daemonset_lbaas_agent }} \\"},{"line_number":33,"context_line":"        --config-file /etc/neutron/neutron_lbaas.conf"},{"line_number":34,"context_line":"{{- end }}"},{"line_number":35,"context_line":"}"}],"source_content_type":"text/x-smarty","patch_set":1,"id":"3f79a3b5_03e7c312","line":32,"range":{"start_line":32,"start_character":6,"end_line":32,"end_character":45},"updated":"2018-11-30 03:42:58.000000000","message":"you may want to add Values.conf.plugins.lbaas.lbaas.enabled for consistency with taas and supporting some other 3rd party drivers without agent.","commit_id":"f14d8b53a84da36cf65540c9139694e45d240a88"}],"neutron/templates/daemonset-lbaas-agent.yaml":[{"author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"change_message_id":"98bf26902afba2586180d3e3a691bbc3566ecabc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{/*"},{"line_number":2,"context_line":"Copyright 2017 The Openstack-Helm Authors."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_a6c7fd97","line":2,"range":{"start_line":2,"start_character":10,"end_line":2,"end_character":14},"updated":"2018-11-30 03:42:58.000000000","message":"2018","commit_id":"f14d8b53a84da36cf65540c9139694e45d240a88"}],"neutron/templates/deployment-server.yaml":[{"author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"change_message_id":"98bf26902afba2586180d3e3a691bbc3566ecabc","unresolved":false,"context_lines":[{"line_number":114,"context_line":"              mountPath: /etc/neutron/policy.json"},{"line_number":115,"context_line":"              subPath: policy.json"},{"line_number":116,"context_line":"              readOnly: true"},{"line_number":117,"context_line":"            {{ if .Values.manifests.daemonset_lbaas_agent }}"},{"line_number":118,"context_line":"            - name: neutron-etc"},{"line_number":119,"context_line":"              mountPath: /etc/neutron/neutron_lbaas.conf"},{"line_number":120,"context_line":"              subPath: neutron_lbaas.conf"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_66ec8505","line":117,"range":{"start_line":117,"start_character":18,"end_line":117,"end_character":57},"updated":"2018-11-30 03:42:58.000000000","message":"lbaas.enabled could be used here as well.","commit_id":"f14d8b53a84da36cf65540c9139694e45d240a88"}],"neutron/values.yaml":[{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"180a1d415297d1c55e2ad4796f5f3cb90cb5eb7f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    neutron_linuxbridge_agent: docker.io/openstackhelm/neutron:newton"},{"line_number":39,"context_line":"    neutron_sriov_agent: docker.io/openstackhelm/neutron:newton-sriov-1804"},{"line_number":40,"context_line":"    neutron_sriov_agent_init: docker.io/openstackhelm/neutron:newton-sriov-1804"},{"line_number":41,"context_line":"    neutron_lbaas: docker.io/openstackhelm/neutron:newton"},{"line_number":42,"context_line":"    dep_check: quay.io/stackanetes/kubernetes-entrypoint:v0.3.1"},{"line_number":43,"context_line":"    image_repo_sync: docker.io/docker:17.07.0"},{"line_number":44,"context_line":"  pull_policy: \"IfNotPresent\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_b060c135","line":41,"range":{"start_line":41,"start_character":19,"end_line":41,"end_character":57},"updated":"2018-11-10 18:22:18.000000000","message":"this image doesn\u0027t have lbaas code/package","commit_id":"f14d8b53a84da36cf65540c9139694e45d240a88"},{"author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"change_message_id":"392bd9b24f0b103a6178270ba081ac53f60dbde1","unresolved":false,"context_lines":[{"line_number":1524,"context_line":"      core_plugin: ml2"},{"line_number":1525,"context_line":"      # service_plugin can be: router, odl-router, empty for calico,"},{"line_number":1526,"context_line":"      # networking_ovn.l3.l3_ovn.OVNL3RouterPlugin for OVN"},{"line_number":1527,"context_line":"      service_plugins: router"},{"line_number":1528,"context_line":"      allow_automatic_l3agent_failover: True"},{"line_number":1529,"context_line":"      l3_ha: True"},{"line_number":1530,"context_line":"      max_l3_agents_per_router: 2"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_86ac41a9","line":1527,"range":{"start_line":1527,"start_character":6,"end_line":1527,"end_character":29},"updated":"2018-11-30 03:47:20.000000000","message":"assuming you want to enable lbaas by default, lbaasv2 should be added here as well.","commit_id":"f14d8b53a84da36cf65540c9139694e45d240a88"},{"author":{"_account_id":6678,"name":"Hyunsun Moon","email":"hyunsun.moon@gmail.com","username":"hyunsun-moon"},"change_message_id":"98bf26902afba2586180d3e3a691bbc3566ecabc","unresolved":false,"context_lines":[{"line_number":1699,"context_line":"  lbaas_agent:"},{"line_number":1700,"context_line":"    DEFAULT:"},{"line_number":1701,"context_line":"      # openvswitch or linuxbridge"},{"line_number":1702,"context_line":"      interface_driver: openvswitch"},{"line_number":1703,"context_line":"      ovs_use_veth: False"},{"line_number":1704,"context_line":""},{"line_number":1705,"context_line":"  rabbitmq:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_e65bb5f5","line":1702,"range":{"start_line":1702,"start_character":24,"end_line":1702,"end_character":35},"updated":"2018-11-30 03:42:58.000000000","message":"null by default, and make it auto-set by network.backend value for consistency with other agents.","commit_id":"f14d8b53a84da36cf65540c9139694e45d240a88"}]}