)]}'
{"cinder/templates/deployment-backup.yaml":[{"author":{"_account_id":22636,"name":"Cliff Parsons","email":"cliffhparsons@aol.com","username":"cliffparsons"},"change_message_id":"ee67b9a60934309e0caafe1eefb42371ef831b6e","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        - name: cinder-backup"},{"line_number":130,"context_line":"{{ tuple $envAll \"cinder_backup\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":131,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.backup | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":132,"context_line":"          securityContext:"},{"line_number":133,"context_line":"            runAsUser: {{ .Values.pod.user.cinder.uid }}"},{"line_number":134,"context_line":"            capabilities:"},{"line_number":135,"context_line":"              add:"},{"line_number":136,"context_line":"                - SYS_ADMIN"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_54c90cac","line":133,"range":{"start_line":132,"start_character":0,"end_line":133,"end_character":56},"updated":"2018-11-12 21:03:17.000000000","message":"Should be removed","commit_id":"86a50ed4c40748bc4d3f9bf7fe25a3a00bb99e47"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"a377f9b542304b861c267b8954581e3edccdc07a","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        - name: cinder-backup"},{"line_number":130,"context_line":"{{ tuple $envAll \"cinder_backup\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":131,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.backup | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":132,"context_line":"          securityContext:"},{"line_number":133,"context_line":"            runAsUser: {{ .Values.pod.user.cinder.uid }}"},{"line_number":134,"context_line":"            capabilities:"},{"line_number":135,"context_line":"              add:"},{"line_number":136,"context_line":"                - SYS_ADMIN"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_34425069","line":133,"range":{"start_line":132,"start_character":0,"end_line":133,"end_character":56},"in_reply_to":"3f79a3b5_54c90cac","updated":"2018-11-12 21:50:05.000000000","message":"Done","commit_id":"86a50ed4c40748bc4d3f9bf7fe25a3a00bb99e47"}],"cinder/templates/job-backup-storage-init.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"fe23254ba7af6f35c75f34acafd23cfce13d77e6","unresolved":false,"context_lines":[{"line_number":82,"context_line":"              mountPath: /tmp/ceph-admin-keyring.sh"},{"line_number":83,"context_line":"              subPath: ceph-admin-keyring.sh"},{"line_number":84,"context_line":"              readOnly: true"},{"line_number":85,"context_line":"            {{- else }}"},{"line_number":86,"context_line":"            - name: cinder-bin"},{"line_number":87,"context_line":"              mountPath: /tmp/ceph-admin-keyring.sh"},{"line_number":88,"context_line":"              subPath: external-ceph-rbd-admin-keyring.sh"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3f79a3b5_7d7284e3","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":23},"updated":"2018-12-17 16:39:33.000000000","message":"ws change","commit_id":"6c451c9a1785f807ac2607ae0d75c6220103c36c"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"70ee289085d954b1b32181d7e0504e765ec11442","unresolved":false,"context_lines":[{"line_number":82,"context_line":"              mountPath: /tmp/ceph-admin-keyring.sh"},{"line_number":83,"context_line":"              subPath: ceph-admin-keyring.sh"},{"line_number":84,"context_line":"              readOnly: true"},{"line_number":85,"context_line":"            {{- else }}"},{"line_number":86,"context_line":"            - name: cinder-bin"},{"line_number":87,"context_line":"              mountPath: /tmp/ceph-admin-keyring.sh"},{"line_number":88,"context_line":"              subPath: external-ceph-rbd-admin-keyring.sh"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3f79a3b5_0c431970","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":23},"in_reply_to":"3f79a3b5_5b50e92d","updated":"2018-12-18 04:49:34.000000000","message":"can be commented in sep PS","commit_id":"6c451c9a1785f807ac2607ae0d75c6220103c36c"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d2d9b9b4d6a20ec769e33e45238168d8e7835acd","unresolved":false,"context_lines":[{"line_number":82,"context_line":"              mountPath: /tmp/ceph-admin-keyring.sh"},{"line_number":83,"context_line":"              subPath: ceph-admin-keyring.sh"},{"line_number":84,"context_line":"              readOnly: true"},{"line_number":85,"context_line":"            {{- else }}"},{"line_number":86,"context_line":"            - name: cinder-bin"},{"line_number":87,"context_line":"              mountPath: /tmp/ceph-admin-keyring.sh"},{"line_number":88,"context_line":"              subPath: external-ceph-rbd-admin-keyring.sh"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3f79a3b5_5b50e92d","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":23},"in_reply_to":"3f79a3b5_7d7284e3","updated":"2018-12-18 01:11:45.000000000","message":"this actually now matches with the indent with L80.","commit_id":"6c451c9a1785f807ac2607ae0d75c6220103c36c"}],"horizon/values.yaml":[{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"48a784b45bbfb3e68d375077018c1099d5a9394f","unresolved":false,"context_lines":[{"line_number":1903,"context_line":"pod:"},{"line_number":1904,"context_line":"  user:"},{"line_number":1905,"context_line":"    horizon:"},{"line_number":1906,"context_line":"      uid: 42424"},{"line_number":1907,"context_line":"  affinity:"},{"line_number":1908,"context_line":"    anti:"},{"line_number":1909,"context_line":"      type:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_2c9f4765","line":1906,"range":{"start_line":1906,"start_character":6,"end_line":1906,"end_character":16},"updated":"2018-10-31 17:46:57.000000000","message":"does it have to be done using a uid?  it can\u0027t be a string for a username in the containers /etc/passwd?","commit_id":"86a50ed4c40748bc4d3f9bf7fe25a3a00bb99e47"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"75af84a408cf25cc1c16a8be5646179f0201931a","unresolved":false,"context_lines":[{"line_number":1903,"context_line":"pod:"},{"line_number":1904,"context_line":"  user:"},{"line_number":1905,"context_line":"    horizon:"},{"line_number":1906,"context_line":"      uid: 42424"},{"line_number":1907,"context_line":"  affinity:"},{"line_number":1908,"context_line":"    anti:"},{"line_number":1909,"context_line":"      type:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_df3661e0","line":1906,"range":{"start_line":1906,"start_character":6,"end_line":1906,"end_character":16},"in_reply_to":"3f79a3b5_2c9f4765","updated":"2018-11-01 16:00:40.000000000","message":"Done","commit_id":"86a50ed4c40748bc4d3f9bf7fe25a3a00bb99e47"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"5d7bef99d0662f5c0e2db46cf443435bc2862f47","unresolved":false,"context_lines":[{"line_number":1903,"context_line":"pod:"},{"line_number":1904,"context_line":"  user:"},{"line_number":1905,"context_line":"    horizon:"},{"line_number":1906,"context_line":"      uid: 42424"},{"line_number":1907,"context_line":"  affinity:"},{"line_number":1908,"context_line":"    anti:"},{"line_number":1909,"context_line":"      type:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_15c28755","line":1906,"range":{"start_line":1906,"start_character":6,"end_line":1906,"end_character":16},"in_reply_to":"3f79a3b5_2c9f4765","updated":"2018-11-01 00:01:03.000000000","message":"It has to be an int per https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.10/#podsecuritycontext-v1-core","commit_id":"86a50ed4c40748bc4d3f9bf7fe25a3a00bb99e47"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"fe23254ba7af6f35c75f34acafd23cfce13d77e6","unresolved":false,"context_lines":[{"line_number":1903,"context_line":"pod:"},{"line_number":1904,"context_line":"  user:"},{"line_number":1905,"context_line":"    horizon:"},{"line_number":1906,"context_line":"      uid: 42424"},{"line_number":1907,"context_line":"  affinity:"},{"line_number":1908,"context_line":"    anti:"},{"line_number":1909,"context_line":"      type:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3f79a3b5_9d56802c","line":1906,"range":{"start_line":1906,"start_character":1,"end_line":1906,"end_character":16},"updated":"2018-12-17 16:39:33.000000000","message":"should we have a comment explaining where this is from?","commit_id":"6c451c9a1785f807ac2607ae0d75c6220103c36c"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"d2d9b9b4d6a20ec769e33e45238168d8e7835acd","unresolved":false,"context_lines":[{"line_number":1903,"context_line":"pod:"},{"line_number":1904,"context_line":"  user:"},{"line_number":1905,"context_line":"    horizon:"},{"line_number":1906,"context_line":"      uid: 42424"},{"line_number":1907,"context_line":"  affinity:"},{"line_number":1908,"context_line":"    anti:"},{"line_number":1909,"context_line":"      type:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3f79a3b5_fb3455fb","line":1906,"range":{"start_line":1906,"start_character":1,"end_line":1906,"end_character":16},"in_reply_to":"3f79a3b5_9d56802c","updated":"2018-12-18 01:11:45.000000000","message":"perhaps - but this is the same uid used for all the service. Should include in the OSH doc may be?","commit_id":"6c451c9a1785f807ac2607ae0d75c6220103c36c"}],"nova/templates/daemonset-compute.yaml":[{"author":{"_account_id":28701,"name":"Dustin Specker","email":"v-dspecker@microsoft.com","username":"dustinspecker"},"change_message_id":"a5a79d3c49c552aa6445ee88ca20db62b2eb3f0a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        - name: ceph-admin-keyring-placement"},{"line_number":77,"context_line":"{{ tuple $envAll \"nova_compute\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":78,"context_line":"          securityContext:"},{"line_number":79,"context_line":"            runAsUser: 0"},{"line_number":80,"context_line":"          command:"},{"line_number":81,"context_line":"            - /tmp/ceph-admin-keyring.sh"},{"line_number":82,"context_line":"          volumeMounts:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f79a3b5_f48fed74","side":"PARENT","line":79,"range":{"start_line":79,"start_character":12,"end_line":79,"end_character":24},"updated":"2018-10-30 18:30:32.000000000","message":"question: Will it be an issue that this uid is no longer 0/different than the other containers?","commit_id":"9d72fe1a501bc609a875eebf7b6274e18600ed70"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"0ad0d6f65ed73b8df370315501dd5d023985ff81","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        - name: ceph-admin-keyring-placement"},{"line_number":77,"context_line":"{{ tuple $envAll \"nova_compute\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":78,"context_line":"          securityContext:"},{"line_number":79,"context_line":"            runAsUser: 0"},{"line_number":80,"context_line":"          command:"},{"line_number":81,"context_line":"            - /tmp/ceph-admin-keyring.sh"},{"line_number":82,"context_line":"          volumeMounts:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3f79a3b5_9571cc16","side":"PARENT","line":79,"range":{"start_line":79,"start_character":12,"end_line":79,"end_character":24},"in_reply_to":"3f79a3b5_f48fed74","updated":"2018-10-31 07:12:14.000000000","message":"with the changes done with ceph, this job no longer needs root to run.  Let\u0027s see the gate to run first as I have rebase a few things around this.","commit_id":"9d72fe1a501bc609a875eebf7b6274e18600ed70"},{"author":{"_account_id":20889,"name":"Niketu Parekh","email":"niketu.parekh@ericsson.com","username":"niketukparekh"},"change_message_id":"501dd220c391c6aa43e58bc2d0df46cce981295b","unresolved":false,"context_lines":[{"line_number":150,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.compute | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":151,"context_line":"          securityContext:"},{"line_number":152,"context_line":"            runAsUser: {{ .Values.pod.user.nova.uid }}"},{"line_number":153,"context_line":"            privileged: true"},{"line_number":154,"context_line":"          {{- if .Values.conf.ceph.enabled }}"},{"line_number":155,"context_line":"          env:"},{"line_number":156,"context_line":"            - name: CEPH_CINDER_USER"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_546d8ccc","line":153,"updated":"2018-11-12 20:36:21.000000000","message":"privileged: true appears to be redundant and contradicting with runAsUser: 42424 (values.pod.user.nova.uid)","commit_id":"86a50ed4c40748bc4d3f9bf7fe25a3a00bb99e47"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"a377f9b542304b861c267b8954581e3edccdc07a","unresolved":false,"context_lines":[{"line_number":150,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.compute | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":151,"context_line":"          securityContext:"},{"line_number":152,"context_line":"            runAsUser: {{ .Values.pod.user.nova.uid }}"},{"line_number":153,"context_line":"            privileged: true"},{"line_number":154,"context_line":"          {{- if .Values.conf.ceph.enabled }}"},{"line_number":155,"context_line":"          env:"},{"line_number":156,"context_line":"            - name: CEPH_CINDER_USER"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3f79a3b5_1432b40f","line":153,"in_reply_to":"3f79a3b5_546d8ccc","updated":"2018-11-12 21:50:05.000000000","message":"The two are not quite contradicting, but the runAsUser is redundant since it should be loaded by the podSecPolicy - will remove.","commit_id":"86a50ed4c40748bc4d3f9bf7fe25a3a00bb99e47"}]}