)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a01ea9aadef253eef41b4f5cc3c1cc23d373bdf3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"and leveraged the helm-toolkit"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: Id0fe9b75432076d0b87e89dcaa5a4b88487972aa"},{"line_number":13,"context_line":"Depends-On: I49fa7330f087e806ee0601f104706b762046535d"},{"line_number":14,"context_line":"Change-Id: I15333df4707948e50deb935ffc1ee599588e4788"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3f79a3b5_cb51a433","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":53},"updated":"2018-11-19 16:12:37.000000000","message":"This change has been abandoned. Can you amend the commit message to remove this line?","commit_id":"246b14ccbbfd4c4aaca20137821f9906a8532440"},{"author":{"_account_id":8898,"name":"Chris Wedgwood","email":"cw@f00f.org","username":"anticw"},"change_message_id":"cb3312fc4c6de3655677b499ebc96389d3007253","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     9d72fe1a (Imported Translations from Zanata)"},{"line_number":2,"context_line":"Author:     oshnew \u003coshnew@ubuntu.att.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2018-10-26 20:23:53 -0500"},{"line_number":4,"context_line":"Commit:     rk0850 \u003crk0850@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-12-06 03:18:13 -0600"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3f79a3b5_01f95f1b","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":42},"updated":"2018-12-07 16:05:23.000000000","message":"is that valid?","commit_id":"6423107d62317e33fe205077d67cf402a098e05b"},{"author":{"_account_id":29161,"name":"Rahul Khiyani","email":"rahul.khiyani@att.com","username":"rk0850"},"change_message_id":"2eceb4abde86e823f357958b5ac36906a54ad49f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     9d72fe1a (Imported Translations from Zanata)"},{"line_number":2,"context_line":"Author:     oshnew \u003coshnew@ubuntu.att.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2018-10-26 20:23:53 -0500"},{"line_number":4,"context_line":"Commit:     rk0850 \u003crk0850@att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-12-06 03:18:13 -0600"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3f79a3b5_e4f6b1d6","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":42},"in_reply_to":"3f79a3b5_01f95f1b","updated":"2018-12-07 16:18:06.000000000","message":"Sorry, It is not valid. Something went wrong I will change it. Thanks for reviewing it.","commit_id":"6423107d62317e33fe205077d67cf402a098e05b"}],"keystone/templates/deployment-api.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"6d3e0aa71a7953068ab0da64f347b71744a7ce17","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        - name: keystone-api"},{"line_number":59,"context_line":"{{ tuple $envAll \"keystone_api\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":60,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.api | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":61,"context_line":"          securityContext:"},{"line_number":62,"context_line":"            allowPrivilegeEscalation: false"},{"line_number":63,"context_line":"          command:"},{"line_number":64,"context_line":"            - /tmp/keystone-api.sh"},{"line_number":65,"context_line":"            - start"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_0c250f16","line":62,"range":{"start_line":61,"start_character":0,"end_line":62,"end_character":43},"updated":"2018-12-07 22:33:20.000000000","message":"could we have this as a blanket policy on the pod?","commit_id":"d0e7494996532de305be65ba628950b205e673c4"},{"author":{"_account_id":29161,"name":"Rahul Khiyani","email":"rahul.khiyani@att.com","username":"rk0850"},"change_message_id":"d9ed5ab47fc1bb2a540d1c0d788bc0e1bd8b3efc","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        - name: keystone-api"},{"line_number":59,"context_line":"{{ tuple $envAll \"keystone_api\" | include \"helm-toolkit.snippets.image\" | indent 10 }}"},{"line_number":60,"context_line":"{{ tuple $envAll $envAll.Values.pod.resources.api | include \"helm-toolkit.snippets.kubernetes_resources\" | indent 10 }}"},{"line_number":61,"context_line":"          securityContext:"},{"line_number":62,"context_line":"            allowPrivilegeEscalation: false"},{"line_number":63,"context_line":"          command:"},{"line_number":64,"context_line":"            - /tmp/keystone-api.sh"},{"line_number":65,"context_line":"            - start"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3f79a3b5_5f5b6e87","line":62,"range":{"start_line":61,"start_character":0,"end_line":62,"end_character":43},"in_reply_to":"3f79a3b5_0c250f16","updated":"2018-12-11 15:08:22.000000000","message":"Done","commit_id":"d0e7494996532de305be65ba628950b205e673c4"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"5efd7ae29655291f04b55e5226538c8ba82c94b1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":46,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":47,"context_line":"    spec:"},{"line_number":48,"context_line":"      securityContext:"},{"line_number":49,"context_line":"        allowPrivilegeEscalation: false"},{"line_number":50,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"keystone\" | include \"helm-toolkit.snippets.kubernetes_pod_security_context\" | indent 6 }}"},{"line_number":51,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":52,"context_line":"      affinity:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3f79a3b5_26779b3e","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":39},"updated":"2018-12-11 03:53:17.000000000","message":"this should be accounted for by the snippet below, else we have two securityContext: keys?","commit_id":"e2b9fe253b4626274a3d410c9050a834a6825da5"},{"author":{"_account_id":29161,"name":"Rahul Khiyani","email":"rahul.khiyani@att.com","username":"rk0850"},"change_message_id":"6974c70de0351bff6e39add150d73e8386573014","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        configmap-bin-hash: {{ tuple \"configmap-bin.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":46,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":47,"context_line":"    spec:"},{"line_number":48,"context_line":"      securityContext:"},{"line_number":49,"context_line":"        allowPrivilegeEscalation: false"},{"line_number":50,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"keystone\" | include \"helm-toolkit.snippets.kubernetes_pod_security_context\" | indent 6 }}"},{"line_number":51,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":52,"context_line":"      affinity:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3f79a3b5_1c774e3e","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":39},"in_reply_to":"3f79a3b5_26779b3e","updated":"2018-12-11 06:37:33.000000000","message":"Thanks for reviewing. This will be accounted for all the containers. There is no need to add another security context for containers.","commit_id":"e2b9fe253b4626274a3d410c9050a834a6825da5"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"5efd7ae29655291f04b55e5226538c8ba82c94b1","unresolved":false,"context_lines":[{"line_number":170,"context_line":"          secretName: keystone-credential-keys"},{"line_number":171,"context_line":"{{ if $mounts_keystone_api.volumes }}{{ toYaml $mounts_keystone_api.volumes | indent 6 }}{{ end }}"},{"line_number":172,"context_line":"{{- end }}"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3f79a3b5_66d27334","line":173,"range":{"start_line":173,"start_character":0,"end_line":173,"end_character":0},"updated":"2018-12-11 03:53:17.000000000","message":"extra EOF line space","commit_id":"e2b9fe253b4626274a3d410c9050a834a6825da5"},{"author":{"_account_id":29161,"name":"Rahul Khiyani","email":"rahul.khiyani@att.com","username":"rk0850"},"change_message_id":"4d795e4272dd95610bb8e2621b632fb5fe0f55d3","unresolved":false,"context_lines":[{"line_number":170,"context_line":"          secretName: keystone-credential-keys"},{"line_number":171,"context_line":"{{ if $mounts_keystone_api.volumes }}{{ toYaml $mounts_keystone_api.volumes | indent 6 }}{{ end }}"},{"line_number":172,"context_line":"{{- end }}"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3f79a3b5_7c91a243","line":173,"range":{"start_line":173,"start_character":0,"end_line":173,"end_character":0},"in_reply_to":"3f79a3b5_66d27334","updated":"2018-12-11 06:39:14.000000000","message":"I will delete the trailing white spaces.","commit_id":"e2b9fe253b4626274a3d410c9050a834a6825da5"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"f05397c3da4d363ce7ca89ba6f6e22c2d88382e5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":47,"context_line":"    spec:"},{"line_number":48,"context_line":"      securityContext:"},{"line_number":49,"context_line":"        allowPrivilegeEscalation: false"},{"line_number":50,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"keystone\" | include \"helm-toolkit.snippets.kubernetes_pod_security_context\" | indent 6 }}"},{"line_number":51,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":52,"context_line":"      affinity:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3f79a3b5_00676725","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":39},"updated":"2018-12-17 17:05:24.000000000","message":"Shouldn\u0027t this be handled via the helm-toolkit template? The helm-toolkit template should render the securityContext key along with the mapped values associated with it https://github.com/openstack/openstack-helm-infra/blob/master/helm-toolkit/templates/snippets/_kubernetes_pod_security_context.tpl#L41-L46","commit_id":"9b526cab29b5fedc74ef286580f0cea44f2e3c0c"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"fcaf43292582cea9000715ee2c1a605dc16dc444","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":47,"context_line":"    spec:"},{"line_number":48,"context_line":"      securityContext:"},{"line_number":49,"context_line":"        allowPrivilegeEscalation: false"},{"line_number":50,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"keystone\" | include \"helm-toolkit.snippets.kubernetes_pod_security_context\" | indent 6 }}"},{"line_number":51,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":52,"context_line":"      affinity:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3f79a3b5_2028639c","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":39},"in_reply_to":"3f79a3b5_00676725","updated":"2018-12-17 17:06:45.000000000","message":"Or, should this be under the container key instead?","commit_id":"9b526cab29b5fedc74ef286580f0cea44f2e3c0c"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"ff33c0e657e2bb8a86da25d312bb02637c8d80c9","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":47,"context_line":"    spec:"},{"line_number":48,"context_line":"      securityContext:"},{"line_number":49,"context_line":"        allowPrivilegeEscalation: false"},{"line_number":50,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"keystone\" | include \"helm-toolkit.snippets.kubernetes_pod_security_context\" | indent 6 }}"},{"line_number":51,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":52,"context_line":"      affinity:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3f79a3b5_7bf9251b","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":39},"in_reply_to":"3f79a3b5_2028639c","updated":"2018-12-18 01:15:23.000000000","message":"++. This along with the snippet on L50 will get you two securityContext key and a malformed yaml, should have this moved to the values.yaml so it renders.","commit_id":"9b526cab29b5fedc74ef286580f0cea44f2e3c0c"},{"author":{"_account_id":18204,"name":"bharani","email":"bk160f@att.com","username":"bharani"},"change_message_id":"122ddaa20afc9982b0c3e3b5c7890228ae06ce57","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        configmap-etc-hash: {{ tuple \"configmap-etc.yaml\" . | include \"helm-toolkit.utils.hash\" }}"},{"line_number":47,"context_line":"    spec:"},{"line_number":48,"context_line":"      securityContext:"},{"line_number":49,"context_line":"        allowPrivilegeEscalation: false"},{"line_number":50,"context_line":"{{ dict \"envAll\" $envAll \"application\" \"keystone\" | include \"helm-toolkit.snippets.kubernetes_pod_security_context\" | indent 6 }}"},{"line_number":51,"context_line":"      serviceAccountName: {{ $serviceAccountName }}"},{"line_number":52,"context_line":"      affinity:"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3f79a3b5_61cc165f","line":49,"range":{"start_line":49,"start_character":8,"end_line":49,"end_character":39},"in_reply_to":"3f79a3b5_7bf9251b","updated":"2018-12-18 03:16:14.000000000","message":"DO we really need allowPrivilegeEscalation key/flag to be moved to Pod level securityCOntext?","commit_id":"9b526cab29b5fedc74ef286580f0cea44f2e3c0c"}]}